[00:25:26] (03CR) 10Jforrester: [C: 032] Diacritic insensitive search in find & replace dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/339932 (https://phabricator.wikimedia.org/T154195) (owner: 10Esanders) [00:25:34] (03CR) 10Jforrester: [C: 032] Pass $overlay to FieldsetLayout and FieldLayout in various places [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338041 (https://phabricator.wikimedia.org/T100571) (owner: 10Bartosz Dziewoński) [00:28:04] (03Merged) 10jenkins-bot: Diacritic insensitive search in find & replace dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/339932 (https://phabricator.wikimedia.org/T154195) (owner: 10Esanders) [00:28:38] (03PS1) 10Jforrester: Update VE core submodule to master (15f36bc75) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340446 (https://phabricator.wikimedia.org/T149821) [00:32:34] (03CR) 10jenkins-bot: Diacritic insensitive search in find & replace dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/339932 (https://phabricator.wikimedia.org/T154195) (owner: 10Esanders) [00:33:27] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 10OOjs-UI, 07Browser-Support-Firefox: Blurry icons in the Transclusion dialog - https://phabricator.wikimedia.org/T132862#3063215 (10Volker_E) 05Open>03Invalid No activity on this task for 10 months, excluding my last comme... [00:33:31] (03PS2) 10Jforrester: Update VE core submodule to master (8211ebc70) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/339933 (https://phabricator.wikimedia.org/T154195) (owner: 10Esanders) [00:35:07] (03Merged) 10jenkins-bot: Pass $overlay to FieldsetLayout and FieldLayout in various places [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338041 (https://phabricator.wikimedia.org/T100571) (owner: 10Bartosz Dziewoński) [00:39:10] (03CR) 10jenkins-bot: Pass $overlay to FieldsetLayout and FieldLayout in various places [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338041 (https://phabricator.wikimedia.org/T100571) (owner: 10Bartosz Dziewoński) [00:40:51] 10VisualEditor: Table appears broken in IE 11 after deleting text from a table cell - https://phabricator.wikimedia.org/T159294#3063222 (10Ryasmeen) [00:49:43] 10VisualEditor, 10VisualEditor-EditingTools: Problems with scrolling in the "Options" dialog make some tooltips drop of the displayed dialog - https://phabricator.wikimedia.org/T100571#3063249 (10Jdforrester-WMF) 05Open>03Resolved Lovely! [00:51:26] 10VisualEditor: Visual Diff does not show changes related with "Comment" - https://phabricator.wikimedia.org/T149821#3063257 (10Jdforrester-WMF) [00:51:34] 10VisualEditor: Fix whitespace errors in visual diffs - https://phabricator.wikimedia.org/T158895#3063259 (10Jdforrester-WMF) [00:53:09] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (8211ebc70) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/339933 (https://phabricator.wikimedia.org/T154195) (owner: 10Esanders) [01:05:22] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor maps-related error - https://phabricator.wikimedia.org/T159295#3063269 (10Tgr) [01:07:02] (03CR) 10Jforrester: [C: 032] Move article edit switching tools to articleTarget module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340440 (owner: 10Esanders) [01:07:42] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor deletes text on section editing conflict - https://phabricator.wikimedia.org/T159296#3063282 (10Tgr) [01:16:02] (03Merged) 10jenkins-bot: Move article edit switching tools to articleTarget module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340440 (owner: 10Esanders) [01:21:38] (03CR) 10jenkins-bot: Move article edit switching tools to articleTarget module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340440 (owner: 10Esanders) [01:36:00] 10VisualEditor: [Regression] Cursor does not go to the next line on pressing Return after adding a section heading - https://phabricator.wikimedia.org/T158259#3063400 (10Ryasmeen) Yeah, we shouldn't have multiple subject lines. Hmm..From a UI perspective it looks similar to adding a page heading in visual edit... [04:00:30] 10VisualEditor, 10VisualEditor-MediaWiki: Better error message for VisualEditor when php7.0-curl package is missing - https://phabricator.wikimedia.org/T153953#3063562 (10Legoktm) No, not via extension.json. I would recommend just adding a `if !extension_loaded('curl') { throw new Exception('curl is missing!')... [04:28:02] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, and 4 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3063575 (10dchen) Ass... [07:50:23] hi everyone! I am trying to set up the visual editor. have been trying to get parsoid installed but when I run sudo yum advanced --keyserver keys.gnupg.net --recv-keys 90E9F83F22250DD7 [07:50:50] i get a huge list of commands and then it says Command line error: no such option: --keyserver [07:51:04] im running red hat on centos 6.8 [08:22:47] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor deletes text on section editing conflict - https://phabricator.wikimedia.org/T159296#3063756 (10Dvorapa) [08:22:50] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Urbanecm: Page blanked when editing a section after an edit conflict - https://phabricator.wikimedia.org/T154217#3063758 (10Dvorapa) [08:23:00] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, and 4 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3063759 (10Pginer-WMF... [08:23:51] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Urbanecm: Page blanked when editing a section after an edit conflict - https://phabricator.wikimedia.org/T154217#2904393 (10Dvorapa) 05duplicate>03Open [08:24:07] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Urbanecm: Page blanked when editing a section after an edit conflict - https://phabricator.wikimedia.org/T154217#2904393 (10Dvorapa) [08:24:09] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor deletes text on section editing conflict - https://phabricator.wikimedia.org/T159296#3063282 (10Dvorapa) [08:25:04] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Urbanecm: Page blanked when editing a section after an edit conflict - https://phabricator.wikimedia.org/T154217#3063769 (10Dvorapa) Steps to reproduce by @Tgr: * open single section for editing in NEW * generate mergeable edit conflict (try... [09:07:05] guys when setting up parsod do I have to do anything else to the files? I am trying to rested after editing bot files to point to my domain and I get the error: service parsoid restart parsoid: unrecognized service [10:59:56] 10VisualEditor: VE seems to be able to "add" links to files that are (probably) stored on the editors' local hard drives - https://phabricator.wikimedia.org/T155460#3064065 (10Amire80) Another example: https://he.wikipedia.org/w/index.php?title=%D7%98%D7%99%D7%95%D7%98%D7%94:%D7%9B%D7%99%D7%91%D7%95%D7%A9_%D7%90... [11:49:03] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Russian-Sites: Update the Russian Wikipedia's wikifier gadget work with VisualEditor's wikitext mode - https://phabricator.wikimedia.org/T156025#3064159 (10MarcoAurelio) [12:39:50] (03PS1) 10Esanders: Cleanup DesktopTarget styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340497 [14:11:45] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (15f36bc75) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340446 (https://phabricator.wikimedia.org/T149821) (owner: 10Jforrester) [14:21:52] (03Merged) 10jenkins-bot: Update VE core submodule to master (15f36bc75) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340446 (https://phabricator.wikimedia.org/T149821) (owner: 10Jforrester) [14:21:54] (03Merged) 10jenkins-bot: Update VE core submodule to master (8211ebc70) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/339933 (https://phabricator.wikimedia.org/T154195) (owner: 10Esanders) [14:30:05] (03CR) 10jenkins-bot: Update VE core submodule to master (15f36bc75) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340446 (https://phabricator.wikimedia.org/T149821) (owner: 10Jforrester) [14:31:34] 10VisualEditor: Private wikis can only be used if LocalSettings.php is set to English with $wgLanguageCode = "en"; ? - https://phabricator.wikimedia.org/T155447#3064470 (10Maalab) My problem have been solved. See https://phabricator.wikimedia.org/T123471. Thanks! [14:36:23] (03CR) 10jenkins-bot: Update VE core submodule to master (8211ebc70) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/339933 (https://phabricator.wikimedia.org/T154195) (owner: 10Esanders) [14:47:44] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Wikimedia-Hackathon-2017, 06Community-Liaisons (Apr-Jun 2017): Discover TemplateData at Vienna Hackathon - https://phabricator.wikimedia.org/T155626#3064535 (10Trizek-WMF) 05Open>03declined That task may not fit with the Vienna hackatho... [14:47:46] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Community-Liaisons: Help some smaller Wikipedias' communities (which?) by writing the TemplateData and enabling citoid for them - https://phabricator.wikimedia.org/T127354#3064538 (10Trizek-WMF) [15:33:56] 10VisualEditor, 10VisualEditor-MediaWiki: Preformatted text no longer directly editable, displays without newlines and opens an inspector for editing - https://phabricator.wikimedia.org/T159231#3064617 (10matmarex) >>! In T159230#3062862, @Etonkovidova wrote: > @matmarex re {T159231} - I thought the inspector... [15:49:31] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Community-Liaisons: Help some smaller Wikipedias' communities (which?) by writing the TemplateData and enabling citoid for them - https://phabricator.wikimedia.org/T127354#3064658 (10Mvolz) There's a related outreachy project requesting this... [15:52:33] 10VisualEditor, 10VisualEditor-MediaWiki: Preformatted text no longer directly editable, displays without newlines and opens an inspector for editing - https://phabricator.wikimedia.org/T159231#3064663 (10matmarex) Yeah, this looks suspicious: {79ccfb9372cb57afa569036ef39ead13abfba673} Our ve.dm.MWPreformatte... [15:52:52] (03PS1) 10Amritsreekumar: Remove button for from toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/340515 [15:53:04] (03CR) 10jerkins-bot: [V: 04-1] Remove button for from toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/340515 (owner: 10Amritsreekumar) [15:56:38] 10VisualEditor, 10VisualEditor-MediaWiki: Preformatted text no longer directly editable, displays without newlines and opens an inspector for editing - https://phabricator.wikimedia.org/T159231#3064672 (10matmarex) (But we still need to match a plain `
` tag too. Indented code still uses that. https://en.w...
[16:02:59] 	 (03Abandoned) 10Amritsreekumar: Remove button for  from toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/340515 (owner: 10Amritsreekumar)
[16:08:08] 	 10VisualEditor, 10VisualEditor-MediaWiki: Preformatted text no longer directly editable, displays without newlines and opens an inspector for editing - https://phabricator.wikimedia.org/T159231#3064697 (10matmarex) a:03matmarex
[16:20:06] 	 (03PS1) 10Amritsreekumar: Remove button for  from toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/340518
[16:20:19] 	 (03CR) 10jerkins-bot: [V: 04-1] Remove button for  from toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/340518 (owner: 10Amritsreekumar)
[16:50:03] 	 10VisualEditor, 10VisualEditor-EditingTools, 07Design, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Find/Replace (in-editor text search) should be diacritic-insensitive - https://phabricator.wikimedia.org/T154195#3064887 (10Jdforrester-WMF) 05Open>03Resolved a:03Jdforrester-WMF
[16:53:25] 	 (03CR) 10Jforrester: Cleanup DesktopTarget styles (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340497 (owner: 10Esanders)
[18:30:02] 	 (03CR) 10Esanders: [C: 04-1] "not sure there is consensus on the ticket" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/340518 (owner: 10Amritsreekumar)
[19:28:04] 	 10VisualEditor, 06Collaboration-Team-Triage, 10Flow: Insert a reference from the VE References tooltip on Flow is not possible on Beta labs - https://phabricator.wikimedia.org/T159364#3065455 (10Catrope)
[19:48:11] 	 10VisualEditor, 07Regression: [Regression pre-wmf.15] Cannot add any citation, getting error in the console "Uncaught TypeError: Cannot read property '$element' of null" - https://phabricator.wikimedia.org/T159278#3065553 (10Ryasmeen) Ok this doesn't happen the first time I add citation to a page. Add one and...
[19:51:02] 	 (03PS1) 10Bartosz Dziewoński: ve.dm.MWPreformattedNode: Update matching for Parsoid changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340554 (https://phabricator.wikimedia.org/T159231)
[19:56:45] 	 (03PS1) 10Bartosz Dziewoński: ve.ce.ContentBranchNode: Don't set 'white-space: normal' on `
` tags [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340555 (https://phabricator.wikimedia.org/T159231)
[19:57:42] 	 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, and 4 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3065583 (10jmatazzoni...
[19:58:12] 	 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: Preformatted text no longer directly editable, displays without newlines and opens an inspector for editing - https://phabricator.wikimedia.org/T159231#3065586 (10matmarex) The first patch should fix the editability/inspector behavior, and the sec...
[19:59:01] 	 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: Preformatted text no longer directly editable, displays without newlines and opens an inspector for editing - https://phabricator.wikimedia.org/T159231#3065588 (10matmarex) I've been testing both with this example: https://en.wikipedia.org/w/index...
[19:59:30] 	 10VisualEditor, 10VisualEditor-EditingTools, 07Design, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Find/Replace (in-editor text search) should be diacritic-insensitive - https://phabricator.wikimedia.org/T154195#3065589 (10Pginer-WMF) I'd appreciate getting some feedback on the proposal on T154195#3060546 fro...
[20:10:33] 	 10VisualEditor: Getting error "Cannot read property 'target' of undefined" while opening VE from section edit link - https://phabricator.wikimedia.org/T159374#3065658 (10Ryasmeen)
[20:20:13] 	 10VisualEditor: Getting error "Uncaught TypeError: Cannot read property 'getToolbarDialogs' of null" in the console while adding a new section with NWE - https://phabricator.wikimedia.org/T159377#3065719 (10Ryasmeen)
[20:21:20] 	 10VisualEditor: Getting error "Cannot read property 'target' of undefined" while opening VE from section edit link - https://phabricator.wikimedia.org/T159374#3065735 (10Ryasmeen) The second error also appears when adding new section using NWE, so I reported a separate issue on it here  T159377
[20:38:12] 	 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, and 4 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3065769 (10Jdforrester...
[21:14:05] 	 (03PS1) 10Esanders: DiffElement: Fix remaining class->data-attribute conversions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340577
[21:17:33] 	 [13grunt-banana-checker] 15legoktm opened pull request #55: Allow skipping keys that don't have message documentation (fixes #54) (06master...06exempt) 02https://github.com/wikimedia/grunt-banana-checker/pull/55
[21:22:04] 	 (03CR) 10jerkins-bot: [V: 04-1] DiffElement: Fix remaining class->data-attribute conversions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340577 (owner: 10Esanders)
[21:25:33] 	 10VisualEditor, 10VisualEditor-ContentEditable: Annotation destroyed, then throws exception when undo-ing - https://phabricator.wikimedia.org/T159384#3065947 (10Esanders)
[21:25:40] 	 10VisualEditor, 10VisualEditor-ContentEditable: Annotation destroyed, then throws exception when undo-ing - https://phabricator.wikimedia.org/T159384#3065960 (10Esanders) p:05Triage>03High
[21:39:21] 	 10VisualEditor, 10VisualEditor-ContentEditable: Text destroyed, then throws exception when undo-ing - https://phabricator.wikimedia.org/T159384#3065985 (10Esanders)
[21:39:47] 	 10VisualEditor, 10VisualEditor-ContentEditable: Text destroyed, then throws exception when undo-ing - https://phabricator.wikimedia.org/T159384#3065947 (10Esanders) This happens no matter what the first paragraph starts with. It looks like it's deleting a fixed amount of text.
[21:45:41] 	 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, and 4 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3065992 (10Dvorapa) @...
[21:45:58] 	 (03PS2) 10Esanders: DiffElement: Fix remaining class->data-attribute conversions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340577
[21:48:56] 	 (03CR) 10jerkins-bot: [V: 04-1] DiffElement: Fix remaining class->data-attribute conversions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340577 (owner: 10Esanders)
[21:51:44] 	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340634 (owner: 10L10n-bot)
[21:52:35] 	 (03PS1) 10Esanders: DiffElement: De-clutter left margin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340647
[21:55:46] 	 (03CR) 10jerkins-bot: [V: 04-1] DiffElement: De-clutter left margin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340647 (owner: 10Esanders)
[21:57:43] 	 (03PS3) 10Esanders: WIP diff attribute changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160
[21:59:32] 	 (03CR) 10jerkins-bot: [V: 04-1] WIP diff attribute changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 (owner: 10Esanders)
[22:03:31] 	 [13grunt-banana-checker] 15Krinkle closed pull request #55: Allow skipping keys that don't have message documentation (fixes #54) (06master...06exempt) 02https://github.com/wikimedia/grunt-banana-checker/pull/55
[22:12:46] 	 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, and 4 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3066058 (10Catrope) >...
[22:14:54] 	 [13grunt-banana-checker] 15Krinkle created 06release (+1 new commit): 02https://github.com/wikimedia/grunt-banana-checker/commit/2c5b4f9ff74e
[22:14:54] 	 13grunt-banana-checker/06release 142c5b4f9 15Timo Tijhof: Tag v0.6.0
[22:17:44] 	 [13grunt-banana-checker] 15Krinkle merged 06release into 06master: 02https://github.com/wikimedia/grunt-banana-checker/compare/7395e3287d49...2c5b4f9ff74e
[22:17:51] 	 [13grunt-banana-checker] 15Krinkle 04deleted 06release at 142c5b4f9: 02https://github.com/wikimedia/grunt-banana-checker/commit/2c5b4f9
[22:18:09] 	 [13grunt-banana-checker] 15Krinkle tagged 06v0.6.0 at 1476b177f: 02https://github.com/wikimedia/grunt-banana-checker/commits/v0.6.0
[22:23:36] 	 10VisualEditor, 10VisualEditor-MediaWiki, 06Collaboration-Team-Triage, 10Flow: Can't edit preformatted text using visual editor - https://phabricator.wikimedia.org/T159230#3066067 (10matmarex) OK, actually, this is quite a mess. Let's handle it on T159231, I'll copy the relevant parts there.  For Flow: thi...
[22:31:26] 	 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: Preformatted text no longer directly editable, displays without newlines and opens an inspector for editing - https://phabricator.wikimedia.org/T159231#3066094 (10matmarex) So, this is actually not so easy. If https://gerrit.wikimedia.org/r/340554...
[22:31:50] 	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Causes more issues. See T159231." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340554 (https://phabricator.wikimedia.org/T159231) (owner: 10Bartosz Dziewoński)
[22:32:02] 	 edsanders: i could use your advice on https://phabricator.wikimedia.org/T159231
[22:35:26] 	 hm
[22:35:57] 	 
	 TBF our previous "support" for pre tags was poor
[22:36:46] 	 we treated then as content branch nodes, but that meant you couldn't have a multi-line pre
[22:37:52] 	 it is new
[22:38:02] 	 i linked the parsoid commit that introduced it in the task somewhere
[22:38:05] 	 this seems better I think
[22:38:59] 	 edsanders: currently, parsoid HTML `
` corresponds to wikitext `
`. parsoid HTML `
` corresponds to wikitext one-space indent.
[22:39:12] 	 ok
[22:39:33] 	 edsanders: the difference between wikitext `
` and wikitext one-space indent is that the former can't have any formatting. it's just plain text. the latter can have bolding, even images etc.
[22:39:51] 	 yup
[22:39:53] 	 and this sounds pretty problematic for VE's preformatted text support
[22:40:29] 	 yes - I guess wikitext 
 should be avoided?
[22:40:48] 	 I would've though  would be used in most cases
[22:41:07] 	 yeah, i think 
 is a lot saner than the indent. so ideally we'd use that, if possible
[22:41:22] 	 but we need to do something sensible when the user starts bolding preformatted text
[22:41:36] 	 I don't think so
[22:42:16] 	 If the users wants rich text with preformatted spacing, they use preformatted from the dropdown (which generates one space indent). If the user wants plain text, they use SyntaxHighlight plugin
[22:42:51] 	 we could write a base version that uses 
 for users that haven't installed that plugin
[22:43:03] 	 even if you want to disallow/discourage them in new content, there are still existing 
 tags on pages that need to be handled
[22:43:04] 	 hmm
[22:43:20] 	 so you want to split these two cases completely?
[22:43:32] 	 we could even modify SyntaxHighlight to have a no-language mode that outputs 
s
[22:43:48] 	 I think we have to, because wikitext
[22:44:25] 	 we can heavily hide the '
' in wikitext to discourage it, but for round-tripping it needs to be handled as it is now
[22:44:38] 	 in fact how it is now isn't even *that* bad
[22:45:19] 	 I don't know how it was before, but I imagine if you tried to add formatting to one of those blocks, then bad things happened?
[22:45:44] 	 i'm not sure if parsoid was able to handle that
[22:45:58] 	 actually I have an old Parsoid locally...
[22:46:32] 	 how it is right now is acceptable, i guess. but i think the interface we had previously (with the preformatted text editable inline) is a lot nicer than a popup inspector.
[22:46:35] 	 Yeah, VE would let you make text bold, and show it as such
[22:46:42] 	 but then on saving you'd see wikitext '''
[22:46:59] 	 so this is an improvment, but for the fact it is using an AlienExtension dialog
[22:46:59] 	 but if we actually make a decision to change from that to an inspector, that'd be fine i guess
[22:47:04] 	 *inspector
[22:47:40] 	 I even had a vague plan to move syntax highlight support up to core
[22:47:59] 	 as in VE-core
[22:48:07] 	 if we add a button to convert it to "annotatable preformatted text", that'd be actually pretty okay
[22:48:26] 	 yeah - seems ok
[22:49:19] 	 *although* - I think we still have problems with linebreaks and single space preformatted
[22:50:04] 	 I think have to press shift+enter to avoid splitting the pre
[22:50:25] 	 yeah
[22:50:28] 	 ...but that doesn't work on the last line
[22:50:35] 	 so if you create a new one you can't extend it
[22:51:44] 	 that's silly. it sounds like you want to fix it ;)
[22:51:52] 	 edsanders: ok, thanks, that was helpful. i'll summarize on the task
[22:53:13] 	 edsanders: also, a question – this thing: ve.dm.MWPreformattedNode.static.suggestedParentNodeTypes = [ 'document', 'tableCell' ]; – why do we need it? (what are example parent node types where we *do not* want preformatted text to be inserted?) blaming did not help me find out
[22:53:47] 	 we have the exact same thing for MWHeadingNode, and nothing else
[22:54:57] 	 listItems
[22:55:36] 	 * === foo === doesn't work
[22:56:02] 	 nor does *    foo
[22:56:03] 	 aha, okay. thanks
[22:56:18] 	 but only in wikitext, in regular html you can have 
  •  no problem
[23:03:55] 	 you could add a comment if that information has been lost to time
[23:04:23] 	 i think it's in the mwHeading tests though
[23:04:35] 	 not that you'd know to look there
[23:06:19] 	 (03PS1) 10Tchanders: WIP Clean up DiffElement logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340656 (https://phabricator.wikimedia.org/T149537)
[23:09:48] 	 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: Preformatted text no longer directly editable, displays without newlines and opens an inspector for editing - https://phabricator.wikimedia.org/T159231#3066144 (10matmarex) After talking with Ed: we should probably keep this mostly as it currently...
[23:09:59] 	 (03CR) 10jerkins-bot: [V: 04-1] WIP Clean up DiffElement logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340656 (https://phabricator.wikimedia.org/T149537) (owner: 10Tchanders)
[23:12:08] 	 (03PS1) 10Bartosz Dziewoński: Document usages of ve.dm.Node.static.suggestedParentNodeTypes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340658
[23:12:19] 	 edsanders: comments added ^
[23:12:47] 	 (03CR) 10Esanders: WIP Clean up DiffElement logic (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340656 (https://phabricator.wikimedia.org/T149537) (owner: 10Tchanders)
[23:14:25] 	 (03CR) 10Esanders: [C: 032] Document usages of ve.dm.Node.static.suggestedParentNodeTypes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340658 (owner: 10Bartosz Dziewoński)
[23:15:37] 	 edsanders: i'll finish this tomorrow. you could probably merge https://gerrit.wikimedia.org/r/340555 in the meantime, it fixes the broken whitespace
[23:17:01] 	 (03CR) 10Esanders: [C: 032] ve.ce.ContentBranchNode: Don't set 'white-space: normal' on `
    ` tags [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340555 (https://phabricator.wikimedia.org/T159231) (owner: 10Bartosz Dziewoński)
[23:21:30] 	 (03Merged) 10jenkins-bot: ve.ce.ContentBranchNode: Don't set 'white-space: normal' on `
    ` tags [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340555 (https://phabricator.wikimedia.org/T159231) (owner: 10Bartosz Dziewoński)
[23:24:48] 	 (03CR) 10jenkins-bot: ve.ce.ContentBranchNode: Don't set 'white-space: normal' on `
    ` tags [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340555 (https://phabricator.wikimedia.org/T159231) (owner: 10Bartosz Dziewoński)
[23:26:46] 	 (03Merged) 10jenkins-bot: Document usages of ve.dm.Node.static.suggestedParentNodeTypes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340658 (owner: 10Bartosz Dziewoński)
[23:34:20] 	 (03CR) 10jenkins-bot: Document usages of ve.dm.Node.static.suggestedParentNodeTypes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340658 (owner: 10Bartosz Dziewoński)
[23:35:05] 	 (03PS3) 10Jforrester: DiffElement: Fix remaining class->data-attribute conversions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340577 (owner: 10Esanders)
[23:35:53] 	 (03CR) 10Jforrester: [C: 032] "PS3: Actually made the corresponding unit test change. ;-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340577 (owner: 10Esanders)
[23:36:08] 	 (03PS2) 10Jforrester: DiffElement: De-clutter left margin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340647 (owner: 10Esanders)
[23:39:39] 	 (03PS3) 10Jforrester: DiffElement: De-clutter left margin, removing the blue border [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340647 (owner: 10Esanders)
[23:39:44] 	 (03CR) 10Jforrester: [C: 032] DiffElement: De-clutter left margin, removing the blue border [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340647 (owner: 10Esanders)
[23:40:00] 	 (03Merged) 10jenkins-bot: DiffElement: Fix remaining class->data-attribute conversions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340577 (owner: 10Esanders)
[23:43:10] 	 (03Merged) 10jenkins-bot: DiffElement: De-clutter left margin, removing the blue border [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340647 (owner: 10Esanders)
[23:43:36] 	 (03CR) 10jenkins-bot: DiffElement: Fix remaining class->data-attribute conversions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340577 (owner: 10Esanders)
[23:45:48] 	 (03CR) 10jenkins-bot: DiffElement: De-clutter left margin, removing the blue border [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340647 (owner: 10Esanders)