[00:12:55] Ha but this was easily fixed [00:13:15] DesktopContext was calling toggle( true ) on the popup while the popup's parent was still hidden, which breaks FloatableElement's centering [00:16:30] edsanders: Timo suggested wrapping ve-ui-init-desktopArticleTarget-sectionTitle inputs in an

(or whatever) with font-family:inherit, rather than hard-coding it from the skin manually. Sound sane? [00:26:31] Ugh [00:26:35] So my patch both does and doesn't fix the bug [00:27:09] https://usercontent.irccloud-cdn.com/file/An3Z8kNp/context-half-fixed.png [00:27:24] The popup is positioned correctly but it still pushes out the side of the document [00:27:43] Which is because it's using margins to correct for running off the end of the container [00:28:27] https://usercontent.irccloud-cdn.com/file/la1tDmsx/context-magin.png [00:28:48] Ugh ignore that, I was trying to screenshot the margin being highlighted but failed [00:29:23] So... I guess we might have to not use margins for this :/ [00:30:31] I was using margins because I was trying to avoid overriding Floatable's left/right setting [00:49:08] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 06Editing-Department, 10MobileFrontend, 07Technical-Debt: VisualEditorOverlay should be written as an OO.ui.ProcessDialog - https://phabricator.wikimedia.org/T88559#3069726 (10Jdforrester-WMF) [00:49:12] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 06Editing-Department, 10MobileFrontend: Rewrite VisualEditorOverlay header using OOjs UI - https://phabricator.wikimedia.org/T96187#3069723 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders This is definitely long-done now. [00:50:57] 10VisualEditor, 10VisualEditor-Tables, 15User-Ryasmeen, 07Verified, and 3 others: Cursor in active table cell causes exception if that cell is then removed (e.g. by undo) - https://phabricator.wikimedia.org/T157590#3069739 (10Ryasmeen) [00:59:12] 10VisualEditor, 05WMF-deploy-2017-02-28_(1.29.0-wmf.14): Rebaser: Only show cursors for connected users - https://phabricator.wikimedia.org/T152487#3069767 (10Jdforrester-WMF) [00:59:25] 10VisualEditor, 10VisualEditor-Tables, 05WMF-deploy-2017-02-28_(1.29.0-wmf.14): Cell change missing in table diff - https://phabricator.wikimedia.org/T158294#3069768 (10Jdforrester-WMF) [00:59:39] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 05WMF-deploy-2017-02-28_(1.29.0-wmf.14): VisualEditor Cite dialog, when Ctrl+Enter is pressed, inserts a newline before closing the dialog - https://phabricator.wikimedia.org/T158321#3069769 (10Jdforrester-WMF) [01:07:52] 10VisualEditor, 10VisualEditor-MediaWiki, 07I18n, 07RTL: [Regression?] On RTL wiki, context menu on left-floated block image expands the document width, causing an ugly horizontal scrollbar - https://phabricator.wikimedia.org/T159472#3069778 (10Jdforrester-WMF) p:05Triage>03High [02:26:56] (03PS1) 10Catrope: ve.ce.Surface: Prevent horizontal scrollbars when hovering FocusableNodes in RTL [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340916 [02:44:41] MatmaRex: OK I've fixed the context thing locally, by changing how PopupWidget does adjustments [02:44:48] But the code is ugly and I need to refactor it a bit [06:39:21] 10VisualEditor: Highlighting on word you are looking for looks broken - https://phabricator.wikimedia.org/T159439#3067533 (10Jerrykim306) By the way, this also affects in Visual Editor original one(Not source editor). [08:39:05] 10VisualEditor: Highlighting on word you are looking for looks broken - https://phabricator.wikimedia.org/T159439#3067533 (10Schnark) I can reproduce this in Vivaldi, while Firefox works as expected. [12:01:55] (03CR) 10Esanders: Cleanup DesktopTarget styles (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340497 (owner: 10Esanders) [12:02:54] (03PS1) 10Esanders: Improve NWE new section styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340962 [12:13:18] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: Adding an image at the top of a list puts the image inside the list - https://phabricator.wikimedia.org/T57767#640605 (10jeblad) Same thing happen at the bottom of the list. Example at [[ https://no.wikipedia.org/w/index.php?title=%C3%98vre_Vang_kirke&old... [12:17:09] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: Adding an image at the top of a list puts the image inside the list - https://phabricator.wikimedia.org/T57767#3070438 (10jeblad) This isn't about the VisualEditor, it is about the PHP Parser? [13:34:55] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, and 5 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3070593 (10Liuxinyu970... [13:42:33] 10VisualEditor: "Often used" not shown in VisualEditor (kowiki) - https://phabricator.wikimedia.org/T159529#3070603 (10Ykhwong) [15:21:54] (03PS4) 10Esanders: DiffElement: Allow a node change to be an attribute change *and* a linear diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340715 [15:21:56] (03PS7) 10Esanders: WIP diff attribute changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 [15:21:58] (03PS1) 10Esanders: DiffElement: Use a real ve.Range instead of a plain object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340988 [15:24:28] (03CR) 10jerkins-bot: [V: 04-1] WIP diff attribute changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 (owner: 10Esanders) [15:45:03] (03PS8) 10Esanders: WIP diff attribute changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 [15:45:05] (03PS1) 10Esanders: DiffElement: Ensure del/ins tags encapsulate annotation changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 [17:42:39] (03CR) 10jerkins-bot: [V: 04-1] WIP diff attribute changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 (owner: 10Esanders) [17:43:47] (03CR) 10Jforrester: [C: 032] Cleanup DesktopTarget styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340497 (owner: 10Esanders) [17:44:18] (03CR) 10Jforrester: [C: 032] Improve NWE new section styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340962 (owner: 10Esanders) [17:46:12] (03CR) 10Jforrester: [C: 031] DiffElement: Ensure del/ins tags encapsulate annotation changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 (owner: 10Esanders) [17:50:49] (03CR) 10Jforrester: "We'll probably want to stack changes, won't we? E.g. if changes to the current code will respond on " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 (owner: 10Esanders) [17:54:44] (03Merged) 10jenkins-bot: Cleanup DesktopTarget styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340497 (owner: 10Esanders) [18:06:05] (03Merged) 10jenkins-bot: Improve NWE new section styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340962 (owner: 10Esanders) [18:08:58] 10VisualEditor: VisualEditor: Text style (bold, italic) is added inside the link markup instead of outside - https://phabricator.wikimedia.org/T154121#3071491 (10Jdforrester-WMF) [18:09:02] 10VisualEditor, 10VisualEditor-DataModel, 07Epic: Ordered application of annotations to avoid fragmentation (e.g. ''[[Foo|Fo]]''[[Foo|o]]) - https://phabricator.wikimedia.org/T52098#3071494 (10Jdforrester-WMF) [18:09:51] 10VisualEditor, 10VisualEditor-MediaWiki, 10Graphs: Consider adding graph caption/ x-axis label / y-axis label / graph title features when inserting graphs. - https://phabricator.wikimedia.org/T154129#3071497 (10Jdforrester-WMF) p:05Triage>03Low [18:11:07] 10VisualEditor, 10VisualEditor-ContentEditable: Position of quotation marks altered when language direction is changed - https://phabricator.wikimedia.org/T154125#3071500 (10Jdforrester-WMF) 05Open>03Invalid Yes, this is intentional; the Unicode BiDi algorithm results in "surprising" outcomes sometimes. [18:14:01] 10VisualEditor, 10VisualEditor-CopyPaste: VisualEditor: when pasting wikified text from an article, the text style (including link) can't be modified - https://phabricator.wikimedia.org/T154123#3071504 (10Jdforrester-WMF) p:05Triage>03Unbreak! This looks like the paste is creating a different set of annota... [18:14:35] Hey, if one of you (probably Kemayo or edsanders) wants to look at https://phabricator.wikimedia.org/T154123 that's be smashing. [18:42:51] (03CR) 10jenkins-bot: Cleanup DesktopTarget styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340497 (owner: 10Esanders) [18:46:43] 10VisualEditor, 03Interactive-Sprint, 06Maps (Kartographer): Disable VE editing of maplink / mapframe when the editor is not able to - https://phabricator.wikimedia.org/T157996#3071562 (10Deskana) p:05Triage>03High Can we get some help with this, please? This was identified as "must have" in {T155601} so... [18:51:20] (03CR) 10jenkins-bot: Improve NWE new section styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340962 (owner: 10Esanders) [18:59:55] (03CR) 10Esanders: "It currently spits out a item for each attribute that has changed. Users can lump changes together or handle them separately." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 (owner: 10Esanders) [19:03:29] (03CR) 10Esanders: "The current code outputs:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 (owner: 10Esanders) [19:28:49] (03CR) 10Jforrester: [C: 032] DiffElement: Use a real ve.Range instead of a plain object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340988 (owner: 10Esanders) [19:34:02] (03CR) 10jerkins-bot: [V: 04-1] DiffElement: Use a real ve.Range instead of a plain object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340988 (owner: 10Esanders) [19:35:58] 10VisualEditor, 10VisualEditor-MediaWiki, 07I18n, 07RTL: [Regression?] On RTL wiki, context menu on left-floated block image expands the document width, causing an ugly horizontal scrollbar - https://phabricator.wikimedia.org/T159472#3071731 (10Catrope) a:05matmarex>03Catrope With my [[https://gerrit.w... [19:58:22] 10VisualEditor, 10Flow, 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017): Flow's visual editor doesn't know about extensions tags - https://phabricator.wikimedia.org/T159380#3071832 (10Jdforrester-WMF) [20:18:47] (03PS1) 10Catrope: DesktopContext: Unhide context before positioning popup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341038 (https://phabricator.wikimedia.org/T159472) [20:20:51] 10VisualEditor, 10VisualEditor-MediaWiki, 07I18n, 13Patch-For-Review, 07RTL: [Regression?] On RTL wiki, context menu on left-floated block image expands the document width, causing an ugly horizontal scrollbar - https://phabricator.wikimedia.org/T159472#3071898 (10Catrope) >>! In T159472#3071731, @Catrop... [20:20:53] James_F: https://phabricator.wikimedia.org/T159472#3071898 [20:26:55] 10VisualEditor, 10VisualEditor-MediaWiki, 07I18n, 13Patch-For-Review, 07RTL: On RTL wiki, context menu on left-floated block image expands the document width, causing an ugly horizontal scrollbar - https://phabricator.wikimedia.org/T159472#3071909 (10Jdforrester-WMF) [20:32:15] in local dev wiki, I have under vendor directory the oojsui lib, managed by composer. what is the correct setup for working on oojs-ui dev? I guess I should switch to use git directly rather than composer. is it under vendor.git? or is there a submodule for each lib? [20:36:11] I want to test Roan's changes. If oojs-ui was an extension I would just git review -d 340454 [20:36:36] eranroz: What I do is clone oojs-ui separately [20:37:06] then grunt build [20:37:12] And then use a hack to copy those files into MW [20:37:16] * RoanKattouw extracts hack from command line history [20:37:57] yes | (for f in *.js *.css; do cp ~/git/oojs/ui/dist/$f ~/vagrant/mediawiki/resources/lib/oojs-ui/ ; done) [20:39:16] thanks. I just thought there may be a cleaner way to do it :) [20:40:14] We should really build one :/ [21:03:06] (03PS1) 10Esanders: Use mw-body-content instead of mw-body [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341045 [21:06:14] (03CR) 10Catrope: "I'm confused, AFAICT mw-body-content is a child of mw-body, not an ancestor. So how does this help?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341045 (owner: 10Esanders) [21:09:04] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Teardown issue – Getting error "Uncaught TypeError: Cannot read property 'getToolbarDialogs' of null" in the console after saving a new section - https://phabricator.wikimedia.org/T159377#3072028 (10Jdforrester-WMF) p:05Triage>03Low [21:16:16] 10VisualEditor: External links in dialogs aren't styled properly - https://phabricator.wikimedia.org/T159578#3072034 (10Esanders) [21:20:42] (03CR) 10Jforrester: "This is presumably for T159578 ?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341045 (owner: 10Esanders) [21:35:35] Is it an internal joke: "font-size: 90.90909%" ? [21:37:23] no… it's probably computed by some silly Less expression [21:38:40] 100/1.1 = 90.90909 [21:38:52] thanks. I just noticed that in FF the "Edit" and "cancel" buttons in the link widget doesn't have exact same height [21:39:02] where do you see that? just curious [21:39:58] For example: https://ar.wikipedia.org/w/index.php?title=%D9%85%D8%B3%D8%B9%D9%88%D8%AF_%D8%BA%D9%86%D8%A7%D9%8A%D9%85&veaction=edit when clicking on the first link [21:40:42] Changing the min-height to 2.6 instead of 2.5 in .oo-ui-buttonElement-framed > .oo-ui-buttonElement-button fix it, though this is probably not the desired solution [21:44:52] we probably have some task about this somewhere [21:47:37] hmm, actually. this looks specific to arabic, or maybe to arabic wikipedia. looks like you have some font-size and line-height overrides that could be somehow causing this… [21:48:14] i see it also in enwiki. 1px difference. but only in FF, not in chrome [21:49:01] it's a couple pixels off for me in chrome on arwiki, OK on enwiki [21:50:23] we've been actually fighting issues like this for a while. different browsers apply rounding differently when converting values calculated in 'em' to pixels. or something along these lines. [21:51:41] the height of a button with a label is calculated differently than the height of a button with an icon. it should give the same result, and the same heights, but it doesn't always do, and it's a pain to make any sense of why this happens. [21:58:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341088 (owner: 10L10n-bot) [21:59:10] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Urbanecm: NWE shouldn't mark inserted ISBN with tags - https://phabricator.wikimedia.org/T154111#3072136 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03Esanders Sorry about the slow response; we fixed it las... [22:03:57] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Urbanecm: NWE shouldn't mark inserted ISBN with tags - https://phabricator.wikimedia.org/T154111#3072147 (10Urbanecm) Thank you, it works. [22:05:33] 10VisualEditor: it.wp article with 3 items in "Notes" section displays only one item in VisualEditor - https://phabricator.wikimedia.org/T154184#2903560 (10Jdforrester-WMF) I'm afraid this is a long-standing problem as part of {T52474}. The first reference is created inside the `Divisione amministrativa` templa... [22:05:46] 10VisualEditor: it.wp article with 3 items in "Notes" section displays only one item in VisualEditor - https://phabricator.wikimedia.org/T154184#3072155 (10Jdforrester-WMF) [22:05:53] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-References, 07Epic: In VisualEditor, references in templates cannot be reused and are numbered separately from references in the text. - https://phabricator.wikimedia.org/T52474#558087 (10Jdforrester-WMF) [22:08:01] 10VisualEditor: Don't show the welcome message unless it has a "switch to visual editing" button - https://phabricator.wikimedia.org/T154202#3072159 (10Jdforrester-WMF) [22:09:36] 10VisualEditor: Don't show the welcome message unless it has a "switch to visual editing" button - https://phabricator.wikimedia.org/T154202#2903974 (10Jdforrester-WMF) 05Open>03declined The principal purpose of the welcome message is to welcome people. The editor mode switch button is a nice extra, but not... [22:10:35] 10VisualEditor, 13Patch-For-Review: External links in dialogs aren't styled properly - https://phabricator.wikimedia.org/T159578#3072177 (10matmarex) [22:12:20] 10VisualEditor, 13Patch-For-Review: External links in dialogs aren't styled properly - https://phabricator.wikimedia.org/T159578#3072034 (10matmarex) You're actually fixing T155863 with these patches. Previous attempts to do it were not merged: https://gerrit.wikimedia.org/r/#/c/158803/ https://gerrit.wikimed... [22:12:59] 10VisualEditor, 06Commons: VisualEditor insert shows Wikimedia Commons files instead of only showing local wiki files - https://phabricator.wikimedia.org/T154234#3072200 (10Jdforrester-WMF) 05Open>03declined The functionality is intentionally to show all images available to that wiki's users. We don't want... [22:17:20] 10VisualEditor, 13Patch-For-Review: External links in dialogs aren't styled properly - https://phabricator.wikimedia.org/T159578#3072216 (10Esanders) Lame. [22:20:17] 10VisualEditor, 13Patch-For-Review: External links in dialogs aren't styled properly - https://phabricator.wikimedia.org/T159578#3072218 (10Esanders) The first commit was the wrong approach, but not sure why the second one was abandoned. [22:24:10] (03CR) 10Jforrester: [C: 032] "…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340988 (owner: 10Esanders) [22:29:13] (03Merged) 10jenkins-bot: DiffElement: Use a real ve.Range instead of a plain object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340988 (owner: 10Esanders) [22:34:02] (03CR) 10jenkins-bot: DiffElement: Use a real ve.Range instead of a plain object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340988 (owner: 10Esanders) [22:42:12] (03PS1) 10Esanders: Comment Parsoid hacks as such [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341097 [22:44:12] 10VisualEditor, 10VisualEditor-EditingTools, 07Design, 05WMF-deploy-2017-03-07_(1.29.0-wmf.15): Find/Replace (in-editor text search) should be diacritic-insensitive - https://phabricator.wikimedia.org/T154195#3072272 (10Jdforrester-WMF) >>! In T154195#3065589, @Pginer-WMF wrote: > Although the task has bee... [22:45:28] (03CR) 10Jforrester: [C: 032] Comment Parsoid hacks as such [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341097 (owner: 10Esanders) [22:58:25] (03Merged) 10jenkins-bot: Comment Parsoid hacks as such [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341097 (owner: 10Esanders) [23:01:55] 10VisualEditor, 10MediaWiki-Page-editing, 13Patch-For-Review: