[05:31:49] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 07Browser-Support-Apple-Safari: Edit link panel has uneven height of OOUI buttons in desktop Safari - https://phabricator.wikimedia.org/T122503#1906016 (10Volker_E) Related to {T113495} [05:32:06] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 07Browser-Support-Apple-Safari: Edit link panel has uneven height of OOUI buttons in desktop Safari - https://phabricator.wikimedia.org/T122503#3086765 (10Volker_E) [06:45:08] 10VisualEditor: Unable to click on links in templates - https://phabricator.wikimedia.org/T99924#1301805 (10Alsee) >>! In T99924#1550540, @Jdforrester-WMF wrote: > If we let you interact with a template, we let you edit it. I don't understand. Could you clarify the decline reason? This issue severely disrupts a... [07:00:43] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341976 (owner: 10L10n-bot) [09:59:06] 10VisualEditor: Cite plugin not working - https://phabricator.wikimedia.org/T160050#3087120 (10Oreolek) [10:13:02] 10VisualEditor: Highlighting on word you are looking for looks broken - https://phabricator.wikimedia.org/T159439#3087175 (10Schnark) JFTR: In Firefox this works because of https://bugzilla.mozilla.org/show_bug.cgi?id=394604. [10:13:41] 10VisualEditor: Rename the automatic field on Citoid to be more understandable - https://phabricator.wikimedia.org/T159953#3087176 (10Prtksxna) While I understand what you're trying to say, doing this would be equivalent to saying "Insert username" and "Insert password" on `Special:UserLogin`. This would be inco... [10:53:37] 10VisualEditor: Add tooltips on the different visual mode tools - https://phabricator.wikimedia.org/T158546#3087231 (10Trizek-WMF) [10:53:39] 10VisualEditor: Rename the automatic field on Citoid to be more understandable - https://phabricator.wikimedia.org/T159953#3087229 (10Trizek-WMF) 05Open>03declined >>! In T159953#3087176, @Prtksxna wrote: > While I understand what you're trying to say, doing this would be equivalent to saying "Insert usernam... [10:57:12] 10VisualEditor, 10ArchCom-RfC, 06Parsing-Team, 06Performance-Team, and 4 others: Decide on storage and delivery method for TemplateStyles CSS - https://phabricator.wikimedia.org/T155813#3087239 (10Gilles) >>! In T155813#3085657, @Anomie wrote: > It'd be nice if you'd deign to quantify the performance degra... [12:19:44] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-Page_Forms: Provide an integration of VisualEditor for SemanticForms - https://phabricator.wikimedia.org/T131686#3087450 (10Yaron_Koren) @Pyro853 - I don't know if you've been looking into the linking issue, but I just looked at the Flow test p... [12:20:58] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-Page_Forms: Provide an integration of VisualEditor for SemanticForms - https://phabricator.wikimedia.org/T131686#3087452 (10Yaron_Koren) p:05Low>03Normal [12:22:15] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 07Performance: Support editing parts of a page in VisualEditor - https://phabricator.wikimedia.org/T50429#3087455 (10Yaron_Koren) [12:22:18] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-Page_Forms: Provide an integration of VisualEditor for SemanticForms - https://phabricator.wikimedia.org/T131686#2174885 (10Yaron_Koren) [13:04:53] (03PS6) 10Bartosz Dziewoński: Update `
` support for Parsoid changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340554 (https://phabricator.wikimedia.org/T159900)
[13:04:56] 	 (03CR) 10Bartosz Dziewoński: Update `
` support for Parsoid changes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340554 (https://phabricator.wikimedia.org/T159900) (owner: 10Bartosz Dziewoński)
[13:05:18] 	 (03CR) 10Bartosz Dziewoński: "All done." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340554 (https://phabricator.wikimedia.org/T159900) (owner: 10Bartosz Dziewoński)
[13:14:54] 	 (03CR) 10jerkins-bot: [V: 04-1] Update `
` support for Parsoid changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340554 (https://phabricator.wikimedia.org/T159900) (owner: 10Bartosz Dziewoński)
[13:19:18] 	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Epic, 07Performance: New Wikitext Editor: Major improvement to load time to edit - https://phabricator.wikimedia.org/T154843#2925793 (10Samwalton9) For me, Chrome, Windows 10, time from clicking Edit Source to being...
[13:22:54] 	 (03PS7) 10Bartosz Dziewoński: Update `
` support for Parsoid changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340554 (https://phabricator.wikimedia.org/T159900)
[13:29:39] 	 Elitre: How shall I now have time for VE and iOS? :O
[14:18:26] 	 (03PS1) 10Esanders: FindAndReplace: Use Intl.Collator instead of localeCompare [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342015
[14:18:29] 	 (03PS1) 10Esanders: Use Intl.Collator for all searches if available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342016 (https://phabricator.wikimedia.org/T159439)
[14:21:19] 	 10VisualEditor, 13Patch-For-Review: Highlighting on word you are looking for looks broken - https://phabricator.wikimedia.org/T159439#3087759 (10Esanders) The above patch fixes the offset issue reported in all our supported browsers. IE9/10 users will still not be able to do certain case insensitive searches i...
[15:20:47] 	 (03PS1) 10Bartosz Dziewoński: ve.ui.MWGalleryDialog: Fix 'Display mode' dropdown options' styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342025
[15:43:05] 	 (03PS2) 10Esanders: Use Intl.Collator for all searches if available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342016 (https://phabricator.wikimedia.org/T159439)
[15:52:21] 	 10VisualEditor, 07Browser-Tests, 13Patch-For-Review, 15User-zeljkofilipin: Selenium tests for VisualEditor in Node.js - https://phabricator.wikimedia.org/T150435#3088103 (10zeljkofilipin) I have proposed a skill share session for Vienna hackathon {T159945} if you would like to pair in person.
[16:00:54] 	 10VisualEditor, 10MediaWiki-Vagrant, 15User-zeljkofilipin: Provisioning visualeditor role fails with `Unable to locate package zookeeper-server` - https://phabricator.wikimedia.org/T159931#3088152 (10zeljkofilipin) How come an year old commit managed to break provisioning VisualEditor now?! I was able to pro...
[16:26:55] 	 10VisualEditor, 10ArchCom-RfC, 06Parsing-Team, 06Performance-Team, and 4 others: Decide on storage and delivery method for TemplateStyles CSS - https://phabricator.wikimedia.org/T155813#3088206 (10Anomie) I would like to better understand your conclusions.  >>! In T155813#3087239, @Gilles wrote: > I though...
[16:35:29] 	 10VisualEditor, 10ArchCom-RfC, 06Parsing-Team, 06Performance-Team, and 4 others: Decide on storage and delivery method for TemplateStyles CSS - https://phabricator.wikimedia.org/T155813#3088239 (10GWicke) @anomie, see T124966 for data showing the impact of linked head styles on first paint times, especiall...
[16:39:44] 	 MatmaRex: You OK with going ahead with https://gerrit.wikimedia.org/r/#/c/341774/ and https://gerrit.wikimedia.org/r/#/c/341775/ and me/you doing the template one as a follow-up as I described?
[16:40:20] 	 (03CR) 10Jforrester: [C: 032] FindAndReplace: Use Intl.Collator instead of localeCompare [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342015 (owner: 10Esanders)
[16:41:17] 	 (03CR) 10Jforrester: [C: 032] Use Intl.Collator for all searches if available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342016 (https://phabricator.wikimedia.org/T159439) (owner: 10Esanders)
[16:43:04] 	 (03CR) 10Jforrester: [C: 032] "Ha, whoops." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342025 (owner: 10Bartosz Dziewoński)
[16:43:10] 	 James_F: yeah, i guess
[16:44:12] 	 MatmaRex: And review on https://gerrit.wikimedia.org/r/#/c/341821/ would be lovely. ;-)
[16:44:48] 	 (03CR) 10Jforrester: [C: 032] "Nice spot." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341555 (owner: 10Bartosz Dziewoński)
[16:44:51] 	 (03Merged) 10jenkins-bot: FindAndReplace: Use Intl.Collator instead of localeCompare [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342015 (owner: 10Esanders)
[16:45:13] 	 (03Merged) 10jenkins-bot: Use Intl.Collator for all searches if available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342016 (https://phabricator.wikimedia.org/T159439) (owner: 10Esanders)
[16:45:48] 	 Is https://gerrit.wikimedia.org/r/#/c/341556/ an actual unit-test failure? Looks like it…
[16:52:35] 	 10VisualEditor, 10ArchCom-RfC, 06Parsing-Team, 06Performance-Team, and 4 others: Decide on storage and delivery method for TemplateStyles CSS - https://phabricator.wikimedia.org/T155813#3088271 (10Anomie) >>! In T155813#3088239, @GWicke wrote: > tl;dr: First paint with linked styles on a really slow 2G con...
[16:53:33] 	 (03Merged) 10jenkins-bot: ve.ui.MWGalleryDialog: Fix 'Display mode' dropdown options' styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342025 (owner: 10Bartosz Dziewoński)
[16:54:05] 	 (03CR) 10jenkins-bot: FindAndReplace: Use Intl.Collator instead of localeCompare [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342015 (owner: 10Esanders)
[16:54:43] 	 (03CR) 10Esanders: [C: 04-1] Generalize DiffElement logic (improves lists and tables) (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340656 (https://phabricator.wikimedia.org/T149537) (owner: 10Tchanders)
[16:57:23] 	 (03PS1) 10Jforrester: Update VE core submodule to master (97d8db944) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342041 (https://phabricator.wikimedia.org/T159439)
[16:57:56] 	 (03CR) 10jenkins-bot: Use Intl.Collator for all searches if available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342016 (https://phabricator.wikimedia.org/T159439) (owner: 10Esanders)
[16:58:38] 	 (03CR) 10Esanders: "I guess the problem really is that LinkContextItem inherits from AnnotationContextItem, but this isn't an annotation. That could be fixed " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341555 (owner: 10Bartosz Dziewoński)
[16:58:55] 	 (03CR) 10Bartosz Dziewoński: [C: 032] Switching modes created an infinite loop onBeforeUnload [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341821 (https://phabricator.wikimedia.org/T153346) (owner: 10DLynch)
[16:59:29] 	 (03Merged) 10jenkins-bot: ve.ui.MWMagicLinkNodeContextItem: Do not display 'Clear styling' button in context [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341555 (owner: 10Bartosz Dziewoński)
[16:59:57] 	 (03CR) 10jenkins-bot: ve.ui.MWGalleryDialog: Fix 'Display mode' dropdown options' styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342025 (owner: 10Bartosz Dziewoński)
[17:00:29] 	 10VisualEditor, 10ArchCom-RfC, 06Parsing-Team, 06Performance-Team, and 4 others: Decide on storage and delivery method for TemplateStyles CSS - https://phabricator.wikimedia.org/T155813#3088281 (10GWicke) @anomie, I was off by 0.1s. To be precise, numbers with images are 11.4s with inlined styles compared...
[17:02:19] 	 10Citoid, 10VisualEditor, 10Internet-Archive: Diagnose Zotero translator for archive.org including wayback.archive.org - https://phabricator.wikimedia.org/T98680#3088286 (10Mvolz)
[17:03:11] 	 10Citoid, 10VisualEditor, 10Internet-Archive: Improve results for archive.org including wayback.archive.org - https://phabricator.wikimedia.org/T98680#1274393 (10Mvolz)
[17:03:56] 	 10Citoid, 10VisualEditor, 10Internet-Archive: Improve results for archive.org including wayback.archive.org - https://phabricator.wikimedia.org/T98680#1274393 (10Mvolz) >>! In T98680#2941114, @Josve05a wrote: > If I convert http://wayback.archive.org/web/20050316221324/http://www.thewbalchannel.com/politics/...
[17:07:44] 	 10Citoid, 10VisualEditor, 10Internet-Archive: Improve results for archive.org including wayback.archive.org - https://phabricator.wikimedia.org/T98680#3088313 (10Mvolz) >>! In T98680#3088286, @Mvolz wrote: >>>! In T98680#2941942, @Josve05a wrote: >> And https://archive.org/stream/annalsmagazineof8101912lond#...
[17:08:17] 	 (03CR) 10jenkins-bot: ve.ui.MWMagicLinkNodeContextItem: Do not display 'Clear styling' button in context [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341555 (owner: 10Bartosz Dziewoński)
[17:14:48] 	 (03Merged) 10jenkins-bot: Switching modes created an infinite loop onBeforeUnload [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341821 (https://phabricator.wikimedia.org/T153346) (owner: 10DLynch)
[17:20:49] 	 (03CR) 10Esanders: [C: 031] "Seems ok as an approach." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341287 (https://phabricator.wikimedia.org/T117165) (owner: 10Bartosz Dziewoński)
[17:24:07] 	 (03CR) 10Esanders: "I guess if we are going to have an async surface that may not be ready to save we should have a getSurfaceStablePromise method (name could" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341288 (https://phabricator.wikimedia.org/T117165) (owner: 10Bartosz Dziewoński)
[17:26:13] 	 (03CR) 10Esanders: [C: 04-1] Update `
` support for Parsoid changes (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/340554 (https://phabricator.wikimedia.org/T159900) (owner: 10Bartosz Dziewoński)
[17:28:35] 	 (03CR) 10Esanders: [C: 031] "Ideally there would be unit tests for those patterns..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341291 (https://phabricator.wikimedia.org/T117165) (owner: 10Bartosz Dziewoński)
[17:31:33] 	 10VisualEditor, 10ArchCom-RfC, 06Parsing-Team, 06Performance-Team, and 4 others: Decide on storage and delivery method for TemplateStyles CSS - https://phabricator.wikimedia.org/T155813#3088411 (10Anomie) Ah, you're comparing "images and external styles" with "images and inline styles and deferred loading...
[17:31:45] 	 (03CR) 10jenkins-bot: Switching modes created an infinite loop onBeforeUnload [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341821 (https://phabricator.wikimedia.org/T153346) (owner: 10DLynch)
[17:33:21] 	 (03PS1) 10DLynch: ArticleTargetLoader: wikitext switch shouldn't require FullRestbaseURL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342053 (https://phabricator.wikimedia.org/T158692)
[17:34:21] 	 James_F: ^^^ Turned out to be that config issue, so we were throwing away the wikitext for any wiki configured to use $wgVisualEditorRestbaseURL instead of $wgVisualEditorFullRestbaseURL.
[17:35:55] 	 (Which my VM was, because it's the easiest config for exposing the VM on the local network and using various other devices one owns to test things.)
[17:48:23] 	 10Citoid, 10VisualEditor, 07Easy: Add 'v' flag to twitter upstream in https://github.com/zotero/translators - https://phabricator.wikimedia.org/T78785#3088476 (10Harjotsingh) a:03Harjotsingh
[17:53:41] 	 10Citoid, 10VisualEditor, 07Easy: Add 'v' flag to twitter upstream in https://github.com/zotero/translators - https://phabricator.wikimedia.org/T78785#3088505 (10Harjotsingh) @Mvolz  Should I make pull request from new branch after adding the flag ?
[17:55:28] 	 10Citoid, 10VisualEditor, 07Easy: Add 'v' flag to twitter upstream in https://github.com/zotero/translators - https://phabricator.wikimedia.org/T78785#3088514 (10Harjotsingh) @Mvolz  Should I make pull request from new branch after adding the flag ?
[17:57:06] 	 (03PS1) 10Esanders: findText: Fix documentation and tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342062
[18:03:02] 	 Kemayo: Aha!
[18:05:02] 	 (03CR) 10Esanders: [C: 031] ArticleTargetLoader: wikitext switch shouldn't require FullRestbaseURL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342053 (https://phabricator.wikimedia.org/T158692) (owner: 10DLynch)
[18:07:21] 	 (03PS1) 10DLynch: ArticleTarget: use existing initialEditSummary if present [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342065 (https://phabricator.wikimedia.org/T159686)
[18:14:32] 	 10VisualEditor, 10ArchCom-RfC, 06Parsing-Team, 06Performance-Team, and 4 others: Decide on storage and delivery method for TemplateStyles CSS - https://phabricator.wikimedia.org/T155813#3088557 (10GWicke) >>! In T155813#3088411, @Anomie wrote: > Ah, you're comparing "images and external styles" with "image...
[18:54:56] 	 (03CR) 10Jforrester: [C: 032] findText: Fix documentation and tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342062 (owner: 10Esanders)
[18:55:15] 	 MatmaRex: Want me to fix up the tests on https://gerrit.wikimedia.org/r/#/c/341287/ ?
[18:56:37] 	 (03CR) 10Jforrester: [C: 032] "For now." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342053 (https://phabricator.wikimedia.org/T158692) (owner: 10DLynch)
[18:57:00] 	 James_F: no, i'll do it. i think i want to add some too
[18:57:19] 	 OK.
[18:58:08] 	 (03Merged) 10jenkins-bot: findText: Fix documentation and tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342062 (owner: 10Esanders)
[18:59:47] 	 (03CR) 10Esanders: [C: 032] ArticleTarget: use existing initialEditSummary if present [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342065 (https://phabricator.wikimedia.org/T159686) (owner: 10DLynch)
[19:00:43] 	 Meh.
[19:00:56] 	 Isn't this.initialEditSummary set to something if you're section editing?
[19:00:57] 	 (03CR) 10jenkins-bot: findText: Fix documentation and tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342062 (owner: 10Esanders)
[19:01:49] 	 Sorry, in meeting.
[19:03:07] 	 Kemayo: ^
[19:04:41] 	 James_F: it is, but in a different place. I don't think it'll cause any issues, but I'll double check.
[19:06:09] 	 OK. I guess the test cases are "section edit -> switch without changing the summary -> save" + it warns you the edit summary is empty, and "section edit -> switch with addition to the summary -> save" + it retains your changes and doesn't warn you?
[19:07:02] 	 Sorry for being useless.
[19:09:43] 	 (03Merged) 10jenkins-bot: ArticleTargetLoader: wikitext switch shouldn't require FullRestbaseURL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342053 (https://phabricator.wikimedia.org/T158692) (owner: 10DLynch)
[19:12:53] 	 (03Merged) 10jenkins-bot: ArticleTarget: use existing initialEditSummary if present [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342065 (https://phabricator.wikimedia.org/T159686) (owner: 10DLynch)
[19:24:46] 	 (03CR) 10jenkins-bot: ArticleTargetLoader: wikitext switch shouldn't require FullRestbaseURL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342053 (https://phabricator.wikimedia.org/T158692) (owner: 10DLynch)
[19:30:30] 	 (03CR) 10jenkins-bot: ArticleTarget: use existing initialEditSummary if present [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342065 (https://phabricator.wikimedia.org/T159686) (owner: 10DLynch)
[19:33:25] 	 10VisualEditor, 10MediaWiki-extensions-Linter: Make Linter edit helper compatible with VisualEditor - https://phabricator.wikimedia.org/T160102#3088843 (10Legoktm)
[19:34:04] 	 10VisualEditor: Make it easy to convert  back into the regular article content - https://phabricator.wikimedia.org/T160103#3088855 (10Whatamidoing-WMF)
[19:42:32] 	 Kemayo: Back. From testing, it looks like that destroys your edit summary from before you switched. :-(
[19:56:40] 	 James_F: Sections. *shakes fist*
[19:57:04] 	 :-(
[20:14:12] 	 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Design: It would be nice to have Show preview and Review your changes more directly accessible in the New Wikitext Editor - https://phabricator.wikimedia.org/T153306#2876033 (10Framawiki) [[ https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:%C3%89dite...
[20:14:44] 	 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release-notes, 15User-Ryasmeen, and 3 others: External links in dialogs aren't styled properly - https://phabricator.wikimedia.org/T159578#3088987 (10Ryasmeen)
[20:19:00] 	 (03CR) 10Esanders: WIP diff attribute changes (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 (owner: 10Esanders)
[20:26:33] 	 (03PS1) 10DLynch: ArticleTarget: Improve edit summary behavior when switching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342083 (https://phabricator.wikimedia.org/T159686)
[20:27:34] 	 (03PS1) 10Jforrester: Render self-links as if they were s [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342084 (https://phabricator.wikimedia.org/T52497)
[20:27:43] 	 MatmaRex: ^^ How hacky is that? ;-)
[20:31:05] 	 Kemayo: Should we explicitly set this.editSummaryValue to null on init? I guess we don't with this.initialEditSummary.
[20:31:30] 	 I paralleled the existing initialEditSummary treatment, yeah.
[20:31:39] 	 WFM.
[20:31:47] 	 (03CR) 10Jforrester: [C: 032] ArticleTarget: Improve edit summary behavior when switching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342083 (https://phabricator.wikimedia.org/T159686) (owner: 10DLynch)
[20:46:10] 	 (03Merged) 10jenkins-bot: ArticleTarget: Improve edit summary behavior when switching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342083 (https://phabricator.wikimedia.org/T159686) (owner: 10DLynch)
[20:51:11] 	 (03CR) 10jenkins-bot: ArticleTarget: Improve edit summary behavior when switching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342083 (https://phabricator.wikimedia.org/T159686) (owner: 10DLynch)
[20:51:24] 	 James_F: probably not terribly
[20:51:27] 	 (03PS1) 10Jforrester: ArticleTargetLoader: wikitext switch shouldn't require FullRestbaseURL [extensions/VisualEditor] (wmf/1.29.0-wmf.15) - 10https://gerrit.wikimedia.org/r/342087 (https://phabricator.wikimedia.org/T158692)
[20:51:37] 	 James_F: why are these using , anyway? that makes no sense semantically
[20:52:04] 	 10VisualEditor, 13Patch-For-Review, 05WMF-deploy-2017-03-14_(1.29.0-wmf.16): Lost work when switching from wikitext to visual modes on wikitech and private wikis (not using RESTbase) - https://phabricator.wikimedia.org/T158692#3089188 (10Jdforrester-WMF)
[20:52:11] 	 MatmaRex: Because MW is a POC?
[20:52:44] 	 MatmaRex: Upstreaming  instead of  is left for the future in the TODO.
[20:53:59] 	 10VisualEditor, 13Patch-For-Review, 05WMF-deploy-2017-03-14_(1.29.0-wmf.16): Lost work when switching from wikitext to visual modes on wikitech and private wikis (not using RESTbase) - https://phabricator.wikimedia.org/T158692#3044198 (10Jdforrester-WMF) Fixed in master for the RESTBase bit. However, on re-r...
[20:56:12] 	 10VisualEditor, 10VisualEditor-MediaWiki, 15User-Ryasmeen, 05WMF-deploy-2017-03-14_(1.29.0-wmf.16): After switching between VE and NWE save dialog complains about missing summary - https://phabricator.wikimedia.org/T159686#3089216 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03High a:03DLynch
[20:56:40] 	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Design, 07Epic: Provide a second version of a beta modern wikitext editor integrated into the visual editor - https://phabricator.wikimedia.org/T142523#3089226 (10Jdforrester-WMF)
[20:56:43] 	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Ryasmeen, 05WMF-deploy-2017-03-14_(1.29.0-wmf.16): The onBeforeUnloadHandler isn't getting set(?) when switching from VE to NWE - https://phabricator.wikimedia.org/T153346#3089223 (10Jdforrester-WMF) 05Open>0...
[20:59:10] 	 https://www.mediawiki.org/wiki/Special:Code/MediaWiki/2457
[21:00:21] 	 James_F: so someone just wanted them bold, and they used  because that was the rage at the time. i'm sure we can change it to whatever as long as it looks the same.
[21:00:31] 	 conveniently, parsoid doesn't do this, so half the work
[21:35:37] 	 10VisualEditor: In IE11 press delete within Visual Editor causes scrolling to top of page - https://phabricator.wikimedia.org/T160126#3089389 (10Dan.mulholland)
[21:36:24] 	 10VisualEditor: In IE11 press delete within Visual Editor causes scrolling to top of page - https://phabricator.wikimedia.org/T160126#3089404 (10Dan.mulholland)
[21:39:07] 	 (03CR) 10Krinkle: Allow links to be constructed with custom elements (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341774 (https://phabricator.wikimedia.org/T52497) (owner: 10Esanders)
[22:08:14] 	 (03CR) 10DLynch: [C: 031] ArticleTargetLoader: wikitext switch shouldn't require FullRestbaseURL [extensions/VisualEditor] (wmf/1.29.0-wmf.15) - 10https://gerrit.wikimedia.org/r/342087 (https://phabricator.wikimedia.org/T158692) (owner: 10Jforrester)
[22:08:30] 	 James_F: ^^^ I don't have +2 there, so you'll need someone else as well.
[22:11:42] 	 Kemayo: It'll need to get deployed properly, not just +2'ed; I'll add it to SWAT.
[22:14:10] 	 Kemayo: Also did you see https://phabricator.wikimedia.org/T158692#3089188 ?
[22:20:48] 	 James_F: Yeah, I'm not sure how it could be happening on enwiki. There's two main paths, both of which would be weird. First, some config glitch where occasionally for some reason it doesn't think the full restbase URL is set. Second, a Parsoid glitch where it fails to actually use the wikitext it was given to transform.
[22:20:59] 	 (But still reports a success, etc.)
[22:21:29] 	 Kemayo: Maaaaaybe something where we re-use an ID in the page so Parsoid gets confused, perhaps?
[22:25:23] 	 Hm, I see a suggestion in the original bug report thread that there might have been a bot-edit to the page while the user was making their edits. I'll see whether that has an impact.
[22:26:38] 	 Well, it doesn't have an obvious one at least.
[22:33:38] 	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/342129 (owner: 10L10n-bot)
[22:40:11] 	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342134 (owner: 10L10n-bot)
[22:43:54] * James_F sighs.
[22:56:15] 	 10VisualEditor: [Regression ore-wmf.16] Edit summary is showing previous session's edit summary - https://phabricator.wikimedia.org/T160130#3089700 (10Ryasmeen)
[22:56:25] 	 10VisualEditor: [Regression pre-wmf.16] Edit summary is showing previous session's edit summary  - https://phabricator.wikimedia.org/T160130#3089712 (10Ryasmeen)
[22:57:55] 	 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), 15User-Ryasmeen, 07Verified: After switching between VE and NWE save dialog complains about missing summary - https://phabricator.wikimedia.org/T159686#3089713 (10Ryasmeen)
[22:58:42] 	 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), 15User-Ryasmeen, 07Verified: After switching between VE and NWE save dialog complains about missing summary - https://phabricator.wikimedia.org/T159686#3074957 (10Ryasmeen) This works now but https://phab...
[23:07:16] 	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), and 2 others: The onBeforeUnloadHandler isn't getting set(?) when switching from VE to NWE - https://phabricator.wikimedia.org/T153346#3089728 (10Ryasmeen)
[23:15:20] 	 hi
[23:15:23] 	 hacking on VE question
[23:15:55] 	 if I do surface.getModel().getSelection().range then I get the user's current selection. How can I set my own selection?
[23:18:43] 	 10VisualEditor: [Regression pre-wmf.16] Edit summary is showing previous session's edit summary - https://phabricator.wikimedia.org/T160130#3089810 (10DLynch) a:03DLynch
[23:20:05] 	 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), and 5 others: [Regression pre-wmf.15] Cannot add any citation, getting error in the console "Uncaught TypeError: Cannot read property '... - https://phabricator.wikimedia.org/T159278#3089814
[23:20:40] * legoktm looks at James_F ?
[23:21:30] 	 10VisualEditor, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), 15User-Ryasmeen, 07Verified, and 2 others: Getting error "Cannot read property 'target' of undefined" while opening VE from section edit link - https://phabricator.wikimedia.org/T159374#3089819 (10Ryasmeen)
[23:22:29] 	 #setSelection maybe
[23:23:11] 	 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), 15User-Ryasmeen, and 3 others: Adding citation from "Basic Form" is not working with NWE, nothing gets added to the page after clicking o... - https://phabricator.wikimedia.org/T153509#3089828
[23:24:39] 	 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), 05MW-1.29-release-notes, and 4 others: External links in dialogs aren't styled properly - https://phabricator.wikimedia.org/T159578#3089836 (10Ryasmeen)
[23:24:44] 	 I'll try again after class
[23:25:35] 	 legoktm: surface.getModel().selectNodes( range );
[23:25:46] 	 I think?
[23:26:39] 	 Oh, no, setSelection( range );
[23:26:41] 	 (03PS1) 10DLynch: DesktopArticleTarget: Clear stored summary value after save completes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342143 (https://phabricator.wikimedia.org/T160130)
[23:28:19] 	 Kemayo: Ha! I was right to worry. Should we also reset initialSaveSummary or whatever?
[23:29:28] 	 Might as well, there..
[23:29:30] 	 Kemayo: Do we need to do that in mw.ArticleTarget for mobile too?
[23:31:05] 	 I can move the whole thing up to the main ArticleTarget, really.
[23:31:29] 	 (03PS2) 10DLynch: DesktopArticleTarget: Clear stored summary value after save completes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342143 (https://phabricator.wikimedia.org/T160130)
[23:34:15] 	 It's not clear to me why some bits aren't in MobileAT.
[23:34:26] 	 (And now I've Star Wars nerd-sniped myself.)
[23:37:47] 	 Lots of the saveComplete bits seem broadly-relevant, at least.
[23:39:06] * James_F nods.
[23:40:39] 	 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), 15User-Ryasmeen, and 3 others: NWE: Icons after external links missing in preview - https://phabricator.wikimedia.org/T153413#3089868 (10Ryasmeen)