[00:01:07] (03CR) 10Dereckson: [C: 032] "SWAT" [extensions/VisualEditor] (wmf/1.29.0-wmf.15) - 10https://gerrit.wikimedia.org/r/342087 (https://phabricator.wikimedia.org/T158692) (owner: 10Jforrester) [00:16:29] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), 15User-Ryasmeen, and 3 others: NWE preview has different styling for headings than the real page - https://phabricator.wikimedia.org/T155774#3090004 (10Ryasmeen) [00:22:00] (03Merged) 10jenkins-bot: ArticleTargetLoader: wikitext switch shouldn't require FullRestbaseURL [extensions/VisualEditor] (wmf/1.29.0-wmf.15) - 10https://gerrit.wikimedia.org/r/342087 (https://phabricator.wikimedia.org/T158692) (owner: 10Jforrester) [00:32:40] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 15User-Ryasmeen: VE crashes after opening Link inspector in the same position after deleting link - https://phabricator.wikimedia.org/T114064#3090022 (10Ryasmeen) Yes this looks fixed. However, I see a solid grey slug when I open the link inspector in the same... [00:47:24] Kemayo: OK, now I'm finding init reset issues everywhere I look. [00:47:48] Kemayo: An additional "This page doesn't exist yet" edit notice gets added every time you switch modes on new pages. [00:48:05] James_F: it's a very profitable avenue for investigation, it turns out. [00:49:29] There's a whole class of issues which are "hit save then start a new edit without reloading the page", which might be best fixed with a more complete tear down and recreation of the init than we do now. [00:50:06] Kemayo: And we just pushed your fullRestBase patch to prod but it doesn't seem to have fixed the switching-loses-code issue in private wikis… [00:50:21] * James_F considers giving up for the day. [00:51:08] Hm. I'll look at it again once I finish my dinner. See how these private wikis differ from my vm setup. [00:51:37] * James_F nods. [00:52:59] It's possible my patch makes a bad assumption about the non-full restbaseUrl config value, would be my immediate guess. [00:53:07] Maybe. [00:55:01] 10VisualEditor, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), 13Patch-For-Review: Lost work when switching from wikitext to visual modes on wikitech and private wikis (not using RESTbase) - https://phabricator.wikimedia.org/T158692#3090049 (10Jdforrester-WMF) p:05Triage>03Unbreak! a:03DLync... [00:56:25] Ooooooooooh. [00:56:29] I'm a fool. [00:57:04] Private wikis don't have fullRestbaseUrls because they are blocked from switching; NWE's switcher needs to be disabled when that's not available. [01:06:50] And the new switcher assumes you can always switch [01:09:55] (03PS1) 10Jforrester: ArticleTarget#switchToVisualEditor: Bail if the server won't let you switch [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342160 (https://phabricator.wikimedia.org/T158692) [01:32:39] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 15User-Ryasmeen: VE crashes after opening Link inspector in the same position after deleting link - https://phabricator.wikimedia.org/T114064#3090094 (10Jdforrester-WMF) Fuuun. File a new task? :-) [01:36:05] 10VisualEditor, 10CodeEditor, 07Easy, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), 15User-Ryasmeen: Should throw an exception if WikiEditor is not installed - https://phabricator.wikimedia.org/T67072#3090098 (10Jdforrester-WMF) 05Open>03Resolved [01:40:07] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), 15User-Ryasmeen: Visual editing mode available even on namespaces where it shouldn't be - https://phabricator.wikimedia.org/T159834#3090118 (10Jdforrester-WMF) 05Open>03Resolved Nope,... [01:43:29] 10VisualEditor: A solid grey slug appears when opening the link inspector in the same position after deleting a link by pressing backspace - https://phabricator.wikimedia.org/T160143#3090122 (10Ryasmeen) [01:44:39] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 15User-Ryasmeen: VE crashes after opening Link inspector in the same position after deleting link - https://phabricator.wikimedia.org/T114064#3090136 (10Ryasmeen) done :) T160143 [02:04:27] But that still won't fix the reported problem (WT->VE loss in a non-private wiki). [03:05:15] 10VisualEditor, 10VisualEditor-ContentLanguage, 07TestMe: Pressing the Shift key moves the cursor (Windows only?) - https://phabricator.wikimedia.org/T156228#3090180 (10Whatamidoing-WMF) @EdErhart-WMF is having the same problem, also in Windows 10 (and I cheerfully volunteer him to demonstrate this via video... [03:06:30] James_F: according to https://doc.wikimedia.org/VisualEditor/master/#!/api/ve.dm.MWWikitextSurface shouldn't the parameter to setSelection() be a selection object...somehow? [03:06:56] Yes. What are you trying to do? [03:14:38] 10VisualEditor, 10VisualEditor-ContentLanguage, 07TestMe: Pressing the Shift key moves the cursor (Windows only?) - https://phabricator.wikimedia.org/T156228#3090182 (10Whatamidoing-WMF) User:Endercase (who is willing to answer questions and test things for you) reports a problem in Chrome/Windows 10 that ma... [05:09:00] James_F: https://phabricator.wikimedia.org/T160102 [05:09:14] James_F: I know the first/last character positions and I want to highlight/select them [05:10:13] First/last positions in terms of DOM or in terms of wikitext? [05:11:49] Remember that VE doesn't know anything about the wikitext. Going from wikitext position to DOM position would be a Parsoid task. [05:13:24] Making lintId force non-VE/NWE is pretty easy, just add it to the blacklist in DesktopArticleTarget -- https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/e163a09105ac92fe54d1952ae3ced845118f0dd1/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js#L861 [05:13:35] But it'd be nice to have it actually work. [05:14:15] And also in hooks.php [05:17:48] 10VisualEditor, 10MediaWiki-extensions-Linter: Make Linter edit helper compatible with VisualEditor - https://phabricator.wikimedia.org/T160102#3088843 (10Jdforrester-WMF) https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/e163a09105ac92fe54d1952ae3ced845118f0dd1/modules/ve-mw/init/targets/ve.... [05:27:06] James_F: what about doing the selection in NWE where we should know the wikitext position? [05:28:35] NWE models each \n-seperated line of wikitext as its own node. Theoretically you could go from document-wikitext-position to node+in-node position, but I don't think we have that helper function written. [05:30:11] ok, seems like for now I should just blacklist the lintId parameter now and get back to this a bit later [05:40:19] Yeah. Make it edsanders's problem, it'll be fixed in an hour. ;-) [05:54:36] 10VisualEditor, 10MediaWiki-extensions-Linter: Make Linter edit helper compatible with VisualEditor - https://phabricator.wikimedia.org/T160102#3090254 (10Legoktm) @Esanders any ideas/suggestions on how to make this work for NWE? [05:54:52] James_F: {{done}} [05:55:23] * James_F grins. [07:45:55] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Show a different tooltip for mode switch tool when no switch is possible - https://phabricator.wikimedia.org/T159807#3090316 (10Schnark) Or (don't know whether this has been discussed before) add a third option to the dropdown: "Abort editing" (which... [09:01:23] 10VisualEditor, 10MediaWiki-extensions-Linter: Make Linter edit helper compatible with VisualEditor - https://phabricator.wikimedia.org/T160102#3088843 (10Schnark) ```lang = js ve.init.target.getSurface().getModel().setLinearSelection( new ve.Range( start, end ) ) ``` sets a selection in NWE. The indices are... [11:03:21] 10VisualEditor: "PopupWidget#toggle: Before calling this method, the popup must be attached to the DOM." console warning while editing in VE - https://phabricator.wikimedia.org/T160161#3090681 (10Schnark) [11:05:56] (03CR) 10Esanders: [C: 04-1] DesktopArticleTarget: Clear stored summary value after save completes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342143 (https://phabricator.wikimedia.org/T160130) (owner: 10DLynch) [11:25:37] 10VisualEditor, 10ProofreadPage: Proofread page inspector 'insert' button always disabled - https://phabricator.wikimedia.org/T160162#3090706 (10Esanders) [11:55:42] 10VisualEditor, 10MediaWiki-extensions-Linter: Make Linter edit helper compatible with VisualEditor - https://phabricator.wikimedia.org/T160102#3090735 (10Esanders) Yeah, for now you would just have to count newlines up to an offset to convert indicies: ``` function getModelOffsetFromWikitextOffset( offset )... [14:28:18] (03PS1) 10Esanders: PositionedTargetToolbar: Move code that assumes surface exists to after check [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342213 [14:36:06] (03PS3) 10Tchanders: Generalize DiffElement logic (improves lists and tables) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340656 (https://phabricator.wikimedia.org/T149537) [14:36:54] (03CR) 10Jforrester: [C: 032] PositionedTargetToolbar: Move code that assumes surface exists to after check [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342213 (owner: 10Esanders) [14:41:47] (03Merged) 10jenkins-bot: PositionedTargetToolbar: Move code that assumes surface exists to after check [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342213 (owner: 10Esanders) [14:54:57] (03CR) 10jenkins-bot: PositionedTargetToolbar: Move code that assumes surface exists to after check [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342213 (owner: 10Esanders) [14:57:33] 10VisualEditor, 10Math, 07Documentation: add a link to documentation of of and formulas to the formula insertion dialogs in VisualEditor - https://phabricator.wikimedia.org/T159447#3067737 (10Esanders) That would be https://meta.wikimedia.org/wiki/Help:Displaying_a_formula, although I'm not sur... [15:11:31] (03CR) 10Esanders: Generalize DiffElement logic (improves lists and tables) (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340656 (https://phabricator.wikimedia.org/T149537) (owner: 10Tchanders) [15:18:20] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 05MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), 15User-Ryasmeen: Inconsistent availability of "Insert signature" between the visual editor and the 2017 source editor - https://phabricator.wikimedia.org/T157286#3091133 (10Elitre) (Fixed... [15:18:50] (03PS4) 10Tchanders: Generalize DiffElement logic (improves lists and tables) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340656 (https://phabricator.wikimedia.org/T149537) [15:23:52] (03CR) 10Tchanders: Generalize DiffElement logic (improves lists and tables) (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340656 (https://phabricator.wikimedia.org/T149537) (owner: 10Tchanders) [16:12:46] (03PS1) 10Esanders: Remove $returnFocusTo hack now null is supported upstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342227 [16:18:16] (03CR) 10DLynch: DesktopArticleTarget: Clear stored summary value after save completes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342143 (https://phabricator.wikimedia.org/T160130) (owner: 10DLynch) [16:18:38] (03CR) 10Jforrester: [C: 032] Remove $returnFocusTo hack now null is supported upstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342227 (owner: 10Esanders) [16:19:21] (03PS3) 10DLynch: DesktopArticleTarget: Clear stored summary value after save completes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342143 (https://phabricator.wikimedia.org/T160130) [16:21:38] (03Merged) 10jenkins-bot: Remove $returnFocusTo hack now null is supported upstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342227 (owner: 10Esanders) [16:25:20] (03CR) 10jenkins-bot: Remove $returnFocusTo hack now null is supported upstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342227 (owner: 10Esanders) [16:40:27] (03PS1) 10Esanders: Fix cursor style on language search widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342236 [16:40:29] (03PS1) 10Esanders: Move demo's qqx language option into the language dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342237 [16:51:19] (03PS1) 10Tchanders: Update gallery actions in response to changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342240 [16:51:41] (03Abandoned) 10Tchanders: WIP Update gallery dialog actions to reflect presence of changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315449 (https://phabricator.wikimedia.org/T62311) (owner: 10Tchanders) [17:17:32] (03PS1) 10Tchanders: Remove line breaks from gallery dialog captions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342242 (https://phabricator.wikimedia.org/T153373) [17:23:57] (03CR) 10jerkins-bot: [V: 04-1] Remove line breaks from gallery dialog captions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342242 (https://phabricator.wikimedia.org/T153373) (owner: 10Tchanders) [17:27:41] (03PS2) 10Tchanders: Remove line breaks from gallery dialog captions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342242 (https://phabricator.wikimedia.org/T153373) [18:56:22] 10VisualEditor: [Regression pre wmf.16] Link Inspector is appearing broken on the first attempt every session - https://phabricator.wikimedia.org/T160190#3091667 (10Ryasmeen) [19:10:23] 10VisualEditor: [Regression pre wmf.16] Link Inspector is appearing broken on the first attempt every session - https://phabricator.wikimedia.org/T160190#3091712 (10Ryasmeen) Actually, its happening for all context menus. Also there is an error in the console: Uncaught TypeError: Cannot read property 'center' of... [19:12:22] 10VisualEditor: [Regression pre wmf.16] All Inspectors and context menus are appearing broken on the first attempt every session. - https://phabricator.wikimedia.org/T160190#3091719 (10Ryasmeen) [19:19:13] 10VisualEditor: [Regression pre-wmf.16] Toolbar is not floating as I scroll down in VE, Error in the console "Uncaught TypeError: Cannot read property 'center' of undefined" - https://phabricator.wikimedia.org/T160197#3091801 (10Ryasmeen) [19:22:59] 10VisualEditor: [Regression pre-wmf.16] All Inspectors and context menus are appearing broken on the first attempt every session. - https://phabricator.wikimedia.org/T160190#3091821 (10Ryasmeen) [19:45:01] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Reading-Web-Backlog, and 3 others: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#3091907 (10Whatamidoing-WMF) I've started https://www.mediawiki.org/wiki/Editing/Projects/Colu... [19:49:02] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: Copying and pasting removes blank lines in Microsoft Edge - https://phabricator.wikimedia.org/T160202#3091936 (10Whatamidoing-WMF) [20:11:13] (03CR) 10Jforrester: [C: 032] Remove line breaks from gallery dialog captions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342242 (https://phabricator.wikimedia.org/T153373) (owner: 10Tchanders) [20:12:01] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 15User-Ryasmeen: Adding a new line in the caption for an image in Gallery creates a blank image space, makes Gallery inaccessible after insertion - https://phabricator.wikimedia.org/T153373#3092031 (10Jdforrester-WMF) 05Open>03Resolved... [20:12:39] (03CR) 10Jforrester: [C: 032] Fix cursor style on language search widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342236 (owner: 10Esanders) [20:16:47] (03Merged) 10jenkins-bot: Fix cursor style on language search widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342236 (owner: 10Esanders) [20:18:13] (03PS2) 10Jforrester: demo: Move qqx language option into the language selector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342237 (owner: 10Esanders) [20:18:17] (03CR) 10Jforrester: [C: 032] demo: Move qqx language option into the language selector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342237 (owner: 10Esanders) [20:20:07] (03CR) 10jenkins-bot: Fix cursor style on language search widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342236 (owner: 10Esanders) [20:21:41] (03Merged) 10jenkins-bot: demo: Move qqx language option into the language selector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342237 (owner: 10Esanders) [20:23:38] (03CR) 10Jforrester: [C: 032] DesktopArticleTarget: Clear stored summary value after save completes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342143 (https://phabricator.wikimedia.org/T160130) (owner: 10DLynch) [20:24:02] (03CR) 10jenkins-bot: demo: Move qqx language option into the language selector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342237 (owner: 10Esanders) [20:24:27] 10VisualEditor, 10VisualEditor-MediaWiki, 07Regression, 15User-Ryasmeen: [Regression pre-wmf.16] Edit summary is showing previous session's edit summary - https://phabricator.wikimedia.org/T160130#3092062 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal [20:28:03] (03CR) 10Jforrester: "Is this solving T62311?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342240 (owner: 10Tchanders) [20:28:30] (03Merged) 10jenkins-bot: Remove line breaks from gallery dialog captions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342242 (https://phabricator.wikimedia.org/T153373) (owner: 10Tchanders) [20:32:31] (03Merged) 10jenkins-bot: DesktopArticleTarget: Clear stored summary value after save completes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342143 (https://phabricator.wikimedia.org/T160130) (owner: 10DLynch) [20:34:16] (03CR) 10jenkins-bot: Remove line breaks from gallery dialog captions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342242 (https://phabricator.wikimedia.org/T153373) (owner: 10Tchanders) [20:38:50] (03CR) 10jenkins-bot: DesktopArticleTarget: Clear stored summary value after save completes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342143 (https://phabricator.wikimedia.org/T160130) (owner: 10DLynch) [20:39:12] 10VisualEditor: [Regression pre-wmf.16] Toolbar is not floating as I scroll down in VE, Error in the console "Uncaught TypeError: Cannot read property 'center' of undefined" - https://phabricator.wikimedia.org/T160197#3092086 (10Jdforrester-WMF) What browser is this in? I can't replicate on Chrome. [20:40:14] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI: [Regression pre-wmf.16] Context menus for items below the screen appear broken (no vertical height) - https://phabricator.wikimedia.org/T160190#3092091 (10Jdforrester-WMF) p:05Triage>03Unbreak! [20:40:37] * James_F sighs. [20:41:11] RoanKattouw: I know you're super-busy but I think we've found another regression caused by your scrollable/etc. changes. :-( ^^^ [20:41:49] WTF [20:41:54] A JS error, too [20:42:00] So hopefully simple [20:42:16] I don't get the JS error, ignore that for now. [20:42:50] Hmm OK maybe it's the overflow issue then [20:42:54] I'll look [20:43:21] Ta. [20:47:32] I can't repro [20:48:13] Neither locally nor in beta [20:48:41] RoanKattouw: My testing was on Chrome. Click on a node the bottom of which is not in the window. [20:49:23] Oh I see it now [20:50:12] The only reason it "works" the second time is that it's often scrolled the item into view by then (but seemingly not always in my testing). [20:50:15] Wait and now I can't repro again [20:50:33] It seemed like something like focusing a node, then resizing the window so its bottom is out of view, and then selecting a link, worked [20:50:34] But not every time [20:51:37] Yeah. :-( [20:52:08] I'm going to get lunch but if you find more reliable reproduction steps do let me know [21:33:57] 10VisualEditor, 10Parsoid: Unnecessary when editing indent-pre with lines starting with '*' - https://phabricator.wikimedia.org/T160207#3092151 (10matmarex) [22:20:03] 10VisualEditor, 10MediaWiki-extensions-Linter, 13Patch-For-Review: Make Linter edit helper compatible with VisualEditor - https://phabricator.wikimedia.org/T160102#3092218 (10Legoktm) Thanks for the help so far - I got most of it working except the highlight flashes and then immediately goes away. :( [23:22:58] 10VisualEditor, 10ArchCom-RfC, 06Parsing-Team, 06Performance-Team, and 4 others: Decide on storage and delivery method for TemplateStyles CSS - https://phabricator.wikimedia.org/T155813#3092357 (10dr0ptp4kt) Okay, so if I understand correctly: 3E is too hard right now, and could and probably should come a... [23:51:04] (03PS2) 10Jforrester: Update VE core submodule to master (bc0001c53) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342041 (https://phabricator.wikimedia.org/T159439)