[00:21:21] 10VisualEditor, 06Editing-Department, 10MediaWiki-General-or-Unknown, 10MediaWiki-Parser, 07Technical-Debt: Selflinks should still be tags with CSS styling via a class, not tags - https://phabricator.wikimedia.org/T160480#3100569 (10Legoktm) So these would be clickable? [00:22:21] 10VisualEditor, 06Editing-Department, 10MediaWiki-General-or-Unknown, 10MediaWiki-Parser, 07Technical-Debt: Selflinks should still be tags with CSS styling via a class, not tags - https://phabricator.wikimedia.org/T160480#3100575 (10Jdforrester-WMF) >>! In T160480#3100569, @Legoktm wrote: >... [00:34:41] 10VisualEditor, 10MediaWiki-Vagrant, 15User-zeljkofilipin: Provisioning visualeditor role fails with `Unable to locate package zookeeper-server` - https://phabricator.wikimedia.org/T159931#3083708 (10Jdforrester-WMF) Given that Vagrant has switched over to Jessie is this now Resolved? [00:42:36] 10VisualEditor, 06Editing-Department, 10MediaWiki-General-or-Unknown, 10MediaWiki-Parser, 07Technical-Debt: Selflinks should still be tags with CSS styling via a class, not tags - https://phabricator.wikimedia.org/T160480#3100391 (10matmarex) If that's a problem, we could make them literally... [00:43:27] 10VisualEditor, 10MediaWiki-Vagrant, 15User-zeljkofilipin: Provisioning visualeditor role fails with `Unable to locate package zookeeper-server` - https://phabricator.wikimedia.org/T159931#3100642 (10SBisson) >>! In T159931#3100628, @Jdforrester-WMF wrote: > Given that Vagrant has switched over to Jessie is... [00:47:42] 10VisualEditor, 10MediaWiki-Vagrant, 15User-Ryasmeen, 15User-zeljkofilipin: Provisioning visualeditor role fails with `Unable to locate package zookeeper-server` - https://phabricator.wikimedia.org/T159931#3100646 (10Jdforrester-WMF) 05Open>03Resolved a:03Jdforrester-WMF Declaring that it is, then. T... [00:48:19] 10VisualEditor, 10MediaWiki-Vagrant, 15User-Ryasmeen, 15User-zeljkofilipin: Provisioning visualeditor role fails with `Unable to locate package zookeeper-server` - https://phabricator.wikimedia.org/T159931#3100651 (10Jdforrester-WMF) a:05Jdforrester-WMF>03Pchelolo [02:31:56] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Reading-Web-Backlog, and 3 others: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#349580 (10Arthur2e5) Hi, on zhwp there seems to be still some good amount of confusion among a... [03:39:07] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Reading-Web-Backlog, and 3 others: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#795805 (10Cwek) I want ask that Could it the tag add two parameters ('class' and 'style') to s... [04:29:08] 10VisualEditor, 10VisualEditor-MediaWiki: Update defaults for VisualEditorBrowserBlacklist - https://phabricator.wikimedia.org/T160494#3100818 (10Krinkle) [05:16:57] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Reading-Web-Backlog, and 3 others: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#3100846 (10Arthur2e5) >>! In T33597#3100752, @Cwek wrote: Here it comes. > Old tag is a clea... [05:32:58] 10Citoid, 10VisualEditor: Nature.com articles gives citoid 401s. - https://phabricator.wikimedia.org/T1380#3100877 (10czar) Does that mean a bypass was created to handle these? I can confirm that the sample citation also compiles properly in the VE's Citoid dialog. [05:42:58] 10Citoid, 10VisualEditor: Citoid not working on nutritionjrnl.com (Nutrition) - https://phabricator.wikimedia.org/T156243#3100879 (10czar) But EM support is planned, right? So this task would be blocked by that one (looks like T140539 is the closest ticket) Looks like a fix was proposed in https://github.com/... [05:43:18] 10Citoid, 10VisualEditor, 06Services, 13Patch-For-Review: Update translation-server, citoid - https://phabricator.wikimedia.org/T140539#3100881 (10czar) [05:43:20] 10Citoid, 10VisualEditor: Citoid not working on nutritionjrnl.com (Nutrition) - https://phabricator.wikimedia.org/T156243#3100880 (10czar) [05:55:10] 10Cite, 10MobileFrontend, 06Reading-Web-Backlog: Enable responsive references on mobile devices - https://phabricator.wikimedia.org/T160497#3100897 (10Arthur2e5) [05:56:45] 10Cite, 10MobileFrontend, 06Reading-Web-Backlog: Enable responsive references on mobile devices - https://phabricator.wikimedia.org/T160497#3100911 (10Arthur2e5) [06:47:20] 10Cite: New parameters to allow to set the class and style of div.mw-references-wrap which is rendered by the with the parameter 'responsive' - https://phabricator.wikimedia.org/T160498#3100927 (10Cwek) [06:48:32] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Reading-Web-Backlog, and 3 others: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#3100940 (10Cwek) [06:48:34] 10Cite: New parameters to allow to set the class and style of div.mw-references-wrap which is rendered by the with the parameter 'responsive' - https://phabricator.wikimedia.org/T160498#3100939 (10Cwek) [06:57:36] 10Cite: New parameters to allow to set the class and style of div.mw-references-wrap which is rendered by the with the parameter 'responsive' - https://phabricator.wikimedia.org/T160498#3100927 (10Arthur2e5) > of div.mw-references-wrap You are possibly more interested in adding it directly to the... [06:57:50] 10VisualEditor, 06Editing-Department: Obviate the need for wikis' wrapper and functionality-replacement templates - https://phabricator.wikimedia.org/T95543#1194043 (10Arthur2e5) [06:57:57] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Reading-Web-Backlog, and 3 others: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#3100950 (10Arthur2e5) [06:57:59] 10Cite: New parameters to allow to set the class and style of div.mw-references-wrap which is rendered by the with the parameter 'responsive' - https://phabricator.wikimedia.org/T160498#3100948 (10Arthur2e5) [07:28:18] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Reading-Web-Backlog, and 3 others: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#3100974 (10Arthur2e5) [07:28:20] 10Cite: New parameters to allow to set the class and style of div.mw-references-wrap which is rendered by the with the parameter 'responsive' - https://phabricator.wikimedia.org/T160498#3100973 (10Arthur2e5) [08:22:08] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Design, 07Epic: Provide a second version of a beta modern wikitext editor integrated into the visual editor - https://phabricator.wikimedia.org/T142523#3101025 (10Schnark) [08:22:11] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Documentation, 15User-Ryasmeen: Update documentation for VE gadgets to include information about NWE - https://phabricator.wikimedia.org/T150081#3101023 (10Schnark) 05Open>03Resolved Well, okay, nobody wants to comment on it, so I just link... [10:12:14] 10Cite: New parameters to allow to set the class and style of div.mw-references-wrap which is rendered by the with the parameter 'responsive' - https://phabricator.wikimedia.org/T160498#3100927 (10TheDJ) I'd say there is no need for a style attribute, but yes classes would be interesting. 10Citoid, 10VisualEditor, 13Patch-For-Review: Visual Editor adds erroneous text "PMC" to citation template pmc= parameter - https://phabricator.wikimedia.org/T157152#3101319 (10Elitre) FWIW [[ https://de.wikipedia.org/w/index.php?title=Benutzerin%3AElitre_%28WMF%29%2Fsandbox&type=revision&diff=163600871&oldi... [10:23:41] 10Citoid, 10VisualEditor, 13Patch-For-Review: Strings of digits currently only search for PMIDs; Add multiple results and include OCLC and PMC in the search - https://phabricator.wikimedia.org/T115248#3101331 (10Elitre) [10:28:34] 10Citoid, 10VisualEditor, 13Patch-For-Review: Strings of digits currently only search for PMIDs; Add multiple results and include OCLC and PMC in the search - https://phabricator.wikimedia.org/T115248#3101337 (10Elitre) How would this work in practice though? We are pasting just strings without the identifie... [10:39:36] 10VisualEditor, 07Browser-Tests, 13Patch-For-Review, 15User-zeljkofilipin: Selenium tests for VisualEditor in Node.js - https://phabricator.wikimedia.org/T150435#3101388 (10zeljkofilipin) a:05Ryasmeen>03zeljkofilipin [10:39:51] 10VisualEditor, 07Browser-Tests, 13Patch-For-Review, 15User-zeljkofilipin: Selenium tests for VisualEditor in Node.js - https://phabricator.wikimedia.org/T150435#2785898 (10zeljkofilipin) p:05Normal>03Low [11:19:01] (03PS3) 10Esanders: DiffElement: Ensure del/ins tags encapsulate annotation changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 [11:19:03] (03PS10) 10Esanders: Diff attribute changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 [11:19:05] (03PS1) 10Esanders: Refactor rect-from-element computation in FocusableNode into static method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342814 [11:25:30] (03CR) 10jerkins-bot: [V: 04-1] Diff attribute changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 (owner: 10Esanders) [11:53:59] (03PS11) 10Esanders: Diff attribute changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 [11:58:37] (03CR) 10jerkins-bot: [V: 04-1] Diff attribute changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 (owner: 10Esanders) [12:40:54] 10VisualEditor, 10VisualEditor-EditingTools, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), 15User-Ryasmeen: Highlighting on word you are looking for looks broken - https://phabricator.wikimedia.org/T159439#3101706 (10Jerrykim306) Closed as resolved: I've tested on my user sandbox, I'm terribly... [12:57:27] (03PS1) 10Esanders: Remove MSIE from blacklist, already blacklisted upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342824 (https://phabricator.wikimedia.org/T160494) [13:07:16] (03CR) 10jerkins-bot: [V: 04-1] Remove MSIE from blacklist, already blacklisted upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342824 (https://phabricator.wikimedia.org/T160494) (owner: 10Esanders) [14:02:43] (03PS12) 10Esanders: Diff attribute changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 [14:02:45] (03PS1) 10Esanders: Add custom messages for change descriptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342834 [14:04:14] 10VisualEditor, 10ArchCom-RfC, 06Parsing-Team, 06Performance-Team, and 4 others: Decide on storage and delivery method for TemplateStyles CSS - https://phabricator.wikimedia.org/T155813#3102099 (10dr0ptp4kt) @Jdlrobson we're down to 3A and 3E. 3A is simpler to implement and probably less error prone, but w... [14:06:49] (03CR) 10jerkins-bot: [V: 04-1] Diff attribute changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 (owner: 10Esanders) [14:09:24] (03CR) 10jerkins-bot: [V: 04-1] Add custom messages for change descriptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342834 (owner: 10Esanders) [14:46:16] 10Cite, 10Wikimedia-Site-requests: wgCiteResponsiveReferences should be "true" for nowiki, consensus established earlier about use of and responsive design - https://phabricator.wikimedia.org/T160362#3102270 (10jeblad) [14:57:59] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, and 6 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3102302 (10Trizek-WMF... [15:11:35] 10Citoid, 10VisualEditor, 13Patch-For-Review: Visual Editor adds erroneous text "PMC" to citation template pmc= parameter - https://phabricator.wikimedia.org/T157152#3102371 (10Whatamidoing-WMF) The problem is [[https://de.wikipedia.org/w/index.php?title=Benutzerin:Elitre_(WMF)/sandbox&diff=163609098&oldid=1... [15:34:10] (03PS13) 10Jforrester: Diff attribute changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 (owner: 10Esanders) [15:35:29] (03CR) 10Jforrester: [C: 031] Refactor rect-from-element computation in FocusableNode into static method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342814 (owner: 10Esanders) [15:45:08] (03Abandoned) 10DatGuy: Convert raw html messages to normal messages [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/331334 (https://phabricator.wikimedia.org/T154891) (owner: 10DatGuy) [15:45:39] 10WikiEditor, 07Easy: Several of the wikieditor-toolbar-* messages are used as raw html - https://phabricator.wikimedia.org/T154891#3102496 (10DatGuy) [16:03:51] (03CR) 10Esanders: "The diff David mentioned in his first comment seems to work for me." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 (owner: 10Esanders) [16:13:29] (03PS1) 10DLynch: ElementLinearData: when removing original dom elements, remap hashes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342847 (https://phabricator.wikimedia.org/T154123) [16:17:34] 10Citoid, 10VisualEditor, 06Services, 13Patch-For-Review: Update translation-server, citoid - https://phabricator.wikimedia.org/T140539#3102746 (10mobrovac) [16:17:37] 10Citoid, 10VisualEditor: Citoid not working on nutritionjrnl.com (Nutrition) - https://phabricator.wikimedia.org/T156243#3102745 (10mobrovac) [16:18:04] 10Citoid, 10VisualEditor, 06Services, 13Patch-For-Review: Update translation-server, citoid - https://phabricator.wikimedia.org/T140539#2468385 (10mobrovac) [16:18:07] 10Citoid, 10VisualEditor: Citoid not working on nutritionjrnl.com (Nutrition) - https://phabricator.wikimedia.org/T156243#2968418 (10mobrovac) [16:37:55] (03CR) 10DLynch: [C: 032] Refactor rect-from-element computation in FocusableNode into static method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342814 (owner: 10Esanders) [16:40:24] (03Merged) 10jenkins-bot: Refactor rect-from-element computation in FocusableNode into static method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342814 (owner: 10Esanders) [16:41:06] 10Cite: New parameters to allow to set the class and style of div.mw-references-wrap which is rendered by the with the parameter 'responsive' - https://phabricator.wikimedia.org/T160498#3102894 (10Arthur2e5) @TheDJ You and I may want to hijack this issue to make it target the entire `ol.references... [16:44:24] (03CR) 10jenkins-bot: Refactor rect-from-element computation in FocusableNode into static method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342814 (owner: 10Esanders) [16:53:32] 10VisualEditor, 10VisualEditor-CopyPaste, 13Patch-For-Review, 07Regression: VisualEditor: when pasting wikified text from an article, the text style (including link) can't be modified - https://phabricator.wikimedia.org/T154123#3102926 (10The_RedBurn) [16:54:56] 10VisualEditor, 10VisualEditor-CopyPaste, 13Patch-For-Review, 07Regression: VisualEditor: when pasting wikified text from an article, the text style (including link) can't be modified - https://phabricator.wikimedia.org/T154123#3102934 (10DLynch) Specifically, a regression due to T142943 / 14b5fbc3. [17:03:33] MatmaRex: Are you coming? [17:03:45] hi [17:13:43] (03PS1) 10VolkerE: Update OOjs UI to v0.20.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342859 [17:17:04] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.20.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342859 (owner: 10VolkerE) [17:20:04] James_F: oh also. you resolved https://phabricator.wikimedia.org/T117165 , but there are a few commits still pending to finish it [17:20:25] (03Merged) 10jenkins-bot: Update OOjs UI to v0.20.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342859 (owner: 10VolkerE) [17:20:33] MatmaRex: I know, I was hoping you'd fix the unit tests so I can make it true. ;-) [17:21:04] heh, okay [17:23:31] (03CR) 10jenkins-bot: Update OOjs UI to v0.20.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342859 (owner: 10VolkerE) [17:26:07] (03PS4) 10Bartosz Dziewoński: ve.ui.MWLinkAction: Use delayed sequence [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341288 (https://phabricator.wikimedia.org/T117165) [17:28:25] James_F: Do you know where edsanders is? He hasn't been on IRC in 12 days and hasn't responded to any emails. [17:28:55] is he on vacation? [17:29:12] kaldari: What e-mails? [17:29:37] just emails from me [17:30:20] We normally use Phabricator with a side-channel of GChat and meetings. [17:31:06] If you CC me on e-mails I can help. [17:31:28] kaldari: I've been here :) [17:31:44] * edsanders searches for email from kaldari [17:32:11] edsanders: weird, IRC whois said you had been idle for 12 days :P [17:32:23] it knows me well [17:33:06] I've been head down this last few weeks trying to finish off our quarterly goal [17:35:10] if you schedule a meeting for next week that would be good - if you can do early in the day pacific time then we might be able to get David Chan in too as I'd like his input on potential IME issues. [17:36:05] (03CR) 10Esanders: "*works when I recreate the diff in standalone, but not as a unit test :/" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 (owner: 10Esanders) [17:36:25] Oh, is this the CodeMirror stuff? I imagine you're going to have to wrap it in a "Don't activate IME here" class for ULS, which is easy (but sad). If it works with the IMEs that'd be awesome. [17:36:58] I think the idea is it would be background colours only in a sub-layer, not text colours [17:37:11] putting spans in the document is an IME non-starter from what I understand [17:42:43] (03PS2) 10Esanders: Remove MSIE from blacklist, already blacklisted upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342824 (https://phabricator.wikimedia.org/T160494) [17:44:44] (03PS1) 10Esanders: Fix position of ace tooltip [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342871 (https://phabricator.wikimedia.org/T160245) [17:44:55] (03CR) 10Jforrester: [C: 032] "Weren't we going to bump this to IE9 for CX compat? I guess we can always revive." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342824 (https://phabricator.wikimedia.org/T160494) (owner: 10Esanders) [17:45:17] (03PS1) 10Esanders: Remove zero argument from ve.debounce [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342872 [17:45:32] 10VisualEditor, 10VisualEditor-MediaWiki, 07Technical-Debt: Update defaults for VisualEditorBrowserBlacklist - https://phabricator.wikimedia.org/T160494#3103239 (10Jdforrester-WMF) p:05Triage>03Low a:05Jdforrester-WMF>03Esanders [17:46:07] (03PS1) 10Esanders: Add extra rules for word-break: break-word [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342873 [17:48:22] 10Cite, 10MobileFrontend, 06Reading-Web-Backlog: Enable responsive references on mobile devices - https://phabricator.wikimedia.org/T160497#3100897 (10Jdlrobson) The mobile site already has responsive references. Could you elaborate and share a URL where you are not seeing them as being responsive? [17:48:49] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 15User-Ryasmeen: Sometimes user-inserted ISBNs don't get converted to magic links somehow, meaning Parsoid has to nowiki them… - https://phabricator.wikimedia.org/T117165#3103267 (10matmarex) >>! In T117165... [17:49:06] (03PS1) 10Bartosz Dziewoński: ve.ce.Surface: Check delayed sequences when deactivating surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342875 (https://phabricator.wikimedia.org/T117165) [17:49:40] (03PS5) 10Bartosz Dziewoński: ve.ui.MWLinkAction: Use delayed sequence [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341288 (https://phabricator.wikimedia.org/T117165) [17:50:23] (03CR) 10Bartosz Dziewoński: "I think I2af0a738afa43295bf6d7d612cac4349bc6cd20d (in VE core) is a better solution for that." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341288 (https://phabricator.wikimedia.org/T117165) (owner: 10Bartosz Dziewoński) [17:51:07] (03PS3) 10Bartosz Dziewoński: ve.ui.MWLinkAction: Improve ISBN and RFC/PMID autolinking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341291 (https://phabricator.wikimedia.org/T117165) [17:52:25] (03CR) 10Bartosz Dziewoński: "To elaborate: we have unit tests for the 'autolinkMagicLink' command, which is used by all of the new sequences. But we have no tests for " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341291 (https://phabricator.wikimedia.org/T117165) (owner: 10Bartosz Dziewoński) [17:54:03] (03PS4) 10Bartosz Dziewoński: ve.ui.MWLinkAction: Improve ISBN and RFC/PMID autolinking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341291 (https://phabricator.wikimedia.org/T117165) [17:54:45] (03CR) 10Jforrester: [C: 032] Fix position of ace tooltip [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342871 (https://phabricator.wikimedia.org/T160245) (owner: 10Esanders) [17:55:43] 10VisualEditor, 10VisualEditor-MediaWiki, 10SyntaxHighlight, 15User-Ryasmeen: Unusable scrollbar shown in dialog to edit in VE - https://phabricator.wikimedia.org/T160245#3103293 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03Esanders [17:56:58] (03PS2) 10Jforrester: MWMediaInfoFieldWidget: Add extra rules for word-break: break-word [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342873 (owner: 10Esanders) [17:57:02] (03CR) 10Jforrester: [C: 032] MWMediaInfoFieldWidget: Add extra rules for word-break: break-word [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342873 (owner: 10Esanders) [17:57:57] (03PS2) 10Jforrester: MWExtensionWindow: Remove pointless zero argument from ve.debounce call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342872 (owner: 10Esanders) [17:58:03] (03CR) 10Jforrester: [C: 032] MWExtensionWindow: Remove pointless zero argument from ve.debounce call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342872 (owner: 10Esanders) [18:06:29] (03Merged) 10jenkins-bot: Remove MSIE from blacklist, already blacklisted upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342824 (https://phabricator.wikimedia.org/T160494) (owner: 10Esanders) [18:09:37] (03CR) 10jerkins-bot: [V: 04-1] Fix position of ace tooltip [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342871 (https://phabricator.wikimedia.org/T160245) (owner: 10Esanders) [18:10:02] (03CR) 10jerkins-bot: [V: 04-1] Fix position of ace tooltip [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342871 (https://phabricator.wikimedia.org/T160245) (owner: 10Esanders) [18:14:31] 10VisualEditor, 10WikiEditor, 06Community-Liaisons, 06Editing-Department, and 8 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#3103424 (10Jdforrester-WMF) OK, this is now live on all wikis except Wikin... [18:14:36] (03Merged) 10jenkins-bot: MWMediaInfoFieldWidget: Add extra rules for word-break: break-word [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342873 (owner: 10Esanders) [18:15:41] edsanders: sorry, had to run to a meeting... [18:16:02] edsanders: I'll schedule a meeting for next week so we can sit down and discuss in more detail [18:17:26] edsanders: FWIW, CodeMirror does both text coloring and background coloring [18:17:48] but we can always change it [18:18:37] If it's modifying the DOM the user is editing then it won't work with IMEs [18:18:54] most code editors don't care about IMEs because most code is written with latin script only [18:19:58] but as soon as you change the spans any active IME will close - and there is no reliable event to tell you if an IME is open or not [18:23:52] edsanders: how can I test that? FWIW, Amir said that CodeMirror had good LTR support, but no idea about IMEs [18:24:10] (03Merged) 10jenkins-bot: MWExtensionWindow: Remove pointless zero argument from ve.debounce call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342872 (owner: 10Esanders) [18:24:39] well looking at the demo on their site, and given that it supports text colouring - it is definitely modifying the editor's DOM [18:24:50] yes [18:25:11] it's creating an HTML mirror of the textarea [18:26:46] how does the New Wikitext editor support IMEs? Isn't it also modifying the DOM? [18:27:41] (03CR) 10jenkins-bot: Remove MSIE from blacklist, already blacklisted upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342824 (https://phabricator.wikimedia.org/T160494) (owner: 10Esanders) [18:30:54] kaldari: We have to fix up after IMEs, which is why it's taken six years to get this far. [18:31:40] 10VisualEditor, 03Interactive-Sprint, 06Maps (Kartographer): Disable VE editing of maplink / mapframe when the editor is not able to - https://phabricator.wikimedia.org/T157996#3103479 (10Deskana) @Esanders Is this something you or someone else in the VisualEditor team can help with? It's been nearly a month... [18:32:14] We were planning on making syntax highlighting a double opt-in feature anyway - first enable in preferences, then turn on in the editor (which would be sticky), so I don't think IME support would be a blocker for it. [18:32:32] * James_F nods. [18:33:14] I'm a bit worried about how it interacts with other editing gadgets though. [18:33:27] so that will require some investigation [18:33:45] (03CR) 10jenkins-bot: MWMediaInfoFieldWidget: Add extra rules for word-break: break-word [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342873 (owner: 10Esanders) [18:40:55] we make sure the IME edits the correct text node - and carefully observe [18:41:28] the problem with a highlighter is that making text changes can trigger a complete DOM re-render at any time [18:42:47] (03CR) 10jenkins-bot: MWExtensionWindow: Remove pointless zero argument from ve.debounce call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342872 (owner: 10Esanders) [18:44:48] (03PS2) 10Esanders: Fix position of ace tooltip [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342871 (https://phabricator.wikimedia.org/T160245) [18:51:12] (03PS3) 10Jforrester: MWAceEditorWidget: Fix position of ace tooltip [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342871 (https://phabricator.wikimedia.org/T160245) (owner: 10Esanders) [18:51:28] (03CR) 10Jforrester: [C: 032] MWAceEditorWidget: Fix position of ace tooltip [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342871 (https://phabricator.wikimedia.org/T160245) (owner: 10Esanders) [18:51:52] (03PS14) 10Esanders: Diff attribute changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 [18:51:54] (03PS2) 10Esanders: Add custom messages for change descriptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342834 [19:00:47] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Ryasmeen: NWE shows me the HTML version when attempting second edit on same page - https://phabricator.wikimedia.org/T155632#3103560 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal OK, I've now spent ~20 minutes searching f... [19:01:35] (03CR) 10jerkins-bot: [V: 04-1] MWAceEditorWidget: Fix position of ace tooltip [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342871 (https://phabricator.wikimedia.org/T160245) (owner: 10Esanders) [19:02:32] (03PS4) 10Jforrester: MWAceEditorWidget: Fix position of ace tooltip [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342871 (https://phabricator.wikimedia.org/T160245) (owner: 10Esanders) [19:02:37] (03CR) 10jerkins-bot: [V: 04-1] MWAceEditorWidget: Fix position of ace tooltip [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342871 (https://phabricator.wikimedia.org/T160245) (owner: 10Esanders) [19:02:53] (03CR) 10Jforrester: [C: 032] "This fix-up-a-commit thing works better when you add the changes you made." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342871 (https://phabricator.wikimedia.org/T160245) (owner: 10Esanders) [19:09:48] 10VisualEditor, 10ArchCom-RfC, 06Parsing-Team, 06Performance-Team, and 5 others: Decide on storage and delivery method for TemplateStyles CSS - https://phabricator.wikimedia.org/T155813#3103609 (10Anomie) 05Open>03Resolved a:03Anomie Ok, this seems to be resolved now. The final decision is 1B+2C+3A/3... [19:23:39] (03Merged) 10jenkins-bot: MWAceEditorWidget: Fix position of ace tooltip [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342871 (https://phabricator.wikimedia.org/T160245) (owner: 10Esanders) [19:33:06] (03CR) 10jenkins-bot: MWAceEditorWidget: Fix position of ace tooltip [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342871 (https://phabricator.wikimedia.org/T160245) (owner: 10Esanders) [19:36:37] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 07Technical-Debt, 15User-Ryasmeen: Update defaults for VisualEditorBrowserBlacklist - https://phabricator.wikimedia.org/T160494#3103677 (10Jdforrester-WMF) 05Open>03Resolved [20:12:52] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Ryasmeen: NWE shows me the HTML version when attempting second edit on same page - https://phabricator.wikimedia.org/T155632#3103792 (10Izno) I think you did. However, now I'm getting a similar problem: When my default editor is NWE, I get d... [20:15:51] 10VisualEditor: Empty suggested params being added when a citation is edited with the cite tool - https://phabricator.wikimedia.org/T160568#3103800 (10Mvolz) [20:18:48] 10Cite, 10VisualEditor: Cite plugin not working - https://phabricator.wikimedia.org/T160050#3103822 (10Mvolz) [21:24:14] (03PS1) 10Jforrester: Don't load VE or NWE on lint-targetted pages (until that works) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342915 (https://phabricator.wikimedia.org/T160102) [21:29:43] (03CR) 10Jforrester: [C: 032] ve.ce.Surface: Check delayed sequences when deactivating surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342875 (https://phabricator.wikimedia.org/T117165) (owner: 10Bartosz Dziewoński) [21:33:58] (03Merged) 10jenkins-bot: ve.ce.Surface: Check delayed sequences when deactivating surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342875 (https://phabricator.wikimedia.org/T117165) (owner: 10Bartosz Dziewoński) [21:35:54] (03PS15) 10Esanders: Diff attribute changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 [21:35:56] (03PS3) 10Esanders: Add custom messages for change descriptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342834 [21:35:58] (03PS4) 10Esanders: DiffElement: Ensure del/ins tags encapsulate annotation changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 [21:36:20] (03CR) 10jenkins-bot: ve.ce.Surface: Check delayed sequences when deactivating surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342875 (https://phabricator.wikimedia.org/T117165) (owner: 10Bartosz Dziewoński) [21:45:42] 10Cite, 10MobileFrontend, 06Reading-Web-Backlog: Enable responsive references on mobile devices - https://phabricator.wikimedia.org/T160497#3104112 (10Arthur2e5) Ah, a more careful look at https://m.mediawiki.org/wiki/User:Artoria2e5/t1 shows the references is actually present. It's just the `.content` eleme... [21:49:37] (03PS16) 10Jforrester: Visual diffing: Show attribute changes in a sidebar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 (owner: 10Esanders) [21:53:57] (03CR) 10Jforrester: [C: 031] "Leaving to Thal." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 (owner: 10Esanders) [21:57:41] (03PS1) 10Jforrester: Update VE core submodule to master (da310202f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342945 [21:58:15] (03PS6) 10Jforrester: ve.ui.MWLinkAction: Use delayed sequence [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341288 (https://phabricator.wikimedia.org/T117165) (owner: 10Bartosz Dziewoński) [21:58:28] (03PS5) 10Jforrester: ve.ui.MWLinkAction: Improve ISBN and RFC/PMID autolinking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341291 (https://phabricator.wikimedia.org/T117165) (owner: 10Bartosz Dziewoński) [22:08:17] (03CR) 10Jforrester: [C: 032] ve.ui.MWLinkAction: Improve ISBN and RFC/PMID autolinking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341291 (https://phabricator.wikimedia.org/T117165) (owner: 10Bartosz Dziewoński) [22:08:20] (03CR) 10Jforrester: [C: 032] ve.ui.MWLinkAction: Use delayed sequence [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341288 (https://phabricator.wikimedia.org/T117165) (owner: 10Bartosz Dziewoński) [22:14:01] (03PS17) 10Esanders: Diff attribute changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 [22:14:03] (03PS4) 10Esanders: Add custom messages for change descriptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342834 [22:14:06] (03PS5) 10Esanders: DiffElement: Ensure del/ins tags encapsulate annotation changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 [22:21:09] (03PS18) 10Esanders: VisualDiff: Show attribute changes in a sidebar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 (https://phabricator.wikimedia.org/T151404) [22:21:12] (03PS5) 10Esanders: Add custom messages for change descriptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342834 [22:21:14] (03PS6) 10Esanders: DiffElement: Ensure del/ins tags encapsulate annotation changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 [22:21:49] (03CR) 10Jforrester: [C: 031] VisualDiff: Show attribute changes in a sidebar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 (https://phabricator.wikimedia.org/T151404) (owner: 10Esanders) [22:28:22] (03PS9) 10Esanders: Introduce visual differ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338101 [22:28:24] (03PS1) 10Esanders: Visual diff attribute changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342949 [22:39:33] (03CR) 10Tchanders: [C: 032] VisualDiff: Show attribute changes in a sidebar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 (https://phabricator.wikimedia.org/T151404) (owner: 10Esanders) [22:42:37] (03CR) 10jerkins-bot: [V: 04-1] Visual diff attribute changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342949 (owner: 10Esanders) [22:43:20] (03Merged) 10jenkins-bot: VisualDiff: Show attribute changes in a sidebar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 (https://phabricator.wikimedia.org/T151404) (owner: 10Esanders) [22:45:39] (03CR) 10jenkins-bot: VisualDiff: Show attribute changes in a sidebar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/340160 (https://phabricator.wikimedia.org/T151404) (owner: 10Esanders) [22:50:01] (03CR) 10Jforrester: Add custom messages for change descriptions (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342834 (owner: 10Esanders) [22:53:03] (03CR) 10Jforrester: Add custom messages for change descriptions (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342834 (owner: 10Esanders) [22:58:44] (03PS6) 10Jforrester: VisualDiff: Add custom messages for change descriptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342834 (owner: 10Esanders) [23:00:28] (03CR) 10Jforrester: [C: 032] VisualDiff: Add custom messages for change descriptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342834 (owner: 10Esanders) [23:03:57] (03Merged) 10jenkins-bot: VisualDiff: Add custom messages for change descriptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342834 (owner: 10Esanders) [23:10:00] (03CR) 10jenkins-bot: VisualDiff: Add custom messages for change descriptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342834 (owner: 10Esanders) [23:10:32] (03PS7) 10Jforrester: DiffElement: Ensure del/ins tags encapsulate annotation changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 (owner: 10Esanders) [23:18:13] (03PS8) 10Jforrester: DiffElement: Ensure del/ins tags encapsulate annotation changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 (owner: 10Esanders) [23:18:33] (03CR) 10Jforrester: "PS8: Added David's failing test." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 (owner: 10Esanders) [23:23:47] (03CR) 10jerkins-bot: [V: 04-1] DiffElement: Ensure del/ins tags encapsulate annotation changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 (owner: 10Esanders) [23:29:08] 10VisualEditor, 10VisualEditor-EditingTools: VisualDiffs: Show complex annotation creations and removals in the sidebar (link, language, span) - https://phabricator.wikimedia.org/T160588#3104470 (10Jdforrester-WMF) [23:30:36] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References: VisualDiffs: Add custom messages for reference changes - https://phabricator.wikimedia.org/T160589#3104489 (10Jdforrester-WMF) [23:32:04] (03PS1) 10Jforrester: Update VE core submodule to master (8817821b6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342963 (https://phabricator.wikimedia.org/T151404) [23:38:28] 10VisualEditor, 10VisualEditor-MediaWiki, 07Category, 07Epic: Let users choose a visual or wikitext diff in the review-your-changes tab - https://phabricator.wikimedia.org/T143350#3104536 (10Jdforrester-WMF) [23:38:30] 10VisualEditor, 10VisualEditor-MediaWiki: When re-starting a local draft, show the user a diff so they know what they're getting into - https://phabricator.wikimedia.org/T143341#3104537 (10Jdforrester-WMF) [23:38:32] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design: Redesign save dialog / diff view - https://phabricator.wikimedia.org/T140451#3104535 (10Jdforrester-WMF) [23:39:06] (03PS10) 10Jforrester: Introduce visual differ in the save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338101 (https://phabricator.wikimedia.org/T143350) (owner: 10Esanders) [23:42:58] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References: VisualDiffs: Add custom messages for reference changes - https://phabricator.wikimedia.org/T160589#3104562 (10Jdforrester-WMF) [23:43:00] 10VisualEditor, 10VisualEditor-EditingTools: VisualDiffs: Show complex annotation creations and removals in the sidebar (link, language, span) - https://phabricator.wikimedia.org/T160588#3104563 (10Jdforrester-WMF) [23:43:02] 10VisualEditor, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)): Fix whitespace errors in visual diffs - https://phabricator.wikimedia.org/T158895#3104564 (10Jdforrester-WMF) [23:43:04] 10VisualEditor: VisualDiff: Handle table diffs separately - https://phabricator.wikimedia.org/T158445#3104565 (10Jdforrester-WMF) [23:43:06] 10VisualEditor, 07Design, 13Patch-For-Review: Have the visual diff system display content attribute changes - https://phabricator.wikimedia.org/T156189#3104566 (10Jdforrester-WMF) [23:43:09] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-History-or-Diffs, 10UI-Standardization, and 2 others: Design a way to present content changes in a rich text context - https://phabricator.wikimedia.org/T152001#3104567 (10Jdforrester-WMF) [23:43:13] 10VisualEditor, 10VisualEditor-MediaWiki, 07Category, 07Epic, 13Patch-For-Review: Let users choose a visual or wikitext diff in the review-your-changes tab - https://phabricator.wikimedia.org/T143350#3104561 (10Jdforrester-WMF) [23:45:12] 10VisualEditor, 10Timeless: MediaWiki VisualEditor and PageAttachment compatibility - https://phabricator.wikimedia.org/T132005#3104568 (10Jdforrester-WMF)