[00:11:47] (03CR) 10Jforrester: [C: 031] "This might even be landable as-is." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338101 (https://phabricator.wikimedia.org/T143350) (owner: 10Esanders) [00:12:10] MatmaRex: You know how you love me to bits, right? https://gerrit.wikimedia.org/r/#/c/342945/ would be nice to merge. :-) [00:14:06] anytime [00:14:08] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (da310202f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342945 (owner: 10Jforrester) [00:21:05] Thanks. :-) [00:23:09] 10VisualEditor, 10VisualEditor-MediaWiki: Have the visual diff system work with MW-core-specific node types like images and templates - https://phabricator.wikimedia.org/T151403#3104702 (10Jdforrester-WMF) [00:23:16] (03CR) 10Jforrester: "Squash into parent? Also this can be tagged against T151403" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342949 (owner: 10Esanders) [00:30:02] (03Merged) 10jenkins-bot: Update VE core submodule to master (da310202f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342945 (owner: 10Jforrester) [00:30:06] (03Merged) 10jenkins-bot: ve.ui.MWLinkAction: Use delayed sequence [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341288 (https://phabricator.wikimedia.org/T117165) (owner: 10Bartosz Dziewoński) [00:30:08] (03Merged) 10jenkins-bot: ve.ui.MWLinkAction: Improve ISBN and RFC/PMID autolinking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341291 (https://phabricator.wikimedia.org/T117165) (owner: 10Bartosz Dziewoński) [00:37:04] (03CR) 10jenkins-bot: Update VE core submodule to master (da310202f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342945 (owner: 10Jforrester) [00:39:12] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 15User-Ryasmeen: Sometimes user-inserted ISBNs don't get converted to magic links somehow, meaning Parsoid has to nowiki them… - https://phabricator.wikimedia.org/T117165#3104767 (10Jdforrester-WMF) [00:42:40] (03CR) 10jenkins-bot: ve.ui.MWLinkAction: Use delayed sequence [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341288 (https://phabricator.wikimedia.org/T117165) (owner: 10Bartosz Dziewoński) [00:46:58] (03CR) 10jenkins-bot: ve.ui.MWLinkAction: Improve ISBN and RFC/PMID autolinking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341291 (https://phabricator.wikimedia.org/T117165) (owner: 10Bartosz Dziewoński) [02:06:03] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI: [Regression wmf.16] Context menus for items below the screen appear broken (no vertical height) - https://phabricator.wikimedia.org/T160190#3104892 (10Jdforrester-WMF) a:03Catrope [02:15:07] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools: [Regression wmf.16] Cursor jumps to the beginning of the page after adding a focusable node - https://phabricator.wikimedia.org/T160479#3104895 (10Jdforrester-WMF) p:05Triage>03Unbreak! [02:16:15] (03PS2) 10Jforrester: Visual diff attribute changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342949 (owner: 10Esanders) [02:24:56] (03CR) 10jerkins-bot: [V: 04-1] Visual diff attribute changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342949 (owner: 10Esanders) [02:41:49] 10VisualEditor: [Regression wmf.16] Toolbar is not floating as I scroll down in VE, Error in the console "Uncaught TypeError: Cannot read property 'center' of undefined" - https://phabricator.wikimedia.org/T160197#3104927 (10Jdforrester-WMF) p:05Triage>03Unbreak! [02:50:42] 10VisualEditor: [Regression wmf.16] Toolbar is not floating as I scroll down in VE, Error in the console "Uncaught TypeError: Cannot read property 'center' of undefined" - https://phabricator.wikimedia.org/T160197#3104934 (10Jdforrester-WMF) I also can't get the JS error after I select a focussable node, even on... [02:51:29] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools: [Regression wmf.16] Cursor jumps to the beginning of the page after adding a focusable node - https://phabricator.wikimedia.org/T160479#3104935 (10Jdforrester-WMF) p:05Unbreak!>03High [04:41:08] (03CR) 10Legoktm: [C: 032] Don't load VE or NWE on lint-targetted pages (until that works) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342915 (https://phabricator.wikimedia.org/T160102) (owner: 10Jforrester) [04:56:36] 10VisualEditor: [Regression wmf.16] Toolbar is not floating as I scroll down in VE, Error in the console "Uncaught TypeError: Cannot read property 'center' of undefined" - https://phabricator.wikimedia.org/T160197#3091801 (10DLynch) I cannot persuade this to happen, either. Reading `computerPosition`, I don't se... [04:59:34] (03Merged) 10jenkins-bot: Don't load VE or NWE on lint-targetted pages (until that works) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342915 (https://phabricator.wikimedia.org/T160102) (owner: 10Jforrester) [05:05:55] (03CR) 10jenkins-bot: Don't load VE or NWE on lint-targetted pages (until that works) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342915 (https://phabricator.wikimedia.org/T160102) (owner: 10Jforrester) [07:14:07] 10Cite: Please enable the Responsive column change on frwiki - https://phabricator.wikimedia.org/T160609#3105066 (10Oliv0) [07:19:19] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342984 (owner: 10L10n-bot) [08:14:02] 10VisualEditor, 10VisualEditor-EditingTools, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), 15User-Ryasmeen: Highlighting on word you are looking for looks broken - https://phabricator.wikimedia.org/T159439#3105188 (10Schnark) This task is resolved, but the fix isn't deployed yet. You can see t... [09:16:57] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 15User-Ryasmeen: Sometimes user-inserted ISBNs don't get converted to magic links somehow, meaning Parsoid has to nowiki them… - https://phabricator.wikimedia.org/T117165#3105301 (10Schnark) IMHO the behavi... [09:23:51] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: Single Edit Tab global default change - https://phabricator.wikimedia.org/T159032#3105332 (10Alsee) @Jdforrester-WMF, it's been almost three weeks since I opened this bug. Can I get an answer on this? You said VE wouldn't be imposed as the... [09:57:53] 10VisualEditor, 06Discovery, 10RelatedArticles, 10UI-Standardization, and 3 others: Align the style for lists of pages - https://phabricator.wikimedia.org/T153417#3105411 (10Jdrewniak) A recent patch by @JGirault https://gerrit.wikimedia.org/r/#/c/342296/ changes the highlight color on the portal typeahead... [10:02:57] 10Cite, 10Wikimedia-Site-requests: Please enable the Responsive column change on frwiki - https://phabricator.wikimedia.org/T160609#3105428 (10Aklapper) "the Responsive column change" is probably something in T33597 ? I'm asking as I have no idea which Cite variable (or such) this request is about exactly. Se... [10:15:59] (03PS9) 10Esanders: DiffElement: Ensure del/ins tags encapsulate annotation changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 [10:19:15] 10VisualEditor, 06Discovery, 10RelatedArticles, 10UI-Standardization, and 3 others: Align the style for lists of pages - https://phabricator.wikimedia.org/T153417#2879950 (10Deskana) Highlight colours for lists of articles (e.g. search on the portal) need not be the same as highlight colours for other kind... [10:20:29] (03CR) 10jerkins-bot: [V: 04-1] DiffElement: Ensure del/ins tags encapsulate annotation changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 (owner: 10Esanders) [10:20:48] 10VisualEditor, 10UI-Standardization: Odd text-style selection behaviour on non-text elements - https://phabricator.wikimedia.org/T160622#3105457 (10Jdrewniak) [10:21:35] 10VisualEditor, 10UI-Standardization: Odd text-format selection behaviour on non-text elements - https://phabricator.wikimedia.org/T160622#3105470 (10Jdrewniak) [10:23:29] (03CR) 10Esanders: [C: 032] ElementLinearData: when removing original dom elements, remap hashes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342847 (https://phabricator.wikimedia.org/T154123) (owner: 10DLynch) [10:26:20] (03CR) 10Esanders: "We can use the linkcache to add classes but if we change the element we lose event bindings." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/341775 (https://phabricator.wikimedia.org/T52497) (owner: 10Esanders) [10:28:51] (03CR) 10Esanders: "I'd prefer to use the correct DOM (i.e. but if that is impractical we may have to do something like this)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342084 (https://phabricator.wikimedia.org/T52497) (owner: 10Jforrester) [10:30:08] (03CR) 10Esanders: Render self-links as if they were s (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342084 (https://phabricator.wikimedia.org/T52497) (owner: 10Jforrester) [10:34:01] (03CR) 10Esanders: Render self-links as if they were s (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342084 (https://phabricator.wikimedia.org/T52497) (owner: 10Jforrester) [10:52:03] 10Cite, 10Wikimedia-Site-requests: Please enable the Responsive column change on frwiki - https://phabricator.wikimedia.org/T160609#3105066 (10TheDJ) @Aklapper the var is `CiteResponsiveReferences`. Note that this ticket is created by the template at https://www.mediawiki.org/wiki/Editing/Projects/Columns_for_... [10:53:52] 10Cite, 10MobileFrontend, 06Reading-Web-Backlog: Unify responsive reference list styling of mobile and desktop - https://phabricator.wikimedia.org/T160497#3105511 (10TheDJ) [10:54:17] (03CR) 10jerkins-bot: [V: 04-1] ElementLinearData: when removing original dom elements, remap hashes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342847 (https://phabricator.wikimedia.org/T154123) (owner: 10DLynch) [10:55:04] 10Cite, 10MobileFrontend, 06Reading-Web-Backlog: Unify responsive reference list styling of mobile and desktop - https://phabricator.wikimedia.org/T160497#3100897 (10TheDJ) I think it's still a interoperability issue in principle. These things should just use the same styling, and not keep 2 sets of differen... [10:56:34] 10Citoid, 10VisualEditor, 10Outreach-Programs-Projects, 10Possible-Tech-Projects, and 2 others: Write a Zotero translator and document process for creating new Zotero translator and getting it live in production - https://phabricator.wikimedia.org/T115158#3105517 (10Mvolz) >>! In T115158#3093746, @czar wro... [11:12:11] (03PS1) 10Esanders: Revert "Remove $returnFocusTo hack now null is supported upstream" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343029 (https://phabricator.wikimedia.org/T160479) [11:18:36] 10VisualEditor, 10VisualEditor-ContentLanguage, 10VisualEditor-MediaWiki-2017WikitextEditor, 07I18n, 07RTL: Using browser IME to switch input direction is impossible in the new wikitext editor - https://phabricator.wikimedia.org/T153356#2878066 (10Esanders) What does the user have to have installed for t... [11:22:14] 10VisualEditor, 10VisualEditor-ContentLanguage, 10VisualEditor-MediaWiki-2017WikitextEditor, 07I18n, 07RTL: Using browser IME to switch input direction is impossible in the new wikitext editor - https://phabricator.wikimedia.org/T153356#3105602 (10Esanders) In Chrome I can change the writing direction fr... [11:34:12] (03PS1) 10Esanders: Remove redundant setDisabled calls from tools extending ve.ui.Tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343034 [11:44:31] 10VisualEditor, 10VisualEditor-ContentLanguage, 10VisualEditor-MediaWiki-2017WikitextEditor, 07I18n, 07RTL: Using browser functions to switch input direction is impossible in the new wikitext editor - https://phabricator.wikimedia.org/T153356#3105668 (10Amire80) [11:46:20] 10Cite: New columns feature for references tag wasn't changed mediawiki message - https://phabricator.wikimedia.org/T160628#3105671 (10IKhitron) [11:46:38] 10Cite: New columns feature for references tag wasn't changed mediawiki message - https://phabricator.wikimedia.org/T160628#3105683 (10IKhitron) p:05Triage>03Unbreak! [11:59:32] 10Cite, 10MobileFrontend, 06Reading-Web-Backlog: Unify responsive reference list styling of mobile and desktop - https://phabricator.wikimedia.org/T160497#3100897 (10phuedx) p:05Triage>03Normal [12:13:41] 10Cite: New columns feature for references tag wasn't changed mediawiki message - https://phabricator.wikimedia.org/T160628#3105766 (10Aklapper) p:05Unbreak!>03Triage > We have a new parameter in references tag from yesterday, responsive I guess that was {T33597}? The issue (a non-updated misleading string... [12:14:19] 10VisualEditor, 10Wikimedia-Site-requests, 07Spanish-Sites: Re-enable VisualEditor by default for all users of the Spanish Wikipedia - https://phabricator.wikimedia.org/T119974#3105771 (10Liuxinyu970226) [12:28:01] 10VisualEditor, 07I18n: undocument parameters in visualeditor-changedesc-align - https://phabricator.wikimedia.org/T160632#3105776 (10Amire80) [12:29:31] (03PS1) 10Esanders: Add tool to change directionality of document view [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343040 (https://phabricator.wikimedia.org/T153356) [12:29:48] 10VisualEditor, 06Discovery, 10RelatedArticles, 10UI-Standardization, and 3 others: Align the style for lists of pages - https://phabricator.wikimedia.org/T153417#2879950 (10debt) Would this new treatment (blue link over lighter blue highlighting) work the same for the portal on mobile and desktop? [12:29:58] 10Cite, 10Wikimedia-Site-requests: Please enable the Responsive column change on frwiki - https://phabricator.wikimedia.org/T160609#3105795 (10Oliv0) Yes, the title was [[ https://www.mediawiki.org/w/index.php?title=Editing/Projects/Columns_for_references&diff=2419737&oldid=prev | set by Whatamidoing (WMF)]],... [13:01:32] 10Cite: New columns feature for references tag wasn't changed mediawiki message - https://phabricator.wikimedia.org/T160628#3105884 (10IKhitron) Yes, it is. I'm glad you are agree with me it's not unbreak now, as I already wrote in the task description. [15:00:40] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Editing tool to changing case - https://phabricator.wikimedia.org/T52745#3106265 (10Liuxinyu970226) [15:07:16] 10VisualEditor, 07Technical-Debt: VisualEditor: Share ref / references re-rendering code with Parsoid - https://phabricator.wikimedia.org/T52505#3106329 (10Liuxinyu970226) [15:08:32] (03CR) 10Jforrester: [C: 032] "Retry…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342847 (https://phabricator.wikimedia.org/T154123) (owner: 10DLynch) [15:10:41] (03CR) 10Jforrester: [C: 032] "Meh." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343029 (https://phabricator.wikimedia.org/T160479) (owner: 10Esanders) [15:12:33] 10Cite, 10Wikimedia-Site-requests: Please enable the Responsive column change on frwiki - https://phabricator.wikimedia.org/T160609#3106342 (10Aklapper) >>! In T160609#3105503, @TheDJ wrote: > @Aklapper the var is `CiteResponsiveReferences`. Note that this ticket is created by the template at https://www.media... [15:12:46] (03Merged) 10jenkins-bot: ElementLinearData: when removing original dom elements, remap hashes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342847 (https://phabricator.wikimedia.org/T154123) (owner: 10DLynch) [15:13:20] (03PS1) 10Jforrester: ElementLinearData: when removing original dom elements, remap hashes [VisualEditor/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343064 (https://phabricator.wikimedia.org/T154123) [15:13:27] (03CR) 10Jforrester: [C: 032] ElementLinearData: when removing original dom elements, remap hashes [VisualEditor/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343064 (https://phabricator.wikimedia.org/T154123) (owner: 10Jforrester) [15:13:57] (03CR) 10Jforrester: [C: 032] Remove redundant setDisabled calls from tools extending ve.ui.Tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343034 (owner: 10Esanders) [15:16:01] (03Merged) 10jenkins-bot: Revert "Remove $returnFocusTo hack now null is supported upstream" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343029 (https://phabricator.wikimedia.org/T160479) (owner: 10Esanders) [15:17:31] 10Cite, 10Wikimedia-Site-requests: Please enable the Responsive column change on frwiki - https://phabricator.wikimedia.org/T160609#3106367 (10Jdforrester-WMF) [15:17:35] 10Cite, 10Wikimedia-Site-requests: wgCiteResponsiveReferences should be "true" for nowiki, consensus established earlier about use of and responsive design - https://phabricator.wikimedia.org/T160362#3106368 (10Jdforrester-WMF) [15:17:37] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Community-Liaisons: Support wikis in converting reference lists over to `responsive` - https://phabricator.wikimedia.org/T159895#3106366 (10Jdforrester-WMF) [15:19:22] 10Cite, 10Wikimedia-Site-requests: Please enable the Responsive column change on frwiki - https://phabricator.wikimedia.org/T160609#3105066 (10Jdforrester-WMF) I've fixed the link in the template. [15:19:39] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Reading-Web-Backlog, and 3 others: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#3106374 (10Jdforrester-WMF) [15:19:41] 10Cite, 10Wikimedia-Site-requests: Please enable the Responsive column change on frwiki - https://phabricator.wikimedia.org/T160609#3106373 (10Jdforrester-WMF) [15:19:58] (03Merged) 10jenkins-bot: ElementLinearData: when removing original dom elements, remap hashes [VisualEditor/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343064 (https://phabricator.wikimedia.org/T154123) (owner: 10Jforrester) [15:20:00] (03Merged) 10jenkins-bot: Remove redundant setDisabled calls from tools extending ve.ui.Tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343034 (owner: 10Esanders) [15:20:55] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Community-Liaisons: Support wikis in converting reference lists over to `responsive` - https://phabricator.wikimedia.org/T159895#3106381 (10Jdforrester-WMF) >>! In T159895#3096262, @Qgil wrote: > Is this a request to #community-liaisons or are... [15:21:22] (03PS2) 10Esanders: Add tool to change directionality of document view [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343040 (https://phabricator.wikimedia.org/T153356) [15:21:58] (03PS1) 10Jforrester: Revert "Remove $returnFocusTo hack now null is supported upstream" [VisualEditor/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343068 (https://phabricator.wikimedia.org/T160479) [15:22:03] (03CR) 10Jforrester: [C: 032] Revert "Remove $returnFocusTo hack now null is supported upstream" [VisualEditor/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343068 (https://phabricator.wikimedia.org/T160479) (owner: 10Jforrester) [15:23:05] (03PS1) 10Esanders: [PULL THROUGH] Add tool to change directionality of document view [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343069 (https://phabricator.wikimedia.org/T153356) [15:25:15] (03PS1) 10Jforrester: Update VE core submodule to master (5c4c9e8ed) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343071 (https://phabricator.wikimedia.org/T154123) [15:26:05] (03Merged) 10jenkins-bot: Revert "Remove $returnFocusTo hack now null is supported upstream" [VisualEditor/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343068 (https://phabricator.wikimedia.org/T160479) (owner: 10Jforrester) [15:28:23] (03PS1) 10Jforrester: Update VE core submodule to wmf/1.29.0-wmf.16 HEAD (50a6323d7) [extensions/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343072 (https://phabricator.wikimedia.org/T154123) [15:30:01] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (8817821b6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342963 (https://phabricator.wikimedia.org/T151404) (owner: 10Jforrester) [15:30:14] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (5c4c9e8ed) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343071 (https://phabricator.wikimedia.org/T154123) (owner: 10Jforrester) [15:34:17] (03PS11) 10Esanders: Introduce visual differ in the save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338101 (https://phabricator.wikimedia.org/T143350) [15:34:19] (03PS3) 10Esanders: VisualDiff: Add custom messages for change descriptions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342949 [15:36:53] (03CR) 10jenkins-bot: ElementLinearData: when removing original dom elements, remap hashes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342847 (https://phabricator.wikimedia.org/T154123) (owner: 10DLynch) [15:38:32] 10VisualEditor, 10VisualEditor-MediaWiki, 07Category, 07Epic, 13Patch-For-Review: Let users choose a visual or wikitext diff in the review-your-changes tab - https://phabricator.wikimedia.org/T143350#3106461 (10Jdforrester-WMF) [15:38:35] 10VisualEditor, 10VisualEditor-EditingTools, 07Design, 15User-Ryasmeen: Have the visual diff system display node attribute changes - https://phabricator.wikimedia.org/T151404#3106458 (10Jdforrester-WMF) 05Open>03Resolved a:03Tchanders [15:38:53] 10VisualEditor, 10VisualEditor-MediaWiki, 07Category, 07Epic, 13Patch-For-Review: Let users choose a visual or wikitext diff in the review-your-changes tab - https://phabricator.wikimedia.org/T143350#2565512 (10Jdforrester-WMF) [15:38:55] 10VisualEditor, 10VisualEditor-EditingTools, 07Design, 15User-Ryasmeen: Have the visual diff system display content attribute changes - https://phabricator.wikimedia.org/T156189#3106463 (10Jdforrester-WMF) 05Open>03Resolved [15:42:24] (03Merged) 10jenkins-bot: Update VE core submodule to master (8817821b6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342963 (https://phabricator.wikimedia.org/T151404) (owner: 10Jforrester) [15:44:41] (03CR) 10jenkins-bot: Revert "Remove $returnFocusTo hack now null is supported upstream" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343029 (https://phabricator.wikimedia.org/T160479) (owner: 10Esanders) [15:46:56] (03CR) 10jenkins-bot: ElementLinearData: when removing original dom elements, remap hashes [VisualEditor/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343064 (https://phabricator.wikimedia.org/T154123) (owner: 10Jforrester) [15:47:45] (03Merged) 10jenkins-bot: Update VE core submodule to master (5c4c9e8ed) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343071 (https://phabricator.wikimedia.org/T154123) (owner: 10Jforrester) [15:51:18] (03CR) 10jenkins-bot: Remove redundant setDisabled calls from tools extending ve.ui.Tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343034 (owner: 10Esanders) [15:53:27] (03CR) 10jenkins-bot: Revert "Remove $returnFocusTo hack now null is supported upstream" [VisualEditor/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343068 (https://phabricator.wikimedia.org/T160479) (owner: 10Jforrester) [15:54:25] (03CR) 10jerkins-bot: [V: 04-1] [PULL THROUGH] Add tool to change directionality of document view [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343069 (https://phabricator.wikimedia.org/T153356) (owner: 10Esanders) [16:09:58] 10Cite, 10MobileFrontend, 06Reading-Web-Backlog: Unify responsive reference list styling of mobile and desktop - https://phabricator.wikimedia.org/T160497#3106603 (10Arthur2e5) It might be possible to mention the possibility of customizing the `column-width` for individual wikis via site-level CSS (rationale... [16:18:01] (03CR) 10jerkins-bot: [V: 04-1] VisualDiff: Add custom messages for change descriptions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342949 (owner: 10Esanders) [16:20:07] (03CR) 10jerkins-bot: [V: 04-1] Introduce visual differ in the save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338101 (https://phabricator.wikimedia.org/T143350) (owner: 10Esanders) [16:25:26] (03CR) 10jenkins-bot: Update VE core submodule to master (8817821b6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342963 (https://phabricator.wikimedia.org/T151404) (owner: 10Jforrester) [16:34:33] (03CR) 10jenkins-bot: Update VE core submodule to master (5c4c9e8ed) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343071 (https://phabricator.wikimedia.org/T154123) (owner: 10Jforrester) [16:36:32] (03PS1) 10DLynch: DesktopArticleTarget: Only try to show notices if some exist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343086 (https://phabricator.wikimedia.org/T160161) [16:53:41] 10VisualEditor, 07I18n: undocumented parameters in visualeditor-changedesc-align, visualeditor-changedesc-image-size, visualeditor-changedesc-link-href. - https://phabricator.wikimedia.org/T160632#3106860 (10Amire80) [16:53:57] (03PS4) 10Esanders: VisualDiff: Add custom messages for change descriptions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342949 [17:01:37] (03CR) 10jerkins-bot: [V: 04-1] VisualDiff: Add custom messages for change descriptions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342949 (owner: 10Esanders) [17:14:15] James_F: The only ticket I could stumble across for the edit notices was T153118 which is sort of the opposite of the duplication problem. [17:14:15] T153118: Edit notices box not displaying all the items or not displaying them well? - https://phabricator.wikimedia.org/T153118 [17:14:22] That said, I did find the problem and fix it. [17:15:19] (03PS1) 10DLynch: MWNoticesPopupTool: When setting notices, clear existing notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343095 [17:19:55] Looking. [17:21:32] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review, 07Technical-Debt: "PopupWidget#toggle: Before calling this method, the popup must be attached to the DOM." console warning while editing in VE - https://phabricator.wikimedia.org/T160161#3090681 (10Jdforrester-WMF) p:05Triage>03Normal a:03D... [17:22:59] Maybe I dreamt that I'd made the task? [17:25:42] 10VisualEditor, 10VisualEditor-CopyPaste, 13Patch-For-Review, 07Regression: VisualEditor: when pasting wikified text from an article, the text style (including link) can't be modified - https://phabricator.wikimedia.org/T154123#3107061 (10Jdforrester-WMF) This is now fixed in master, and we'll deploy it to... [17:25:55] 10VisualEditor, 10VisualEditor-CopyPaste, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review, 07Regression: VisualEditor: when pasting wikified text from an article, the text style (including link) can't be modified - https://phabricator.wikimedia.org/T154123#3107064 (10Jdforres... [17:26:13] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review: [Regression wmf.16] Cursor jumps to the beginning of the page after adding a focusable node - https://phabricator.wikimedia.org/T160479#3107066 (10Jdf... [17:32:50] (03CR) 10Jforrester: [C: 032] DesktopArticleTarget: Only try to show notices if some exist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343086 (https://phabricator.wikimedia.org/T160161) (owner: 10DLynch) [17:33:10] (03CR) 10Jforrester: [C: 032] MWNoticesPopupTool: When setting notices, clear existing notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343095 (owner: 10DLynch) [17:42:33] (03Merged) 10jenkins-bot: DesktopArticleTarget: Only try to show notices if some exist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343086 (https://phabricator.wikimedia.org/T160161) (owner: 10DLynch) [17:43:30] 10VisualEditor, 10TPG-Engagements, 07Category, 07Epic, 15User-Jaufrecht Backlog: [EPIC] Conduct second round of VE SLU checkups - https://phabricator.wikimedia.org/T149621#3107172 (10JAufrecht) [17:45:24] 10VisualEditor, 07Category, 07Epic, 10TPG-Engagements (VE Agile Coaching), 15User-Jaufrecht Backlog: [EPIC] Conduct second round of VE SLU checkups - https://phabricator.wikimedia.org/T149621#2758156 (10JAufrecht) [17:46:50] (03Merged) 10jenkins-bot: MWNoticesPopupTool: When setting notices, clear existing notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343095 (owner: 10DLynch) [17:48:38] (03CR) 10jenkins-bot: DesktopArticleTarget: Only try to show notices if some exist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343086 (https://phabricator.wikimedia.org/T160161) (owner: 10DLynch) [17:52:32] (03CR) 10jenkins-bot: MWNoticesPopupTool: When setting notices, clear existing notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343095 (owner: 10DLynch) [17:55:49] 10VisualEditor: [Regression wmf.16] Toolbar is not floating as I scroll down in VE, Error in the console "Uncaught TypeError: Cannot read property 'center' of undefined" - https://phabricator.wikimedia.org/T160197#3107237 (10Ryasmeen) @Dlynch: Sure, I was able to replicate it in both test2 and Beta on following... [17:58:06] 10VisualEditor: [Regression wmf.16] Toolbar is not floating as I scroll down in VE, Error in the console "Uncaught TypeError: Cannot read property 'center' of undefined" - https://phabricator.wikimedia.org/T160197#3107243 (10Jdforrester-WMF) Aha. This looks like it's fallout from {T160190}. [17:59:22] Kemayo: Feel like digging into T160190 then? ;-) [17:59:22] T160190: [Regression wmf.16] Context menus for items below the screen appear broken (no vertical height) - https://phabricator.wikimedia.org/T160190 [18:04:00] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343072 (https://phabricator.wikimedia.org/T154123) (owner: 10Jforrester) [18:06:10] 10VisualEditor, 10VisualEditor-MediaWiki, 15User-Ryasmeen: Switch from VE to wikitext edit mode refused when repeated with edits; onunloadhandler? - https://phabricator.wikimedia.org/T118493#3107267 (10Jdforrester-WMF) 05Open>03Resolved a:03DLynch This is fixed when testing {T153346} too. [18:08:40] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review, and 2 others: "PopupWidget#toggle: Before calling this method, the popup must be attached to the DOM." console warning while editing in ... - https://phabricator.wikimedia.org/T160161#3107284 [18:09:57] Sure, after I finish my lunch. [18:10:47] "Close and reopen VE" does explain why I couldn't trigger anything. :D [18:12:57] 10VisualEditor, 07Technical-Debt: VisualEditor: Share ref / references re-rendering code with Parsoid - https://phabricator.wikimedia.org/T52505#3107332 (10Krinkle) [18:15:45] (03Merged) 10jenkins-bot: Update VE core submodule to wmf/1.29.0-wmf.16 HEAD (50a6323d7) [extensions/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343072 (https://phabricator.wikimedia.org/T154123) (owner: 10Jforrester) [18:29:50] (03PS1) 10Jforrester: Follow-up eb8ba26a: Make MWNoticesTool#setNotices() display its own popup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343107 [18:31:13] Kemayo: Ditto. [18:31:51] Kemayo: In ^^^ I've tried to fiddle with this code to be less crap (and fix an issue), but… I can't actually see what ever does new MWNoticesTool. [18:33:07] E.g. if there's no welcomePromise does that mean we never show the edit notices? [19:15:46] 10Citoid, 10VisualEditor, 10Outreach-Programs-Projects, 10Possible-Tech-Projects, and 2 others: Write a Zotero translator and document process for creating new Zotero translator and getting it live in production - https://phabricator.wikimedia.org/T115158#3107580 (10Mine0901) @czar I am learning to write... [19:23:40] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), 15User-Ryasmeen: [Regression wmf.16] Cursor jumps to the beginning of the page after adding a focusable node - https://phabricator.wikimedia.org/T160479#3107599 (10Jdforr... [19:23:55] 10VisualEditor, 10VisualEditor-CopyPaste, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), 07Regression, 15User-Ryasmeen: VisualEditor: when pasting wikified text from an article, the text style (including link) can't be modified - https://phabricator.wikimedia.org/T154123#3107603 (10Jdforrester... [19:27:51] (03PS3) 10Jforrester: Add tool to change directionality of document view [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343040 (https://phabricator.wikimedia.org/T153356) (owner: 10Esanders) [19:28:36] (03CR) 10Jforrester: [C: 032] "PS3: Added autoAddToCatchall to false so it doesn't appear in the insert menu." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343040 (https://phabricator.wikimedia.org/T153356) (owner: 10Esanders) [19:32:35] 10Citoid, 10VisualEditor, 10Outreach-Programs-Projects, 10Possible-Tech-Projects, and 2 others: Write a Zotero translator and document process for creating new Zotero translator and getting it live in production - https://phabricator.wikimedia.org/T115158#3107630 (10czar) Sent a Phabricator chat invite I... [19:34:59] (03Merged) 10jenkins-bot: Add tool to change directionality of document view [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343040 (https://phabricator.wikimedia.org/T153356) (owner: 10Esanders) [19:38:06] (03CR) 10jenkins-bot: Add tool to change directionality of document view [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343040 (https://phabricator.wikimedia.org/T153356) (owner: 10Esanders) [19:42:50] (03PS2) 10Jforrester: Update VE core submodule to master (ef5dc965f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343069 (https://phabricator.wikimedia.org/T153356) (owner: 10Esanders) [19:43:44] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (ef5dc965f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343069 (https://phabricator.wikimedia.org/T153356) (owner: 10Esanders) [19:44:17] 10VisualEditor, 10VisualEditor-ContentLanguage, 10VisualEditor-MediaWiki-2017WikitextEditor, 07I18n, and 3 others: Using browser functions to switch input direction is impossible in the new wikitext editor - https://phabricator.wikimedia.org/T153356#3107656 (10Jdforrester-WMF) 05Open>03Resolved a:03Es... [19:55:19] James_F: Conveniently, welcomeDialogPromise is more or less guaranteed to exist, because it's always created by maybeShowWelcomeDialog, which is called unless we're specifically suppressing normalStartupDialogs. [19:56:21] I suppose there's an argument to be had over whether the edit notices are technically part of the startup dialogs, of course. [19:57:06] Insofar as they're not modal like the rest of the stuff that's being suppressed. [19:57:08] (03Merged) 10jenkins-bot: Update VE core submodule to master (ef5dc965f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343069 (https://phabricator.wikimedia.org/T153356) (owner: 10Esanders) [20:01:52] (03CR) 10DLynch: [C: 032] Follow-up eb8ba26a: Make MWNoticesTool#setNotices() display its own popup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343107 (owner: 10Jforrester) [20:02:31] * James_F nods. [20:03:33] (03CR) 10jenkins-bot: Update VE core submodule to master (ef5dc965f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343069 (https://phabricator.wikimedia.org/T153356) (owner: 10Esanders) [20:14:06] (03Merged) 10jenkins-bot: Follow-up eb8ba26a: Make MWNoticesTool#setNotices() display its own popup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343107 (owner: 10Jforrester) [20:20:40] (03CR) 10jenkins-bot: Follow-up eb8ba26a: Make MWNoticesTool#setNotices() display its own popup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343107 (owner: 10Jforrester) [20:33:15] 10VisualEditor, 10VisualEditor-ContentLanguage, 10VisualEditor-MediaWiki-2017WikitextEditor, 07I18n, and 4 others: Using browser functions to switch input direction is impossible in the new wikitext editor - https://phabricator.wikimedia.org/T153356#3107851 (10Amire80) Tested in en.wikipedia.beta.wmflabs.o... [20:59:55] 10VisualEditor, 06Discovery, 10RelatedArticles, 10UI-Standardization, and 3 others: Align the style for lists of pages - https://phabricator.wikimedia.org/T153417#3107941 (10JGirault) >>! In T153417#3105793, @debt wrote: > Would this new treatment (blue link over lighter blue highlighting) work the same fo... [21:13:33] 10VisualEditor, 10VisualEditor-ContentLanguage, 10VisualEditor-MediaWiki-2017WikitextEditor, 07I18n, and 4 others: Using browser functions to switch input direction is impossible in the new wikitext editor - https://phabricator.wikimedia.org/T153356#2878066 (10Jdforrester-WMF) Very happy to help. :-) [21:20:43] (03CR) 10Jforrester: [C: 032] Introduce visual differ in the save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338101 (https://phabricator.wikimedia.org/T143350) (owner: 10Esanders) [21:21:48] (03PS5) 10Jforrester: VisualDiff: Add custom messages for change descriptions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342949 (https://phabricator.wikimedia.org/T151403) (owner: 10Esanders) [21:21:54] (03CR) 10Jforrester: [C: 032] VisualDiff: Add custom messages for change descriptions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342949 (https://phabricator.wikimedia.org/T151403) (owner: 10Esanders) [21:22:51] (03CR) 10Jforrester: "We can do upstreaming later; see T160480 for the suggestion to properly change the DOM." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342084 (https://phabricator.wikimedia.org/T52497) (owner: 10Jforrester) [21:24:54] 10VisualEditor, 06Discovery, 10RelatedArticles, 10UI-Standardization, and 3 others: Align the style for lists of pages - https://phabricator.wikimedia.org/T153417#3108143 (10debt) Thanks, just wanted to confirm. :) [21:28:42] (03Merged) 10jenkins-bot: Introduce visual differ in the save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338101 (https://phabricator.wikimedia.org/T143350) (owner: 10Esanders) [21:31:29] 10VisualEditor, 10VisualEditor-MediaWiki, 07Category, 07Epic, 07User-notice: Let users choose a visual or wikitext diff in the review-your-changes tab - https://phabricator.wikimedia.org/T143350#3108213 (10Jdforrester-WMF) [21:33:53] (03CR) 10jerkins-bot: [V: 04-1] VisualDiff: Add custom messages for change descriptions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342949 (https://phabricator.wikimedia.org/T151403) (owner: 10Esanders) [21:36:15] (03PS6) 10Jforrester: VisualDiff: Add custom messages for change descriptions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342949 (https://phabricator.wikimedia.org/T151403) (owner: 10Esanders) [21:36:30] (03CR) 10Jforrester: [C: 032] VisualDiff: Add custom messages for change descriptions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342949 (https://phabricator.wikimedia.org/T151403) (owner: 10Esanders) [21:37:28] (03CR) 10jenkins-bot: Introduce visual differ in the save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338101 (https://phabricator.wikimedia.org/T143350) (owner: 10Esanders) [21:40:45] 10VisualEditor: Odd text-format selection behaviour on non-text elements - https://phabricator.wikimedia.org/T160622#3108245 (10Volker_E) [21:50:09] (03Merged) 10jenkins-bot: VisualDiff: Add custom messages for change descriptions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342949 (https://phabricator.wikimedia.org/T151403) (owner: 10Esanders) [21:54:49] 10VisualEditor, 10VisualEditor-MediaWiki, 15User-Ryasmeen: Have the visual diff system work with MW-core-specific node types like images and templates - https://phabricator.wikimedia.org/T151403#3108329 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders [21:54:52] 10VisualEditor, 10VisualEditor-MediaWiki, 07Category, 07Epic, 07User-notice: Let users choose a visual or wikitext diff in the review-your-changes tab - https://phabricator.wikimedia.org/T143350#3108332 (10Jdforrester-WMF) [21:58:30] (03CR) 10jenkins-bot: VisualDiff: Add custom messages for change descriptions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342949 (https://phabricator.wikimedia.org/T151403) (owner: 10Esanders) [22:04:44] (03PS1) 10Tchanders: Update treeDiffer.js library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343136 [22:05:23] James_F: i saw a few UBN tasks scroll by today - do you need me to work on something? i'm a bit behind on my email [22:06:44] MatmaRex: RoanKattouw's not worked on https://phabricator.wikimedia.org/T160190 for a week now, so… that one if you can? :-( [22:07:04] I saw it on Joe's screen today too :( [22:07:05] MatmaRex: We think it was caused by the scrollable/popup stuff. [22:07:20] It's somewhat intermittent but James_F has repro steps thatwork [22:07:34] For some reason clippable sets height:0 on the context popup [22:08:03] alright. i'll get on it [22:08:17] In my experience this could be because it's doing the math while the popup is off screen, or because there's a miscalculation that causes allotedHeight to be negative (happened in Echo where something was overflow-y: visible by accident), or some other failure mode I've never seen before [22:09:43] But if I was investigating this (still chasing down RCFilters bugs, sorry) I would start with stepping through the calculations in clip() and looking out for those failure modes (as well as looking at what allotedHeight ends up being computed as and why) [22:10:02] Thanks Roan. [22:10:42] Sometimes issues with display:none/visibility:hidden/whatever could also cause the initial width/height of the popup to be measured as 0. It did that previously (breaking Floatable) and I thought I'd fixed that by changing the order in which things are shown, but maybe I didn't or maybe that broke something else [22:10:54] Sorry for dragging this out and not giving it to MatmaRex earlier [22:11:24] The change I was referring to is https://gerrit.wikimedia.org/r/#/c/341038/1 [22:20:39] (03CR) 10Esanders: [C: 032] Update treeDiffer.js library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343136 (owner: 10Tchanders) [22:26:26] (03Merged) 10jenkins-bot: Update treeDiffer.js library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343136 (owner: 10Tchanders) [22:29:40] (03CR) 10jenkins-bot: Update treeDiffer.js library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343136 (owner: 10Tchanders) [22:32:44] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/343188 (owner: 10L10n-bot) [22:35:47] (03PS1) 10DLynch: Follow up ec559041: abort notices display early if no notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343194 [22:36:56] James_F: For some reason, when I reviewed your patch I went "this.destroy() will of course stop anything else happening after it's called". [22:37:24] Ha! [22:37:36] (03CR) 10Jforrester: [C: 032] Follow up ec559041: abort notices display early if no notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343194 (owner: 10DLynch) [22:37:47] I mean, it /sounds/ like it would, right? [22:38:12] Totally logical. [22:41:52] (03CR) 10jerkins-bot: [V: 04-1] Follow up ec559041: abort notices display early if no notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343194 (owner: 10DLynch) [22:42:49] ...the joys of completely unrelated failures. It died on "4 messages lack documentation." [22:43:17] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343193 (owner: 10L10n-bot) [22:43:31] Bleh. [22:43:36] How did stuff pass before? [22:47:12] (03CR) 10jerkins-bot: [V: 04-1] Follow up ec559041: abort notices display early if no notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343194 (owner: 10DLynch) [22:49:39] (03PS1) 10Jforrester: Follow-up 7a8cc04f0: Re-set qqq messages that i18n bot destroyed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343206 [22:49:50] Kemayo: ^^^ Merge that please. :-) [22:50:12] (03CR) 10DLynch: [C: 032] Follow-up 7a8cc04f0: Re-set qqq messages that i18n bot destroyed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343206 (owner: 10Jforrester) [22:53:03] 10VisualEditor: [Regression wmf.16] Toolbar is not floating as I scroll down in VE, Error in the console "Uncaught TypeError: Cannot read property 'center' of undefined" - https://phabricator.wikimedia.org/T160197#3108600 (10DLynch) The issue seems to be that when you leave-and-reenter VE, the popup instance per... [22:58:35] (03Merged) 10jenkins-bot: Follow-up 7a8cc04f0: Re-set qqq messages that i18n bot destroyed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343206 (owner: 10Jforrester) [23:00:27] (03PS2) 10DLynch: Follow up ec559041: abort notices display early if no notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343194 [23:10:10] (03CR) 10jenkins-bot: Follow-up 7a8cc04f0: Re-set qqq messages that i18n bot destroyed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343206 (owner: 10Jforrester) [23:13:44] (03CR) 10Jforrester: [C: 032] Follow up ec559041: abort notices display early if no notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343194 (owner: 10DLynch) [23:15:38] (03CR) 10jerkins-bot: [V: 04-1] Follow up ec559041: abort notices display early if no notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343194 (owner: 10DLynch) [23:20:31] (03CR) 10DLynch: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343194 (owner: 10DLynch) [23:24:47] (03Merged) 10jenkins-bot: Follow up ec559041: abort notices display early if no notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343194 (owner: 10DLynch) [23:27:20] ...did it just merge that despite the test builds failing? [23:38:03] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), and 2 others: [Regression wmf.16] Cursor jumps to the beginning of the page after adding a focusable node - https://phabricator.wikimedia.org/T160479#3108697 (10Ryasmeen) [23:43:08] (03CR) 10jenkins-bot: Follow up ec559041: abort notices display early if no notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343194 (owner: 10DLynch) [23:58:02] (03PS1) 10DLynch: DesktopContext: on destroy, tell our popup to stop positioning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343217 (https://phabricator.wikimedia.org/T160197) [23:59:42] Am I right in thinking that there's no standard OOui place to put teardown code, if a widget is being discarded?