[00:00:37] yes [00:01:23] 10VisualEditor, 13Patch-For-Review: [Regression wmf.16] Toolbar is not floating as I scroll down in VE, Error in the console "Uncaught TypeError: Cannot read property 'center' of undefined" - https://phabricator.wikimedia.org/T160197#3108736 (10DLynch) I was, in fact, slightly misleading in my previous stateme... [00:01:59] we don't even have a way of notifying a widget it's being discarded and should clean up after itself, which sucks a bit. this is a problems for things like appending stuff to overlays [00:02:16] since they just stay there forever even if the widget is removed from the page [00:02:42] That bug in particular was a case of "this widget sets up an onScroll handler, and that fails horribly if it's removed from the DOM". [00:03:32] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI: [Regression wmf.16] Context menus for items below the screen appear broken (no vertical height) - https://phabricator.wikimedia.org/T160190#3108740 (10matmarex) a:05Catrope>03matmarex To reproduce (other than on first try): 1. Make a context menu ap... [00:06:30] The whole NWE affair makes this stuff so much easier to notice. It's much more common than the previous example of "open VE, leave VE, reopen VE" without reloading the page. [00:09:29] (03PS1) 10Jforrester: Follow-up 335b56728: Reality doesn't run in perma-debug mode :-) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343220 [00:10:00] * James_F nods. [00:10:10] Kemayo: Feel like merging the above? ;-) [00:14:29] (03CR) 10DLynch: [C: 032] Follow-up 335b56728: Reality doesn't run in perma-debug mode :-) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343220 (owner: 10Jforrester) [00:15:16] * James_F coughs. [00:15:23] Should have spotted that one. [00:21:29] (03PS1) 10Bartosz Dziewoński: ve.ui.DesktopContext: Prevent hiding of the context popup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343221 (https://phabricator.wikimedia.org/T160190) [00:23:38] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), and 4 others: Adding a new line in the caption for an image in Gallery creates a blank image space, makes Gallery inaccessible af... - https://phabricator.wikimedia.org/T153373#3108760 [00:23:46] (03CR) 10Bartosz Dziewoński: [C: 032] DesktopContext: on destroy, tell our popup to stop positioning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343217 (https://phabricator.wikimedia.org/T160197) (owner: 10DLynch) [00:24:53] (03CR) 10Jforrester: [C: 032] ve.ui.DesktopContext: Prevent hiding of the context popup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343221 (https://phabricator.wikimedia.org/T160190) (owner: 10Bartosz Dziewoński) [00:25:11] (03Merged) 10jenkins-bot: Follow-up 335b56728: Reality doesn't run in perma-debug mode :-) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343220 (owner: 10Jforrester) [00:26:49] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), 15User-Ryasmeen, and 3 others: After switching between VE and NWE save dialog complains about missing summary - https://phabricator.wikimedia.org/T159686#3108765 (10Ryasmeen) [00:26:54] i feel like most of ve.ui.DesktopContext.prototype.setPopupSizeAndPosition could be axed now and replaced with the PopupWidget positioning stuff that RoanKattouw implemented. [00:27:00] Oh, sure. [00:27:05] Yes [00:27:07] I felt the same way [00:27:12] I mean, up-streaming stuff is kinda the idea. [00:27:26] But it's complex enough that I didn't really want to dive into it at ~5pm which is when I looked at it [00:27:30] Even though Roan's team are currently doing lots of over-riding of OOUI in his day job. :-P [00:27:30] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 07Regression, and 4 others: [Regression pre-wmf.16] Edit summary is showing previous session's edit summary - https://phabricator.wikimedia.org/T160130#3108767 (10Ryasmeen) [00:29:36] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), and 4 others: The onBeforeUnloadHandler isn't getting set(?) when switching from VE to NWE - https://phabricator.wikimedia.org/T153346#3108775 (10Ryasmeen) [00:29:48] (03Merged) 10jenkins-bot: DesktopContext: on destroy, tell our popup to stop positioning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343217 (https://phabricator.wikimedia.org/T160197) (owner: 10DLynch) [00:29:50] (03Merged) 10jenkins-bot: ve.ui.DesktopContext: Prevent hiding of the context popup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343221 (https://phabricator.wikimedia.org/T160190) (owner: 10Bartosz Dziewoński) [00:31:15] 10VisualEditor, 13Patch-For-Review: [Regression wmf.16] Toolbar is not floating as I scroll down in VE, Error in the console "Uncaught TypeError: Cannot read property 'center' of undefined" - https://phabricator.wikimedia.org/T160197#3091801 (10Catrope) >>! In T160197#3108600, @DLynch wrote: > The issue seems... [00:33:04] (03CR) 10jenkins-bot: DesktopContext: on destroy, tell our popup to stop positioning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343217 (https://phabricator.wikimedia.org/T160197) (owner: 10DLynch) [00:33:51] (03CR) 10jenkins-bot: Follow-up 335b56728: Reality doesn't run in perma-debug mode :-) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343220 (owner: 10Jforrester) [00:36:12] (03CR) 10jenkins-bot: ve.ui.DesktopContext: Prevent hiding of the context popup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343221 (https://phabricator.wikimedia.org/T160190) (owner: 10Bartosz Dziewoński) [00:38:57] (03PS1) 10Jforrester: Update VE core submodule to master (ac6d7031c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343224 (https://phabricator.wikimedia.org/T160190) [00:39:55] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (ac6d7031c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343224 (https://phabricator.wikimedia.org/T160190) (owner: 10Jforrester) [00:47:57] (03PS3) 10Jforrester: DesktopArticleTarget: Make the waiting module list extensible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335462 (https://phabricator.wikimedia.org/T156899) (owner: 10DLynch) [00:48:08] (03PS4) 10Jforrester: DesktopArticleTarget: Make the waiting module list extensible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335462 (https://phabricator.wikimedia.org/T156899) (owner: 10DLynch) [00:53:32] (03Merged) 10jenkins-bot: Update VE core submodule to master (ac6d7031c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343224 (https://phabricator.wikimedia.org/T160190) (owner: 10Jforrester) [00:56:39] (03CR) 10Jforrester: "PS3: Made this Yet Another Damn registry, because apparently that's how we do things. (Not tested.)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335462 (https://phabricator.wikimedia.org/T156899) (owner: 10DLynch) [00:57:13] (03CR) 10Jforrester: "Counter-part to do this stuff in GCJ is Ib3232bc801a6aa68e208cf9b689340c482c2f9b2." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335462 (https://phabricator.wikimedia.org/T156899) (owner: 10DLynch) [01:01:15] 10Cite: New parameters to allow to set the class and style of div.mw-references-wrap which is rendered by the with the parameter 'responsive' - https://phabricator.wikimedia.org/T160498#3108831 (10Cwek) >>! In T160498#3101303, @TheDJ wrote: > I'd say there is no need for a style attribute, but yes... [01:01:23] (03CR) 10jenkins-bot: Update VE core submodule to master (ac6d7031c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343224 (https://phabricator.wikimedia.org/T160190) (owner: 10Jforrester) [01:09:03] 10Cite: New parameters to allow to set the class and style of div.mw-references-wrap which is rendered by the with the parameter 'responsive' - https://phabricator.wikimedia.org/T160498#3108836 (10Jdforrester-WMF) [01:09:08] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Reading-Web-Backlog, and 3 others: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#3108837 (10Jdforrester-WMF) [01:09:14] 10Cite: New parameters to allow to set the class and style of div.mw-references-wrap which is rendered by the with the parameter 'responsive' - https://phabricator.wikimedia.org/T160498#3100927 (10Jdforrester-WMF) This clearly does not block T33597 because that is done. :-) [01:22:46] 10VisualEditor, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review, 07Verified: [Regression wmf.16] Toolbar is not floating as I scroll down in VE, Error in the console "Uncaught TypeError: Cannot read property 'center' of undefin... - https://phabricator.wikimedia.org/T160197#3108854 [01:23:57] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 13Patch-For-Review, 07Verified: [Regression wmf.16] Context menus for items below the screen appear broken (no vertical height) - https://phabricator.wikimedia.org/T160190#3108867 (10Ryasmeen) [01:33:50] (03PS1) 10Jforrester: DesktopContext: on destroy, tell our popup to stop positioning [VisualEditor/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343228 (https://phabricator.wikimedia.org/T160197) [01:33:56] (03CR) 10Jforrester: [C: 032] DesktopContext: on destroy, tell our popup to stop positioning [VisualEditor/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343228 (https://phabricator.wikimedia.org/T160197) (owner: 10Jforrester) [01:34:00] (03PS1) 10Jforrester: ve.ui.DesktopContext: Prevent hiding of the context popup [VisualEditor/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343229 (https://phabricator.wikimedia.org/T160190) [01:34:05] (03CR) 10Jforrester: [C: 032] ve.ui.DesktopContext: Prevent hiding of the context popup [VisualEditor/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343229 (https://phabricator.wikimedia.org/T160190) (owner: 10Jforrester) [01:37:53] (03Merged) 10jenkins-bot: DesktopContext: on destroy, tell our popup to stop positioning [VisualEditor/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343228 (https://phabricator.wikimedia.org/T160197) (owner: 10Jforrester) [01:37:55] (03Merged) 10jenkins-bot: ve.ui.DesktopContext: Prevent hiding of the context popup [VisualEditor/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343229 (https://phabricator.wikimedia.org/T160190) (owner: 10Jforrester) [01:39:17] (03PS10) 10Jforrester: DiffElement: Ensure del/ins tags encapsulate annotation changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 (owner: 10Esanders) [01:39:48] (03CR) 10Jforrester: [C: 04-1] "PS10: Added an eslint disable so we can see that David's test case still fails (but the other new one doesn't)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 (owner: 10Esanders) [01:39:53] 10Cite: New parameters to allow to set the class and style of div.mw-references-wrap which is rendered by the with the parameter 'responsive' - https://phabricator.wikimedia.org/T160498#3108872 (10Arthur2e5) >>! In T160498#3101303, @TheDJ wrote: > mw-columns-narrow Oops, this is actually when thi... [01:41:22] (03CR) 10jenkins-bot: DesktopContext: on destroy, tell our popup to stop positioning [VisualEditor/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343228 (https://phabricator.wikimedia.org/T160197) (owner: 10Jforrester) [01:42:53] (03CR) 10jerkins-bot: [V: 04-1] DiffElement: Ensure del/ins tags encapsulate annotation changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 (owner: 10Esanders) [01:45:15] (03CR) 10jenkins-bot: ve.ui.DesktopContext: Prevent hiding of the context popup [VisualEditor/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343229 (https://phabricator.wikimedia.org/T160190) (owner: 10Jforrester) [03:32:32] (03CR) 10Divec: [C: 04-1] "There's something wrong with the 'Nested annotation change' case, even before ve.ui.DiffElement#annotateNode happens. The diff doc is comi" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 (owner: 10Esanders) [03:39:16] (03PS11) 10Divec: DiffElement: Ensure del/ins tags encapsulate annotation changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 (owner: 10Esanders) [03:41:26] (03CR) 10jerkins-bot: [V: 04-1] DiffElement: Ensure del/ins tags encapsulate annotation changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 (owner: 10Esanders) [03:42:32] (03CR) 10Divec: "PS11 fixes the depth of the ins/del tags, but not the unrelated problem I mentioned in PS10." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 (owner: 10Esanders) [04:40:11] 10VisualEditor: Visual diffing a change to a syntaxHighlight node causes JS error - https://phabricator.wikimedia.org/T160729#3109006 (10Catrope) [04:42:06] 10VisualEditor: References in visual diffs are highlighted without taking superscript into account - https://phabricator.wikimedia.org/T160730#3109019 (10Catrope) [04:52:26] 10VisualEditor: Visual diffing a change to a syntaxHighlight node causes JS error - https://phabricator.wikimedia.org/T160729#3109033 (10Catrope) I've also found that this happens for hieroglyph nodes too, but not for math and score nodes, even though they're also subclasses of `ve.dm.MWExtensionNode`. For some... [05:31:16] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Epic, 07Performance: New Wikitext Editor: Major improvement to load time to edit - https://phabricator.wikimedia.org/T154843#3109042 (10Alsee) Note that the Minor Planets page has been split. Anyone wanting to test t... [07:19:51] 10VisualEditor, 10VisualEditor-EditingTools, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), 15User-Ryasmeen: Highlighting on word you are looking for looks broken - https://phabricator.wikimedia.org/T159439#3109083 (10Jerrykim306) >>! In T159439#3105188, @Schnark wrote: > This task is resolved,... [07:20:11] 10VisualEditor, 10VisualEditor-EditingTools, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), 15User-Ryasmeen: Highlighting on word you are looking for looks broken - https://phabricator.wikimedia.org/T159439#3109084 (10Jerrykim306) Thanks. It fixed! [08:52:44] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Clicking on the category bar should do nothing in NWE - https://phabricator.wikimedia.org/T160733#3109178 (10Schnark) [10:47:30] (03PS1) 10Esanders: Pass element to describeChanges [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343271 [10:47:32] (03PS1) 10Esanders: Move diff cleanup to ve.DiffMatchPatch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343272 [10:48:52] 10VisualEditor, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)): Fix whitespace errors in visual diffs - https://phabricator.wikimedia.org/T158895#3109341 (10Esanders) [10:49:06] 10VisualEditor, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)): Fix whitespace errors in visual diffs - https://phabricator.wikimedia.org/T158895#3050815 (10Esanders) This is done. [10:51:01] 10VisualEditor: Visual diffing: Merge changes across whitespace - https://phabricator.wikimedia.org/T160740#3109344 (10Esanders) [10:53:52] 10VisualEditor, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)): Fix whitespace errors in visual diffs - https://phabricator.wikimedia.org/T158895#3109366 (10Esanders) See also T160740 [10:54:25] (03PS1) 10Esanders: VisualDiff: Move word split TODO to test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343273 (https://phabricator.wikimedia.org/T160740) [10:56:38] 10VisualEditor: No visual diff shown after switching from wikitext - https://phabricator.wikimedia.org/T160741#3109371 (10Schnark) [11:10:11] (03PS2) 10Esanders: Move diff cleanup to ve.DiffMatchPatch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343272 [11:10:13] (03PS2) 10Esanders: VisualDiff: Move word split TODO to test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343273 (https://phabricator.wikimedia.org/T160740) [11:11:51] (03PS3) 10Esanders: VisualDiff: Move word split TODO to test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343273 (https://phabricator.wikimedia.org/T160740) [11:20:00] (03PS1) 10WMDE-Fisch: Replace deprecated Context::getStats() with MWServices::getStatsdDataFactory() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343279 [11:20:46] (03PS2) 10WMDE-Fisch: Replace deprecated Context::getStats() with MWServices::getStatsdDataFactory() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343279 [12:17:47] (03PS4) 10Esanders: VisualDiff: Merge remove+inserts separated by whitespace only [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343273 (https://phabricator.wikimedia.org/T160740) [12:17:49] (03PS1) 10Esanders: Use diff_match_patch action constants for better readability [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343286 [12:19:26] (03CR) 10Esanders: "This is required for extension node changes to work properly in I469a3c789" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343271 (owner: 10Esanders) [12:34:00] 10VisualEditor, 10Developer-Wishlist (2017): VE support for skins should be done by adding appropriate anchors/ids/styles to the skins, and not by editing VE itself - https://phabricator.wikimedia.org/T155554#2946905 (10matmarex) Lack of documentation is another thing, but technically, I think this is possible... [12:54:23] 10VisualEditor, 10Timeless: MediaWiki VisualEditor and PageAttachment compatibility - https://phabricator.wikimedia.org/T132005#2185645 (10matmarex) I don't really know what PageAttachment is, but the VisualEditor compatibility fixes work. (You also need `$wgVisualEditorSupportedSkins[] = 'timeless';` in Local... [12:56:07] 10VisualEditor, 10Developer-Wishlist (2017): VE support for skins should be done by adding appropriate anchors/ids/styles to the skins, and not by editing VE itself - https://phabricator.wikimedia.org/T155554#3109565 (10matmarex) Apparently, we actually have this documented: https://www.mediawiki.org/wiki/Visu... [13:00:06] 10VisualEditor, 10Timeless: MediaWiki VisualEditor and PageAttachment compatibility - https://phabricator.wikimedia.org/T132005#3109572 (10matmarex) [13:00:08] 10VisualEditor, 10Developer-Wishlist (2017): VE support for skins should be done by adding appropriate anchors/ids/styles to the skins, and not by editing VE itself - https://phabricator.wikimedia.org/T155554#3109570 (10matmarex) [13:11:44] 10VisualEditor, 10Developer-Wishlist (2017): VE support for skins should be done by adding appropriate anchors/ids/styles to the skins, and not by editing VE itself - https://phabricator.wikimedia.org/T155554#2946905 (10Esanders) I'm not sure the assertion of this bug is correct. As both skins and VE are plugi... [15:41:53] (03CR) 10Jforrester: [C: 032] Pass element to describeChanges [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343271 (owner: 10Esanders) [15:42:18] (03CR) 10Jforrester: [C: 032] Move diff cleanup to ve.DiffMatchPatch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343272 (owner: 10Esanders) [15:43:04] (03CR) 10Jforrester: [C: 032] Use diff_match_patch action constants for better readability [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343286 (owner: 10Esanders) [15:45:06] 10VisualEditor, 10VisualEditor-EditingTools, 13Patch-For-Review: Visual diffing: Merge changes across whitespace - https://phabricator.wikimedia.org/T160740#3110028 (10Jdforrester-WMF) p:05Triage>03Normal a:03Esanders [15:45:16] (03CR) 10Jforrester: [C: 032] VisualDiff: Merge remove+inserts separated by whitespace only [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343273 (https://phabricator.wikimedia.org/T160740) (owner: 10Esanders) [15:45:19] (03Merged) 10jenkins-bot: Pass element to describeChanges [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343271 (owner: 10Esanders) [15:46:42] (03Merged) 10jenkins-bot: Move diff cleanup to ve.DiffMatchPatch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343272 (owner: 10Esanders) [15:48:36] (03Merged) 10jenkins-bot: Use diff_match_patch action constants for better readability [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343286 (owner: 10Esanders) [15:48:38] (03Merged) 10jenkins-bot: VisualDiff: Merge remove+inserts separated by whitespace only [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343273 (https://phabricator.wikimedia.org/T160740) (owner: 10Esanders) [15:49:48] (03CR) 10jenkins-bot: Pass element to describeChanges [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343271 (owner: 10Esanders) [15:59:20] (03CR) 10jenkins-bot: Move diff cleanup to ve.DiffMatchPatch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343272 (owner: 10Esanders) [16:02:20] 10VisualEditor, 10VisualEditor-MediaWiki, 07Category, 07Epic, and 2 others: Let users choose a visual or wikitext diff in the review-your-changes tab - https://phabricator.wikimedia.org/T143350#3110072 (10Jdforrester-WMF) [16:02:23] 10VisualEditor, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), 15User-Ryasmeen: Fix whitespace errors in visual diffs - https://phabricator.wikimedia.org/T158895#3110071 (10Jdforrester-WMF) 05Open>03Resolved [16:02:24] (03CR) 10jenkins-bot: Use diff_match_patch action constants for better readability [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343286 (owner: 10Esanders) [16:02:45] 10VisualEditor, 10VisualEditor-EditingTools, 13Patch-For-Review: Visual diffing: Merge changes across whitespace - https://phabricator.wikimedia.org/T160740#3110077 (10Jdforrester-WMF) [16:02:47] 10VisualEditor, 10VisualEditor-MediaWiki, 07Category, 07Epic, and 2 others: Let users choose a visual or wikitext diff in the review-your-changes tab - https://phabricator.wikimedia.org/T143350#2565512 (10Jdforrester-WMF) [16:06:56] (03CR) 10jenkins-bot: VisualDiff: Merge remove+inserts separated by whitespace only [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343273 (https://phabricator.wikimedia.org/T160740) (owner: 10Esanders) [16:10:11] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Design: "Save change" indicates non-redoable save, but enables preview to check changes. - https://phabricator.wikimedia.org/T160761#3110089 (10Jan_Dittrich) [16:20:49] (03PS12) 10Jforrester: DiffElement: Ensure del/ins tags encapsulate annotation changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 (owner: 10Esanders) [16:21:03] (03CR) 10Jforrester: "PS12: Manual rebase. Still broken. :-(" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 (owner: 10Esanders) [16:24:53] (03CR) 10jerkins-bot: [V: 04-1] DiffElement: Ensure del/ins tags encapsulate annotation changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/341001 (owner: 10Esanders) [16:49:25] (03PS1) 10Jforrester: Update VE core submodule to master (b2f4785d6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343321 (https://phabricator.wikimedia.org/T160740) [19:51:51] 10VisualEditor, 10Graphs, 10OOjs-UI: Bottom paddings visual issue - https://phabricator.wikimedia.org/T119017#1815628 (10Volker_E) [19:57:54] 10VisualEditor, 10OOjs-UI, 07Accessibility: Tool menu: navigating with Tabs skips some icons - https://phabricator.wikimedia.org/T93232#3110795 (10Volker_E) a:05matmarex>03None [19:58:16] 10VisualEditor, 10OOjs-UI: Unnaturally big link dialogue in multimedia dialogue - https://phabricator.wikimedia.org/T98101#3110799 (10Volker_E) a:05matmarex>03None [19:59:54] 10VisualEditor, 10VisualEditor-EditingTools, 07Browser-Support-Apple-Safari, 10OOjs-UI (OOjs-UI-0.20.0): Edit link panel has uneven height of OOUI buttons in desktop Safari - https://phabricator.wikimedia.org/T122503#3110810 (10Volker_E) a:03Volker_E [20:00:12] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Design: "Save change" indicates non-redoable save, but enables preview to check changes. - https://phabricator.wikimedia.org/T160761#3110817 (10Dvorapa) [20:00:16] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Design: It would be nice to have Show preview and Review your changes more directly accessible in the New Wikitext Editor - https://phabricator.wikimedia.org/T153306#3110820 (10Dvorapa) [20:02:31] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Design: "Save change" indicates non-redoable save, but enables preview to check changes. - https://phabricator.wikimedia.org/T160761#3110089 (10Dvorapa) This is currently in progress the solution wil look like Proceed to save (or some similar tex... [20:04:47] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Design: "Save change" indicates non-redoable save, but enables preview to check changes. - https://phabricator.wikimedia.org/T160761#3110828 (10Dvorapa) [20:04:50] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Toolbar "Save page" button is confusing as it merely opens the dialog to save the page - https://phabricator.wikimedia.org/T44138#3110831 (10Dvorapa) [20:14:27] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Design: It would be nice to have Show preview and Review your changes more directly accessible in the New Wikitext Editor - https://phabricator.wikimedia.org/T153306#3110842 (10Dvorapa) @Jdforrester-WMF Could you take a look on this and prepare a... [21:10:42] MatmaRex: How much hacking do you think I'd need to do to put a MenuToolGroup in a ButtonGroupWidget? [21:15:25] 10VisualEditor, 10OOjs-UI: Allow people to put a MenuToolGroup in a ButtonGroupWidget - https://phabricator.wikimedia.org/T160791#3111032 (10Jdforrester-WMF) [21:23:15] (03PS1) 10Esanders: Ensure inline node changes are balanced and minimal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343345 [21:23:28] 10VisualEditor, 10OOjs-UI: Make having a ButtonGroupWidget in the actionsToolbar not look terrible - https://phabricator.wikimedia.org/T160794#3111092 (10Jdforrester-WMF) [21:24:03] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Design: It would be nice to have Show preview and Review your changes more directly accessible in the New Wikitext Editor - https://phabricator.wikimedia.org/T153306#2876033 (10Jdforrester-WMF) >>! In T153306#3110842, @Dvorapa wrote: > @Jdforrest... [21:29:32] 10VisualEditor, 10VisualEditor-EditingTools: "Foo" -> "Foo!" doesn't come out as a minimised diff when it starts the paragraph - https://phabricator.wikimedia.org/T160795#3111110 (10Jdforrester-WMF) [21:48:27] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/343391 (owner: 10L10n-bot) [21:58:05] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343397 (owner: 10L10n-bot) [21:58:40] 10VisualEditor, 07I18n: undocumented parameters in visualeditor-changedesc-align, visualeditor-changedesc-image-size, visualeditor-changedesc-link-href. - https://phabricator.wikimedia.org/T160632#3111166 (10Jdforrester-WMF) p:05Triage>03Normal a:03Jdforrester-WMF [21:59:37] (03PS1) 10Jforrester: i18n: Add param documentation in qqq for some recent keys [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343405 (https://phabricator.wikimedia.org/T160632) [22:01:03] (03CR) 10Jforrester: [C: 032] Ensure inline node changes are balanced and minimal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343345 (owner: 10Esanders) [22:01:17] RoanKattouw: Can I grab a +2 on https://gerrit.wikimedia.org/r/#/c/343405/ please? [22:06:45] (03Merged) 10jenkins-bot: Ensure inline node changes are balanced and minimal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343345 (owner: 10Esanders) [22:07:35] (03CR) 10Jforrester: [C: 032] Replace deprecated Context::getStats() with MWServices::getStatsdDataFactory() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343279 (owner: 10WMDE-Fisch) [22:08:00] 10VisualEditor: visualeditor-switch uses 50% system CPU - https://phabricator.wikimedia.org/T160797#3111184 (10hashar) [22:08:17] (03CR) 10Catrope: [C: 032] i18n: Add param documentation in qqq for some recent keys [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343405 (https://phabricator.wikimedia.org/T160632) (owner: 10Jforrester) [22:09:37] 10VisualEditor: visualeditor-switch uses 50% system CPU - https://phabricator.wikimedia.org/T160797#3111197 (10Jdforrester-WMF) Despite the name I don't think anyone in the VE team is involved in that instance. Maybe @cscott knows? [22:12:08] (03CR) 10jerkins-bot: [V: 04-1] i18n: Add param documentation in qqq for some recent keys [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343405 (https://phabricator.wikimedia.org/T160632) (owner: 10Jforrester) [22:17:38] (03CR) 10jenkins-bot: Ensure inline node changes are balanced and minimal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343345 (owner: 10Esanders) [22:29:24] (03PS2) 10Jforrester: i18n: Add param documentation in qqq for some recent keys [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343405 (https://phabricator.wikimedia.org/T160632) [22:29:33] (03CR) 10Jforrester: [C: 032] "Per Roan." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343405 (https://phabricator.wikimedia.org/T160632) (owner: 10Jforrester) [22:31:46] (03Merged) 10jenkins-bot: Replace deprecated Context::getStats() with MWServices::getStatsdDataFactory() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343279 (owner: 10WMDE-Fisch) [22:32:57] (03Merged) 10jenkins-bot: i18n: Add param documentation in qqq for some recent keys [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343405 (https://phabricator.wikimedia.org/T160632) (owner: 10Jforrester) [22:39:48] (03CR) 10jenkins-bot: Replace deprecated Context::getStats() with MWServices::getStatsdDataFactory() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343279 (owner: 10WMDE-Fisch) [22:41:54] (03CR) 10jenkins-bot: i18n: Add param documentation in qqq for some recent keys [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343405 (https://phabricator.wikimedia.org/T160632) (owner: 10Jforrester) [22:51:25] (03PS1) 10Jforrester: Update VE core submodule to wmf/1.29.0-wmf.16 HEAD (f6e399eed) [extensions/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343411 (https://phabricator.wikimedia.org/T160190) [23:04:01] (03CR) 10Catrope: [C: 032] Update VE core submodule to wmf/1.29.0-wmf.16 HEAD (f6e399eed) [extensions/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343411 (https://phabricator.wikimedia.org/T160190) (owner: 10Jforrester) [23:11:56] (03PS2) 10Jforrester: Update VE core submodule to master (a63435906) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343321 (https://phabricator.wikimedia.org/T159439) [23:12:20] RoanKattouw: Also can I steal a +2 on https://gerrit.wikimedia.org/r/#/c/343321/ ? [23:14:21] (03PS3) 10Catrope: Update VE core submodule to master (a63435906) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343321 (https://phabricator.wikimedia.org/T159439) (owner: 10Jforrester) [23:16:21] (03PS4) 10Catrope: Update VE core submodule to master (a63435906) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343321 (https://phabricator.wikimedia.org/T160632) (owner: 10Jforrester) [23:16:27] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (a63435906) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343321 (https://phabricator.wikimedia.org/T160632) (owner: 10Jforrester) [23:21:12] (03Merged) 10jenkins-bot: Update VE core submodule to wmf/1.29.0-wmf.16 HEAD (f6e399eed) [extensions/VisualEditor] (wmf/1.29.0-wmf.16) - 10https://gerrit.wikimedia.org/r/343411 (https://phabricator.wikimedia.org/T160190) (owner: 10Jforrester) [23:33:51] James_F: T154123 T160479 T160190 T160197 [23:33:51] T154123: VisualEditor: when pasting wikified text from an article, the text style (including link) can't be modified - https://phabricator.wikimedia.org/T154123 [23:33:52] T160197: [Regression wmf.16] Toolbar is not floating as I scroll down in VE, Error in the console "Uncaught TypeError: Cannot read property 'center' of undefined" - https://phabricator.wikimedia.org/T160197 [23:33:52] T160190: [Regression wmf.16] Context menus for items below the screen appear broken (no vertical height) - https://phabricator.wikimedia.org/T160190 [23:33:52] T160479: [Regression wmf.16] Cursor jumps to the beginning of the page after adding a focusable node - https://phabricator.wikimedia.org/T160479 [23:35:26] (03Merged) 10jenkins-bot: Update VE core submodule to master (a63435906) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343321 (https://phabricator.wikimedia.org/T160632) (owner: 10Jforrester) [23:36:53] 10VisualEditor, 10VisualEditor-CopyPaste, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), 07Regression, 15User-Ryasmeen: VisualEditor: when pasting wikified text from an article, the text style (including link) can't be modified - https://phabricator.wikimedia.org/T154123#3111481 (10Jdforrester... [23:36:55] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), and 2 others: [Regression wmf.16] Cursor jumps to the beginning of the page after adding a focusable node - https://phabricator.wikimedia.org/T160479#3111482 (10Jdforrester... [23:37:31] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), and 2 others: [Regression wmf.16] Context menus for items below the screen appear broken (no vertical height) - https://phabricator.wikimedia.org/T160190#3111486 (10Jdforrester-WMF) 05Open>... [23:37:41] 10VisualEditor, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), 07Verified: [Regression wmf.16] Toolbar is not floating as I scroll down in VE, Error in the console "Uncaught TypeError: Cannot read property 'center' of undefined" - https://phabricator.wikimedia.org/T160197#3111491 (10Jdforrester-WM... [23:37:58] 10VisualEditor, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), 15User-Ryasmeen, 07Verified: [Regression wmf.16] Toolbar is not floating as I scroll down in VE, Error in the console "Uncaught TypeError: Cannot read property 'center' of undefined" - https://phabricator.wikimedia.org/T160197#3111493... [23:39:49] (03CR) 10jenkins-bot: Update VE core submodule to master (a63435906) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343321 (https://phabricator.wikimedia.org/T160632) (owner: 10Jforrester) [23:41:23] 10VisualEditor, 07I18n, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 15User-Ryasmeen: undocumented parameters in visualeditor-changedesc-align, visualeditor-changedesc-image-size, visualeditor-changedesc-link-href. - https://phabricator.wikimedia.org/T160632#3111517 (10Jdforrester-WMF) 05Ope... [23:41:50] 10VisualEditor, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 15User-Ryasmeen: Visual diffing a change to a syntaxHighlight node causes JS error - https://phabricator.wikimedia.org/T160729#3111520 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03High a:03Esanders [23:42:15] 10VisualEditor, 10VisualEditor-MediaWiki, 07Category, 07Epic, and 2 others: Let users choose a visual or wikitext diff in the review-your-changes tab - https://phabricator.wikimedia.org/T143350#3111529 (10Jdforrester-WMF) [23:42:18] 10VisualEditor, 10VisualEditor-EditingTools, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 15User-Ryasmeen: Visual diffing: Merge changes across whitespace - https://phabricator.wikimedia.org/T160740#3111527 (10Jdforrester-WMF) 05Open>03Resolved [23:43:02] RoanKattouw: Can you tell we're getting close to the end of a quarter? http://phlogiston.wmflabs.org/ve_report.html [23:46:18] 10VisualEditor, 06Discovery, 06Discovery-Search: Remove use of jquery.autoEllipsis in mw.widgets.TitleOptionWidget - https://phabricator.wikimedia.org/T160804#3111535 (10Krinkle)