[00:21:27] (03PS1) 10Jforrester: i18n: Add a default alignment value [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/344278 [00:29:24] (03PS1) 10Jforrester: ve.dm.MWImageNode#describeChanges: Ignore borderImage noise from the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344281 [01:22:16] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/344278/ [01:25:46] (03CR) 10Catrope: [C: 032] i18n: Add a default alignment value [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/344278 (owner: 10Jforrester) [01:29:46] (03Merged) 10jenkins-bot: i18n: Add a default alignment value [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/344278 (owner: 10Jforrester) [01:34:28] (03CR) 10jenkins-bot: i18n: Add a default alignment value [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/344278 (owner: 10Jforrester) [01:46:04] (03PS2) 10Jforrester: Update VE core submodule to master (0cc3ded3d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344219 (https://phabricator.wikimedia.org/T160839) [01:46:13] RoanKattouw: ^^ [01:46:57] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (0cc3ded3d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344219 (https://phabricator.wikimedia.org/T160839) (owner: 10Jforrester) [02:00:17] (03Merged) 10jenkins-bot: Update VE core submodule to master (0cc3ded3d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344219 (https://phabricator.wikimedia.org/T160839) (owner: 10Jforrester) [02:18:46] (03CR) 10jenkins-bot: Update VE core submodule to master (0cc3ded3d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344219 (https://phabricator.wikimedia.org/T160839) (owner: 10Jforrester) [03:25:31] 10Citoid, 10VisualEditor: Extract page from Google Books in Citoid - https://phabricator.wikimedia.org/T160848#3112608 (10czar) I think it's the same task (modifying the Zotero translator to include any parameters needed for WP, and the only one that applies, I presume, is the page number). I might be able to... [03:27:24] 10Citoid, 10VisualEditor, 07WorkType-Maintenance: Keep page number parameter when processing Google Books links - https://phabricator.wikimedia.org/T113262#1660158 (10czar) [06:12:07] 10Citoid, 10VisualEditor, 10Outreach-Programs-Projects, 10Possible-Tech-Projects, and 2 others: Write a Zotero translator and document process for creating new Zotero translator and getting it live in production - https://phabricator.wikimedia.org/T115158#3124217 (10Mine0901) [07:44:01] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/344313 (owner: 10L10n-bot) [09:30:26] 10Citoid, 10VisualEditor: Extract page from Google Books in Citoid - https://phabricator.wikimedia.org/T160848#3124348 (10Mvolz) There's no real hook, but we have a fork of the Zotero translators: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/services/zotero/translators So if there are any chang... [11:54:20] 10Citoid, 10VisualEditor, 13Patch-For-Review: Visual Editor adds erroneous text "PMC" to citation template pmc= parameter - https://phabricator.wikimedia.org/T157152#3124718 (10Mvolz) I've done some research on this and it looks like PMC is genuinely part of the identifier. For instance: https://www.ncbi... [12:39:50] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Browser-Support-Microsoft-Edge: Copying and pasting removes blank lines in Microsoft Edge - https://phabricator.wikimedia.org/T160202#3091936 (10Esanders) Edge converts single line breaks to
and double line break... [12:43:45] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Inserting link to category adds colon before the link - https://phabricator.wikimedia.org/T160977#3124835 (10Esanders) [12:45:25] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Inserting link to category adds colon before the link - https://phabricator.wikimedia.org/T160977#3117026 (10Esanders) This isn't specific to NWE. In visual mode you get `:Category:Book`, so the extra colon is the correct based on what the... [13:01:01] Hey, Will Parsoid & Visual Editor work without Python installed? [13:08:47] 10Citoid, 10VisualEditor, 13Patch-For-Review: Visual Editor adds erroneous text "PMC" to citation template pmc= parameter - https://phabricator.wikimedia.org/T157152#3124869 (10Trappist_the_monk) In cs1|2 the name of the identifier has always been PMC; the template parameter name has always been |pmc=; the v... [13:17:18] (03PS1) 10Esanders: Use original title or normalized title when inserting link text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344375 (https://phabricator.wikimedia.org/T118408) [13:19:36] (03CR) 10Esanders: "Probably https://phabricator.wikimedia.org/T159377" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/342213 (owner: 10Esanders) [13:19:53] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Teardown issue – Getting error "Uncaught TypeError: Cannot read property 'getToolbarDialogs' of null" in the console after saving a new section - https://phabricator.wikimedia.org/T159377#3065719 (10Esanders) Probably fixed by https://gerrit.wikimedi... [13:35:59] (03CR) 10jerkins-bot: [V: 04-1] Use original title or normalized title when inserting link text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344375 (https://phabricator.wikimedia.org/T118408) (owner: 10Esanders) [14:38:41] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: "Do you want to leave this page?" dialog after saving edit and introducing new URL in browser - https://phabricator.wikimedia.org/T161221#3125220 (10Qgil) [14:45:36] 10Citoid, 10VisualEditor, 13Patch-For-Review: Visual Editor adds erroneous text "PMC" to citation template pmc= parameter - https://phabricator.wikimedia.org/T157152#3125257 (10Mvolz) Yes, I understand that's how CS1 works, but unfortunately it's wrong according to the identifier publisher, which is the NIH.... [14:45:45] 10Citoid, 10VisualEditor, 13Patch-For-Review: Visual Editor adds erroneous text "PMC" to citation template pmc= parameter - https://phabricator.wikimedia.org/T157152#3125259 (10Mvolz) 05Open>03declined [15:35:33] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), 15User-Ryasmeen: Teardown issue – Getting error "Uncaught TypeError: Cannot read property 'getToolbarDialogs' of null" in the console aft... - https://phabricator.wikimedia.org/T159377#3125388 [15:37:07] (03CR) 10Jforrester: [C: 04-1] Use original title or normalized title when inserting link text (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344375 (https://phabricator.wikimedia.org/T118408) (owner: 10Esanders) [15:37:40] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 13Patch-For-Review: Inserting link to category adds colon before the link - https://phabricator.wikimedia.org/T160977#3125397 (10Jdforrester-WMF) 05stalled>03Open >>! In T160977#3118852, @Dvorapa wrote: > @Jdforrester-WMF I think @Schnark has g... [15:42:03] (03CR) 10Esanders: [C: 032] ve.ui.MWGalleryDialog: Don't die if the dropdown menu doesn't have a value [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344041 (https://phabricator.wikimedia.org/T160967) (owner: 10Jforrester) [15:48:05] (03PS2) 10Esanders: Use original title or normalized title when inserting link text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344375 (https://phabricator.wikimedia.org/T118408) [15:55:17] (03Merged) 10jenkins-bot: ve.ui.MWGalleryDialog: Don't die if the dropdown menu doesn't have a value [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344041 (https://phabricator.wikimedia.org/T160967) (owner: 10Jforrester) [15:55:55] (03CR) 10Esanders: [C: 032] ve.dm.MWImageNode#describeChanges: Ignore borderImage noise from the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344281 (owner: 10Jforrester) [16:02:05] (03CR) 10jenkins-bot: ve.ui.MWGalleryDialog: Don't die if the dropdown menu doesn't have a value [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344041 (https://phabricator.wikimedia.org/T160967) (owner: 10Jforrester) [16:05:59] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-Page_Forms: Provide an integration of VisualEditor for SemanticForms - https://phabricator.wikimedia.org/T131686#3125451 (10Pyro853) Hi @Yaron_Koren I didn't take time to work on it since my last message, i just find out that I really have to u... [16:11:09] (03Merged) 10jenkins-bot: ve.dm.MWImageNode#describeChanges: Ignore borderImage noise from the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344281 (owner: 10Jforrester) [16:18:24] (03CR) 10jenkins-bot: ve.dm.MWImageNode#describeChanges: Ignore borderImage noise from the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344281 (owner: 10Jforrester) [16:18:42] 10Cite, 10VisualEditor, 13Patch-For-Review: New columns feature for references tag wasn't changed mediawiki message - https://phabricator.wikimedia.org/T160628#3125471 (10Jdforrester-WMF) p:05Triage>03Normal a:03Jdforrester-WMF [16:41:19] (03PS1) 10DLynch: SurfaceFragment: avoid double-annotating in insertContent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/344417 (https://phabricator.wikimedia.org/T143261) [16:51:59] 10VisualEditor, 10VisualEditor-MediaWiki: Edit notices box not displaying all the items or not displaying them well? - https://phabricator.wikimedia.org/T153118#2870277 (10Isarra) The notices seem to only show up expanded when opening it initially, usually - otherwise they're always collapsed, and users are no... [16:53:40] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 13Patch-For-Review: Paste identical annotated content into (end of?) an annotation serialises very poorly because it gets double-annotated - https://phabricator.wikimedia.org/T143261#2562311 (10DLynch) That patch fixes Ed's test case... [17:53:39] (03PS1) 10Esanders: Fix typo in surfaceReady documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344441 [17:56:35] (03CR) 10Jforrester: [C: 032] "Double-ready." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344441 (owner: 10Esanders) [17:57:20] (03CR) 10Jforrester: "This should probably have some tests that failed before and now pass. :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/344417 (https://phabricator.wikimedia.org/T143261) (owner: 10DLynch) [17:57:58] (03CR) 10Divec: [C: 04-1] SurfaceFragment: avoid double-annotating in insertContent (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/344417 (https://phabricator.wikimedia.org/T143261) (owner: 10DLynch) [17:58:38] (03CR) 10Divec: [C: 032] Only show branch node rebuilds in inputDebug mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343905 (owner: 10Esanders) [18:00:28] (03CR) 10DLynch: "I can do both these things. Are people happy with the direction of the filtering? I could forcibly keep the content annotation and just no" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/344417 (https://phabricator.wikimedia.org/T143261) (owner: 10DLynch) [18:01:55] (03CR) 10Jforrester: "Seems sensible, yes, sorry. :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/344417 (https://phabricator.wikimedia.org/T143261) (owner: 10DLynch) [18:03:35] (03Merged) 10jenkins-bot: Only show branch node rebuilds in inputDebug mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343905 (owner: 10Esanders) [18:09:41] (03Merged) 10jenkins-bot: Fix typo in surfaceReady documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344441 (owner: 10Esanders) [18:11:30] 10VisualEditor: In Visual Editor editing window, some images don't display - https://phabricator.wikimedia.org/T160307#3125803 (10Dan.mulholland) @Jdforrester-WMF Yes, they are all in the same file repo. [18:13:15] 10VisualEditor, 10VisualEditor-MediaWiki, 15User-Ryasmeen: VisualEditor doesn't handle login timeouts well in MW 1.26 - https://phabricator.wikimedia.org/T123088#3125805 (10Dan.mulholland) 05Open>03Resolved a:03Dan.mulholland MW 1.26 is now old, this information might be of use to others but is unlikel... [18:15:27] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Editing an old revision loads the current revision - https://phabricator.wikimedia.org/T156998#2992374 (10Esanders) Very odd - the [[https://de.wikipedia.org/w/api.php?action=visualeditor&format=json&paction=wikitext&page=Wikipedia%3AProjektneuheiten... [18:15:56] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Services: Editing an old revision loads the current revision - https://phabricator.wikimedia.org/T156998#3125812 (10Esanders) [18:18:25] (03CR) 10jenkins-bot: Only show branch node rebuilds in inputDebug mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/343905 (owner: 10Esanders) [18:21:40] (03CR) 10Bartosz Dziewoński: [C: 031] Section editing: strip links from heading text used for edit summary [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343901 (https://phabricator.wikimedia.org/T160911) (owner: 10DLynch) [18:32:02] (03CR) 10Esanders: [C: 032] Section editing: strip links from heading text used for edit summary [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343901 (https://phabricator.wikimedia.org/T160911) (owner: 10DLynch) [18:38:15] 10VisualEditor, 10VisualEditor-MediaWiki, 15User-Ryasmeen: VisualEditor doesn't handle login timeouts well in MW 1.26 - https://phabricator.wikimedia.org/T123088#3125948 (10Jdforrester-WMF) 05Resolved>03declined Shifting to "Declined" as we didn't actually help anyone here. [18:45:08] (03Merged) 10jenkins-bot: Section editing: strip links from heading text used for edit summary [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343901 (https://phabricator.wikimedia.org/T160911) (owner: 10DLynch) [19:06:03] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid, 06Services (watching): Editing an old revision loads the current revision - https://phabricator.wikimedia.org/T156998#3126024 (10mobrovac) I have just verified that this is the content served directly by Parsoid: ``` mobrovac@wtp2001:... [19:18:13] (03CR) 10jenkins-bot: Fix typo in surfaceReady documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344441 (owner: 10Esanders) [19:25:13] (03CR) 10jenkins-bot: Section editing: strip links from heading text used for edit summary [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/343901 (https://phabricator.wikimedia.org/T160911) (owner: 10DLynch) [19:40:15] (03PS1) 10Fomafix: Replace deprecated jQuery .unbind() by .off() [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/344477 [19:57:28] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid, 06Services (watching): Editing an old revision loads the current revision - https://phabricator.wikimedia.org/T156998#2992374 (10Arlolra) What does `direction=prev` do? If you remove that, Parsoid renders exactly what's shown. [20:24:18] (03PS2) 10DLynch: SurfaceFragment: avoid double-annotating in insertContent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/344417 (https://phabricator.wikimedia.org/T143261) [21:20:30] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid, 06Services (watching): Editing an old revision loads the current revision - https://phabricator.wikimedia.org/T156998#3126648 (10Esanders) Interesting, so oldid=Xn along with direction=prev/next gives you id X(n-1) or X(n+1). Seems lik... [21:23:15] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid, 06Services (watching): Editing an old revision loads the current revision - https://phabricator.wikimedia.org/T156998#3126668 (10Esanders) Verified this is a bug with VE visual mode too. [21:23:25] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Editing an old revision loads the current revision - https://phabricator.wikimedia.org/T156998#3126669 (10Esanders) [21:25:37] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Editing an old revision loads the current revision - https://phabricator.wikimedia.org/T156998#3126678 (10Jdforrester-WMF) 05stalled>03Open p:05Triage>03High [21:31:01] edsanders: I have a fix. [21:31:33] is it replacing query.oldid with mw.config.get('wgRevisionId')? [21:31:38] Yes. [21:31:40] because that's what i'm doing... [21:31:42] ok [21:32:04] someone also needs to tell RevisionSlider that they need to modify that config var when they async redraw the page [21:32:26] (03PS1) 10Jforrester: DesktopArticleTarget.init#activateTarget: Don't trust oldid, it lies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344505 (https://phabricator.wikimedia.org/T156998) [21:34:07] 10VisualEditor, 10Revision-Slider, 06TCB-Team: When redrawing the page to a new revision, please update mw.config.get('wgRevisionId') - https://phabricator.wikimedia.org/T161257#3126717 (10Jdforrester-WMF) [21:34:30] edsanders: ^^ Merge appreciated. [21:38:46] I found 4 occurences... [21:39:41] James_F: grep for "query.oldid" [21:40:07] In meeting, sorry. [21:40:26] (03CR) 10Esanders: [C: 04-1] "and you missed some in DAT and MobileArticleTarget "query.oldid"" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344505 (https://phabricator.wikimedia.org/T156998) (owner: 10Jforrester) [21:45:07] fixed [21:45:12] (03PS2) 10Esanders: DesktopArticleTarget.init#activateTarget: Don't trust oldid in the query string, it lies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344505 (https://phabricator.wikimedia.org/T156998) (owner: 10Jforrester) [21:45:24] (03CR) 10Esanders: [C: 031] DesktopArticleTarget.init#activateTarget: Don't trust oldid in the query string, it lies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344505 (https://phabricator.wikimedia.org/T156998) (owner: 10Jforrester) [21:50:44] 10VisualEditor, 10Revision-Slider, 06TCB-Team, 13Patch-For-Review: When redrawing the page to a new revision, please update mw.config.get('wgRevisionId') - https://phabricator.wikimedia.org/T161257#3126717 (10Esanders) Actually on investigation, VE doesn't currently launch directly on diff pages at the mom... [21:50:50] 10VisualEditor: [Regression pre-wmf.18] VE crashes after clicking on "Review your changes" when Block quote is added - https://phabricator.wikimedia.org/T161262#3126838 (10Ryasmeen) [21:52:20] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 13Patch-For-Review: Editing an old revision after navigating history (direction=next/prev) loads the prev/next revision - https://phabricator.wikimedia.org/T156998#3126862 (10Esanders) [21:52:21] 10VisualEditor: [Regression pre-wmf.18] VE crashes after clicking on "Review your changes" when Block quote is added - https://phabricator.wikimedia.org/T161262#3126864 (10Ryasmeen) [21:52:29] 10VisualEditor, 13Patch-For-Review: Editing an old revision after navigating history (direction=next/prev) loads the prev/next revision - https://phabricator.wikimedia.org/T156998#2992374 (10Esanders) [21:52:42] (03CR) 10jerkins-bot: [V: 04-1] DesktopArticleTarget.init#activateTarget: Don't trust oldid in the query string, it lies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344505 (https://phabricator.wikimedia.org/T156998) (owner: 10Jforrester) [22:08:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344547 (owner: 10L10n-bot) [22:15:24] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Gallery, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), and 3 others: [Regression wmf.17] Cannot open Gallery dialog after making some changes to it and saving the page - https://phabricator.wikimedia.org/T160967#3126934 (10Ryasmeen) [22:17:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Gallery, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), and 4 others: [Regression wmf.17] Cannot open Gallery dialog after making some changes to it and saving the page - https://phabricator.wikimedia.org/T160967#3126944 (10Ryasmeen) 05Open... [22:48:03] (03PS3) 10Jforrester: *ArticleTarget: Don't trust oldid in the query string, it lies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344505 (https://phabricator.wikimedia.org/T156998) [22:48:20] (03PS4) 10Jforrester: *ArticleTarget: Don't trust oldid in the query string, it lies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344505 (https://phabricator.wikimedia.org/T156998) [22:56:16] (03CR) 10jerkins-bot: [V: 04-1] *ArticleTarget: Don't trust oldid in the query string, it lies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344505 (https://phabricator.wikimedia.org/T156998) (owner: 10Jforrester) [23:18:46] (03CR) 10Krinkle: [C: 032] Replace deprecated jQuery .unbind() by .off() [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/344477 (owner: 10Fomafix) [23:30:34] (03Merged) 10jenkins-bot: Replace deprecated jQuery .unbind() by .off() [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/344477 (owner: 10Fomafix)