[00:39:41] (03PS2) 10Krinkle: ve.init.mw.DesktopArticleTarget: Remove unused code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345073 (owner: 10Bartosz Dziewoński) [00:40:18] (03CR) 10Krinkle: [C: 032] ve.init.mw.DesktopArticleTarget: Remove unused code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345073 (owner: 10Bartosz Dziewoński) [00:47:58] 10VisualEditor: Find the phrase "ISBN" from ISBN magic links with Find and replace - https://phabricator.wikimedia.org/T121315#1875502 (10Jonesey95) Note that magic links are going away. [00:50:51] (03Merged) 10jenkins-bot: ve.init.mw.DesktopArticleTarget: Remove unused code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345073 (owner: 10Bartosz Dziewoński) [00:51:30] 10VisualEditor: Visual Editor wraps ISBNs in nowiki tags - https://phabricator.wikimedia.org/T161581#3135987 (10Jonesey95) [00:57:52] (03CR) 10jenkins-bot: ve.init.mw.DesktopArticleTarget: Remove unused code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345073 (owner: 10Bartosz Dziewoński) [01:29:39] (03CR) 10Bartosz Dziewoński: "After reading this code a couple more times I finally understood what this was meant to do. It should've been fixed rather than removed. W" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345073 (owner: 10Bartosz Dziewoński) [01:29:43] (03PS1) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget: Remove redirect subtitle if we cancel editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345081 [01:30:10] (03PS2) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget: Remove redirect subtitle if we cancel editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345081 [01:31:32] (03PS3) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget: Hide redirect subtitle if we cancel editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345081 [01:59:39] 10VisualEditor, 10VisualEditor-ContentLanguage, 07Chinese-Sites: ZH IME input sometimes inserts latin characters - https://phabricator.wikimedia.org/T74268#759264 (10Arthur2e5) This happens on zhwiki too. And well, the reporter mentioned MediaWiki.org itself! No reason to keep it in "Non-WMF sites". Certain... [04:53:48] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: Single Edit Tab global default change - https://phabricator.wikimedia.org/T159032#3136150 (10Alsee) The discussion was unanimous when I posted it. Now one person has disagreed. [05:04:05] 10VisualEditor, 10VisualEditor-MediaWiki: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#3136157 (10Liuxinyu970226) [05:04:07] 10VisualEditor, 10VisualEditor-ContentLanguage, 07Chinese-Sites: ZH IME input sometimes inserts latin characters - https://phabricator.wikimedia.org/T74268#3136152 (10Liuxinyu970226) 05Open>03stalled >>! In T74268#3136097, @Arthur2e5 wrote: > This happens on zhwiki too. And well, the reporter mentioned M... [08:17:53] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Urbanecm: Page blanked when editing a section after an edit conflict - https://phabricator.wikimedia.org/T154217#2904393 (10Schnark) As far as I can see in `ve.init.mw.ArticleTarget.js` in the `onSaveDialogResolveConflict` method (https://ph... [09:04:26] 10VisualEditor, 06Discovery, 10RelatedArticles, 10UI-Standardization, and 3 others: Align the style for lists of pages - https://phabricator.wikimedia.org/T153417#3136410 (10Volker_E) @Jdrewniak @JGirault Here the group-internal patch review was faster than I could take breath from T161177, which I cared a... [11:40:31] (03PS1) 10Esanders: Re-apply "Remove $returnFocusTo hack now null is supported upstream" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345128 [11:51:06] (03PS2) 10Esanders: Re-apply "Remove $returnFocusTo hack now null is supported upstream" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345128 [12:11:33] (03PS28) 10Zfilipin: WIP Selenium test for loading VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320829 (https://phabricator.wikimedia.org/T150435) (owner: 10Ryasmeen) [12:11:51] (03CR) 10jerkins-bot: [V: 04-1] WIP Selenium test for loading VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320829 (https://phabricator.wikimedia.org/T150435) (owner: 10Ryasmeen) [12:31:36] 10VisualEditor, 10MediaWiki-Vagrant, 10RESTBase: Provisioning MediaWiki Vagrant VisualEditor role does not result in working VisualEditor - https://phabricator.wikimedia.org/T161603#3136723 (10zeljkofilipin) [12:35:04] 10VisualEditor, 10MediaWiki-Vagrant, 10RESTBase, 15User-zeljkofilipin: Provisioning MediaWiki Vagrant VisualEditor role does not result in working VisualEditor - https://phabricator.wikimedia.org/T161603#3136735 (10zeljkofilipin) [12:37:27] 10VisualEditor, 10MediaWiki-Vagrant, 10RESTBase, 15User-zeljkofilipin: Provisioning MediaWiki Vagrant VisualEditor role does not result in working VisualEditor - https://phabricator.wikimedia.org/T161603#3136737 (10zeljkofilipin) [14:03:05] (03PS1) 10Zfilipin: WIP WebdriverIO tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345146 (https://phabricator.wikimedia.org/T150435) [14:05:38] (03Abandoned) 10Zfilipin: WIP Selenium test for loading VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320829 (https://phabricator.wikimedia.org/T150435) (owner: 10Ryasmeen) [14:45:54] (03CR) 10Jforrester: [C: 032] Re-apply "Remove $returnFocusTo hack now null is supported upstream" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345128 (owner: 10Esanders) [14:47:08] (03CR) 10Jforrester: "Unit tests? Task? :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/344812 (owner: 10Divec) [14:48:03] (03Merged) 10jenkins-bot: Re-apply "Remove $returnFocusTo hack now null is supported upstream" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345128 (owner: 10Esanders) [14:51:22] (03CR) 10jenkins-bot: Re-apply "Remove $returnFocusTo hack now null is supported upstream" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345128 (owner: 10Esanders) [14:51:34] (03PS2) 10Jforrester: Update VE core submodule to master (495cd7d65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344803 (https://phabricator.wikimedia.org/T143261) [14:51:45] RoanKattouw: ^^ https://gerrit.wikimedia.org/r/344803 [14:55:46] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (495cd7d65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344803 (https://phabricator.wikimedia.org/T143261) (owner: 10Jforrester) [14:58:53] 10VisualEditor: Find the phrase "ISBN" from ISBN magic links with Find and replace - https://phabricator.wikimedia.org/T121315#1875502 (10Jdforrester-WMF) >>! In T121315#3135976, @Jonesey95 wrote: > Note that magic links are going away. That's T145604, and it's not decided yet that we'll apply this to Wikimedi... [15:01:33] 10VisualEditor: Visual Editor wraps ISBNs in nowiki tags - https://phabricator.wikimedia.org/T161581#3135987 (10Jdforrester-WMF) The fix for this, T117165, was released after those edits. [15:01:41] 10VisualEditor: Visual Editor wraps ISBNs in nowiki tags - https://phabricator.wikimedia.org/T161581#3137082 (10Jdforrester-WMF) [15:01:43] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki: Pasted ISBNs should trigger the ISBN typing auto-linking - https://phabricator.wikimedia.org/T161152#3137085 (10Jdforrester-WMF) [15:04:41] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 07Browser-Support-Firefox, 07I18n, and 2 others: Firefox in interface RTL in reversed are VE in suggestions link Latin - https://phabricator.wikimedia.org/T136641#3137092 (10Jdforrester-WMF) 05Open>03Resolved OK, I'm declaring this Resolved then. Thanks e... [15:05:59] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki: Pasted ISBNs should trigger the ISBN typing auto-linking - https://phabricator.wikimedia.org/T161152#3137097 (10matmarex) a:03matmarex [15:08:53] (03Merged) 10jenkins-bot: Update VE core submodule to master (495cd7d65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344803 (https://phabricator.wikimedia.org/T143261) (owner: 10Jforrester) [15:11:07] (03CR) 10Jforrester: [C: 032] ve.init.mw.DesktopArticleTarget: Hide redirect subtitle if we cancel editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345081 (owner: 10Bartosz Dziewoński) [15:11:09] (03PS2) 10Zfilipin: WIP WebdriverIO tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345146 (https://phabricator.wikimedia.org/T150435) [15:11:26] (03PS3) 10Zfilipin: WIP WebdriverIO tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345146 (https://phabricator.wikimedia.org/T150435) [15:12:14] (03PS4) 10Zfilipin: WIP WebdriverIO tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345146 (https://phabricator.wikimedia.org/T150435) [15:12:26] 10VisualEditor, 10VisualEditor-DataModel: Add serialize/deserialize methods to ve.dm.Transaction and ve.dm.IndexValueStore - https://phabricator.wikimedia.org/T161611#3137113 (10dchan) [15:14:33] (03PS2) 10Divec: Serialize/deserialize for Transaction and IndexValueStore [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/344812 (https://phabricator.wikimedia.org/T161611) [15:14:47] Kemayo: Did you get a chance to look at https://gerrit.wikimedia.org/r/#/c/343226/ ? [15:14:53] (03CR) 10jenkins-bot: Update VE core submodule to master (495cd7d65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/344803 (https://phabricator.wikimedia.org/T143261) (owner: 10Jforrester) [15:15:45] 10VisualEditor, 10VisualEditor-DataModel, 13Patch-For-Review: Add serialize/deserialize methods to ve.dm.Transaction and ve.dm.IndexValueStore - https://phabricator.wikimedia.org/T161611#3137147 (10Jdforrester-WMF) p:05Triage>03Normal [15:15:50] (03CR) 10Jforrester: [C: 031] ":-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/344812 (https://phabricator.wikimedia.org/T161611) (owner: 10Divec) [15:19:16] 10VisualEditor, 10VisualEditor-MediaWiki: Opening a redirect page for editing in VE, then cancelling the edit, duplicates the redirect-related interface - https://phabricator.wikimedia.org/T161614#3137170 (10matmarex) [15:19:44] (03CR) 10Divec: "Thanks ... the new code is getting tested by the ve.dm.Change unit tests" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/344812 (https://phabricator.wikimedia.org/T161611) (owner: 10Divec) [15:20:02] 10VisualEditor, 10VisualEditor-MediaWiki: Opening a redirect page for editing in VE, then cancelling the edit, duplicates the redirect-related interface - https://phabricator.wikimedia.org/T161614#3137183 (10Jdforrester-WMF) p:05Triage>03Normal [15:20:32] (03CR) 10Bartosz Dziewoński: [C: 04-2] ve.init.mw.DesktopArticleTarget: Hide redirect subtitle if we cancel editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345081 (owner: 10Bartosz Dziewoński) [15:20:41] (03CR) 10Bartosz Dziewoński: [C: 04-2] "I found a task for this. :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345081 (owner: 10Bartosz Dziewoński) [15:22:33] (03CR) 10Bartosz Dziewoński: "Actually, nevermind, I was thinking of T144885 but that's a different case." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345081 (owner: 10Bartosz Dziewoński) [15:22:50] James_F: I got sidetracked onto other things. [15:22:53] (03CR) 10Bartosz Dziewoński: [C: 032] ve.init.mw.DesktopArticleTarget: Hide redirect subtitle if we cancel editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345081 (owner: 10Bartosz Dziewoński) [15:24:11] (03CR) 10jerkins-bot: [V: 04-1] WIP WebdriverIO tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345146 (https://phabricator.wikimedia.org/T150435) (owner: 10Zfilipin) [15:26:27] 10VisualEditor, 10VisualEditor-MediaWiki, 15User-Ryasmeen: VisualEditor should support redirects to sections on a page - https://phabricator.wikimedia.org/T69147#3137208 (10matmarex) 05Open>03Resolved This seems to work the right way these days. If you input a title+section, the same is shown as the firs... [15:27:55] (03PS5) 10Zfilipin: WIP WebdriverIO tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345146 (https://phabricator.wikimedia.org/T150435) [15:28:07] 10VisualEditor, 10VisualEditor-MediaWiki: After saving an article atop a redirect, sub continues to show "Redirect page" - https://phabricator.wikimedia.org/T144885#3137227 (10matmarex) 05Open>03Invalid I can't reproduce this either. But there are other funny issues with the "Redirect page" subtitle, see T... [15:28:59] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage, 06Wikisource: Writing manual s into header/footer using VisualEditor with ProofreadPage corrupts the page - https://phabricator.wikimedia.org/T138604#3137248 (10Jdforrester-WMF) >>! In T138604#2406393, @Tpt wrote: > After more investigation t... [15:31:02] James_F: So, my letting it sit at the back at my head is mostly because this whole thing seems like a bit of a hack (including my original patch, of course). I feel the "right" thing to do would be to make changes to resourceloader such that something like GlobalCssJs has a way to say "load me with core module X", so we don't wind up with various modules not [15:31:02] strictly related to VE having to stick some VE-specific config into their extension.json. [15:31:25] * James_F nods. [15:31:28] That said, this approach does work, and is a lot easier than major resourceloader changes. [15:31:45] Though if we eventually push VE into core, lots of extensions knowing about it would make sense. [15:31:47] * James_F shrugs. [15:32:00] Kemayo: Shall we just merge it and move on with our lives? :-) [15:33:08] 😭 [15:36:43] (03PS6) 10Zfilipin: WIP WebdriverIO tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345146 (https://phabricator.wikimedia.org/T150435) [15:42:56] (03CR) 10DLynch: [C: 032] DesktopArticleTarget: Make the waiting module list extensible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335462 (https://phabricator.wikimedia.org/T156899) (owner: 10DLynch) [15:43:10] (03Merged) 10jenkins-bot: ve.init.mw.DesktopArticleTarget: Hide redirect subtitle if we cancel editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345081 (owner: 10Bartosz Dziewoński) [15:44:38] (03PS1) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget: Refactor redirect interface handling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345166 (https://phabricator.wikimedia.org/T161614) [15:44:44] Kemayo: Thanks; and https://gerrit.wikimedia.org/r/#/c/343226/ :-) [15:45:02] (03CR) 10jerkins-bot: [V: 04-1] WIP WebdriverIO tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345146 (https://phabricator.wikimedia.org/T150435) (owner: 10Zfilipin) [15:47:53] MatmaRex: That's… a lot bigger patch than I was expecting. :-) [15:48:35] James_F: it's a lot bigger than i was expecting too. :) [15:49:21] Also, when you 'refactor' code generally people expect the number of lines to go down, not up. :-P [15:49:51] i could probably make a small fix, but the existing logic was pretty messy. it's still not great, but i think the remaining messiness is unavoidable [15:50:11] at least we keep the DOM changes to one place now, rather than a dozen [15:50:17] and each one done differently [15:50:18] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 15User-Ryasmeen: Paste identical annotated content into (end of?) an annotation serialises very poorly because it gets dou... - https://phabricator.wikimedia.org/T143261#3137331 [15:51:00] 10VisualEditor, 10VisualEditor-EditingTools, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 15User-Ryasmeen: Visual diff crashes if you convert an existing paragraph to a blockquote; the otherNode is a VeDmTextNode which doesn't have a .node.typ... - https://phabricator.wikimedia.org/T161262#3137334 [15:51:02] James_F: it's all because of the silly doc comments. ;) [15:51:45] Yeah yeah. [15:51:45] 10VisualEditor, 10VisualEditor-EditingTools, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 15User-Ryasmeen: References defined in templates can be 'edited' by pressing enter or double clicking - https://phabricator.wikimedia.org/T161547#3137337 (10Jdforrester-WMF) 05Open>03Resolved p:05Tr... [15:51:54] (Nice work. ;-)) [15:53:57] (03CR) 10jenkins-bot: ve.init.mw.DesktopArticleTarget: Hide redirect subtitle if we cancel editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345081 (owner: 10Bartosz Dziewoński) [15:59:03] (03Merged) 10jenkins-bot: DesktopArticleTarget: Make the waiting module list extensible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335462 (https://phabricator.wikimedia.org/T156899) (owner: 10DLynch) [16:04:42] (03CR) 10jenkins-bot: DesktopArticleTarget: Make the waiting module list extensible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335462 (https://phabricator.wikimedia.org/T156899) (owner: 10DLynch) [16:05:02] (03CR) 10Zfilipin: "check experimental" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345146 (https://phabricator.wikimedia.org/T150435) (owner: 10Zfilipin) [16:07:57] (03CR) 10jerkins-bot: [V: 04-1] WIP WebdriverIO tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345146 (https://phabricator.wikimedia.org/T150435) (owner: 10Zfilipin) [16:15:21] 10VisualEditor, 10VisualEditor-Initialisation, 10GlobalCssJs, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 15User-Ryasmeen: VE should wait for global.js before init - https://phabricator.wikimedia.org/T156899#3137454 (10Jdforrester-WMF) 05Open>03Resolved [16:15:30] 10VisualEditor, 07Browser-Tests, 13Patch-For-Review, 15User-zeljkofilipin: Selenium tests for VisualEditor in Node.js - https://phabricator.wikimedia.org/T150435#3137457 (10zeljkofilipin) a:05zeljkofilipin>03Ryasmeen @Ryasmeen I am assigning the task back to you. I have abandoned the webdriverjs patch... [16:24:03] 10VisualEditor, 10VisualEditor-MediaWiki, 10Comments, 10Parsoid, 10Social-Tools: VisualEditor/Parsoid breaking Extension:Tabber and Extension:Comments parser extension tags (incorrect serialisation) - https://phabricator.wikimedia.org/T152137#2839632 (10Arlolra) > Often when this happens it's because VE... [16:31:07] (03CR) 10Jforrester: [C: 032] ve.init.mw.DesktopArticleTarget: Refactor redirect interface handling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345166 (https://phabricator.wikimedia.org/T161614) (owner: 10Bartosz Dziewoński) [16:32:21] 10VisualEditor, 06Discovery, 10RelatedArticles, 10UI-Standardization, and 3 others: Align the style for lists of pages - https://phabricator.wikimedia.org/T153417#3137564 (10Volker_E) Another question from a style guide perspective, should the thumbnails feature rounded borders? [16:41:41] (03Merged) 10jenkins-bot: ve.init.mw.DesktopArticleTarget: Refactor redirect interface handling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345166 (https://phabricator.wikimedia.org/T161614) (owner: 10Bartosz Dziewoński) [16:42:11] 10VisualEditor, 10VisualEditor-MediaWiki, 15User-Ryasmeen: Opening a redirect page for editing in VE, then cancelling the edit, duplicates the redirect-related interface - https://phabricator.wikimedia.org/T161614#3137647 (10Jdforrester-WMF) 05Open>03Resolved a:03matmarex [16:43:18] 10VisualEditor, 10VisualEditor-MediaWiki, 10Comments, 10Parsoid, 10Social-Tools: VisualEditor/Parsoid breaking Extension:Tabber and Extension:Comments parser extension tags (incorrect serialisation) - https://phabricator.wikimedia.org/T152137#3137651 (10StarWarden) The version of Parsoid is 0.6.1 (which,... [16:44:58] (03PS1) 10DLynch: MediaDialog: flag caption widget as being in a dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345180 (https://phabricator.wikimedia.org/T161555) [16:46:09] Kemayo: Ha, I'd forgotten we had that. [16:46:59] 10Citoid, 10VisualEditor, 10Graphoid, 06Operations, and 4 others: SCB services should not use a proxy for our domains - https://phabricator.wikimedia.org/T97530#3137659 (10mobrovac) 05Open>03Resolved All of the services that do not need the proxy, don't use it. Moreover, with the switch to Scap3 config... [16:47:14] 10VisualEditor, 10VisualEditor-MediaWiki, 10Comments, 10Parsoid, 10Social-Tools: VisualEditor/Parsoid breaking Extension:Tabber and Extension:Comments parser extension tags (incorrect serialisation) - https://phabricator.wikimedia.org/T152137#3137663 (10Arlolra) Since the `typeof="mw:Extension/tabber"` i... [16:47:27] (03CR) 10Jforrester: [C: 032] MediaDialog: flag caption widget as being in a dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345180 (https://phabricator.wikimedia.org/T161555) (owner: 10DLynch) [16:48:25] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 13Patch-For-Review, 15User-Ryasmeen: In the media dialog, Command-Enter adds a blank line to the caption and closes the dialog - https://phabricator.wikimedia.org/T161555#3137665 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03DLynch [16:50:06] (03CR) 10jenkins-bot: ve.init.mw.DesktopArticleTarget: Refactor redirect interface handling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345166 (https://phabricator.wikimedia.org/T161614) (owner: 10Bartosz Dziewoński) [16:51:44] We have so many things. [16:52:21] 10VisualEditor, 10VisualEditor-MediaWiki, 10Comments, 10Parsoid, 10Social-Tools: VisualEditor/Parsoid breaking Extension:Tabber and Extension:Comments parser extension tags (incorrect serialisation) - https://phabricator.wikimedia.org/T152137#3137678 (10Jdforrester-WMF) Oh, right, yes. We intentionally d... [16:57:23] (03Merged) 10jenkins-bot: MediaDialog: flag caption widget as being in a dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345180 (https://phabricator.wikimedia.org/T161555) (owner: 10DLynch) [17:01:30] (03CR) 10jenkins-bot: MediaDialog: flag caption widget as being in a dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345180 (https://phabricator.wikimedia.org/T161555) (owner: 10DLynch) [17:02:12] (03PS1) 10Bartosz Dziewoński: ve.init.mw.ArticleTarget: Don't construct element IDs dynamically [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345185 [17:02:51] 10VisualEditor, 10VisualEditor-MediaWiki, 10Comments, 10Parsoid, 10Social-Tools: VisualEditor/Parsoid breaking Extension:Tabber and Extension:Comments parser extension tags (incorrect serialisation) - https://phabricator.wikimedia.org/T152137#3137739 (10Arlolra) A simple workaround could be for the exten... [17:04:44] 10VisualEditor: Replace the check for $wgVisualEditorSupportedSkins with a check for something in the skin itself - https://phabricator.wikimedia.org/T161373#3137751 (10matmarex) a:03matmarex [17:08:00] 10VisualEditor, 10VisualEditor-MediaWiki: Replace the check for $wgVisualEditorSupportedSkins with a check for something in the skin itself - https://phabricator.wikimedia.org/T161373#3137762 (10Jdforrester-WMF) p:05Triage>03Low [17:11:26] 10VisualEditor, 10VisualEditor-MediaWiki, 10Comments, 10Parsoid, 10Social-Tools: VisualEditor/Parsoid breaking Extension:Tabber and Extension:Comments parser extension tags (incorrect serialisation) - https://phabricator.wikimedia.org/T152137#3137786 (10ashley) The Tabber issue is most likely caused by a... [17:13:34] (03CR) 10Jforrester: [C: 032] ve.init.mw.ArticleTarget: Don't construct element IDs dynamically [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345185 (owner: 10Bartosz Dziewoński) [17:23:12] (03Merged) 10jenkins-bot: ve.init.mw.ArticleTarget: Don't construct element IDs dynamically [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345185 (owner: 10Bartosz Dziewoński) [17:28:33] (03CR) 10jenkins-bot: ve.init.mw.ArticleTarget: Don't construct element IDs dynamically [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345185 (owner: 10Bartosz Dziewoński) [17:33:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10Comments, 10Parsoid, 10Social-Tools: VisualEditor/Parsoid breaking Extension:Tabber and Extension:Comments parser extension tags (incorrect serialisation) - https://phabricator.wikimedia.org/T152137#3137848 (10StarWarden) Swapping to the master version of Tabbe... [17:54:37] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Community-Liaisons: Support wikis in converting reference lists over to `responsive` - https://phabricator.wikimedia.org/T159895#3137936 (10Whatamidoing-WMF) a:03Whatamidoing-WMF [18:02:08] 10VisualEditor, 10VisualEditor-MediaWiki, 10Comments, 10Parsoid, 10Social-Tools: VisualEditor/Parsoid breaking Extension:Tabber and Extension:Comments parser extension tags (incorrect serialisation) - https://phabricator.wikimedia.org/T152137#3137968 (10Arlolra) Is there an example of a broken edit as a... [18:28:51] 10VisualEditor, 10VisualEditor-MediaWiki, 10Comments, 10Parsoid, 10Social-Tools: VisualEditor/Parsoid breaking Extension:Tabber and Extension:Comments parser extension tags (incorrect serialisation) - https://phabricator.wikimedia.org/T152137#3138067 (10StarWarden) I did it here: http://dragon-mania-lege... [18:38:16] 10VisualEditor, 06Discovery, 10RelatedArticles, 10UI-Standardization, and 3 others: Align the style for lists of pages - https://phabricator.wikimedia.org/T153417#3138090 (10JGirault) >>! In T153417#3137564, @Volker_E wrote: > Another question from a style guide perspective, should the thumbnails feature r... [18:58:20] 10VisualEditor, 03Interactive-Sprint, 06Maps (Kartographer): Disable VE editing of maplink / mapframe when the editor is not able to - https://phabricator.wikimedia.org/T157996#3022930 (10JGirault) a:03JGirault [19:07:16] 10VisualEditor, 10VisualEditor-MediaWiki, 10Comments, 10Parsoid, and 2 others: VisualEditor/Parsoid breaking Extension:Tabber and Extension:Comments parser extension tags (incorrect serialisation) - https://phabricator.wikimedia.org/T152137#3138160 (10Arlolra) 05stalled>03Resolved a:03Arlolra > The b... [19:08:34] 10VisualEditor: Fram can't see edit notices in VisualEditor - https://phabricator.wikimedia.org/T161642#3138164 (10Whatamidoing-WMF) [19:11:37] (03PS1) 10Jforrester: build: Bump various devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345201 [19:12:57] James_F: which skins do we actually claim to support? [19:13:21] James_F: or to rephrase, what is 'blueprint' doing in our VisualEditorSupportedSkins? it barely works [19:13:44] (e.g. the toolbar is misplaced and disappears completely when you scroll) [19:17:54] MatmaRex: Vector Apex Monobook, plus other skins added by their maintainers' request. [19:18:15] James_F: minerva? [19:19:25] MatmaRex: I think that's just for the desktop Minerva beta feature. [19:19:38] MatmaRex: Not sure if it's needed for mobile. [19:20:34] hmm, desktop minerva is actually crapping out with weird errors for me locally [19:23:02] (03PS1) 10Bartosz Dziewoński: ve.ui.MWAdvancedSettingsPage: Don't read the text of the #ca-edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345204 [19:23:04] (03PS1) 10Bartosz Dziewoński: Don't use '#content #firstHeading', unnecessarily specific [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345205 [19:23:06] (03PS1) 10Bartosz Dziewoński: Consistently use #catlinks to refer to category links container [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345206 [19:23:08] (03PS1) 10Bartosz Dziewoński: Replace $wgVisualEditorSupportedSkins with a check for required elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345207 (https://phabricator.wikimedia.org/T161373) [19:23:16] James_F: anyway. ^ thoughts? [19:23:32] i also updated https://www.mediawiki.org/wiki/VisualEditor/Skin_requirements . we only really need #content and #mw-content-text [19:25:11] (03CR) 10Jforrester: [C: 04-1] "This won't work if ca-edit is taken over for other purposes, IIRC." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345204 (owner: 10Bartosz Dziewoński) [19:34:51] Sorry I don't have a useful memory of what we did what we did for 345204. [19:35:21] That [20:09:03] 10VisualEditor, 10VisualEditor-MediaWiki: "Uncaught TypeError: Cannot read property 'node' of undefined" when viewing visual diff - https://phabricator.wikimedia.org/T161646#3138307 (10matmarex) [20:20:18] 10VisualEditor: Add links to https://www.mediawiki.org/wiki/VisualEditor/Skin_requirements from some more places related to VisualEditor and/or skinning - https://phabricator.wikimedia.org/T161372#3138337 (10matmarex) I wrote these: * https://www.mediawiki.org/wiki/Extension:VisualEditor#Skin_compatibility * htt... [20:49:08] (03PS1) 10Bartosz Dziewoński: ve.ce.Surface: Check sequences after paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345233 (https://phabricator.wikimedia.org/T161152) [21:09:58] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345244 (owner: 10L10n-bot) [21:13:10] (03CR) 10Bartosz Dziewoński: "Such as?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345204 (owner: 10Bartosz Dziewoński) [21:18:40] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 13Patch-For-Review: Pasted ISBNs should trigger the ISBN typing auto-linking - https://phabricator.wikimedia.org/T161152#3138446 (10matmarex) This should resolve the specific example. But we still can't autolink ISBNs inside big pasted... [21:23:23] 10VisualEditor, 10VisualEditor-MediaWiki: Strange layout quirks with "You have switched" message - https://phabricator.wikimedia.org/T161648#3138454 (10Krinkle) [21:25:42] 10VisualEditor, 10VisualEditor-MediaWiki: Strange layout quirks with "You have switched" message - https://phabricator.wikimedia.org/T161648#3138454 (10matmarex) Looks like T158341. [21:37:17] Roan: Want to merge https://gerrit.wikimedia.org/r/#/c/343204/ for me? :-) [21:43:59] 10VisualEditor, 10VisualEditor-MediaWiki: "Uncaught TypeError: Cannot read property 'node' of undefined" when viewing visual diff - https://phabricator.wikimedia.org/T161646#3138537 (10Jdforrester-WMF) 05Open>03stalled > This kills the save dialog. It's impossible to close it or save the changes. Unless yo... [21:46:14] (03PS1) 10Esanders: Separate screenshot test runner from specific tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345252 [21:46:16] (03PS1) 10Esanders: VisualDiff automated screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345253 [21:49:27] 10VisualEditor, 10VisualEditor-MediaWiki: "Uncaught TypeError: Cannot read property 'node' of undefined" when viewing visual diff - https://phabricator.wikimedia.org/T161646#3138574 (10matmarex) I was trying to save this edit: https://www.mediawiki.org/w/index.php?title=Extension:VisualEditor&diff=2432847&oldi... [22:09:43] 10VisualEditor, 10Parsoid, 13Patch-For-Review: Unnecessary when editing indent-pre with lines starting with '*' - https://phabricator.wikimedia.org/T160207#3138612 (10Arlolra) p:05Triage>03Normal [22:11:32] 10VisualEditor, 10OOjs-UI: MediaWiki theme: Tools & ToolGroupTools receive visual `:hover` feedback, normal ToolGroups don't - https://phabricator.wikimedia.org/T161653#3138613 (10Volker_E) [22:17:29] 10VisualEditor, 10OOjs-UI: MediaWiki theme: Tools & ToolGroupTools receive visual `:hover` feedback, normal ToolGroups don't - https://phabricator.wikimedia.org/T161653#3138649 (10Volker_E) [22:32:28] 10VisualEditor, 10Parsoid, 13Patch-For-Review, 15User-Ryasmeen: Unnecessary when editing indent-pre with lines starting with '*' - https://phabricator.wikimedia.org/T160207#3138681 (10Arlolra) 05Open>03Resolved a:03Arlolra [23:08:00] (03PS1) 10VolkerE: Update OOjs UI to v0.20.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345262 [23:20:24] 10VisualEditor: Add links to https://www.mediawiki.org/wiki/VisualEditor/Skin_requirements from some more places related to VisualEditor and/or skinning - https://phabricator.wikimedia.org/T161372#3138843 (10Isarra) I can't think of anything, but that may not be saying much.