[01:06:49] 10VisualEditor, 03Interactive-Sprint, 06Maps (Kartographer), 13Patch-For-Review: Disable VE editing of maplink / mapframe when the editor is not able to - https://phabricator.wikimedia.org/T157996#3139108 (10JGirault) With this patch: | Maplink not supported in VE | {F7065487} | Mapframe not supported in... [01:53:59] Hi. I'm having an issue with VisualEditor, where it has trouble connecting to Parsoid due to cross domain calls. or something. :) [01:54:31] XMLHttpRequest cannot load http://joshuarosales.com:7231/localhost/v1/transform/wikitext/to/html/Inner_Product/127. Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://joshuarosales.com' is therefore not allowed access. The response had HTTP status code 404. [01:54:37] That's the error I'm getting. [01:54:53] When I hit the EDIT button. [02:03:27] Can anyone help me with that? [02:03:59] I think I narrowed the issue down to cross domain calls. If I start the browser in an unsafe mode where it allows such calls, it works. [05:07:04] 10VisualEditor, 10Parsoid: Can't connect to parsoid through Visual Editor Extension due to cross-domain calls - https://phabricator.wikimedia.org/T161672#3139213 (10Joshuar7) [07:43:29] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link inspector uppercases target inside the word without any reason - https://phabricator.wikimedia.org/T161681#3139467 (10Schnark) [07:50:46] (03CR) 10Esanders: [C: 032] Serialize/deserialize for Transaction and IndexValueStore [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/344812 (https://phabricator.wikimedia.org/T161611) (owner: 10Divec) [07:53:50] (03Merged) 10jenkins-bot: Serialize/deserialize for Transaction and IndexValueStore [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/344812 (https://phabricator.wikimedia.org/T161611) (owner: 10Divec) [07:54:29] (03CR) 10Esanders: [C: 04-1] "I think we should let sequences declare if they trigger on paste. This doesn't really make sense for most of our sequences where they are " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345233 (https://phabricator.wikimedia.org/T161152) (owner: 10Bartosz Dziewoński) [07:58:48] (03CR) 10jenkins-bot: Serialize/deserialize for Transaction and IndexValueStore [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/344812 (https://phabricator.wikimedia.org/T161611) (owner: 10Divec) [08:43:02] RedPanda check your Parsoid config [08:59:14] Red also your RESTBase config [11:18:27] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage, 06Wikisource: Writing manual s into header/footer using VisualEditor with ProofreadPage corrupts the page - https://phabricator.wikimedia.org/T138604#3139885 (10Tpt) > Does that mean this is now Resolved as all the old pages have expired? Sa... [11:56:05] 10VisualEditor, 10Wikimedia-Site-requests, 07Community-consensus-needed: Enable VisualEditor by default for all users of the Dutch Wikipedia - https://phabricator.wikimedia.org/T161365#3140023 (10Johan) [12:18:50] 10VisualEditor, 10Parsoid, 10RESTBase: Can't connect to parsoid through Visual Editor Extension due to cross-domain calls - https://phabricator.wikimedia.org/T161672#3140057 (10Arlolra) Probably need to add `cors: '*'` to the RESTBase conf. Parsoid's default is to `allowCORS`. [12:51:23] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.20.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345262 (owner: 10VolkerE) [12:54:17] (03Merged) 10jenkins-bot: Update OOjs UI to v0.20.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345262 (owner: 10VolkerE) [12:59:28] (03CR) 10jenkins-bot: Update OOjs UI to v0.20.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345262 (owner: 10VolkerE) [13:15:59] 10VisualEditor, 10Parsoid: Flag invalid wikitext to the editor's attention in VisualEditor - https://phabricator.wikimedia.org/T89041#3140212 (10Arlolra) 05Open>03declined Parsing errors are now surfaced with #mediawiki-extensions-linter [13:59:26] 10VisualEditor, 10Parsoid, 10RESTBase, 06Services (done): Can't connect to parsoid through Visual Editor Extension due to cross-domain calls - https://phabricator.wikimedia.org/T161672#3140314 (10Pchelolo) Your problem is on us. At some point we've made CORS optional and moved it to a filter that has to be... [14:37:50] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link inspector uppercases target inside the word without any reason - https://phabricator.wikimedia.org/T161681#3139467 (10DLynch) I don't see this happening. {F7081379} [14:45:03] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link inspector uppercases target inside the word without any reason - https://phabricator.wikimedia.org/T161681#3140443 (10Jdforrester-WMF) 05Open>03stalled Same here. Possibly a temporary glitch in the search DB? [14:49:36] 10VisualEditor, 10Parsoid, 15User-Ryasmeen: Unnecessary when editing indent-pre with lines starting with '*' - https://phabricator.wikimedia.org/T160207#3092151 (10Jdforrester-WMF) [15:13:25] 10VisualEditor, 10Parsoid, 10RESTBase, 06Services (done): Can't connect to parsoid through Visual Editor Extension due to cross-domain calls - https://phabricator.wikimedia.org/T161672#3140542 (10Joshuar7) I had a lot of difficulty finding this change onine, since there also seems to be obsolete documentat... [15:15:56] 10VisualEditor, 10Parsoid, 10RESTBase, 06Services (done), 15User-Ryasmeen: Can't connect to parsoid through Visual Editor Extension due to cross-domain calls - https://phabricator.wikimedia.org/T161672#3140560 (10Pchelolo) 05Open>03Resolved [15:24:51] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References: Don't die if the user tries to nest a inside another one - https://phabricator.wikimedia.org/T153543#2883686 (10DLynch) I can't reproduce an outright freeze. Could you give some more precise steps you took? I did note that trying to write `{... [15:26:44] James_F: Should the template dialog support parser functions like #tag? It currently doesn't, because #tag isn't a valid Title... [15:28:03] ...also it can cause an error because hitting enter in the template-name field tries to submit the form, even if the button is disabled. [15:32:19] Kemayo: It does and doesn't. [15:32:40] Kemayo: There's a task to properly support them, but it's not had any work done on it for four years. [15:32:40] I mean, you can edit ones that are already in the page, but you can't add new ones. [15:32:44] Yeah. [15:32:55] But you also can't edit the zeroth/first parameter. [15:33:20] Because templates are {{foo|1|2|3}} and parser functions are {{#foo:1|2|3}}. [15:33:33] So VE lets you edit 2 and 3 for parser functions. [15:53:14] 10VisualEditor: Transclusion dialog tries to submit invalid titles when enter is pressed - https://phabricator.wikimedia.org/T161715#3140672 (10DLynch) [15:54:06] (03PS1) 10DLynch: Add template: don't try to add invalid templates when enter is pressed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345385 (https://phabricator.wikimedia.org/T161715) [15:55:46] (03CR) 10Jforrester: [C: 032] Add template: don't try to add invalid templates when enter is pressed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345385 (https://phabricator.wikimedia.org/T161715) (owner: 10DLynch) [15:56:21] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 15User-Ryasmeen: Transclusion dialog tries to submit invalid titles when enter is pressed - https://phabricator.wikimedia.org/T161715#3140696 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal [16:00:27] (03CR) 10Jforrester: [C: 032] Separate screenshot test runner from specific tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345252 (owner: 10Esanders) [16:00:41] (03CR) 10Jforrester: [C: 032] VisualDiff automated screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345253 (owner: 10Esanders) [16:05:33] (03CR) 10jerkins-bot: [V: 04-1] Add template: don't try to add invalid templates when enter is pressed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345385 (https://phabricator.wikimedia.org/T161715) (owner: 10DLynch) [16:10:43] (03CR) 10DLynch: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345385 (https://phabricator.wikimedia.org/T161715) (owner: 10DLynch) [16:10:51] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345385 (https://phabricator.wikimedia.org/T161715) (owner: 10DLynch) [16:11:52] * James_F grins at Kemayo. [16:12:34] (03PS1) 10Esanders: Fix disabling of surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345388 [16:14:43] (03Merged) 10jenkins-bot: Separate screenshot test runner from specific tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345252 (owner: 10Esanders) [16:14:44] (03Merged) 10jenkins-bot: VisualDiff automated screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345253 (owner: 10Esanders) [16:20:50] (03CR) 10jenkins-bot: Separate screenshot test runner from specific tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345252 (owner: 10Esanders) [16:25:55] (03PS2) 10Esanders: Fix disabling of surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345388 [16:26:33] (03CR) 10jenkins-bot: VisualDiff automated screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345253 (owner: 10Esanders) [16:26:49] (03CR) 10Jforrester: [C: 032] Fix disabling of surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345388 (owner: 10Esanders) [16:28:48] (03CR) 10Jforrester: [C: 032] Add template: don't try to add invalid templates when enter is pressed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345385 (https://phabricator.wikimedia.org/T161715) (owner: 10DLynch) [16:29:21] (03Merged) 10jenkins-bot: Fix disabling of surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345388 (owner: 10Esanders) [16:30:04] 10VisualEditor, 10Parsoid, 10Parsoid-Serializer: Adding content to an empty table cell written in inline form results in the serialised wikitext being in the one-cell-per-line format - https://phabricator.wikimedia.org/T65356#3140875 (10Arlolra) [16:36:27] (03CR) 10jenkins-bot: Fix disabling of surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345388 (owner: 10Esanders) [16:39:01] (03Merged) 10jenkins-bot: Add template: don't try to add invalid templates when enter is pressed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345385 (https://phabricator.wikimedia.org/T161715) (owner: 10DLynch) [16:49:44] (03CR) 10jenkins-bot: Add template: don't try to add invalid templates when enter is pressed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345385 (https://phabricator.wikimedia.org/T161715) (owner: 10DLynch) [17:14:54] James_F: So unsurprisingly CodeEditor+Linter doesn't work either :( [17:15:25] legoktm: I'd've guessed. [17:24:18] MatmaRex: Want to reply on https://gerrit.wikimedia.org/r/#/c/344805/ one way or the other? Was thinking I'd merge it now. [17:25:49] James_F: replied [17:26:18] Ta. [17:36:28] (03CR) 10Jforrester: [C: 04-1] "Well, it ignores the values used by Vector or Monobook and instead uses a value neither of them use, which means it will be possibly wrong" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345204 (owner: 10Bartosz Dziewoński) [17:37:00] (03PS2) 10Jforrester: Consistently use #catlinks to refer to category links container [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345206 (owner: 10Bartosz Dziewoński) [17:37:05] (03CR) 10Jforrester: [C: 032] Consistently use #catlinks to refer to category links container [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345206 (owner: 10Bartosz Dziewoński) [17:37:30] (03PS2) 10Jforrester: Don't use '#content #firstHeading', unnecessarily specific [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345205 (owner: 10Bartosz Dziewoński) [17:37:54] (03CR) 10Jforrester: [C: 032] Don't use '#content #firstHeading', unnecessarily specific [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345205 (owner: 10Bartosz Dziewoński) [17:59:12] (03Merged) 10jenkins-bot: Consistently use #catlinks to refer to category links container [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345206 (owner: 10Bartosz Dziewoński) [18:02:22] (03Merged) 10jenkins-bot: Don't use '#content #firstHeading', unnecessarily specific [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345205 (owner: 10Bartosz Dziewoński) [18:05:32] (03CR) 10jenkins-bot: Consistently use #catlinks to refer to category links container [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345206 (owner: 10Bartosz Dziewoński) [18:11:49] (03CR) 10jenkins-bot: Don't use '#content #firstHeading', unnecessarily specific [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345205 (owner: 10Bartosz Dziewoński) [18:12:52] (03CR) 10Bartosz Dziewoński: "en.wp's dumb overrides are rarely a good reason to stop progress. The default is sane: https://en.wikipedia.org/wiki/MediaWiki:Edit/en . B" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345204 (owner: 10Bartosz Dziewoński) [18:12:56] (03Abandoned) 10Bartosz Dziewoński: ve.ui.MWAdvancedSettingsPage: Don't read the text of the #ca-edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345204 (owner: 10Bartosz Dziewoński) [18:13:06] (03PS2) 10Bartosz Dziewoński: Replace $wgVisualEditorSupportedSkins with a check for required elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345207 (https://phabricator.wikimedia.org/T161373) [18:36:48] MatmaRex: The "right" answer is to get rid of the concept of skins and so there's only one damn "edit" label. [18:37:31] James_F: that actually doesn't require getting rid of the concept of skins. [18:37:45] it's just that our existing skins stupidly all used separate messages. [18:38:31] MatmaRex: OK, change what the word "skin" means so there's only one damn "edit" label, happy? :-) [18:38:58] James_F: you literally only need to delete the 'vector-view-edit' message from Vector, and it will magically fall back to 'edit'. [18:39:19] and same for the other dozen similar ones. [18:39:59] it's just all dumb copypasta from MonoBook, which probably also copypasted this from whatever was there prior to MonoBook. [18:40:29] We didn't call it a skin before then [18:47:32] (03CR) 10Jforrester: Replace $wgVisualEditorSupportedSkins with a check for required elements (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345207 (https://phabricator.wikimedia.org/T161373) (owner: 10Bartosz Dziewoński) [18:48:26] MatmaRex: ^^ Not a blocker, just a meh. [19:19:50] (03CR) 10Bartosz Dziewoński: Replace $wgVisualEditorSupportedSkins with a check for required elements (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345207 (https://phabricator.wikimedia.org/T161373) (owner: 10Bartosz Dziewoński) [19:51:11] 10VisualEditor, 10VisualEditor-MediaWiki, 07Documentation: Add links to https://www.mediawiki.org/wiki/VisualEditor/Skin_requirements from some more places related to VisualEditor and/or skinning - https://phabricator.wikimedia.org/T161372#3141624 (10matmarex) [19:58:10] MatmaRex: Were you going to fix the "copypasta" in https://gerrit.wikimedia.org/r/#/c/344805/ or should I guess what it should say? [20:00:16] James_F: i guess i can. doing [20:00:27] Thanks. :-0 [20:32:36] 10VisualEditor, 06Discovery, 10RelatedArticles, 10UI-Standardization, and 3 others: Align the style for lists of pages - https://phabricator.wikimedia.org/T153417#3141804 (10Prtksxna) Following (and forking) @pginer-wmf's lead on T92452, I've created a sample on [[ http://codepen.io/anon/pen/dvQpjm | codep... [20:38:09] 10VisualEditor, 10VisualEditor-MediaWiki, 07Documentation, 15User-Ryasmeen: Add links to https://www.mediawiki.org/wiki/VisualEditor/Skin_requirements from some more places related to VisualEditor and/or skinning - https://phabricator.wikimedia.org/T161372#3141834 (10matmarex) 05Open>03Resolved a:03ma... [21:05:43] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345464 (owner: 10L10n-bot) [21:21:49] (03PS1) 10Esanders: Pass section when resolving conflicts in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345473 (https://phabricator.wikimedia.org/T154217) [21:22:00] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 13Patch-For-Review, 15User-Urbanecm: Page blanked when editing a section after an edit conflict - https://phabricator.wikimedia.org/T154217#2904393 (10Esanders) Thanks for the investigation! [21:47:19] 10VisualEditor, 10VisualEditor-MediaWiki, 07Documentation, 15User-Ryasmeen: Add links to https://www.mediawiki.org/wiki/VisualEditor/Skin_requirements from some more places related to VisualEditor and/or skinning - https://phabricator.wikimedia.org/T161372#3142246 (10Jdforrester-WMF) p:05Triage>03Low [21:51:54] (03CR) 10Catrope: [C: 032] Pass section when resolving conflicts in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345473 (https://phabricator.wikimedia.org/T154217) (owner: 10Esanders) [21:56:59] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Ryasmeen, 15User-Urbanecm: Page blanked when editing a section after an edit conflict - https://phabricator.wikimedia.org/T154217#3142296 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders [21:58:33] 10VisualEditor, 10VisualEditor-MediaWiki: Switching to edit conflict screen should make the save dialog pending (before the page gets reloaded) - https://phabricator.wikimedia.org/T161768#3142300 (10Jdforrester-WMF) [22:00:31] (03Merged) 10jenkins-bot: Pass section when resolving conflicts in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345473 (https://phabricator.wikimedia.org/T154217) (owner: 10Esanders) [22:07:04] (03CR) 10jenkins-bot: Pass section when resolving conflicts in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345473 (https://phabricator.wikimedia.org/T154217) (owner: 10Esanders) [23:02:59] (03CR) 10Jforrester: [C: 032] Replace $wgVisualEditorSupportedSkins with a check for required elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345207 (https://phabricator.wikimedia.org/T161373) (owner: 10Bartosz Dziewoński) [23:03:40] 10VisualEditor, 10VisualEditor-MediaWiki, 15User-Ryasmeen: Replace the check for $wgVisualEditorSupportedSkins with a check for something in the skin itself - https://phabricator.wikimedia.org/T161373#3142454 (10Jdforrester-WMF) 05Open>03Resolved [23:14:54] (03Merged) 10jenkins-bot: Replace $wgVisualEditorSupportedSkins with a check for required elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345207 (https://phabricator.wikimedia.org/T161373) (owner: 10Bartosz Dziewoński) [23:19:54] (03CR) 10jenkins-bot: Replace $wgVisualEditorSupportedSkins with a check for required elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345207 (https://phabricator.wikimedia.org/T161373) (owner: 10Bartosz Dziewoński) [23:45:14] 10VisualEditor, 06Editing-Department, 10MediaWiki-General-or-Unknown, 10MediaWiki-Parser, and 2 others: Selflinks should still be tags with CSS styling via a class, not tags - https://phabricator.wikimedia.org/T160480#3142551 (10Jdforrester-WMF) 05Open>03Resolved a:03Jdforrester-WMF [23:47:05] (03PS2) 10Jforrester: Render self-links as if they were s [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342084 (https://phabricator.wikimedia.org/T52497) [23:53:22] (03CR) 10Jforrester: "Now upstreamed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/342084 (https://phabricator.wikimedia.org/T52497) (owner: 10Jforrester)