[05:37:09] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/346095 (owner: 10L10n-bot) [08:29:04] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE adds links in summary when section headings are linked, while OWE doesn't - https://phabricator.wikimedia.org/T162017#3149912 (10Schnark) [09:51:34] 10Citoid, 10VisualEditor, 13Patch-For-Review: Visual Editor adds erroneous text "PMC" to citation template pmc= parameter - https://phabricator.wikimedia.org/T157152#3150098 (10Mvolz) This is declined because we're not going to remove the PMC in the backend, because this affects every language wiki and their... [09:51:46] 10Citoid, 10VisualEditor: Visual Editor adds erroneous text "PMC" to citation template pmc= parameter - https://phabricator.wikimedia.org/T157152#3150099 (10Mvolz) 05Open>03declined [10:23:39] 10VisualEditor, 10Parsoid: Add or move references on the visual editor creates superfluous wikitext or HTML markup () - https://phabricator.wikimedia.org/T162027#3150157 (10Trizek-WMF) [10:32:25] 10Citoid, 10VisualEditor, 07Russian-Sites: Change a type of dash in Russian Wikipedia - https://phabricator.wikimedia.org/T161963#3148526 (10Mvolz) This is kind of a tough one. We don't really have multilingual support in the backend; we will automatically request things using the language code of the wiki b... [10:36:39] 10Citoid, 10VisualEditor, 07Russian-Sites: Change a type of dash in Russian Wikipedia - https://phabricator.wikimedia.org/T161963#3150198 (10Mvolz) @mobrovac thoughts? [10:37:59] 10Citoid, 10VisualEditor, 07Russian-Sites: Punctuation is often language dependant - https://phabricator.wikimedia.org/T161963#3150200 (10Mvolz) [10:39:42] 10Citoid, 10VisualEditor, 07Russian-Sites: Punctuation is often language dependant - https://phabricator.wikimedia.org/T161963#3148526 (10Mvolz) Another possibility is to use the "accept-language" parameter and try to apply some rules of our own in the back end, so if we get accept-language = 'ru', replace t... [10:40:24] 10Citoid, 10VisualEditor, 07Russian-Sites: Punctuation is often language dependant - https://phabricator.wikimedia.org/T161963#3150204 (10Mvolz) p:05Triage>03Normal [11:08:15] 10Citoid, 10VisualEditor: Visual Editor adds erroneous text "PMC" to citation template pmc= parameter - https://phabricator.wikimedia.org/T157152#3150244 (10Boghog) Which Wikis have templates that require PMC in the identifier? Most Wikis currently do not have templates that support PMC and the ones that do... [13:42:43] 10Citoid, 10VisualEditor: Visual Editor adds erroneous text "PMC" to citation template pmc= parameter - https://phabricator.wikimedia.org/T157152#3150613 (10Mvolz) >There should be at least a localization setting that allows local Wikis to suppress PMC in the identifier. Other wikis accept the correct identif... [14:03:36] 10VisualEditor: Consider omitting the dialog title if there isn't room to display it - https://phabricator.wikimedia.org/T161955#3150752 (10Aklapper) [14:08:36] 10VisualEditor: Reload page before and after edit - https://phabricator.wikimedia.org/T161791#3150760 (10Aklapper) Is "Reload page before and after edit" a summary of a bug or a request for a feature? Please edit the task summary to clarify. Thanks! [14:33:43] 10Citoid, 10VisualEditor, 07Russian-Sites: Punctuation is often language dependant - https://phabricator.wikimedia.org/T161963#3150821 (10mobrovac) In RESTBase we already [set the langauage](https://github.com/wikimedia/restbase/blob/ece2d06b5064570db87c7244e85b8c6e2ed846ed/v1/citoid.js#L16-L20) based on the... [15:04:22] (03CR) 10Esanders: [C: 04-1] "It seems like an event emitter pattern would be better than traversing the whole tree looking for nodes that have the method." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) (owner: 10Divec) [15:05:24] 10VisualEditor, 10VisualEditor-ContentEditable, 13Patch-For-Review: Disabling a ve.ce.DocumentNode leaves descendant ActiveNodes enabled - https://phabricator.wikimedia.org/T161944#3147909 (10Esanders) ...and table cells. [15:15:33] (03CR) 10Divec: "Hmmm, ok. What's the best way to handle nested ContentEditables, e.g. DocumentNode>ActiveNode>TableCellNode>ActiveNode? Should all levels " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) (owner: 10Divec) [15:15:55] 10VisualEditor: Add an option to force page reload when enabling or disabling visual editor - https://phabricator.wikimedia.org/T161791#3150955 (10Rudloff) [17:10:23] (03CR) 10Legoktm: [C: 032] Use tabs to indent in json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345938 (owner: 10Umherirrender) [17:10:42] 10VisualEditor, 10MediaWiki-Page-editing, 06Community-Liaisons (Apr-Jun 2017): CLs to communicate the Save/Publish change - https://phabricator.wikimedia.org/T134580#3151536 (10Whatamidoing-WMF) [17:13:38] 10VisualEditor, 10MediaWiki-Page-editing, 06Community-Liaisons (Apr-Jun 2017): CLs to communicate the Save/Publish change - https://phabricator.wikimedia.org/T134580#3151539 (10Whatamidoing-WMF) Current status: We need to think about how this interacts with FlaggedRevisions at dewiki. Although your changes... [17:23:30] (03Merged) 10jenkins-bot: Use tabs to indent in json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345938 (owner: 10Umherirrender) [17:29:19] (03CR) 10jenkins-bot: Use tabs to indent in json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345938 (owner: 10Umherirrender) [18:03:08] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Preview covers the whole page, including the sidebar - https://phabricator.wikimedia.org/T162074#3151638 (10Whatamidoing-WMF) [18:04:05] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Preview covers the whole page, including the sidebar - https://phabricator.wikimedia.org/T162074#3151659 (10Whatamidoing-WMF) This differs from {155732}, which wants to see the wiktext editing box, rather than the sidebar. [18:39:47] 10Cite, 10VisualEditor, 10Wikimedia-Site-requests, 13Patch-For-Review, 15User-Ryasmeen: Convert reference lists over to `responsive` on hewiki - https://phabricator.wikimedia.org/T161804#3151748 (10DatGuy) 05Open>03Resolved [18:41:10] 10VisualEditor, 10OOjs-UI, 13Patch-For-Review: Allow people to put a MenuToolGroup in a ButtonGroupWidget - https://phabricator.wikimedia.org/T160791#3111032 (10DLynch) Patch just generally improves the experience in the mediawiki theme with buttons that aren't direct children of the toolbar but are in a but... [18:41:56] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Community-Liaisons: Support wikis in converting reference lists over to `responsive` - https://phabricator.wikimedia.org/T159895#3151749 (10DatGuy) [19:26:28] 10VisualEditor, 10VisualEditor-EditingTools, 06Editing-Department: Impossible to style an inline text fragment as pre formatted - https://phabricator.wikimedia.org/T161982#3148983 (10Esanders) Those dropdowns originally had headings (and still do in core). I could say who removed them from MW, or why: {F7171... [19:30:12] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: VE loads even if deactivated when switched from NWE - https://phabricator.wikimedia.org/T161925#3147413 (10Esanders) I'm not sure you should be able to use NWE but not VE. We should probably just make VE a dependency of NWE, but not sure if BetaFeatu... [19:47:17] 10Citoid, 10VisualEditor: Visual Editor adds erroneous text "PMC" to citation template pmc= parameter - https://phabricator.wikimedia.org/T157152#3152097 (10Boghog) Other Wikis handle the identifier without the redundant prefix without error. Deleting the pmc parameter from the documentation is a non sequitur.... [19:58:55] 10Citoid, 10VisualEditor: Visual Editor adds erroneous text "PMC" to citation template pmc= parameter - https://phabricator.wikimedia.org/T157152#3152126 (10Mvolz) The line I was referring to was in the citoid 'maps' value in the td, not to delete the PMC parameter. Sorry, that was a little ambiguous. If you... [20:01:05] 10VisualEditor, 10OOjs-UI (OOjs-UI-0.20.3), 13Patch-For-Review: Allow people to put a MenuToolGroup in a ButtonGroupWidget - https://phabricator.wikimedia.org/T160791#3152135 (10Volker_E) [20:43:41] 10VisualEditor, 10OOjs-UI (OOjs-UI-0.20.3), 13Patch-For-Review: Allow people to put a MenuToolGroup in a ButtonGroupWidget - https://phabricator.wikimedia.org/T160791#3111032 (10Esanders) I think a major issue here is that the dropdown is a different colour to the primary 'save' button: {F7173488} I would ex... [20:58:42] (03PS1) 10Esanders: MWExtension describeChanges: Actually return value of parent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/346200 (https://phabricator.wikimedia.org/T161357) [21:09:59] (03PS1) 10Esanders: Remove DiffElement DOM element when destroying [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/346201 (https://phabricator.wikimedia.org/T161877) [21:19:13] 10VisualEditor: Buttons don't fit on the context menus in some languages - https://phabricator.wikimedia.org/T161808#3143975 (10Esanders) Can we file this upstream with the Council for German Orthography? [21:36:14] 10VisualEditor: Visual Editor no longer converts a URL to be a link when you hit space or enter - https://phabricator.wikimedia.org/T162095#3152361 (10ksmith) [23:52:13] 10VisualEditor: Visual Editor no longer converts a URL to be a link when you hit space or enter - https://phabricator.wikimedia.org/T162095#3152361 (10matmarex) For me, pasted URLs are immediately linkified when I press Ctrl+V (just tested on Chrome and Firefox on Windows 10). Can you provide more details about...