[00:05:45] (03CR) 10Jforrester: [WIP] [PULLTHROUGH] MW changes for the meta-data inlining commit (0319 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336929 (owner: 10Jforrester) [00:06:25] (03PS6) 10Jforrester: [WIP] [PULLTHROUGH] MW changes for the meta-data inlining commit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336929 [00:12:32] (03PS7) 10Catrope: [WIP] [PULLTHROUGH] MW changes for the meta-data inlining commit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336929 (owner: 10Jforrester) [00:32:43] (03PS8) 10Catrope: [WIP] [PULLTHROUGH] MW changes for the meta-data inlining commit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336929 (owner: 10Jforrester) [00:53:24] (03CR) 10jerkins-bot: [V: 04-1] [WIP] [PULLTHROUGH] MW changes for the meta-data inlining commit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336929 (owner: 10Jforrester) [01:15:29] 10VisualEditor, 10VisualEditor-DataModel: Introduce DM events for "a node of this type was inserted/deleted/modified"? - https://phabricator.wikimedia.org/T162761#3173945 (10Catrope) [01:51:43] (03PS4) 10Divec: WIP: ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) [02:14:34] (03PS1) 10Jforrester: tests: Switch to use mocha for reporting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347799 [02:14:36] (03PS1) 10Jforrester: tests: Enforce dm unit test coverage at 20% per file and 80% globally [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347800 [02:16:28] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-DataModel: ve.dm.TransactionProcessor: Restructure DM tree branches using existing nodes, instead of rebuilding them afresh - https://phabricator.wikimedia.org/T162762#3173964 (10dchan) [02:18:21] 10VisualEditor, 10VisualEditor-DataModel: Introduce DM events for "a node of this type was inserted/deleted/modified"? - https://phabricator.wikimedia.org/T162761#3173977 (10dchan) Interesting question. On the tree side of things, I've been considering the shortcomings of detecting ancestry modifications (e.g.... [02:24:03] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-DataModel: ve.dm.TransactionProcessor: Restructure DM tree branches using existing nodes, instead of rebuilding them afresh - https://phabricator.wikimedia.org/T162762#3173979 (10dchan) **Processing transactions - two pointer method for tree modi... [07:07:02] 10TemplateData, 10VisualEditor, 15User-Ryasmeen: TemplateData rejects well-formed format string - https://phabricator.wikimedia.org/T162584#3174194 (10Schnark) 05stalled>03Resolved a:03Schnark I have no idea what changed, but now it does work for me, too, both in OWE and in NWE. So either it was some s... [10:54:43] 10VisualEditor, 13Patch-For-Review, 15User-zeljkofilipin: LanguageScreenshotBot fails with `Error: timeout of 40000ms exceeded. Ensure the done() callback is being called in this test.` - https://phabricator.wikimedia.org/T162454#3174759 (10zeljkofilipin) I am not sure how to continue: - VisualEditor does n... [10:54:54] (03CR) 10Zfilipin: "I am not sure how to continue:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/347595 (https://phabricator.wikimedia.org/T162454) (owner: 10Zfilipin) [14:22:20] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Toolbar "Save page" button is confusing as it merely opens the dialog to save the page - https://phabricator.wikimedia.org/T44138#3175239 (10Tgr) On desktop it's very widely used. See e.g. [[https://msdn.microsoft.com/en-us/library/windows/desktop/bb22679... [14:54:37] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Toolbar "Save page" button is confusing as it merely opens the dialog to save the page - https://phabricator.wikimedia.org/T44138#468164 (10Liuxinyu970226) >>! In T44138#3171667, @Tgr wrote: >>>! In T44138#3171527, @Elitre wrote: >> Do we know if there's... [15:01:59] 10VisualEditor: When you insert a template with the visual editor, search should be easier - https://phabricator.wikimedia.org/T162695#3175317 (10Trizek-WMF) 05declined>03Open >>! In T162695#3172837, @Jdforrester-WMF wrote: > Please file three different tasks for three different bugs. Can you clarify? I onl... [15:32:21] (03PS5) 10Divec: WIP: ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) [15:50:40] 10TemplateData, 10VisualEditor, 10WMSE-Bug-Reporting-and-Translation-2017: Unable to add template and parameters correctly with VisualEditor - https://phabricator.wikimedia.org/T159836#3175403 (10SaraMortsell) Yep, it's working fine. [15:56:12] 10TemplateData, 10VisualEditor, 10WMSE-Bug-Reporting-and-Translation-2017, 15User-Ryasmeen: Unable to add template and parameters correctly with VisualEditor - https://phabricator.wikimedia.org/T159836#3175414 (10Jdforrester-WMF) 05stalled>03Resolved a:03Jdforrester-WMF [15:57:48] (03CR) 10Esanders: WIP: ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) (owner: 10Divec) [16:02:01] (03CR) 10Esanders: "this fixes an exception being thrown when you press back in the auto-cite workflow." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/346971 (owner: 10Esanders) [16:03:03] (03CR) 10Jforrester: [C: 032] Fix credit widget behaviour, don't ever set null [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/346971 (owner: 10Esanders) [16:04:54] (03Merged) 10jenkins-bot: Fix credit widget behaviour, don't ever set null [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/346971 (owner: 10Esanders) [16:06:38] 10VisualEditor: Surfaces should have a single line mode - https://phabricator.wikimedia.org/T162808#3175430 (10Esanders) [16:36:01] (03PS1) 10DLynch: TemplatePlaceholderPage: abort pending template search after adding template [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/347871 (https://phabricator.wikimedia.org/T162707) [16:36:13] (03PS1) 10Jforrester: Upgrade to jQuery v3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347872 [16:37:04] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 13Patch-For-Review: Template dialog's search results remain visible after selecting the template - https://phabricator.wikimedia.org/T162707#3171869 (10DLynch) I couldn't actually reproduce this, in Safari or anywhere else. However, I //think// I know what... [16:46:18] 10VisualEditor, 10VisualEditor-MediaWiki: VE unit tests broken in jQ3, preventing upgrade - https://phabricator.wikimedia.org/T162810#3175546 (10Jdforrester-WMF) [16:50:43] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff - Error when attempting to see changes after switching from wikitext editor to VE - https://phabricator.wikimedia.org/T162811#3175564 (10Elitre) [16:55:25] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff - Error when attempting to see changes after switching from wikitext editor to VE - https://phabricator.wikimedia.org/T162811#3175582 (10Elitre) [16:57:31] 10VisualEditor: Edit intro is not shown when a user switches from wikitext editor to visualeditor - https://phabricator.wikimedia.org/T162812#3175584 (10Elitre) [17:11:23] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff - Changes to existing references are not shown in the main window or the sidebar - https://phabricator.wikimedia.org/T162819#3175724 (10Elitre) [17:11:29] (03CR) 10Divec: WIP: ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) (owner: 10Divec) [17:13:17] 10VisualEditor, 10VisualEditor-VisualDiffs: When two references switch positions their numbering is shown incorrectly in the preview. - https://phabricator.wikimedia.org/T162820#3175733 (10Elitre) [17:27:14] (03CR) 10Krinkle: tests: Switch to use mocha for reporting (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347799 (owner: 10Jforrester) [17:38:23] 10VisualEditor, 10OOjs-UI: OOjs UI: Responsive VE toolbar - https://phabricator.wikimedia.org/T92315#3175858 (10Volker_E) [17:45:13] (03PS2) 10Krinkle: Replace deprecated jQuery.isArray with Array.isArray [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/346512 (owner: 10Fomafix) [17:46:17] (03CR) 10Krinkle: [C: 04-1] Replace deprecated jQuery.isArray with Array.isArray (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/346512 (owner: 10Fomafix) [17:49:13] (03CR) 10Bartosz Dziewoński: [C: 032] TemplatePlaceholderPage: abort pending template search after adding template [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/347871 (https://phabricator.wikimedia.org/T162707) (owner: 10DLynch) [17:53:55] (03PS2) 10Jforrester: tests: Switch to use mocha for reporting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347799 [17:54:06] (03CR) 10Jforrester: tests: Switch to use mocha for reporting (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347799 (owner: 10Jforrester) [17:58:25] (03CR) 10Krinkle: [C: 032] tests: Switch to use mocha for reporting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347799 (owner: 10Jforrester) [18:00:26] (03Merged) 10jenkins-bot: TemplatePlaceholderPage: abort pending template search after adding template [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/347871 (https://phabricator.wikimedia.org/T162707) (owner: 10DLynch) [18:03:01] (03Merged) 10jenkins-bot: tests: Switch to use mocha for reporting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347799 (owner: 10Jforrester) [18:20:30] (03CR) 10jenkins-bot: TemplatePlaceholderPage: abort pending template search after adding template [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/347871 (https://phabricator.wikimedia.org/T162707) (owner: 10DLynch) [18:20:56] (03CR) 10jenkins-bot: tests: Switch to use mocha for reporting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347799 (owner: 10Jforrester) [19:14:57] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 13Patch-For-Review, 15User-Ryasmeen: Template dialog's search results remain visible after selecting the template - https://phabricator.wikimedia.org/T162707#3176196 (10Jdforrester-WMF) 05Open... [19:23:23] (03PS9) 10Jforrester: [WIP] [PULLTHROUGH] MW changes for the meta-data inlining commit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336929 [19:25:43] (03PS1) 10Esanders: Introduce single-line mode for surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347901 [19:28:22] (03CR) 10jerkins-bot: [V: 04-1] Introduce single-line mode for surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347901 (owner: 10Esanders) [19:31:19] (03CR) 10jerkins-bot: [V: 04-1] [WIP] [PULLTHROUGH] MW changes for the meta-data inlining commit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336929 (owner: 10Jforrester) [19:32:01] (03PS12) 10Tchanders: WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) [19:37:58] (03PS10) 10Jforrester: [WIP] [PULLTHROUGH] MW changes for the meta-data inlining commit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336929 [19:40:09] (03CR) 10jerkins-bot: [V: 04-1] WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [19:40:13] (03PS2) 10Jforrester: tests: Enforce dm unit test coverage at 20% per file and 80% globally [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347800 [19:44:17] (03CR) 10Jforrester: [C: 04-1] Introduce single-line mode for surfaces (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347901 (owner: 10Esanders) [19:45:43] (03CR) 10jerkins-bot: [V: 04-1] [WIP] [PULLTHROUGH] MW changes for the meta-data inlining commit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336929 (owner: 10Jforrester) [19:47:24] (03CR) 10Jforrester: [C: 04-1] "Let's do this when we're doing it for MW." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347872 (owner: 10Jforrester) [19:50:44] (03CR) 10Jforrester: [C: 032] Tweak document padding [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347576 (owner: 10Esanders) [19:52:45] MatmaRex: Can I steal a +2 on https://gerrit.wikimedia.org/r/#/c/347783/ and https://gerrit.wikimedia.org/r/#/c/347784/ ? [19:53:09] (03Merged) 10jenkins-bot: Tweak document padding [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347576 (owner: 10Esanders) [19:56:19] (03CR) 10jenkins-bot: Tweak document padding [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347576 (owner: 10Esanders) [19:56:25] yeah [19:57:18] (03CR) 10Bartosz Dziewoński: [C: 032] Update OOjs UI to v0.21.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347784 (owner: 10Jforrester) [19:57:20] (03CR) 10Bartosz Dziewoński: [C: 032] Follow-up 16231a81: Fix typo in update-oojs-ui.sh [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347783 (owner: 10Jforrester) [19:59:48] (03Merged) 10jenkins-bot: Follow-up 16231a81: Fix typo in update-oojs-ui.sh [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347783 (owner: 10Jforrester) [20:00:44] (03Merged) 10jenkins-bot: Update OOjs UI to v0.21.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347784 (owner: 10Jforrester) [20:03:03] (03CR) 10jenkins-bot: Follow-up 16231a81: Fix typo in update-oojs-ui.sh [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347783 (owner: 10Jforrester) [20:06:27] (03CR) 10jenkins-bot: Update OOjs UI to v0.21.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347784 (owner: 10Jforrester) [20:08:42] MatmaRex: Thanks! [20:10:04] (03PS2) 10Jforrester: Introduce single-line mode for surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347901 (https://phabricator.wikimedia.org/T162808) (owner: 10Esanders) [20:10:13] (03CR) 10Jforrester: [C: 04-1] Introduce single-line mode for surfaces (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347901 (https://phabricator.wikimedia.org/T162808) (owner: 10Esanders) [20:10:40] (03CR) 10Jforrester: [C: 04-1] "Needs unit tests." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347901 (https://phabricator.wikimedia.org/T162808) (owner: 10Esanders) [20:13:14] (03CR) 10jerkins-bot: [V: 04-1] Introduce single-line mode for surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347901 (https://phabricator.wikimedia.org/T162808) (owner: 10Esanders) [20:20:30] 10VisualEditor: .ve-ce-documentNode adds padding to content, expecting margin to be removed somewhere else - https://phabricator.wikimedia.org/T162493#3176365 (10matmarex) That patch looks like useful cleanup, but doesn't resolve this issue? The workaround in Timeless seems to still be necessary to avoid extra p... [20:29:25] 10VisualEditor, 10OOjs-UI: The padding for table cell menu items got narrower, making it looked crammed - https://phabricator.wikimedia.org/T162830#3176379 (10Ryasmeen) [20:50:20] 10VisualEditor: .ve-ce-documentNode adds padding to content, expecting margin to be removed somewhere else - https://phabricator.wikimedia.org/T162493#3176461 (10matmarex) a:05Esanders>03matmarex [21:00:57] (03CR) 10Esanders: [C: 031] "Seems ok" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347800 (owner: 10Jforrester) [21:05:00] (03PS1) 10Bartosz Dziewoński: Remove builtin padding from .ve-ce-documentNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347977 (https://phabricator.wikimedia.org/T162493) [21:07:13] MatmaRex: https://phabricator.wikimedia.org/T162810 might be interesting to you if you can reproduce (I can't, but CI can) – jQuery3 apparent incompatibility from VE. [21:09:16] James_F: it frankly looks terribly boring, but i can look into it. :) [21:09:37] MatmaRex: Ha. OK, I thought you found async stuff fun. Sorry! [21:15:09] 10VisualEditor, 13Patch-For-Review: .ve-ce-documentNode adds padding to content, expecting margin to be removed somewhere else - https://phabricator.wikimedia.org/T162493#3176570 (10Esanders) >>! In T162493#3171604, @Isarra wrote: > A textarea is a visually distinct element, separate from the rest of the conte... [21:28:21] 10VisualEditor, 10VisualEditor-MediaWiki, 10Timeless: Clicking in the gutter/margin area when editing with VE loses the text cursor (focus) from the editing surface - https://phabricator.wikimedia.org/T162838#3176589 (10matmarex) [21:48:03] 10VisualEditor, 10VisualEditor-Tables, 10OOjs-UI: The padding for table cell menu items got narrower, making it looked crammed - https://phabricator.wikimedia.org/T162830#3176379 (10Jdforrester-WMF) p:05Triage>03High The `.ve-ui-tableLineContextItem-actionButton .oo-ui-buttonElement-button` selector in v... [21:48:23] 10VisualEditor, 10VisualEditor-Tables, 10OOjs-UI: [Regression pre-wmf.21] The padding for table cell menu items got narrower, making it looked crammed, due to OOUI 0.21.0 release - https://phabricator.wikimedia.org/T162830#3176659 (10Jdforrester-WMF) [21:49:52] RoanKattouw: https://phabricator.wikimedia.org/T162762 [22:21:15] 10VisualEditor, 10OOjs-UI (OOjs-UI-0.21.0), 15User-Ryasmeen: ClippableElement horizontal clipping is totally broken - https://phabricator.wikimedia.org/T158341#3176761 (10matmarex) (https://gerrit.wikimedia.org/r/#/c/347658/ might have fixed this) [22:23:28] 10VisualEditor, 10OOjs-UI (OOjs-UI-0.21.0), 15User-Ryasmeen: ClippableElement horizontal clipping is totally broken - https://phabricator.wikimedia.org/T158341#3176765 (10matmarex) [22:56:40] (03PS3) 10Esanders: Introduce single-line mode for surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347901 (https://phabricator.wikimedia.org/T162808) [23:01:02] (03CR) 10Jforrester: Introduce single-line mode for surfaces (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347901 (https://phabricator.wikimedia.org/T162808) (owner: 10Esanders) [23:14:25] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Community-Liaisons, 10Wikimedia-Site-requests: Support wikis in converting reference lists over to `responsive` - https://phabricator.wikimedia.org/T159895#3176975 (10Jdforrester-WMF) [23:14:27] 10Cite, 10VisualEditor, 10Wikimedia-Site-requests, 13Patch-For-Review, 15User-Ryasmeen: Convert reference lists over to `responsive` on bgwiki - https://phabricator.wikimedia.org/T162145#3176973 (10Jdforrester-WMF) 05Open>03Resolved This is now done (though it will take up to a few weeks to go live f... [23:14:37] 10Cite, 10VisualEditor, 10Wikimedia-Site-requests, 13Patch-For-Review, 15User-Ryasmeen: Convert reference lists over to `responsive` on ca.wiki - https://phabricator.wikimedia.org/T161307#3176977 (10Jdforrester-WMF) 05Open>03Resolved This is now done (though it will take up to a few weeks to go live... [23:14:38] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Community-Liaisons, 10Wikimedia-Site-requests: Support wikis in converting reference lists over to `responsive` - https://phabricator.wikimedia.org/T159895#3082574 (10Jdforrester-WMF) [23:20:28] 10VisualEditor, 06Community-Liaisons, 07User-notice: Support WMF communities in run-up to switching EditPage over to OOUI - https://phabricator.wikimedia.org/T162849#3177020 (10Jdforrester-WMF) [23:22:41] (03CR) 10Esanders: [C: 04-1] "I still think it's fine for document to have default padding. As I said on the ticket - you could equally say we should do the same thing " (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347977 (https://phabricator.wikimedia.org/T162493) (owner: 10Bartosz Dziewoński) [23:31:09] (03PS1) 10Jforrester: Update VE core submodule to master (e4540d87f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348008 (https://phabricator.wikimedia.org/T162622) [23:32:55] (03CR) 10Bartosz Dziewoński: Remove builtin padding from .ve-ce-documentNode (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347977 (https://phabricator.wikimedia.org/T162493) (owner: 10Bartosz Dziewoński) [23:33:09] (03PS2) 10Bartosz Dziewoński: Remove builtin padding from .ve-ce-documentNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347977 (https://phabricator.wikimedia.org/T162493)