[00:18:00] (03PS1) 10Jforrester: ve.init.Target: Be able to not set default mode, for tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/348019 [00:18:18] (03PS1) 10Jforrester: ve.init.mw.DesktopArticleTarget.init: Don't do this twice, we do it after the promise anyway [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348020 [00:18:20] (03PS1) 10Jforrester: ve.test.utils: Don't try to write user options in test suites [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348021 [00:19:17] 10VisualEditor, 10VisualEditor-EditingTools, 10MediaWiki-Gallery, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), and 4 others: VisualEditor: Opening and closing the gallery inspector without making any change causes a transaction - https://phabricator.wikimedia.org/T62311#3177194 (10Ryasmeen) [00:24:16] 10VisualEditor, 10VisualEditor-VisualDiffs, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), 15User-Ryasmeen, and 3 others: Fix whitespace errors in visual diffs - https://phabricator.wikimedia.org/T158895#3177200 (10Ryasmeen) [00:26:54] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-VisualDiffs, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), and 4 others: Visual diffing: Merge changes across whitespace - https://phabricator.wikimedia.org/T160740#3177203 (10Ryasmeen) [00:29:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Gallery, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), and 5 others: [Regression wmf.17] Cannot open Gallery dialog after making some changes to it and saving the page - https://phabricator.wikimedia.org/T160967#3177207 (10Ryasmeen) [00:31:12] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-VisualDiffs, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), and 4 others: Visual diff crashes if you convert an existing paragraph to a blockquote; the otherNode is a VeDmTextNode which... - https://phabricator.wikimedia.org/T161262#3177221 [00:32:36] (03CR) 10Krinkle: [C: 031] "LGTM. Not tested." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348020 (owner: 10Jforrester) [00:33:33] 10VisualEditor, 10VisualEditor-VisualDiffs, 05MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), 15User-Ryasmeen, and 2 others: Visual diffs get duplicated if you go back to editing from the "Review your changes" dialog and then return to that dialog ... - https://phabricator.wikimedia.org/T161877#3177225 [00:41:16] (03PS2) 10Jforrester: ve.test.utils: Don't try to write user options in test suites [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348021 [00:41:18] (03PS1) 10Jforrester: ext.visualEditor.mwcore: Depend on mediawiki.notify for the warning [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348024 [00:41:34] (03PS3) 10Krinkle: ve.test.utils: Don't try to write user options in test suites [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348021 (https://phabricator.wikimedia.org/T162810) (owner: 10Jforrester) [00:42:51] (03PS4) 10Krinkle: ve.test.utils: Don't try to write user options in test suites [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348021 (https://phabricator.wikimedia.org/T162810) (owner: 10Jforrester) [00:46:23] (03PS2) 10Krinkle: ext.visualEditor.mwcore: Depend on mediawiki.notify for the warning [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348024 (owner: 10Jforrester) [00:53:52] (03CR) 10Krinkle: [C: 032] ve.test.utils: Don't try to write user options in test suites [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348021 (https://phabricator.wikimedia.org/T162810) (owner: 10Jforrester) [00:55:14] (03CR) 10Krinkle: [C: 032] ext.visualEditor.mwcore: Depend on mediawiki.notify for the warning [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348024 (owner: 10Jforrester) [01:03:38] (03Merged) 10jenkins-bot: ve.test.utils: Don't try to write user options in test suites [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348021 (https://phabricator.wikimedia.org/T162810) (owner: 10Jforrester) [01:04:55] (03Merged) 10jenkins-bot: ext.visualEditor.mwcore: Depend on mediawiki.notify for the warning [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348024 (owner: 10Jforrester) [01:10:04] (03CR) 10jenkins-bot: ve.test.utils: Don't try to write user options in test suites [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348021 (https://phabricator.wikimedia.org/T162810) (owner: 10Jforrester) [01:15:32] (03CR) 10jenkins-bot: ext.visualEditor.mwcore: Depend on mediawiki.notify for the warning [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348024 (owner: 10Jforrester) [01:26:41] (03PS1) 10Jforrester: tests: Fiddle with templatedata cache insertion to avoid failed XHRs [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/348031 [01:28:51] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: VE unit tests broken in jQ3, preventing upgrade - https://phabricator.wikimedia.org/T162810#3177268 (10Jdforrester-WMF) a:03Jdforrester-WMF [01:33:19] 10VisualEditor, 10VisualEditor-MediaWiki, 07Performance, 07Regression: mw.Api#saveOption called twice with different visualeditor-editor values on startup - https://phabricator.wikimedia.org/T156316#3177270 (10Jdforrester-WMF) a:03Jdforrester-WMF [01:33:21] (03PS2) 10Jforrester: DesktopArticleTarget.init: Don't call setEditorPreference twice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348020 (https://phabricator.wikimedia.org/T156316) [01:34:11] (03Abandoned) 10Jforrester: ve.init.Target: Be able to not set default mode, for tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/348019 (owner: 10Jforrester) [02:06:19] (03PS11) 10Catrope: [WIP] [PULLTHROUGH] MW changes for the meta-data inlining commit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336929 (owner: 10Jforrester) [02:12:52] (03CR) 10jerkins-bot: [V: 04-1] [WIP] [PULLTHROUGH] MW changes for the meta-data inlining commit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336929 (owner: 10Jforrester) [03:02:01] (03CR) 10Krinkle: [C: 032] "Two points:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348020 (https://phabricator.wikimedia.org/T156316) (owner: 10Jforrester) [03:02:23] (03PS3) 10Krinkle: DesktopArticleTarget.init: Don't call setEditorPreference twice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348020 (https://phabricator.wikimedia.org/T156316) (owner: 10Jforrester) [03:03:14] (03CR) 10Krinkle: [C: 032] Update VE core submodule to master (e4540d87f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348008 (https://phabricator.wikimedia.org/T162622) (owner: 10Jforrester) [03:04:12] (03PS2) 10Krinkle: tests: Fiddle with templatedata cache insertion to avoid failed XHRs [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/348031 (https://phabricator.wikimedia.org/T124742) (owner: 10Jforrester) [03:05:05] (03CR) 10Krinkle: [C: 032] tests: Fiddle with templatedata cache insertion to avoid failed XHRs [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/348031 (https://phabricator.wikimedia.org/T124742) (owner: 10Jforrester) [03:05:39] (03CR) 10Krinkle: [C: 032] "This ensures the tests continue to work with jQuery 3 in which the no-op promise from addPart() will be asynchronous always, which sets of" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/348031 (https://phabricator.wikimedia.org/T124742) (owner: 10Jforrester) [03:12:58] (03Merged) 10jenkins-bot: Update VE core submodule to master (e4540d87f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348008 (https://phabricator.wikimedia.org/T162622) (owner: 10Jforrester) [03:14:27] (03Merged) 10jenkins-bot: tests: Fiddle with templatedata cache insertion to avoid failed XHRs [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/348031 (https://phabricator.wikimedia.org/T124742) (owner: 10Jforrester) [03:17:08] (03CR) 10jenkins-bot: Update VE core submodule to master (e4540d87f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348008 (https://phabricator.wikimedia.org/T162622) (owner: 10Jforrester) [03:26:47] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 13Patch-For-Review, 15User-Ryasmeen: VE unit tests broken in jQ3, preventing upgrade - https://phabricator.wikimedia.org/T162810#3177328 (10Krinkle) 05Open>03Resolved [03:59:14] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 15User-Ryasmeen: VE unit tests broken in jQ3, preventing upgrade - https://phabricator.wikimedia.org/T162810#3177338 (10Jdforrester-WMF) [03:59:58] 10VisualEditor, 10VisualEditor-VisualDiffs, 13Patch-For-Review, 15User-Ryasmeen: [Regression pre-wmf.20] Error "Cannot read property 'getBoundingClientRect' of undefined" while trying to open visual diff after switch - https://phabricator.wikimedia.org/T162622#3177339 (10Jdforrester-WMF) 05Open>03Resolv... [04:00:01] 10VisualEditor, 10VisualEditor-VisualDiffs, 15User-Ryasmeen: [Regression pre-wmf.20] Error "Cannot read property 'getBoundingClientRect' of undefined" while trying to open visual diff after switch - https://phabricator.wikimedia.org/T162622#3177344 (10Jdforrester-WMF) [04:03:09] Krinkle: Did you mean for https://gerrit.wikimedia.org/r/#/c/348020/ to merge? :-) [04:36:39] (03PS2) 10Jforrester: Upgrade to jQuery v3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347872 [04:36:57] (03CR) 10Jforrester: "jQ3 is now available by default in MW, though not on WMF servers yet." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347872 (owner: 10Jforrester) [04:38:07] (03PS4) 10Jforrester: DesktopArticleTarget.init: Don't call setEditorPreference twice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348020 (https://phabricator.wikimedia.org/T156316) [04:38:17] (03CR) 10Jforrester: [C: 032] "Per Timo." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348020 (https://phabricator.wikimedia.org/T156316) (owner: 10Jforrester) [04:48:56] (03Merged) 10jenkins-bot: DesktopArticleTarget.init: Don't call setEditorPreference twice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348020 (https://phabricator.wikimedia.org/T156316) (owner: 10Jforrester) [04:54:46] (03CR) 10jenkins-bot: DesktopArticleTarget.init: Don't call setEditorPreference twice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348020 (https://phabricator.wikimedia.org/T156316) (owner: 10Jforrester) [06:19:55] 10VisualEditor, 06Discovery, 10RelatedArticles, 10UI-Standardization, and 3 others: Align the style for lists of pages - https://phabricator.wikimedia.org/T153417#3177469 (10Volker_E) >>! In T153417#3170622, @Pginer-WMF wrote: > Another aspect worth discussing is how to style the "matching part of the titl... [07:54:49] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Toolbar "Save page" button is confusing as it merely opens the dialog to save the page - https://phabricator.wikimedia.org/T44138#468164 (10Volker_E) @Liuxinyu970226 That should be possible with CSS or HTML/CSS without big issues if requested and agreed u... [08:45:38] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow: Switch to current mode is confusing in the editor mode selector - https://phabricator.wikimedia.org/T162864#3177639 (10Pginer-WMF) [09:19:59] (03PS1) 10Fomafix: Fix deprecation warning since jQuery 3 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/348050 [09:51:31] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow: Switch to current mode is confusing in the editor mode selector - https://phabricator.wikimedia.org/T162864#3177782 (10Dvorapa) @Jdforrester-WMF said in reaction to my question about this topic in task T116417... [10:24:30] (03CR) 10Esanders: "Are you sure? ve.dm.MWImageNode inherits from GCN and from MWBlockImageNode, which mixes in MWImageNode, I can access ve.dm.MWBlockImageNo" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) (owner: 10Divec) [10:26:34] (03CR) 10Esanders: "Ah - yes. In those cases I just document that it is required to explicitly mix in all the parents of your mixin." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) (owner: 10Divec) [10:33:38] (03PS1) 10Esanders: Tag mixin inheritance hacks with bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348059 (https://phabricator.wikimedia.org/T92540) [10:40:47] (03CR) 10jerkins-bot: [V: 04-1] Tag mixin inheritance hacks with bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348059 (https://phabricator.wikimedia.org/T92540) (owner: 10Esanders) [10:41:30] (03PS6) 10Divec: ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) [10:55:53] (03PS7) 10Divec: ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) [11:02:53] 10Citoid, 10VisualEditor, 10MediaWiki-Vagrant, 10RESTBase, 06Services: Citoid restbase config broken on vagrant - https://phabricator.wikimedia.org/T162468#3177900 (10Mvolz) 05Open>03Invalid [11:12:56] 10Citoid, 10VisualEditor, 10MediaWiki-Vagrant, 10RESTBase, 06Services: Citoid restbase config broken on vagrant - https://phabricator.wikimedia.org/T162468#3177928 (10Mvolz) @Pchelolo can you tell me your virtualbox and vagrant version? I updated mine to the latest version, destroyed and recreated the ma... [11:31:08] (03PS8) 10Esanders: ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) (owner: 10Divec) [11:31:15] (03CR) 10jerkins-bot: [V: 04-1] ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) (owner: 10Divec) [11:35:42] (03PS2) 10Esanders: Tag mixin inheritance hacks with bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348059 (https://phabricator.wikimedia.org/T92540) [11:37:13] 10VisualEditor: "Often used" not shown in VisualEditor (kowiki) - https://phabricator.wikimedia.org/T159529#3177950 (10Ykhwong) This issue was brought up over 2 months ago in Korean Wikipedia, and we are still waiting for the issue to be resolved in the near future. Please understand that the "encapsulate" actio... [11:42:09] (03CR) 10jerkins-bot: [V: 04-1] Tag mixin inheritance hacks with bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348059 (https://phabricator.wikimedia.org/T92540) (owner: 10Esanders) [11:42:59] (03CR) 10Esanders: [C: 031] "For the code I haven't written" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) (owner: 10Divec) [11:44:55] (03PS9) 10Esanders: ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) (owner: 10Divec) [11:45:32] (03CR) 10Esanders: [C: 031] ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) (owner: 10Divec) [11:47:00] (03PS10) 10Divec: ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) [11:50:14] (03PS11) 10Divec: ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) [11:51:41] (03PS12) 10Divec: ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) [11:56:14] (03CR) 10Divec: [C: 032] ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) (owner: 10Divec) [11:58:29] (03Merged) 10jenkins-bot: ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) (owner: 10Divec) [12:00:40] (03CR) 10jenkins-bot: ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/345955 (https://phabricator.wikimedia.org/T161944) (owner: 10Divec) [12:40:39] 10Citoid, 10VisualEditor, 10MediaWiki-Vagrant, 10RESTBase, 06Services: Citoid restbase config broken on vagrant - https://phabricator.wikimedia.org/T162468#3178051 (10Mvolz) Hmm, When I ssh into the vagrant machine and try to manually install, I'm getting npm errors: vagrant ssh sudo service restbase s... [13:43:13] 10Citoid, 10VisualEditor: Unable to make citation from http://www.apidologie.org/articles/apido/abs/2004/04/M4014/M4014.html - https://phabricator.wikimedia.org/T162886#3178206 (10Mvolz) [13:44:26] 10Citoid, 10VisualEditor: Unable to make citation from http://www.apidologie.org/articles/apido/abs/2004/04/M4014/M4014.html - https://phabricator.wikimedia.org/T162886#3178220 (10Mvolz) 05Open>03Invalid [13:45:38] 10Citoid, 10VisualEditor: Timed out when requesting http://www.apidologie.org/articles/apido/abs/2004/04/M4014/M4014.html - https://phabricator.wikimedia.org/T162886#3178206 (10Mvolz) 05Invalid>03Open p:05Triage>03Normal [13:51:00] 10VisualEditor, 10MediaWiki-General-or-Unknown, 07Technical-Debt: Update extensions not to use deprecated EditPageBeforeEditChecks hook - https://phabricator.wikimedia.org/T161809#3178238 (10matmarex) [13:51:48] 10VisualEditor, 10MediaWiki-General-or-Unknown, 07Technical-Debt: Update extensions not to use deprecated EditPageBeforeEditChecks hook - https://phabricator.wikimedia.org/T161809#3143993 (10matmarex) [14:04:53] 10VisualEditor, 10MediaWiki-extensions-General-or-Unknown, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 07Technical-Debt: Update extensions not to use deprecated EditPageBeforeEditChecks hook - https://phabricator.wikimedia.org/T161809#3178273 (10Reedy) [14:41:05] 10Citoid, 10VisualEditor, 10MediaWiki-Vagrant, 10RESTBase, 06Services: Citoid restbase config broken on vagrant - https://phabricator.wikimedia.org/T162468#3178418 (10Pchelolo) @Mvolz Hm.. Vagrant 1.9.3 VBox 5.1.12 Host machine - macOS Sierra One critical difference might be that I have `vagrant setti... [14:58:27] 10Citoid, 10VisualEditor, 10MediaWiki-Vagrant, 10RESTBase, 06Services: Citoid restbase config broken on vagrant - https://phabricator.wikimedia.org/T162468#3164304 (10mobrovac) @Mvolz try manually deleted the node modules and re-installing them (`rm -rf node_modules && npm install`) [15:27:38] 10Citoid, 10VisualEditor: Strings of digits currently only search for PMIDs; Add multiple results and include OCLC and PMC in the search - https://phabricator.wikimedia.org/T115248#1719043 (10mobrovac) [15:37:24] (03Abandoned) 10Jforrester: WIP: Pullthrough of diffing code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318930 (owner: 10Jforrester) [15:45:53] 10VisualEditor, 10MediaWiki-extensions-FlaggedRevs, 05MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), 07Technical-Debt, 15User-Ryasmeen: Update FlaggedRevs not to use deprecated EditPageBeforeEditChecks hook - https://phabricator.wikimedia.org/T161810#3178836 (10Reedy) [15:48:38] 10Citoid, 10VisualEditor: Strings of digits currently only search for PMIDs; Add multiple results and include OCLC and PMC in the search - https://phabricator.wikimedia.org/T115248#3178857 (10Mvolz) This is live now: Try 14656 as an example. I think the dialog seems a bit crowded? [16:17:12] 10VisualEditor, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 13Patch-For-Review, 15User-Ryasmeen: Update Wikibase not to use deprecated EditPageBeforeEditChecks hook - https://phabricator.wikimedia.org/T161815#3179116 (10Jdforrester-WMF) [16:17:14] 10VisualEditor, 10MediaWiki-extensions-Scribunto, 05MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), 07Technical-Debt, 15User-Ryasmeen: Update Scribunto not to use deprecated EditPageBeforeEditChecks hook - https://phabricator.wikimedia.org/T161813#3179117 (10Jdforrester-WMF) [16:17:17] 10VisualEditor, 10MediaWiki-extensions-LiquidThreads, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 13Patch-For-Review, and 2 others: Update LiquidThreads not to use deprecated EditPageBeforeEditChecks hook - https://phabricator.wikimedia.org/T161811#3179118 (10Jdforrester-WMF) [16:17:18] 10VisualEditor, 10MediaWiki-extensions-FlaggedRevs, 05MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), 07Technical-Debt, 15User-Ryasmeen: Update FlaggedRevs not to use deprecated EditPageBeforeEditChecks hook - https://phabricator.wikimedia.org/T161810#3179119 (10Jdforrester-WMF) [16:17:20] 10VisualEditor, 10MediaWiki-extensions-General-or-Unknown, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 07Technical-Debt: Update extensions not to use deprecated EditPageBeforeEditChecks hook - https://phabricator.wikimedia.org/T161809#3179120 (10Jdforrester-WMF) [16:18:59] 10VisualEditor, 10MediaWiki-extensions-FlaggedRevs, 05MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), 07Technical-Debt, 15User-Ryasmeen: Update FlaggedRevs not to use deprecated EditPageBeforeEditChecks hook - https://phabricator.wikimedia.org/T161810#3144015 (10Jdforrester-WMF) [16:22:52] 10VisualEditor, 10MediaWiki-extensions-General-or-Unknown, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 07Technical-Debt: Update extensions not to use deprecated EditPageBeforeEditChecks hook - https://phabricator.wikimedia.org/T161809#3179185 (10Jdforrester-WMF) p:05Normal>03Lowest The only ch... [16:26:23] 10VisualEditor, 06Community-Liaisons, 07User-notice: Support WMF communities in run-up to switching EditPage over to OOUI - https://phabricator.wikimedia.org/T162849#3179212 (10Jdforrester-WMF) [16:28:14] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Cursor behavior is strange on blank lines - https://phabricator.wikimedia.org/T162916#3179233 (10Whatamidoing-WMF) [16:59:51] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: WikitextEditor messes up translation markers and shows error: "Translation unit markers in unexpected position." - https://phabricator.wikimedia.org/T162186#3179383 (10jeblad) No cle. User error. [17:00:04] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: WikitextEditor messes up translation markers and shows error: "Translation unit markers in unexpected position." - https://phabricator.wikimedia.org/T162186#3179384 (10jeblad) 05Open>03Invalid [17:17:21] James_F: do we have a jq3 patch for VE core? [17:18:06] Found it [17:26:07] 10VisualEditor, 15User-Ryasmeen: Insertion of nowiki tags at the nowiki project - https://phabricator.wikimedia.org/T150140#3179512 (10jeblad) 05stalled>03Resolved [17:47:45] edsanders: Merge it? It's good to go… [17:53:37] 10Citoid, 10VisualEditor: Strings of digits currently only search for PMIDs; Add multiple results and include OCLC and PMC in the search - https://phabricator.wikimedia.org/T115248#3179615 (10Jdforrester-WMF) A couple of screenshots: | At the top | Scrolled down a bit | | {F7531240} | {F7531241} | Yeah, mayb... [18:00:31] (03PS3) 10Jforrester: doc: Tag mixin inheritance hacks with bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348059 (https://phabricator.wikimedia.org/T92540) (owner: 10Esanders) [18:06:47] 10VisualEditor, 10MediaWiki-extensions-UniversalLanguageSelector: Input method and the situation at nowiki - https://phabricator.wikimedia.org/T135092#3179717 (10jeblad) This si part of a pull request, [[https://github.com/wikimedia/jquery.ime/pull/470 | Update and extend the Norwegian rules #470 ]] [18:07:04] 10VisualEditor, 06Editing-Department, 10MobileFrontend: mobile phone wikitext editor should have edit toolbar - https://phabricator.wikimedia.org/T106267#3179729 (10Jdlrobson) [18:13:33] 10VisualEditor, 06Editing-Department, 10MobileFrontend, 06Reading-Web-Backlog: Mobile Search does not generate create new page link - https://phabricator.wikimedia.org/T145722#3179787 (10Jdlrobson) 05Open>03declined This is by design. You can however override it adding the following css rule: ``` .mw-... [18:31:06] 10VisualEditor, 06Editing-Department, 10MobileFrontend: [Contributions] Allow people to submit coordinates for articles that don't have them - https://phabricator.wikimedia.org/T44786#3179890 (10Jdlrobson) [18:38:49] 10VisualEditor, 06Discovery, 10RelatedArticles, 10UI-Standardization, and 3 others: Align the style for lists of pages - https://phabricator.wikimedia.org/T153417#3179913 (10JGirault) >>! In T153417#3170622, @Pginer-WMF wrote: > Another aspect worth discussing is how to style the "matching part of the titl... [18:49:26] (03CR) 10Esanders: [C: 032] Upgrade to jQuery v3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347872 (owner: 10Jforrester) [18:57:31] (03CR) 10Jforrester: [C: 032] doc: Tag mixin inheritance hacks with bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348059 (https://phabricator.wikimedia.org/T92540) (owner: 10Esanders) [19:05:39] (03Merged) 10jenkins-bot: doc: Tag mixin inheritance hacks with bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348059 (https://phabricator.wikimedia.org/T92540) (owner: 10Esanders) [19:08:07] 10VisualEditor, 06Editing-Department, 10MobileFrontend, 06Reading-Web-Backlog: Mobile Search does not generate create new page link - https://phabricator.wikimedia.org/T145722#3180368 (10Mooeypoo) >>! In T145722#3179787, @Jdlrobson wrote: > This is by design. Just out of curiosity - what was the reason fo... [19:12:17] 10VisualEditor: [Regression pre-wmf.21] VE crashes while opening the Page Options menu, error in the console:Uncaught TypeError: Cannot read property 'getAttribute' of null - https://phabricator.wikimedia.org/T162939#3180448 (10Ryasmeen) [19:21:14] (03CR) 10jenkins-bot: doc: Tag mixin inheritance hacks with bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348059 (https://phabricator.wikimedia.org/T92540) (owner: 10Esanders) [19:33:27] 10Citoid, 10VisualEditor, 10The-Wikipedia-Library: Access to Atekst from Citoid - https://phabricator.wikimedia.org/T128418#3180629 (10jeblad) Link works for me, but note that this is a paysite. As I have got no further reply from them I will set this as stalled. [19:33:42] 10Citoid, 10VisualEditor, 10The-Wikipedia-Library: Access to Atekst from Citoid - https://phabricator.wikimedia.org/T128418#3180634 (10jeblad) 05Open>03stalled p:05Low>03Lowest [19:34:39] 10Citoid, 10VisualEditor, 10The-Wikipedia-Library: Access to Atekst from Citoid - https://phabricator.wikimedia.org/T128418#2073981 (10jeblad) On second thoughts, I set it as declined. Knowing them nothing will probably happen. [19:34:58] 10Citoid, 10VisualEditor, 10The-Wikipedia-Library: Access to Atekst from Citoid - https://phabricator.wikimedia.org/T128418#3180639 (10jeblad) 05stalled>03declined [19:38:24] 10VisualEditor, 06Editing-Department, 10MobileFrontend, 06Reading-Web-Backlog: Mobile Search does not generate create new page link - https://phabricator.wikimedia.org/T145722#3180652 (10Jdlrobson) Of course this can be re-evaluated and undone if desired by the editing team but the main reasons were: 1) T... [19:39:16] 10VisualEditor: The insert menu in VE is awkward - https://phabricator.wikimedia.org/T135099#3180655 (10jeblad) This still has no solution. [20:09:02] (03PS1) 10Krinkle: tests: Use assert.async() instead of QUnit.stop/start [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/348133 [20:09:25] (03PS2) 10Krinkle: tests: Use assert.async() instead of QUnit.stop/start [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/348133 [20:15:28] 10VisualEditor, 06Editing-Department, 10MobileFrontend, 06Reading-Web-Backlog, 07Design: Feature request: Cannot view source of old revisions - https://phabricator.wikimedia.org/T56484#3180845 (10Jdlrobson) [20:19:11] 10VisualEditor, 06Editing-Department, 10MobileFrontend, 07Mobile: Feature request: Ability to undo revisions on the mobile version - https://phabricator.wikimedia.org/T87609#3180854 (10Jdlrobson) [20:31:27] 10VisualEditor, 10MediaWiki-Special-pages, 07Mobile: Optimize Special:RecentChanges for mobile - https://phabricator.wikimedia.org/T58640#646507 (10Jdlrobson) [20:32:21] 10VisualEditor, 06Editing-Department, 10MobileFrontend: Adds a proper way to load custom editors - https://phabricator.wikimedia.org/T71177#3180911 (10Jdlrobson) [20:32:37] 10VisualEditor, 06Editing-Department: Emulate mobile view on desktop preview page - https://phabricator.wikimedia.org/T85587#3180912 (10Jdlrobson) [20:33:17] 10VisualEditor, 06Editing-Department, 10MobileFrontend, 07Design: Provide a "signature" button in the mobile wikitext editor - https://phabricator.wikimedia.org/T106266#3180917 (10Jdlrobson) [20:46:21] 10VisualEditor: Import of preformatted templates into an article - https://phabricator.wikimedia.org/T135095#3180964 (10jeblad) In VE open Cité, write ` 10VisualEditor, 15User-Ryasmeen: Import of preformatted templates into an article - https://phabricator.wikimedia.org/T135095#3180966 (10jeblad) 05stalled>03Resolved [20:51:46] (03CR) 10Jforrester: [C: 032] tests: Use assert.async() instead of QUnit.stop/start [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/348133 (owner: 10Krinkle) [20:53:33] (03PS1) 10Krinkle: build: Remove 'grunt watch' [unicodejs] - 10https://gerrit.wikimedia.org/r/348139 [20:53:35] (03PS1) 10Krinkle: build: Switch default form PhantomJS to Chrome [unicodejs] - 10https://gerrit.wikimedia.org/r/348140 [20:53:37] (03PS1) 10Krinkle: build: Enforce minumum code coverage [unicodejs] - 10https://gerrit.wikimedia.org/r/348141 [20:54:50] (03PS2) 10Krinkle: build: Switch default form PhantomJS to Chrome [unicodejs] - 10https://gerrit.wikimedia.org/r/348140 [20:54:52] (03PS2) 10Krinkle: build: Enforce minumum code coverage [unicodejs] - 10https://gerrit.wikimedia.org/r/348141 [20:54:54] (03PS1) 10Krinkle: build: Remove unused jquery.js copy [unicodejs] - 10https://gerrit.wikimedia.org/r/348142 [21:00:11] (03CR) 10Jforrester: [C: 032] build: Remove 'grunt watch' [unicodejs] - 10https://gerrit.wikimedia.org/r/348139 (owner: 10Krinkle) [21:00:14] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)): VE unit tests broken in jQ3, preventing upgrade - https://phabricator.wikimedia.org/T162810#3181026 (10Ryasmeen) [21:00:44] (03CR) 10Jforrester: [C: 032] build: Switch default form PhantomJS to Chrome [unicodejs] - 10https://gerrit.wikimedia.org/r/348140 (owner: 10Krinkle) [21:01:12] (03CR) 10Jforrester: [C: 032] "Ha." [unicodejs] - 10https://gerrit.wikimedia.org/r/348142 (owner: 10Krinkle) [21:01:20] (03CR) 10Jforrester: [C: 032] build: Enforce minumum code coverage [unicodejs] - 10https://gerrit.wikimedia.org/r/348141 (owner: 10Krinkle) [21:01:31] (03Merged) 10jenkins-bot: tests: Use assert.async() instead of QUnit.stop/start [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/348133 (owner: 10Krinkle) [21:02:15] (03Merged) 10jenkins-bot: build: Remove 'grunt watch' [unicodejs] - 10https://gerrit.wikimedia.org/r/348139 (owner: 10Krinkle) [21:02:50] (03Merged) 10jenkins-bot: build: Switch default form PhantomJS to Chrome [unicodejs] - 10https://gerrit.wikimedia.org/r/348140 (owner: 10Krinkle) [21:04:18] (03Merged) 10jenkins-bot: build: Enforce minumum code coverage [unicodejs] - 10https://gerrit.wikimedia.org/r/348141 (owner: 10Krinkle) [21:05:34] (03Merged) 10jenkins-bot: build: Remove unused jquery.js copy [unicodejs] - 10https://gerrit.wikimedia.org/r/348142 (owner: 10Krinkle) [21:10:16] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Interface, and 2 others: content-holding
should only contain the page text - https://phabricator.wikimedia.org/T37247#3181097 (10Anomie) I've become interested in this thanks to TemplateStyles. Currently, TemplateStyles scopes all style... [21:14:37] (03CR) 10jenkins-bot: tests: Use assert.async() instead of QUnit.stop/start [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/348133 (owner: 10Krinkle) [21:16:07] (03CR) 10jenkins-bot: build: Remove 'grunt watch' [unicodejs] - 10https://gerrit.wikimedia.org/r/348139 (owner: 10Krinkle) [21:17:48] (03CR) 10jenkins-bot: build: Switch default form PhantomJS to Chrome [unicodejs] - 10https://gerrit.wikimedia.org/r/348140 (owner: 10Krinkle) [21:19:05] (03CR) 10jenkins-bot: build: Enforce minumum code coverage [unicodejs] - 10https://gerrit.wikimedia.org/r/348141 (owner: 10Krinkle) [21:20:18] (03CR) 10jenkins-bot: build: Remove unused jquery.js copy [unicodejs] - 10https://gerrit.wikimedia.org/r/348142 (owner: 10Krinkle) [21:22:52] James_F: not merging: https://gerrit.wikimedia.org/r/#/c/347872/ ? [21:25:18] edsanders: Looks like Jenkins forgot about it. Kicking now. [21:25:25] Ooh. [21:25:29] It's got a dependency. [21:25:46] edsanders: Merge https://gerrit.wikimedia.org/r/#/c/347800/ if you're OK with it. [21:26:17] edsanders: Also unit tests for https://gerrit.wikimedia.org/r/#/c/347901/ enforcing state, please. [21:26:28] And CR on https://gerrit.wikimedia.org/r/#/c/347977/ [21:39:21] (03PS1) 10Jforrester: Follow-up 57a06a6e: .getAttribute might be 'guaranteed', but not from null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348151 (https://phabricator.wikimedia.org/T162939) [21:39:56] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: [Regression pre-wmf.21] VE crashes while opening the Page Options menu, error in the console:Uncaught TypeError: Cannot read property 'getAttribute' of null - https://phabricator.wikimedia.org/T162939#3181304 (10Jdforrester-WMF) p:05Triage>03Hi... [21:47:26] (03CR) 10Mooeypoo: [C: 032] Follow-up 57a06a6e: .getAttribute might be 'guaranteed', but not from null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348151 (https://phabricator.wikimedia.org/T162939) (owner: 10Jforrester) [21:58:06] (03Merged) 10jenkins-bot: Follow-up 57a06a6e: .getAttribute might be 'guaranteed', but not from null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348151 (https://phabricator.wikimedia.org/T162939) (owner: 10Jforrester) [22:02:07] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 15User-Ryasmeen: [Regression pre-wmf.21] VE crashes while opening the Page Options menu, error in the console:Uncaught TypeError: Cannot read property 'getA... - https://phabricator.wikimedia.org/T162939#3181430 [22:13:55] 10VisualEditor, 06Editing-Analysis: Measure wikitext lint issues in articles created by similar populations in wikitext vs. in VisualEditor - https://phabricator.wikimedia.org/T162958#3181461 (10Jdforrester-WMF) [22:29:23] (03CR) 10jenkins-bot: Follow-up 57a06a6e: .getAttribute might be 'guaranteed', but not from null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348151 (https://phabricator.wikimedia.org/T162939) (owner: 10Jforrester) [22:55:04] 10VisualEditor, 10VisualEditor-MediaWiki: Provide a way in a pending VE save dialog to escape back to the editor e.g. to rescue content for later if the Internet connection is down - https://phabricator.wikimedia.org/T132570#3181665 (10jeblad) This still happen. [23:55:51] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 15User-Ryasmeen, 07Verified: [Regression pre-wmf.21] VE crashes while opening the Page Options menu, error in the console:Uncaught TypeError: Cannot read ... - https://phabricator.wikimedia.org/T162939#3181966