[00:13:29] (03CR) 10jenkins-bot: Update OOjs UI to v0.21.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/348882 (owner: 10Jforrester) [00:17:53] RoanKattouw: Quick +2 on 347800? [00:18:28] (03CR) 10Catrope: [C: 032] tests: Enforce dm unit test coverage at 20% per file and 80% globally [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347800 (owner: 10Jforrester) [00:22:42] (03Merged) 10jenkins-bot: tests: Enforce dm unit test coverage at 20% per file and 80% globally [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347800 (owner: 10Jforrester) [00:29:52] (03CR) 10jenkins-bot: tests: Enforce dm unit test coverage at 20% per file and 80% globally [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347800 (owner: 10Jforrester) [01:12:17] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Parser, 10Parsoid, 07Regression: Table of contents corrupted on read after VE save - https://phabricator.wikimedia.org/T163291#3192565 (10Krinkle) [01:14:54] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Parser, 10Parsoid, 07Regression: Table of contents corrupted on read after VE save - https://phabricator.wikimedia.org/T163291#3192578 (10Krinkle) Two separate bugs: * The PHP parser does not deal well with `__TOC__` appearing inside a wikitext list... [01:16:40] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Parser, 07Regression: Table of contents corrupted on read after VE save - https://phabricator.wikimedia.org/T163291#3192579 (10Krinkle) [01:16:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Parser: Table of contents corrupted on read after VE save - https://phabricator.wikimedia.org/T163291#3192565 (10Krinkle) [01:46:18] 10VisualEditor, 10Parsoid: Parsoid should use the "mw" interwiki prefix instead of the "mediawikiwiki" one - https://phabricator.wikimedia.org/T145337#2626999 (10Krinkle) Done in [revision 16613884](https://meta.wikimedia.org/w/index.php?title=Interwiki_map&type=revision&diff=16613884&oldid=16607217). Pending... [01:51:52] 10VisualEditor, 10VisualEditor-MediaWiki: [Regression pre-wmf.21] Categories popup menu is not connected with Category bubble - https://phabricator.wikimedia.org/T163269#3192660 (10Jdforrester-WMF) p:05Triage>03High [03:34:49] 10VisualEditor, 10Parsoid, 13Patch-For-Review: Parsoid should use the "mw" interwiki prefix instead of the "mediawikiwiki" one - https://phabricator.wikimedia.org/T145337#3192842 (10MZMcBride) >>! In T145337#3192652, @Krinkle wrote: > Done in [revision 16613884](https://meta.wikimedia.org/w/index.php?title=I... [05:13:21] 10VisualEditor, 10WikiEditor, 06Community-Liaisons, 06Editing-Department, and 7 others: Consider to re-label "Save changes"/"Publish changes" to be "Save & Publish" - https://phabricator.wikimedia.org/T163302#3192884 (10eranroz) [05:17:02] 10VisualEditor, 10WikiEditor, 06Community-Liaisons, 06Editing-Department, and 3 others: Consider to re-label "Save changes"/"Publish changes" to be "Save & Publish" - https://phabricator.wikimedia.org/T163302#3192900 (10Legoktm) [05:31:56] 10VisualEditor, 10WikiEditor, 06Community-Liaisons, 06Editing-Department, and 8 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#2329237 (10Hanay) Hanay [06:59:09] 10VisualEditor, 07Regression: VisualEditor sometimes not available - https://phabricator.wikimedia.org/T163307#3193010 (10Nirmos) [07:12:08] 10VisualEditor, 07Regression: VisualEditor sometimes not available - https://phabricator.wikimedia.org/T163307#3193010 (10NH) It can be added the same thing happens when logged out (in a new browser session), so it should not have to do with user specific settings etc. For me this happens in Safari 10.1. User... [11:27:45] 10VisualEditor, 13Patch-For-Review, 15User-zeljkofilipin: LanguageScreenshotBot fails with `Error: timeout of 40000ms exceeded. Ensure the done() callback is being called in this test.` - https://phabricator.wikimedia.org/T162454#3193282 (10Esanders) Yeah it's looking for nstab-main, but we're now in the "he... [11:28:55] (03PS5) 10Esanders: Fix LanguageScreenshotBot by using an existing article [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/347595 (https://phabricator.wikimedia.org/T162454) (owner: 10Zfilipin) [11:50:34] (03PS1) 10Esanders: Screenshots: Hack the toolbar to display "Article" instead of "Help page" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348931 [12:06:52] (03CR) 10Esanders: [C: 031] Fix LanguageScreenshotBot by using an existing article [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/347595 (https://phabricator.wikimedia.org/T162454) (owner: 10Zfilipin) [12:07:53] (03PS2) 10Esanders: Screenshots: Hack the toolbar to display "Article" instead of "Help page" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348931 [12:21:29] (03CR) 10Gvozdet: [C: 031] Screenshots: Hack the toolbar to display "Article" instead of "Help page" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348931 (owner: 10Esanders) [13:03:57] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Design: It would be nice to have Show preview and Review your changes more directly accessible in the New Wikitext Editor - https://phabricator.wikimedia.org/T153306#2876033 (10Pginer-WMF) >>! In T153306#3044327, @Jdforrester-WMF wrote: > As part... [13:57:39] 10VisualEditor, 06Editing-Department, 10MediaWiki-Page-editing, 07Browser-Support-Internet-Explorer, and 4 others: [Regression pre-wmf.21] Impossible to edit pages using IE 6 - https://phabricator.wikimedia.org/T163219#3193592 (10Aklapper) [14:30:50] (03CR) 10Jforrester: [C: 032] Fix LanguageScreenshotBot by using an existing article [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/347595 (https://phabricator.wikimedia.org/T162454) (owner: 10Zfilipin) [14:31:13] (03CR) 10Jforrester: [C: 032] Screenshots: Hack the toolbar to display "Article" instead of "Help page" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348931 (owner: 10Esanders) [14:40:48] (03Merged) 10jenkins-bot: Fix LanguageScreenshotBot by using an existing article [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/347595 (https://phabricator.wikimedia.org/T162454) (owner: 10Zfilipin) [14:40:51] (03Merged) 10jenkins-bot: Screenshots: Hack the toolbar to display "Article" instead of "Help page" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348931 (owner: 10Esanders) [14:45:37] 10VisualEditor, 10Parsoid, 13Patch-For-Review: Parsoid should use the "mw" interwiki prefix instead of the "mediawikiwiki" one - https://phabricator.wikimedia.org/T145337#3193791 (10Jdforrester-WMF) >>! In T145337#3192842, @MZMcBride wrote: > As it is currently, the table entries have every appearance of bei... [14:49:44] (03CR) 10jenkins-bot: Fix LanguageScreenshotBot by using an existing article [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/347595 (https://phabricator.wikimedia.org/T162454) (owner: 10Zfilipin) [14:55:48] (03CR) 10jenkins-bot: Screenshots: Hack the toolbar to display "Article" instead of "Help page" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348931 (owner: 10Esanders) [15:20:47] (03PS1) 10Aaron Schulz: Make onUserLoggedIn() check read-only mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348948 [16:15:05] 10VisualEditor: VisualEditor tabs aren't loading on office.wiki - https://phabricator.wikimedia.org/T162749#3173497 (10Esanders) Is there anything in the console when this happens? [16:44:35] James_F: You deleted a bunch of things in https://gerrit.wikimedia.org/r/#/c/346933/ but didn't seem to get rid of all the references to them. ve.ui.MWTocWidget still references a bunch of that stuff, so things like dragging to rearrange categories throws errors. [16:53:37] ...also, the padding in that panel has gone kind of crazy, but I think that's Volker. [16:53:39] https://usercontent.irccloud-cdn.com/file/8pv37sIr/ [17:16:11] Kemayo: Oh, oops. [17:16:25] Kemayo: MWTocWidget isn't live though? [17:20:02] James_F: Yeah, it only actually causes problems for people with $wgVisualEditorEnableTocWidget=true. [17:20:23] (Sorry, the initial comment sounded a bit more "this is broken for everyone" than I meant.) [17:20:27] Roan suggested just deleting that code. I have the alternative ambition of making it finally work. [17:20:38] But whoops. [17:21:51] Crazy talk. [17:30:14] Kemayo: If you want some serious "fun" you can have a look at https://gerrit.wikimedia.org/r/#/c/336929/ (still WIP, waiting on functionality from David C. and Roan in VE core) which fiddles with MWTocWidget. [17:43:47] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Design: It would be nice to have Show preview and Review your changes more directly accessible in the New Wikitext Editor - https://phabricator.wikimedia.org/T153306#3194692 (10Dvorapa) @Pginer-WMF I don't think this is a good idea to hide previe... [17:53:47] (03CR) 10Jforrester: [C: 032] Make onUserLoggedIn() check read-only mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348948 (owner: 10Aaron Schulz) [17:57:40] (03CR) 10Jforrester: [C: 032] git.wikimedia.org -> phab [unicodejs] - 10https://gerrit.wikimedia.org/r/348660 (https://phabricator.wikimedia.org/T139089) (owner: 10TerraCodes) [18:03:06] (03Merged) 10jenkins-bot: Make onUserLoggedIn() check read-only mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348948 (owner: 10Aaron Schulz) [18:03:54] (03Merged) 10jenkins-bot: git.wikimedia.org -> phab [unicodejs] - 10https://gerrit.wikimedia.org/r/348660 (https://phabricator.wikimedia.org/T139089) (owner: 10TerraCodes) [18:05:29] (03CR) 10jenkins-bot: git.wikimedia.org -> phab [unicodejs] - 10https://gerrit.wikimedia.org/r/348660 (https://phabricator.wikimedia.org/T139089) (owner: 10TerraCodes) [18:07:22] (03CR) 10jenkins-bot: Make onUserLoggedIn() check read-only mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348948 (owner: 10Aaron Schulz) [18:19:37] (03PS1) 10Jforrester: [WIP] Update to Unicode 9.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/348975 [18:20:56] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Update to Unicode 9.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/348975 (owner: 10Jforrester) [18:32:34] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Automatic edit used as section heading in §ion=new edit - https://phabricator.wikimedia.org/T163370#3194964 (10Whatamidoing-WMF) [18:38:20] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 07Performance, and 2 others: mw.Api#saveOption called twice with different visualeditor-editor values on startup - https://phabricator.wikimedia.org/T156316#3195031 (10Jdforrester-WMF) 05Open>03Resolved... [18:44:13] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow: Show a different label for the current mode in the editor mode selector (not "switch to…", as it's confusing) - https://phabricator.wikimedia.org/T162864#3195079 (10Jdforrester-WMF) [18:57:59] (03PS1) 10Jforrester: Show a different label for the current mode in the editor mode selector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348984 (https://phabricator.wikimedia.org/T162864) [18:58:41] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 07Browser-Support-Google-Chrome, and 2 others: [Regression pre-wmf16] Entire line of text gets highlighted, when applying link or language to a text in Heading or Page Title format - https://phabricator.wikimedia.org/T87297#3195122... [18:59:18] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOjs-UI: Please make the "More" and "Fewer" setting in the Insert menu be sticky - https://phabricator.wikimedia.org/T85638#3195125 (10Jdforrester-WMF) a:05Jdforrester-WMF>03None [18:59:28] 10VisualEditor, 10Wikimedia-Site-requests, 07Epic, 05Goal, 07User-notice: Enable VisualEditor by default for all users of all Wikimedia wikis - https://phabricator.wikimedia.org/T52000#3195127 (10Jdforrester-WMF) p:05Low>03Lowest [18:59:34] 10VisualEditor, 10Wikimedia-Site-requests, 13Patch-For-Review: Re-enable VisualEditor by default for all users of the English Wikipedia - https://phabricator.wikimedia.org/T90662#3195129 (10Jdforrester-WMF) p:05Low>03Lowest [18:59:52] 10VisualEditor, 10Wikimedia-Site-requests, 07Chinese-Sites, 07User-notice: Enable VisualEditor by default for all users of all "phase 7" Wikipedias - https://phabricator.wikimedia.org/T93388#3195132 (10Jdforrester-WMF) p:05Low>03Lowest [19:00:05] 10VisualEditor, 10Wikimedia-Site-requests, 07Spanish-Sites: Re-enable VisualEditor by default for all users of the Spanish Wikipedia - https://phabricator.wikimedia.org/T119974#3195136 (10Jdforrester-WMF) p:05Normal>03Lowest [19:00:11] 10VisualEditor, 10Wikimedia-Site-requests, 07User-notice: Enable VisualEditor by default for all users of all Wikipedias - https://phabricator.wikimedia.org/T51999#3195138 (10Jdforrester-WMF) p:05Normal>03Lowest [19:00:18] 10VisualEditor, 10Wikimedia-Site-requests, 07Category, 07Notice, and 2 others: Re-enable VisualEditor by default for all logged-out users of the English Wikipedia - https://phabricator.wikimedia.org/T90663#3195140 (10Jdforrester-WMF) p:05Normal>03Lowest [19:00:35] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - https://phabricator.wikimedia.org/T56947#3195148 (10Jdforrester-WMF) p:05Normal>03Low [19:00:55] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - https://phabricator.wikimedia.org/T56947#641557 (10Jdforrester-WMF) a:05Jdforrester-WMF>03No... [19:01:55] 10VisualEditor, 10VisualEditor-MediaWiki: Enable VisualEditor by default for all users of the Russian Wikivoyage - https://phabricator.wikimedia.org/T136995#3195153 (10Jdforrester-WMF) p:05Normal>03Lowest [19:02:54] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.27-release (WMF-deploy-2016-03-08_(1.27.0-wmf.16)), 15User-Ryasmeen: Don't give the user the option to discard changes when changing editor - https://phabricator.wikimedia.org/T128585#3195155 (10Jdforrester-WMF) 05Open>03Resolved [19:03:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: Make VisualEditor primary (first editor to load) on the English Wikipedia for people for whom it's enabled - https://phabricator.wikimedia.org/T92895#3195158 (10Jdforrester-WMF) p:05Low>03Lowest [19:07:28] 10VisualEditor, 10WikiEditor, 06Community-Liaisons, 06Editing-Department, and 8 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#3195169 (10Dbrant) [20:33:15] (03CR) 10Bartosz Dziewoński: "So? I really think this will make skin authors' lives easier." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/347977 (https://phabricator.wikimedia.org/T162493) (owner: 10Bartosz Dziewoński) [20:48:33] (03PS1) 10Bartosz Dziewoński: ve.ui.MWCategoryPopupWidget: Fix popup positioning [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349019 (https://phabricator.wikimedia.org/T163269) [20:49:18] (03CR) 10Bartosz Dziewoński: "Note that the whole interface seems a bit broken right now… but it's less broken with this patch." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349019 (https://phabricator.wikimedia.org/T163269) (owner: 10Bartosz Dziewoński) [20:57:02] 10VisualEditor, 10ContentTranslation, 10ContentTranslation-CXserver, 10MediaWiki-Language-converter, and 3 others: Glossaries, pronunciations, and dictionaries - https://phabricator.wikimedia.org/T149660#3195651 (10Sarise298) a:05cscott>03Sarise298 [21:02:47] 10VisualEditor, 10ContentTranslation, 10ContentTranslation-CXserver, 10MediaWiki-Language-converter, and 3 others: Glossaries, pronunciations, and dictionaries - https://phabricator.wikimedia.org/T149660#3195673 (10ssastry) a:05Sarise298>03cscott [21:16:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/349072 (owner: 10L10n-bot) [21:27:15] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349080 (owner: 10L10n-bot) [21:35:17] (03CR) 10Krinkle: [C: 032] Fix logic for redirecting unsupported browsers to old editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348781 (https://phabricator.wikimedia.org/T163226) (owner: 10Bartosz Dziewoński) [21:45:45] (03Merged) 10jenkins-bot: Fix logic for redirecting unsupported browsers to old editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348781 (https://phabricator.wikimedia.org/T163226) (owner: 10Bartosz Dziewoński) [21:46:59] 10VisualEditor, 06Editing-Department, 10MobileFrontend, 07Epic, and 4 others: [EPIC] Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#3195810 (10Jdforrester-WMF) [21:53:04] 10VisualEditor, 06Editing-Department, 10MobileFrontend, 07Epic, and 4 others: [EPIC] Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#3195844 (10Jdforrester-WMF) Looks good; merged your patches (except for th... [22:02:24] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Page-editing, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 15User-Ryasmeen: Impossible to preview page (or changes) in old wikitext editor using IE 6 when VisualEditor is enabled - https://phabricator.wikimedia.org/T163226#3195888 (10Jdfo... [22:05:14] (03CR) 10Jforrester: [C: 031] ve.ui.MWCategoryPopupWidget: Fix popup positioning [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349019 (https://phabricator.wikimedia.org/T163269) (owner: 10Bartosz Dziewoński) [22:05:20] 10VisualEditor, 06Editing-Department, 10MobileFrontend, 07Epic, and 5 others: [EPIC] Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#3195908 (10Volker_E) Two nitpicks for the future: - Could we remove the... [22:05:57] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: [Regression pre-wmf.21] Categories popup menu is not connected with Category bubble - https://phabricator.wikimedia.org/T163269#3195924 (10Jdforrester-WMF) a:03matmarex [22:07:10] (03CR) 10jenkins-bot: Fix logic for redirecting unsupported browsers to old editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/348781 (https://phabricator.wikimedia.org/T163226) (owner: 10Bartosz Dziewoński) [22:42:51] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References: [Regression pre-wmf.21] Cite dialog is not opening, "Uncaught TypeError: Cannot read property 'keyedNodes' of undefined" in the console - https://phabricator.wikimedia.org/T163267#3196022 (10Jdforrester-WMF) p:05Triage>03High [23:05:00] 10VisualEditor, 06Editing-Department, 10MobileFrontend, 07Epic, and 4 others: [EPIC] Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#3196068 (10Jdlrobson) Isn't editpage-copywarn a MediaWiki message provided...