[09:26:57] (03PS1) 10Esanders: Check diffElement still exists after setTimeout [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349892 [12:23:24] 10VisualEditor, 07Browser-Support-Android-Google-Chrome, 07Browser-Support-Apple-Safari, 07Browser-Support-Firefox, 07Browser-Support-Internet-Explorer: Warn users that they use an obsolete browser to edit - https://phabricator.wikimedia.org/T163539#3200951 (10Esanders) Do you have examples of this. The... [12:25:44] 10VisualEditor, 07Browser-Support-Android-Google-Chrome, 07Browser-Support-Apple-Safari, 07Browser-Support-Firefox, 07Browser-Support-Internet-Explorer: Warn users that they use an obsolete browser to edit - https://phabricator.wikimedia.org/T163539#3205716 (10Esanders) We could show a notice on the edit... [12:31:26] 10VisualEditor, 10OOjs-UI, 10SyntaxHighlight: List of languages in VE's dialog behaves stangly - https://phabricator.wikimedia.org/T163536#3205728 (10Esanders) [14:49:13] (03CR) 10Jforrester: "This is for T162642 right?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349892 (owner: 10Esanders) [15:45:56] James_F: I added some screenshots to https://www.mediawiki.org/wiki/VisualEditor/Diffs [15:46:16] that show more than just plain text diffs (which aren't much different from wikitext) [15:48:55] edsanders: Nice. [15:50:27] if you have time to drop into the slides... [16:23:33] (03CR) 10DLynch: [C: 032] Refactor newFromAnnotation & addAnnotationsToData [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/349428 (https://phabricator.wikimedia.org/T162278) (owner: 10Esanders) [16:27:24] (03Merged) 10jenkins-bot: Refactor newFromAnnotation & addAnnotationsToData [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/349428 (https://phabricator.wikimedia.org/T162278) (owner: 10Esanders) [16:30:49] (03CR) 10jenkins-bot: Refactor newFromAnnotation & addAnnotationsToData [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/349428 (https://phabricator.wikimedia.org/T162278) (owner: 10Esanders) [16:50:18] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Automatic edit used as section heading in §ion=new edit - https://phabricator.wikimedia.org/T163370#3194964 (10DLynch) I can't actually persuade this to happen. Can anyone else, who can then provide better reproduction steps? That said, `EditPag... [17:58:01] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/349994 (owner: 10L10n-bot) [18:01:57] 10VisualEditor: Edit notices icon (ve-ui-mwNoticesPopupTool-items) is empty for new articles - https://phabricator.wikimedia.org/T156432#3207293 (10Jdforrester-WMF) Agreed. T153118 is different. [18:02:07] 10VisualEditor: Edit notices icon (ve-ui-mwNoticesPopupTool-items) is empty for new articles - https://phabricator.wikimedia.org/T156432#3207296 (10Jdforrester-WMF) [18:02:09] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 15User-Ryasmeen: Edit intro is not shown when a user switches from wikitext editor to visualeditor - https://phabricator.wikimedia.org/T162812#3207299 (10Jdforrester-WMF) [18:03:39] (03PS2) 10Jforrester: MWSaveDialog: Check diffElement still exists after setTimeout [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349892 (https://phabricator.wikimedia.org/T162642) (owner: 10Esanders) [18:03:44] (03CR) 10Jforrester: [C: 032] MWSaveDialog: Check diffElement still exists after setTimeout [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349892 (https://phabricator.wikimedia.org/T162642) (owner: 10Esanders) [18:04:08] 10VisualEditor, 10VisualEditor-VisualDiffs, 13Patch-For-Review, 15User-Ryasmeen: [Regression pre-wmf.20] Error "Uncaught TypeError: Cannot read property 'positionDescriptions' of null" after saving page from visual diff - https://phabricator.wikimedia.org/T162642#3207308 (10Jdforrester-WMF) 05Open>03Res... [18:04:45] 10VisualEditor, 10OOjs-UI, 10SyntaxHighlight: List of languages in VE's dialog behaves strangely (OO.ui.ComboBoxInputWidget) - https://phabricator.wikimedia.org/T163536#3207312 (10Esanders) I meant it wasn't an extended widget, and therefore an upstream issue. It shouldn't break using docum... [18:05:32] 10VisualEditor, 10OOjs-UI, 10SyntaxHighlight: List of languages in VE's dialog behaves strangely (OO.ui.ComboBoxInputWidget) - https://phabricator.wikimedia.org/T163536#3207313 (10Esanders) I think with that option enabled, we need to scroll back to the top if no exact match is found after... [18:09:34] (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] Remove deprecated TransactionBuilder aliases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/349404 (owner: 10Esanders) [18:12:10] (03Merged) 10jenkins-bot: MWSaveDialog: Check diffElement still exists after setTimeout [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349892 (https://phabricator.wikimedia.org/T162642) (owner: 10Esanders) [18:12:28] (03PS1) 10Jforrester: Update VE core submodule to master (7b494035e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350001 (https://phabricator.wikimedia.org/T162278) [18:14:43] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Remove deprecated TransactionBuilder aliases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/349404 (owner: 10Esanders) [18:16:08] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (7b494035e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350001 (https://phabricator.wikimedia.org/T162278) (owner: 10Jforrester) [18:16:56] Thanks MatmaRex. [18:17:53] (03CR) 10jenkins-bot: [BREAKING CHANGE] Remove deprecated TransactionBuilder aliases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/349404 (owner: 10Esanders) [18:18:28] MatmaRex: Could I beg you to look at https://gerrit.wikimedia.org/r/#/c/349368/ and https://gerrit.wikimedia.org/r/#/c/349369/ ? It's a breaking change in TemplateData's API response that gives more information, plus a fix and utilisation of said changed API in VE (which is why I'm making it). It makes https://gerrit.wikimedia.org/r/#/c/349370/ possible [18:18:28] without being crap. :-) [18:19:08] (03CR) 10jenkins-bot: MWSaveDialog: Check diffElement still exists after setTimeout [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349892 (https://phabricator.wikimedia.org/T162642) (owner: 10Esanders) [18:19:48] James_F: why is it breaking? :( [18:20:30] MatmaRex: It breaks an assumption. Previously the response only contained titles for which there was templatedata, and clients had to work out that meant that either there was no templatedata for the given title, or the title didn't exist. [18:21:07] MatmaRex: Now TD actually actively responds with "this page doesn't exist" or "this page does exist but there's no templatedata stored". [18:21:16] MatmaRex: There's exactly one client of TD, VE. [18:21:27] James_F: can we keep the old behavior as default, and add a parameter to enable the new outputs? otherwise you'd have to email the lists and all that [18:21:42] I'm happy to e-mail the lists. [18:22:48] butbutbut breaking :( [18:23:07] One supported client which I'm fixing. [18:23:21] The alternative is useless code that adds crap to every request. [18:24:05] I mean, you're proposing adding a parameter called something like "beStupidlyUnlikeEveryOtherAPIQuery" with the default of true. :-) [18:24:22] This makes TD's API much more like the response you get from all the others. [18:24:45] James_F: fine, but when Brad gets mad at me, i'll send him off to you. :) [18:24:50] Sure. :-) [18:24:52] i'll test it in a minute. brb [18:27:39] (03Merged) 10jenkins-bot: Update VE core submodule to master (7b494035e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350001 (https://phabricator.wikimedia.org/T162278) (owner: 10Jforrester) [18:28:28] (03PS1) 10Jforrester: Update VE core submodule to master (00f0a0bf8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350003 [18:33:24] (03CR) 10jenkins-bot: Update VE core submodule to master (7b494035e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350001 (https://phabricator.wikimedia.org/T162278) (owner: 10Jforrester) [18:34:38] MatmaRex: Hmm. Actually, it's also used by Parsoid and CX, so… meh, I'll do it. [18:36:42] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Scrolling in the gallery search box causes image thumbnails to change size - https://phabricator.wikimedia.org/T163727#3207399 (10Whatamidoing-WMF) [18:48:40] James_F: hah. okay. ping me when it's ready :) [19:12:28] (03PS3) 10Jforrester: API: Identify missing and no-TemplateData pages in the response [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/349368 [19:12:59] MatmaRex: Done. [19:14:02] (03PS3) 10Jforrester: MWTransclusionModel: Update for change in TemplateData [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349369 [19:15:09] (03CR) 10jerkins-bot: [V: 04-1] API: Identify missing and no-TemplateData pages in the response [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/349368 (owner: 10Jforrester) [19:18:28] Eurgh. [19:22:56] (03PS4) 10Jforrester: API: Identify missing and no-TemplateData pages in the response [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/349368 [19:40:16] (03CR) 10Jforrester: [C: 032] ve.init.mw.ArticleTarget: Only retry once after a 'badtoken' error [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349289 (https://phabricator.wikimedia.org/T163493) (owner: 10Bartosz Dziewoński) [19:40:29] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review, 15User-Ryasmeen: VisualEditor will retry saving a page forever if the API gives it an invalid token - https://phabricator.wikimedia.org/T163493#3207623 (10Jdforrester-WMF) 05Open>03Resolved [19:48:36] (03Merged) 10jenkins-bot: ve.init.mw.ArticleTarget: Only retry once after a 'badtoken' error [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349289 (https://phabricator.wikimedia.org/T163493) (owner: 10Bartosz Dziewoński) [19:51:40] (03PS2) 10Jforrester: ArticleTarget: Load anew if RESTbase has forgotten it was deleted [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349337 (https://phabricator.wikimedia.org/T163502) [19:52:23] (03CR) 10Jforrester: [C: 04-1] "This doesn't work; ArticleTargetLoader doesn't short-circuit locally if it believes it's creating a page, it relies on RESTbase always bei" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349337 (https://phabricator.wikimedia.org/T163502) (owner: 10Jforrester) [19:56:52] (03CR) 10jenkins-bot: ve.init.mw.ArticleTarget: Only retry once after a 'badtoken' error [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349289 (https://phabricator.wikimedia.org/T163493) (owner: 10Bartosz Dziewoński) [20:29:04] 10VisualEditor, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 15User-zeljkofilipin: LanguageScreenshotBot fails with `Error: timeout of 40000ms exceeded. Ensure the done() callback is being called in this test.` - https://phabricator.wikimedia.org/T162454#3207823 (10Jdforrester-WMF) What's the s... [20:30:36] (03PS3) 10Bartosz Dziewoński: MWTemplatePage: Show a different message if the template doesn't exist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349370 (https://phabricator.wikimedia.org/T162694) (owner: 10Jforrester) [20:33:04] (03CR) 10Bartosz Dziewoński: [C: 032] API: Identify missing and no-TemplateData pages in the response [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/349368 (owner: 10Jforrester) [20:33:07] (03CR) 10Bartosz Dziewoński: [C: 032] MWTransclusionModel: Update for change in TemplateData [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349369 (owner: 10Jforrester) [20:33:13] (03CR) 10Bartosz Dziewoński: [C: 032] MWTemplatePage: Show a different message if the template doesn't exist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349370 (https://phabricator.wikimedia.org/T162694) (owner: 10Jforrester) [20:36:25] (03Merged) 10jenkins-bot: API: Identify missing and no-TemplateData pages in the response [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/349368 (owner: 10Jforrester) [20:43:54] (03Merged) 10jenkins-bot: MWTransclusionModel: Update for change in TemplateData [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349369 (owner: 10Jforrester) [20:43:55] (03Merged) 10jenkins-bot: MWTemplatePage: Show a different message if the template doesn't exist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349370 (https://phabricator.wikimedia.org/T162694) (owner: 10Jforrester) [20:44:44] (03CR) 10jenkins-bot: API: Identify missing and no-TemplateData pages in the response [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/349368 (owner: 10Jforrester) [20:51:30] (03CR) 10jenkins-bot: MWTransclusionModel: Update for change in TemplateData [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349369 (owner: 10Jforrester) [20:57:10] (03CR) 10jenkins-bot: MWTemplatePage: Show a different message if the template doesn't exist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/349370 (https://phabricator.wikimedia.org/T162694) (owner: 10Jforrester) [20:59:44] (03PS1) 10Jforrester: Don't deprecate immediately, let Wikimedia extensions/services convert first [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350068 [21:00:02] MatmaRex: On second thoughts, we shouldn't immediately hard-deprecate, I think. [21:00:23] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 15User-Ryasmeen: Warn user when a template does not exist with a different message - https://phabricator.wikimedia.org/T162694#3207919 (10Jdforrester-WMF) 05Open>03Resolved [21:00:50] James_F: hm, okay. [21:00:56] (03CR) 10Bartosz Dziewoński: [C: 032] Don't deprecate immediately, let Wikimedia extensions/services convert first [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350068 (owner: 10Jforrester) [21:01:13] Will revert after the train, I think. [21:04:19] (03Merged) 10jenkins-bot: Don't deprecate immediately, let Wikimedia extensions/services convert first [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350068 (owner: 10Jforrester) [21:04:30] (03CR) 10jenkins-bot: Don't deprecate immediately, let Wikimedia extensions/services convert first [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350068 (owner: 10Jforrester) [21:06:02] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350071 (owner: 10L10n-bot) [21:12:17] (03PS1) 10Jforrester: Revert "Don't deprecate immediately, let Wikimedia extensions/services convert first" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350082 [21:34:44] 10TemplateData, 10VisualEditor, 10Parsoid: On serialising, if a parameter alias is used Parsoid should use its main item's paramOrder - https://phabricator.wikimedia.org/T154718#3208047 (10Jdforrester-WMF) p:05Triage>03Normal [21:34:52] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 13Patch-For-Review: Create dedicated input methods for "number" transclusion parameters - https://phabricator.wikimedia.org/T124850#3208054 (10Volker_E) [22:01:22] 10VisualEditor, 10Parsoid, 10RESTBase, 06Services (done): RESTbase 500s when asking for the latest revision of enwiki's [[Vomeronasal organ]] - https://phabricator.wikimedia.org/T163598#3208146 (10ssastry) [22:02:33] 10VisualEditor, 06Collaboration-Team-Triage, 10ContentTranslation, 10Mobile-Content-Service, and 2 others: Parsoid image output is (intentionally) missing the magnify links found in PHP parser output, leading to differences - https://phabricator.wikimedia.org/T160960#3208159 (10ssastry) p:05Triage>03Nor... [22:11:26] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid, 15User-Urbanecm: Missing data-mw content in wikitext leads to html2wt exceptions - https://phabricator.wikimedia.org/T141226#3208181 (10ssastry)