[01:15:41] (03PS1) 10VolkerE: Update OOjs UI to v0.21.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350350 [01:23:41] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.21.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350350 (owner: 10VolkerE) [01:26:21] (03Merged) 10jenkins-bot: Update OOjs UI to v0.21.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350350 (owner: 10VolkerE) [01:29:41] (03CR) 10jenkins-bot: Update OOjs UI to v0.21.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350350 (owner: 10VolkerE) [01:33:28] (03CR) 10VolkerE: [C: 032] Update VE core submodule to master (00f0a0bf8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350003 (owner: 10Jforrester) [01:38:20] (03CR) 10Jforrester: [C: 04-1] Add paragraphType paramter to newBlankDocument (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350196 (owner: 10Esanders) [01:44:55] (03Merged) 10jenkins-bot: Update VE core submodule to master (00f0a0bf8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350003 (owner: 10Jforrester) [01:51:33] (03CR) 10jenkins-bot: Update VE core submodule to master (00f0a0bf8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350003 (owner: 10Jforrester) [08:16:34] 10VisualEditor, 06Editing-Department, 10MediaWiki-Page-editing, 07Browser-Support-Android-Google-Chrome, and 3 others: Warn users when they edit that they are using an obsolete browser - https://phabricator.wikimedia.org/T163539#3213054 (10Trizek-WMF) >>! In T163539#3211179, @Jdforrester-WMF wrote: > I vag... [10:46:37] (03CR) 10Esanders: Add paragraphType paramter to newBlankDocument (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350196 (owner: 10Esanders) [10:46:40] (03PS2) 10Esanders: Add paragraphType parameter to newBlankDocument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350196 [10:52:38] (03CR) 10Esanders: Rewrite logic for choosing initial editor (037 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350236 (owner: 10Esanders) [10:53:02] (03PS2) 10Esanders: Rewrite logic for choosing initial editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350236 [11:00:42] (03CR) 10jerkins-bot: [V: 04-1] Rewrite logic for choosing initial editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350236 (owner: 10Esanders) [11:01:49] 10VisualEditor, 10MediaWiki-extensions-Linter, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: Make Linter edit helper compatible with VisualEditor - https://phabricator.wikimedia.org/T160102#3213366 (10Esanders... [12:19:25] 10Citoid, 10VisualEditor, 15User-Ryasmeen: OpenLibrary citation has incorrect author information (bug filed upstream) - https://phabricator.wikimedia.org/T95128#3213552 (10Mvolz) 05Resolved>03Open [12:20:08] 10Citoid, 10VisualEditor, 15User-Ryasmeen: OpenLibrary citation has incorrect author information (bug filed upstream) - https://phabricator.wikimedia.org/T95128#1180891 (10Mvolz) RE-opening as we still have yet to pull this upstream change into our local repo and deploy. :) [13:29:02] anyone had this before ? [13:29:03] [Composer\Downloader\TransportException] [13:29:08] The "http://packagist.org/p/oojs/oojs-ui%24df7b085ad3aa881e1c28b50c423f426a37f4eb9d97fd9405469b96cc68c0eb9e.json" file could not be downloaded: Failed to open http://packagist.org/p/oojs/oojs-ui%24df7b085ad3aa881e1c28b50c423f426a37f4eb9d97fd9405469b96cc68c0eb9e.json (Recv failure: Connection reset by peer) [14:13:51] 10VisualEditor, 10OOjs-UI, 10SyntaxHighlight: OO.ui.ComboBoxInputWidget should scroll back to the top if no exact match is found after filtering via filterFromInput: true - https://phabricator.wikimedia.org/T163536#3200812 (10DLynch) There's really two things, here. The filtering only happens after the secon... [14:54:23] weird. [14:55:12] it seems that vagrant's composer never uses https.. even though it's diagnose mode reports that https is just fine. and then it fails on the oojs-ui calls http request for even fewer clear reasons... [15:24:08] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor: [Regression wmf.21] Switching editor throws error "Uncaught TypeError: Cannot read property 'destroy' of null" - https://phabricator.wikimedia.org/T163813#3214261 (10DLynch) a:03DLynch Side effect of c02c529. [15:31:05] (03PS1) 10DLynch: DesktopArticleTarget: only destroy notices tool if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) [15:32:02] (03PS3) 10Bmansurov: Improve API response on formatversion=2 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350101 (https://phabricator.wikimedia.org/T155164) [15:32:08] (03CR) 10jerkins-bot: [V: 04-1] Improve API response on formatversion=2 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350101 (https://phabricator.wikimedia.org/T155164) (owner: 10Bmansurov) [15:37:04] (03CR) 10jerkins-bot: [V: 04-1] DesktopArticleTarget: only destroy notices tool if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) (owner: 10DLynch) [15:38:20] Hm. That's actually a side-effect of the prior merge commit. [15:38:39] `lib/ve/tests/dm/ve.dm.TransactionBuilder.test.js: Invalid JavaScript syntax: Unexpected 'static' on line 2272` [15:40:13] Heh, which is `static = ve.dm.TransactionBuilder.static`. Keywords, woo. [15:47:02] ...also it's not happening locally. [15:47:53] (03CR) 10DLynch: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) (owner: 10DLynch) [15:56:35] (03CR) 10jerkins-bot: [V: 04-1] DesktopArticleTarget: only destroy notices tool if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) (owner: 10DLynch) [15:56:42] Drat. [15:57:02] James_F: Any idea what's up with jsduck there? [15:59:49] Kemayo: probably a bug! [16:00:18] it also chokes if you use non-ASCII characters in a variable or property name. we ran into that at some point. [16:01:40] Mostly, I'm confused that it's not happening locally. I have the same version of jsduck, and everything. [16:02:27] Like, I'm fine with it erroring weirdly, but I'd like it to at least be consistent. [16:02:31] 10VisualEditor: Add ‰ in special characters input - https://phabricator.wikimedia.org/T163894#3214501 (10Trizek-WMF) [16:02:50] (03CR) 10Krinkle: [C: 04-1] Explicit load module 'jquery.tablesorter' instead of use when loaded (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/349174 (owner: 10Fomafix) [16:07:22] (03PS3) 10Krinkle: Replace deprecated jQuery.isArray with Array.isArray [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/346512 (owner: 10Fomafix) [16:10:41] (03CR) 10Krinkle: [C: 032] Replace deprecated jQuery.isArray with Array.isArray [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/346512 (owner: 10Fomafix) [16:12:51] (03Merged) 10jenkins-bot: Replace deprecated jQuery.isArray with Array.isArray [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/346512 (owner: 10Fomafix) [16:19:47] (03CR) 10Anomie: "Looks sane to me. One nitpick." (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350101 (https://phabricator.wikimedia.org/T155164) (owner: 10Bmansurov) [16:20:02] (03PS4) 10Bmansurov: Improve API response on formatversion=2 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350101 (https://phabricator.wikimedia.org/T155164) [16:22:24] (03PS5) 10Bmansurov: Improve API response on formatversion=2 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350101 (https://phabricator.wikimedia.org/T155164) [16:23:22] (03CR) 10Bmansurov: Improve API response on formatversion=2 (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350101 (https://phabricator.wikimedia.org/T155164) (owner: 10Bmansurov) [16:29:47] (03PS1) 10Fomafix: Remove workarounds for IE8 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/350441 (https://phabricator.wikimedia.org/T123219) [16:34:38] (03CR) 10Gergő Tisza: Improve API response on formatversion=2 (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350101 (https://phabricator.wikimedia.org/T155164) (owner: 10Bmansurov) [16:35:50] (03CR) 10Anomie: Improve API response on formatversion=2 (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350101 (https://phabricator.wikimedia.org/T155164) (owner: 10Bmansurov) [16:38:06] (03CR) 10Anomie: Improve API response on formatversion=2 (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350101 (https://phabricator.wikimedia.org/T155164) (owner: 10Bmansurov) [17:00:36] (03CR) 10Krinkle: [C: 032] Remove workarounds for IE8 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/350441 (https://phabricator.wikimedia.org/T123219) (owner: 10Fomafix) [17:02:48] (03Merged) 10jenkins-bot: Remove workarounds for IE8 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/350441 (https://phabricator.wikimedia.org/T123219) (owner: 10Fomafix) [17:10:38] (03CR) 10Esanders: [C: 032] DesktopArticleTarget: only destroy notices tool if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) (owner: 10DLynch) [17:11:26] (03CR) 10Esanders: [C: 04-1] DesktopArticleTarget: only destroy notices tool if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) (owner: 10DLynch) [17:12:41] (03CR) 10Jforrester: [C: 032] Add paragraphType parameter to newBlankDocument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350196 (owner: 10Esanders) [17:13:25] (03CR) 10Esanders: [C: 04-1] DesktopArticleTarget: only destroy notices tool if it exists (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) (owner: 10DLynch) [17:14:01] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350236 (owner: 10Esanders) [17:14:18] (03CR) 10DLynch: DesktopArticleTarget: only destroy notices tool if it exists (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) (owner: 10DLynch) [17:14:31] (03PS2) 10DLynch: DesktopArticleTarget: only destroy notices tool if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) [17:14:40] 10VisualEditor, 06Community-Liaisons: Phases 4, 5 in building the visual editor taskforce - https://phabricator.wikimedia.org/T147174#3214831 (10Elitre) p:05Normal>03Low [17:14:53] (03Merged) 10jenkins-bot: Add paragraphType parameter to newBlankDocument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350196 (owner: 10Esanders) [17:16:03] Kemayo: Hmm. I don't understand either. [17:17:07] I do also think we should be running jsduck when we update the submodule. It's currently skipped (I think) because technically no files are modified. [17:17:29] But jsduck passes locally. [17:17:35] Hence my confusion. [17:17:42] Same version. [17:17:49] Likewise. [17:17:58] It also passed when we wrote this code in VE-core. [17:18:06] Where it definitely /did/ run jsduck. [17:18:17] * James_F suspects a corrupted checkout on one of the CI boxen. [17:18:27] What if we re-bump the submodule pointer? [17:19:26] Probably can't make anything more broken, at least. [17:19:36] That's the spirit. :-) One second. [17:20:44] (03CR) 10jerkins-bot: [V: 04-1] Rewrite logic for choosing initial editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350236 (owner: 10Esanders) [17:21:39] (03CR) 10jenkins-bot: Add paragraphType parameter to newBlankDocument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350196 (owner: 10Esanders) [17:21:49] (03PS1) 10Jforrester: Update VE core submodule to master (5936b9521) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350450 [17:22:03] Kemayo: That ^^^ passes jsduck locally too, so… [17:22:41] (03CR) 10jerkins-bot: [V: 04-1] DesktopArticleTarget: only destroy notices tool if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) (owner: 10DLynch) [17:23:28] Kemayo: that's https://phabricator.wikimedia.org/T155862 , filed the last time we had this problem :) [17:24:22] MatmaRex: The more perplexing issue is "jsduck fails in CI but works locally", of course. :-( [17:24:24] 10VisualEditor, 10Continuous-Integration-Config: VisualEditor-MediaWiki: Don't be "smart" about only running jsduck on JS file changes - https://phabricator.wikimedia.org/T155862#3214905 (10matmarex) [17:32:29] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (5936b9521) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350450 (owner: 10Jforrester) [17:32:49] Kemayo: I'm really sad that bumping the submodule fixed it. [17:32:55] Kemayo: But hey, it worked. [17:33:40] (03PS3) 10Jforrester: Rewrite logic for choosing initial editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350236 (owner: 10Esanders) [17:33:51] (03CR) 10Jforrester: "Rebased onto a fix for the jsduck issue." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350236 (owner: 10Esanders) [17:33:59] (03PS3) 10Jforrester: DesktopArticleTarget: only destroy notices tool if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) (owner: 10DLynch) [17:34:12] (03CR) 10Jforrester: "PS3: Rebased onto a fix for the jsduck issue." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) (owner: 10DLynch) [17:34:13] Strictly, we don't know if it fixed it yet. Since jsduck didn't run there. [17:34:40] Eurgh, point. [17:37:56] There's room to argue about which is worse: it fixing it or it not fixing it. :D [17:40:26] (03CR) 10Esanders: [C: 032] DesktopArticleTarget: only destroy notices tool if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) (owner: 10DLynch) [17:42:53] Yeah… [17:42:59] Well, I've got bad news. [17:43:05] Looks like it didn't fix it. [17:43:13] 350432,3 just failed. [17:43:23] * James_F sighs. [17:43:42] Time to beg some time from Antoine, I guess. :-( [17:44:30] I guess we could just write around Ed's hack. [17:45:01] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, and 4 others: Show a different label for the current mode in the editor mode selector (not "switch to…", as it's confusing) - https://phabricator.wikimedia.org/T162864#3177639 (10Esanders) Ha... [17:46:01] (03PS1) 10Jforrester: TransactionBuilder.test: Don't use `static` as the variable name [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350454 [17:46:06] Kemayo: ^^ [17:46:45] (03CR) 10DLynch: [C: 032] TransactionBuilder.test: Don't use `static` as the variable name [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350454 (owner: 10Jforrester) [17:47:52] (03PS1) 10Esanders: EditModeTool: Use state-describing labels, instead of action-describing labels. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350455 (https://phabricator.wikimedia.org/T162864) [17:48:08] (03CR) 10Esanders: [C: 04-1] EditModeTool: Use state-describing labels, instead of action-describing labels. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350455 (https://phabricator.wikimedia.org/T162864) (owner: 10Esanders) [17:49:14] (03Merged) 10jenkins-bot: Update VE core submodule to master (5936b9521) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350450 (owner: 10Jforrester) [17:49:18] (03CR) 10jerkins-bot: [V: 04-1] DesktopArticleTarget: only destroy notices tool if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) (owner: 10DLynch) [17:50:40] (03Merged) 10jenkins-bot: TransactionBuilder.test: Don't use `static` as the variable name [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350454 (owner: 10Jforrester) [17:51:13] (03PS1) 10Jforrester: Update VE core submodule to master (15d5124ee) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350457 [17:51:44] (03PS4) 10DLynch: DesktopArticleTarget: only destroy notices tool if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) [17:52:14] (In fairness, there was a typo then as well as the jsduck brouhaha.) [17:52:20] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (15d5124ee) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350457 (owner: 10Jforrester) [17:52:21] Ha. :-D [17:52:31] (03CR) 10jerkins-bot: [V: 04-1] Rewrite logic for choosing initial editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350236 (owner: 10Esanders) [17:52:39] (03PS2) 10Esanders: EditModeTool: Use state-describing labels, instead of action-describing labels. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350455 (https://phabricator.wikimedia.org/T162864) [17:55:06] (03CR) 10jenkins-bot: Update VE core submodule to master (5936b9521) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350450 (owner: 10Jforrester) [17:59:09] (03CR) 10jenkins-bot: TransactionBuilder.test: Don't use `static` as the variable name [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350454 (owner: 10Jforrester) [18:02:19] (03Merged) 10jenkins-bot: Update VE core submodule to master (15d5124ee) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350457 (owner: 10Jforrester) [18:03:12] (03CR) 10jerkins-bot: [V: 04-1] DesktopArticleTarget: only destroy notices tool if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) (owner: 10DLynch) [18:03:41] (03PS5) 10Jforrester: DesktopArticleTarget: only destroy notices tool if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) (owner: 10DLynch) [18:03:56] (03CR) 10jerkins-bot: [V: 04-1] EditModeTool: Use state-describing labels, instead of action-describing labels. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350455 (https://phabricator.wikimedia.org/T162864) (owner: 10Esanders) [18:05:03] (03CR) 10Esanders: [C: 032] DesktopArticleTarget: only destroy notices tool if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) (owner: 10DLynch) [18:05:59] (03CR) 10Esanders: TransactionBuilder.test: Don't use `static` as the variable name (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350454 (owner: 10Jforrester) [18:06:55] (03CR) 10Jforrester: TransactionBuilder.test: Don't use `static` as the variable name (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350454 (owner: 10Jforrester) [18:07:49] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, and 4 others: Show a different label for the current mode in the editor mode selector (not "switch to…", as it's confusing) - https://phabricator.wikimedia.org/T162864#3215045 (10Jdforrester-W... [18:08:43] (03CR) 10jenkins-bot: Update VE core submodule to master (15d5124ee) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350457 (owner: 10Jforrester) [18:13:02] (03Merged) 10jenkins-bot: DesktopArticleTarget: only destroy notices tool if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) (owner: 10DLynch) [18:15:12] 10VisualEditor, 06Community-Liaisons, 07User-notice: Support WMF communities in run-up to switching EditPage over to OOUI - https://phabricator.wikimedia.org/T162849#3215051 (10Elitre) a:05Jdforrester-WMF>03Whatamidoing-WMF [18:18:24] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Ryasmeen: [Regression wmf.21] Switching editor throws error "Uncaught TypeError: Cannot read property 'destroy' of null" - https://phabricator.wikimedia.org/T163813#3215053 (10Jdforrester-WMF) 05Open>03Resolved [18:19:32] (03CR) 10jenkins-bot: DesktopArticleTarget: only destroy notices tool if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350432 (https://phabricator.wikimedia.org/T163813) (owner: 10DLynch) [18:25:27] (03PS3) 10Jforrester: EditModeTool: Use state-describing labels, instead of action-describing labels. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350455 (https://phabricator.wikimedia.org/T162864) (owner: 10Esanders) [18:33:40] (03PS4) 10Jforrester: EditModeTool: Use state-describing, not action-describing labels [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350455 (https://phabricator.wikimedia.org/T162864) (owner: 10Esanders) [18:33:52] (03CR) 10Jforrester: [C: 032] EditModeTool: Use state-describing, not action-describing labels [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350455 (https://phabricator.wikimedia.org/T162864) (owner: 10Esanders) [18:42:43] (03Merged) 10jenkins-bot: EditModeTool: Use state-describing, not action-describing labels [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350455 (https://phabricator.wikimedia.org/T162864) (owner: 10Esanders) [18:45:56] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Ryasmeen, 07Verified: [Regression wmf.21] Switching editor throws error "Uncaught TypeError: Cannot read property 'destroy' of null" - https://phabricator.wikimedia.org/T163813#3215179 (10Ryasmeen) [18:46:43] (03CR) 10jenkins-bot: EditModeTool: Use state-describing, not action-describing labels [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350455 (https://phabricator.wikimedia.org/T162864) (owner: 10Esanders) [18:52:07] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, and 5 others: Show a different label for the current mode in the editor mode selector (not "switch to…", as it's confusing) - https://phabricator.wikimedia.org/T162864#3215234 (10Jdforrester-W... [19:08:51] 10VisualEditor, 10VisualEditor-Tables, 15User-Ryasmeen: No cursor appearing inside the table caption - https://phabricator.wikimedia.org/T163828#3215284 (10Ryasmeen) 05Open>03Resolved a:03Ryasmeen Looks like it's fixed now. [19:09:04] 10VisualEditor, 10VisualEditor-Tables, 15User-Ryasmeen: No cursor appearing inside the table caption - https://phabricator.wikimedia.org/T163828#3215288 (10Ryasmeen) a:05Ryasmeen>03None [19:21:43] 10VisualEditor, 10WikiEditor: Add ‰ in special characters input - https://phabricator.wikimedia.org/T163894#3215300 (10Esanders) [19:42:13] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, and 6 others: Show a different label for the current mode in the editor mode selector (not "switch to…", as it's confusing) - https://phabricator.wikimedia.org/T162864#3215358 (10Dvorapa) If... [19:48:29] (03PS1) 10Bartosz Dziewoński: init: Relax checks for required skin elements to avoid false positives [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350471 (https://phabricator.wikimedia.org/T162411) [19:59:17] (03CR) 10Jforrester: init: Relax checks for required skin elements to avoid false positives (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350471 (https://phabricator.wikimedia.org/T162411) (owner: 10Bartosz Dziewoński) [20:00:21] 10VisualEditor, 10WikiEditor, 15User-Ryasmeen: Add ‰ in special characters input - https://phabricator.wikimedia.org/T163894#3215419 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03Esanders [20:00:29] (03CR) 10Krinkle: init: Relax checks for required skin elements to avoid false positives (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350471 (https://phabricator.wikimedia.org/T162411) (owner: 10Bartosz Dziewoński) [20:00:55] (03CR) 10Bartosz Dziewoński: init: Relax checks for required skin elements to avoid false positives (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350471 (https://phabricator.wikimedia.org/T162411) (owner: 10Bartosz Dziewoński) [20:02:59] (03PS4) 10Jforrester: Rewrite logic for choosing initial editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350236 (owner: 10Esanders) [20:03:54] (03CR) 10Jforrester: init: Relax checks for required skin elements to avoid false positives (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350471 (https://phabricator.wikimedia.org/T162411) (owner: 10Bartosz Dziewoński) [20:05:11] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 15User-Ryasmeen, and 2 others: [Regression pre-.21] Categories input in VisualEditor "Page options" dialog has weird internal spacing - https://phabricator.wikimedia.org/T163404#3215438 (10Ryasmeen) [20:05:35] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 15User-Ryasmeen, and 2 others: [Regression pre-wmf.21] Categories popup menu is not connected with Category bubble - https://phabricator.wikimedia.org/T163269#3215441 (10Ryasmeen) [20:06:04] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), and 3 others: [Regression pre-wmf.21] Cite dialog is not opening, "Uncaught TypeError: Cannot read property 'keyedNodes' of undefined" in... - https://phabricator.wikimedia.org/T163267#3215442 [20:08:02] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 15User-Ryasmeen, and 2 others: [Regression pre-wmf.21] VE crashes while opening the Page Options menu, error in the console:Uncaught TypeError: Cannot read ... - https://phabricator.wikimedia.org/T162939#3215443 [20:09:07] 10VisualEditor, 10VisualEditor-Tables, 10OOjs-UI, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), and 3 others: [Regression pre-wmf.21] The padding for table cell menu items got narrower, making it looked crammed, due to OOUI 0.21.0 release - https://phabricator.wikimedia.org/T162830#3215444 (10R... [20:10:37] (03CR) 10Jforrester: [C: 032] Rewrite logic for choosing initial editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350236 (owner: 10Esanders) [20:16:19] 10VisualEditor, 10VisualEditor-VisualDiffs, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 15User-Ryasmeen, and 2 others: [Regression pre-wmf.20] Error "Uncaught TypeError: Cannot read property 'positionDescriptions' of null" after saving page f... - https://phabricator.wikimedia.org/T162642#3215485 [20:17:31] 10VisualEditor, 10VisualEditor-VisualDiffs, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 15User-Ryasmeen, and 2 others: [Regression pre-wmf.20] Error "Cannot read property 'getBoundingClientRect' of undefined" while trying to open visual diff ... - https://phabricator.wikimedia.org/T162622#3215498 [20:18:34] (03Merged) 10jenkins-bot: Rewrite logic for choosing initial editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350236 (owner: 10Esanders) [20:23:05] (03CR) 10jenkins-bot: Rewrite logic for choosing initial editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350236 (owner: 10Esanders) [20:27:15] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 15User-Ryasmeen, and 2 others: Don't apply selflink style to link in the context menu - https://phabricator.wikimedia.org/T162671#3215564 (10Ryasmeen) [20:28:33] 10VisualEditor, 10VisualEditor-VisualDiffs, 05MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), 15User-Ryasmeen, and 3 others: Visual diffs get duplicated if you go back to editing from the "Review your changes" dialog and then return to that dialog ... - https://phabricator.wikimedia.org/T161877#3215569 [20:31:13] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-VisualDiffs, 05MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), and 4 others: Visual diff represents changes since entering VE, so switching from wikitext means diff isn't complete (can be ... - https://phabricator.wikimedia.org/T160741#3215582 [20:37:00] (03PS4) 10Krinkle: [PULLTHROUGH] Follow up change for change in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/261198 (owner: 10Florianschmidtwelzow) [20:37:12] (03CR) 10jerkins-bot: [V: 04-1] [PULLTHROUGH] Follow up change for change in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/261198 (owner: 10Florianschmidtwelzow) [21:10:45] (03CR) 10Esanders: "I guess so" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/339400 (owner: 10Esanders) [21:19:43] 10VisualEditor: [Regression pre-wmf.22] Visual Diff showing raw HTML after switching back from NWE - https://phabricator.wikimedia.org/T163945#3215763 (10Ryasmeen) [21:30:31] (03CR) 10Bmansurov: Improve API response on formatversion=2 (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350101 (https://phabricator.wikimedia.org/T155164) (owner: 10Bmansurov) [21:58:06] (03PS1) 10Bmansurov: Use modified action=templatedata response format [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350489 [21:59:34] (03PS2) 10Bmansurov: Use modified action=templatedata response format [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350489 [22:00:28] I just encountered a weird VE bug where it insists on deleting the first character of a word that comes after a link. Is that a known bug? [22:00:35] (03PS3) 10Bmansurov: Use modified action=templatedata response format [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350489 [22:02:38] (03CR) 10Bmansurov: "Here is the patch to VE: Ifac45165cdf02e9071e00b08f28cef9fe53762bc." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350101 (https://phabricator.wikimedia.org/T155164) (owner: 10Bmansurov) [22:06:01] (03CR) 10jerkins-bot: [V: 04-1] Use modified action=templatedata response format [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350489 (owner: 10Bmansurov) [22:26:54] (03CR) 10Jforrester: "Looks reasonable; thanks!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350489 (owner: 10Bmansurov) [22:32:20] (03PS2) 10Jforrester: Allow uploading of dropped Blobs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/339400 (https://phabricator.wikimedia.org/T39932) (owner: 10Esanders) [22:33:22] (03PS3) 10Jforrester: MWMediaTransferHandler: Allow uploading of dropped Blobs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/339400 (https://phabricator.wikimedia.org/T39932) (owner: 10Esanders) [22:43:12] (03CR) 10Gergő Tisza: "It would probably be better if VE understood both formats for a while. PHP and JS changes are not strictly simultaneous, even if you deplo" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350489 (owner: 10Bmansurov) [23:16:16] (03PS1) 10Jforrester: Hooks#EditPageBeforeEditToolbar: Return false so that other toolbars aren't loaded [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/350498