[00:17:48] MatmaRex: I don't suppose I can talk you into merging https://gerrit.wikimedia.org/r/#/c/343785/ for me? Really want to deprecate for MW1.29 rather than have to delay yet again… :-( [00:29:47] (03CR) 10MaxSem: [C: 032] Hooks#EditPageBeforeEditToolbar: Return false so that other toolbars aren't loaded [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/350498 (owner: 10Jforrester) [00:30:21] MatmaRex: Never mind, MaxSem did it. [00:32:13] (03Merged) 10jenkins-bot: Hooks#EditPageBeforeEditToolbar: Return false so that other toolbars aren't loaded [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/350498 (owner: 10Jforrester) [01:02:20] (03CR) 10Krinkle: [C: 04-1] init: Relax checks for required skin elements to avoid false positives (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350471 (https://phabricator.wikimedia.org/T162411) (owner: 10Bartosz Dziewoński) [01:43:24] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, and 6 others: Show a different label for the current mode in the editor mode selector (not "switch to…", as it's confusing) - https://phabricator.wikimedia.org/T162864#3216521 (10Jdforrester-W... [05:27:26] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Interface, and 2 others: content-holding
should only contain the page text - https://phabricator.wikimedia.org/T37247#386110 (10tstarling) Maybe you could have a ParserOption for it, so that the parser tests can still pass without too m... [11:35:55] 10Citoid, 10VisualEditor: Citoid icinga alert /api (open graph via native scraper) is CRITICAL: Test open graph via native scraper returned the unexpected status 404 (expecting: 200) - https://phabricator.wikimedia.org/T163986#3217190 (10jcrespo) [11:51:25] (03PS2) 10Fomafix: Explicit load module 'jquery.tablesorter' instead of use when loaded [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/349174 [12:08:05] 10Citoid, 10VisualEditor: Citoid icinga alert /api (open graph via native scraper) is CRITICAL: Test open graph via native scraper returned the unexpected status 404 (expecting: 200) - https://phabricator.wikimedia.org/T163986#3217190 (10akosiaris) And now it's fine again [12:23:23] 10VisualEditor: Edit notices not visible in VisualEditor - https://phabricator.wikimedia.org/T161642#3217272 (10Esanders) [12:54:18] 10Citoid, 10VisualEditor: Citoid icinga alert /api (open graph via native scraper) is CRITICAL: Test open graph via native scraper returned the unexpected status 404 (expecting: 200) - https://phabricator.wikimedia.org/T163986#3217355 (10jcrespo) Maybe this should be reconverted on "not check PBS's website upd... [13:02:46] (03CR) 10TheDJ: [C: 032] Explicit load module 'jquery.tablesorter' instead of use when loaded [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/349174 (owner: 10Fomafix) [13:03:53] 10VisualEditor: Visual Diff showing raw HTML after switching back from NWE - https://phabricator.wikimedia.org/T163945#3217380 (10Esanders) [13:04:41] (03PS1) 10Esanders: VisualDiff: Don't describe internalItem changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350550 (https://phabricator.wikimedia.org/T163945) [13:04:43] (03PS1) 10Esanders: VisualDiff: Don't try to render empty node changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350551 [13:04:52] (03Merged) 10jenkins-bot: Explicit load module 'jquery.tablesorter' instead of use when loaded [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/349174 (owner: 10Fomafix) [13:07:01] (03CR) 10jerkins-bot: [V: 04-1] VisualDiff: Don't try to render empty node changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350551 (owner: 10Esanders) [13:07:47] (03CR) 10jerkins-bot: [V: 04-1] VisualDiff: Don't describe internalItem changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350550 (https://phabricator.wikimedia.org/T163945) (owner: 10Esanders) [14:02:57] 10VisualEditor, 10SyntaxHighlight: Syntaxhighlight is missing in VE when you add code from a new language - https://phabricator.wikimedia.org/T145271#3217548 (10TheDJ) [14:03:02] 10VisualEditor, 10VisualEditor-CopyPaste, 10SyntaxHighlight, 07Browser-Support-Apple-Safari, and 3 others: VisualEditor: Pasting a syntaxhighlight block from another VE surface don't load syntaxhighlight's styling - https://phabricator.wikimedia.org/T60388#3217551 (10TheDJ) [14:25:07] 10VisualEditor, 10VisualEditor-VisualDiffs, 13Patch-For-Review: Visual Diff showing raw HTML after switching back from NWE - https://phabricator.wikimedia.org/T163945#3217646 (10Jdforrester-WMF) p:05Triage>03Normal a:03Esanders [15:18:57] (03PS2) 10Jforrester: VisualDiff: Don't describe internalItem changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350550 (https://phabricator.wikimedia.org/T163945) (owner: 10Esanders) [15:18:59] (03PS1) 10Jforrester: tests: Cover LinkAnnotation#getFragment() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350578 [15:19:01] (03PS1) 10Jforrester: tests: Cover tags [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350579 [15:19:03] (03PS1) 10Jforrester: tests: Test rich annotations' describeChange() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350580 [15:20:41] (03CR) 10Jforrester: "PS2: Made pass by dropping `data-diff-id="0"` from the DiffElement unit test – but is this correct?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350550 (https://phabricator.wikimedia.org/T163945) (owner: 10Esanders) [15:21:57] (03CR) 10Anomie: Improve API response on formatversion=2 (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350101 (https://phabricator.wikimedia.org/T155164) (owner: 10Bmansurov) [15:23:34] (03PS2) 10Jforrester: VisualDiff: Don't try to render empty node changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350551 (owner: 10Esanders) [15:25:17] (03CR) 10Jforrester: Improve API response on formatversion=2 (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350101 (https://phabricator.wikimedia.org/T155164) (owner: 10Bmansurov) [15:26:06] (03PS1) 10Esanders: Synchronise VE availability checks in frontend and backend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350582 [15:33:09] (03CR) 10Esanders: "No, I made a typo in the code" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350550 (https://phabricator.wikimedia.org/T163945) (owner: 10Esanders) [15:33:46] (03PS3) 10Esanders: VisualDiff: Don't describe internalItem changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350550 (https://phabricator.wikimedia.org/T163945) [15:33:48] (03PS3) 10Esanders: VisualDiff: Don't try to render empty node changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350551 [15:34:37] (03CR) 10Esanders: [C: 032] tests: Cover tags [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350579 (owner: 10Jforrester) [15:38:41] (03CR) 10Jforrester: [C: 04-1] Synchronise VE availability checks in frontend and backend (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350582 (owner: 10Esanders) [15:40:11] (03CR) 10Esanders: "We should fix our getFragment to behave more like location.hash and mw.Title, i.e. everything after the first '#' (although location.hash " (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350578 (owner: 10Jforrester) [15:40:27] (03CR) 10Esanders: [C: 04-1] "Tests ok, function broken." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350578 (owner: 10Jforrester) [15:40:46] (03CR) 10Jforrester: tests: Cover LinkAnnotation#getFragment() (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350578 (owner: 10Jforrester) [15:42:42] (03CR) 10Esanders: [C: 04-1] tests: Test rich annotations' describeChange() (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350580 (owner: 10Jforrester) [15:44:26] (03PS2) 10Jforrester: tests: Test rich annotations' describeChange() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350580 [15:45:13] (03PS3) 10Jforrester: tests: Test rich annotations' describeChange() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350580 [15:45:37] (03CR) 10Jforrester: "Oh, yeah, that'd do it." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350550 (https://phabricator.wikimedia.org/T163945) (owner: 10Esanders) [15:49:49] (03PS1) 10DLynch: LinkAnnotation: fix getFragment behavior [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350586 [15:50:24] James_F: There, follow-up patch to fix Ed's complaints. [15:50:46] Kemayo: Bah. I was writing one too. [15:51:06] Mine is less code though. :-) [15:51:10] return this.getHref().split( /#(.+)/, 2 )[ 1 ] || ''; [15:51:36] I went and deliberately copied what mw.Title did to split the fragment out, I admit. [15:51:53] mw.Title is sadly not the best code to copy. [15:52:08] Granted! But I figured that consistency was a virtue in this case. [15:52:11] If anything, we should re-write it, not the other way around. [15:52:14] Eh. [15:52:27] My code is … possibly faster? [15:52:29] * James_F shrugs. [15:52:45] I'll leave it to you, and run to my oh-so-fun meeting. [15:53:22] (03CR) 10Jforrester: [C: 031] "or return this.getHref().split( /#(.+)/, 2 )[ 1 ] || '' ;-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350586 (owner: 10DLynch) [15:58:42] (03CR) 10DLynch: "> or return this.getHref().split( /#(.+)/, 2 )[ 1 ] || '' ;-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350586 (owner: 10DLynch) [15:59:20] Kemayo: WFM. Will leave to edsanders as he's picky. [16:01:41] (03CR) 10Esanders: [C: 04-1] "indexOf+slice is what mediawiki.Title.js uses - so good enough for me" (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350586 (owner: 10DLynch) [16:03:03] 10VisualEditor, 10VisualEditor-MediaWiki: "Start editing" popup keeps appearing? - https://phabricator.wikimedia.org/T162575#3218208 (10Elitre) 05stalled>03Invalid I'm pretty much aware of n.3 :D Maybe an intermittent thing. Will reopen if it rehappens. [16:03:29] regexes seem more likely to go wrong in unexpected ways [16:10:05] (03PS2) 10DLynch: LinkAnnotation: fix getFragment behavior [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350586 [16:12:25] (03PS2) 10Esanders: Synchronise VE availability checks in frontend and backend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350582 [16:22:24] (03PS1) 10DLynch: tests: MWInternalLinkAnnotation getFragment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350595 [16:24:07] For completeness sake, etc. [16:26:43] (03CR) 10DLynch: init: Relax checks for required skin elements to avoid false positives (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350471 (https://phabricator.wikimedia.org/T162411) (owner: 10Bartosz Dziewoński) [16:51:27] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI: Padding on icons in VE mobile context broken by OOUI update - https://phabricator.wikimedia.org/T163473#3198794 (10DLynch) Might be a side-effect of my changes to buttongroups in toolbars (d22d2331), somehow. That said, is there an image somewhere... [16:57:13] James_F: hm, was that handy, converting the syntaxhighlight page to Flow (which doens't support syntaxhighlight) ? [16:57:29] https://www.mediawiki.org/wiki/Topic:Tphiuhopo9ykbue5 [16:58:48] i mean syntaxhighlight was complicated enough. having a broken discussion system in there won't help much :) [17:13:38] thedj: Works fine inside VE. :-) [17:14:06] James_F: you filing a table bug? [17:14:25] thedj: https://phabricator.wikimedia.org/T59159 [17:14:35] edsanders: Will do. [17:14:44] edsanders: But if you want to be my guest. [17:20:32] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Tables: Tables can be created inside list items, even though that is invalid wikitext - https://phabricator.wikimedia.org/T164016#3218437 (10Esanders) [17:22:53] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Tables: Tables can be created inside list items, even though that is invalid wikitext - https://phabricator.wikimedia.org/T164016#3218437 (10Jdforrester-WMF) Eh. `*
FooBar
` is valid wikitext and renders fine. P... [17:23:37] (03CR) 10Bmansurov: Improve API response on formatversion=2 (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350101 (https://phabricator.wikimedia.org/T155164) (owner: 10Bmansurov) [17:24:11] (03CR) 10Jforrester: [C: 032] LinkAnnotation: fix getFragment behavior [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350586 (owner: 10DLynch) [17:26:05] (03PS4) 10Jforrester: tests: Test rich annotations' describeChange() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350580 [17:26:26] (03CR) 10Jforrester: tests: Test rich annotations' describeChange() (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350580 (owner: 10Jforrester) [17:26:45] (03CR) 10Jforrester: [C: 032] VisualDiff: Don't describe internalItem changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350550 (https://phabricator.wikimedia.org/T163945) (owner: 10Esanders) [17:26:49] (03CR) 10Jforrester: [C: 032] VisualDiff: Don't try to render empty node changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350551 (owner: 10Esanders) [17:27:30] Kemayo: Wanna merge https://gerrit.wikimedia.org/r/#/c/350578/ and https://gerrit.wikimedia.org/r/#/c/350580/ ? :-) [17:27:49] 10VisualEditor, 10VisualEditor-DataModel: Enforce suggestedParentNodeTypes in fixupInsertion - https://phabricator.wikimedia.org/T164017#3218462 (10Esanders) [17:28:00] (03CR) 10Jforrester: [C: 032] tests: MWInternalLinkAnnotation getFragment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350595 (owner: 10DLynch) [17:28:10] 10VisualEditor, 10VisualEditor-DataModel: Enforce suggestedParentNodeTypes in fixupInsertion - https://phabricator.wikimedia.org/T164017#3218475 (10Esanders) [17:28:12] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Tables: Tables can be created inside list items, even though that is invalid wikitext - https://phabricator.wikimedia.org/T164016#3218474 (10Esanders) [17:28:19] (03CR) 10jerkins-bot: [V: 04-1] tests: Test rich annotations' describeChange() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350580 (owner: 10Jforrester) [17:29:53] (03Merged) 10jenkins-bot: VisualDiff: Don't describe internalItem changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350550 (https://phabricator.wikimedia.org/T163945) (owner: 10Esanders) [17:29:57] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Tables: Tables can be created inside list items, even though that is invalid wikitext - https://phabricator.wikimedia.org/T164016#3218437 (10Esanders) So is `*

Heading

`. This is why we have suggestedParentNodeTypes. It allows it to exist in th... [17:29:57] (03Merged) 10jenkins-bot: VisualDiff: Don't try to render empty node changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350551 (owner: 10Esanders) [17:30:57] edsanders: As of Parsoid HTML 1.4.0 (new yesterday), it knows about audio and video files. See e.g. https://en.wikipedia.beta.wmflabs.org/api/rest_v1/page/html/User%3AJdforrester_(WMF)%2Fsandbox – but VE alienates them, and I can't quite see why, dm.MWBlockImageNode should match? [17:31:12] edsanders: Should we sub-class it for the special attributes? [17:31:22] Kemayo: do you fancy having a go at T164017? [17:31:22] T164017: Enforce suggestedParentNodeTypes in fixupInsertion - https://phabricator.wikimedia.org/T164017 [17:34:48] (03CR) 10jenkins-bot: VisualDiff: Don't describe internalItem changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350550 (https://phabricator.wikimedia.org/T163945) (owner: 10Esanders) [17:35:41] (03PS1) 10Esanders: Specify suggested parent node types for tables [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350609 (https://phabricator.wikimedia.org/T164016) [17:36:26] (03PS1) 10Esanders: VisualDiff: Check save dialog is still visible when re-rendering diff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350610 [17:36:28] (03CR) 10Jforrester: "They'll work in
s too, right?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350609 (https://phabricator.wikimedia.org/T164016) (owner: 10Esanders) [17:36:38] i thought i had killed that stupid speaker fallback by now... [17:36:45] (03CR) 10jenkins-bot: VisualDiff: Don't try to render empty node changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350551 (owner: 10Esanders) [17:38:29] thedj: Nope, still loads of crap to kill. :-( [17:38:35] thedj: But we're working on it. [17:40:08] thedj: On the plus side, I get the nice snazzy new player inside VE – but inaccessible. And also it's not the player I get in read mode. But hey, baby steps. [17:40:22] thedj: (Is there a plan to push the new video player out on WMF wikis?) [17:40:34] nope [17:40:43] it's on test2.wp.org [17:41:06] (03Merged) 10jenkins-bot: tests: MWInternalLinkAnnotation getFragment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350595 (owner: 10DLynch) [17:41:30] thedj: If I delete the aliennode blocking div the player works. It's so close… [17:48:08] (03CR) 10jenkins-bot: tests: MWInternalLinkAnnotation getFragment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350595 (owner: 10DLynch) [18:04:52] James_F: working on it [18:05:37] edsanders: You rock. [18:05:58] edsanders: Note that we'll need to put some code in TMH for sub-classing inc. the extra config options? [18:06:04] (Eventually.) [18:09:45] (03PS1) 10Esanders: Add basic support for Parsoid HTML5 video/audio [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350624 [18:10:36] yes [18:21:05] James_F: do Parsoid have a plugin system - because their code should be in TMH as well [18:21:50] edsanders: Yes, but not using it for this, I believe. [18:21:54] edsanders: (Yet.) [18:22:13] (03CR) 10Esanders: "nope - it's a whitelist system." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350609 (https://phabricator.wikimedia.org/T164016) (owner: 10Esanders) [18:25:56] (03CR) 10Jforrester: [C: 04-1] "Sorry, more bluntly: Your list misses
s but I believe they work trivially inside them, so you need to fix your list or convince me I'" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350609 (https://phabricator.wikimedia.org/T164016) (owner: 10Esanders) [18:30:17] 10VisualEditor: Consider removing icon-add element from Transclusion dialog's options - https://phabricator.wikimedia.org/T164027#3218775 (10Volker_E) [18:30:34] (03CR) 10jerkins-bot: [V: 04-1] Add basic support for Parsoid HTML5 video/audio [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350624 (owner: 10Esanders) [18:31:44] 10VisualEditor: Consider removing icon-add element from Transclusion dialog's options - https://phabricator.wikimedia.org/T164027#3218788 (10Volker_E) [18:38:06] edsanders: i'm pretty sure there was an earlier attempt to fix that MWembed reference. [18:38:24] edsanders: and then reverted or abandoned. [18:38:47] anyway. videojs doesn't need it, only kaltura player does. [18:39:39] well it doesn't work on my setup because I don't have a "normal" directory structure [18:42:59] (03CR) 10Jforrester: [C: 032] VisualDiff: Check save dialog is still visible when re-rendering diff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350610 (owner: 10Esanders) [18:53:13] (03Merged) 10jenkins-bot: VisualDiff: Check save dialog is still visible when re-rendering diff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350610 (owner: 10Esanders) [19:05:39] (03CR) 10jenkins-bot: VisualDiff: Check save dialog is still visible when re-rendering diff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350610 (owner: 10Esanders) [19:23:45] (03CR) 10Bartosz Dziewoński: [C: 032] "Well, it works… huh." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/339400 (https://phabricator.wikimedia.org/T39932) (owner: 10Esanders) [19:24:26] (03Abandoned) 10Bartosz Dziewoński: WIP: Add possibility to paste a file to the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288773 (https://phabricator.wikimedia.org/T39932) (owner: 10Florianschmidtwelzow) [19:32:43] (03Merged) 10jenkins-bot: MWMediaTransferHandler: Allow uploading of dropped Blobs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/339400 (https://phabricator.wikimedia.org/T39932) (owner: 10Esanders) [19:40:01] (03CR) 10Esanders: [C: 032] tests: Cover LinkAnnotation#getFragment() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350578 (owner: 10Jforrester) [19:44:26] (03Merged) 10jenkins-bot: tests: Cover LinkAnnotation#getFragment() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350578 (owner: 10Jforrester) [19:44:52] (03Merged) 10jenkins-bot: LinkAnnotation: fix getFragment behavior [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350586 (owner: 10DLynch) [19:44:54] (03Merged) 10jenkins-bot: tests: Cover tags [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350579 (owner: 10Jforrester) [19:47:49] (03CR) 10jenkins-bot: MWMediaTransferHandler: Allow uploading of dropped Blobs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/339400 (https://phabricator.wikimedia.org/T39932) (owner: 10Esanders) [19:52:14] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: The wikitext mode is overly sensitive to the contents of the rest of the page - https://phabricator.wikimedia.org/T164031#3219014 (10Whatamidoing-WMF) [19:55:01] (03CR) 10Esanders: [C: 04-1] tests: Test rich annotations' describeChange() (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350580 (owner: 10Jforrester) [19:55:32] (03CR) 10jenkins-bot: tests: Cover LinkAnnotation#getFragment() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350578 (owner: 10Jforrester) [19:55:46] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Interface, and 3 others: content-holding
should only contain the page text - https://phabricator.wikimedia.org/T37247#3219054 (10dr0ptp4kt) Adding @bearND, @Mholloway, @JoeWalsh, @Jdlrobson, @MarkTraceur for visibility - you most likely... [19:57:41] (03CR) 10jenkins-bot: LinkAnnotation: fix getFragment behavior [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350586 (owner: 10DLynch) [19:59:47] (03CR) 10jenkins-bot: tests: Cover tags [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350579 (owner: 10Jforrester) [20:01:51] 10VisualEditor, 06Community-Liaisons: Support WMF communities in run-up to switching EditPage over to OOUI - https://phabricator.wikimedia.org/T162849#3219091 (10Johan) (No specific technical change related to this ticket; Tech News should and will link and to the tickets describing the technical changes. Plea... [20:02:02] (03PS5) 10Jforrester: tests: Test rich annotations' describeChange() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350580 [20:28:42] (03CR) 10Esanders: "Yes - I understood :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350609 (https://phabricator.wikimedia.org/T164016) (owner: 10Esanders) [20:45:16] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Interface, and 3 others: content-holding
should only contain the page text - https://phabricator.wikimedia.org/T37247#3219320 (10Nirmos) Does it have to be a class (instead of an id) because of Flow? [20:51:01] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Interface, and 3 others: content-holding
should only contain the page text - https://phabricator.wikimedia.org/T37247#3219342 (10Anomie) Flow or anything else that might want to put two "pages" of content in one HTML document. For examp... [20:52:43] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Interface, and 3 others: content-holding
should only contain the page text - https://phabricator.wikimedia.org/T37247#3219350 (10Nirmos) Yeah, ok, thanks. [20:53:16] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Interface, and 3 others: content-holding
should only contain the page text - https://phabricator.wikimedia.org/T37247#3219353 (10Anomie) >>! In T37247#3219054, @dr0ptp4kt wrote: > you most likely want to double check that CSS selector e... [21:09:30] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350727 (owner: 10L10n-bot) [21:17:09] (03CR) 10Jforrester: [C: 04-1] "Per comments on PS1" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350582 (owner: 10Esanders) [21:17:55] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350736 (owner: 10L10n-bot) [21:47:33] (03CR) 10Esanders: [C: 04-1] "Doesn't do typeToRdfa in the CE node correctly." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350624 (owner: 10Esanders) [22:11:07] I once again am getting 503 errors from restbase in vagrant. Anyone remembers how to fix it? [22:11:46] VE isn't working for me at all in Vagrant :( [22:12:25] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References: Reusing a citation and replacing the reference list template removes the original citation - https://phabricator.wikimedia.org/T152070#2837320 (10Whatamidoing-WMF) This just happened to me! https://en.wikipedia.org/w/index.php?title=Monoplegia&di... [22:23:24] (03CR) 10Krinkle: tests: Test rich annotations' describeChange() (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350580 (owner: 10Jforrester) [22:39:22] (03CR) 10Jforrester: tests: Test rich annotations' describeChange() (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350580 (owner: 10Jforrester) [22:45:39] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: The wikitext mode is overly sensitive to the contents of the rest of the page - https://phabricator.wikimedia.org/T164031#3219014 (10IKhitron) "File bug" in reproducing steps? You just created an infinite loop. [23:13:38] (03CR) 10Krinkle: tests: Test rich annotations' describeChange() (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350580 (owner: 10Jforrester) [23:41:44] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: The wikitext mode is overly sensitive to the contents of the rest of the page - https://phabricator.wikimedia.org/T164031#3219802 (10Whatamidoing-WMF) I assume that at some point, they'll fix the bug, and then the resulting error condition will cause... [23:50:17] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: The wikitext mode is overly sensitive to the contents of the rest of the page - https://phabricator.wikimedia.org/T164031#3219808 (10IKhitron) Yap. But no infinite loop in the world is actually infinite, it will stop before the year 3,017. It will be...