[08:19:35] 10VisualEditor: VisualEditor allows insertion of extension tags with empty content that later show errors - https://phabricator.wikimedia.org/T164053#3220097 (10Elitre) [08:24:14] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Community-Liaisons, 10Wikimedia-Site-requests: Support wikis in converting reference lists over to `responsive` - https://phabricator.wikimedia.org/T159895#3220123 (10Dereckson) [08:28:34] 10VisualEditor, 10VisualEditor-MediaWiki, 07Regression: [Regression] English magic words replaced with opposite localized ones while editing in VE - https://phabricator.wikimedia.org/T164054#3220126 (10Schnark) [08:50:58] 10VisualEditor, 10VisualEditor-MediaWiki, 07Regression: [Regression] English magic words replaced with opposite localized ones while editing in VE - https://phabricator.wikimedia.org/T164054#3220154 (10Schnark) Seems to happen also for magic words that are already localized: https://de.wikipedia.org/w/index.... [08:51:28] 10Citoid, 10VisualEditor: Citoid icinga alert /api (open graph via native scraper) is CRITICAL: Test open graph via native scraper returned the unexpected status 404 (expecting: 200) - https://phabricator.wikimedia.org/T163986#3220157 (10akosiaris) The entire service (citoid - and zotero that is powering many... [09:12:34] 10VisualEditor, 06Community-Liaisons: Support WMF communities in run-up to switching EditPage over to OOUI - https://phabricator.wikimedia.org/T162849#3220193 (10Ladsgroup) After talking to prominent users in fawiki, they were all in favor of rolling this out there. just FYI. I can help out in communication if... [09:14:17] 10VisualEditor, 10OOjs-UI, 07Browser-Support-Firefox, 07Regression: Welcome dialog in VE has scrollbar in Firefox - https://phabricator.wikimedia.org/T164056#3220197 (10Schnark) [11:16:19] 10VisualEditor, 10Vector: Vector is blamed to be incompatible with VisualEditor - https://phabricator.wikimedia.org/T164061#3220437 (10Paladox) [13:08:27] (03PS2) 10Esanders: Add basic support for Parsoid HTML5 video/audio [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350624 [14:09:55] 10VisualEditor, 10Vector: Vector is blamed to be incompatible with VisualEditor - https://phabricator.wikimedia.org/T164061#3220842 (10PerfektesChaos) [14:23:51] 10VisualEditor, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 15User-Ryasmeen, 15User-zeljkofilipin: LanguageScreenshotBot trying to edit a non-existent page without signing in - https://phabricator.wikimedia.org/T162454#3220913 (10zeljkofilipin) 05Resolved>03Open The job still fails: htt... [14:24:23] 10VisualEditor, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 15User-Ryasmeen, 15User-zeljkofilipin: LanguageScreenshotBot trying to edit a non-existent page without signing in - https://phabricator.wikimedia.org/T162454#3220915 (10zeljkofilipin) I could not reproduce the problem on my machine... [15:02:01] (03PS1) 10Esanders: Run screenshot tests in series [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350857 [15:03:01] 10VisualEditor: ULS is misplaced on Template insertion window - https://phabricator.wikimedia.org/T164078#3221030 (10Trizek-WMF) [15:07:49] 10VisualEditor, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 15User-Ryasmeen, 15User-zeljkofilipin: LanguageScreenshotBot trying to edit a non-existent page without signing in - https://phabricator.wikimedia.org/T162454#3221093 (10Esanders) I think the way I rewrote the tests it runs the lang... [15:10:01] (03CR) 10Jforrester: [C: 031] "Neat." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350857 (owner: 10Esanders) [15:10:44] (03CR) 10Esanders: "hacky" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350857 (owner: 10Esanders) [15:15:23] (03CR) 10Jforrester: [C: 032] "Should we create a top-level MWMediaNode/etc. and have MW*ImageNode as the default fall-through?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350624 (owner: 10Esanders) [15:24:52] (03CR) 10Esanders: [C: 032] tests: Test rich annotations' describeChange() (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350580 (owner: 10Jforrester) [15:26:45] (03Merged) 10jenkins-bot: Add basic support for Parsoid HTML5 video/audio [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350624 (owner: 10Esanders) [15:27:12] (03Merged) 10jenkins-bot: tests: Test rich annotations' describeChange() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350580 (owner: 10Jforrester) [15:29:27] (03CR) 10jenkins-bot: tests: Test rich annotations' describeChange() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350580 (owner: 10Jforrester) [15:30:38] (03CR) 10jenkins-bot: Add basic support for Parsoid HTML5 video/audio [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350624 (owner: 10Esanders) [15:34:28] 10VisualEditor: Change "Use this image" label to "Use this media" - https://phabricator.wikimedia.org/T164086#3221195 (10Elitre) [15:43:06] (03PS1) 10Jforrester: Update VE core submodule to master (a5deb2b73) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350859 (https://phabricator.wikimedia.org/T163945) [15:43:08] (03PS1) 10Jforrester: Re-sync tests from VE-core into ext.visualEditor.test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350860 [15:46:59] (03PS6) 10Bmansurov: Improve API response on formatversion=2 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350101 (https://phabricator.wikimedia.org/T155164) [15:48:04] (03PS1) 10Esanders: [BREAKING CHANGE] QUnit: Remove all code for counting tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350862 [15:49:58] (03PS1) 10Esanders: QUnit: Remove all code for counting tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350865 [15:50:13] (03CR) 10jerkins-bot: [V: 04-1] Re-sync tests from VE-core into ext.visualEditor.test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350860 (owner: 10Jforrester) [15:58:01] (03CR) 10jerkins-bot: [V: 04-1] QUnit: Remove all code for counting tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350865 (owner: 10Esanders) [16:03:28] (03PS2) 10Esanders: QUnit: Remove all code for counting tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350865 [16:05:23] (03PS1) 10Esanders: Remove eslint:fix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350870 [16:05:59] 10Citoid, 10VisualEditor: Citoid icinga alert /api (open graph via native scraper) is CRITICAL: Test open graph via native scraper returned the unexpected status 404 (expecting: 200) - https://phabricator.wikimedia.org/T163986#3217190 (10mobrovac) I agree that defining the term //the service is working properl... [16:07:12] 10Citoid, 10VisualEditor, 06Services (watching), 15User-mobrovac: Citoid icinga alert /api (open graph via native scraper) is CRITICAL: Test open graph via native scraper returned the unexpected status 404 (expecting: 200) - https://phabricator.wikimedia.org/T163986#3221320 (10mobrovac) [16:07:22] (03PS1) 10Esanders: Remove eslint:fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350872 [16:08:39] (03PS2) 10Esanders: Remove eslint:fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350872 [16:08:47] (03PS2) 10Esanders: Remove eslint:fix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350870 [16:09:11] (03CR) 10Jforrester: [C: 032] Remove eslint:fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350872 (owner: 10Esanders) [16:09:17] (03CR) 10Jforrester: [C: 032] Remove eslint:fix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350870 (owner: 10Esanders) [16:09:33] (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] QUnit: Remove all code for counting tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350862 (owner: 10Esanders) [16:13:32] (03CR) 10Jforrester: [C: 032] QUnit: Remove all code for counting tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350865 (owner: 10Esanders) [16:14:25] (03Merged) 10jenkins-bot: Remove eslint:fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350872 (owner: 10Esanders) [16:16:02] (03Merged) 10jenkins-bot: [BREAKING CHANGE] QUnit: Remove all code for counting tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350862 (owner: 10Esanders) [16:17:41] (03PS4) 10Bmansurov: Use modified action=templatedata response format [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350489 [16:18:47] (03Merged) 10jenkins-bot: Remove eslint:fix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350870 (owner: 10Esanders) [16:20:31] (03CR) 10jenkins-bot: Remove eslint:fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350872 (owner: 10Esanders) [16:22:24] (03Merged) 10jenkins-bot: QUnit: Remove all code for counting tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350865 (owner: 10Esanders) [16:22:42] (03CR) 10jenkins-bot: [BREAKING CHANGE] QUnit: Remove all code for counting tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350862 (owner: 10Esanders) [16:26:12] (03CR) 10jerkins-bot: [V: 04-1] Use modified action=templatedata response format [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350489 (owner: 10Bmansurov) [16:26:24] (03CR) 10jenkins-bot: Remove eslint:fix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350870 (owner: 10Esanders) [16:30:22] (03CR) 10jenkins-bot: QUnit: Remove all code for counting tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350865 (owner: 10Esanders) [16:32:02] (03PS1) 10Esanders: Remove eslint:fix [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/350876 [16:35:17] (03CR) 10Jforrester: [C: 032] Remove eslint:fix [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/350876 (owner: 10Esanders) [16:43:33] (03Merged) 10jenkins-bot: Remove eslint:fix [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/350876 (owner: 10Esanders) [16:45:07] (03CR) 10Esanders: Synchronise VE availability checks in frontend and backend (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350582 (owner: 10Esanders) [16:45:35] (03PS3) 10Esanders: Synchronise VE availability checks in frontend and backend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350582 [16:55:05] (03CR) 10Jforrester: [C: 032] Synchronise VE availability checks in frontend and backend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350582 (owner: 10Esanders) [17:02:55] (03Merged) 10jenkins-bot: Synchronise VE availability checks in frontend and backend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350582 (owner: 10Esanders) [17:06:59] (03CR) 10jenkins-bot: Synchronise VE availability checks in frontend and backend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350582 (owner: 10Esanders) [17:44:44] (03CR) 10Esanders: "I don't think you want to run the server tests in the client..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350860 (owner: 10Jforrester) [17:45:15] (03CR) 10Esanders: "Oh wait - ve.dm.Change is client code as well" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350860 (owner: 10Jforrester) [18:36:58] 10VisualEditor, 07JavaScript, 07Regression, 15User-Urbanecm, 07Wikimedia-Incident: JavaScript is broken at cswiki recently - https://phabricator.wikimedia.org/T164102#3221757 (10Urbanecm) [18:37:13] 10VisualEditor, 10Gadgets, 07JavaScript, 07Regression, and 2 others: JavaScript is broken at cswiki recently - https://phabricator.wikimedia.org/T164102#3221770 (10Urbanecm) p:05Triage>03Unbreak! [18:42:01] 10VisualEditor, 10Gadgets, 10Wikimedia-General-or-Unknown, 07JavaScript, and 3 others: JavaScript is broken at cswiki recently - https://phabricator.wikimedia.org/T164102#3221779 (10Urbanecm) From some reasons this does not affect all projects. English Wikipedia is okay ATM. [18:47:13] 10VisualEditor, 10Gadgets, 10Wikimedia-General-or-Unknown, 07JavaScript, and 3 others: JavaScript is broken at cswiki recently - https://phabricator.wikimedia.org/T164102#3221802 (10matej_suchanek) p:05Unbreak!>03Triage The gadget Cat-a-lot is responsible for this. [18:47:50] 10VisualEditor, 10Gadgets, 10Wikimedia-General-or-Unknown, 07JavaScript, 15User-Urbanecm: JavaScript is broken at cswiki recently - https://phabricator.wikimedia.org/T164102#3221806 (10greg) Removing a couple tags per @matej_suchanek's comment. [18:48:11] 10VisualEditor, 10Gadgets, 07JavaScript, 15User-Urbanecm: JavaScript is broken at cswiki recently - https://phabricator.wikimedia.org/T164102#3221808 (10greg) [18:52:30] (03PS1) 10Jforrester: ve.dm.ElementLinearData.test: Cover getAnnotationIndexesFromOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350890 [18:52:31] (03PS1) 10Jforrester: [WIP] ElementLinearData: Don't use IVStores, rely on annotation hashes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350891 [19:04:51] (03CR) 10Jforrester: "This should be a little bit faster, relying on the hashing function…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350891 (owner: 10Jforrester) [19:11:20] 10VisualEditor, 10VisualEditor-MediaWiki, 15User-Urbanecm: After making an edit in VisualEditor, the button Mark this page as patrolled isn't shown - https://phabricator.wikimedia.org/T152900#3221888 (10Urbanecm) Bug is still present. Any update? [19:23:05] 10VisualEditor, 06Community-Liaisons, 07User-notice: Support WMF communities in run-up to switching EditPage over to OOUI - https://phabricator.wikimedia.org/T162849#3221943 (10Jdforrester-WMF) >>! In T162849#3219091, @Johan wrote: > (No specific technical change related to this ticket; Tech News should and... [19:23:21] 10VisualEditor, 06Community-Liaisons, 07User-notice: Support WMF communities in run-up to switching EditPage over to OOUI - https://phabricator.wikimedia.org/T162849#3221946 (10Jdforrester-WMF) [19:28:11] 10VisualEditor, 06Community-Liaisons, 07User-notice: Support WMF communities in run-up to switching EditPage over to OOUI - https://phabricator.wikimedia.org/T162849#3221977 (10Jdforrester-WMF) [19:30:51] 10VisualEditor, 06Community-Liaisons, 07User-notice: Support WMF communities in run-up to switching EditPage over to OOUI - https://phabricator.wikimedia.org/T162849#3221987 (10Quiddity) [19:32:04] 10VisualEditor, 06Community-Liaisons, 07User-notice: Support WMF communities in run-up to switching EditPage over to OOUI - https://phabricator.wikimedia.org/T162849#3221989 (10Jdforrester-WMF) [19:48:16] 10VisualEditor, 06Community-Liaisons, 07User-notice: Support WMF communities in run-up to switching EditPage over to OOUI - https://phabricator.wikimedia.org/T162849#3222083 (10Jdforrester-WMF) >>! In T162849#3220193, @Ladsgroup wrote: > After talking to prominent users in fawiki, they were all in favor of r... [20:36:56] 10VisualEditor, 10Parsoid, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 05MW-1.29-release-notes, and 3 others: Parsoid should use the "mw" interwiki prefix instead of the "mediawikiwiki" one - https://phabricator.wikimedia.org/T145337#3222211 (10Krinkle) Okay. So there's another layer. 1. {i... [20:53:16] 10VisualEditor, 10OOjs-UI, 10SyntaxHighlight, 13Patch-For-Review: OO.ui.ComboBoxInputWidget should scroll back to the top if no exact match is found after filtering via filterFromInput: true - https://phabricator.wikimedia.org/T163536#3200812 (10Krinkle) Bug is still on mediawiki.org, but should be fixed o... [21:03:19] 10WikiEditor, 10Wikimedia-General-or-Unknown, 07Regression: Toolbar missing at no.wiki - https://phabricator.wikimedia.org/T164116#3222322 (10Aklapper) [21:04:01] hmm, interesting. i'm able to trigger a nowiki insertion. [21:05:10] i copied some wikitext from the wikieditor, then pasted it in ve source editor and it surrounds everything with nowiki [21:05:40] i can also see it bringing up some sort of dialog, which is immediately dismissed, before i can read it. [21:08:49] 10WikiEditor, 10Wikimedia-General-or-Unknown, 07Regression: Toolbar missing at no.wiki - https://phabricator.wikimedia.org/T164116#3222366 (10jeblad) Force browser cache to reload? I had a complete purge earlier today. The toolbar is gone for me even when all gadgets are turned off. [21:10:23] 10WikiEditor, 10Wikimedia-General-or-Unknown, 07Regression: Toolbar missing at no.wiki - https://phabricator.wikimedia.org/T164116#3222367 (10jeblad) When not logged in and using Chromium the toolbar is there. [21:13:12] 10WikiEditor, 10Wikimedia-General-or-Unknown, 07Regression: Toolbar missing at no.wiki - https://phabricator.wikimedia.org/T164116#3222241 (10TheDJ) It's trying to retrieve something from your cookies (collapsed state of the advanced toolbar I suspect), and fails on reading that. So it is likely specific to... [21:13:50] 10VisualEditor, 06Editing-Department, 10MobileFrontend, 07Mobile: Click edit section, click previous page, click previous page. The last click has no effect. The browser is trapped in the page. - https://phabricator.wikimedia.org/T164104#3222376 (10Jdlrobson) [21:19:32] (03CR) 10Esanders: [C: 04-2] "I don't think this is identical, because compareTo uses ve.dm.Annotation#getComparableObect, whereas the hash will be getHashObject." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350891 (owner: 10Jforrester) [21:19:48] 10WikiEditor, 10Wikimedia-General-or-Unknown, 07Regression: Toolbar missing at no.wiki - https://phabricator.wikimedia.org/T164116#3222389 (10jeblad) Also happens when I'm logged out on Firefox. Note that {T164118} is new today, not sure if it is related. [21:21:57] 10WikiEditor, 10Wikimedia-General-or-Unknown, 07Regression: Toolbar missing at no.wiki - https://phabricator.wikimedia.org/T164116#3222397 (10jeblad) Deleted all cookies a wikipedia-page and the toolbar is back. [21:27:00] 10WikiEditor, 10Wikimedia-General-or-Unknown, 07Regression: Toolbar missing at no.wiki - https://phabricator.wikimedia.org/T164116#3222407 (10jeblad) I'll tell them about how to solve the problem. Let the task hang around a day in case someone needs it, but I guess the fix is "Eat all cookies!" [21:28:37] 10WikiEditor, 10Wikimedia-General-or-Unknown, 07Regression: Toolbar missing at no.wiki - https://phabricator.wikimedia.org/T164116#3222411 (10TheDJ) @jeblad try to find out if the users affected have a gadget or userscript in common. Might be something like that is not using the jquery.cookie module and mess... [21:31:07] 10WikiEditor, 10Wikimedia-General-or-Unknown, 07Regression: Toolbar missing at no.wiki - https://phabricator.wikimedia.org/T164116#3222415 (10TheDJ) no:MediaWiki:Gadget-notifications.js, no:MediaWiki:Gadget-recent-changes-patrol.js and no:MediaWiki:Gadget-GoogleTrans.js all seem suspicious to me. [21:32:03] 10WikiEditor, 10Wikimedia-General-or-Unknown, 07Regression: Toolbar missing at no.wiki - https://phabricator.wikimedia.org/T164116#3222416 (10jeblad) Problem persisted even if all gadgets was turned off. It seems likely that something has messed with a cookie, ... argh, perhaps I know what... [21:38:33] 10VisualEditor, 10VisualEditor-MediaWiki, 10SyntaxHighlight, 15User-Ryasmeen: After the first time the SyntaxHighlighter inspector opens, the language drop-down only appears after a second click on the indicator - https://phabricator.wikimedia.org/T113088#3222435 (10Krinkle) 05Open>03Resolved [21:40:41] 10WikiEditor, 10Wikimedia-General-or-Unknown, 07Regression: Toolbar missing at no.wiki - https://phabricator.wikimedia.org/T164116#3222440 (10TheDJ) @jeblad, a cookie is persistent, so if something wrote a broken value, then another cookie reader will have to deal with that broken value regardless. cookies... [21:44:00] 10VisualEditor, 10SyntaxHighlight: Make language identification for a code block is case insensitive in VE - https://phabricator.wikimedia.org/T125231#3222463 (10Krinkle) [21:44:41] 10WikiEditor, 10Wikimedia-General-or-Unknown, 07Regression: Toolbar missing at no.wiki - https://phabricator.wikimedia.org/T164116#3222470 (10jeblad) Not me! ;) But my hunch was wrong, I suspected some new code, but it wasn't that code. But yes, the code for some of the gadgets should be burned over live fire. [21:49:15] 10VisualEditor, 10SyntaxHighlight: Code block disappears when specified language is unknown (mismatch read mode) - https://phabricator.wikimedia.org/T164120#3222481 (10Krinkle) [21:49:25] 10VisualEditor, 10SyntaxHighlight, 07Regression: Code block disappears when specified language is unknown (mismatch read mode) - https://phabricator.wikimedia.org/T164120#3222494 (10Krinkle) [21:49:43] 10VisualEditor, 10SyntaxHighlight, 07Regression: Code block disappears when specified language is unknown (mismatch read mode) - https://phabricator.wikimedia.org/T164120#3222481 (10Krinkle) (Tagging as Regression as I'm fairly certain this wasn't the case a few weeks ago.) [21:49:58] 10VisualEditor, 10SyntaxHighlight, 07Regression: Code block disappears when specified language is unknown (mismatch read mode) - https://phabricator.wikimedia.org/T164120#3222497 (10Krinkle) p:05Triage>03Normal [22:07:02] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350945 (owner: 10L10n-bot) [22:08:22] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI: Padding on icons in VE mobile context broken by OOUI update - https://phabricator.wikimedia.org/T163473#3198794 (10Jdforrester-WMF) Something like this: {F7819156} [22:12:50] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI: Padding on icons in VE mobile context broken by OOUI update - https://phabricator.wikimedia.org/T163473#3222556 (10DLynch) Ah, I see, it's more the spacing on the entire row than the icons themselves. [22:14:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/350952 (owner: 10L10n-bot) [22:14:38] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI: Padding on icons in VE mobile context broken by OOUI update - https://phabricator.wikimedia.org/T163473#3222558 (10Jdforrester-WMF) a:03DLynch You broke it, //etc.// ;-) [22:20:57] 10VisualEditor, 10VisualEditor-DataModel: Introduce DM events for "a node of this type was inserted/deleted/modified"? - https://phabricator.wikimedia.org/T162761#3222618 (10Jdforrester-WMF) [22:21:00] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-DataModel, 07Epic, and 2 others: (Re-) unify data and metadata - https://phabricator.wikimedia.org/T56299#3222617 (10Jdforrester-WMF) [22:21:56] 10VisualEditor, 10VisualEditor-DataModel: Introduce DM events for "a node of this type was inserted/deleted/modified"? - https://phabricator.wikimedia.org/T162761#3173945 (10Jdforrester-WMF) This is a blocker for T56299 landing (because of the VE-MW need); is there a way we could implement this inefficiently a... [22:39:32] (03CR) 10Esanders: [C: 032] ve.dm.ElementLinearData.test: Cover getAnnotationIndexesFromOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350890 (owner: 10Jforrester) [22:43:21] (03Merged) 10jenkins-bot: ve.dm.ElementLinearData.test: Cover getAnnotationIndexesFromOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350890 (owner: 10Jforrester) [22:45:46] (03CR) 10jenkins-bot: ve.dm.ElementLinearData.test: Cover getAnnotationIndexesFromOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350890 (owner: 10Jforrester) [23:10:41] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI: Padding on icons in VE mobile context broken by OOUI update - https://phabricator.wikimedia.org/T163473#3222777 (10DLynch) I think it's actually //maybe// Volker! There were several commits in the last release cycle or two which involved refactoring... [23:36:10] (03PS1) 10DLynch: MobileContext: fix button spacing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350962 (https://phabricator.wikimedia.org/T163473) [23:36:42] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI, 13Patch-For-Review: Padding on icons in VE mobile context broken by OOUI update - https://phabricator.wikimedia.org/T163473#3222814 (10Volker_E) Yup, I haven't touched toolbar tools (yet), but as there are probably a few ButtonElements scattered h... [23:38:07] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI, 13Patch-For-Review: Padding on icons in VE mobile context broken by OOUI update - https://phabricator.wikimedia.org/T163473#3222815 (10DLynch) My patch applies some custom padding to non-labelWidget buttons in the header of a few places in VE. I'm... [23:39:01] (03CR) 10jerkins-bot: [V: 04-1] MobileContext: fix button spacing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350962 (https://phabricator.wikimedia.org/T163473) (owner: 10DLynch) [23:39:46] (03PS2) 10DLynch: MobileContext: fix button spacing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350962 (https://phabricator.wikimedia.org/T163473) [23:41:28] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI, 13Patch-For-Review: Padding on icons in VE mobile context broken by OOUI update - https://phabricator.wikimedia.org/T163473#3222817 (10Volker_E) From first reaction, I'd be with your comment – being inclined to have it centralized in OOUI as we've... [23:53:42] 10WikiEditor, 10Wikimedia-General-or-Unknown, 07Regression: Toolbar missing at no.wiki - https://phabricator.wikimedia.org/T164116#3222827 (10jeblad) I can provoke this to happen, but I can't narrow down why. It is a bit of a Heisenbug, so don't expect me to find it anytime soon.