[06:25:10] Hmmm... When was the left panel when you click on "Special characters" condensed? [06:28:50] Because it's cutting off the first character if it has a diacritic now. [06:29:44] Well, it's shaving off its diacritic, at any rate. [06:30:18] Noticed it today at bs.wiki http://i.imgur.com/zs1GtiF.png [06:32:02] It says "Cirilica", but it should say "Ćirilica". I'm on FF and on OS X (10.11.6). [06:41:50] Not happening in Chrome though. [07:54:24] 10VisualEditor, 10VisualEditor-MediaWiki: Provide visible tool for aborting edit in VE - https://phabricator.wikimedia.org/T164705#3242722 (10Schnark) [09:22:49] 10VisualEditor: Cursor jumps when working at bottom of the article? - https://phabricator.wikimedia.org/T164720#3243002 (10Elitre) [10:08:06] 10VisualEditor: Diff on medium sized table takes a very long time then shows no diff - https://phabricator.wikimedia.org/T164724#3243143 (10Esanders) [10:13:37] 10VisualEditor: Diff on medium sized table takes a very long time then shows no diff - https://phabricator.wikimedia.org/T164724#3243161 (10Esanders) The lack of diff is cause by the timeout code - although it should result in the entire table being replaced. Also the timeout happens too high up to catch the slo... [10:16:13] 10Citoid, 10VisualEditor: Add support for worldcat search api xml results - https://phabricator.wikimedia.org/T162357#3243162 (10Mvolz) p:05Triage>03Normal [15:15:29] (03CR) 10Bartosz Dziewoński: [C: 032] "Doesn't seem to break anything (testing with a copy of the templated tables from https://en.wikipedia.org/wiki/Alfonso_Cuarón)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/351883 (owner: 10DLynch) [15:22:30] (03CR) 10Bartosz Dziewoński: [C: 031] MWTransclusionNode: Implement MWTransclusionTableCell [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/351883 (owner: 10DLynch) [15:23:15] (03CR) 10Bartosz Dziewoński: [C: 031] "(On second thought, I don't really know how this works and better leave it for Ed.)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/351883 (owner: 10DLynch) [15:25:05] MatmaRex: if you tweak the CSS of the invisible text you can make it visible again, and then scroll up to work out where the two layers are diverging [15:25:10] that would be helpful to know [15:26:31] edsanders: it looked like the line height was not matched well, they diverged more and more the further i scrolled. i can look again [15:26:55] this is on wekit? [15:26:59] +b [15:27:10] it should match the line-height and font-size using computed CSS [15:27:34] divering by two lines out of a thousand would be a really small difference [15:27:43] more likely to be occasional wrapper errors [15:27:48] *wrapping [15:28:01] I see the same locally, will investigate [15:29:34] edsanders: here's a screenshot of a shorter article, with the "real" text in red: http://i.imgur.com/xgtInmu.jpg [15:29:47] mismatched slightly at first, but by nearly a full line by the end [15:30:11] (ugh, why did that get turned into a jpg. anyway.) [15:50:23] I think it's the headings [15:50:38] The old stylesheet used to render those as different sizes, maybe I haven't reset them fully [15:54:21] yep - needed a line-height: inherit [16:26:06] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff on a specific page on Officewiki hangs forever - https://phabricator.wikimedia.org/T164763#3244533 (10matmarex) [16:39:22] 10VisualEditor, 06Community-Liaisons: Finalize centralisation of VE user feedback - https://phabricator.wikimedia.org/T162664#3244638 (10Jdforrester-WMF) [16:47:40] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff on a specific page on Officewiki hangs forever - https://phabricator.wikimedia.org/T164763#3244667 (10Esanders) [16:47:42] 10VisualEditor: Diff on medium sized table takes a very long time then shows no diff - https://phabricator.wikimedia.org/T164724#3244670 (10Esanders) [16:49:47] 10VisualEditor, 06Community-Liaisons: Finalize centralisation of VE user feedback - https://phabricator.wikimedia.org/T162664#3244681 (10Elitre) [17:54:08] 10VisualEditor, 10VisualEditor-EditingTools, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 15User-Ryasmeen: How to switch off new heading/section HTML div-split function - https://phabricator.wikimedia.org/T164453#3244914 (10Jdforrester-WMF) 05Open>03Resolved [18:02:14] Anyone want to merge https://gerrit.wikimedia.org/r/#/c/352055/ and stack for me? ;-) [18:03:14] (03CR) 10Catrope: [C: 032] Export publish-short message for mobile [extensions/VisualEditor] (wmf/1.29.0-wmf.21) - 10https://gerrit.wikimedia.org/r/351893 (https://phabricator.wikimedia.org/T164472) (owner: 10Jforrester) [18:03:17] (03CR) 10Catrope: [C: 032] Follow-up 57a06a6: Use the same attribute name on read and on write [extensions/VisualEditor] (wmf/1.29.0-wmf.21) - 10https://gerrit.wikimedia.org/r/351527 (https://phabricator.wikimedia.org/T164054) (owner: 10Jforrester) [18:14:09] (03Merged) 10jenkins-bot: Export publish-short message for mobile [extensions/VisualEditor] (wmf/1.29.0-wmf.21) - 10https://gerrit.wikimedia.org/r/351893 (https://phabricator.wikimedia.org/T164472) (owner: 10Jforrester) [18:19:25] (03Merged) 10jenkins-bot: Follow-up 57a06a6: Use the same attribute name on read and on write [extensions/VisualEditor] (wmf/1.29.0-wmf.21) - 10https://gerrit.wikimedia.org/r/351527 (https://phabricator.wikimedia.org/T164054) (owner: 10Jforrester) [18:33:19] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 07Regression, 15User-Ryasmeen: [Regression] English magic words replaced with opposite localized ones while editing in VE - https://phabricator.wikimedia.org/T164054#3245085 (10Jdforrester-WMF) Now l... [18:33:22] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review, and 2 others: Label not displayed while VEditing on mobile site - https://phabricator.wikimedia.org/T164472#3234723 (10Jdforrester-WMF) Now live in production; sorry all. [18:42:29] I ran into an issue with VE on 1.27.2 where the template suggestions aren't populating [18:43:08] I tracked it down to an API call that's not returning the right data. Or rather it thinks the templates are missing (when they're not) [18:43:13] w/api.php?action=query&format=json&prop=info&generator=prefixsearch&gpssearch=Note&gpsnamespace=10 [18:43:29] Does anybody have any ideas? [18:46:14] edsanders: Do you know where I can find that icon asset? [18:53:06] 10VisualEditor, 06Reading-Web-Backlog, 06Wikipedia-Android-App-Backlog, 06Wikipedia-iOS-App-Backlog, and 3 others: Section collapsing is broken in MobileFrontend - https://phabricator.wikimedia.org/T164733#3245160 (10Jdlrobson) [19:09:42] (03PS1) 10Esanders: Generate visual diff only after switching to visual diff tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/352642 (https://phabricator.wikimedia.org/T164724) [19:19:48] 10VisualEditor, 06Reading-Web-Backlog, 06Wikipedia-Android-App-Backlog, 06Wikipedia-iOS-App-Backlog, and 3 others: Section collapsing is broken in MobileFrontend - https://phabricator.wikimedia.org/T164733#3245288 (10Jdlrobson) [19:20:23] 10VisualEditor, 06Reading-Web-Backlog, 06Wikipedia-Android-App-Backlog, 06Wikipedia-iOS-App-Backlog, and 3 others: Section collapsing is broken in MobileFrontend - https://phabricator.wikimedia.org/T164733#3243455 (10Jdlrobson) @MBinder_WMF can you facilitate an estimation? @ovasileva this should be the to... [19:48:26] 10VisualEditor, 06Reading-Web-Backlog, 06Wikipedia-Android-App-Backlog, 06Wikipedia-iOS-App-Backlog, and 3 others: Section collapsing is broken in MobileFrontend - https://phabricator.wikimedia.org/T164733#3245452 (10MBinder_WMF) @Jdlrobson Happy to. I'm assuming you mean in a face-to-face hangout. The nex... [19:54:07] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 05MW-1.30-release-notes, and 5 others: content-holding
should only contain the page text - https://phabricator.wikimedia.org/T37247#3245466 (10Anomie) 05Open>03Resolved a:03Anomie Note this won't be included in 1.30.0-wmf.1, but should be in... [20:00:03] 10VisualEditor, 06Reading-Web-Backlog, 06Wikipedia-Android-App-Backlog, 06Wikipedia-iOS-App-Backlog, and 2 others: Section collapsing is broken in MobileFrontend - https://phabricator.wikimedia.org/T164733#3245474 (10Jdlrobson) [20:12:58] 10VisualEditor, 10TemplateStyles: Add class mw-parser-output to VE's editing area - https://phabricator.wikimedia.org/T164790#3245493 (10Anomie) [20:23:26] 10VisualEditor, 10Wikimedia-Site-requests: Enable visual editor for the Wikipedia namespace on nl.wikipedia.org - https://phabricator.wikimedia.org/T164435#3245539 (10Jdforrester-WMF) [20:31:30] 10VisualEditor, 10TemplateStyles: Add class mw-parser-output to VE's editing area - https://phabricator.wikimedia.org/T164790#3245559 (10Anomie) Not that I know of, feel free to create a subtask if that's the appropriate way for it to happen. [20:32:19] 10VisualEditor, 06Reading-Admin, 06Reading-Web-Backlog, 06Wikipedia-Android-App-Backlog, and 3 others: Section collapsing is broken in MobileFrontend - https://phabricator.wikimedia.org/T164733#3245560 (10dr0ptp4kt) [20:36:19] (03PS1) 10Esanders: Upgrade tree differ to support timeouts, and handle them [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/352669 (https://phabricator.wikimedia.org/T164724) [20:36:48] 10VisualEditor, 10TemplateStyles: Add class mw-parser-output to VE's editing area - https://phabricator.wikimedia.org/T164790#3245493 (10Jdforrester-WMF) >>! In T164790#3245559, @Anomie wrote: > Not that I know of, feel free to create a subtask if that's the appropriate way for it to happen. Done. > And than... [20:38:38] (03CR) 10Jforrester: Upgrade tree differ to support timeouts, and handle them (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/352669 (https://phabricator.wikimedia.org/T164724) (owner: 10Esanders) [20:40:33] (03CR) 10jerkins-bot: [V: 04-1] Upgrade tree differ to support timeouts, and handle them [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/352669 (https://phabricator.wikimedia.org/T164724) (owner: 10Esanders) [20:40:59] edsanders: Ha! [20:41:08] ? [20:41:13] edsanders: Well, it shows that we're running that code in the unit tests, at least. [20:41:42] edsanders: Your tree patch failed unit tests in CI, presumably because it took too long to diff the tree (and the unit test doesn't cope with that). [20:41:49] hmm [20:41:59] seems unlikely - the tests are very basic [20:42:39] nope, that's something else [20:43:18] nope - it's the timeout [20:43:20] how odd [20:46:12] oh - I have the inequality backwards - it's always timing out [20:46:59] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 05MW-1.30-release-notes, and 5 others: content-holding
should only contain the page text - https://phabricator.wikimedia.org/T37247#386110 (10matmarex) Here's a late annoying question – should contents of page status indicators (` (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/352694 (owner: 10L10n-bot) [21:05:44] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/352701 (owner: 10L10n-bot) [21:11:41] (03CR) 10Esanders: [C: 032] ApiVisualEditor: Move RESTbase initiation from construct() to execute() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/351352 (owner: 10Jforrester) [21:13:58] (03CR) 10Esanders: [C: 04-1] [WIP] ve.dm.ElementLinearData.test: Cover compareElements (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350891 (owner: 10Jforrester) [21:15:06] (03CR) 10Esanders: [C: 04-1] [WIP] ve.dm.ElementLinearData.test: Cover compareElements (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350891 (owner: 10Jforrester) [21:15:35] (03CR) 10Esanders: [C: 032] MobileContext: fix button spacing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350962 (https://phabricator.wikimedia.org/T163473) (owner: 10DLynch) [21:17:55] (03Merged) 10jenkins-bot: MobileContext: fix button spacing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350962 (https://phabricator.wikimedia.org/T163473) (owner: 10DLynch) [21:20:43] (03Merged) 10jenkins-bot: ApiVisualEditor: Move RESTbase initiation from construct() to execute() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/351352 (owner: 10Jforrester) [21:21:47] (03CR) 10jenkins-bot: MobileContext: fix button spacing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/350962 (https://phabricator.wikimedia.org/T163473) (owner: 10DLynch) [21:24:45] (03CR) 10jenkins-bot: ApiVisualEditor: Move RESTbase initiation from construct() to execute() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/351352 (owner: 10Jforrester) [21:42:45] (03PS1) 10Jforrester: Follow-up fa2efb9e5: Also mount the service in ApiVisualEditorEdit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/352712 [21:43:25] edsanders: ^^ Whoops, didn't commit that file change… [21:47:25] (03PS1) 10Jforrester: Update VE core submodule to master (fbeb0db2c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/352713 (https://phabricator.wikimedia.org/T163473) [21:50:40] Hi there. I'm trying to get VE running locally. I did a fresh vagrant install and enable VE role. I see "Error loading data from server: HTTP 503. Would you like to retry?" repeatedly. Where to begin debugging? [21:52:19] (03CR) 10Esanders: [C: 032] Follow-up fa2efb9e5: Also mount the service in ApiVisualEditorEdit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/352712 (owner: 10Jforrester) [21:53:05] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (fbeb0db2c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/352713 (https://phabricator.wikimedia.org/T163473) (owner: 10Jforrester) [21:54:04] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 05MW-1.30-release-notes, and 5 others: content-holding
should only contain the page text - https://phabricator.wikimedia.org/T37247#3245885 (10Nirmos) At svwiki we have - https://sv.wikipedia.org/wiki/MediaWiki:Gadget-ProtectionIndicators.js -... [21:55:57] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (fbeb0db2c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/352713 (https://phabricator.wikimedia.org/T163473) (owner: 10Jforrester) [22:01:25] (03Merged) 10jenkins-bot: Follow-up fa2efb9e5: Also mount the service in ApiVisualEditorEdit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/352712 (owner: 10Jforrester) [22:04:57] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (fbeb0db2c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/352713 (https://phabricator.wikimedia.org/T163473) (owner: 10Jforrester) [22:09:31] (03CR) 10jenkins-bot: Follow-up fa2efb9e5: Also mount the service in ApiVisualEditorEdit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/352712 (owner: 10Jforrester) [23:42:41] (03PS1) 10Jforrester: Follow-up fa2efb9e5 part II: Don't try to call a private function [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/352727 [23:44:26] (03CR) 10Catrope: [C: 032] Follow-up fa2efb9e5 part II: Don't try to call a private function [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/352727 (owner: 10Jforrester) [23:54:21] (03Merged) 10jenkins-bot: Follow-up fa2efb9e5 part II: Don't try to call a private function [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/352727 (owner: 10Jforrester)