[02:43:37] (03PS1) 10Divec: Process transaction before selecting nodes for annotation events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/353830 [03:39:38] (03PS6) 10Divec: TransactionProcessor: modify DM tree branches instead of rebuilding them [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/348450 (https://phabricator.wikimedia.org/T162762) [03:42:57] (03CR) 10jerkins-bot: [V: 04-1] TransactionProcessor: modify DM tree branches instead of rebuilding them [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/348450 (https://phabricator.wikimedia.org/T162762) (owner: 10Divec) [05:05:28] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Regression, 15User-Urbanecm: Source editor fails to load - https://phabricator.wikimedia.org/T165238#3261451 (10Acagastya) @TheDJ, T165132 is due to the New Editor which I did not enable. I am facing this issue when I try to use the old editor. [05:25:35] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Regression, 15User-Urbanecm: Source editor fails to load - https://phabricator.wikimedia.org/T165238#3261534 (10Piramidion) >>! In T165238#3261451, @Acagastya wrote: > @TheDJ, T165132 is due to the New Editor which I did not enable. I am facing... [06:55:49] 10VisualEditor, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review, 07User-notice: Support WMF communities in run-up to switching EditPage over to OOUI - https://phabricator.wikimedia.org/T162849#3261624 (10Whatamidoing-WMF) Johan, I was thinking about either running a simple line in the... [07:05:58] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Regression, 15User-Urbanecm: Source editor fails to load - https://phabricator.wikimedia.org/T165238#3261627 (10Urbanecm) Yeah, seems my steps are for another issue... I expirienced this bug with using OWE only but it behave randomly. I know th... [08:08:41] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs: Editing a page with unflagged changes should edit latest version in VE, even if you view the stable version - https://phabricator.wikimedia.org/T165283#3261893 (10Schnark) [08:23:34] 10VisualEditor, 06Reading-Admin, 06Reading-Web-Backlog, 06Wikipedia-Android-App-Backlog, and 6 others: Section collapsing is broken in MobileFrontend - https://phabricator.wikimedia.org/T164733#3261947 (10phuedx) 05Open>03Resolved a:05ABorbaWMF>03phuedx I've tested this on a handful of articles log... [08:49:13] (03CR) 10Catrope: [C: 032] ve.ui.TableAction: Don't pre-build sequences of transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/353769 (owner: 10Divec) [08:51:29] (03CR) 10Catrope: [C: 032] Process transaction before selecting nodes for annotation events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/353830 (owner: 10Divec) [08:51:57] (03Merged) 10jenkins-bot: ve.ui.TableAction: Don't pre-build sequences of transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/353769 (owner: 10Divec) [08:54:38] (03Merged) 10jenkins-bot: Process transaction before selecting nodes for annotation events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/353830 (owner: 10Divec) [08:55:24] (03CR) 10jenkins-bot: ve.ui.TableAction: Don't pre-build sequences of transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/353769 (owner: 10Divec) [08:56:14] (03PS1) 10Jforrester: Update VE core submodule to master (8e29310db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353838 (https://phabricator.wikimedia.org/T144122) [08:57:00] (03PS11) 10Jforrester: MWTransclusionNode: Implement MWTransclusionTableCell [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/351883 (https://phabricator.wikimedia.org/T144122) (owner: 10DLynch) [08:57:33] (03CR) 10jenkins-bot: Process transaction before selecting nodes for annotation events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/353830 (owner: 10Divec) [08:58:25] 10VisualEditor, 10VisualEditor-Tables, 13Patch-For-Review: Right-click-to-copy doesn't work on templated table cells (because of the shield?) - https://phabricator.wikimedia.org/T144122#3262045 (10Jdforrester-WMF) a:03DLynch [09:01:06] 10Cite: Macedonian Wikipedia needs help with the Cite system - https://phabricator.wikimedia.org/T165290#3262051 (10Elitre) [09:02:36] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Regression, 15User-Urbanecm: Source editor fails to load - https://phabricator.wikimedia.org/T165238#3262081 (10Acagastya) @Piramidion It happens a) everytime VE is selected, and after it loads, cancelled by pressing Escape and clicking on Edit... [09:03:00] 10Cite, 10VisualEditor, 10Wikimedia-Site-requests: Convert reference lists over to `responsive` on mswiki - https://phabricator.wikimedia.org/T165247#3262082 (10Jdforrester-WMF) a:03Jdforrester-WMF [09:03:10] 10Cite, 10VisualEditor, 10Wikimedia-Site-requests: Convert reference lists over to `responsive` on mswiki - https://phabricator.wikimedia.org/T165247#3261136 (10Jdforrester-WMF) p:05Triage>03Normal [09:05:09] 10VisualEditor, 10EasyTimeline: Use large popup panel for timelines in VisualEditor - https://phabricator.wikimedia.org/T165239#3262092 (10Jdforrester-WMF) 05Open>03declined Support for Timeline was Declined in {T29157}, I'm afraid. [09:07:26] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Regression: action=edit in URL doesn't work when NWE is enabled - https://phabricator.wikimedia.org/T165132#3262100 (10Jdforrester-WMF) 05Open>03declined OWE is replaced by the wikitext mode of VE. It wasn't meant to work beforehand, that was... [09:12:10] 10Cite: Macedonian Wikipedia needs help with the Cite system - https://phabricator.wikimedia.org/T165290#3262119 (10Aklapper) That link does not work for me? [09:13:31] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: veaction=editsource in the URL should load new wikitext editor - https://phabricator.wikimedia.org/T165146#3262122 (10Jdforrester-WMF) 05duplicate>03Open p:05Triage>03High Not a dupe. https://www.mediawiki.org/wiki/Special:Random/Template?ve... [09:16:09] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: veaction=editsource in the URL should load new wikitext editor - https://phabricator.wikimedia.org/T165146#3262128 (10Jdforrester-WMF) p:05High>03Unbreak! [09:17:03] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: veaction=editsource in the URL should load new wikitext editor - https://phabricator.wikimedia.org/T165146#3262131 (10Jdforrester-WMF) Similarly https://cs.wikipedia.org/w/index.php?title=Asdasda&action=edit&redlink=1 doesn't trigger. [09:25:25] 10Cite: Macedonian Wikipedia needs help with the Cite system - https://phabricator.wikimedia.org/T165290#3262151 (10Elitre) [09:25:50] 10Cite: Macedonian Wikipedia needs help with the Cite system - https://phabricator.wikimedia.org/T165290#3262051 (10Elitre) Weird, fixed. My Monday morning is messy. [09:26:42] 10VisualEditor, 10VisualEditor-MediaWiki: Invoking VE/NWE from Special:WhatLinksHere doesn't work - https://phabricator.wikimedia.org/T165010#3254141 (10Jdforrester-WMF) `ext.visualEditor.desktopArticleTarget.init` isn't getting loaded for some reason. [09:38:11] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Regression: action=edit in URL doesn't work when NWE is enabled - https://phabricator.wikimedia.org/T165132#3257794 (10Elitre) This remark is probably not really necessary, but James' comment context is "when NWE is enabled, OWE is replaced...",... [09:39:25] 10VisualEditor, 10VisualEditor-MediaWiki: Invoking VE/NWE from Special:WhatLinksHere doesn't work - https://phabricator.wikimedia.org/T165010#3262229 (10Jdforrester-WMF) p:05Triage>03High [09:48:09] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Regression: action=edit in URL doesn't work when NWE is enabled - https://phabricator.wikimedia.org/T165132#3262279 (10Izno) 05declined>03Open [09:48:37] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Regression: action=edit in URL doesn't work when NWE is enabled - https://phabricator.wikimedia.org/T165132#3257794 (10Izno) I am still experiencing an error where *no* editor opens. [09:52:35] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Regression: action=edit in URL doesn't work when NWE is enabled - https://phabricator.wikimedia.org/T165132#3262290 (10Elitre) What happens when you try from different browser/while logged out/with tools and scripts disabled? (I had random issues... [09:58:47] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Regression, 15User-Urbanecm: Source editor fails to load - https://phabricator.wikimedia.org/T165238#3260928 (10geraki) I confirm the same problem exists in elwiki. Users report that they face it //even after// they disabled the beta wikitext e... [10:14:42] (03PS1) 10Jforrester: Enable edit tab setup on appropriate Special pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353849 (https://phabricator.wikimedia.org/T165010) [10:22:30] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Regression: action=edit in URL doesn't work when NWE is enabled - https://phabricator.wikimedia.org/T165132#3262369 (10Tgr) Would it possible to keep the OWE accessible somehow? NWE has enough rough edges that I need to switch back all the time (... [10:30:59] (03PS1) 10Jforrester: Revert "Synchronise VE availability checks in frontend and backend" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353850 [10:31:06] (03CR) 10jerkins-bot: [V: 04-1] Revert "Synchronise VE availability checks in frontend and backend" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353850 (owner: 10Jforrester) [10:33:18] (03PS2) 10Jforrester: Revert "Synchronise VE availability checks in frontend and backend" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353850 [10:36:49] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Regression, 15User-Urbanecm: Source editor fails to load - https://phabricator.wikimedia.org/T165238#3262453 (10Esanders) The issue is with non-singleEditTab wikis, hence not broken on en.wiki. Investigating... [10:43:09] (03Abandoned) 10Esanders: Revert "Synchronise VE availability checks in frontend and backend" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353850 (owner: 10Jforrester) [10:46:21] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Regression, 15User-Urbanecm: Source editor fails to load - https://phabricator.wikimedia.org/T165238#3262475 (10Framawiki) Frwp had this problem too. For user reports, see https://frwp.org/WP:bistro and search 'éditeur'. [10:50:32] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Regression, 15User-Urbanecm: Source editor fails to load on direct non-view page loads where the wiki doesn't have Single Edit Tab enabled - https://phabricator.wikimedia.org/T165238#3262482 (10Jdforrester-WMF) a:03Esanders [10:54:00] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Regression: action=edit in URL doesn't load OWE when NWE is enabled - https://phabricator.wikimedia.org/T165132#3262490 (10Jdforrester-WMF) 05Open>03declined [10:54:32] (03PS1) 10Esanders: Fix action=edit links for NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353854 (https://phabricator.wikimedia.org/T165238) [10:56:42] (03CR) 10Jforrester: [C: 032] Fix action=edit links for NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353854 (https://phabricator.wikimedia.org/T165238) (owner: 10Esanders) [10:56:50] 10VisualEditor, 10WikiEditor, 07Technical-Debt: Kill of most/all the WikiEditor RL modules - https://phabricator.wikimedia.org/T165112#3257307 (10TheDJ) note that CodeEditor does not load all of them. [10:58:41] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Regression: action=edit in URL doesn't load OWE when NWE is enabled - https://phabricator.wikimedia.org/T165132#3262505 (10Schnark) There are actually two ways to force OWE: `?action=submit` or `?action=edit&venoscript=1`, so I don't really mind... [11:03:43] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Regression: action=edit in URL doesn't load OWE when NWE is enabled - https://phabricator.wikimedia.org/T165132#3262552 (10Jdforrester-WMF) >>! In T165132#3262279, @Izno wrote: > I am still experiencing an error where *no* editor opens. Yes, tha... [11:04:30] 10VisualEditor, 10WikiEditor, 07Technical-Debt: Kill of most/all the WikiEditor RL modules - https://phabricator.wikimedia.org/T165112#3262554 (10Jdforrester-WMF) >>! In T165112#3262499, @TheDJ wrote: > note that CodeEditor does not load all of them. CodeEditor shouldn't load //any// of them, but that's a d... [11:06:50] (03Merged) 10jenkins-bot: Fix action=edit links for NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353854 (https://phabricator.wikimedia.org/T165238) (owner: 10Esanders) [11:14:33] (03CR) 10jenkins-bot: Fix action=edit links for NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353854 (https://phabricator.wikimedia.org/T165238) (owner: 10Esanders) [11:34:58] (03PS1) 10Esanders: Always prefer wikitext for action=edit on non-SET wikis [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353858 (https://phabricator.wikimedia.org/T165238) [11:48:38] (03PS2) 10Jforrester: Always prefer wikitext for action=edit on non-SET wikis [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353858 (https://phabricator.wikimedia.org/T165238) (owner: 10Esanders) [11:52:25] (03CR) 10Catrope: [C: 032] Always prefer wikitext for action=edit on non-SET wikis [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353858 (https://phabricator.wikimedia.org/T165238) (owner: 10Esanders) [11:56:35] (03PS1) 10Jforrester: Fix action=edit links for NWE [extensions/VisualEditor] (wmf/1.30.0-wmf.1) - 10https://gerrit.wikimedia.org/r/353861 (https://phabricator.wikimedia.org/T165238) [12:03:07] (03Merged) 10jenkins-bot: Always prefer wikitext for action=edit on non-SET wikis [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353858 (https://phabricator.wikimedia.org/T165238) (owner: 10Esanders) [12:05:44] (03PS1) 10Jforrester: Always prefer wikitext for action=edit on non-SET wikis [extensions/VisualEditor] (wmf/1.30.0-wmf.1) - 10https://gerrit.wikimedia.org/r/353863 (https://phabricator.wikimedia.org/T165238) [12:22:05] (03CR) 10jenkins-bot: Always prefer wikitext for action=edit on non-SET wikis [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353858 (https://phabricator.wikimedia.org/T165238) (owner: 10Esanders) [12:25:22] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: Invoking VE/NWE from Special:WhatLinksHere doesn't work - https://phabricator.wikimedia.org/T165010#3262777 (10Jdforrester-WMF) The "links not working" bit is being fixed in {T165238}; the "there's no VE tab" one is being fixed with this one. [12:25:58] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: VE tab missing from Special:WhatLinksHere etc. - https://phabricator.wikimedia.org/T165010#3262783 (10Jdforrester-WMF) a:03Jdforrester-WMF [13:17:17] (03CR) 10Addshore: [C: 032] Fix action=edit links for NWE [extensions/VisualEditor] (wmf/1.30.0-wmf.1) - 10https://gerrit.wikimedia.org/r/353861 (https://phabricator.wikimedia.org/T165238) (owner: 10Jforrester) [13:17:23] (03CR) 10Addshore: [C: 032] Always prefer wikitext for action=edit on non-SET wikis [extensions/VisualEditor] (wmf/1.30.0-wmf.1) - 10https://gerrit.wikimedia.org/r/353863 (https://phabricator.wikimedia.org/T165238) (owner: 10Jforrester) [13:30:44] (03Merged) 10jenkins-bot: Fix action=edit links for NWE [extensions/VisualEditor] (wmf/1.30.0-wmf.1) - 10https://gerrit.wikimedia.org/r/353861 (https://phabricator.wikimedia.org/T165238) (owner: 10Jforrester) [13:33:25] (03Merged) 10jenkins-bot: Always prefer wikitext for action=edit on non-SET wikis [extensions/VisualEditor] (wmf/1.30.0-wmf.1) - 10https://gerrit.wikimedia.org/r/353863 (https://phabricator.wikimedia.org/T165238) (owner: 10Jforrester) [13:35:32] 10Citoid, 10VisualEditor, 06Services: New param/pattern in service for requesting a single citation based on a unique identifier - https://phabricator.wikimedia.org/T165321#3263001 (10Mvolz) [13:36:13] 10Citoid, 10VisualEditor: Strings of digits currently only search for PMIDs; Add multiple results and include OCLC and PMC in the search - https://phabricator.wikimedia.org/T115248#1719043 (10Mvolz) [13:36:15] 10Citoid, 10VisualEditor, 06Services: New param/pattern in service for requesting a single citation based on a unique identifier - https://phabricator.wikimedia.org/T165321#3263019 (10Mvolz) [13:37:03] 10Citoid, 10VisualEditor, 13Patch-For-Review: Add support for worldcat search api xml results - https://phabricator.wikimedia.org/T162357#3160196 (10Mvolz) [13:37:05] 10Citoid, 10VisualEditor, 06Services: New param/pattern in service for requesting a single citation based on a unique identifier - https://phabricator.wikimedia.org/T165321#3263001 (10Mvolz) [13:37:45] 10Citoid, 10VisualEditor, 06Community-Tech, 06Services: New param/pattern in service for requesting a single citation based on a unique identifier - https://phabricator.wikimedia.org/T165321#3263001 (10Mvolz) [13:38:58] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 05MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 13Patch-For-Review, and 3 others: Source editor fails to load on direct non-view page loads where the wiki doesn't have Single Edit ... - https://phabricator.wikimedia.org/T165238#3263029 [13:40:18] 10Citoid, 10VisualEditor, 06Community-Tech, 10RESTBase-API, and 2 others: New param/pattern in service for requesting a single citation based on a unique identifier - https://phabricator.wikimedia.org/T165321#3263048 (10mobrovac) New endpoints make sense to me, especially in RESTBase. [14:29:45] 10VisualEditor, 10EasyTimeline: Use large popup panel for timelines in VisualEditor - https://phabricator.wikimedia.org/T165239#3263195 (10Tacsipacsi) @Jdforrester-WMF: Then I rephrase the task: Make **all** popups large, //except// the ones that are marked explicitly otherwise. The larger is usually the bette... [15:06:20] 10Citoid, 10VisualEditor, 06Parsing-Team, 06Services, 07Technical-Debt: Restructure so that citoid can be run without Zotero - https://phabricator.wikimedia.org/T93579#3263441 (10Mvolz) >>! In T93579#1925048, @GWicke wrote: > @mobrovac, @ssastry and myself just brainstormed ways to remove the dependency... [15:09:00] (03CR) 10Catrope: [C: 04-1] TransactionProcessor: modify DM tree branches instead of rebuilding them (0321 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/348450 (https://phabricator.wikimedia.org/T162762) (owner: 10Divec) [15:36:21] 10Citoid, 10VisualEditor, 13Patch-For-Review, 15User-Josve05a: Figure out how to deal with incomplete dates, i.e. year only or year and month only - https://phabricator.wikimedia.org/T132308#3263692 (10Mvolz) We've deployed a fix for the year issue; all dates with only a year should now have just a year.... [15:52:09] (03CR) 10Jforrester: TransactionProcessor: modify DM tree branches instead of rebuilding them (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/348450 (https://phabricator.wikimedia.org/T162762) (owner: 10Divec) [16:00:30] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE: HTML title remains "Editing ..." after successful section edit - https://phabricator.wikimedia.org/T165346#3263760 (10Izno) [16:00:52] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE: HTML title remains "Editing ..." after successful section edit - https://phabricator.wikimedia.org/T165346#3263773 (10Izno) [16:10:13] 10Citoid, 10VisualEditor, 13Patch-For-Review, 15User-Josve05a: Figure out how to deal with incomplete dates, i.e. year only or year and month only - https://phabricator.wikimedia.org/T132308#3263787 (10Whatamidoing-WMF) > however, we still have to abide by the style guidelines For the record: No, you don... [16:25:55] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (8e29310db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353838 (https://phabricator.wikimedia.org/T144122) (owner: 10Jforrester) [16:27:15] Woo. [16:29:16] (03CR) 10DLynch: [C: 032] "It'll need an equivalent patch for MWTransclusionNode downstream as well." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/353712 (owner: 10Esanders) [16:30:13] (03CR) 10DLynch: [C: 032] Add class to TableCellableNode and move some styles there [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/353710 (owner: 10Esanders) [16:33:03] (03Merged) 10jenkins-bot: Add class to TableCellableNode and move some styles there [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/353710 (owner: 10Esanders) [16:33:05] (03Merged) 10jenkins-bot: Remove 'cellable' attribute [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/353712 (owner: 10Esanders) [16:35:40] (03PS1) 10Jforrester: Update VE core submodule to master (45aa796b3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353899 (https://phabricator.wikimedia.org/T144122) [16:36:54] Kemayo: Want to build a patch on top of ^^ for MWTransclusionNode? [16:37:31] Kemayo: Or… I could, maybe. :-) [16:37:43] (03CR) 10jenkins-bot: Add class to TableCellableNode and move some styles there [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/353710 (owner: 10Esanders) [16:38:16] (03Merged) 10jenkins-bot: Update VE core submodule to master (8e29310db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353838 (https://phabricator.wikimedia.org/T144122) (owner: 10Jforrester) [16:38:29] James_F: I do have an existing patch touching that whole area, which I'm waiting for Ed to merge. [16:38:49] https://gerrit.wikimedia.org/r/#/c/351883/ [16:38:53] True. Make it a mega-patch? Or several? [16:39:05] I was thinking I'd re-test 351883 and maybe merge it later. [16:39:28] It's probably fair for me to add it to this one. Ed's one I just merged was a reaction to my equivalent patch to core, after all. [16:39:38] * James_F nods. [16:39:40] OK. [16:39:52] (03CR) 10jenkins-bot: Remove 'cellable' attribute [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/353712 (owner: 10Esanders) [16:41:23] (03PS2) 10Jforrester: Update VE core submodule to master (45aa796b3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353899 [16:46:41] (03CR) 10jenkins-bot: Update VE core submodule to master (8e29310db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/353838 (https://phabricator.wikimedia.org/T144122) (owner: 10Jforrester) [16:46:48] 10Citoid, 10VisualEditor: Citoid: several publishers recently missing? - https://phabricator.wikimedia.org/T165105#3263940 (10Albert) One more comment I would like to add; both journals are included in the pubmed database. If it helps these are their specifics: 1) JrId: 22628 JournalTitle: Journal of geophysi... [16:53:13] 10Citoid, 10VisualEditor, 10RESTBase-API, 06Services (watching), 15User-mobrovac: New param/pattern in service for requesting a single citation based on a unique identifier - https://phabricator.wikimedia.org/T165321#3264014 (10MusikAnimal) This doesn't seem to be within our purview [16:57:19] Kemayo, MatmaRex: Meeting? [16:57:31] Starting early? [16:57:33] Oh, it's not even time yet. Sorry. :-) [16:57:36] Apparently. [16:57:44] James_F: sure, but it's in like three minutes :o [16:57:53] Tell Prateek. :-) [17:09:17] (03PS12) 10DLynch: MWTransclusionNode: Implement MWTransclusionTableCell [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/351883 (https://phabricator.wikimedia.org/T144122) [17:10:18] 10Citoid, 10VisualEditor, 10RESTBase-API, 06Services (watching), 15User-mobrovac: New param/pattern in service for requesting a single citation based on a unique identifier - https://phabricator.wikimedia.org/T165321#3264092 (10Mvolz) >>! In T165321#3264014, @MusikAnimal wrote: > This doesn't seem to be... [17:27:08] hi there [17:27:21] I've been getting great support on mediawiki on the support desk https://www.mediawiki.org/wiki/Topic:Tqcpaksxynh43c8w and in the github repo of one stable MediaWiki extension [17:27:34] I'm not getting much response looking for help with the visual editor: https://www.mediawiki.org/wiki/Extension_talk:VisualEditor [17:28:06] I manage lots of open source projects myself - hope I don't come across as pushy :-) just wanted to see if I was asking in the right place [17:31:49] I've got the visual editor working - but there are some corner case issues we're having with IE, iPad and usability that I'd love to chat to someone about ... [17:33:55] this is the site - https://wiki.healthylondon.org [17:34:15] tansaku: that error message doesn't look like it's getting stuck due to slow network or whatever, it looks like a syntax error in the script served by MediaWiki… as if it was corrupted it on the way or something? (or as if it was actually using a syntax that IE11 doesn't accept) [17:38:17] tansaku: if you click on the "load.php (2,329)" in the error message, it will take you to the script that is failing. specifically, IE11 doesn't like this syntax: "for(pair of sendBody.entries())" in the module 'ext.moderation.ajaxhook' (this is part of some other extension you have installed, not VisualEditor) [17:38:50] tansaku: for…of is a relatively new syntax and it won't work outside of most recent browsers. you should file a bug with whatever this extension is, asking them to support IE11. [17:39:32] (in that error message, "2" is the line number and "329" is the column number where the syntax error occurs) [17:52:59] (03CR) 10Esanders: [C: 032] MWTransclusionNode: Implement MWTransclusionTableCell [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/351883 (https://phabricator.wikimedia.org/T144122) (owner: 10DLynch) [18:03:31] MatmaRex: thanks - that's very helpful - I'm discussing with that extension author: https://github.com/edwardspec/mediawiki-moderation/issues/9 [18:05:02] (03Merged) 10jenkins-bot: MWTransclusionNode: Implement MWTransclusionTableCell [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/351883 (https://phabricator.wikimedia.org/T144122) (owner: 10DLynch) [18:05:09] on a more general note, is there a way to have things fail more gracefully? so that if something like this happens the editor switches over to basic? [18:07:11] tansaku: no. if you have a syntax error in your script (and effectively, that's how IE11 treats this), the whole MediaWiki script loading system goes out of whack. we really assume you don't have syntax errors. [18:08:56] MatmaRex: thanks - really great to understand that better - I'll write that all up and add to my issue on the discussion [18:09:29] (03CR) 10jenkins-bot: MWTransclusionNode: Implement MWTransclusionTableCell [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/351883 (https://phabricator.wikimedia.org/T144122) (owner: 10DLynch) [18:10:41] couple of other things are that I notice that popups and drop downs don't work on the iPad, which is fair enough - but I notice that on the wikipedia site the Visual Editor disables those - is there some setting to detect iOS safari and change the functionality? Also I'd be interested in being able to switch off some of the popups generally ... [18:15:06] tansaku: what popups and dropdowns? and how do they "not work", can you describe that in more detail, or file a task? i'm not aware of that issue. [18:15:34] tansaku: Wikimedia wikis use https://www.mediawiki.org/wiki/Extension:MobileFrontend to display a different skin for mobile views, and it has slightly different VisualEditor integration than normal [18:22:28] 10WikiEditor, 10OOjs-UI: &ooui=1 is not preserved after Show preview is clicked - https://phabricator.wikimedia.org/T165237#3264445 (10matmarex) a:03matmarex This would be indeed convenient. Hopefully it'll be a simple change. [18:54:53] 10WikiEditor, 10MediaWiki-Page-editing, 10UI-Standardization: "Cancel" button in action=edit must not look like a red link - https://phabricator.wikimedia.org/T165122#3257618 (10Quiddity) Sidenote, I've seen 3 comments from people that they hadn't realized there was a cancel feature until the link (previousl... [19:17:50] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Editor fails to load in a new tab - https://phabricator.wikimedia.org/T165389#3264823 (10Whatamidoing-WMF) [19:23:10] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-GuidedTour: Turning off VisualEditor's built-in wikitext mode makes inexplicable GuidedTour message go away - https://phabricator.wikimedia.org/T165390#3264858 (10Whatamidoing-WMF) [19:39:52] MatmaRex: I posted about that here: https://www.mediawiki.org/wiki/Topic:Tqcoy1d9m5sbtf1e [19:40:42] if you open the visual editor on an ipad then you don't see any of the usual buttons for the visual editor, and when you save the summary/watch-this-page etc. popup does not appear [19:40:51] on wikipedia main site that it [19:40:59] it/is [19:42:31] if I view out https://wiki.healthylondon.org site on ipad then we see all the dropdowns for hearing, font type, etc. but tapping on them does nothing, and when you save the popup with summary/watch-this-page appears but then clicking on it fails to save - it seems like wikipedia has some special ipad friendly mode for visualeditor which is not enabled by default I think ... but just guessing [19:42:59] tansaku: like i said, Wikimedia wikis use https://www.mediawiki.org/wiki/Extension:MobileFrontend [19:43:21] aha - sorry - missed that in the join/leave haze [19:43:26] although i don't know why the normal mode wouldn't work [19:44:01] that may be specific to my instance and plugins - but big thanks for that mobile front end link - exactly what I was looking for [20:24:30] 10VisualEditor, 10OOjs-UI, 07Browser-Support-Firefox: VE > Insert > Template > Show options: Sidebar has unnecessary scroll on FF - https://phabricator.wikimedia.org/T161798#3143566 (10matmarex) I see a different but similar issue on Windows, I suppose it's because of differences in scrollbar handling. {F80... [20:32:44] 10VisualEditor, 10OOjs-UI, 07Browser-Support-Firefox: VE > Insert > Template > Show options: Sidebar has unnecessary scroll on FF - https://phabricator.wikimedia.org/T161798#3265140 (10matmarex) Hiding and showing the '.oo-ui-outlineControlsWidget' element (applying 'display: none' in the inspector and then... [22:28:57] 10VisualEditor, 10Math, 10Parsoid, 05MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), and 2 others: Extension output is wrapped in
breaking editing in VE and rendering elsewhere - https://phabricator.wikimedia.org/T165139#3258026 (10ssastry) a:05HansVanLeunen>... [23:22:08] 10VisualEditor, 10ExtensionDistributor: VisualEditor REL1_23 is not distributed by ExtensionDistributor - https://phabricator.wikimedia.org/T155076#3265981 (10Legoktm) >>! In T155076#3111939, @Seb35 wrote: > Commit b3e5759 is https://gerrit.wikimedia.org/r/#/c/126908/ which was probably at one time tagged with... [23:42:18] 10VisualEditor, 06Community-Liaisons, 10Wikimedia-Site-requests, 13Patch-For-Review, 07User-notice: Support WMF communities in run-up to switching EditPage over to OOUI - https://phabricator.wikimedia.org/T162849#3177020 (10Platonides) Rather than changing countless uses, and also annoying downstream use...