[03:25:44] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor-VisualDiffs, 05MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), 15User-Ryasmeen: NWE: Links to missing pages should be red in preview (and self-links should be bold) - https://phabricator.wikimedia.org/T153535#3280888 (10D... [04:12:23] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: The New Wikitext Editor lacks of the possibility of previewing an arbitrary page when editing a template - https://phabricator.wikimedia.org/T165933#3280894 (10Agabi10) [05:55:21] (03PS1) 10Divec: Tree modifications: don't presume the tree is in sync with the linear model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354888 [05:57:31] (03CR) 10jerkins-bot: [V: 04-1] Tree modifications: don't presume the tree is in sync with the linear model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354888 (owner: 10Divec) [06:31:46] (03PS2) 10Divec: WIP: When modifying DM tree, don't presume tree/linmod are in sync [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354888 [06:33:50] (03CR) 10jerkins-bot: [V: 04-1] WIP: When modifying DM tree, don't presume tree/linmod are in sync [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354888 (owner: 10Divec) [07:16:25] 10VisualEditor: VisualEditor not saving changes on triple curly braces - https://phabricator.wikimedia.org/T165888#3280947 (10Quiddity) https://www.mediawiki.org/api/rest_v1/page/html/User%3AQuiddity%20(WMF)%2Fsandbox2 [07:17:03] (03CR) 10Divec: [C: 032] "Very nice indeed" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354687 (owner: 10DLynch) [07:20:33] (03Merged) 10jenkins-bot: ui.DebugBar: Transaction log [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354687 (owner: 10DLynch) [07:23:39] (03CR) 10jenkins-bot: ui.DebugBar: Transaction log [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354687 (owner: 10DLynch) [07:57:22] (03PS5) 10Jforrester: CollabPad: Add popstate/teardown handling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354755 (owner: 10Esanders) [07:57:41] (03CR) 10Jforrester: [C: 032] CollabPad: Add popstate/teardown handling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354755 (owner: 10Esanders) [07:57:50] (03PS3) 10Jforrester: Move getWikitextFragment up to Target from ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354869 (owner: 10Esanders) [07:58:08] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354892 (owner: 10L10n-bot) [08:01:00] (03CR) 10Jforrester: [C: 032] Move getWikitextFragment up to Target from ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354869 (owner: 10Esanders) [08:01:38] (03CR) 10Jforrester: [C: 032] rebaser: Move synchronizer/authorList to Target from Target.init [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354870 (owner: 10Esanders) [08:08:50] (03Merged) 10jenkins-bot: CollabPad: Add popstate/teardown handling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354755 (owner: 10Esanders) [08:15:05] (03Merged) 10jenkins-bot: Move getWikitextFragment up to Target from ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354869 (owner: 10Esanders) [08:16:57] (03CR) 10jenkins-bot: CollabPad: Add popstate/teardown handling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354755 (owner: 10Esanders) [08:22:41] (03CR) 10jenkins-bot: Move getWikitextFragment up to Target from ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354869 (owner: 10Esanders) [08:25:22] (03PS1) 10Jforrester: tests: Cover ve.util#isUnattachedCombiningMark [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354900 [08:30:45] (03PS3) 10Jforrester: CollabPad: Move synchronizer/authorList to Target from Target.init [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354870 (owner: 10Esanders) [08:34:29] (03CR) 10Jforrester: [C: 032] CollabPad: Move synchronizer/authorList to Target from Target.init [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354870 (owner: 10Esanders) [08:39:07] (03PS1) 10Catrope: ce.BranchNode: Disconnect model event handlers in destructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354903 [08:39:47] (03PS1) 10Jforrester: Update VE core submodule to master (69d8607cf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354904 [08:42:17] (03PS1) 10Catrope: ce.BranchNode: Handle splices next to text nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354906 [08:48:48] (03Merged) 10jenkins-bot: CollabPad: Move synchronizer/authorList to Target from Target.init [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354870 (owner: 10Esanders) [08:51:49] (03PS1) 10Catrope: ve.Node#attach: set document before root, rather than after [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354908 [08:54:40] (03CR) 10jenkins-bot: CollabPad: Move synchronizer/authorList to Target from Target.init [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354870 (owner: 10Esanders) [08:56:56] (03CR) 10DLynch: [C: 032] ve.Node#attach: set document before root, rather than after [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354908 (owner: 10Catrope) [08:58:19] (03CR) 10DLynch: [C: 04-1] "Can you add a test case that this hits?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354906 (owner: 10Catrope) [09:09:53] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor-VisualDiffs, 05MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), 15User-Ryasmeen: NWE: Links to missing pages should be red in preview (and self-links should be bold) - https://phabricator.wikimedia.org/T153535#2883457 (10T... [09:13:39] (03PS1) 10Amire80: Change "Template preferred format" to "Template code formatting" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/354912 [09:18:46] (03PS1) 10Jforrester: tests: Cover ve.util#sparseSplice edge case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354914 [09:18:49] (03PS1) 10Jforrester: tests: Cover ve.util#getCommonAncestor error case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354915 [09:18:51] (03PS1) 10Jforrester: tests: Cover ve.util#getCommonStartSequenceLength error case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354916 [09:18:53] (03PS1) 10Jforrester: tests: Cover ve.utils#isUriComponentValid and #safeDecodeUriComponent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354917 [09:18:55] (03PS1) 10Jforrester: [FAILING TEST] tests: Cover ve.utils#adjacentDomPosition case with no stop function [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354918 [09:19:22] 10VisualEditor: [Regression pre-wmf.2] Context menu for table is appearing for template node - https://phabricator.wikimedia.org/T165892#3279714 (10DLynch) I don't see this happening: {F8144302} Is it still a problem for you? [09:21:44] 10VisualEditor: [Regression pre-wmf.2] Context menu for table is appearing for template node - https://phabricator.wikimedia.org/T165892#3281366 (10Jdforrester-WMF) 05Open>03stalled [09:23:41] (03CR) 10jerkins-bot: [V: 04-1] [FAILING TEST] tests: Cover ve.utils#adjacentDomPosition case with no stop function [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354918 (owner: 10Jforrester) [09:23:57] (03CR) 10Jforrester: "I'm not sure this is a good idea (but I don't particularly like the current wording)." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/354912 (owner: 10Amire80) [09:34:32] (03PS3) 10Esanders: WIP Export to wikitext dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354871 [09:34:34] (03PS1) 10Esanders: rebaser: Initialize toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354921 [09:34:50] (03CR) 10jerkins-bot: [V: 04-1] WIP Export to wikitext dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354871 (owner: 10Esanders) [09:34:55] (03CR) 10jerkins-bot: [V: 04-1] rebaser: Initialize toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354921 (owner: 10Esanders) [09:45:28] (03PS2) 10Esanders: rebaser: Initialize toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354921 [09:45:30] (03PS4) 10Esanders: WIP Export to wikitext dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354871 [09:47:06] (03CR) 10Jforrester: [C: 04-1] "Still need to update some users." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/350082 (owner: 10Jforrester) [09:49:00] (03PS2) 10Amire80: Change "Template preferred format" to "Template code formatting" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/354912 [10:00:13] (03CR) 10Catrope: [C: 032] rebaser: Initialize toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354921 (owner: 10Esanders) [10:00:48] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (69d8607cf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354904 (owner: 10Jforrester) [10:04:48] (03PS1) 10DLynch: summarizeTransaction: hide null author [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354936 [10:04:51] 10WikiEditor, 10MediaWiki-extensions-LiquidThreads, 07JavaScript: LiquidThreads editor has toolbar displayed twice with different buttons - https://phabricator.wikimedia.org/T165959#3281500 (10matmarex) I blame @Esanders and . [10:18:11] (03CR) 10Jforrester: [C: 032] summarizeTransaction: hide null author [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354936 (owner: 10DLynch) [10:22:21] (03Merged) 10jenkins-bot: summarizeTransaction: hide null author [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354936 (owner: 10DLynch) [10:22:44] (03Merged) 10jenkins-bot: rebaser: Initialize toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354921 (owner: 10Esanders) [10:22:46] (03Merged) 10jenkins-bot: Update VE core submodule to master (69d8607cf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354904 (owner: 10Jforrester) [10:25:35] (03CR) 10Divec: [C: 032] ce.BranchNode: Disconnect model event handlers in destructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354903 (owner: 10Catrope) [10:26:23] (03CR) 10jenkins-bot: summarizeTransaction: hide null author [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354936 (owner: 10DLynch) [10:27:47] (03CR) 10DLynch: [C: 04-1] ce.BranchNode: Disconnect model event handlers in destructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354903 (owner: 10Catrope) [10:27:56] (03CR) 10DLynch: [C: 04-2] ce.BranchNode: Disconnect model event handlers in destructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354903 (owner: 10Catrope) [10:27:59] (03Abandoned) 10Jforrester: ce.BranchNode: Disconnect model event handlers in destructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354903 (owner: 10Catrope) [10:31:21] (03CR) 10jenkins-bot: rebaser: Initialize toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354921 (owner: 10Esanders) [10:32:55] (03PS3) 10Jforrester: Change "Template preferred format" to "Suggested wikitext formatting" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/354912 (owner: 10Amire80) [10:33:02] (03CR) 10Jforrester: [C: 032] Change "Template preferred format" to "Suggested wikitext formatting" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/354912 (owner: 10Amire80) [10:35:49] (03Merged) 10jenkins-bot: Change "Template preferred format" to "Suggested wikitext formatting" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/354912 (owner: 10Amire80) [10:36:00] (03CR) 10jenkins-bot: Change "Template preferred format" to "Suggested wikitext formatting" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/354912 (owner: 10Amire80) [10:38:25] (03CR) 10jenkins-bot: Update VE core submodule to master (69d8607cf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354904 (owner: 10Jforrester) [10:45:24] (03PS6) 10DLynch: Add ve.ce.View#initialize to eliminate constructor/onSetup duplication [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195236 (owner: 10Catrope) [10:45:26] (03PS3) 10DLynch: Render HTML attributes in ce.View#initialize rather than in the constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195238 (owner: 10Catrope) [10:49:56] (03CR) 10jerkins-bot: [V: 04-1] Add ve.ce.View#initialize to eliminate constructor/onSetup duplication [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195236 (owner: 10Catrope) [10:50:31] (03CR) 10jerkins-bot: [V: 04-1] Render HTML attributes in ce.View#initialize rather than in the constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195238 (owner: 10Catrope) [10:52:14] (03PS7) 10DLynch: Add ve.ce.View#initialize to eliminate constructor/onSetup duplication [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195236 (owner: 10Catrope) [10:56:35] (03CR) 10jerkins-bot: [V: 04-1] Add ve.ce.View#initialize to eliminate constructor/onSetup duplication [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195236 (owner: 10Catrope) [11:01:29] (03CR) 10Jforrester: [C: 04-1] "This throws 'DocumentNodes do not exist in the linear model' in the SA demo on load for me." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195238 (owner: 10Catrope) [11:04:39] (03CR) 10Jforrester: [C: 04-1] "Holding for a consistent pattern in OOUI too." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354658 (owner: 10Esanders) [11:05:25] (03PS1) 10Catrope: rebaser: Prevent submissions before initialization [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354949 [11:14:10] 10VisualEditor, 10VisualEditor-DataModel: [Regression pre-.2] Inserting a reference sometimes breaks horribly (due to trees in TransactionProcessor?) - https://phabricator.wikimedia.org/T165965#3281681 (10Jdforrester-WMF) [11:14:55] 10VisualEditor, 10VisualEditor-DataModel: [Regression pre-.2] Inserting a reference sometimes breaks horribly (due to trees in TransactionProcessor?) - https://phabricator.wikimedia.org/T165965#3281711 (10Jdforrester-WMF) [11:15:32] 10VisualEditor, 10VisualEditor-DataModel: [Regression pre-.2] Inserting a reference sometimes breaks horribly (due to trees in TransactionProcessor?) - https://phabricator.wikimedia.org/T165965#3281681 (10Jdforrester-WMF) At some point in the next 24 hours we'll need to either revert the world if we've not fix... [11:20:43] 10WikiEditor, 10MediaWiki-extensions-LiquidThreads, 07JavaScript, 05MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 13Patch-For-Review: LiquidThreads editor has toolbar displayed twice with different buttons - https://phabricator.wikimedia.org/T165959#3281757 (10matmarex) All fixed? [11:30:07] 10VisualEditor, 10WikiEditor, 10MediaWiki-extensions-LiquidThreads, 07JavaScript, and 2 others: LiquidThreads editor has toolbar displayed twice with different buttons - https://phabricator.wikimedia.org/T165959#3281897 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03Esanders Yes, b... [11:44:55] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: The New Wikitext Editor lacks of the possibility of previewing an arbitrary page when editing a template - https://phabricator.wikimedia.org/T165933#3281961 (10Dvorapa) [11:44:57] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-TemplateSandbox: Support "Preview page with this template" (TemplateSandbox) in the new wikitext editor - https://phabricator.wikimedia.org/T153367#3281964 (10Dvorapa) [11:52:57] 10VisualEditor: Fluid tab header - https://phabricator.wikimedia.org/T165979#3282013 (10Juandev) [11:53:53] 10VisualEditor: The preview link for user page in the link dialog doesn't add local wiki domain prefix - https://phabricator.wikimedia.org/T165980#3282025 (10Mooeypoo) [12:01:27] (03PS4) 10DLynch: Render HTML attributes in ce.View#initialize rather than in the constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195238 (owner: 10Catrope) [12:04:58] (03CR) 10jerkins-bot: [V: 04-1] Render HTML attributes in ce.View#initialize rather than in the constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195238 (owner: 10Catrope) [12:10:20] 10VisualEditor: [Regression pre-wmf.2] Context menu for table is appearing for template node - https://phabricator.wikimedia.org/T165892#3282093 (10Ryasmeen) Hmm,. not anymore. [12:14:07] 10VisualEditor: [Regression pre-wmf.2] Context menu for table is appearing for template node - https://phabricator.wikimedia.org/T165892#3279714 (10matmarex) Possibly fixed by https://gerrit.wikimedia.org/r/#/c/354558/ ? [12:22:44] 10VisualEditor: [Regression pre-wmf.2] Random characters are getting inserted in CE after inserting a heading and pressing return - https://phabricator.wikimedia.org/T165985#3282140 (10Ryasmeen) [12:30:24] 10VisualEditor: [Regression pre-wmf.2] Link inspector is opening with a solid grey slug - https://phabricator.wikimedia.org/T165986#3282178 (10Ryasmeen) [12:35:12] 10VisualEditor: [Regression pre-wmf.2] Citation dialog is not opening, error in the console "VM689:647 Uncaught TypeError: Cannot read property 'getDocumentNode' of null" - https://phabricator.wikimedia.org/T165987#3282212 (10Ryasmeen) [12:36:47] (03PS1) 10Jforrester: Revert "TransactionProcessor: modify DM tree branches instead of rebuilding them" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354966 (https://phabricator.wikimedia.org/T165965) [12:39:58] 10VisualEditor: [Regression pre-wmf.2] Citation dialog is not opening, error in the console "VM689:647 Uncaught TypeError: Cannot read property 'getDocumentNode' of null" - https://phabricator.wikimedia.org/T165987#3282239 (10Jdforrester-WMF) p:05Triage>03Unbreak! [12:41:40] 10VisualEditor: [Regression pre-wmf.2] Link inspector is opening with a solid grey slug - https://phabricator.wikimedia.org/T165986#3282275 (10Jdforrester-WMF) p:05Triage>03Unbreak! [12:41:52] 10VisualEditor: [Regression pre-wmf.2] Getting error "Uncaught TypeError: Cannot read property 'getSurface' of null" after indenting bullet/number list - https://phabricator.wikimedia.org/T165990#3282280 (10Ryasmeen) [12:42:04] 10VisualEditor: [Regression pre-wmf.2] Random characters are getting inserted in CE after inserting a heading and pressing return - https://phabricator.wikimedia.org/T165985#3282305 (10Jdforrester-WMF) p:05Triage>03Unbreak! [12:42:56] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10VisualEditor-Tables, 05MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 15User-Ryasmeen: [Regression pre-wmf.2] Context menu for table is appearing for template node - https://phabricator.wikimedia.org/T165892#3282310 (10Jdforrester-WMF)... [12:43:38] 10VisualEditor: [Regression pre-wmf.2] Getting error "Uncaught TypeError: Cannot read property 'getSurface' of null" after indenting bullet/number list - https://phabricator.wikimedia.org/T165990#3282330 (10Jdforrester-WMF) p:05Triage>03Unbreak! [12:46:07] (03PS8) 10DLynch: Add ve.ce.View#initialize to eliminate constructor/onSetup duplication [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195236 (owner: 10Catrope) [12:46:42] 10VisualEditor: [Regression pre-wmf.2] Link inspector is opening with a solid grey slug - https://phabricator.wikimedia.org/T165986#3282369 (10Ryasmeen) Also, happens while adding the template. [13:05:00] (03CR) 10Jforrester: [C: 032] Add ve.ce.View#initialize to eliminate constructor/onSetup duplication [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195236 (owner: 10Catrope) [13:05:07] (03PS5) 10Jforrester: Render HTML attributes in ce.View#initialize rather than in the constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195238 (owner: 10Catrope) [13:05:30] (03CR) 10Jforrester: [C: 032] Render HTML attributes in ce.View#initialize rather than in the constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195238 (owner: 10Catrope) [13:06:10] 10VisualEditor, 10VisualEditor-ContentEditable: [Regression pre-wmf.2] Link inspector is opening with a solid grey disabled selection in a slug - https://phabricator.wikimedia.org/T165986#3282507 (10Jdforrester-WMF) [13:09:08] (03Merged) 10jenkins-bot: Add ve.ce.View#initialize to eliminate constructor/onSetup duplication [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195236 (owner: 10Catrope) [13:09:15] (03Merged) 10jenkins-bot: Render HTML attributes in ce.View#initialize rather than in the constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195238 (owner: 10Catrope) [13:12:36] (03CR) 10jenkins-bot: Add ve.ce.View#initialize to eliminate constructor/onSetup duplication [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195236 (owner: 10Catrope) [13:14:29] (03PS1) 10Jforrester: Revert "Upgrade to jQuery v3" until OOjs UI is fully compatible [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354977 [13:16:14] (03CR) 10jenkins-bot: Render HTML attributes in ce.View#initialize rather than in the constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195238 (owner: 10Catrope) [13:17:55] 10VisualEditor: [Regression pre-wmf.2] Getting error "Uncaught TypeError: Cannot read property 'getSurface' of null" after indenting bullet/number list - https://phabricator.wikimedia.org/T165990#3282569 (10Jdforrester-WMF) [13:17:57] 10VisualEditor, 10VisualEditor-ContentEditable: [Regression pre-wmf.2] Link inspector is opening with a solid grey disabled selection in a slug - https://phabricator.wikimedia.org/T165986#3282571 (10Jdforrester-WMF) [13:17:59] 10VisualEditor: [Regression pre-wmf.2] Random characters are getting inserted in CE after inserting a heading and pressing return - https://phabricator.wikimedia.org/T165985#3282572 (10Jdforrester-WMF) [13:18:01] 10VisualEditor: [Regression pre-wmf.2] Citation dialog is not opening, error in the console "VM689:647 Uncaught TypeError: Cannot read property 'getDocumentNode' of null" - https://phabricator.wikimedia.org/T165987#3282570 (10Jdforrester-WMF) [13:18:18] (03CR) 10DLynch: [C: 032] "Okay, okay, we can work out a test later so this actually gets merged." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354906 (owner: 10Catrope) [13:22:52] (03Merged) 10jenkins-bot: ce.BranchNode: Handle splices next to text nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354906 (owner: 10Catrope) [13:23:36] (03Merged) 10jenkins-bot: ve.Node#attach: set document before root, rather than after [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354908 (owner: 10Catrope) [13:42:36] (03CR) 10Divec: [C: 032] RebaseServer: When rejecting, publish the top of the history instead of the top of the rejected change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354702 (owner: 10Catrope) [13:42:44] (03PS1) 10Jforrester: Update VE core submodule to master (7aab1c6ba) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354984 [13:42:55] (03CR) 10jenkins-bot: ce.BranchNode: Handle splices next to text nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354906 (owner: 10Catrope) [13:43:14] (03CR) 10Divec: [C: 032] rebaser: Prevent submissions before initialization [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354949 (owner: 10Catrope) [13:45:13] (03CR) 10jenkins-bot: ve.Node#attach: set document before root, rather than after [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354908 (owner: 10Catrope) [13:45:32] (03Merged) 10jenkins-bot: RebaseServer: When rejecting, publish the top of the history instead of the top of the rejected change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354702 (owner: 10Catrope) [13:47:38] (03Merged) 10jenkins-bot: rebaser: Prevent submissions before initialization [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354949 (owner: 10Catrope) [13:49:22] (03PS2) 10Jforrester: Update VE core submodule to master (c00d2fa38) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354984 [13:59:15] (03CR) 10Jforrester: "In local testing, this appears to fix T165985, and doesn't fix T165986 or T165990; didn't test T165965 or T165987." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354984 (owner: 10Jforrester) [14:00:12] (03CR) 10jenkins-bot: RebaseServer: When rejecting, publish the top of the history instead of the top of the rejected change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354702 (owner: 10Catrope) [14:01:08] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-DataModel: [Regression pre-wmf.2] Random characters are getting inserted in CE after inserting a heading and pressing return - https://phabricator.wikimedia.org/T165985#3282140 (10Jdforrester-WMF) [14:03:22] (03CR) 10jenkins-bot: rebaser: Prevent submissions before initialization [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354949 (owner: 10Catrope) [14:03:28] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (c00d2fa38) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354984 (owner: 10Jforrester) [14:06:20] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (c00d2fa38) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354984 (owner: 10Jforrester) [14:09:20] (03CR) 10Jforrester: [V: 032] Update VE core submodule to master (c00d2fa38) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354984 (owner: 10Jforrester) [14:11:58] 10VisualEditor, 10VisualEditor-DataModel, 15User-Ryasmeen: [Regression pre-wmf.2] Citation dialog is not opening, error in the console "VM689:647 Uncaught TypeError: Cannot read property 'getDocumentNode' of null" - https://phabricator.wikimedia.org/T165987#3282700 (10Jdforrester-WMF) 05Open>03Resolved a... [14:12:57] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-DataModel, 15User-Ryasmeen: [Regression pre-wmf.2] Random characters are getting inserted in CE after inserting a heading and pressing return - https://phabricator.wikimedia.org/T165985#3282708 (10Jdforrester-WMF) 05Open>03Resolved a:03Cat... [14:15:58] (03CR) 10jenkins-bot: Update VE core submodule to master (c00d2fa38) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354984 (owner: 10Jforrester) [14:32:43] (03PS1) 10Jforrester: Follow-up 7e72163ea: Fix CBN alien unit test I missed and force-merged [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354994 [14:33:43] (03CR) 10Bartosz Dziewoński: [C: 032] "Bad James." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354994 (owner: 10Jforrester) [14:33:55] (03CR) 10DLynch: [C: 032] Follow-up 7e72163ea: Fix CBN alien unit test I missed and force-merged [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354994 (owner: 10Jforrester) [14:35:39] MatmaRex_mobile: Ho-hum. :-) [14:36:17] James_F: isn't it always me arguing to force-merge things, and you arguing to wait for tests to be fixed up? ;) [14:37:17] MatmaRex_mobile: When there aren 5 UBN bugs in master the day before the train I take a different approach. :-) [14:40:33] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Unit-tests: Flaky VisualEditor QUnit test: ve.ce.ContentBranchNode (MW) - https://phabricator.wikimedia.org/T166009#3282754 (10Krinkle) [14:41:58] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Unit-tests: Flaky VisualEditor QUnit test: ve.ce.ContentBranchNode (MW) - https://phabricator.wikimedia.org/T166009#3282769 (10Jdforrester-WMF) 05Open>03Invalid It's not a regression, it's us making a breaking change in VE, now papered over. Jenkins d... [15:05:27] (03Merged) 10jenkins-bot: Follow-up 7e72163ea: Fix CBN alien unit test I missed and force-merged [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354994 (owner: 10Jforrester) [15:11:48] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Unit-tests: Flaky VisualEditor QUnit test: ve.ce.ContentBranchNode (MW) - https://phabricator.wikimedia.org/T166009#3282754 (10Paladox) I am too experiencing this on https://gerrit.wikimedia.org/r/#/c/193434/122 [15:14:22] (03CR) 10jenkins-bot: Follow-up 7e72163ea: Fix CBN alien unit test I missed and force-merged [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354994 (owner: 10Jforrester) [15:26:47] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: Single Edit Tab global default change - https://phabricator.wikimedia.org/T159032#3282894 (10Alsee) >>! In T159032#3184818, @Halibutt wrote: >> The WMF ran a controlled study on the effects of visual editor, showing that it provided zero be... [15:36:30] 10Cite, 06TCB-Team: Implement "extends"-attribute for ref-tag - https://phabricator.wikimedia.org/T151301#3282925 (10Lea_WMDE) [15:37:15] 10Cite, 06TCB-Team: Implement "extends"-attribute for ref-tag - https://phabricator.wikimedia.org/T151301#2813616 (10Lea_WMDE) [17:48:28] (03PS1) 10Fomafix: Add parameter useskin to action=parse for live preview [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/355008 [19:31:04] 10Cite, 07Community-Wishlist-Survey-2015, 07German-Community-Wishlist-Main-Wishes, 06TCB-Team (Oct2016-March2017): Efficient way to refer to different pages of the same work when adding references to an article (#17) - https://phabricator.wikimedia.org/T100645#3283136 (10Lea_WMDE) a:05Sophivorus>03None [19:32:02] 10Cite, 10VisualEditor, 06TCB-Team, 07German-Community-Wishlist: Make VisualEditor compatible with "extends" parameter - https://phabricator.wikimedia.org/T151308#3283139 (10Lea_WMDE) [19:33:10] 10Cite, 06TCB-Team, 06WMDE-Design, 07Design: Error handling for "extends" parameter - https://phabricator.wikimedia.org/T151305#3283142 (10Lea_WMDE) [19:34:52] 10Cite, 06TCB-Team, 06WMDE-Design, 07Design: Error handling for "extends" parameter - https://phabricator.wikimedia.org/T151305#2813680 (10Lea_WMDE) [19:34:57] 10Cite, 06TCB-Team: Implement "extends"-attribute for ref-tag - https://phabricator.wikimedia.org/T151301#3283144 (10Lea_WMDE) [19:35:46] 10Cite, 10Parsoid, 06TCB-Team, 07RfC: Possibility to refine existing , e.g. reference individual pages in a book - https://phabricator.wikimedia.org/T138601#3283146 (10Lea_WMDE) [19:35:48] 10Cite, 07Community-Wishlist-Survey-2015, 07German-Community-Wishlist-Main-Wishes, 06TCB-Team (Oct2016-March2017): Efficient way to refer to different pages of the same work when adding references to an article (#17) - https://phabricator.wikimedia.org/T100645#3283147 (10Lea_WMDE) [19:36:10] 10Cite, 10Parsoid, 06TCB-Team, 07RfC: Possibility to refine existing , e.g. reference individual pages in a book - https://phabricator.wikimedia.org/T138601#2405038 (10Lea_WMDE) [19:36:12] 10Cite, 07Community-Wishlist-Survey-2015, 07German-Community-Wishlist-Main-Wishes, 06TCB-Team (Oct2016-March2017): Efficient way to refer to different pages of the same work when adding references to an article (#17) - https://phabricator.wikimedia.org/T100645#1336808 (10Lea_WMDE) [19:39:23] 10Cite, 07Community-Wishlist-Survey-2015, 07German-Community-Wishlist-Main-Wishes, 06TCB-Team (Oct2016-March2017): Efficient way to refer to different pages of the same work when adding references to an article (#17) - https://phabricator.wikimedia.org/T100645#3283154 (10Lea_WMDE) [19:39:27] 10Cite, 10Parsoid, 06TCB-Team, 07RfC: Possibility to refine existing , e.g. reference individual pages in a book - https://phabricator.wikimedia.org/T138601#3283150 (10Lea_WMDE) 05Open>03Invalid This task was the basis for an updated solution, which can be found in {T151301} [19:40:48] 10Cite, 06TCB-Team, 06WMDE-Design, 07Design: Error handling for "extends" parameter - https://phabricator.wikimedia.org/T151305#3283156 (10Lea_WMDE) [19:40:52] 10Cite, 06TCB-Team: Implement "extends"-attribute for ref-tag - https://phabricator.wikimedia.org/T151301#2813616 (10Lea_WMDE) [20:59:32] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/355046 (owner: 10L10n-bot) [21:05:38] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/355052 (owner: 10L10n-bot) [22:22:59] (03CR) 10Krinkle: [C: 032] "Thanks!" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/355008 (owner: 10Fomafix) [22:26:27] (03Merged) 10jenkins-bot: Add parameter useskin to action=parse for live preview [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/355008 (owner: 10Fomafix)