[06:04:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/355998 (owner: 10L10n-bot) [10:06:07] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Shortcut keyboard for adding signature - https://phabricator.wikimedia.org/T166494#3297794 (10Elitre) [10:09:54] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Shortcut keyboard for adding signature - https://phabricator.wikimedia.org/T166494#3297794 (10Dvorapa) Maybe should also be suggested to OWE [10:20:02] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Shortcut keyboard for adding signature - https://phabricator.wikimedia.org/T166494#3297838 (10Schnark) I don't think this should be considered as //alternative// to T153255. One reason (among others) why a more visible button is wanted, is to make it... [10:48:08] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Shortcut keyboard for adding signature - https://phabricator.wikimedia.org/T166494#3297938 (10Dvorapa) I agree with @Schnark that mainly for novice users signature button presence and highlighting among others is crucial in discussions. Why not just... [10:51:24] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Promote the signature button to the toolbar (or somewhere else more prominent) in VE/NWE - https://phabricator.wikimedia.org/T153255#3297953 (10Dvorapa) I agree with @Schnark. Btw why not just port the current functionality from OWE, where this works... [12:45:17] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Shortcut keyboard for adding signature - https://phabricator.wikimedia.org/T166494#3298248 (10Kaartic) [13:30:02] 10TemplateData, 10VisualEditor, 10Wikidata: Template to ping everybody who participated in a discussion - https://phabricator.wikimedia.org/T165600#3298309 (10ChristianKl) I don't see a reason why VisualEditor should be tagged. If Template is the wrong group to ping for issues about templates I'm sorry. [14:12:48] (03CR) 10Esanders: [C: 04-1] "Also this renders the entire reference list, if changed. We should only show references which have been changed, and possibly the referenc" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/355716 (https://phabricator.wikimedia.org/T162819) (owner: 10Tchanders) [14:18:24] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links: Links sometimes point to /w/Pagename instead of /wiki/Pagename - https://phabricator.wikimedia.org/T166333#3292905 (10Esanders) I get a properly resolved URL in the CE using Ubuntu + Chrome/Firefox: ``` lang=css (03Merged) 10jenkins-bot: tests: Cover ve.util#isUnattachedCombiningMark [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354900 (owner: 10Jforrester) [15:06:40] (03CR) 10Esanders: [C: 04-1] tests: Cover ve.util#getCommonAncestor error case (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354915 (owner: 10Jforrester) [15:08:08] (03CR) 10jenkins-bot: tests: Cover ve.util#isUnattachedCombiningMark [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354900 (owner: 10Jforrester) [15:09:41] (03CR) 10Esanders: [C: 04-1] tests: Cover ve.util#getCommonStartSequenceLength error case (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354916 (owner: 10Jforrester) [15:10:24] (03CR) 10Esanders: [C: 04-1] tests: Cover ve.utils#isUriComponentValid and #safeDecodeUriComponent (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354917 (owner: 10Jforrester) [15:10:56] (03CR) 10Esanders: [C: 031] "Leaving to David C as he wrote this." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354914 (owner: 10Jforrester) [15:25:28] (03PS2) 10Divec: tests: Cover ve.util#sparseSplice edge case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354914 (owner: 10Jforrester) [15:26:32] (03CR) 10Divec: [C: 031] "+2 to everything but my tweak" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354914 (owner: 10Jforrester) [15:33:45] (03CR) 10Divec: tests: Cover ve.util#getCommonAncestor error case (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354915 (owner: 10Jforrester) [15:45:10] (03PS2) 10Divec: tests: Cover ve.util#getCommonAncestor error case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354915 (owner: 10Jforrester) [15:47:25] (03CR) 10Divec: tests: Cover ve.util#getCommonStartSequenceLength error case (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354916 (owner: 10Jforrester) [15:54:33] (03PS2) 10Divec: tests: Cover ve.util#getCommonStartSequenceLength zero sequences case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354916 (owner: 10Jforrester) [15:56:24] (03PS3) 10Divec: tests: Cover ve.util#getCommonAncestor zero node case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354915 (owner: 10Jforrester) [16:09:07] 10VisualEditor, 10OOjs-UI, 07Regression: Can't use LanguageInputWidget after update to jQuery 3 - https://phabricator.wikimedia.org/T166152#3298652 (10Volker_E) p:05Triage>03High [16:09:20] 10VisualEditor, 10OOjs-UI, 07Regression: Template dialog doesn't focus input after update to jQuery 3 - https://phabricator.wikimedia.org/T166150#3298657 (10Volker_E) p:05Triage>03Normal [16:34:20] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 06Community-Liaisons (Apr-Jun 2017): Make a list of wikis that will probably want to have enabled by default - https://phabricator.wikimedia.org/T160971#3298697 (10Quiddity) [17:52:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: Single Edit Tab global default change - https://phabricator.wikimedia.org/T159032#3054961 (10Deskana) >>! In T159032#3293776, @Alsee wrote: > @Halibutt @Jdforrester-WMF: > > I just collected data using the Recent Changes page, set to displ... [17:53:14] 10TemplateData, 10VisualEditor: TemplateData's GUI editor should warn about duplicate parameters - https://phabricator.wikimedia.org/T166520#3298834 (10Whatamidoing-WMF) [18:41:18] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Page-editing: Missung Summary: $1 is not replaced properley - https://phabricator.wikimedia.org/T166478#3298881 (10matmarex) a:03matmarex [18:45:32] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Page-editing: Missing Summary: $1 is not replaced properly - https://phabricator.wikimedia.org/T166478#3298885 (10Aklapper) [18:54:09] 10VisualEditor: Step through the category tree when adding or editing categories, similar to how HotCat works - https://phabricator.wikimedia.org/T166521#3298895 (10Whatamidoing-WMF) [18:55:06] 10VisualEditor: Step through the category tree when adding or editing categories, similar to how HotCat works - https://phabricator.wikimedia.org/T166521#3298911 (10Whatamidoing-WMF) [19:14:21] (03CR) 10Esanders: [C: 032] tests: Cover ve.util#getCommonAncestor zero node case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354915 (owner: 10Jforrester) [19:14:21] 10Citoid, 10VisualEditor: Merge together the results from Zotero and the fallback HTML scaper? - https://phabricator.wikimedia.org/T166297#3291385 (10mobrovac) Apart from the concrete Telegraph case discussed in the comments, I think it would be valuable to consider the general question posed in this task's ti... [19:14:37] 10TemplateData, 10VisualEditor: Add a template type property (or field) to TemplateData - https://phabricator.wikimedia.org/T166525#3298956 (10Whatamidoing-WMF) [19:14:55] (03CR) 10Esanders: [C: 032] tests: Cover ve.util#sparseSplice edge case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354914 (owner: 10Jforrester) [19:15:35] (03CR) 10Esanders: [C: 032] tests: Cover ve.util#getCommonStartSequenceLength zero sequences case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354916 (owner: 10Jforrester) [19:16:13] (03PS1) 10Bartosz DziewoƄski: VisualEditorDataModule: Pass save/publish button label to 'missingsummary' message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356078 (https://phabricator.wikimedia.org/T166478) [19:18:06] (03Merged) 10jenkins-bot: tests: Cover ve.util#sparseSplice edge case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354914 (owner: 10Jforrester) [19:19:02] 10VisualEditor: No way identify empty nodes (space or blank, such as ) added by extension tags - https://phabricator.wikimedia.org/T166526#3298973 (10Whatamidoing-WMF) [19:21:12] (03CR) 10jenkins-bot: tests: Cover ve.util#sparseSplice edge case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354914 (owner: 10Jforrester) [19:41:24] 10Citoid, 10VisualEditor, 10RESTBase: Citoid confuses DOI with URL in production - https://phabricator.wikimedia.org/T165105#3298992 (10mobrovac) [19:45:38] 10Citoid, 10VisualEditor, 06Services (doing), 15User-mobrovac: Citoid confuses DOI with URL in production - https://phabricator.wikimedia.org/T165105#3298993 (10mobrovac) For some reason, Citoid in production resolves the given input as a URL instead of a DOI. Issuing a query for `localhost:1970/api?format... [21:38:24] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356114 (owner: 10L10n-bot) [21:46:39] 10Citoid, 10VisualEditor, 06Services (doing), 15User-mobrovac: Citoid confuses DOI with URL in production - https://phabricator.wikimedia.org/T165105#3299077 (10mobrovac) Full debug log from production: ``` [2017-05-29T21:45:22.883Z] INFO: citoid/17369 on scb1002: Worker 17369 listening on 0.0.0.0:1977 (...