[00:12:53] Everyone, I have no idea if you'll actually see this, but I'm at an editathon and people are absolutely loving the automatic citation generation in VE. [00:12:56] So good job. [00:13:06] Y'all are doing good stuff. [00:16:41] yay Isarra [00:19:06] <3 [00:22:16] 10VisualEditor, 06Editing-Department, 10MediaWiki-General-or-Unknown, 10OOjs-UI, 13Patch-For-Review: Update extensions for removal of core icon pack in OOjs UI v0.22 - https://phabricator.wikimedia.org/T166730#3306525 (10Jdforrester-WMF) [00:22:20] 10VisualEditor, 06Collaboration-Team-Triage, 06Editing-Department, 10Flow, and 2 others: Flow tries to use the now-deleted icon "remove"; should use "trash" from the 'moderation' pack - https://phabricator.wikimedia.org/T166742#3306521 (10Jdforrester-WMF) 05Open>03Resolved a:03Catrope [00:36:26] (03PS4) 10Jforrester: Update VE core submodule to master (8be817396) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356451 (owner: 10Esanders) [00:44:23] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (8be817396) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356451 (owner: 10Esanders) [00:48:55] (03PS5) 10Jforrester: Update VE core submodule to master (8be817396) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356451 (owner: 10Esanders) [00:49:15] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/356501/ [00:49:41] (03CR) 10Catrope: [C: 032] Replace uses of the removed 'remove' icon with the 'trash' one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356501 (https://phabricator.wikimedia.org/T166730) (owner: 10Jforrester) [01:03:42] (03Merged) 10jenkins-bot: Replace uses of the removed 'remove' icon with the 'trash' one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356501 (https://phabricator.wikimedia.org/T166730) (owner: 10Jforrester) [01:04:48] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (8be817396) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356451 (owner: 10Esanders) [01:14:03] (03CR) 10jenkins-bot: Replace uses of the removed 'remove' icon with the 'trash' one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356501 (https://phabricator.wikimedia.org/T166730) (owner: 10Jforrester) [01:16:43] (03Merged) 10jenkins-bot: Update VE core submodule to master (8be817396) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356451 (owner: 10Esanders) [01:23:43] (03CR) 10jenkins-bot: Update VE core submodule to master (8be817396) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356451 (owner: 10Esanders) [02:33:11] 10VisualEditor: VE startup crashes on [[mw:Manual:FAQ]], probably due to tag - https://phabricator.wikimedia.org/T166754#3306634 (10Catrope) [03:08:22] 10VisualEditor, 10VisualEditor-VisualDiffs: JS error when trying to view visual diff after switching from source to visual with new annotation - https://phabricator.wikimedia.org/T166755#3306660 (10Catrope) [03:26:32] 10VisualEditor, 10VisualEditor-VisualDiffs: JS error when trying to view visual diff after switching from source to visual with new annotation - https://phabricator.wikimedia.org/T166755#3306674 (10Catrope) In beta labs, I can reproduce this on a simple [[https://en.wikipedia.beta.wmflabs.org/wiki/User:RoanKat... [05:29:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/356524 (owner: 10L10n-bot) [08:57:45] Hello! Does anyone here have experience with setting up Visual Editor on MediaWiki 1.28.2? (VE Version: 0.1.0 (93528b7)) - I could swear I've done everything right, but all it does when you click the web edit button is Popup with: Error loading data from server: Could not connect to the server. Would you like to retry? [09:04:44] mcmonkey: that sounds like restbase/parsoid isn't working: https://www.mediawiki.org/wiki/Parsoid/Setup [09:05:32] mvolz: both /seem/ to work: curling their addresses gets results - restbase returns the main page when I curl the main page, parsoids localhost:8142 curl returns some random info on the API of parsoid [09:08:12] Hmm, have you tried looking at the network response in your browser's developer tools? [09:08:19] To get a more specific error [09:09:10] https://www.mediawiki.org/wiki/Parsoid/Troubleshooting#Configuration [09:10:14] 10VisualEditor, 06Editing-Department, 07Epic, 07Mobile, 07User-notice: [EPIC] Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#3306921 (10Elitre) Probably the tasks for CLs hasn't been filed yet? (I thought... [09:11:28] huh [09:11:48] so, restbase is configured to be accessed by the user, not the server php? [09:12:04] Apparently I'm sending a request to localhost from my browser, if I'm reading this debug correctly [09:14:35] Ay and that's all that went wrong! [09:17:38] I really oughtta learn browser tools better - I'm not a webdev, I'm just trying to install a wiki on request by a person for a thing. Thanks for knocking me on the head with a bit of direction-to-look-in, mvolz ! Works perfectly now :) [09:18:27] Great, yw :) [09:19:59] 10VisualEditor, 06Editing-Department, 07Epic, 07Mobile, 07User-notice: [EPIC] Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#3306957 (10Elitre) [09:20:42] 10VisualEditor, 06Community-Liaisons (Jul-Sep 2017): CL support to JS-less editing change - https://phabricator.wikimedia.org/T166767#3306943 (10Elitre) [09:37:32] 10Citoid, 10VisualEditor, 06Services (watching), 15User-mobrovac: Citoid icinga alert /api (open graph via native scraper) is CRITICAL: Test open graph via native scraper returned the unexpected status 404 (expecting: 200) - https://phabricator.wikimedia.org/T163986#3306973 (10Mvolz) a:03Mvolz [09:39:13] 10Citoid, 10VisualEditor, 06Services (watching), 15User-mobrovac: Revamp spec.yaml in citoid - https://phabricator.wikimedia.org/T163986#3217190 (10Mvolz) p:05Triage>03Normal [09:48:16] 10VisualEditor, 10VisualEditor-MediaWiki: Provide a keyboard shortcut for adding signature - https://phabricator.wikimedia.org/T166494#3306984 (10Elitre) Yes. So the S looks taken for so many other purposes. H for Handwriting? X as it's both used to mark the place where a signature goes and for a signature rep... [10:10:05] 10Citoid, 10VisualEditor, 13Patch-For-Review, 06Services (watching), 15User-mobrovac: Revamp spec.yaml in citoid - https://phabricator.wikimedia.org/T163986#3307011 (10Mvolz) Note this patch only replaces pbs.org with example.com. We could certainly try to scrape something we host ourselves... is our upt... [10:12:15] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Promote the signature button to the toolbar (or somewhere else more prominent) in VE/NWE - https://phabricator.wikimedia.org/T153255#3307012 (10Elitre) (If this ever worked "like a charm", we wouldn't have to remind that it exists all the time, or bo... [10:20:10] 10VisualEditor, 10VisualEditor-MediaWiki: Provide a keyboard shortcut for adding signature - https://phabricator.wikimedia.org/T166494#3297794 (10Deskana) It's generally helpful to consider other editors similar to ours that might've set a standard we can reuse. I can't think of any that have similar functiona... [10:54:45] 10VisualEditor: VE startup crashes on [[mw:Manual:FAQ]], probably due to tag - https://phabricator.wikimedia.org/T166754#3307081 (10Mainframe98) [12:32:56] 10VisualEditor, 06Release-Engineering-Team (Kanban), 15User-Ryasmeen, 15User-zeljkofilipin: LanguageScreenshotBot trying to edit a non-existent page without signing in - https://phabricator.wikimedia.org/T162454#3307285 (10Elitre) >>! In T162454#3299805, @zeljkofilipin wrote: >>>! In T162454#3267294, @Jeff... [12:45:18] (03PS1) 10Esanders: Add missing icon sets to rebaser demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/356579 [12:47:57] (03CR) 10Jforrester: [C: 032] "We should automate this like all the others." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/356579 (owner: 10Esanders) [12:50:40] (03Merged) 10jenkins-bot: Add missing icon sets to rebaser demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/356579 (owner: 10Esanders) [12:52:50] (03CR) 10jenkins-bot: Add missing icon sets to rebaser demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/356579 (owner: 10Esanders) [12:54:45] 10VisualEditor: VE startup crashes on [[mw:Manual:FAQ]], probably due to tag - https://phabricator.wikimedia.org/T166754#3306634 (10Esanders) It would be nice if the spec was clearer on this: https://www.mediawiki.org/wiki/Specs/HTML/1.3.0 [13:01:53] (03PS1) 10Esanders: Guard against mwdata.body being null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356581 (https://phabricator.wikimedia.org/T166754) [13:09:14] 10VisualEditor, 06Editing-Department, 10MediaWiki-extensions-CentralNotice, 10OOjs-UI, 13Patch-For-Review: CentralNotice tries to use the now-deleted icon "remove"; should use "trash" from the 'moderation' pack - https://phabricator.wikimedia.org/T166749#3306439 (10Esanders) Do we have to use a word that... [13:50:08] 10Citoid, 10VisualEditor, 10RESTBase-API, 06Services (watching), 15User-mobrovac: New param/pattern in service for requesting a single citation based on a unique identifier - https://phabricator.wikimedia.org/T165321#3307471 (10Mvolz) >>! In T165321#3277029, @kaldari wrote: > http://xisbn.worldcat.org/we... [13:50:51] 10VisualEditor, 10OOjs-UI, 07Regression: Can't use LanguageInputWidget after update to jQuery 3 - https://phabricator.wikimedia.org/T166152#3307472 (10matmarex) This seems to have been fixed in VisualEditor with the upgrade to OOjs UI v0.22.1. [13:51:05] 10VisualEditor, 07Regression, 15User-Ryasmeen: Can't use LanguageInputWidget after update to jQuery 3 - https://phabricator.wikimedia.org/T166152#3307473 (10matmarex) 05Open>03Resolved [13:52:26] 10VisualEditor, 10OOjs-UI, 07Regression: Template dialog doesn't focus input after update to jQuery 3 - https://phabricator.wikimedia.org/T166150#3307483 (10matmarex) This is still reproducible after the upgrade to OOjs UI v0.22.1. [14:04:59] 10VisualEditor, 10OOjs-UI, 07Regression: Template dialog doesn't focus input after update to jQuery 3 - https://phabricator.wikimedia.org/T166150#3307506 (10matmarex) a:03matmarex ve.ui.MWTemplateDialog tries to set the focus in its setup process. I'm not sure why this ever worked, the dialog is not suppos... [14:05:19] 10VisualEditor, 07Regression: Template dialog doesn't focus input after update to jQuery 3 - https://phabricator.wikimedia.org/T166150#3307510 (10matmarex) [14:16:00] (03PS1) 10Jforrester: ext.visualEditor.articleTarget: Depend on 'layout' so we have a menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356593 [14:32:34] (03PS1) 10Bartosz Dziewoński: ve.ui.MWTemplateDialog: Use normal #getReadyProcess instead of custom stuff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356595 (https://phabricator.wikimedia.org/T166150) [14:33:22] (03PS1) 10Jforrester: Depend on 'movement' so we have arrows in the find and replace dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/356596 [14:34:24] James_F: if you're looking at these already, it seems like the icons for the 'More'/'Fewer' options in the text styling menu also disappeared. looks like OOjs UI toolbars now have a hidden dependency on some icon pack. [14:34:24] 10VisualEditor, 13Patch-For-Review: VE startup crashes on [[mw:Manual:FAQ]], probably due to tag - https://phabricator.wikimedia.org/T166754#3307656 (10Deskana) p:05Triage>03Normal a:03Esanders [14:34:57] MatmaRex: Yes, it's odd. Whoops. [14:35:12] MatmaRex: And of course the demos load every single icon pack so you never notice. [14:35:17] remind me why removing that core pack was a good idea. grumble. [14:35:32] MatmaRex: We've saved 80KiB on every page load. [14:35:53] MatmaRex: Which means we're very close to just loading OOUI on every page now. [14:36:27] it's all the worst. [14:38:17] MatmaRex: https://gerrit.wikimedia.org/r/356596 fixes the more/fewer one too. [14:38:25] MatmaRex: Merge and I'll do the pull-through. [14:39:00] (03CR) 10Jforrester: [C: 031] ve.ui.MWTemplateDialog: Use normal #getReadyProcess instead of custom stuff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356595 (https://phabricator.wikimedia.org/T166150) (owner: 10Bartosz Dziewoński) [14:39:20] (03CR) 10Bartosz Dziewoński: [C: 032] Depend on 'movement' so we have arrows in the find and replace dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/356596 (owner: 10Jforrester) [14:40:14] MatmaRex: Also, for added fun we don't actually trigger more/fewer in the SA demo (too short a list), so I had to re-do the SA toolbarGroup setting locally to check. Meh. :-) [14:41:02] 10VisualEditor, 05MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), 07Regression, 15User-Ryasmeen: Can't use LanguageInputWidget after update to jQuery 3 - https://phabricator.wikimedia.org/T166152#3307669 (10Jdforrester-WMF) [14:41:47] (03Merged) 10jenkins-bot: Depend on 'movement' so we have arrows in the find and replace dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/356596 (owner: 10Jforrester) [14:42:19] (03CR) 10Jforrester: [C: 032] Guard against mwdata.body being null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356581 (https://phabricator.wikimedia.org/T166754) (owner: 10Esanders) [14:46:46] (03CR) 10jenkins-bot: Depend on 'movement' so we have arrows in the find and replace dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/356596 (owner: 10Jforrester) [14:50:38] (03PS1) 10Jforrester: Update VE core submodule to master (cd4e0fa2d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356599 [14:51:08] MatmaRex: https://gerrit.wikimedia.org/r/356599 and https://gerrit.wikimedia.org/r/356593 and then I think we're done for icons inside VE. [14:52:58] (03Merged) 10jenkins-bot: Guard against mwdata.body being null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356581 (https://phabricator.wikimedia.org/T166754) (owner: 10Esanders) [14:53:26] (03PS2) 10Bartosz Dziewoński: ext.visualEditor.articleTarget: Depend on 'layout' for the menu icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356593 (owner: 10Jforrester) [14:53:37] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (cd4e0fa2d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356599 (owner: 10Jforrester) [14:53:40] (03CR) 10Bartosz Dziewoński: [C: 032] ext.visualEditor.articleTarget: Depend on 'layout' for the menu icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356593 (owner: 10Jforrester) [14:53:48] 10VisualEditor, 10VisualEditor-MediaWiki, 05MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), 15User-Ryasmeen: [Regression pre-wmf.4] InvalidArgumentException from line 85 of /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderImage.... - https://phabricator.wikimedia.org/T166741#3307750 [14:55:29] 10VisualEditor, 10VisualEditor-MediaWiki, 15User-Ryasmeen: VE startup crashes on [[mw:Manual:FAQ]], probably due to tag - https://phabricator.wikimedia.org/T166754#3307779 (10Jdforrester-WMF) 05Open>03Resolved [14:57:32] 10VisualEditor, 10VisualEditor-VisualDiffs: JS error when trying to view visual diff after switching from source to visual with new annotation - https://phabricator.wikimedia.org/T166755#3307809 (10Jdforrester-WMF) p:05Triage>03High [14:58:07] (03CR) 10jenkins-bot: Guard against mwdata.body being null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356581 (https://phabricator.wikimedia.org/T166754) (owner: 10Esanders) [15:05:05] (03Merged) 10jenkins-bot: Update VE core submodule to master (cd4e0fa2d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356599 (owner: 10Jforrester) [15:05:07] (03Merged) 10jenkins-bot: ext.visualEditor.articleTarget: Depend on 'layout' for the menu icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356593 (owner: 10Jforrester) [15:16:52] (03CR) 10jenkins-bot: Update VE core submodule to master (cd4e0fa2d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356599 (owner: 10Jforrester) [15:18:05] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE preview doesn't process language conversion using {{autotranslate}} - https://phabricator.wikimedia.org/T166723#3307871 (10Deskana) p:05Triage>03Normal [15:25:09] 10VisualEditor, 10VisualEditor-MediaWiki: Provide a keyboard shortcut for adding signature - https://phabricator.wikimedia.org/T166494#3307888 (10Jdforrester-WMF) >>! In T166494#3307052, @Deskana wrote: > Keyboard shortcuts in VisualEditor and the 2017 Wikitext Editor follow either a ` 10VisualEditor, 10VisualEditor-MediaWiki: Provide a keyboard shortcut for adding signature - https://phabricator.wikimedia.org/T166494#3307889 (10Jdforrester-WMF) 05Open>03stalled Declaring this 'stalled' waiting for a good idea for a shortcut to use. [15:27:44] (03CR) 10jenkins-bot: ext.visualEditor.articleTarget: Depend on 'layout' for the menu icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356593 (owner: 10Jforrester) [15:29:12] 10VisualEditor, 06Editing-Department, 10MediaWiki-General-or-Unknown, 10OOjs-UI, 05MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)): Update extensions for removal of core icon pack in OOjs UI v0.22 - https://phabricator.wikimedia.org/T166730#3307916 (10Jdforrester-WMF) [15:32:16] 10VisualEditor, 10OOjs-UI, 07Technical-Debt, 15User-Ryasmeen: Issues with OOjs UI's new WindowInstance code preventing some VE dialogs from working - https://phabricator.wikimedia.org/T166631#3307927 (10matmarex) 05Open>03Resolved [15:33:46] 10VisualEditor, 10OOjs-UI, 05MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), 07Technical-Debt, 15User-Ryasmeen: Issues with OOjs UI's new WindowInstance code preventing some VE dialogs from working - https://phabricator.wikimedia.org/T166631#3307936 (10Jdforrester-WMF) [15:34:27] 10VisualEditor, 06Community-Liaisons (Jul-Sep 2017): CL support to JS-less editing change - https://phabricator.wikimedia.org/T166767#3307939 (10Jdforrester-WMF) > While we're aware it's ready-ish, we don't think we can handle this before the new quarter starts. Then we can proceed without? [15:46:37] (03PS1) 10DLynch: Correct numbers in visualeditor-dialog-meta-settings-toc-help [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356618 (https://phabricator.wikimedia.org/T166029) [15:52:15] 10VisualEditor, 10VisualEditor-MediaWiki: Provide a keyboard shortcut for adding signature - https://phabricator.wikimedia.org/T166494#3308015 (10Deskana) >>! In T166494#3307888, @Jdforrester-WMF wrote: > Actually, the former is a 'sequence', and the latter is a 'shortcut'. Yay terminology. :-) The idea is tha... [15:58:47] 10VisualEditor, 10VisualEditor-ContentLanguage, 07Chinese-Sites, 07Epic: VisualEditor: Support "Language conversion blocks" for multi-script wikis - https://phabricator.wikimedia.org/T49411#3308035 (10Deskana) @cscott Any updates for us on this since it's reopened? :-) [16:09:57] 10VisualEditor, 06Editing-Department, 05MW-1.30-release-notes, 10MediaWiki-General-or-Unknown, 10OOjs-UI: Update extensions for removal of core icon pack in OOjs UI v0.22 - https://phabricator.wikimedia.org/T166730#3308063 (10Jdforrester-WMF) [16:13:45] (03CR) 10Jforrester: [C: 04-1] "Isn't the number correct, and it's the wiki that's over-ridden its config?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356618 (https://phabricator.wikimedia.org/T166029) (owner: 10DLynch) [16:17:50] (03CR) 10DLynch: "> Isn't the number correct, and it's the wiki that's over-ridden its" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356618 (https://phabricator.wikimedia.org/T166029) (owner: 10DLynch) [16:19:21] (03CR) 10DLynch: "And it's been that way since 2006, according to blame, so I think we may have just made a mistake when writing the original message here." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356618 (https://phabricator.wikimedia.org/T166029) (owner: 10DLynch) [16:33:17] 10VisualEditor: Visual diff: Template replaced by another template is shown as an attribute change - https://phabricator.wikimedia.org/T166801#3308109 (10Esanders) [16:41:57] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Performance: Pasting URLs is slow in new wikitext editor - https://phabricator.wikimedia.org/T154019#2898535 (10DLynch) I think T163237 was a duplicate of this, and thus this one is fixed as well? [16:55:03] 10VisualEditor, 06Editing-Department, 10MediaWiki-General-or-Unknown, 10OOjs-UI: Update extensions for deprecation of openWindow/closeWindow promise in OOjs UI v0.22 - https://phabricator.wikimedia.org/T166729#3308166 (10matmarex) [17:02:55] MatmaRex: Meeting? [17:03:07] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Performance: Pasting URLs is slow in new wikitext editor - https://phabricator.wikimedia.org/T154019#2898535 (10Dvorapa) @DLynch I don't think so [17:03:36] yes [17:20:47] 10VisualEditor, 06Editing-Department, 10MediaWiki-General-or-Unknown, 10OOjs-UI: Update extensions for deprecation of openWindow/closeWindow promise in OOjs UI v0.22 - https://phabricator.wikimedia.org/T166729#3308296 (10Jdforrester-WMF) [17:24:23] 10VisualEditor, 06Editing-Department, 10MediaWiki-General-or-Unknown, 10OOjs-UI: Update extensions for deprecation of openWindow/closeWindow promise in OOjs UI v0.22 - https://phabricator.wikimedia.org/T166729#3308323 (10matmarex) So first things first, documentation: * https://www.mediawiki.org/w/index.ph... [17:29:26] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 05MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 07Performance, 15User-Ryasmeen: Pasting URLs is slow in new wikitext editor - https://phabricator.wikimedia.org/T154019#3308358 (10Jdforrester-WMF) 05Open>03Resolved a:03DLync... [17:31:18] 10VisualEditor: Visual diff: Template replaced by another template is shown as an attribute change - https://phabricator.wikimedia.org/T166801#3308390 (10Jdforrester-WMF) p:05Triage>03Normal [17:33:20] 10VisualEditor, 10VisualEditor-MediaWiki-Media: SVG files appear blurry on VE insert media tool - https://phabricator.wikimedia.org/T166643#3308398 (10Jdforrester-WMF) p:05Triage>03Low Will need special-casing when we ask for the thumbnail and (a) get back something smaller than our target and (b) it's a n... [17:35:13] (03CR) 10Jforrester: [C: 032] "Huh." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356618 (https://phabricator.wikimedia.org/T166029) (owner: 10DLynch) [17:36:07] 10VisualEditor, 10VisualEditor-MediaWiki, 15User-Ryasmeen: VE - wrong info for "Table of contents" - limit is 4, not 3 - https://phabricator.wikimedia.org/T166029#3308403 (10Jdforrester-WMF) 05Open>03Resolved a:03DLynch [17:41:30] (03CR) 10Bartosz Dziewoński: [C: 04-1] "No longer needed? What is the issue this was meant to solve?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354658 (owner: 10Esanders) [17:42:23] (03CR) 10Esanders: "Do we know why this was done differently? We should check there wasn't a good reason..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356595 (https://phabricator.wikimedia.org/T166150) (owner: 10Bartosz Dziewoński) [17:43:47] (03CR) 10Bartosz Dziewoński: "It blames to the big initial commit of template support. It's possible getReadyProcess wasn't a thing back then?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356595 (https://phabricator.wikimedia.org/T166150) (owner: 10Bartosz Dziewoński) [17:46:55] RoanKattouw: Can I steal some of your time later for https://gerrit.wikimedia.org/r/#/c/281470 ? [17:47:34] (03CR) 10Jforrester: [C: 031] "I think that's right; getReadyProcess got introduced later as a generalisation and we didn't go back and fix it?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356595 (https://phabricator.wikimedia.org/T166150) (owner: 10Bartosz Dziewoński) [17:49:23] (03Merged) 10jenkins-bot: Correct numbers in visualeditor-dialog-meta-settings-toc-help [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356618 (https://phabricator.wikimedia.org/T166029) (owner: 10DLynch) [17:54:51] (03CR) 10Esanders: [C: 032] ve.ui.MWTemplateDialog: Use normal #getReadyProcess instead of custom stuff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356595 (https://phabricator.wikimedia.org/T166150) (owner: 10Bartosz Dziewoński) [17:55:16] 10VisualEditor, 06Editing-Department, 10MediaWiki-Page-editing, 13Patch-For-Review: Change OOUI EditPage inputs to keep the old 'id' attributes on the elements - https://phabricator.wikimedia.org/T165854#3308572 (10matmarex) >>! In T165854#3294114, @Schnark wrote: > You are aware that this change w... [17:56:05] 10VisualEditor, 10Wikimedia-Site-requests, 06Community-Liaisons (Apr-Jun 2017), 13Patch-For-Review, 07User-notice: Support WMF communities in run-up to switching EditPage over to OOUI - https://phabricator.wikimedia.org/T162849#3308575 (10matmarex) [17:56:07] 10VisualEditor, 06Editing-Department, 10MediaWiki-Page-editing, 15User-Ryasmeen: Change OOUI EditPage inputs to keep the old 'id' attributes on the elements - https://phabricator.wikimedia.org/T165854#3308573 (10matmarex) 05Open>03Resolved [17:57:43] (03CR) 10jenkins-bot: Correct numbers in visualeditor-dialog-meta-settings-toc-help [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356618 (https://phabricator.wikimedia.org/T166029) (owner: 10DLynch) [18:08:22] (03Merged) 10jenkins-bot: ve.ui.MWTemplateDialog: Use normal #getReadyProcess instead of custom stuff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356595 (https://phabricator.wikimedia.org/T166150) (owner: 10Bartosz Dziewoński) [18:15:36] (03CR) 10jenkins-bot: ve.ui.MWTemplateDialog: Use normal #getReadyProcess instead of custom stuff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356595 (https://phabricator.wikimedia.org/T166150) (owner: 10Bartosz Dziewoński) [18:32:22] 10VisualEditor, 06Community-Liaisons (Jul-Sep 2017): CL support to JS-less editing change - https://phabricator.wikimedia.org/T166767#3308703 (10Elitre) No? This is not what we had agreed. Per our agenda we had come to the conclusion that July could be a good month, because there are so many other changes to h... [18:37:05] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 07Regression, 15User-Ryasmeen: Template dialog doesn't focus input after update to jQuery 3 - https://phabricator.wikimedia.org/T166150#3308722 (10Jdforrester-WMF) 05Open>03Resolved [18:51:45] RoanKattouw: https://phabricator.wikimedia.org/T166153 [19:13:47] 10VisualEditor, 06Editing-Department, 05MW-1.30-release-notes, 10MediaWiki-General-or-Unknown, 10OOjs-UI: Update extensions for removal of core icon pack in OOjs UI v0.22 - https://phabricator.wikimedia.org/T166730#3305852 (10Volker_E) There's also https://phabricator.wikimedia.org/source/mediawiki/brows... [19:16:26] 10VisualEditor, 06Editing-Department, 05MW-1.30-release-notes, 10MediaWiki-General-or-Unknown, 10OOjs-UI: Update extensions for removal of core icon pack in OOjs UI v0.22 - https://phabricator.wikimedia.org/T166730#3308909 (10Volker_E) RevisionSlider got fixed in https://gerrit.wikimedia.org/r/#/c/356602/ [19:37:22] 10VisualEditor, 10OOjs-UI, 05MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), 07Technical-Debt, 15User-Ryasmeen: Issues with OOjs UI's new WindowInstance code preventing some VE dialogs from working - https://phabricator.wikimedia.org/T166631#3308972 (10Jdforrester-WMF) [19:37:24] 10VisualEditor, 06Editing-Department, 05MW-1.30-release-notes, 10MediaWiki-General-or-Unknown, 10OOjs-UI: Update extensions for removal of core icon pack in OOjs UI v0.22 - https://phabricator.wikimedia.org/T166730#3308971 (10Jdforrester-WMF) [19:42:03] 10VisualEditor, 05MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), 10OOjs-UI (OOjs-UI-0.22.1), 07Technical-Debt, 15User-Ryasmeen: Issues with OOjs UI's new WindowInstance code preventing some VE dialogs from working - https://phabricator.wikimedia.org/T166631#3308997 (10Jdforrester-WMF) [19:42:19] 10VisualEditor, 06Collaboration-Team-Triage, 06Editing-Department, 10Flow, and 3 others: Flow tries to use the now-deleted icon "remove"; should use "trash" from the 'moderation' pack - https://phabricator.wikimedia.org/T166742#3309004 (10Jdforrester-WMF) [19:48:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 07Technical-Debt: MWTemplateTitleInputWidget should use mw.widgets.TitleSearchWidget with a cache, not mw.widgets.TitleInputWidget - https://phabricator.wikimedia.org/T163525#3309044 (10Jdforrester-WMF) p:05Triage>03Low [19:49:06] 10VisualEditor: The preview link for user page in the link dialog doesn't add local wiki domain prefix - https://phabricator.wikimedia.org/T165980#3309045 (10Jdforrester-WMF) p:05Triage>03High [19:49:48] 10VisualEditor, 10MediaWiki-Page-editing, 13Patch-For-Review, 07User-notice: On the edit page next to the edit summary input box, show the number of remaining bytes (like VE-MW provides) - https://phabricator.wikimedia.org/T165856#3309050 (10Jdforrester-WMF) a:03Jdforrester-WMF [21:11:37] 10VisualEditor: Visual diff: Template replaced by another template is shown as an attribute change - https://phabricator.wikimedia.org/T166801#3309266 (10Esanders) Actually the `typeChange` property is never used, so changing any block node to any other block node will come up as an attribute change. [21:16:10] (03PS1) 10C. Scott Ananian: WIP: Specialized inspector for LanguageConverter markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356739 (https://phabricator.wikimedia.org/T49411) [21:17:05] James_F, Krinkle, Roan: is there any precedent in VE for an inline BranchNode ? [21:17:31] that is, a Node that behaved like an annotation: you could edit inside it, and it was laid out inline. [21:17:43] No I don't think so [21:18:01] There are inline nodes like images [21:18:15] yes, but they are ve.ce.LeafNodes, not allowed to have any contents [21:18:21] But no inline nodes that have children [21:18:25] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/356744 (owner: 10L10n-bot) [21:18:33] even BlockImage is a LeafNode, and you have to click into the inspector to edit the caption [21:18:38] Yeah [21:18:52] So, I would like us to have inline editing of image captions [21:19:01] But it wouldn't be done that way [21:19:09] What is the application you have in mind? [21:19:34] I tried to use toDataElement to convince the dm that my was actually an annotation, but that didn't work quite right with generated content. [21:20:24] -{R|foo}- is a silly sort of , right? But it's represented by Parsoid as [21:20:43] What does that syntax mean again? [21:21:01] It just means "protect `foo` from language conversion" [21:21:09] Aha OK [21:21:21] but there are other similar forms [21:21:21] Does it also output Foo? [21:21:26] yes [21:21:37] Then shouldn't the span be not empty? [21:21:49] well... maybe. [21:22:16] I mean, at least for display purposes you would want that, right? [21:22:22] see https://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec/Language_conversion_blocks#Alternative_2 [21:22:44] Also, am I allowed to have annotations inside? [21:22:56] Can part of foo be bold, or a link? [21:22:57] the idea is that eventually we'll do the actual language conversion client-side, and so we'd fill the empty spans with the correct thing based on the currently-selected variant [21:23:02] yes, you can have annotations inside [21:23:12] Oh, I see [21:23:29] So it behaves kind of like a reference then [21:23:42] Or a mix between that and an auto numbered link [21:23:43] in other cases, there might be more than one possible output in there, and I only want to see one of them (at a time) [21:23:49] Right [21:24:09] So the content isn't text then, it's HTML [21:24:14] yeah [21:24:38] and it's got the usual "could be block, could be inline" thing that MWTransclusionNode deals with [21:24:44] (03CR) 10jerkins-bot: [V: 04-1] WIP: Specialized inspector for LanguageConverter markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356739 (https://phabricator.wikimedia.org/T49411) (owner: 10C. Scott Ananian) [21:24:55] That's a tricky one, I'd recommend picking edsanders and David's brains too [21:25:12] The fact that it can be block is very annoying [21:25:14] At any rate, I guess the easiest way to get started here is to implement it as a 'boring' LeafNode and not allow direct editing, you'll have to use an inspector [21:25:17] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356754 (owner: 10L10n-bot) [21:25:23] That makes it hard to make it an annotation [21:26:02] RoanKattouw: yes, and it's something I'd eventually like to fix on the PHP side. But there are a few cases like -{zh-cn:==Foo==;zh-tw:==Bar==}- [21:26:14] Right [21:26:15] which should really be rewritten as == -{zh-cn:Foo;zh-tw:Bar}- == [21:27:15] If it's only annotated text, then you could make it an annotation that would have to do some magic to generate its own content and feed the right content back into data-mw [21:27:19] usual annoying story about balance, templates, markup boundaries, etc. [21:29:03] yeah, with an annotation i just hit a roadblock in ve.dm.Converter:getDomSubtreeFromData which doesn't give me a way to return the annotation *and* the data contained as an array from toDataElement, the way that nodes can [21:29:30] so I might patch that and handle the case where toDataElement returns an array of length > 1 from toDataElement [21:29:45] but figured I'd check to make sure I wasn't missing something obvious first [21:30:01] Yeah you'll have to invent something new here [21:30:15] I might also just give in an generate explicit foo for some of these cases [21:30:15] In both directions [21:30:24] which would be a more direct analog of [21:30:31] Or add pre- and post-processing steps [21:30:43] Also look at how nowiki works on the way out [21:31:05] If you did -{foo
bar}- then I *think* the usual HTML5 treebuilding would split the over the
and you'd effectively get -{foo}-
-{bar}- [21:31:07] It's not really the same, it drops the annotation, but it might give you ideas [21:31:32] that works for the "raw output" case, but things get really hairy if there are multiple alternatives. [21:31:38] Well if the resulting HTML is too weird, you can just alienate it [21:32:25] Which might even happen automatically because of special treatment of the mw: prefix and protections against misnesting [21:33:13] yeah, right now VE is alienating everything which is fine but because the s are empty the result is that the content goes missing [21:33:43] again, maybe an indicator that this whole "empty span to be filled with converted output" idea isn't all that hot. we'll see. [21:34:20] anyway, I think using a Node and just dealing with non-direct editing is the way to go for the crappy-first-draft. [21:34:32] although i'm curious how to planned on allowing direct figure caption editing [21:34:40] *how you planned to allow [21:37:05] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 06Commons: VisualEditor file upload is broken for new user - https://phabricator.wikimedia.org/T166540#3309357 (10Nemo_bis) The file upload is not technically broken, it's working as expected (i.e. in a very user-unfriendly way because it was not designed for m... [21:41:02] cscott: Basically, make captions work the way references work, with their contents being in an internalList item or subdocument, then create a surface on that subdoc and embed it in the image frame [21:41:22] The subdocuments thing is a refactor I started in 2014 and never finished [21:42:25] You could also do it without changing the DM representation if you are able to make a surface for a subset of the document [21:42:54] But the change in representation would allow inline images to retain captions [21:44:55] Yeah, I just would want to be able to cursor seamlessly "into" the embedded subdoc. [21:45:18] 10VisualEditor, 10VisualEditor-ContentLanguage, 07Chinese-Sites, 07Epic, 13Patch-For-Review: VisualEditor: Support "Language conversion blocks" for multi-script wikis - https://phabricator.wikimedia.org/T49411#3309369 (10cscott) @deskana sure: Theres's fully-functioning Parsoid support in https://gerrit... [22:17:30] 10VisualEditor, 06Editing-Department, 10MediaWiki-General-or-Unknown, 10OOjs-UI: Update extensions for deprecation of openWindow/closeWindow promise in OOjs UI v0.22 - https://phabricator.wikimedia.org/T166729#3309417 (10matmarex) I grepped everything for calls to the four functions, then removed obvious f... [22:27:26] (03PS1) 10Bartosz Dziewoński: Update for deprecation of OOjs UI openWindow/closeWindow promise [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/356766 (https://phabricator.wikimedia.org/T166729) [22:27:39] (03PS1) 10Bartosz Dziewoński: Update for deprecation of OOjs UI openWindow/closeWindow promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356767 (https://phabricator.wikimedia.org/T166729) [22:30:32] (03CR) 10Bartosz Dziewoński: Update for deprecation of OOjs UI openWindow/closeWindow promise (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/356766 (https://phabricator.wikimedia.org/T166729) (owner: 10Bartosz Dziewoński) [22:41:00] cscott: If you want to do subdocs as part of this I'll love you forever … but I don't think you should put too much hope on that. :-) [22:59:53] MatmaRex: Amazing. [23:01:14] James_F: which part of it? i was surprised how many random extensions are using the dialogs [23:01:26] MatmaRex: "I was able to deduce this because I'm amazing. See 3122891518e256fa907102840afb536b89d6093a." [23:01:35] Also, yes. [23:01:43] :D [23:03:19] (03CR) 10Jforrester: [C: 031] Update for deprecation of OOjs UI openWindow/closeWindow promise [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/356766 (https://phabricator.wikimedia.org/T166729) (owner: 10Bartosz Dziewoński) [23:04:59] MatmaRex: https://gerrit.wikimedia.org/r/#/c/354658/ by Ed was a problem that meant that progress dialogs (only used I think by TransferHandlers) would instantly close on being opened (because of the follow-through promises). You didn't touch ProgressDialog in 356766 though? [23:05:24] MatmaRex: Does it now Just Work™? [23:06:29] James_F: i didn't test, but that was most likely fixed by the WindowInstance stuff [23:07:01] James_F: if it doesn't work, please file another bug and i'll look into it next week [23:07:01] Try it with one that takes a while (e.g. paste wikitext). [23:07:08] Or that. [23:07:10] :-) [23:20:36] 10VisualEditor, 06Editing-Department, 05MW-1.30-release-notes, 10MediaWiki-General-or-Unknown, 10OOjs-UI: Update extensions for removal of core icon pack in OOjs UI v0.22 - https://phabricator.wikimedia.org/T166730#3309565 (10matmarex) Potential violators – a human needs to verify that all this code has...