[08:56:27] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: The same keyboard shortcut cannot simultaneously be 'Preview page' and 'Switch to the visual editor' - https://phabricator.wikimedia.org/T167832#3346240 (10Schnark) You mean 'Show changes' instead of 'Show preview', and both the exact shortcut and be... [10:37:19] 10Citoid, 10VisualEditor, 10Operations, 10Services (blocked), 10User-mobrovac: Wiley requests for DOI and some other publishers don't work in production - https://phabricator.wikimedia.org/T165105#3347409 (10Samwalton9) Not directly, but I might have someone who does have direct contact. Could you give m... [11:25:23] (03PS1) 10Esanders: Keep TOC in correct place in document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358928 [11:26:45] 10VisualEditor, 10OOjs-UI, 10Regression: VE widget tooltips misplaced - https://phabricator.wikimedia.org/T167751#3347471 (10Esanders) [11:27:17] 10VisualEditor, 10OOjs-UI, 10Regression: VE widget tooltips misplaced - https://phabricator.wikimedia.org/T167751#3343283 (10Esanders) Pinging @matmarex and @Catrope who changed OOUI popup behaviour recently. [11:28:03] (03CR) 10Esanders: [C: 032] MWTransclusionDialog: size footer correctly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358632 (https://phabricator.wikimedia.org/T167483) (owner: 10DLynch) [11:39:42] (03Merged) 10jenkins-bot: MWTransclusionDialog: size footer correctly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358632 (https://phabricator.wikimedia.org/T167483) (owner: 10DLynch) [11:47:01] (03CR) 10jenkins-bot: MWTransclusionDialog: size footer correctly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358632 (https://phabricator.wikimedia.org/T167483) (owner: 10DLynch) [11:48:37] 10Citoid, 10VisualEditor, 10Operations, 10Services (blocked), 10User-mobrovac: Wiley requests for DOI and some other publishers don't work in production - https://phabricator.wikimedia.org/T165105#3347537 (10Mvolz) >>! In T165105#3347409, @Samwalton9 wrote: > Not directly, but I might have someone who do... [11:49:32] 10Citoid, 10VisualEditor, 10Operations, 10Services (blocked), 10User-mobrovac: Wiley requests for DOI and some other publishers don't work in production - https://phabricator.wikimedia.org/T165105#3347538 (10Samwalton9) Yes - thanks! Do you have the IP address, so I can pass it along? [11:52:25] 10Citoid, 10VisualEditor, 10Operations, 10Services (blocked), 10User-mobrovac: Wiley requests for DOI and some other publishers don't work in production - https://phabricator.wikimedia.org/T165105#3347539 (10Mvolz) >>! In T165105#3347538, @Samwalton9 wrote: > Yes - thanks! Do you have the IP address, so... [12:19:42] 10VisualEditor, 10VisualEditor-MediaWiki, 10Regression: Edit notice renders behind content instead of on top (FOUC) - https://phabricator.wikimedia.org/T167616#3347626 (10Esanders) Can't find a breakpoint to debug this. Could be related to how PopupWidgets resize them themselves, or something to do with the... [13:25:13] 10VisualEditor: wgAction = view in edit mode - https://phabricator.wikimedia.org/T167880#3347870 (10Shizhao) [13:48:12] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10OOjs-UI, 10MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), and 2 others: [Regression wmf.4] Dialog footer broken for templates - https://phabricator.wikimedia.org/T167483#3347986 (10Ryasmeen) 05Open>03Resolved [13:48:47] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10OOjs-UI, 10MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), and 2 others: [Regression wmf.4] Dialog footer broken for templates - https://phabricator.wikimedia.org/T167483#3347990 (10Ryasmeen) a:03DLynch [13:49:30] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), 10User-Ryasmeen, 10Verified: Gallery dialog doesn't indicate what images are included - https://phabricator.wikimedia.org/T167049#3347991 (10Ryasmeen) [13:50:41] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), 10User-Ryasmeen, and 2 others: Gallery dialog doesn't indicate what images are included - https://phabricator.wikimedia.org/T167049#3315690 (10Ryasmeen) [13:51:17] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), 10User-Ryasmeen, 10Verified: Missing bin icon in templates dialogs - https://phabricator.wikimedia.org/T167598#3347996 (10Ryasmeen) [13:54:23] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10OOjs-UI, 10MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), and 2 others: [Regression wmf.4] Dialog footer broken for templates - https://phabricator.wikimedia.org/T167483#3348033 (10Ryasmeen) >>! In T167483#3342024, @Jdforrester-WMF wrote:... [14:26:47] 10VisualEditor: [Regression wmf.5] Incorrect surface highlights while changing a hieroglyph - https://phabricator.wikimedia.org/T167890#3348171 (10Ryasmeen) [14:36:06] 10VisualEditor: [Regression ?] Getting error "Uncaught TypeError: Cannot read property 'top' of null" in the console, while switching from visual diff to wikitext diff or to save page - https://phabricator.wikimedia.org/T167892#3348200 (10Ryasmeen) [15:07:23] 10VisualEditor, 10Graphs: Add a frame and caption text to - https://phabricator.wikimedia.org/T147768#3348415 (10debt) Moving off the sprint board - the Discovery team won't be able to finish this work at this time. [15:52:46] 10VisualEditor: wgAction = view in edit mode - https://phabricator.wikimedia.org/T167880#3347870 (10Deskana) @Shizhao Hi! I'm afraid I don't understand. Can you give me some more context? [15:55:50] (03PS1) 10DLynch: MWTransclusionDialog: fix conditions for "show options" button disabling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358984 (https://phabricator.wikimedia.org/T167710) [16:06:54] 10VisualEditor, 10Parsing-Team, 10TemplateStyles, 10ArchCom-RfC (ArchCom-Approved), and 2 others: RfC: Allow styling in templates - https://phabricator.wikimedia.org/T483#3348660 (10Tgr) [16:35:09] 10VisualEditor: "Clear styling" gives ⌘M as a keyboard shortcut, but this is Minimize Window in Safari and Firefox on a Mac - https://phabricator.wikimedia.org/T167898#3348744 (10Whatamidoing-WMF) [16:55:43] (03CR) 10Esanders: [C: 04-1] "This should add test cases that cover the reasons it was reverted, before we re-merge it. (And obviously fix them)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/357171 (https://phabricator.wikimedia.org/T167027) (owner: 10Divec) [16:57:54] 10VisualEditor: "Clear styling" gives ⌘M as a keyboard shortcut, but this is Minimize Window in Safari and Firefox on a Mac - https://phabricator.wikimedia.org/T167898#3348744 (10Esanders) And Chrome? [17:58:37] (03CR) 10Jforrester: "> This should add test cases that cover the reasons it was reverted, before we re-merge it. (And obviously fix them)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/357171 (https://phabricator.wikimedia.org/T167027) (owner: 10Divec) [18:31:50] (03CR) 10Bartosz Dziewoński: "This should not be needed. Changing a button label should not change its height. I feel like there's a deeper bug in here somewhere?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358632 (https://phabricator.wikimedia.org/T167483) (owner: 10DLynch) [18:40:12] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10OOjs-UI, 10MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), and 2 others: [Regression wmf.4] Dialog footer broken for templates - https://phabricator.wikimedia.org/T167483#3334473 (10matmarex) This was caused by {a97eacd05b17982a5e2cb4b1bb8... [18:40:34] (03CR) 10Bartosz Dziewoński: "This caused T167483. Clearly, T93290 is not actually fixed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/355247 (https://phabricator.wikimedia.org/T93290) (owner: 10Esanders) [18:40:50] (03CR) 10DLynch: "> This should not be needed. Changing a button label should not" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358632 (https://phabricator.wikimedia.org/T167483) (owner: 10DLynch) [18:40:54] (03PS1) 10Bartosz Dziewoński: Revert 032fb292, a97eacd0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/359010 (https://phabricator.wikimedia.org/T93290) [18:41:37] (03CR) 10Bartosz Dziewoński: "Indeed. That was supposed to have been fixed, see T93290." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358632 (https://phabricator.wikimedia.org/T167483) (owner: 10DLynch) [18:52:25] (03CR) 10DLynch: [C: 032] Revert 032fb292, a97eacd0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/359010 (https://phabricator.wikimedia.org/T93290) (owner: 10Bartosz Dziewoński) [19:04:59] (03Merged) 10jenkins-bot: Revert 032fb292, a97eacd0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/359010 (https://phabricator.wikimedia.org/T93290) (owner: 10Bartosz Dziewoński) [19:11:13] (03CR) 10jenkins-bot: Revert 032fb292, a97eacd0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/359010 (https://phabricator.wikimedia.org/T93290) (owner: 10Bartosz Dziewoński) [19:17:48] 10VisualEditor, 10VisualEditor-MediaWiki, 10Regression: Edit notice renders behind content instead of on top (FOUC) - https://phabricator.wikimedia.org/T167616#3349409 (10matmarex) There are some `transform`s on the `.oo-ui-toolbar-bar` during the toolbar animation that seem to be causing this. And there's t... [20:27:10] (03PS1) 10Bartosz Dziewoński: Make sure the toolbar is shown on top of surface contents even when not floating [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/359033 (https://phabricator.wikimedia.org/T167616) [20:27:18] (03PS1) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget: Remove some hacks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/359034 (https://phabricator.wikimedia.org/T167616) [20:33:47] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I think the current behavior is correct. I'm commenting in the task." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358984 (https://phabricator.wikimedia.org/T167710) (owner: 10DLynch) [20:39:00] (03CR) 10Bartosz Dziewoński: "Maybe not…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358984 (https://phabricator.wikimedia.org/T167710) (owner: 10DLynch) [20:49:45] (03CR) 10DLynch: "> Maybe not…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358984 (https://phabricator.wikimedia.org/T167710) (owner: 10DLynch) [20:56:49] (03CR) 10Bartosz Dziewoński: [C: 04-1] "On second thought, the existing behavior is indeed very weird, and your proposal here is probably sane. But this change makes it impossibl" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358984 (https://phabricator.wikimedia.org/T167710) (owner: 10DLynch) [21:16:34] 10VisualEditor, 10OOjs-UI, 10Regression: VE "user education" tooltips misplaced - https://phabricator.wikimedia.org/T167751#3349844 (10matmarex) a:03matmarex [21:19:21] (03PS1) 10Bartosz Dziewoński: ve.ui.MWEducationPopupTool: Remove unnecessary manual popup positioning [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/359051 (https://phabricator.wikimedia.org/T167751) [21:51:18] 10VisualEditor: "Clear styling" gives ⌘M as a keyboard shortcut, but this is Minimize Window in Safari and Firefox on a Mac - https://phabricator.wikimedia.org/T167898#3350059 (10Whatamidoing-WMF) I don't know; I've never used Chrome. [21:57:38] 10VisualEditor: VisualEditor tooltip incorrectly parses names of multiline templates - https://phabricator.wikimedia.org/T167613#3350068 (10matmarex) a:03matmarex The root cause of this is that `mw.Title.newFromText()` doesn't accept input containing newlines (which is correct and matches PHP `Title::newFromTe... [23:01:16] (03PS1) 10Bartosz Dziewoński: Use Parsoid data for template names rather than detect from wikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/359074 (https://phabricator.wikimedia.org/T167613) [23:01:36] 10VisualEditor, 10Patch-For-Review: VisualEditor tooltip incorrectly parses names of multiline templates - https://phabricator.wikimedia.org/T167613#3350222 (10matmarex) (I discovered T167933 while working on this.) [23:10:37] (03CR) 10jerkins-bot: [V: 04-1] Use Parsoid data for template names rather than detect from wikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/359074 (https://phabricator.wikimedia.org/T167613) (owner: 10Bartosz Dziewoński) [23:12:09] "Then, once merged, it must be deployed; if not, loading VisualEditor will fail with errors such as "Failed to load resource: the server responded with a status of 404"." [23:12:16] Seems to work fine on atjwiki :P [23:15:21] (03PS2) 10Bartosz Dziewoński: Use Parsoid data for template names rather than detect from wikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/359074 (https://phabricator.wikimedia.org/T167613) [23:51:49] 10VisualEditor, 10Release-Engineering-Team (Kanban), 10User-Ryasmeen, 10User-zeljkofilipin: LanguageScreenshotBot trying to edit a non-existent page without signing in - https://phabricator.wikimedia.org/T162454#3350309 (10Xaosflux) Please note, as decided in Wikipedia:Articles for deletion/Screenshot/fodd...