[07:10:51] 10VisualEditor, 10Community-Liaisons (Jul-Sep 2017): CL support to JS-less editing change - https://phabricator.wikimedia.org/T166767#3374086 (10Qgil) [08:50:57] 10Citoid, 10VisualEditor, 10VisualEditor-ContentEditable, 10Design, and 6 others: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - https://phabricator.wikimedia.org/T71474#3374256 (10Liuxinyu970226) [08:51:03] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10UI-Standardization, and 4 others: mediawiki.feedback should use OOjs UI dialog - https://phabricator.wikimedia.org/T89878#3374258 (10Liuxinyu970226) [08:51:06] 10VisualEditor, 10VisualEditor-Performance, 10Performance, 10User-Ryasmeen, and 5 others: Show the VisualEditor toolbar/editor chrome as soon as VE scripts are loaded, rather than blocking on waiting for the content to load - https://phabricator.wikimedia.org/T76523#3374261 (10Liuxinyu970226) [08:51:25] 10VisualEditor, 10Wikimedia-Site-requests, 10User-Ryasmeen, 10User-notice, and 2 others: Disable "Beta" suffixes on tabs for VisualEditor opt-in wikis - https://phabricator.wikimedia.org/T60583#3374265 (10Liuxinyu970226) [09:30:04] (03CR) 10DLynch: [C: 031] Use instanceof to check for LeafNode's [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/360911 (https://phabricator.wikimedia.org/T167009) (owner: 10Esanders) [11:22:11] 10Cite, 10TCB-Team, 10WMDE-Design, 10Design: Error handling for "extends" parameter - https://phabricator.wikimedia.org/T151305#2813680 (10petr.matas) >>! In T151305#2813932, @Jan_Dittrich wrote: > Is there any mechanism to show error messages? As far as I am concerned, if you do an edit and save it you ar... [12:27:57] 10Cite: Cite error messages are not shown in User namespace if UI language is English - https://phabricator.wikimedia.org/T168719#3374635 (10petr.matas) [12:29:40] 10Cite: Cite error ref numeric key not displayed in user namespace - https://phabricator.wikimedia.org/T147652#3374649 (10petr.matas) [12:29:42] 10Cite: Cite error messages are not shown in User namespace if UI language is English - https://phabricator.wikimedia.org/T168719#3374648 (10petr.matas) [13:07:43] 10Cite: Cite error messages are not shown in User namespace if UI language is English - https://phabricator.wikimedia.org/T168719#3374687 (10petr.matas) [13:10:04] 10VisualEditor, 10VisualEditor-MediaWiki: Unexpected loading of VisualEditor after Special:RevisionDelete submission - https://phabricator.wikimedia.org/T168533#3374695 (10Deskana) p:05Triage>03Normal Verified. Not super high priority, but is definitely something we should iron out. [13:11:55] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Issues with 2017 editor and Grammarly - https://phabricator.wikimedia.org/T167019#3374700 (10Deskana) p:05Triage>03Low [16:11:56] (03CR) 10Bartosz Dziewoński: Make sure the toolbar is shown on top of surface contents even when not floating (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/359033 (https://phabricator.wikimedia.org/T167616) (owner: 10Bartosz Dziewoński) [16:22:22] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Copy problem with the 2017 wikitext editor - https://phabricator.wikimedia.org/T168734#3375124 (10Bencemac) [17:12:08] (03CR) 10Bartosz Dziewoński: [C: 032] MWTransclusionDialog: fix conditions for "show options" button disabling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358984 (https://phabricator.wikimedia.org/T167710) (owner: 10DLynch) [17:20:04] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: Copy problem with the 2017 wikitext editor - https://phabricator.wikimedia.org/T168734#3375258 (10Dvorapa) [17:21:51] (03Merged) 10jenkins-bot: MWTransclusionDialog: fix conditions for "show options" button disabling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358984 (https://phabricator.wikimedia.org/T167710) (owner: 10DLynch) [17:28:19] (03CR) 10jenkins-bot: MWTransclusionDialog: fix conditions for "show options" button disabling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358984 (https://phabricator.wikimedia.org/T167710) (owner: 10DLynch) [17:38:05] Hi all, I would like to understand how the VisualEditor specifically treats "table"... I had a quick look at the whole code, but hardly find where the handling of table is. [17:38:05] 10VisualEditor, 10VisualEditor-MediaWiki: Transclusion options are messed up in multiple ways - https://phabricator.wikimedia.org/T168740#3375296 (10matmarex) [17:38:50] I assume it operates over an HTML generated by Parsoid. But then I would like to locate the specific code in charge of processing tables and offering useful services like cell edition [17:39:09] macker_: there's a lot of custom handling for tables. generally, any file whose name includes the word 'table' is part of it. :) [17:41:00] MatmaRex: when reviewing the code that was my strategy (finding occurrences of "table")... but no good result so far [17:41:52] I have impression to miss the most basic part ;) maybe can you indicate the main file in which the processing and custom handling are mainly done? [17:44:16] macker_: i suppose you could start in lib/ve/src/ce/nodes/ve.ce.TableNode.js. but i could give you a better answer if i knew what you're looking for [17:45:39] macker_: by the way, if you want to get into VE development, https://www.mediawiki.org/wiki/User:DLynch_(WMF)/VisualEditor/GettingStarted gives an outline of some of the conventions. reading it will probably make it easier for you to find your way [17:55:58] 10VisualEditor, 10VisualEditor-MediaWiki: Transclusion options are messed up in multiple ways - https://phabricator.wikimedia.org/T168740#3375329 (10matmarex) I'm actually not sure if it's https://gerrit.wikimedia.org/r/#/c/350260/. The longer I look at this code, the crazier it seems. Right now I don't unders... [17:58:28] Thanks! The doc. seems useful but deprecated wrt to the source code I have ( https://gerrit.wikimedia.org/r/p/mediawiki/extensions/VisualEditor.git) [17:59:00] eg I have no demos/ve/minimal.html [18:01:43] macker_: make sure you get the submodule. run `git submodule init` [18:02:58] (the VisualEditor extension for MediaWiki [VE-MW] is built on top of the generic VisualEditor [VE-core]. VE-core is just a fancy HTML editor, and VE-MW implements features like templates and citations on top of it.) [18:03:17] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor should anchordecode internal links - https://phabricator.wikimedia.org/T160877#3113446 (10Krinkle) If `Foo#bár` is used as link target in VisualEditor, this should be preserved and make its way into wikitext. I believe that is alr... [18:04:39] 10VisualEditor, 10VisualEditor-MediaWiki: Transclusion options are messed up in multiple ways - https://phabricator.wikimedia.org/T168740#3375368 (10matmarex) The missing icon was fixed in acde3756. Have we really not done an OOjs UI release with that? [18:20:05] MatmaRex: oh OK many thanks! [18:21:06] My goal is to understand how to efficiently process Wiki tables (VisualEditor is a natural candidate). Maybe I should also had a look at Parsoid (or projects using Parsoid) for getting other inspirations on how to process Wiki tables. Any recommendation? Or I am in the right place and Visual Editor has the best support of Wikitables to far? [18:37:44] macker_: sorry, i wasn't looking at the replies here. "process" how? unless you want to edit them, i don't think VE's code will be of much help. [18:45:12] MatmaRex: I want to build tools in JavaScript for processing Wiki tables (from Wikipedia)... VE is a nice example (I am very impressed of VE features like cell edition, since VE does not lose the original Wiki information and allows adequate treatment). [18:45:37] MatmaxRex: the trick is that Parsoid produces raw and rather strange/ad-hoc HTML for returning the Wiki information, and I am [18:45:45] (03PS17) 10Esanders: WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [18:46:17] MatmaxRex: hoping to understand how Parsoid HTML is processed in VE, especially for tables [18:48:44] macker_: hmm, how is it strange? it's just HTML tables. with some extra attributes you can probably ignore. [18:49:23] macker_: VE doesn't directly work with the HTML, it parses the HTML into its own data model (ve.dm.Converter) and works with that [18:54:59] MatmaRex: yes I have understood this part (HTML => data model)... but I guess specific attributes are useful for correctly handling stuff like transclusion [18:56:03] MatmaRex: maybe Parsoid is doing the thing I want and I was too feared by the specific attributes/strange HTML generated [18:56:09] 10VisualEditor, 10OOjs-UI, 10Regression: DraggableElement / DraggableGroupElement should have no skin styles applied. - https://phabricator.wikimedia.org/T168745#3375500 (10Esanders) [18:57:09] 10VisualEditor, 10OOjs-UI, 10Browser-Support-Firefox: VE > Insert > Template > Show options: Sidebar has unnecessary scroll on FF - https://phabricator.wikimedia.org/T161798#3375516 (10matmarex) a:03matmarex [18:57:13] 10VisualEditor, 10VisualEditor-MediaWiki: Transclusion options are messed up in multiple ways - https://phabricator.wikimedia.org/T168740#3375517 (10matmarex) a:03matmarex [18:58:03] (03PS1) 10Esanders: GalleryDialog: Downstream fix for DraggableElement padding [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361088 (https://phabricator.wikimedia.org/T168745) [18:58:43] (03PS2) 10Esanders: GalleryDialog: Downstream fix for DraggableElement padding [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361088 (https://phabricator.wikimedia.org/T168745) [19:07:03] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review: Transclusion options are messed up in multiple ways - https://phabricator.wikimedia.org/T168740#3375564 (10matmarex) After the fixes: {F8516356} {F8516358} [19:13:21] (03PS1) 10Esanders: GalleryDialog: Re-order and make margins even [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361094 [19:17:14] (03PS2) 10Esanders: GalleryDialog: Re-order and make margins even [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361094 [19:17:16] (03PS18) 10Esanders: WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [19:22:54] (03PS19) 10Esanders: WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [21:01:41] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361172 (owner: 10L10n-bot) [21:02:02] 10VisualEditor, 10VisualEditor-MediaWiki: Unexpected loading of VisualEditor after Special:RevisionDelete submission - https://phabricator.wikimedia.org/T168533#3375760 (10Krinkle)