[07:17:31] 10VisualEditor, 10MobileFrontend: Be able to edit lead with no or hidden content on mobile - https://phabricator.wikimedia.org/T168815#3385138 (10Tacsipacsi) It is very common on Wikipedia, although not in articles: navboxes that have no documentation, like [[https://hu.m.wikipedia.org/wiki/Sablon:Újpest_FC_ke... [08:41:24] 10VisualEditor, 10MediaWiki-extensions-General, 10Technical-Debt, 10User-Ryasmeen: Update extensions not to use deprecated EditPageBeforeEditChecks hook - https://phabricator.wikimedia.org/T161809#3385357 (10Jdforrester-WMF) 05Open>03Resolved [10:42:00] 10Citoid, 10VisualEditor, 10User-Josve05a: Validate (more) PMCIDs - https://phabricator.wikimedia.org/T155887#3385800 (10Deskana) p:05Triage>03Normal [11:40:11] 10VisualEditor, 10Community-Liaisons, 10Editing-team: Future of the visual editor newsletter - https://phabricator.wikimedia.org/T139305#3385913 (10Elitre) We should also bear T104131 in mind. [11:44:18] 10VisualEditor: Coordinates template gets caught in new heading because it's invisible - https://phabricator.wikimedia.org/T168616#3385957 (10Elitre) Top right is where it appears anyway, but (quoting myself and en.wp policy), //per WP:ORDER, the template is placed in articles after any navigation templates (be... [11:44:54] 10VisualEditor: VE occasionally opens a link within a template instead of the template's settings when clicked - https://phabricator.wikimedia.org/T168638#3385958 (10Elitre) That's what I suspect as well. [11:54:46] 10VisualEditor, 10Browser-Support-Firefox, 10OOjs-UI (OOjs-UI-0.22.2), 10User-Ryasmeen: VE > Insert > Template > Show options: Sidebar has unnecessary scroll on FF - https://phabricator.wikimedia.org/T161798#3386031 (10Jdforrester-WMF) 05Open>03Resolved [11:56:24] 10VisualEditor, 10VisualEditor-VisualDiffs: [Regression ?] Getting error "Uncaught TypeError: Cannot read property 'top' of null" in the console, while switching from visual diff to wikitext diff or to save page - https://phabricator.wikimedia.org/T167892#3386042 (10Jdforrester-WMF) [11:57:26] 10VisualEditor, 10VisualEditor-CopyPaste, 10Browser-Support-Apple-Safari: Can't drag-and-drop text to rearrange (cut and paste) in Safari - https://phabricator.wikimedia.org/T168901#3386044 (10Jdforrester-WMF) [11:57:59] 10Citoid, 10VisualEditor: Help the community configure citoid on gdwiki - https://phabricator.wikimedia.org/T168937#3386045 (10Jdforrester-WMF) [11:58:43] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Math, 10Epic: Consider showing minimised diff when changing mathematical function - https://phabricator.wikimedia.org/T161076#3386049 (10Jdforrester-WMF) [11:58:51] 10Citoid, 10VisualEditor, 10Services: Request.logger doesn't log requestID in subsequent calls - https://phabricator.wikimedia.org/T102986#3386051 (10Jdforrester-WMF) [11:59:07] 10VisualEditor, 10Timeless: VE in Timeless makes cactions non-responsive, trapping users forever - https://phabricator.wikimedia.org/T162503#3386054 (10Jdforrester-WMF) [11:59:46] 10VisualEditor, 10Technical-Debt: Move out skin-specific stylesheets for Vector, MonoBook, Apex and Minerva to their respective repositories - https://phabricator.wikimedia.org/T161374#3386056 (10Jdforrester-WMF) [12:00:59] 10VisualEditor, 10MediaWiki-Interface, 10Parsoid: Expose `modules` and `jsconfigvars` from Parse API in Parsoid when converting wikitext - https://phabricator.wikimedia.org/T139852#3386059 (10Jdforrester-WMF) [12:01:43] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Patch-For-Review, 10User-Josve05a: Allow user to switch cite template in limited circumstances - https://phabricator.wikimedia.org/T97936#3386062 (10Jdforrester-WMF) p:05Normal>03Low [12:02:02] 10VisualEditor, 10Discovery, 10RelatedArticles, 10UI-Standardization, and 3 others: Align the style for lists of pages - https://phabricator.wikimedia.org/T153417#3386064 (10Jdforrester-WMF) [12:02:22] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki: Find the phrase "ISBN" from ISBN magic links with Find and replace - https://phabricator.wikimedia.org/T121315#3386080 (10Jdforrester-WMF) [12:08:36] 10VisualEditor, 10Technical-Debt: VisualEditor: Extract red link API code from VE and put into Parsoid - https://phabricator.wikimedia.org/T64803#3386129 (10Jdforrester-WMF) >>! In T64803#3380142, @Esanders wrote: > Red link code is now in Parsoid so can be removed from VE Will need us to round-trip new links... [12:16:43] (03CR) 10Jforrester: [C: 032] Fix TOC meta item detection [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/360989 (owner: 10Esanders) [12:31:33] (03Merged) 10jenkins-bot: Fix TOC meta item detection [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/360989 (owner: 10Esanders) [12:31:35] (03Merged) 10jenkins-bot: Keep TOC in correct place in document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358928 (owner: 10Esanders) [12:35:49] (03CR) 10jenkins-bot: Fix TOC meta item detection [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/360989 (owner: 10Esanders) [12:39:59] (03CR) 10jenkins-bot: Keep TOC in correct place in document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358928 (owner: 10Esanders) [13:31:15] 10VisualEditor: Sometimes the edit direction changes from l-to-r to r-to-l even if the content language is l-to-r - https://phabricator.wikimedia.org/T166239#3289470 (10Deskana) I cannot reproduce this problem. @jeblad Could you provide a screen recording showing this problem? It will be difficult to fix if it... [13:33:57] (03Abandoned) 10Esanders: Fix instantly closing progress bars in jQuery 3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354658 (owner: 10Esanders) [13:35:55] 10VisualEditor: Coordinates template gets caught in new heading because it's invisible - https://phabricator.wikimedia.org/T168616#3386459 (10Deskana) >>! In T168616#3385957, @Elitre wrote: > Top right is where it appears anyway, but (quoting myself and en.wp policy), //per WP:ORDER, the template is placed in a... [13:41:57] (03CR) 10Jforrester: "Needs investigation; probably Vector or MW core adding odd additional styling to s, at a quick guess." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354679 (https://phabricator.wikimedia.org/T165865) (owner: 10Bartosz Dziewoński) [13:43:52] (03PS1) 10Esanders: DiffElement: Add hacky support for template-defined references [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361859 [13:52:48] (03PS1) 10Esanders: Remove custom icon sizing from block slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361861 [14:00:37] (03CR) 10Jforrester: [C: 032] Remove custom icon sizing from block slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361861 (owner: 10Esanders) [14:08:40] (03Merged) 10jenkins-bot: Remove custom icon sizing from block slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361861 (owner: 10Esanders) [14:15:52] (03CR) 10jenkins-bot: Remove custom icon sizing from block slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361861 (owner: 10Esanders) [14:16:55] 10VisualEditor, 10MediaWiki-Interface, 10Parsoid: Expose `modules` and `jsconfigvars` from Parse API in Parsoid when converting wikitext - https://phabricator.wikimedia.org/T139852#3386818 (10ssastry) @Jdforrester-WMF Note that in T139852#3160428 I am saying that this is a VE issue, not a Parsoid one. The Pa... [14:25:36] 10VisualEditor, 10MediaWiki-Interface, 10Parsoid: Expose `modules` and `jsconfigvars` from Parse API in Parsoid when converting wikitext - https://phabricator.wikimedia.org/T139852#3386844 (10Jdforrester-WMF) Ah, OK. [14:25:54] 10VisualEditor, 10MediaWiki-Interface, 10Parsoid: Expose `modules` and `jsconfigvars` from Parse API in Parsoid when converting wikitext - https://phabricator.wikimedia.org/T139852#3386846 (10Jdforrester-WMF) [14:26:14] 10VisualEditor, 10MediaWiki-Interface: Expose `modules` and `jsconfigvars` from Parsoid's parse API when converting wikitext - https://phabricator.wikimedia.org/T139852#2444530 (10Jdforrester-WMF) p:05Normal>03Low [14:26:54] 10VisualEditor, 10MediaWiki-Interface, 10Technical-Debt: Expose `modules` and `jsconfigvars` from Parsoid's parse API when converting wikitext - https://phabricator.wikimedia.org/T139852#2444530 (10Jdforrester-WMF) [14:42:12] (03PS3) 10Jforrester: rebaser: Make serializations shorter (2nd attempt) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354659 (owner: 10Esanders) [14:49:41] (03CR) 10jerkins-bot: [V: 04-1] rebaser: Make serializations shorter (2nd attempt) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354659 (owner: 10Esanders) [14:50:59] (03CR) 10Jforrester: [C: 04-1] "Unit test failure appears real?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354659 (owner: 10Esanders) [14:52:00] 10VisualEditor, 10Patch-For-Review: Table row context menu appears too far below - https://phabricator.wikimedia.org/T165865#3387015 (10matmarex) Yes, I've been working on some higher priority issues (this is mostly just a cosmetic problem) but I'll look into it now. [15:04:52] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review: Pasting annotated wikitext results in double encoding and therefore s - https://phabricator.wikimedia.org/T153315#3387085 (10Esanders) Firstly I think we should be able to address the issue of... [15:07:50] (03PS4) 10Bartosz Dziewoński: ve.ui.TableLineContext: Fancier popups [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354679 (https://phabricator.wikimedia.org/T165865) [15:20:26] (03PS1) 10Esanders: Ignore covering annotations when looking for plain text pastes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361882 (https://phabricator.wikimedia.org/T153315) [15:24:54] (03CR) 10Jforrester: [C: 032] Ignore covering annotations when looking for plain text pastes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361882 (https://phabricator.wikimedia.org/T153315) (owner: 10Esanders) [15:29:10] (03Merged) 10jenkins-bot: Ignore covering annotations when looking for plain text pastes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361882 (https://phabricator.wikimedia.org/T153315) (owner: 10Esanders) [15:43:46] (03CR) 10jenkins-bot: Ignore covering annotations when looking for plain text pastes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361882 (https://phabricator.wikimedia.org/T153315) (owner: 10Esanders) [15:46:10] (03PS1) 10DLynch: dm.Document fixupInsertion: check suggestedParents as well [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361888 (https://phabricator.wikimedia.org/T164017) [15:50:05] (03PS1) 10DLynch: dm.SurfaceFragment tests: exercise fixupInsertion for mwHeadings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361890 (https://phabricator.wikimedia.org/T164017) [15:50:42] (03CR) 10DLynch: "This is going to fail until the fixupInsertion change gets pulled through." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361890 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [16:01:29] (03CR) 10jerkins-bot: [V: 04-1] dm.SurfaceFragment tests: exercise fixupInsertion for mwHeadings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361890 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [16:05:05] (03PS2) 10Jforrester: dm.SurfaceFragment tests: exercise fixupInsertion for mwHeadings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361890 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [16:05:23] (03PS2) 10Jforrester: dm.Document fixupInsertion: check suggestedParents as well [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361888 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [16:05:29] (03CR) 10jerkins-bot: [V: 04-1] dm.SurfaceFragment tests: exercise fixupInsertion for mwHeadings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361890 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [16:06:21] (03CR) 10Jforrester: dm.Document fixupInsertion: check suggestedParents as well (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361888 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [16:07:04] (03CR) 10DLynch: dm.Document fixupInsertion: check suggestedParents as well (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361888 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [16:08:46] (03PS3) 10DLynch: dm.Document fixupInsertion: check suggestedParents as well [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361888 (https://phabricator.wikimedia.org/T164017) [16:10:28] (03CR) 10Jforrester: "Ta. :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361888 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [16:12:49] (03CR) 10Esanders: "Would probably be good if we brought over at least one of the MW tests using a mock node, i.e. DocumentChildOnlyNode" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361890 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [16:13:15] (03CR) 10Esanders: "Above comment was meant for the core patch." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361890 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [16:13:21] (03CR) 10Esanders: "Would probably be good if we brought over at least one of the MW tests using a mock node, i.e. DocumentChildOnlyNode" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361888 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [16:47:48] 10VisualEditor, 10Mobile-Content-Service, 10Reading-Infrastructure-Team-Backlog, 10Services (designing): Support flagged revisions in RESTBase - https://phabricator.wikimedia.org/T169116#3387595 (10GWicke) [16:52:43] 10Citoid, 10VisualEditor, 10ProveIt-Gadget, 10User-Ryasmeen: Add Citoid support to ProveIt - https://phabricator.wikimedia.org/T148226#3387621 (10Iniquity) @Sophivorus thanks a lot! xD [16:53:14] (03PS4) 10DLynch: dm.Document fixupInsertion: check suggestedParents as well [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361888 (https://phabricator.wikimedia.org/T164017) [16:54:10] (03CR) 10DLynch: "> Would probably be good if we brought over at least one of the MW" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361888 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [17:10:12] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/361888/4 [17:12:37] (03CR) 10Jforrester: [C: 031] dm.Document fixupInsertion: check suggestedParents as well [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361888 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [17:18:38] (03PS12) 10C. Scott Ananian: Display LanguageConverter markup in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356739 (https://phabricator.wikimedia.org/T49411) [17:18:40] (03PS5) 10C. Scott Ananian: WIP: Node inspector and dialog for LanguageConverter markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358396 (https://phabricator.wikimedia.org/T49411) [17:23:31] (03PS13) 10C. Scott Ananian: Display LanguageConverter markup in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356739 (https://phabricator.wikimedia.org/T49411) [17:23:33] (03PS6) 10C. Scott Ananian: WIP: Node inspector and dialog for LanguageConverter markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358396 (https://phabricator.wikimedia.org/T49411) [17:34:15] (03CR) 10jerkins-bot: [V: 04-1] WIP: Node inspector and dialog for LanguageConverter markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358396 (https://phabricator.wikimedia.org/T49411) (owner: 10C. Scott Ananian) [17:34:56] (03CR) 10Esanders: [C: 031] dm.Document fixupInsertion: check suggestedParents as well (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361888 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [17:36:37] (03PS5) 10DLynch: dm.Document fixupInsertion: check suggestedParents as well [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361888 (https://phabricator.wikimedia.org/T164017) [17:36:47] (03CR) 10DLynch: dm.Document fixupInsertion: check suggestedParents as well (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361888 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [17:40:31] (03CR) 10Esanders: [C: 032] dm.Document fixupInsertion: check suggestedParents as well [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361888 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [17:46:30] (03Merged) 10jenkins-bot: dm.Document fixupInsertion: check suggestedParents as well [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361888 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [17:49:14] (03CR) 10jenkins-bot: dm.Document fixupInsertion: check suggestedParents as well [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361888 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [17:51:33] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror: Investigation: CodeMirror + New WikiText Editor syncing issues - https://phabricator.wikimedia.org/T161052#3387834 (10kaldari) Let's test this out after CodeMirror is deployed to Test Wikipedia. [17:52:26] (03PS5) 10Bartosz Dziewoński: ve.ui.TableLineContext: Fancier popups [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354679 (https://phabricator.wikimedia.org/T165865) [17:52:56] (03CR) 10Bartosz Dziewoński: "Better now." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354679 (https://phabricator.wikimedia.org/T165865) (owner: 10Bartosz Dziewoński) [17:56:06] 10VisualEditor: VE occasionally opens a link within a template instead of the template's settings when clicked - https://phabricator.wikimedia.org/T168638#3370603 (10Alsee) Based on the video , it looks like the blue box was't fully covering the link. Hypothesis: If rendering of the blue box is delayed or the lo... [18:02:22] (03PS10) 10Esanders: Visual Diff: add internal list diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/355716 (https://phabricator.wikimedia.org/T162819) (owner: 10Tchanders) [18:02:24] (03PS2) 10Esanders: DiffElement: Add hacky support for template-defined references [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361859 [18:07:16] James_F: Gemfile and .rubocop were added to support the Ruby selenium tests - I assume they aren't needed anymore or does jsduck use them in some way? [18:13:02] (03CR) 10Tchanders: [C: 032] DiffElement: Add hacky support for template-defined references [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361859 (owner: 10Esanders) [18:17:42] (03CR) 10Esanders: [C: 032] Visual Diff: add internal list diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/355716 (https://phabricator.wikimedia.org/T162819) (owner: 10Tchanders) [18:19:59] (03Merged) 10jenkins-bot: Visual Diff: add internal list diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/355716 (https://phabricator.wikimedia.org/T162819) (owner: 10Tchanders) [18:22:29] (03Merged) 10jenkins-bot: DiffElement: Add hacky support for template-defined references [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361859 (owner: 10Esanders) [18:22:31] (03CR) 10jenkins-bot: Visual Diff: add internal list diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/355716 (https://phabricator.wikimedia.org/T162819) (owner: 10Tchanders) [18:27:07] (03CR) 10jenkins-bot: DiffElement: Add hacky support for template-defined references [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/361859 (owner: 10Esanders) [18:32:48] (03PS7) 10C. Scott Ananian: Context item for LanguageConverter markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/358396 (https://phabricator.wikimedia.org/T49411) [18:32:50] (03PS1) 10C. Scott Ananian: WIP: Dialog for editing LanguageConverter markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361921 (https://phabricator.wikimedia.org/T49411) [18:50:40] (03CR) 10jerkins-bot: [V: 04-1] WIP: Dialog for editing LanguageConverter markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361921 (https://phabricator.wikimedia.org/T49411) (owner: 10C. Scott Ananian) [19:11:26] (03PS1) 10Jforrester: build: Drop all Ruby-related CI files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361929 [19:11:53] edsanders: https://gerrit.wikimedia.org/r/361929 , happy? :-) [19:20:36] 10VisualEditor, 10Mobile-Content-Service, 10RESTBase, 10RESTBase-API, and 2 others: Support flagged revisions in RESTBase - https://phabricator.wikimedia.org/T169116#3388181 (10mobrovac) I favour the first option as well. Not only is it the most straightforward, it is also the expected behaviour form clien... [19:20:45] (03CR) 10jerkins-bot: [V: 04-1] build: Drop all Ruby-related CI files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361929 (owner: 10Jforrester) [19:23:43] (03CR) 10Jforrester: [C: 032] ve.ui.TableLineContext: Fancier popups [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354679 (https://phabricator.wikimedia.org/T165865) (owner: 10Bartosz Dziewoński) [19:28:15] (03Merged) 10jenkins-bot: ve.ui.TableLineContext: Fancier popups [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354679 (https://phabricator.wikimedia.org/T165865) (owner: 10Bartosz Dziewoński) [19:31:53] (03CR) 10jenkins-bot: ve.ui.TableLineContext: Fancier popups [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354679 (https://phabricator.wikimedia.org/T165865) (owner: 10Bartosz Dziewoński) [19:36:28] (03PS3) 10Jforrester: dm.SurfaceFragment tests: exercise fixupInsertion for mwHeadings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361890 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [19:36:31] 10VisualEditor, 10Wikimedia-log-errors: Argument 2 passed to VisualEditorHooks::onDiffViewHeader() must be an instance of Revision, null given - https://phabricator.wikimedia.org/T169132#3388262 (10mmodell) [19:36:48] (03CR) 10Jforrester: "Rebased onto c558be1208d7adcfc33ae6a0f3eef81ff153a45a to verify that CI likes it, ahead of squashing them together." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361890 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [19:36:50] 10VisualEditor, 10Wikimedia-log-errors: Argument 2 passed to VisualEditorHooks::onDiffViewHeader() must be an instance of Revision, null given - https://phabricator.wikimedia.org/T169132#3388274 (10mmodell) [19:43:17] (03PS1) 10Jforrester: VisualEditorHooks#onDiffViewHeader: Don't add type hint as the hook sucks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361938 (https://phabricator.wikimedia.org/T169132) [19:44:31] (03CR) 10jerkins-bot: [V: 04-1] dm.SurfaceFragment tests: exercise fixupInsertion for mwHeadings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361890 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [19:45:58] (03CR) 10DLynch: "Still fails in the expected way, at least. Now we just need to rebase that base commit onto a pullthrough." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361890 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [19:46:26] (03PS1) 10Jforrester: Update VE core submodule to master (b528a5321) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361940 (https://phabricator.wikimedia.org/T153315) [19:46:59] (03CR) 10Jforrester: "Umm. I'm an idiot. I meant to put this on top of d7747cb91." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361890 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [19:47:03] (03PS4) 10Jforrester: dm.SurfaceFragment tests: exercise fixupInsertion for mwHeadings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361890 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [19:47:18] Kemayo: Sorry. :-) [19:48:08] (03CR) 10DLynch: "Subtle difference. :D" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361890 (https://phabricator.wikimedia.org/T164017) (owner: 10DLynch) [19:49:27] Keegan: Could you merge https://gerrit.wikimedia.org/r/361938 ? UBN affecting production. :-( [19:49:30] Bah. [19:49:34] Kemayo: ^^ [19:51:02] (03CR) 10DLynch: [C: 032] VisualEditorHooks#onDiffViewHeader: Don't add type hint as the hook sucks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361938 (https://phabricator.wikimedia.org/T169132) (owner: 10Jforrester) [19:51:23] Seems like something unobjectionable, apart from in the sense that the need to do it suggests other problems. [19:52:28] Yeah, the problem is that PHP freaks out when you type-hint something and then pass in null. [19:52:36] And the hook is… poorly designed, shall we say. [19:54:08] (03PS1) 1020after4: VisualEditorHooks#onDiffViewHeader: Don't add type hint as the hook sucks [extensions/VisualEditor] (wmf/1.30.0-wmf.7) - 10https://gerrit.wikimedia.org/r/361941 (https://phabricator.wikimedia.org/T169132) [19:55:18] (03CR) 1020after4: [C: 032] VisualEditorHooks#onDiffViewHeader: Don't add type hint as the hook sucks [extensions/VisualEditor] (wmf/1.30.0-wmf.7) - 10https://gerrit.wikimedia.org/r/361941 (https://phabricator.wikimedia.org/T169132) (owner: 1020after4) [19:58:31] (03PS5) 10Jforrester: Update VE core submodule to master (b528a5321) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361890 (https://phabricator.wikimedia.org/T153315) (owner: 10DLynch) [19:58:57] Magic! [20:01:50] (03Merged) 10jenkins-bot: VisualEditorHooks#onDiffViewHeader: Don't add type hint as the hook sucks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361938 (https://phabricator.wikimedia.org/T169132) (owner: 10Jforrester) [20:06:44] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: {{formatnum:…}}) cannot be edited - https://phabricator.wikimedia.org/T51954#3388371 (10Danmichaelo) p:05Low>03Normal [20:06:50] (03CR) 10Bartosz Dziewoński: "`Revision $oldRev = null` would also work." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361938 (https://phabricator.wikimedia.org/T169132) (owner: 10Jforrester) [20:08:50] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: {{formatnum:…}}) cannot be edited - https://phabricator.wikimedia.org/T51954#545744 (10Danmichaelo) Was hit by this limitation when I was editing an article now. Couldn't find any way to edit the number except to delete it, so I changed the title to r... [20:12:18] (03Merged) 10jenkins-bot: VisualEditorHooks#onDiffViewHeader: Don't add type hint as the hook sucks [extensions/VisualEditor] (wmf/1.30.0-wmf.7) - 10https://gerrit.wikimedia.org/r/361941 (https://phabricator.wikimedia.org/T169132) (owner: 1020after4) [20:14:07] (03CR) 10jenkins-bot: VisualEditorHooks#onDiffViewHeader: Don't add type hint as the hook sucks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361938 (https://phabricator.wikimedia.org/T169132) (owner: 10Jforrester) [20:17:08] 10VisualEditor, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-Ryasmeen, 10Wikimedia-log-errors: Argument 2 passed to VisualEditorHooks::onDiffViewHeader() must be an instance of Revision, null given - https://phabricator.wikimedia.org/T169132#3388392 (10mmodell) 05Open>03Resolved a:... [20:23:17] 10VisualEditor, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-Ryasmeen, 10Wikimedia-log-errors: Argument 2 passed to VisualEditorHooks::onDiffViewHeader() must be an instance of Revision, null given - https://phabricator.wikimedia.org/T169132#3388435 (10mmodell) a:05mmodell>03Jdforre... [20:24:15] 10VisualEditor, 10VisualEditor-CopyPaste: Drag and drop (cut and paste) didn't work in Chrome - https://phabricator.wikimedia.org/T169136#3388438 (10Whatamidoing-WMF) [21:13:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/362049 (owner: 10L10n-bot) [21:16:26] (03PS1) 1020after4: Set onDiffViewHeader argument defaults = null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/362064 (https://phabricator.wikimedia.org/T169132) [21:22:15] 10VisualEditor, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.8)), 10Patch-For-Review, 10Release-Engineering-Team (Kanban), and 2 others: Argument 2 passed to VisualEditorHooks::onDiffViewHeader() must be an instance of Revision, null given - https://phabricator.wikimedia.org/T169132#3388651 (1... [21:24:20] 10VisualEditor, 10Revision-Slider, 10TCB-Team, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.8)), and 4 others: Argument 2 passed to VisualEditorHooks::onDiffViewHeader() must be an instance of Revision, null given - https://phabricator.wikimedia.org/T169132#3388652 (10mmodell) 05Resolved>0... [21:25:55] 10VisualEditor, 10Revision-Slider, 10TCB-Team, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.8)), and 4 others: Argument 2 passed to VisualEditorHooks::onDiffViewHeader() must be an instance of Revision, null given - https://phabricator.wikimedia.org/T169132#3388659 (10mmodell) A better fix as... [21:26:09] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/362072 (owner: 10L10n-bot) [21:26:45] 10VisualEditor, 10Revision-Slider, 10TCB-Team, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.8)), and 4 others: Argument 2 passed to VisualEditorHooks::onDiffViewHeader() must be an instance of Revision, null given - https://phabricator.wikimedia.org/T169132#3388661 (10mmodell) a:05Jdforreste... [21:34:47] 10VisualEditor, 10MediaWiki-extensions-Linter, 10Parsoid: Improve detection of missing quotes in HTML tag attributes - https://phabricator.wikimedia.org/T153203#3388703 (10Arlolra) The Parsoid bug that prevented tokenizing as an html element is fixed, but I'm leaving this open because maybe a linter category... [21:53:11] 10VisualEditor, 10MobileFrontend, 10Design: Mobile edit page shows different content than desktop edit/visual editor - https://phabricator.wikimedia.org/T152058#3388900 (10pmiazga) @Deskana - yes, at the beginning I was trying to edit the whole article by clicking the primary edit action. Then I learned that... [22:01:36] 10VisualEditor, 10MobileFrontend, 10Design: Mobile editor breaks when article has a heading insinde infobox - https://phabricator.wikimedia.org/T152058#3388942 (10Jdlrobson) Adding visualeditor ''project'' tag. [22:02:16] (03CR) 10Jforrester: [C: 032] Set onDiffViewHeader argument defaults = null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/362064 (https://phabricator.wikimedia.org/T169132) (owner: 1020after4) [22:07:03] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Community-Liaisons: Please help htwiki enable citoid (Templates/TemplateData is already done) - https://phabricator.wikimedia.org/T169158#3388977 (10Whatamidoing-WMF) [22:07:15] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Community-Liaisons: Please help htwiki enable citoid (Templates/TemplateData is already done) - https://phabricator.wikimedia.org/T169158#3388977 (10Whatamidoing-WMF) [22:15:05] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (b528a5321) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361940 (https://phabricator.wikimedia.org/T153315) (owner: 10Jforrester) [22:16:03] (03Merged) 10jenkins-bot: Set onDiffViewHeader argument defaults = null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/362064 (https://phabricator.wikimedia.org/T169132) (owner: 1020after4) [22:22:05] (03CR) 10jenkins-bot: Set onDiffViewHeader argument defaults = null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/362064 (https://phabricator.wikimedia.org/T169132) (owner: 1020after4) [22:30:19] (03Merged) 10jenkins-bot: Update VE core submodule to master (b528a5321) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361940 (https://phabricator.wikimedia.org/T153315) (owner: 10Jforrester) [22:34:46] (03CR) 10jenkins-bot: Update VE core submodule to master (b528a5321) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361940 (https://phabricator.wikimedia.org/T153315) (owner: 10Jforrester) [23:10:22] 10VisualEditor, 10VisualEditor-MediaWiki: Almost all links in a navbox marked as red on a specific page - https://phabricator.wikimedia.org/T167936#3389117 (10Nnvu) >>! In T167936#3383655, @matmarex wrote: > @nnvu I only see this issue on specific pages, rather than everywhere. Is it the same for you? Can you... [23:35:59] 10VisualEditor, 10MobileFrontend, 10Reading-Web-Backlog, 10Design: Revisit and amend browser history behaviour for editing experience - https://phabricator.wikimedia.org/T162128#3389172 (10pmiazga) [23:38:18] 10VisualEditor, 10MobileFrontend, 10Reading-Web-Backlog, 10Design: Revisit and amend browser history behaviour for editing experience - https://phabricator.wikimedia.org/T162128#3389179 (10Jdlrobson) See conversation beginning here: https://phabricator.wikimedia.org/T162128#3169309 Probably needs a real li... [23:41:04] 10VisualEditor, 10Collaboration-Team-Triage, 10Flow: Flow toolbar overlaps with mention search - https://phabricator.wikimedia.org/T169076#3389182 (10Catrope) Looks like this is a bug with VisualEditor's bottom toolbar support [23:42:37] 10VisualEditor, 10MobileFrontend, 10Design: Mobile editor breaks when article has a heading insinde infobox - https://phabricator.wikimedia.org/T152058#3389185 (10pmiazga) @Jdlrobson thanks for re-adding `VisualEditor` label, I thought `VisualEditor` tag is used only for visual editor feature.