[04:12:20] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (31ed22557) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365423 (https://phabricator.wikimedia.org/T170114) (owner: 10Jforrester) [04:29:13] (03Merged) 10jenkins-bot: Update VE core submodule to master (31ed22557) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365423 (https://phabricator.wikimedia.org/T170114) (owner: 10Jforrester) [04:33:33] (03CR) 10jenkins-bot: Update VE core submodule to master (31ed22557) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365423 (https://phabricator.wikimedia.org/T170114) (owner: 10Jforrester) [05:54:32] (03PS1) 10Prtksxna: Replace TextInputWidget (multiline) with MultilineTextInputWidget [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/365550 (https://phabricator.wikimedia.org/T170275) [06:24:09] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Design, 10User-Ryasmeen: Should we indicate to users that visual diffs are in beta? - https://phabricator.wikimedia.org/T170156#3442642 (10Prtksxna) >>! In T170156#3436415, @Pginer-WMF wrote: > I used a placeholder icon trying to pick from the existing ones in... [06:39:17] 10VisualEditor: [[Linkhttps://en.wikipedia.org/wiki/Link|Link]] is always wrong - https://phabricator.wikimedia.org/T88502#3442646 (10Whatamidoing-WMF) Maybe? I haven't run across this particular error since then. [07:15:26] 10VisualEditor, 10Design: Please rearrange the order of items in the Insert menu - https://phabricator.wikimedia.org/T169801#3442706 (10Prtksxna) Yes, functionality that is used more often should be easier to access. I couldn't find any information on why the menu items are ordered the way they currently are,... [08:22:09] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: After checking the preview, the NWE appears one more plus (+) icon after the categories - https://phabricator.wikimedia.org/T170748#3441491 (10Schnark) This is a bug in the HotCat gadget, which reacts poorly to the `wikipage.content` hook. HotCat bug... [09:35:15] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Replace TextInputWidget (multiline) with MultilineTextInputWidget [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/365550 (https://phabricator.wikimedia.org/T170275) (owner: 10Prtksxna) [09:58:23] 10Citoid, 10VisualEditor, 10Operations, 10Services (blocked), 10User-mobrovac: Wiley requests for DOI and some other publishers don't work in production - https://phabricator.wikimedia.org/T165105#3443024 (10Samwalton9) I'm told that Wiley "should be able to provide the necessary info this week." [10:36:12] 10Citoid, 10VisualEditor, 10Operations, 10Services (blocked), 10User-mobrovac: Wiley requests for DOI and some other publishers don't work in production - https://phabricator.wikimedia.org/T165105#3443097 (10Mvolz) Thanks for chasing this down @Samwalton9! [12:20:07] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff shows changes to reference numbers caused by inserting more references - https://phabricator.wikimedia.org/T170235#3443253 (10Deskana) Note: this bug is limited to the visual diff provided from the history page, and are //not// reproducible with the visua... [12:20:21] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff (on history page) shows changes to reference numbers caused by inserting more references - https://phabricator.wikimedia.org/T170235#3443254 (10Deskana) [12:23:29] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff (on history page) shows changes to reference numbers caused by inserting more references - https://phabricator.wikimedia.org/T170235#3443255 (10Pginer-WMF) >>! In T170235#3439017, @Deskana wrote: > I wonder if @Prtksxna or @Pginer-WMF have thoughts on thi... [12:53:40] 10VisualEditor, 10Design: Please rearrange the order of items in the Insert menu - https://phabricator.wikimedia.org/T169801#3443298 (10Pginer-WMF) I agree with @Prtksxna considerations. I just wanted to try to compile usual strategies to deal with complexity in these cases. Depending on the volume of options... [14:17:04] (03CR) 10Esanders: "Ping. Do you want to do that? Do you know where it core it should go?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/363098 (https://phabricator.wikimedia.org/T169574) (owner: 10Bartosz Dziewoński) [14:18:38] (03CR) 10Esanders: [C: 032] Fix wikitext preview in IE and Edge [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365245 (https://phabricator.wikimedia.org/T170466) (owner: 10Bartosz Dziewoński) [14:23:23] (03CR) 10Esanders: "The tests pass in isolation, but fail as part of the suite. Maybe QUnit has changed setup/teardown environment behaviour?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/365039 (https://phabricator.wikimedia.org/T170585) (owner: 10Jforrester) [14:29:43] (03Merged) 10jenkins-bot: Fix wikitext preview in IE and Edge [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365245 (https://phabricator.wikimedia.org/T170466) (owner: 10Bartosz Dziewoński) [14:33:04] (03CR) 10Esanders: "Yup, they've been renamed to beforeEach/afterEach: https://qunitjs.com/upgrade-guide-2.x/#rename-module-hooks" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/365039 (https://phabricator.wikimedia.org/T170585) (owner: 10Jforrester) [14:33:26] (03PS2) 10Esanders: build: Upgrade QUnit to 2.x [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/365039 (https://phabricator.wikimedia.org/T170585) (owner: 10Jforrester) [14:35:36] (03CR) 10Esanders: "FYI: We also use 'setup' in a few places in ve-mw & ve-cite" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/365039 (https://phabricator.wikimedia.org/T170585) (owner: 10Jforrester) [14:37:48] (03CR) 10Esanders: [C: 032] Drop local 'template' icon, use 'puzzle' from upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/363631 (https://phabricator.wikimedia.org/T111041) (owner: 10Jforrester) [14:42:02] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Can't move images to a different location - https://phabricator.wikimedia.org/T170693#3439603 (10Esanders) WFM in Firefox + Ubuntu and Firefox + OSX. The image goes grey, and I get a horizontal line showing me where the image will land. [14:48:30] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Can't move images to a different location - https://phabricator.wikimedia.org/T170693#3439603 (10Deskana) @Whatamidoing-WMF Which article was this on? I'm getting inconsistent behaviour when trying to move images, but I was trying it in an article that had a ton... [14:59:28] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Can't move images to a different location - https://phabricator.wikimedia.org/T170693#3443918 (10Deskana) 05Open>03Invalid I can't reproduce this. It seems to work just fine on articles other than the one that was a total mess of images. Given that two of us... [15:05:28] (03CR) 10jenkins-bot: Fix wikitext preview in IE and Edge [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365245 (https://phabricator.wikimedia.org/T170466) (owner: 10Bartosz Dziewoński) [15:09:30] (03Merged) 10jenkins-bot: Drop local 'template' icon, use 'puzzle' from upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/363631 (https://phabricator.wikimedia.org/T111041) (owner: 10Jforrester) [15:11:10] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Microsoft-Edge, 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), and 2 others: Show preview stopped working in Microsoft Edge - https://phabricator.wikimedia.org/T170466#3443961 (10Deskana) 05Open>03Resolved [15:16:54] (03CR) 10jenkins-bot: Drop local 'template' icon, use 'puzzle' from upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/363631 (https://phabricator.wikimedia.org/T111041) (owner: 10Jforrester) [15:27:19] 10VisualEditor, 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), 10Technical-Debt: Upgrade VisualEditor to QUnit 2 - https://phabricator.wikimedia.org/T170585#3444039 (10Jdforrester-WMF) [15:27:37] (03CR) 10Jforrester: [C: 031] "Neat." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/365039 (https://phabricator.wikimedia.org/T170585) (owner: 10Jforrester) [15:34:07] (03CR) 10Jforrester: [C: 032] Replace TextInputWidget (multiline) with MultilineTextInputWidget [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/365550 (https://phabricator.wikimedia.org/T170275) (owner: 10Prtksxna) [15:34:59] 10VisualEditor, 10VisualEditor-VisualDiffs, 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), 10User-Ryasmeen: Hard to spot removing a space near a line break in the visual diff - https://phabricator.wikimedia.org/T170114#3444094 (10Jdforrester-WMF) [15:35:06] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Accessibility, 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), 10User-Ryasmeen: Use inside

in VisualDiffs - https://phabricator.wikimedia.org/T170136#3444095 (10Jdforrester-WMF) [15:35:24] 10VisualEditor, 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), 10OOjs-UI (OOjs-UI-0.22.3), 10User-Ryasmeen: Duplicate icons: 'puzzle' icon and 'template' (in VE) - https://phabricator.wikimedia.org/T111041#3444096 (10Jdforrester-WMF) [15:36:47] (03Merged) 10jenkins-bot: Replace TextInputWidget (multiline) with MultilineTextInputWidget [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/365550 (https://phabricator.wikimedia.org/T170275) (owner: 10Prtksxna) [15:37:00] (03CR) 10jenkins-bot: Replace TextInputWidget (multiline) with MultilineTextInputWidget [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/365550 (https://phabricator.wikimedia.org/T170275) (owner: 10Prtksxna) [15:38:09] 10VisualEditor: [[Linkhttps://en.wikipedia.org/wiki/Link|Link]] is always wrong - https://phabricator.wikimedia.org/T88502#3444112 (10Jdforrester-WMF) [15:38:13] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10Design, 10User-Ryasmeen, 10VisualEditor 2014/15 Q4 blockers: External link interface for link dialogue - https://phabricator.wikimedia.org/T76398#3444115 (10Jdforrester-WMF) [15:56:48] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Microsoft-Edge, 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), 10User-Ryasmeen: Show preview stopped working in Microsoft Edge - https://phabricator.wikimedia.org/T170466#3444261 (10Jdforrester-WMF) [15:56:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), 10User-Ryasmeen, 10User-Urbanecm: Welcome to Wikipedia message is shown even if page is protected - https://phabricator.wikimedia.org/T138715#3444263 (10Jdforrester-WMF) [16:20:49] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design, 10Epic: Provide a system for prompting the user to do things as they edit - https://phabricator.wikimedia.org/T110644#3444447 (10Jdforrester-WMF) [16:20:51] 10VisualEditor, 10VisualEditor-DataModel, 10MW-1.28-release (WMF-deploy-2016-06-28_(1.28.0-wmf.8)), 10Technical-Debt, 10User-Ryasmeen: Create a generic type-indexed node cache - https://phabricator.wikimedia.org/T135950#3444444 (10Jdforrester-WMF) 05Open>03Resolved This should have been marked as fix... [16:28:40] 10VisualEditor, 10TemplateStyles: Add class mw-parser-output to VE's editing area - https://phabricator.wikimedia.org/T164790#3444506 (10Jdforrester-WMF) p:05Triage>03Normal [16:40:13] (03PS1) 10Esanders: Move historical diff loading to DiffLoader util [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365644 [16:40:15] (03PS1) 10Esanders: Show visual diffs in wikitext mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365645 (https://phabricator.wikimedia.org/T170371) [16:40:36] (03CR) 10Esanders: [C: 04-2] "As mentioned in the ticket, we should hold off until T170269 is fixed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365645 (https://phabricator.wikimedia.org/T170371) (owner: 10Esanders) [16:58:45] 10VisualEditor, 10TemplateStyles: Add class mw-parser-output to VE's editing area - https://phabricator.wikimedia.org/T164790#3444702 (10Esanders) Adding mw-parser-output to the CE surface is a trivial one line fix. If this class exists solely to support TemplateStyles then it's fine, otherwise it should be no... [17:05:26] (03PS1) 10Esanders: Add mw-parser-output class to CE document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365651 (https://phabricator.wikimedia.org/T164790) [17:19:37] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design: Please rearrange the order of items in the Insert menu - https://phabricator.wikimedia.org/T169801#3444773 (10Jdforrester-WMF) >>! In T169801#3442706, @Prtksxna wrote: > Yes, functionality that is used more often should be easier to access. I couldn't find... [17:21:49] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff (on history page) shows changes to reference numbers caused by inserting more references - https://phabricator.wikimedia.org/T170235#3423910 (10Jdforrester-WMF) Maybe showing this only if the paragraph is touched in another way could work, but then [1][2]... [17:25:57] (03CR) 10Bartosz Dziewoński: "Sorry. Yes. If we want this in core, the addJsConfigVars() call should be in DifferenceEngine::showDiffPage() I guess? I was planning to w" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/363098 (https://phabricator.wikimedia.org/T169574) (owner: 10Bartosz Dziewoński) [17:54:58] 10Citoid, 10VisualEditor: Automated archiving of URLs - https://phabricator.wikimedia.org/T89438#3445018 (10Elitre) Hey czar! Is there a place on https://www.mediawiki.org/wiki/Citoid/Enabling_Citoid_on_your_wiki (or elsewhere) where you could document something about the bot maybe, especially if you welcome/n... [18:12:59] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: [Regression] "Error loading data from server: oldidnotfound: There is no revision with ID 0.. " appears while trying to switch from NWE to VE - https://phabricator.wikimedia.org/T166131#3445072 (10Deskana) Bumping up in priority. [18:57:15] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design: Please rearrange the order of items in the Insert menu - https://phabricator.wikimedia.org/T169801#3445552 (10Whatamidoing-WMF) If we can't have proper sections, then what do you think about fake sections? We could add "Advanced features:" as a grayed-out,... [18:58:32] (03CR) 10Krinkle: [C: 031] "Note that for VE/ve-mw, you can safely do this in two steps if needed given that beforeEach/afterEach already exist in 1.x as well. So you" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/365039 (https://phabricator.wikimedia.org/T170585) (owner: 10Jforrester) [19:00:42] (03CR) 10Krinkle: [C: 032] build: Upgrade QUnit to 2.x [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/365039 (https://phabricator.wikimedia.org/T170585) (owner: 10Jforrester) [19:03:28] (03Merged) 10jenkins-bot: build: Upgrade QUnit to 2.x [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/365039 (https://phabricator.wikimedia.org/T170585) (owner: 10Jforrester) [19:07:25] 10VisualEditor, 10VisualEditor-MediaWiki, 10Technical-Debt: Make VisualEditor-MediaWiki compatible with QUnit 2 - https://phabricator.wikimedia.org/T170872#3445612 (10Jdforrester-WMF) [19:07:51] 10Cite, 10Editing-team, 10Technical-Debt: Make Cite compatible with QUnit 2 - https://phabricator.wikimedia.org/T170873#3445626 (10Jdforrester-WMF) [19:08:09] (03CR) 10jenkins-bot: build: Upgrade QUnit to 2.x [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/365039 (https://phabricator.wikimedia.org/T170585) (owner: 10Jforrester) [19:08:31] (03PS1) 10Krinkle: tests: Simplify Platform test beforeEach/afterEach logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/365681 [19:10:58] (03PS1) 10Jforrester: tests: Make VisualEditor-MediaWiki compatible with QUnit 2 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365682 (https://phabricator.wikimedia.org/T170872) [19:11:44] (03CR) 10Krinkle: build: Upgrade grunt-eslint from 19.0.0 to 20.0.0 (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/362378 (owner: 10Jforrester) [19:15:59] (03CR) 10Krinkle: "Already available indeed, except for when you're using the mw-core provided newMwEnvironment, because that will still add the old setup/te" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365682 (https://phabricator.wikimedia.org/T170872) (owner: 10Jforrester) [19:16:28] (03CR) 10Krinkle: "I intend to upgrade core first and migrate extensions after, by making our wrapper still support setup/teardown as-is." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365682 (https://phabricator.wikimedia.org/T170872) (owner: 10Jforrester) [19:18:15] (03CR) 10Jforrester: "> I intend to upgrade core first and migrate extensions after" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365682 (https://phabricator.wikimedia.org/T170872) (owner: 10Jforrester) [19:22:16] (03CR) 10jerkins-bot: [V: 04-1] tests: Make VisualEditor-MediaWiki compatible with QUnit 2 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365682 (https://phabricator.wikimedia.org/T170872) (owner: 10Jforrester) [19:26:55] 10VisualEditor, 10Technical-Debt, 10User-Ryasmeen: Upgrade VisualEditor to QUnit 2 - https://phabricator.wikimedia.org/T170585#3445697 (10Jdforrester-WMF) 05Open>03Resolved a:03Krinkle [19:28:40] 10VisualEditor, 10Flow, 10TemplateStyles, 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017): Add class mw-parser-output to Flow comment- or content- containing elements - https://phabricator.wikimedia.org/T164791#3445718 (10Jdforrester-WMF) a:03Esanders [19:29:43] 10VisualEditor, 10TemplateStyles, 10Patch-For-Review: Add class mw-parser-output to VE's editing area - https://phabricator.wikimedia.org/T164790#3445725 (10Jdforrester-WMF) a:03Esanders [19:43:23] (03PS2) 10Esanders: build: Upgrade grunt-eslint from 19.0.0 to 20.0.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/362378 (owner: 10Jforrester) [19:52:36] 10VisualEditor, 10Flow, 10TemplateStyles, 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017): Add class mw-parser-output to Flow comment- or content- containing elements - https://phabricator.wikimedia.org/T164791#3445809 (10Anomie) I note https://gerrit.wikimedia.org/r/365656 seems to have missed t... [20:06:26] (03CR) 10Esanders: [C: 032] tests: Simplify Platform test beforeEach/afterEach logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/365681 (owner: 10Krinkle) [20:09:34] (03Merged) 10jenkins-bot: tests: Simplify Platform test beforeEach/afterEach logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/365681 (owner: 10Krinkle) [20:14:10] (03CR) 10jenkins-bot: tests: Simplify Platform test beforeEach/afterEach logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/365681 (owner: 10Krinkle) [20:23:56] (03CR) 10Esanders: "See Ic4abaae6e9c74509f7a114a697cdbb78dd1b89b6" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/363098 (https://phabricator.wikimedia.org/T169574) (owner: 10Bartosz Dziewoński) [20:27:40] (03PS2) 10Esanders: Visual diffs: Use new wgDiff[Old/New]Id [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/363098 (https://phabricator.wikimedia.org/T169574) (owner: 10Bartosz Dziewoński) [20:50:22] 10VisualEditor, 10TemplateStyles, 10Patch-For-Review: Add class mw-parser-output to VE's editing area - https://phabricator.wikimedia.org/T164790#3445989 (10Tgr) User CSS affecting VE structures is already the status quo; currently such CSS is unprefixed and affects everything on the page, with TemplateStyle... [20:50:34] (03CR) 10Catrope: [C: 032] Add mw-parser-output class to CE document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365651 (https://phabricator.wikimedia.org/T164790) (owner: 10Esanders) [20:54:13] 10VisualEditor, 10TemplateStyles, 10Patch-For-Review: Add class mw-parser-output to VE's editing area - https://phabricator.wikimedia.org/T164790#3446020 (10Jdforrester-WMF) >>! In T164790#3445989, @Tgr wrote: > As for using the class on each separate transclusion, how would that work after we switch to Pars... [20:56:33] (03CR) 10Jforrester: [C: 031] "Changes LGTM (though tsk at the combined rebase and change)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/362378 (owner: 10Jforrester) [20:56:50] (03PS1) 10Jforrester: Update VE core submodule to master (354a4738a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365791 (https://phabricator.wikimedia.org/T170585) [21:02:00] Krinkle: I made https://gerrit.wikimedia.org/r/#/c/365791/ as a pull-through of the QUnit fixes in VE which might make things fail less? [21:03:14] (03Merged) 10jenkins-bot: Add mw-parser-output class to CE document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365651 (https://phabricator.wikimedia.org/T164790) (owner: 10Esanders) [21:10:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/365823 (owner: 10L10n-bot) [21:13:53] 10VisualEditor, 10TemplateStyles, 10Patch-For-Review: Add class mw-parser-output to VE's editing area - https://phabricator.wikimedia.org/T164790#3446137 (10Tgr) > Any template styles code that tries to affect content outside of the template will indeed not work. I'd consider that a feature, not a bug. FWIW... [21:13:55] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (354a4738a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365791 (https://phabricator.wikimedia.org/T170585) (owner: 10Jforrester) [21:16:08] (03CR) 10jenkins-bot: Add mw-parser-output class to CE document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365651 (https://phabricator.wikimedia.org/T164790) (owner: 10Esanders) [21:20:16] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365846 (owner: 10L10n-bot) [21:20:35] (03CR) 10Krinkle: "Yeah, and setup/teardown is only deprecated, not removed. So these will work fine. They don't need to happen before, nor at the same time." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365682 (https://phabricator.wikimedia.org/T170872) (owner: 10Jforrester) [21:21:29] 10VisualEditor, 10SyntaxHighlight, 10User-Ryasmeen: Code block disappears in VE edit mode when specified language is unknown (mismatch read mode) - https://phabricator.wikimedia.org/T164120#3446231 (10Jdforrester-WMF) 05Open>03Resolved a:03DLynch [21:22:53] (03CR) 10Krinkle: "Switch to beforeEach/afterEach won't work right now, but can safely land before mw-core upgrades, as long as https://gerrit.wikimedia.org/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365791 (https://phabricator.wikimedia.org/T170585) (owner: 10Jforrester) [21:26:14] (03CR) 10Jforrester: "> Yeah, and setup/teardown is only deprecated, not removed. So these will work fine. They don't need to happen before, nor at the same tim" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365682 (https://phabricator.wikimedia.org/T170872) (owner: 10Jforrester) [21:31:53] 10VisualEditor, 10TemplateStyles, 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), 10User-Ryasmeen: Add class mw-parser-output to VE's editing area - https://phabricator.wikimedia.org/T164790#3446321 (10Jdforrester-WMF) 05Open>03Resolved [21:38:51] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), 10User-Ryasmeen, 10User-Urbanecm: Welcome to Wikipedia message is shown even if page is protected - https://phabricator.wikimedia.org/T138715#3446376 (10Ryasmeen) 05Resolved>03Open [21:40:31] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), 10User-Ryasmeen, 10User-Urbanecm: Welcome to Wikipedia message is shown even if page is protected - https://phabricator.wikimedia.org/T138715#2407965 (10Ryasmeen) I can still reproduce it on Beta cl... [21:45:51] (03PS2) 10Krinkle: Update VE core submodule to master (354a4738a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365791 (https://phabricator.wikimedia.org/T170585) (owner: 10Jforrester) [21:46:09] (03CR) 10Krinkle: "Let's see if it passes with that core commit, which in turn depends on a Wikibase fix." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365791 (https://phabricator.wikimedia.org/T170585) (owner: 10Jforrester) [21:50:16] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), 10User-Ryasmeen, 10User-Urbanecm: Welcome to Wikipedia message is shown even if page is protected - https://phabricator.wikimedia.org/T138715#3446469 (10DLynch) @Ryasmeen: I can't reproduce that. Do... [22:02:43] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), 10User-Ryasmeen, 10User-Urbanecm: Welcome to Wikipedia message is shown even if page is protected - https://phabricator.wikimedia.org/T138715#3446525 (10Ryasmeen) No, I created a new user account an... [22:13:48] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (354a4738a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365791 (https://phabricator.wikimedia.org/T170585) (owner: 10Jforrester) [22:16:34] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), 10User-Ryasmeen, 10User-Urbanecm: Welcome to Wikipedia message is shown even if page is protected - https://phabricator.wikimedia.org/T138715#3446578 (10DLynch) Aha, I see what's different. One second. [22:17:36] (03PS1) 10DLynch: DesktopArticleTarget.init: more explicit no-welcome-on-protected-pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365867 (https://phabricator.wikimedia.org/T138715) [22:37:02] (03CR) 10Jforrester: [C: 032] DesktopArticleTarget.init: more explicit no-welcome-on-protected-pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365867 (https://phabricator.wikimedia.org/T138715) (owner: 10DLynch) [22:43:41] 10VisualEditor, 10Flow, 10TemplateStyles, 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)): Add class mw-parser-output to Flow comment- or content- containing elements - https://phabricator.wikimedia.org/T164791#3245507 (10Etonkovid... [22:48:22] (03Merged) 10jenkins-bot: DesktopArticleTarget.init: more explicit no-welcome-on-protected-pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365867 (https://phabricator.wikimedia.org/T138715) (owner: 10DLynch) [22:55:56] (03CR) 10jenkins-bot: DesktopArticleTarget.init: more explicit no-welcome-on-protected-pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365867 (https://phabricator.wikimedia.org/T138715) (owner: 10DLynch) [23:03:33] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10Tracking, 10User-Ryasmeen: [DO NOT USE] Support non-image media (tracking) [superseded by #VisualEditor-MediaWiki-Media] - https://phabricator.wikimedia.org/T69690#3446701 (10Liuxinyu970226) [23:07:29] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Microsoft-Edge, 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), and 2 others: Show preview stopped working in Microsoft Edge - https://phabricator.wikimedia.org/T170466#3446728 (10Ryasmeen) [23:17:36] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Can't move images to a different location - https://phabricator.wikimedia.org/T170693#3446741 (10Whatamidoing-WMF) I filed the bug after https://ru.wikipedia.org/w/index.php?title=%D0%A1%D0%B8%D1%84%D0%BE%D0%BD_(%D1%81%D0%BE%D1%81%D1%83%D0%B4)&diff=86526135&oldid... [23:53:34] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), 10User-Ryasmeen, and 2 others: Welcome to Wikipedia message is shown even if page is protected - https://phabricator.wikimedia.org/T138715#3446825 (10Ryasmeen) 05Open>03Resolved