[00:16:26] (03PS1) 10Jforrester: Update VE core submodule to master (94532edbf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373166 (https://phabricator.wikimedia.org/T171377) [07:33:53] 10VisualEditor, 10Community-Liaisons: Finalize centralisation of VE user feedback - https://phabricator.wikimedia.org/T162664#3543785 (10Elitre) FWIW at Wikimania I have finalised an agreement with @Cirdan (after his talk https://wikimania2017.wikimedia.org/wiki/Submissions/From_open_hostility_to_collaboration... [07:39:43] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/373231 (owner: 10L10n-bot) [07:46:08] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373239 (owner: 10L10n-bot) [08:55:41] 10VisualEditor, 10MediaWiki-extensions-Translate: Major loss of data when clicking outside of the "translate" editor box - https://phabricator.wikimedia.org/T173239#3543944 (10Nikerabbit) Not actionable for me. [09:07:04] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs: Editing a page with unflagged changes should edit latest version in VE, even if you view the stable version - https://phabricator.wikimedia.org/T165283#3543955 (10clel) @Tkarcher Thanks. Also I think that one has a chance to see th... [09:53:03] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Design: Be able to generate citation list using citoid - https://phabricator.wikimedia.org/T173624#3544014 (10Trizek-WMF) I was suggesting this, because I've explored the Wikidata option with some friends (on my volunteer capacity). Every un... [09:53:23] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Design: Be able to generate citation list using citoid - https://phabricator.wikimedia.org/T173624#3544015 (10Trizek-WMF) I was suggesting this, because I've explored the Wikidata option with some friends (on my volunteer capacity). Every un... [10:13:30] 10Cite, 10VisualEditor, 10VisualEditor-VisualDiffs, 10Patch-For-Review: Changing a reference shows useless and confusing details in visual diff - https://phabricator.wikimedia.org/T171377#3462804 (10Deskana) Not quite done yet: still waiting for https://gerrit.wikimedia.org/r/371588 to get merged. [10:13:48] 10Cite, 10VisualEditor, 10VisualEditor-VisualDiffs, 10Patch-For-Review: Changing a reference shows useless and confusing details in visual diff - https://phabricator.wikimedia.org/T171377#3544033 (10Deskana) [10:14:22] 10VisualEditor, 10Community-Liaisons: Finalize centralisation of VE user feedback - https://phabricator.wikimedia.org/T162664#3170590 (10Deskana) Thank you @Cirdan! [11:46:17] 10VisualEditor, 10VisualEditor-EditingTools: Clicking hyperlink and cite buttons twice breaks the editor - https://phabricator.wikimedia.org/T173077#3544246 (10The_RedBurn) I can confirm that it works on https://simple.wikipedia.beta.wmflabs.org Should this be marked as invalid or resolved? [13:24:02] 10VisualEditor, 10VisualEditor-VisualDiffs, 10User-Ryasmeen: Errors when attempting to view some history diffs - https://phabricator.wikimedia.org/T171863#3544454 (10matmarex) 05Open>03Resolved [14:01:30] 10VisualEditor, 10MediaWiki-Page-editing: 'Edit help' shows when you edit CSS and JS pages only - https://phabricator.wikimedia.org/T173715#3544618 (10Jdlrobson) > Something seems to be wrong. 'Edit help' link ([[MediaWiki:Edithelp]]) shows when you edit CSS and JS pages only, and has problems with padding. Th... [14:03:41] 10VisualEditor, 10MediaWiki-Page-editing: 'Edit help' shows when you edit CSS and JS pages only - https://phabricator.wikimedia.org/T173715#3544636 (10Urbanecm) Have a look at https://cs.wikipedia.org/w/index.php?title=Salamis&action=edit for example. There is no help text. You're looking into JS page where it... [14:06:14] (03PS1) 10Esanders: Allow for mw.body being null in extensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373293 (https://phabricator.wikimedia.org/T173016) [14:22:04] 10VisualEditor, 10MediaWiki-Page-editing: 'Edit help' shows when you edit CSS and JS pages only - https://phabricator.wikimedia.org/T173715#3544813 (10Iniquity) [14:22:46] 10VisualEditor, 10MediaWiki-Page-editing: 'Edit help' shows when you edit CSS and JS pages only - https://phabricator.wikimedia.org/T173715#3537643 (10Iniquity) [14:23:50] 10VisualEditor, 10MediaWiki-Page-editing: 'Edit help' shows when you edit CSS and JS pages only - https://phabricator.wikimedia.org/T173715#3537643 (10Iniquity) [14:33:34] 10VisualEditor, 10VisualEditor-EditingTools: Clicking hyperlink and cite buttons twice breaks the editor - https://phabricator.wikimedia.org/T173077#3544884 (10Esanders) 05stalled>03Open I can reproduce locally and on various live wikis [14:35:49] 10VisualEditor, 10VisualEditor-EditingTools: Clicking hyperlink and cite buttons twice breaks the editor - https://phabricator.wikimedia.org/T173077#3544907 (10Deskana) >>! In T173077#3544246, @The_RedBurn wrote: > I can confirm that it works on https://simple.wikipedia.beta.wmflabs.org > Should this be marked... [14:49:23] 10TemplateData, 10VisualEditor, 10ContentTranslation, 10Wikidata, and 2 others: CX and VisualEditor template editors are not aware of parameters that can be auto-filled from Wikidata - https://phabricator.wikimedia.org/T152082#3544993 (10Deskana) p:05Triage>03Low [14:52:12] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Design: Be able to generate citation list using citoid - https://phabricator.wikimedia.org/T173624#3544996 (10Jdforrester-WMF) See #WikiCite for a huge amount of thinking done on this already. It would be a shame to duplicate that work. [14:55:24] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-CodeMirror, 10Beta-Cluster-reproducible: CodeMirror breaks NWE on labs: "TypeError: mwConfig is null" - https://phabricator.wikimedia.org/T172632#3545002 (10Deskana) 05Open>03Invalid I enabled both the "New wikitext mod... [15:02:05] (03PS1) 10Esanders: Don't try to close context while opening [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/373304 (https://phabricator.wikimedia.org/T173077) [15:02:50] 10VisualEditor: The preview link for user page in the link dialog doesn't add local wiki domain prefix - https://phabricator.wikimedia.org/T165980#3282025 (10Pols12) Same problem with Flow. I have not achieved to reproduce with `user:` prefix, however it happens with `help:`, `meta:` and `template:` prefixes, s... [15:03:15] (03CR) 10Jforrester: [C: 032] "Did we lose this feature when the jQuery 3 compatibility changes to OOjs UI's windows were made?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/373304 (https://phabricator.wikimedia.org/T173077) (owner: 10Esanders) [15:03:42] 10VisualEditor, 10Collaboration-Team-Triage, 10Flow: The preview link for user page in the link dialog doesn't add local wiki domain prefix - https://phabricator.wikimedia.org/T165980#3545040 (10Pols12) [15:08:02] (03Merged) 10jenkins-bot: Don't try to close context while opening [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/373304 (https://phabricator.wikimedia.org/T173077) (owner: 10Esanders) [15:11:23] 10VisualEditor, 10VisualEditor-EditingTools, 10Patch-For-Review: Clicking hyperlink and cite buttons twice breaks the editor - https://phabricator.wikimedia.org/T173077#3545084 (10Esanders) Looks like this is only broken when using jQuery 2 [15:12:04] (03CR) 10Esanders: "Looks like a jq2-only issue. Checked this still works in jq3." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/373304 (https://phabricator.wikimedia.org/T173077) (owner: 10Esanders) [15:13:29] (03CR) 10jenkins-bot: Don't try to close context while opening [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/373304 (https://phabricator.wikimedia.org/T173077) (owner: 10Esanders) [15:22:38] (03PS2) 10Jforrester: Update VE core submodule to master (d7bb71b95) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373166 (https://phabricator.wikimedia.org/T171377) [15:24:48] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-VisualDiffs, 10Community-Liaisons, 10User-Ryasmeen: "Tech Talk" about visual diffs - https://phabricator.wikimedia.org/T152948#3545165 (10Elitre) Fair point: recording + slides should be added to any relevant pages on mw.org, though. [15:27:48] hmm. [15:27:51] TypeError: undefined is not an object (evaluating '$('#wpTextbox1').data('wikiEditor-context').modules') [15:28:43] when trying to open NWE on en.wp.. Did anyone see that before ? [15:28:55] $codeMirrorButton = $('#wpTextbox1').data('wikiEditor-context').modules.toolbar.$toolbar.find('a.tool[rel=CodeMirror]') [15:30:43] thedj: We tested it yesterday and it worked fine.... [15:30:54] Try reloading the page? [15:30:58] thedj: hmm, presumably wpTextbox1 is missing, as it can be with NWE enabled [15:31:40] it's definetly not all the time. [15:32:29] i have it here: https://en.wikipedia.org/wiki/Template:Historical_populations?action=edit [15:35:28] wikiEditorToolbarEnabled = !!mw.loader.getState('ext.wikiEditor') && mw.user.options.get('usebetatoolbar') > 0; [15:35:51] mw.loader.getState('ext.wikiEditor') == registered [15:44:33] thedj: Instead I get "TypeError: Cannot read property 'modules' of undefined TypeError: Cannot read property 'modules' of undefined at HTMLDocument.addCodeMirrorToWikiEditor (…)" on that page (but both NWE and CodeMirror seem to load and execute fine). [15:45:31] James_F: Editing works as expected? [15:45:42] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Patch-For-Review: Visual diff (on history page) shows changes to reference numbers caused by inserting more references - https://phabricator.wikimedia.org/T170235#3545270 (10Deskana) p:05Triage>03Normal [15:45:52] "!!mw.loader.getState('ext.wikiEditor')" <-- that's suspect [15:45:55] 10VisualEditor, 10VisualEditor-VisualDiffs: Stop showing excessive moves when moving a paragraph across the page - https://phabricator.wikimedia.org/T171451#3545272 (10Deskana) p:05Triage>03Normal [15:46:06] it makes assumptions about the loader that you cannot rely on. [15:46:12] 10VisualEditor, 10VisualEditor-VisualDiffs: When moving and reordering references the "References" list isn't being updated - https://phabricator.wikimedia.org/T171587#3545275 (10Deskana) p:05Triage>03Normal [15:46:30] 10VisualEditor, 10VisualEditor-VisualDiffs: Nothing shown in visual diff when editing invisible templates - https://phabricator.wikimedia.org/T170107#3545278 (10Deskana) [15:46:41] Niharika: Yes. [15:47:01] You want `mw.loader.getState('ext.wikiEditor') === 'ready'` or whatever. [15:47:11] but than you are in a race [15:47:24] 'ready' || 'loaded'. [15:47:34] still [15:47:42] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: When deleting revisions, 2017 wikitext editor loads when it shouldn't and blocks you from proceeding - https://phabricator.wikimedia.org/T173090#3545280 (10Deskana) [15:47:50] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: When deleting revisions, 2017 wikitext editor loads when it shouldn't and blocks you from proceeding - https://phabricator.wikimedia.org/T173090#3518312 (10Deskana) [15:47:50] Doesn't it declare WikiEditor as an RL dependency? [15:48:27] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE shouldn't intercept when viewing deleted revisions - https://phabricator.wikimedia.org/T173154#3545283 (10Deskana) Related: {T173090} [15:48:37] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: HTML tags are incorrectly included in edit summaries when editing sections in 2017 editor - https://phabricator.wikimedia.org/T173711#3545299 (10Deskana) [15:49:01] it assumes that when a dependency is declared on wikieditor, that it is actually a page with wikieditor [15:49:36] I'm in solid meetings for the rest of the day, but I could look at it this evening. [15:49:41] 10VisualEditor: "Often used" not shown in VisualEditor (kowiki) - https://phabricator.wikimedia.org/T159529#3545306 (10Deskana) p:05Normal>03High @Esanders @DLynch @dchan Can one of you do some investigation here? It'd be good to find out what the problem is. [15:50:19] i'm not sure how NWE takes over edit pages, but you need to use those same conditionals on the client side. [15:51:09] so likely if (!NWE && usebetatoolbar ), then { when wikieditor has loaded, add button } [15:52:06] But isn't the problem with NWE and not with classic/advanced editors? [15:52:24] I'm not at my desk yet so can't test. [15:52:52] yes, the NWE page, executes the addition of the wikiEditor toolbar, but the toolbar is not there. [15:53:10] 10VisualEditor, 10VisualEditor-EditingTools, 10Patch-For-Review: Clicking hyperlink and cite buttons twice breaks the editor - https://phabricator.wikimedia.org/T173077#3545317 (10Deskana) If https://gerrit.wikimedia.org/r/373304 fixes the issue, then please schedule it for SWAT deployment. We shouldn't wait... [15:53:50] because the logic determening when to add to assume that there is a wikieditor is making incorrect assumptions about toolbar modules. [15:55:13] possibly this is more visible on en.wp due to the reftoolbar extension.... [15:55:18] which has [15:55:19] if (mw.user.options.get('usebetatoolbar') == true) { [15:55:19] mw.loader.using(['ext.gadget.refToolbarBase', 'ext.wikiEditor.toolbar'], function() { [15:55:22] importScript('MediaWiki:RefToolbar.js'); [15:55:25] }); [15:55:27] } [15:56:46] so basically, whenever reftoolbar is enabled, it will always assume that the WikitextEditor is being used..... and then depends on the toolbar module, to ensure loading at the same time, which in turn will enforce that the wikitextEditor modules are always loaded.... [15:57:57] making it a self fulfilling profecy :) [16:04:11] maybe we should just mw.hook'ify the wikieditor ? that would make everything so much easier... [16:04:29] actually... maybe we already did that ? [16:14:45] (03PS2) 10DLynch: Allow for mw.body being null in extensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373293 (https://phabricator.wikimedia.org/T173016) (owner: 10Esanders) [16:24:27] thedj: Ah, yes, if you're loading the reftoolbar gadget all bets are off. :-( [16:31:39] (03CR) 10DLynch: [C: 032] "I just added a quick explanatory comment." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373293 (https://phabricator.wikimedia.org/T173016) (owner: 10Esanders) [16:39:41] 10VisualEditor: "Often used" not shown in VisualEditor (kowiki) - https://phabricator.wikimedia.org/T159529#3545556 (10DLynch) I'm taking a look. It seems to be having a parse error on the JSON, though directly copying it locally causes nothing. [16:40:47] (03Merged) 10jenkins-bot: Allow for mw.body being null in extensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373293 (https://phabricator.wikimedia.org/T173016) (owner: 10Esanders) [16:41:10] 10VisualEditor: "Often used" not shown in VisualEditor (kowiki) - https://phabricator.wikimedia.org/T159529#3545563 (10DLynch) I'm calling this //suspicious//: {F9159366} [16:42:50] (03CR) 10jenkins-bot: Allow for mw.body being null in extensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373293 (https://phabricator.wikimedia.org/T173016) (owner: 10Esanders) [16:44:02] 10VisualEditor: "Often used" not shown in VisualEditor (kowiki) - https://phabricator.wikimedia.org/T159529#3545574 (10DLynch) So, it seems that in `미디어위키:Visualeditor-quick-access-characters.json` it's seeing `"{{llang||}}"` as a key... and expanding the template. [16:47:34] Anyone know offhand what the normal trigger for MW not-expanding templates in JSON is? T159529 turns out to be that behavior not triggering. [16:47:35] T159529: "Often used" not shown in VisualEditor (kowiki) - https://phabricator.wikimedia.org/T159529 [16:47:37] thedj: I've so far been unable to reproduce that error. Even on that page. [16:54:46] Kemayo: hmm, i would say that could be caused by the page having the wrong content model set (wikitext instead of JSON), but this page seems to have it correct. https://ko.wikipedia.org/w/index.php?title=%EB%AF%B8%EB%94%94%EC%96%B4%EC%9C%84%ED%82%A4:Visualeditor-quick-access-characters.json&action=info&uselang=en [16:55:18] Kemayo: i'd look into how exactly we're loading the contents of that message, perhaps we're accidentally intentionally parsing it [16:55:31] 10VisualEditor: "Often used" not shown in VisualEditor (kowiki) - https://phabricator.wikimedia.org/T159529#3545639 (10DLynch) Also, this is exactly the same error as T167051. @Esanders? [17:38:58] 10VisualEditor: "Often used" not shown in VisualEditor (kowiki) - https://phabricator.wikimedia.org/T159529#3070603 (10matmarex) This was probably introduced in 786c576893748cdebfce5a847a5298bf6202fe08. Following that code, the message is used with `->text()`, which expands templates and parser functions (but do... [17:39:04] Kemayo: ^ [17:49:06] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Design: Be able to generate citation list using citoid - https://phabricator.wikimedia.org/T173624#3546287 (10Mvolz) Before we get ahead of ourselves with wikidata and what not, there are some slight complications: We currently have a fuzzy... [17:58:17] Kemayo: So we can just fix it for them by getting rid of the "{{"s? [18:01:18] James_F: Short-term, yeah, I think so. We should probably also adjust the bit Bartosz pointed out, so this won't happen at all. [18:01:48] I'm not sure it's easy to do so? [18:01:51] it's a simple change actually [18:02:03] Plus, this is definitely a case of the special characters tool being used in a weird way, as a generic wikitext snippet library. :P [18:02:04] it wasn't trivial to find out why this happens, but it's simple to fix [18:02:10] i might as well write a patch [18:02:28] MatmaRex: Yeah, if you're already right at the place it's happening, makes sense. I can review it. [18:03:49] There's also the new source-mode-only flag Ed added, which probably belongs on all those wikitext snippets. [18:04:18] Yeah, well. [18:04:55] Which doesn't do anything to fix this particular issue, of course, but if we're tweaking their JSON anyway... [18:08:02] 10VisualEditor, 10VisualEditor-VisualDiffs: Getting error "Cannot read property 'getBoundingClientRect' of undefined" while switching to Visual diff after adding image right above a gallery - https://phabricator.wikimedia.org/T161077#3546493 (10Ryasmeen) Yup, the original behavior has been significantly change... [18:08:51] (03PS1) 10Bartosz Dziewoński: VisualEditorDataModule: Do not expand templates in plain text messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373331 (https://phabricator.wikimedia.org/T159529) [18:08:54] James_F: Kemayo: ^ (untested) [19:14:43] 10VisualEditor, 10VisualEditor-Performance, 10Performance-Team: Performance review of VisualEditor - https://phabricator.wikimedia.org/T171093#3546751 (10Krinkle) p:05Triage>03Normal [20:42:57] 10VisualEditor: VisualEditor: Provide an indication that a link is piped without requiring mouseover - https://phabricator.wikimedia.org/T172861#3547028 (10Thryduulf) The goal of this is to see which links are piped without needing to interact with them. It's partly about checking errors in prior revisions, an... [22:57:59] 10WikiEditor, 10CodeEditor, 10MediaWiki-Page-editing: WikiEditor hides the "'Edit help'" links (because it supplies its own in the toolbar), but CodeEditor doesn't - https://phabricator.wikimedia.org/T173715#3547401 (10Jdforrester-WMF) [23:03:55] 10WikiEditor, 10CodeEditor, 10MediaWiki-Page-editing: WikiEditor hides the "'Edit help'" links (because it supplies its own in the toolbar), but CodeEditor doesn't - https://phabricator.wikimedia.org/T173715#3537643 (10Jdforrester-WMF) This has been the case in WikiEditor (aka "the 2010 wikitext editor") as... [23:35:32] 10WikiEditor, 10CodeEditor, 10MediaWiki-Page-editing: WikiEditor hides the "'Edit help'" links (because it supplies its own in the toolbar), but CodeEditor doesn't - https://phabricator.wikimedia.org/T173715#3547459 (10Iniquity) @Jdforrester-WMF Can it be easier to remove this part of code? [23:41:47] 10WikiEditor, 10CodeEditor, 10MediaWiki-Page-editing: WikiEditor hides the "'Edit help'" links (because it supplies its own in the toolbar), but CodeEditor doesn't - https://phabricator.wikimedia.org/T173715#3547480 (10Jdforrester-WMF) >>! In T173715#3547459, @Iniquity wrote: > @Jdforrester-WMF Can it be eas...