[00:17:14] 10WikiEditor, 10CodeEditor, 10MediaWiki-Page-editing, 10Patch-For-Review: WikiEditor hides the "'Edit help'" links (because it supplies its own in the toolbar), but CodeEditor doesn't - https://phabricator.wikimedia.org/T173715#3551548 (10Iniquity) @Jdforrester-WMF thanks! [01:07:47] 10Cite, 10VisualEditor, 10Wikimedia-Site-requests, 10Patch-For-Review: Convert reference lists over to `responsive` on enwiki - https://phabricator.wikimedia.org/T173176#3551606 (10Whatamidoing-WMF) The discussion was officially re-opened, and a few more support votes have been added, in addition to some l... [08:01:37] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/373821 (owner: 10L10n-bot) [08:09:12] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373835 (owner: 10L10n-bot) [10:31:42] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Styles for babel box aren't loaded in preview of visual wikitext editor - https://phabricator.wikimedia.org/T169331#3552306 (10Deskana) [10:32:02] 10VisualEditor: [Regression pre-wmf.8] "Uncaught TypeError: Cannot read property 'getTokens' of null" appears after adding a Code block - https://phabricator.wikimedia.org/T169925#3552308 (10Deskana) [10:32:11] 10VisualEditor, 10VisualEditor-Tables: Deleting column with sparse cells leaves behind CE cells that don't exist in model - https://phabricator.wikimedia.org/T170074#3552310 (10Deskana) [10:34:58] 10VisualEditor, 10VisualEditor-MediaWiki: Unexpected loading of VisualEditor after Special:RevisionDelete submission - https://phabricator.wikimedia.org/T168533#3552314 (10Deskana) [10:35:00] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: When deleting revisions, 2017 wikitext editor loads when it shouldn't and blocks you from proceeding - https://phabricator.wikimedia.org/T173090#3552317 (10Deskana) [10:35:24] 10VisualEditor, 10VisualEditor-MediaWiki: When deleting revisions, 2017 wikitext editor and VisualEditor load when they shouldn't and block you from proceeding. - https://phabricator.wikimedia.org/T168533#3552319 (10Deskana) [13:13:31] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: One editor can't paste anything - https://phabricator.wikimedia.org/T172420#3552887 (10Deskana) 05Open>03stalled There is nothing we can do about this without significantly more information. [13:16:07] 10VisualEditor, 10Africa-Wikimedia-Developers, 10Easy, 10I18n: Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label - https://phabricator.wikimedia.org/T173181#3552894 (10Eugene233) a:03Eugene233 [13:30:37] 10VisualEditor, 10VisualEditor-MediaWiki: Provide visible tool for aborting edit in VE - https://phabricator.wikimedia.org/T164705#3552945 (10Deskana) p:05Triage>03Low [13:32:00] 10VisualEditor: Saving in VE shows error, but succeeds - https://phabricator.wikimedia.org/T161085#3552950 (10Deskana) 05Open>03Invalid Intermittent issues like this happen from time to time, and they normally resolve themselves, so there's probably no point chasing down a months old report. If the problem i... [13:36:25] (03PS1) 10Eugene233: Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373890 (https://phabricator.wikimedia.org/T173181) [13:51:31] (03CR) 10D3r1ck01: [C: 04-1] "@Eugene233, thanks for the PS, but check what @Amire80 said; "It would be much better to define it as non-breaking in CSS", this is so bec" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373890 (https://phabricator.wikimedia.org/T173181) (owner: 10Eugene233) [14:02:11] 10Citoid, 10VisualEditor: In Visual Editor 'Add a citation tool' if the title of the URL has a | in it is causes an error message to show up - https://phabricator.wikimedia.org/T156366#3553036 (10Deskana) The problem here is the site in question, not Citoid or VisualEditor. The page's title really does have a... [14:09:27] 10Citoid, 10VisualEditor: Consider stripping characters like line feeds from page titles when importing citation using Citoid - https://phabricator.wikimedia.org/T156366#3553054 (10Deskana) [14:09:40] 10Citoid, 10VisualEditor: Consider stripping characters like line feeds from page titles when importing citation using Citoid - https://phabricator.wikimedia.org/T156366#2972506 (10Deskana) p:05Triage>03Low [14:26:55] (03PS1) 10Esanders: Set wgRevisionId on overridden edit page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373897 (https://phabricator.wikimedia.org/T166131) [14:28:18] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review: "Error loading data from server: oldidnotfound: There is no revision with ID 0.. " appears while trying to switch from NWE to VE - https://phabricator.wikimedia.org/T166131#3553106 (10Esanders) [14:35:03] 10VisualEditor, 10VisualEditor-ContentEditable, 10Regression: [Regression pre-wmf.17] The highlight and the context menu for a node stays at the previous position after repositioning it - https://phabricator.wikimedia.org/T129541#3553120 (10Esanders) Looks like a regression from https://gerrit.wikimedia.org/... [14:44:04] (03PS1) 10Esanders: FocusableNode: Redraw highlights using focus toggle [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/373900 (https://phabricator.wikimedia.org/T129541) [14:44:07] (03PS1) 10Esanders: Debounce FocusableNode#redrawHighlights [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/373901 [15:00:24] (03CR) 10Divec: "This seems to be because ve.dm.MWReferenceNode.static.cloneElement deletes certain attributes, making the comparison fail. I'll fix it by " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/357171 (https://phabricator.wikimedia.org/T162762) (owner: 10Divec) [15:00:41] 10VisualEditor, 10Africa-Wikimedia-Developers, 10MinervaNeue: Text area not obvious when creating New talk page on a fresh MW install - https://phabricator.wikimedia.org/T174158#3553181 (10Jdlrobson) [15:01:20] (03PS13) 10Divec: TransactionProcessor: modify DM tree branches instead of rebuilding them [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/357171 (https://phabricator.wikimedia.org/T162762) [15:01:27] (03CR) 10jerkins-bot: [V: 04-1] TransactionProcessor: modify DM tree branches instead of rebuilding them [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/357171 (https://phabricator.wikimedia.org/T162762) (owner: 10Divec) [15:05:14] (03PS14) 10Divec: TransactionProcessor: modify DM tree branches instead of rebuilding them [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/357171 (https://phabricator.wikimedia.org/T162762) [15:05:57] (03CR) 10Divec: "Patch Set 13 was rebased" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/357171 (https://phabricator.wikimedia.org/T162762) (owner: 10Divec) [15:08:33] (03PS1) 10Esanders: build: Update eslint-config-wikimedia 0.4->0.5 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373906 [15:09:38] (03CR) 10Divec: Make RebaseServer asynchronous (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/331423 (owner: 10Divec) [15:26:23] (03CR) 10Jforrester: [C: 032] build: Update eslint-config-wikimedia 0.4->0.5 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373906 (owner: 10Esanders) [15:35:24] 10Citoid, 10VisualEditor: Consider stripping characters like line feeds from page titles when importing citation using Citoid - https://phabricator.wikimedia.org/T156366#3553279 (10Mrjohncummings) Thanks for the explanation @Deskana, it would be interesting to know how widely this is done by websites or if thi... [15:35:51] (03Merged) 10jenkins-bot: build: Update eslint-config-wikimedia 0.4->0.5 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373906 (owner: 10Esanders) [15:42:21] (03CR) 10jenkins-bot: build: Update eslint-config-wikimedia 0.4->0.5 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373906 (owner: 10Esanders) [15:43:22] 10Citoid, 10VisualEditor: Consider stripping characters like line feeds from page titles when importing citation using Citoid - https://phabricator.wikimedia.org/T156366#3553299 (10Deskana) It's very rare. This is the first time I've ever seen a web page that has a line feed in its title. Generating hard stati... [15:46:17] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror: CodeMirror shouldn't register its enable/disable tools with the New Wikitext Editor unless the beta feature is enabled - https://phabricator.wikimedia.org/T173480#3553305 (10Jdforrester-WMF) [15:49:28] (03CR) 10Jforrester: [C: 031] "WFM." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/331423 (owner: 10Divec) [15:57:15] (03CR) 10Jforrester: [C: 031] "Tested this with a bunch of edits (moves/typing/pasting; reference, templates, headings, tables). Seemed to work well." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/357171 (https://phabricator.wikimedia.org/T162762) (owner: 10Divec) [16:24:04] 10VisualEditor, 10Browser-Tests-Infrastructure, 10MediaWiki-extensions-CentralAuth, 10Browser-Tests, and 2 others: Edits sometimes fail for new users erroneously reporting them as anon - https://phabricator.wikimedia.org/T172835#3553437 (10zeljkofilipin) [16:26:34] 10Citoid, 10VisualEditor: Consider stripping characters like line feeds from page titles when importing citation using Citoid - https://phabricator.wikimedia.org/T156366#3553445 (10Mrjohncummings) Thanks, well I think if its the first time you've seen it it must be pretty rare. [17:08:35] 10VisualEditor, 10VisualEditor-MediaWiki, 10Technical-Debt: Allow extensions to disable VE - https://phabricator.wikimedia.org/T174180#3553546 (10Esanders) [17:11:12] (03PS1) 10Esanders: Disable VE on Special:Undelete [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373927 (https://phabricator.wikimedia.org/T173154) [17:12:10] (03CR) 10Jforrester: "Hmm. This means that you don't get the "right" edit tabs on Special:Undelete now, though…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373927 (https://phabricator.wikimedia.org/T173154) (owner: 10Esanders) [17:46:14] (03PS1) 10Esanders: Remove reference to editfont-default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373935 (https://phabricator.wikimedia.org/T170223) [20:25:20] (03CR) 10Amire80: "> @Eugene233, thanks for the PS, but check what @Amire80 said; "It" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373890 (https://phabricator.wikimedia.org/T173181) (owner: 10Eugene233) [20:31:04] 10VisualEditor: [Regression wmf.15?] The "Remove field" icon is appearing inside the field for Cite journal template - https://phabricator.wikimedia.org/T174202#3554243 (10Ryasmeen) [20:31:40] 10VisualEditor: [Regression wmf.15?] The "Remove field" icon is appearing inside the field for Cite journal template - https://phabricator.wikimedia.org/T174202#3554255 (10Ryasmeen) [20:31:57] 10VisualEditor: [Regression wmf.15?] The "Remove field" icon is appearing inside the field for Cite journal template - https://phabricator.wikimedia.org/T174202#3554243 (10Ryasmeen) [20:32:51] (03CR) 10D3r1ck01: [C: 04-1] "You just made a very good point @Amire80. The SO link was just to show the different kind of spaces though :). And yeah asking the person " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373890 (https://phabricator.wikimedia.org/T173181) (owner: 10Eugene233) [20:44:16] (03CR) 10Amire80: "Try:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373890 (https://phabricator.wikimedia.org/T173181) (owner: 10Eugene233) [21:22:00] 10WikiEditor, 10CodeEditor, 10OOjs-UI, 10CSS, 10Design: Fix several design features of WikiEditor and CodeEditor to match the general style - https://phabricator.wikimedia.org/T174119#3554428 (10Iniquity) >What "general styleguide" do you have in mind that this is trying to ape? These changes don't look... [21:47:43] 10WikiEditor, 10CodeEditor, 10UI-Standardization, 10CSS, 10Design: Fix several design features of WikiEditor and CodeEditor to match the general style - https://phabricator.wikimedia.org/T174119#3554576 (10Volker_E) p:05Triage>03Lowest [21:51:52] 10WikiEditor, 10CodeEditor, 10UI-Standardization, 10CSS, 10Design: Fix several design features of WikiEditor and CodeEditor to match the general style - https://phabricator.wikimedia.org/T174119#3554596 (10Volker_E) @Iniquity As much as I understand (and in some ways would support) this cause, we are cur... [23:15:21] (03CR) 10Tchanders: [C: 032] DiffElement: Fix insert/delete-to-end loops [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/373706 (https://phabricator.wikimedia.org/T173860) (owner: 10Esanders) [23:17:34] (03Merged) 10jenkins-bot: DiffElement: Fix insert/delete-to-end loops [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/373706 (https://phabricator.wikimedia.org/T173860) (owner: 10Esanders) [23:30:18] (03CR) 10jenkins-bot: DiffElement: Fix insert/delete-to-end loops [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/373706 (https://phabricator.wikimedia.org/T173860) (owner: 10Esanders)