[00:03:43] 10VisualEditor, 10VisualEditor-VisualDiffs: Consider clarifying the visual language for Visual Diffs - https://phabricator.wikimedia.org/T169325#3587029 (10Volker_E) >>! In T169325#3583023, @Prtksxna wrote: >>>! In T169325#3583001, @Volker_E wrote: >> Also, please consider color coding not to be [[ http://weba... [00:29:05] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-DataModel, 10MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), and 2 others: ve.dm.TransactionProcessor: Restructure DM tree branches using existing nodes, instead of rebuilding the... - https://phabricator.wikimedia.org/T162762#3587049 [02:11:18] (03CR) 10Legoktm: Don't set arbitrary properties on ParserOutput, and minor cleanup (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/375437 (owner: 10Legoktm) [05:29:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376468 (owner: 10L10n-bot) [06:21:49] 10VisualEditor, 10MobileFrontend, 10Readers-Web-Backlog (Tracking), 10Regression: Link to talk / discussion page should indicate if page exists or not - https://phabricator.wikimedia.org/T174995#3587324 (10Nemo_bis) This has nothing whatsoever to do with VisualEditor, as far as I can tell. [08:28:30] 10VisualEditor: Resize an image floating close to a list moves the bullets - https://phabricator.wikimedia.org/T175237#3587454 (10Trizek-WMF) [10:02:25] 10Citoid, 10TemplateData, 10VisualEditor: Consider adding "boolean" as a type for template data (and possibly add negation?) - https://phabricator.wikimedia.org/T175247#3587703 (10Mvolz) [10:11:29] 10Citoid, 10TemplateData, 10VisualEditor: Consider adding "boolean" as a type for template data (and possibly add negation?) - https://phabricator.wikimedia.org/T175247#3587721 (10Mvolz) Hmm maybe T144155 is similar, apparently there *is* a "boolean" type? I guess it's only in the SC? [10:12:49] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Create dedicated input methods for "boolean" transclusion parameters - https://phabricator.wikimedia.org/T144155#2590142 (10Mvolz) I would also like to see yes/no supported, see: T175247 [10:14:43] 10Citoid, 10TemplateData, 10VisualEditor: Consider adding negation in template data maps for boolean values - https://phabricator.wikimedia.org/T175247#3587703 (10Mvolz) [10:14:54] 10Citoid, 10TemplateData, 10VisualEditor: Consider adding negation in template data maps for boolean values - https://phabricator.wikimedia.org/T175247#3587742 (10Mvolz) [10:21:17] 10TemplateData, 10VisualEditor: Add cancel button to parameter editing dialog in GUI TD editor - https://phabricator.wikimedia.org/T175250#3587762 (10Mvolz) [10:33:13] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Create dedicated input methods for "boolean" transclusion parameters - https://phabricator.wikimedia.org/T144155#3587780 (10Mvolz) >>! In T144155#2633095, @Trizek-WMF wrote: > > > Is there any documentation somewhere? There's the spec her... [10:55:22] 10TemplateData, 10VisualEditor: Add cancel button to parameter editing dialog in GUI TD editor - https://phabricator.wikimedia.org/T175250#3587762 (10Deskana) I don't know much about TemplateData. Is this dialogue provided by the VisualEditor extension, or something else? [10:59:04] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-DataModel, 10MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), and 2 others: ve.dm.TransactionProcessor: Restructure DM tree branches using existing nodes, instead of rebuilding the... - https://phabricator.wikimedia.org/T162762#3587805 [10:59:06] 10VisualEditor, 10VisualEditor-DataModel, 10Patch-For-Review: Introduce DM events for "a node of this type was inserted/deleted/modified"? - https://phabricator.wikimedia.org/T162761#3587807 (10Deskana) [11:02:18] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-DataModel, 10MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), and 2 others: ve.dm.TransactionProcessor: Restructure DM tree branches using existing nodes, instead of rebuilding the... - https://phabricator.wikimedia.org/T162762#3587816 [11:02:21] 10VisualEditor, 10VisualEditor-CopyPaste, 10Patch-For-Review, 10User-Ryasmeen: Pasting a table into the middle of text causes all the corruptions with TreeModifier - https://phabricator.wikimedia.org/T166041#3587815 (10Deskana) 05Open>03Resolved [11:02:27] 10TemplateData, 10VisualEditor: Add cancel button to parameter editing dialog in GUI TD editor - https://phabricator.wikimedia.org/T175250#3587762 (10Esanders) It's provided by the TemplateData extension, written VE and former-VE members to support VE's template editing. [11:05:22] https://grafana.wikimedia.org/dashboard/db/visualeditor-load-save?refresh=5m&orgId=1&from=now-1y&to=now-3m [11:05:37] hmmm, is this indicating that VE usage is dropping for the past half year ? [11:09:44] 10TemplateData, 10VisualEditor: Add cancel button to parameter editing dialog in GUI TD editor - https://phabricator.wikimedia.org/T175250#3587824 (10Esanders) The difficulty here is that changes to the fields update the model instantly, not just when 'done' is pressed, so there would need to be a significant... [11:42:12] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-DataModel, 10MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), and 2 others: ve.dm.TransactionProcessor: Restructure DM tree branches using existing nodes, instead of rebuilding the... - https://phabricator.wikimedia.org/T162762#3587862 [11:42:14] 10VisualEditor, 10VisualEditor-DataModel, 10Patch-For-Review, 10User-Ryasmeen: Re-fix "Inserting a reference sometimes breaks horribly (due to trees in TransactionProcessor?)" - https://phabricator.wikimedia.org/T167027#3587860 (10Deskana) 05Open>03Resolved a:03dchan [12:01:41] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Toolbar "Save page" button is confusing as it merely opens the dialog to save the page - https://phabricator.wikimedia.org/T44138#3587933 (10Frigory) > for example, we can provide an access to preview as an additional mode in the menu we provide access to... [12:14:50] (03PS1) 10Bartosz Dziewoński: Do not "resolve attributes" in toDomElements() overrides [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376507 (https://phabricator.wikimedia.org/T169675) [12:14:55] (03PS3) 10Bartosz Dziewoński: ve.ce.Surface: Make attribute resolution consistent with ve.ui.PreviewElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376262 [12:59:47] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Design: Provide a 'delete' button on focusable nodes in desktop - https://phabricator.wikimedia.org/T99862#1300571 (10Prtksxna) The delete button could be placed in the same manner that it currently is on tables. |Tables (with delete buttons)|Templates (... [13:04:42] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design: SurfaceWidget when active should be styled like other OOUI widgets are (blue box/etc.) - https://phabricator.wikimedia.org/T78358#843255 (10Prtksxna) Should this now be `TargetWidget` (since rGVED826055ac43ca674937a4acc7d3d98ae4f420aad2), or am I confusing... [13:09:42] 10VisualEditor, 10VisualEditor-Tables, 10Design: Tables: If you select N rows / columns and click "insert above/below" or "… left/right", VE should insert N rows / columns, not 1 - https://phabricator.wikimedia.org/T75227#751266 (10Prtksxna) >>! In T75227#1954434, @Esanders wrote: > ..or we could show two op... [13:16:33] 10VisualEditor, 10VisualEditor-EditingTools, 10Design: VisualEditor: Make it easier to see that there is an option to paste as plain text - https://phabricator.wikimedia.org/T73612#775316 (10Prtksxna) >>! In T73612#775328, @Jdforrester-WMF wrote: > …so although we could add a "paste unformatted" button it wo... [13:22:54] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design: VisualEditor: Page options icon is confusing - https://phabricator.wikimedia.org/T71509#3588136 (10Prtksxna) [13:33:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design: VisualEditor: Page options icon is confusing - https://phabricator.wikimedia.org/T71509#716239 (10Prtksxna) //Page options// is a vague thing and so gets a vague icon {icon frown-o}. We could use the typical {icon cog} or {icon cogs} but that might get con... [14:03:05] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Create dedicated input methods for "boolean" transclusion parameters - https://phabricator.wikimedia.org/T144155#3588368 (10Trizek-WMF) >>! In T144155#3587780, @Mvolz wrote: >>>! In T144155#2633095, @Trizek-WMF wrote: >> >> >> Is there any... [14:40:24] (03PS1) 10Esanders: Rebaser: Rename author to authorId consistently [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376526 [15:01:25] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Create dedicated input methods for "boolean" transclusion parameters - https://phabricator.wikimedia.org/T144155#3588584 (10Mvolz) >>! In T144155#3588368, @Trizek-WMF wrote: >>>! In T144155#3587780, @Mvolz wrote: >>>>! In T144155#2633095, @T... [15:18:32] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Create dedicated input methods for "boolean" transclusion parameters - https://phabricator.wikimedia.org/T144155#3588622 (10Trizek-WMF) Is possible to define some aliases on each wiki? | 0 | yes | oui | vrai | 1 | no | non | faux If so Te... [15:22:24] (03CR) 10Jforrester: [C: 032] Rebaser: Rename author to authorId consistently [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376526 (owner: 10Esanders) [15:24:37] (03Merged) 10jenkins-bot: Rebaser: Rename author to authorId consistently [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376526 (owner: 10Esanders) [15:26:45] (03CR) 10jenkins-bot: Rebaser: Rename author to authorId consistently [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376526 (owner: 10Esanders) [15:26:50] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Create dedicated input methods for "boolean" transclusion parameters - https://phabricator.wikimedia.org/T144155#3588678 (10Mvolz) >>! In T144155#3588622, @Trizek-WMF wrote: > Is possible to define some aliases on each wiki? > > | 0 | yes |... [15:35:27] James_F: bit concerning that eslint is failing locally in lib/ve, but not on gerrit [15:35:52] edsanders: Hmm. Did you upgrade? [15:36:01] npm install, yes [15:36:23] I get an indentation error in ve.ce.Surface [15:36:37] * James_F re-installs npm. [15:36:39] (03PS1) 10Esanders: lint: Remove unnecessary parentheses [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376533 [15:39:54] (03PS1) 10Esanders: Documentation fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376534 [15:40:30] (03CR) 10Jforrester: [C: 032] "Locally passes with and without…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376533 (owner: 10Esanders) [15:41:10] (03PS2) 10Jforrester: ve.ui.Surface: Documentation type hint fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376534 (owner: 10Esanders) [15:41:13] (03CR) 10Jforrester: [C: 032] ve.ui.Surface: Documentation type hint fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376534 (owner: 10Esanders) [15:41:47] (03PS1) 10DLynch: MWExtensionWindow: clean up originalMwData on teardown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376536 (https://phabricator.wikimedia.org/T172586) [15:42:24] (03CR) 10Jforrester: "This is a fun bug." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376536 (https://phabricator.wikimedia.org/T172586) (owner: 10DLynch) [15:43:54] (03Merged) 10jenkins-bot: lint: Remove unnecessary parentheses [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376533 (owner: 10Esanders) [15:45:56] (03Merged) 10jenkins-bot: ve.ui.Surface: Documentation type hint fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376534 (owner: 10Esanders) [15:48:01] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design: TargetWidget when active should be styled like other OOUI widgets are (blue box/etc.) - https://phabricator.wikimedia.org/T78358#3588739 (10Jdforrester-WMF) [15:48:53] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design: TargetWidget when active should be styled like other OOUI widgets are (blue box/etc.) - https://phabricator.wikimedia.org/T78358#843255 (10Jdforrester-WMF) Yup. [15:50:38] (03CR) 10jenkins-bot: lint: Remove unnecessary parentheses [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376533 (owner: 10Esanders) [15:53:06] (03CR) 10jenkins-bot: ve.ui.Surface: Documentation type hint fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376534 (owner: 10Esanders) [16:06:06] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Create dedicated input methods for "boolean" transclusion parameters - https://phabricator.wikimedia.org/T144155#3588792 (10Trizek-WMF) The first thing that should be done when you define a parameter in Template data is to define the type of... [16:24:13] 10Citoid, 10VisualEditor, 10Outreach-Programs-Projects, 10Possible-Tech-Projects, and 2 others: Write a Zotero translator and document process for creating new Zotero translator and getting it live in production - https://phabricator.wikimedia.org/T115158#3588892 (10Elitre) What he said! TYVM!!! [17:42:04] 10VisualEditor, 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint: ACW should intercept page creation via VisualEditor - https://phabricator.wikimedia.org/T173605#3589124 (10kaldari) Redlinks link to title=XXXX&action=edit&redlink=1, so that's what we need to intercept. Basically, we ne... [17:53:21] 10VisualEditor, 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint: VisualEditor prevents AlternateEdit hook from working - https://phabricator.wikimedia.org/T175292#3589161 (10kaldari) [17:54:09] 10VisualEditor, 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint: VisualEditor prevents AlternateEdit hook from working - https://phabricator.wikimedia.org/T175292#3589176 (10kaldari) p:05Triage>03High [18:02:57] 10VisualEditor, 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint: VisualEditor prevents AlternateEdit hook from working - https://phabricator.wikimedia.org/T175292#3589229 (10kaldari) [18:24:12] 10VisualEditor, 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint: VisualEditor prevents AlternateEdit hook from working - https://phabricator.wikimedia.org/T175292#3589319 (10kaldari) @Jdforrester-WMF: Any ideas about how to fix this (or work around it)? How does VisualEditor prevent E... [18:45:44] 10VisualEditor, 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint: VisualEditor prevents AlternateEdit hook from working - https://phabricator.wikimedia.org/T175292#3589450 (10kaldari) 05Open>03Invalid Ah, it looks like there is a CustomEditor hook that fires before AlternateEdit an... [18:54:05] 10Cite, 10VisualEditor, 10Wikimedia-Site-requests, 10Patch-For-Review: Convert reference lists over to `responsive` on enwiki - https://phabricator.wikimedia.org/T173176#3589481 (10Whatamidoing-WMF) This is scheduled for Monday, 11 September 2017. Please note that this config change will **not** affect... [19:05:28] 10VisualEditor, 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint: ACW should intercept page creation via VisualEditor - https://phabricator.wikimedia.org/T173605#3589512 (10kaldari) So it looks like VisualEditor uses the CustomEditor hook to do it's intercepting. We should try using Cu... [19:06:06] 10VisualEditor, 10Africa-Wikimedia-Developers, 10MinervaNeue, 10Patch-For-Review, 10User-Ryasmeen: Text area not obvious when creating New talk page on MF with MinervaB - https://phabricator.wikimedia.org/T174158#3589515 (10Jdforrester-WMF) [19:35:13] 10VisualEditor, 10MinervaNeue, 10Patch-For-Review, 10User-Ryasmeen: Text area not obvious when creating New talk page on MF with MinervaB - https://phabricator.wikimedia.org/T174158#3589597 (10D3r1ck01) [20:07:06] (03CR) 10Bartosz Dziewoński: [C: 032] MWExtensionWindow: clean up originalMwData on teardown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376536 (https://phabricator.wikimedia.org/T172586) (owner: 10DLynch) [20:12:51] (03Merged) 10jenkins-bot: MWExtensionWindow: clean up originalMwData on teardown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376536 (https://phabricator.wikimedia.org/T172586) (owner: 10DLynch) [20:13:11] 10WikiEditor, 10MediaWiki-extensions-CodeMirror, 10Community-Tech-Sprint, 10Patch-For-Review: Browser Ctrl-F search can't search text outside of current view - https://phabricator.wikimedia.org/T174480#3589712 (10matmarex) [20:14:40] (03CR) 10jenkins-bot: MWExtensionWindow: clean up originalMwData on teardown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376536 (https://phabricator.wikimedia.org/T172586) (owner: 10DLynch) [20:15:56] 10VisualEditor, 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint: ACW should intercept page creation via VisualEditor - https://phabricator.wikimedia.org/T173605#3589723 (10Niharika) >>! In T173605#3589512, @kaldari wrote: > > P.S. - We'll also have to make sure that `wfLoadExtension(... [20:27:16] 10VisualEditor, 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint: ACW should intercept page creation via VisualEditor - https://phabricator.wikimedia.org/T173605#3589756 (10MaxSem) >>! In T173605#3589723, @Niharika wrote: > Is that even doable? Yes, with a scary comment. [21:32:47] (03PS1) 10Esanders: Minimise dependencies, and make toolbar tweaks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376619 [21:40:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/376624 (owner: 10L10n-bot) [21:44:17] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376630 (owner: 10L10n-bot) [21:53:54] (03CR) 10Jforrester: Minimise dependencies, and make toolbar tweaks (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376619 (owner: 10Esanders) [22:00:33] 10VisualEditor, 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint, 10Patch-For-Review: ACW should intercept page creation via VisualEditor - https://phabricator.wikimedia.org/T173605#3589961 (10kaldari) @Niharika, @MaxSem: Niharika's patch solves the "veaction=edit" case, but still do... [22:02:33] 10VisualEditor, 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint, 10Patch-For-Review: ACW should intercept page creation via VisualEditor - https://phabricator.wikimedia.org/T173605#3589963 (10Niharika) >>! In T173605#3589961, @kaldari wrote: > @Niharika, @MaxSem: Niharika's patch so... [22:42:24] 10VisualEditor, 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint, 10Patch-For-Review: ACW should intercept page creation via VisualEditor - https://phabricator.wikimedia.org/T173605#3590051 (10Niharika) @kaldari: My patch is on the beta cluster. You can test it. https://en.wikipedia.... [23:19:02] 10VisualEditor, 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint, 10MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), 10Patch-For-Review: ACW should intercept page creation via VisualEditor - https://phabricator.wikimedia.org/T173605#3590099 (10kaldari) Doesn't work fo...