[01:41:30] (03Abandoned) 10Divec: WIP: Miscellaneous support for ContentTranslation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/363521 (owner: 10Divec) [05:28:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377191 (owner: 10L10n-bot) [08:45:42] 10Citoid, 10VisualEditor, 10Services (watching), 10User-Ryasmeen: Update zotero translators - https://phabricator.wikimedia.org/T174992#3595472 (10mobrovac) 05Open>03Resolved Deployed, resolving. [10:52:55] 10VisualEditor: Resize an image floating close to a list moves the bullets - https://phabricator.wikimedia.org/T175237#3595950 (10Deskana) p:05Triage>03Normal This needs further investigation. I tried this in Chrome on a Mac, but had a different problem where the bullets ended up inside the image. The page... [11:08:05] 10VisualEditor, 10I18n, 10Patch-For-Review: Allow special keys in keyboard shortcuts to be translated - https://phabricator.wikimedia.org/T175449#3595990 (10Deskana) p:05Triage>03Normal a:03Esanders [11:09:42] 10VisualEditor, 10VisualEditor-MediaWiki: VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation - https://phabricator.wikimedia.org/T114531#3596009 (10Deskana) [11:09:44] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: 2017 wikitext editor doesn't load when I want to undo an edit - https://phabricator.wikimedia.org/T175446#3596011 (10Deskana) [11:33:22] 10VisualEditor, 10I18n, 10RTL, 10Regression: VE table columns editing is destroyed in RTL - https://phabricator.wikimedia.org/T175417#3596077 (10Deskana) p:05Triage>03High [11:34:30] 10VisualEditor, 10Patch-For-Review, 10User-Ryasmeen: Cannot add the same Math/Chemical formula that has been cleared from the context menu before. - https://phabricator.wikimedia.org/T172586#3596094 (10Deskana) 05Open>03Resolved a:03DLynch [11:37:15] 10VisualEditor: Can't always close VE welcome prompt - https://phabricator.wikimedia.org/T175428#3593127 (10Deskana) @jrbs Can you give a link to the page in question? [11:38:08] 10VisualEditor: Hidden comment within a list on its own line, is not shown in visual editor - https://phabricator.wikimedia.org/T175490#3596117 (10Deskana) p:05Triage>03Low [11:48:38] 10VisualEditor, 10VisualEditor-ContentEditable: Exception when unbulleting the final bullet of a list - https://phabricator.wikimedia.org/T175548#3596154 (10dchan) [11:51:52] 10VisualEditor, 10VisualEditor-EditingTools, 10Design: VisualEditor: Make it easier to see that there is an option to paste as plain text - https://phabricator.wikimedia.org/T73612#3596172 (10Deskana) p:05Normal>03Lowest >>! In T73612#3588103, @Prtksxna wrote: > Has this come up as a problem again? Ther... [11:55:54] (03CR) 10Deskana: [C: 032] "Where is Dam when you need him? I'll merge it instead." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/374636 (https://phabricator.wikimedia.org/T170665) (owner: 10Tchanders) [11:57:26] (03PS1) 10Divec: WIP: Notification for DM node attached/detached [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377237 [11:59:14] (03CR) 10jerkins-bot: [V: 04-1] WIP: Notification for DM node attached/detached [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377237 (owner: 10Divec) [12:01:39] (03CR) 10Divec: "@Esanders , care to comment on the use of ve.Document#onNodeAttach / ve.Document#onNodeDetach ?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377237 (owner: 10Divec) [12:01:41] (03Merged) 10jenkins-bot: Add feedback link for visual diff inside save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/374636 (https://phabricator.wikimedia.org/T170665) (owner: 10Tchanders) [12:03:10] 10VisualEditor, 10VisualEditor-VisualDiffs, 10MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), 10Patch-For-Review, 10User-Ryasmeen: Inform users inside the editor that visual diffs are in beta - https://phabricator.wikimedia.org/T170665#3596228 (10Deskana) 05Open>03Resolved a:03Tchande... [12:03:18] (03CR) 10jenkins-bot: Add feedback link for visual diff inside save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/374636 (https://phabricator.wikimedia.org/T170665) (owner: 10Tchanders) [13:42:59] 10VisualEditor: Resize an image floating close to a list moves the bullets - https://phabricator.wikimedia.org/T175237#3587454 (10TheDJ) Note that bullets next to floating items are inherently somewhat problematic in HTML/CSS. It's why we have [[ https://en.wikipedia.org/wiki/Template:Flowlist | Template flowlis... [15:01:42] (03CR) 10DLynch: [C: 032] Don't require a selection to run any of the save actions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377050 (owner: 10Esanders) [15:10:24] (03Merged) 10jenkins-bot: Don't require a selection to run any of the save actions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377050 (owner: 10Esanders) [15:16:00] (03CR) 10DLynch: Make special keys translatable (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376896 (https://phabricator.wikimedia.org/T175449) (owner: 10Esanders) [15:31:20] (03PS8) 10Esanders: [WIP] Undo support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/323357 (https://phabricator.wikimedia.org/T78550) (owner: 10Alex Monk) [15:31:22] (03PS1) 10Esanders: Change ArticleTargetLoader#requestPageData API to use options object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377285 [15:31:24] (03PS1) 10Esanders: Remove pageName/revision from ArticleTarget constructor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377286 [15:31:26] (03PS1) 10Esanders: Use lowerCamelCase for javascript var oldId [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377287 [16:00:38] (03PS1) 10Esanders: Make save commands triggerable form anywhere [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377293 [16:05:07] 10VisualEditor, 10VisualEditor-VisualDiffs, 10MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), 10Patch-For-Review, 10User-Ryasmeen: Inform users inside the editor that visual diffs are in beta - https://phabricator.wikimedia.org/T170665#3597394 (10Deskana) [16:33:02] 10VisualEditor, 10VisualEditor-VisualDiffs, 10MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), 10Patch-For-Review, 10User-Ryasmeen: Inform users inside the editor that visual diffs are in beta - https://phabricator.wikimedia.org/T170665#3597533 (10Deskana) Updated release tag to represent t... [16:34:43] (03PS1) 10DLynch: DesktopArticleTarget.init: handle new-section tab when in visual mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377301 (https://phabricator.wikimedia.org/T157755) [16:49:09] James_F: do new users now get VE source editing mode by default when they edit a talk page? [16:49:43] (on enwiki) [16:49:52] ragesoss: No. Manual opt-in beta feature only. Not even if you click "give me all beta features". [16:50:23] ragesoss: Deskana might be changing that to being a regular beta feature, but I think we're a way away from giving it to brand new users by default, sorry. [16:51:22] James_F: no worries. I got a bug report from a professor about the talk page guided tour not working, with a screenshot of VE source editing. but he must have enabled the manually, I guess. [16:51:38] Almost certainly. Or a very odd bug. [16:51:38] so I don't have to rewrite that tour *yet* [16:51:42] :-D [16:52:37] James_F: what is that beta setting called (in terms of setting in via the API)? [16:53:40] ragesoss: visualeditor-newwikitext [16:55:06] visualeditor-newwikitext=0 to disable? [16:55:18] Yes. [16:55:28] That's the default. [16:56:20] maybe I'll just set that explicitly upon joining a course to avoid problems with the occasional person who fiddles with it. [16:56:29] * James_F nods. [17:19:46] (03CR) 10jenkins-bot: Don't require a selection to run any of the save actions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377050 (owner: 10Esanders) [17:31:18] 10VisualEditor: Can't always close VE welcome prompt - https://phabricator.wikimedia.org/T175428#3597767 (10jrbs) This is the link I followed to get this error (I had not edited on svwp previously, but could in theory create the page with my `+staff`): https://sv.wikipedia.org/w/index.php?title=Medborgerlig_Saml... [17:58:15] (03PS2) 10Arlolra: Fix editing figcaptions in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376864 (https://phabricator.wikimedia.org/T174774) [18:00:20] 10Cite, 10Parsoid: Port some patches to Parsoid cite ext implementation - https://phabricator.wikimedia.org/T175222#3597936 (10Arlolra) [18:00:23] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Parsoid: Add support to Parsoid's cite code for `responsive` parameter - https://phabricator.wikimedia.org/T159894#3597934 (10Arlolra) [18:01:23] (03PS3) 10Esanders: Fix editing figcaptions in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376864 (https://phabricator.wikimedia.org/T174774) (owner: 10Arlolra) [18:01:50] (03CR) 10Esanders: "oops" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376864 (https://phabricator.wikimedia.org/T174774) (owner: 10Arlolra) [18:02:24] (03PS4) 10Esanders: Fix editing figcaptions in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376864 (https://phabricator.wikimedia.org/T174774) (owner: 10Arlolra) [18:03:19] (03CR) 10Esanders: [C: 032] Fix editing figcaptions in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376864 (https://phabricator.wikimedia.org/T174774) (owner: 10Arlolra) [18:03:59] (03CR) 10Arlolra: "Nice collision :)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376864 (https://phabricator.wikimedia.org/T174774) (owner: 10Arlolra) [18:13:39] (03CR) 10jerkins-bot: [V: 04-1] Fix editing figcaptions in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376864 (https://phabricator.wikimedia.org/T174774) (owner: 10Arlolra) [18:24:16] edsanders: ^^^ Eurgh, i18n-bot strikes again. [18:26:08] (03PS1) 10Esanders: i18n-bot fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377318 [18:27:10] (03CR) 10Bartosz Dziewoński: [C: 032] i18n-bot fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377318 (owner: 10Esanders) [18:28:40] (03CR) 10Esanders: Make special keys translatable (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376896 (https://phabricator.wikimedia.org/T175449) (owner: 10Esanders) [18:30:26] in case anyone is wondering what i wasted a bunch of time today on, i discovered the weirdest chrome bug. https://jsfiddle.net/734vdpoj/ click "Toggle table rows" twice and the table will get all jumbled up. [18:30:38] (03PS5) 10Esanders: Fix editing figcaptions in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376864 (https://phabricator.wikimedia.org/T174774) (owner: 10Arlolra) [18:32:08] MatmaRex: … huh. Yeah, works fine in Firefox and Safari. [18:33:18] James_F: affects some pages on Commons, e.g. https://commons.wikimedia.org/wiki/Creator:A._R._Pshchelko [18:33:51] (the table is collapsible, click the header row) [18:34:53] (03Merged) 10jenkins-bot: i18n-bot fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377318 (owner: 10Esanders) [18:42:21] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Wikimedia-Site-requests, 10Community-Liaisons (Jul-Sep 2017): Support wikis in converting reference lists over to `responsive` - https://phabricator.wikimedia.org/T159895#3598217 (10Jdforrester-WMF) [18:42:24] 10Cite, 10VisualEditor, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Ryasmeen: Convert reference lists over to `responsive` on enwiki - https://phabricator.wikimedia.org/T173176#3598215 (10Jdforrester-WMF) 05Open>03Resolved Now live. From some spot checking, everything looks good, but if the... [18:42:37] 10Cite, 10VisualEditor, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Ryasmeen: Convert reference lists over to `responsive` on enwiki - https://phabricator.wikimedia.org/T173176#3598219 (10Jdforrester-WMF) [18:43:05] (03CR) 10Esanders: [C: 032] "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376864 (https://phabricator.wikimedia.org/T174774) (owner: 10Arlolra) [18:45:40] (03Merged) 10jenkins-bot: Fix editing figcaptions in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376864 (https://phabricator.wikimedia.org/T174774) (owner: 10Arlolra) [18:47:48] 10WikiEditor, 10MediaWiki-extensions-CodeMirror, 10Community-Tech-Sprint, 10Patch-For-Review: Browser Ctrl-F search can't search text outside of current view - https://phabricator.wikimedia.org/T174480#3598232 (10Niharika) For the ticket watchers - the above patch fixes the ctrl+f issues but it might show... [18:53:56] 10WikiEditor, 10MediaWiki-extensions-CodeMirror, 10Community-Tech-Sprint, 10Patch-For-Review: Browser Ctrl-F search can't search text outside of current view - https://phabricator.wikimedia.org/T174480#3563387 (10matmarex) >>! In T174480#3578106, @Niharika wrote: >>>! In T174480#3576427, @Pastakhov wrote:... [19:44:46] (now reported as https://bugs.chromium.org/p/chromium/issues/detail?id=764031) [19:46:24] (03CR) 10jenkins-bot: i18n-bot fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377318 (owner: 10Esanders) [19:48:22] (03CR) 10jenkins-bot: Fix editing figcaptions in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376864 (https://phabricator.wikimedia.org/T174774) (owner: 10Arlolra) [20:06:55] (03CR) 10Jforrester: [C: 032] Use lowerCamelCase for javascript var oldId [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377287 (owner: 10Esanders) [20:15:21] (03CR) 10Jforrester: [C: 031] Change ArticleTargetLoader#requestPageData API to use options object (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377285 (owner: 10Esanders) [20:18:55] (03PS1) 10Jforrester: Update VE core submodule to master (02a2ea954) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377336 (https://phabricator.wikimedia.org/T174774) [20:22:58] (03CR) 10Jforrester: [C: 031] Make special keys translatable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376896 (https://phabricator.wikimedia.org/T175449) (owner: 10Esanders) [20:28:03] 10Citoid, 10VisualEditor: Citoid for DOI has problems with < > - https://phabricator.wikimedia.org/T175632#3598499 (10PerfektesChaos) [20:33:02] (03CR) 10Jforrester: [C: 032] Remove pageName/revision from ArticleTarget constructor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377286 (owner: 10Esanders) [20:34:31] (03CR) 10Jforrester: [WIP] Undo support (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/323357 (https://phabricator.wikimedia.org/T78550) (owner: 10Alex Monk) [20:37:59] (03CR) 10Jforrester: [C: 031] DesktopArticleTarget.init: handle new-section tab when in visual mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377301 (https://phabricator.wikimedia.org/T157755) (owner: 10DLynch) [20:38:57] MatmaRex: Why is https://gerrit.wikimedia.org/r/#/c/375021/ C-2'ed? It's just a regular MW train dependency, right? [20:40:19] James_F: yes. i removed it now [20:40:40] James_F: actually i'm not sure what you mean by "regular MW train dependency", but [20:40:58] from https://gerrit.wikimedia.org/r/#/c/375020/ : "To avoid transient problems during deployment (old JS code cached in the user's browser receiving the new format of API responses), the old property is kept in the API response. We should remove it next week." – https://gerrit.wikimedia.org/r/#/c/375021/ is the change to remove it [20:41:01] James_F: ^ [20:42:17] Yes. 375020 is merged and will go out in wmf.18, which if we merge it now 375021 will also ship with. [20:42:17] (03CR) 10Esanders: [C: 032] Remove use of deprecated EditPage::getCheckboxes() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/375021 (https://phabricator.wikimedia.org/T174613) (owner: 10Bartosz Dziewoński) [20:42:44] 375021 should be in the next wmf.XX after 375020 [20:42:45] Client-side cached versions of RL modules should not be an issue any more though, right? Now we have the hashes and all that… [20:43:00] Oh, well. It won't be, now edsanders just C+2'ed it. [20:43:07] James_F: yes, i meant it mostly for the case of long-running editor sessions [20:43:23] So someone clicks edit under wmf.17 and tries to edit under wmf.18? [20:43:27] s/edit/save/ [20:43:39] (03CR) 10Bartosz Dziewoński: [C: 04-2] "Actually this should probably go out next week, per the commit message on https://gerrit.wikimedia.org/r/#/c/375020/ ?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/375021 (https://phabricator.wikimedia.org/T174613) (owner: 10Bartosz Dziewoński) [20:43:51] Oy. [20:44:06] James_F: yes. or clicks edit under wmf.17, completes an edit, then clicks edit again and in the meantime we've rolled out wmf.18 [20:44:28] Because the page is repainted not reloaded, right. [20:44:50] James_F: or even during the 5 minute window before RL caches expire. i think even that case is worth avoiding [20:44:53] Theoretically this would break every week though. Ah well. [20:44:55] * James_F nods. [20:45:05] since if it fails, you possibly end up with a hung save dialog and no way to recover [20:45:10] True. [20:45:21] * James_F was hunting for code to review and merge. [20:46:08] Kemayo: edsanders helpfully re-wrote the code you were fiddling with for his undo stuff, BTW. Because he's horrible or something. (I.e., your https://gerrit.wikimedia.org/r/#/c/377301/ and his https://gerrit.wikimedia.org/r/#/c/377287/ conflict.) [21:08:33] (03CR) 10Esanders: [C: 032] Avoid using deprecated ParserCache::singleton() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376856 (owner: 10Legoktm) [21:14:15] (03Merged) 10jenkins-bot: Avoid using deprecated ParserCache::singleton() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376856 (owner: 10Legoktm) [21:18:20] 10VisualEditor, 10I18n, 10RTL, 10Regression: VE table columns editing is destroyed in RTL - https://phabricator.wikimedia.org/T175417#3598553 (10Esanders) Pinging @DLynch [21:18:33] (03CR) 10jenkins-bot: Avoid using deprecated ParserCache::singleton() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376856 (owner: 10Legoktm) [21:19:46] 10VisualEditor, 10I18n, 10RTL, 10Regression: VE table columns editing is destroyed in RTL - https://phabricator.wikimedia.org/T175417#3598557 (10DLynch) ...huh. I'll take a look. [21:31:40] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Google-Chrome: "Undo" doesn't work from mouse (Chrome/Linux) - https://phabricator.wikimedia.org/T175634#3598581 (10Whatamidoing-WMF) [21:54:29] 10VisualEditor: Unable to save changes - https://phabricator.wikimedia.org/T173858#3598660 (10Whatamidoing-WMF) The original reporter says that this happens intermittently, which suggests a problem with an internet connection (and not, e.g., malformed wikitext on the page).