[07:42:59] 10Editing-team, 10VisualEditor, 10Performance-Team, 10User-Ryasmeen: Decommission webperf/ve.py daemon - https://phabricator.wikimedia.org/T175083#3599484 (10Krinkle) 05Open>03Resolved >>! In T175083#3587019, @gerritbot wrote: > Change 376146 merged by Dzahn: > [operations/puppet@production] webperf: D... [10:02:19] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Google-Chrome: "Undo" doesn't work from mouse (Chrome/Linux) - https://phabricator.wikimedia.org/T175634#3598581 (10Deskana) Right click is "Undo" in Ubuntu?! [10:08:54] (03PS2) 10Divec: Notification for DM node attached/detached [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377237 [10:55:37] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Google-Chrome: "Undo" doesn't work from mouse (Chrome/Linux) - https://phabricator.wikimedia.org/T175634#3599847 (10Paucabot) Right click opens a context menu. The first option is "undo". [10:57:38] 10VisualEditor, 10VisualEditor-ContentEditable: Exception when unbulleting the final bullet of a list - https://phabricator.wikimedia.org/T175548#3599849 (10Esanders) Should we be reverting TreeModifier again before release then? @Deskana @Jdforrester-WMF [12:53:17] 10VisualEditor: Resize an image floating close to a list moves the bullets - https://phabricator.wikimedia.org/T175237#3600106 (10Trizek-WMF) >>! In T175237#3591089, @Esanders wrote: > Can you link to a page? That looks a lot like a browser bug, so there may be nothing we can do... I've tried it on mediawiki.or... [13:56:21] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Google-Chrome: "Undo" doesn't work from mouse (Chrome/Linux) - https://phabricator.wikimedia.org/T175634#3598581 (10Esanders) Unfortunately this doesn't fire a reliable event. In Chrome it looks like you get event.inputType = 'his... [14:11:16] (03PS1) 10Esanders: Trigger proper undo/redo when inputType=historyUndo/Redo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377471 (https://phabricator.wikimedia.org/T175634) [14:12:54] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Efficient correction of previewed errors in Wikitext edit mode - https://phabricator.wikimedia.org/T175453#3600403 (10Nanimo5) [14:13:08] (03CR) 10jerkins-bot: [V: 04-1] Trigger proper undo/redo when inputType=historyUndo/Redo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377471 (https://phabricator.wikimedia.org/T175634) (owner: 10Esanders) [14:43:18] (03PS2) 10Esanders: Trigger proper undo/redo when inputType=historyUndo/Redo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377471 (https://phabricator.wikimedia.org/T175634) [14:45:20] (03CR) 10jerkins-bot: [V: 04-1] Trigger proper undo/redo when inputType=historyUndo/Redo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377471 (https://phabricator.wikimedia.org/T175634) (owner: 10Esanders) [14:58:42] (03PS1) 10DLynch: ui.TableLineContext: adjust positioning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377482 (https://phabricator.wikimedia.org/T175417) [14:59:29] (03CR) 10Jforrester: [C: 04-1] "Interesting fake IME test breakage." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377471 (https://phabricator.wikimedia.org/T175634) (owner: 10Esanders) [15:17:50] (03PS3) 10Esanders: Trigger proper undo/redo when inputType=historyUndo/Redo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377471 (https://phabricator.wikimedia.org/T175634) [15:17:52] (03PS1) 10Esanders: Capture format* inputTypes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377487 [15:20:49] (03PS2) 10Esanders: Capture format* inputTypes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377487 [15:33:27] (03CR) 10Jforrester: Capture format* inputTypes (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377487 (owner: 10Esanders) [15:33:33] (03CR) 10Jforrester: [C: 031] "Very fancy." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377487 (owner: 10Esanders) [15:33:41] (03CR) 10Jforrester: [C: 031] Trigger proper undo/redo when inputType=historyUndo/Redo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377471 (https://phabricator.wikimedia.org/T175634) (owner: 10Esanders) [15:36:39] (03CR) 10DLynch: [C: 032] Trigger proper undo/redo when inputType=historyUndo/Redo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377471 (https://phabricator.wikimedia.org/T175634) (owner: 10Esanders) [15:38:21] (03CR) 10Esanders: Capture format* inputTypes (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377487 (owner: 10Esanders) [15:38:49] (03Merged) 10jenkins-bot: Trigger proper undo/redo when inputType=historyUndo/Redo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377471 (https://phabricator.wikimedia.org/T175634) (owner: 10Esanders) [15:38:53] (03CR) 10Jforrester: [C: 031] Capture format* inputTypes (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377487 (owner: 10Esanders) [15:41:06] (03CR) 10jenkins-bot: Trigger proper undo/redo when inputType=historyUndo/Redo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377471 (https://phabricator.wikimedia.org/T175634) (owner: 10Esanders) [15:41:24] (03CR) 10Jforrester: [C: 032] ui.TableLineContext: adjust positioning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377482 (https://phabricator.wikimedia.org/T175417) (owner: 10DLynch) [15:41:50] Kemayo: You OK with https://gerrit.wikimedia.org/r/#/c/376896/ being merged? [15:42:31] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Google-Chrome, 10Patch-For-Review, 10User-Ryasmeen: "Undo" doesn't work from mouse (Chrome/Linux) - https://phabricator.wikimedia.org/T175634#3600858 (10Deskana) 05Open>03Resolved a:03Esanders Hopefully this fixes things... [15:43:26] (03CR) 10DLynch: Make special keys translatable (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376896 (https://phabricator.wikimedia.org/T175449) (owner: 10Esanders) [15:43:32] (03Merged) 10jenkins-bot: ui.TableLineContext: adjust positioning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377482 (https://phabricator.wikimedia.org/T175417) (owner: 10DLynch) [15:43:56] James_F: I still have that quibble about the "enter" symbol making the command help dialog more incomprehensible. [15:44:27] Kemayo: True, but we don't actually use it in practice. [15:44:41] Yes we do, that's why I'm complaining. [15:45:43] (03CR) 10jenkins-bot: ui.TableLineContext: adjust positioning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377482 (https://phabricator.wikimedia.org/T175417) (owner: 10DLynch) [15:45:52] James_F: https://usercontent.irccloud-cdn.com/file/LMMIRw5b/ [15:46:20] Oh, I thought that showed return? [15:46:38] Certainly I use the Return key not the Enter key to trigger it. [15:46:45] Nah, it's in the shortcuts list as "cmd+enter". [15:46:52] * James_F sighs. [15:47:14] Is this some silly Windows thing that calls Return 'enter' and the rest of the world has to follow or something? [15:48:23] Well, it's also that JS doesn't distinguish between them. Event keycode is 13 for both. [15:48:36] Fun. [15:48:50] So the OO.ui.Keys helper only has OO.ui.Keys.ENTER, which nudges us towards calling it that. [15:48:51] Should we change our bindings to return then and merge it? [15:49:18] Kemayo: Also, could you merge https://gerrit.wikimedia.org/r/#/c/377336/ ? ;-) [15:50:26] I'm not opposed to just changing it to being "ctrl+return", sure. I think the return-arrow symbol is more widely understood. [15:50:39] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (02a2ea954) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377336 (https://phabricator.wikimedia.org/T174774) (owner: 10Jforrester) [15:52:29] Though I do think there's a case for these less-used symbols just being spelled out like they currently are. That's probably a thing to debate with UX, though. [15:53:19] Not a bikeshed I'm willing to die on. ;P [15:54:49] I agree that we should show the return character as that's what 99.9999% of people will recognise. :-) [15:55:00] Kemayo: Want to make the fiddle and merge? [15:56:40] (03Merged) 10jenkins-bot: Update VE core submodule to master (02a2ea954) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377336 (https://phabricator.wikimedia.org/T174774) (owner: 10Jforrester) [15:57:06] James_F: sure, give me just a minute to get to it. [15:57:11] 10VisualEditor, 10VisualEditor-ContentEditable: Exception when unbulleting the final bullet of a list - https://phabricator.wikimedia.org/T175548#3600894 (10Deskana) >>! In T175548#3599849, @Esanders wrote: > Should we be reverting TreeModifier again before release then? @Deskana @Jdforrester-WMF We probably... [15:57:26] Good plan. :-) [15:58:40] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Media, 10Browser-Support-Firefox, and 2 others: Editing captions in Firefox is so unpredictable as to be useless - https://phabricator.wikimedia.org/T174774#3600899 (10Deskana) 05Open>03Resolved a:03Arlolra [16:01:30] 10VisualEditor, 10VisualEditor-VisualDiffs, 10MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), 10User-Ryasmeen: On diff pages, ?visualdiff=1 doesn't work if diff=prev rather than an revid - https://phabricator.wikimedia.org/T169574#3600905 (10matmarex) 05Open>03Resolved Thanks. Done: http... [16:03:45] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Google-Chrome, 10Patch-For-Review, 10User-Ryasmeen: "Undo" doesn't work from mouse (Chrome/Linux) - https://phabricator.wikimedia.org/T175634#3600910 (10Paucabot) Thanks, Deskana. When will it be deployed or when will I be abl... [16:04:05] (03CR) 10jenkins-bot: Update VE core submodule to master (02a2ea954) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377336 (https://phabricator.wikimedia.org/T174774) (owner: 10Jforrester) [16:08:45] James_F: Actually... just changing the shortcut doesn't do anything. The entire translation patch is set up so that "return" isn't translated, and even aliases uses of it into "enter". [16:10:47] Given that JS doesn't actually distinguish in any way, we could just use the ⏎ symbol for enter. [16:11:41] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Google-Chrome, 10Patch-For-Review, 10User-Ryasmeen: "Undo" doesn't work from mouse (Chrome/Linux) - https://phabricator.wikimedia.org/T175634#3600928 (10Deskana) >>! In T175634#3600910, @Paucabot wrote: > Thanks, Deskana. When... [16:14:28] (03PS5) 10DLynch: Make special keys translatable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376896 (https://phabricator.wikimedia.org/T175449) (owner: 10Esanders) [16:18:14] Meh. [16:18:37] (03CR) 10Jforrester: [C: 031] "Fine." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376896 (https://phabricator.wikimedia.org/T175449) (owner: 10Esanders) [16:18:41] (03CR) 10Jforrester: [C: 032] Make special keys translatable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376896 (https://phabricator.wikimedia.org/T175449) (owner: 10Esanders) [16:20:51] (03Merged) 10jenkins-bot: Make special keys translatable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376896 (https://phabricator.wikimedia.org/T175449) (owner: 10Esanders) [16:23:06] (03CR) 10jenkins-bot: Make special keys translatable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376896 (https://phabricator.wikimedia.org/T175449) (owner: 10Esanders) [16:29:20] (03PS2) 10Jforrester: Update VE core submodule to master (f88cd00a6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376899 (https://phabricator.wikimedia.org/T175417) (owner: 10Esanders) [16:33:00] 10VisualEditor, 10I18n, 10Patch-For-Review: Allow special keys in keyboard shortcuts to be translated - https://phabricator.wikimedia.org/T175449#3601001 (10Deskana) [16:37:56] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (f88cd00a6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376899 (https://phabricator.wikimedia.org/T175417) (owner: 10Esanders) [16:40:40] 10Citoid, 10VisualEditor, 10Services (watching), 10User-Ryasmeen: Update zotero translators - https://phabricator.wikimedia.org/T174992#3601042 (10Jdforrester-WMF) [16:43:38] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (f88cd00a6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376899 (https://phabricator.wikimedia.org/T175417) (owner: 10Esanders) [16:44:38] (03CR) 10DLynch: [C: 032] "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376899 (https://phabricator.wikimedia.org/T175417) (owner: 10Esanders) [16:44:49] That was it failing to have jsduck installed, which... [16:46:37] (03PS1) 10Esanders: Remove 'return' mapping as it is aliased to 'enter' below [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377506 [16:46:58] (03CR) 10Jforrester: "No hope for using this later?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377506 (owner: 10Esanders) [16:52:32] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (f88cd00a6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376899 (https://phabricator.wikimedia.org/T175417) (owner: 10Esanders) [16:59:58] James_F: the regular test builds pass, but the gate-and-submit ones fail because jsduck isn't installed. [17:00:13] Yeah. Eurgh. CI infrastructure issues suck. [17:02:40] (03PS1) 10Divec: ve.ce.BranchNode#splice: disconnect nodes fully [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377510 [17:04:44] (03PS2) 10Divec: ve.ce.BranchNode#splice: disconnect nodes fully [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377510 (https://phabricator.wikimedia.org/T175548) [17:07:49] 10VisualEditor, 10VisualEditor-ContentEditable, 10Patch-For-Review: Exception when unbulleting the final bullet of a list - https://phabricator.wikimedia.org/T175548#3601137 (10dchan) It looks like we were leaving zombie connections to nodes long ago torn down, which then reacted badly to TreeModifier causin... [17:11:50] (03CR) 10Esanders: "not while it's aliased to another value" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377506 (owner: 10Esanders) [17:33:10] (03CR) 10Jforrester: [C: 032] Remove 'return' mapping as it is aliased to 'enter' below [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377506 (owner: 10Esanders) [17:33:21] edsanders: You reviewing https://gerrit.wikimedia.org/r/377510 ? [17:33:31] yeah [17:33:56] Kk. [17:34:46] (03CR) 10Esanders: ve.ce.BranchNode#splice: disconnect nodes fully (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377510 (https://phabricator.wikimedia.org/T175548) (owner: 10Divec) [17:35:11] (03Merged) 10jenkins-bot: Remove 'return' mapping as it is aliased to 'enter' below [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377506 (owner: 10Esanders) [17:37:22] (03CR) 10jenkins-bot: Remove 'return' mapping as it is aliased to 'enter' below [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377506 (owner: 10Esanders) [17:51:07] (03CR) 10jenkins-bot: Update VE core submodule to master (f88cd00a6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376899 (https://phabricator.wikimedia.org/T175417) (owner: 10Esanders) [18:13:47] (03PS3) 10Divec: ve.ce.BranchNode#splice: disconnect nodes fully [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377510 (https://phabricator.wikimedia.org/T175548) [18:14:13] (03CR) 10Divec: "Done" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377510 (https://phabricator.wikimedia.org/T175548) (owner: 10Divec) [18:20:25] (03CR) 10Jforrester: [C: 031] ve.ce.BranchNode#splice: disconnect nodes fully [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377510 (https://phabricator.wikimedia.org/T175548) (owner: 10Divec) [18:21:56] (03CR) 10Esanders: [C: 032] ve.ce.BranchNode#splice: disconnect nodes fully [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377510 (https://phabricator.wikimedia.org/T175548) (owner: 10Divec) [18:24:26] (03Merged) 10jenkins-bot: ve.ce.BranchNode#splice: disconnect nodes fully [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377510 (https://phabricator.wikimedia.org/T175548) (owner: 10Divec) [18:25:21] 10VisualEditor, 10I18n, 10Patch-For-Review, 10RTL, and 2 others: VE table columns editing is destroyed in RTL - https://phabricator.wikimedia.org/T175417#3601475 (10Deskana) 05Open>03Resolved a:03DLynch Now I am become @DLynch, the un-destroyer of table editing. [18:25:34] 10VisualEditor, 10I18n, 10Patch-For-Review, 10User-Ryasmeen: Allow special keys in keyboard shortcuts to be translated - https://phabricator.wikimedia.org/T175449#3601480 (10Deskana) 05Open>03Resolved [18:26:17] (03PS1) 10Jforrester: Update VE core submodule to master (dafc7bbe5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377524 (https://phabricator.wikimedia.org/T175548) [18:27:22] (03CR) 10Deskana: [C: 032] Update VE core submodule to master (dafc7bbe5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377524 (https://phabricator.wikimedia.org/T175548) (owner: 10Jforrester) [18:29:04] (03CR) 10Jforrester: "Is this for T162761?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377237 (owner: 10Divec) [18:29:21] (03CR) 10jenkins-bot: ve.ce.BranchNode#splice: disconnect nodes fully [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377510 (https://phabricator.wikimedia.org/T175548) (owner: 10Divec) [18:34:44] (03Merged) 10jenkins-bot: Update VE core submodule to master (dafc7bbe5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377524 (https://phabricator.wikimedia.org/T175548) (owner: 10Jforrester) [18:37:03] 10VisualEditor, 10VisualEditor-ContentEditable, 10Patch-For-Review, 10User-Ryasmeen: Exception when unbulleting the final bullet of a list - https://phabricator.wikimedia.org/T175548#3601506 (10Deskana) 05Open>03Resolved Why revert when you can just fix it? :-) [18:47:00] from my limited test devices it looks like inputType support works on WebKit 603, but not 602 (both MobileSafari 10.0) [18:48:28] (03CR) 10jenkins-bot: Update VE core submodule to master (dafc7bbe5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377524 (https://phabricator.wikimedia.org/T175548) (owner: 10Jforrester) [18:50:05] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Google-Chrome, 10Patch-For-Review, 10User-Ryasmeen: "Undo" doesn't work from mouse (Chrome/Linux) - https://phabricator.wikimedia.org/T175634#3601617 (10Esanders) The patch will only work on the very latest versions of Chrome... [18:51:43] James_F: Kemayo do any of your devices have WebKit <= 602 http://www.whatsmyua.info/ ? [18:52:20] I've got 603.3.8 here, sorry. [18:52:39] edsanders: I'm fairly sure not, but I can dig around. [18:52:58] And 604.1 on my 'phone. [18:53:14] I want to check it's not just crossbrowsertesting failing on me, they only go up to 602, and none of them support inputType [18:53:34] edsanders: Well, Chrome reports as "…Chrome/60.0.3112.113 Safari/537.36" but I assume that's not what you mean. :-) [18:54:00] no, but check that this demo works: http://jsfiddle.net/6y0g0yap/2/ [18:54:16] works means when you click on 'Input' and type you are shown the event name underneath [18:54:28] and if you press ctrl+z it says "historyUndo" [18:54:48] Yup, and formatBold. [18:55:22] The text case transformations are just "insertText". [18:55:38] case transformations? [18:56:01] Make upper case / Make lower case / Capitalise [18:56:16] huh [18:56:33] well definitely doesn't work on my 601 device [18:56:44] so must be a 603 feature as I suspect [18:56:47] Might be new in the newer OS versions. [18:58:33] Looks like 603 shipped with Safari 10.1 [18:59:09] https://developer.apple.com/library/content/releasenotes/General/WhatsNewInSafari/Articles/Safari_10_1.html [18:59:13] yup "Input Events" [19:01:12] they actually got there 4 months before Chrome [19:03:37] this means you can now use "shake to undo" on VE mobile (assuming that's still a thing??) [19:18:08] 10VisualEditor, 10Regression: History tools no updating state in standalone demo - https://phabricator.wikimedia.org/T175734#3601761 (10Esanders) [19:18:21] (03PS1) 10Esanders: Fix typo in HistoryTool#onSurfaceChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377534 [19:18:26] (03PS1) 10Esanders: Follow-up Ifcc2e6f: Emit surfaceChange after tool setup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377535 (https://phabricator.wikimedia.org/T175734) [19:19:22] 10Citoid, 10VisualEditor: Citoid for DOI has problems with < > - https://phabricator.wikimedia.org/T175632#3598499 (10Deskana) Is this a problem with VisualEditor (e.g. not encoding the data it's passing to Citoid properly), or an issue with Citoid? [19:21:58] (03PS2) 10Jforrester: Follow-up 8e795e4331: Fix typo in HistoryTool#onSurfaceChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377534 (owner: 10Esanders) [19:22:09] (03CR) 10Jforrester: [C: 032] Follow-up 8e795e4331: Fix typo in HistoryTool#onSurfaceChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377534 (owner: 10Esanders) [19:22:26] (03PS2) 10Jforrester: Follow-up Ifcc2e6f: Emit surfaceChange after tool setup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377535 (https://phabricator.wikimedia.org/T175734) (owner: 10Esanders) [19:22:54] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Design: Provide a Preview panel that doesn't obscure the wikitext box and maybe the skin's sidebar (?) - https://phabricator.wikimedia.org/T155732#3601801 (10Deskana) [19:22:56] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Efficient correction of previewed errors in Wikitext edit mode - https://phabricator.wikimedia.org/T175453#3601803 (10Deskana) [19:23:00] 10VisualEditor, 10VisualEditor-EditingTools, 10Patch-For-Review, 10Regression: History tools not updating state in standalone demo - https://phabricator.wikimedia.org/T175734#3601805 (10Jdforrester-WMF) [19:23:54] 10VisualEditor, 10VisualEditor-EditingTools, 10Patch-For-Review, 10Regression: History tools not updating state in standalone demo - https://phabricator.wikimedia.org/T175734#3601812 (10Deskana) p:05Triage>03Normal a:03Esanders [19:24:57] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Collaboration-Team-Triage, 10Flow: Support VE source mode (NWE) in Flow - https://phabricator.wikimedia.org/T175366#3591445 (10Deskana) p:05Triage>03Low [19:25:54] (03Merged) 10jenkins-bot: Follow-up 8e795e4331: Fix typo in HistoryTool#onSurfaceChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377534 (owner: 10Esanders) [19:31:21] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Undo/redo should not (?) remain active when surface is blurred - https://phabricator.wikimedia.org/T67713#3601858 (10Esanders) 05Open>03declined [19:33:30] 10VisualEditor, 10User-Ryasmeen: Undoing the insertion of a template leaves almost all of the toolbar grayed out - https://phabricator.wikimedia.org/T85468#3601863 (10Esanders) 05Open>03Resolved a:03Esanders Probably fixed at some point in the last 2.75 years [19:38:50] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10Browser-Support-Firefox, 10User-Ryasmeen: VisualEditor: Link editor does not always open in Firefox with one click - https://phabricator.wikimedia.org/T113872#3601874 (10Deskana) 05Open>03Resolved a:03Deskana All of these problems appear to have been... [19:41:53] 10VisualEditor, 10VisualEditor-MediaWiki, 10Contributors-Analysis: Revise the Edit schema and its use - https://phabricator.wikimedia.org/T118063#3601883 (10Deskana) 05Open>03stalled We need to have a long hard think about analytics and metrics at some point. There's not much point doing that before ther... [19:42:12] (03CR) 10jenkins-bot: Follow-up 8e795e4331: Fix typo in HistoryTool#onSurfaceChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377534 (owner: 10Esanders) [19:46:06] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10User-Ryasmeen: Switching to custom tab in Advanced Settings while uploading an image throws error "dimensions is null" - https://phabricator.wikimedia.org/T119550#3601889 (10Deskana) 05Open>03Resolved a:03Deskana This was fixed at some point. [19:46:58] 10Citoid, 10VisualEditor: Citoid for DOI has problems with < > - https://phabricator.wikimedia.org/T175632#3598499 (10Mvolz) This is a dupe, but it's an issue with service. <> are stripped for security reasons. [19:48:55] 10Citoid, 10VisualEditor: Citoid for DOI has problems with < > - https://phabricator.wikimedia.org/T175632#3601902 (10Deskana) I guess that {T119494} is the task it's a duplicate of, so I'll merge this into that. [19:49:06] 10Citoid, 10VisualEditor, 10Security-Team: Citoid converts ignores <302::aid-ajmg13> - https://phabricator.wikimedia.org/T119494#1827796 (10Deskana) [19:49:09] 10Citoid, 10VisualEditor: Citoid for DOI has problems with < > - https://phabricator.wikimedia.org/T175632#3601908 (10Deskana) [19:54:19] 10VisualEditor, 10VisualEditor-DataModel, 10User-Ryasmeen: Error thrown when deleting a heading next to a table - https://phabricator.wikimedia.org/T140871#3601919 (10Deskana) 05Open>03Resolved I tried reproducing this and couldn't, but I'm not entirely certain I was doing it right. I will guess that thi... [19:57:11] 10VisualEditor, 10VisualEditor-DataModel, 10User-Ryasmeen: Error thrown when deleting a heading next to a table - https://phabricator.wikimedia.org/T140871#3601944 (10DLynch) 05Resolved>03Open Still happens, I'm afraid:{F9487572} [19:59:14] 10VisualEditor, 10VisualEditor-DataModel, 10User-Ryasmeen: Error thrown when deleting a heading next to a table - https://phabricator.wikimedia.org/T140871#3601976 (10Deskana) p:05High>03Normal @DLynch Thanks! I'll reprioritise then. [19:59:58] 10VisualEditor, 10VisualEditor-DataModel, 10User-Ryasmeen: Error thrown when deleting a heading next to a table - https://phabricator.wikimedia.org/T140871#3601994 (10DLynch) Yeah, it's a really specific situation required to trigger it, so lower priority seems fair. [20:00:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10Epic: VisualEditor: Implement some form of auto-save - https://phabricator.wikimedia.org/T57370#3601998 (10Esanders) >>! In T57370#3601942, @Esanders wrote: > > do our own memory management ...or use someone else's, e.g. https://github.com/monsur/jscache [20:14:56] 10Editing-team, 10MediaWiki-Page-editing, 10MediaWiki-Platform-Team: Do not overwrite edits when conflicting with self - https://phabricator.wikimedia.org/T175745#3602065 (10daniel) [20:18:57] 10VisualEditor, 10VisualEditor-MediaWiki, 10Front-end-Standards-Group, 10Epic: VisualEditor: Implement some form of auto-save - https://phabricator.wikimedia.org/T57370#3602085 (10Esanders) [20:19:17] 10Editing-team, 10MediaWiki-Page-editing, 10MediaWiki-Platform-Team, 10User-Daniel: Do not overwrite edits when conflicting with self - https://phabricator.wikimedia.org/T175745#3602086 (10daniel) [20:20:18] (03PS1) 10Tchanders: WIP VisualDiff: Show minimal moves in diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377554 (https://phabricator.wikimedia.org/T171451) [20:25:15] 10Editing-team, 10MediaWiki-Page-editing, 10MediaWiki-Platform-Team, 10User-Daniel: Do not overwrite edits when conflicting with self - https://phabricator.wikimedia.org/T175745#3602110 (10daniel) Historical justification, as per Brion on IRC: [22:20] So [22:20] Back in the day if you used... [20:39:35] 10Editing-team, 10MediaWiki-Page-editing, 10MediaWiki-Platform-Team, 10User-Daniel: Do not overwrite edits when conflicting with self - https://phabricator.wikimedia.org/T175745#3602181 (10Jdforrester-WMF) I'd be OK with changing this, but it'll likely have some fallout with editing tools relying on this b... [20:41:07] (03CR) 10Jforrester: [C: 032] Follow-up Ifcc2e6f: Emit surfaceChange after tool setup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377535 (https://phabricator.wikimedia.org/T175734) (owner: 10Esanders) [20:43:19] (03Merged) 10jenkins-bot: Follow-up Ifcc2e6f: Emit surfaceChange after tool setup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377535 (https://phabricator.wikimedia.org/T175734) (owner: 10Esanders) [20:45:37] (03CR) 10jenkins-bot: Follow-up Ifcc2e6f: Emit surfaceChange after tool setup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377535 (https://phabricator.wikimedia.org/T175734) (owner: 10Esanders) [20:53:47] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/377634 (owner: 10L10n-bot) [20:58:16] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377642 (owner: 10L10n-bot) [21:04:34] (03CR) 10Esanders: WIP VisualDiff: Show minimal moves in diff (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/377554 (https://phabricator.wikimedia.org/T171451) (owner: 10Tchanders) [22:49:23] 10VisualEditor, 10VisualEditor-MediaWiki, 10Contributors-Analysis: Revise the Edit schema and its use - https://phabricator.wikimedia.org/T118063#3602513 (10Neil_P._Quinn_WMF) >>! In T118063#3601883, @Deskana wrote: > We need to have a long hard think about analytics and metrics at some point. There's not mu... [22:51:36] 10VisualEditor, 10VisualEditor-MediaWiki, 10Contributors-Analysis: Revise the Edit schema and its use - https://phabricator.wikimedia.org/T118063#3602545 (10Deskana) >>! In T118063#3602513, @Neil_P._Quinn_WMF wrote: >>>! In T118063#3601883, @Deskana wrote: >> We need to have a long hard think about analytics... [22:59:37] 10VisualEditor, 10VisualEditor-MediaWiki, 10Contributors-Analysis: Revise the Edit schema and its use - https://phabricator.wikimedia.org/T118063#3602567 (10Neil_P._Quinn_WMF) >! In T118063#3601883, @Deskana wrote: > Hey, if you want to dive into this, I'd love to do it with you! But I assumed you were busy... [23:07:03] (03CR) 10Jforrester: Make save commands triggerable form anywhere (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377293 (owner: 10Esanders) [23:07:25] (03PS2) 10Jforrester: ArticleTarget: Make save commands triggerable from anywhere [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377293 (owner: 10Esanders) [23:09:42] (03CR) 10Jforrester: [C: 032] Change ArticleTargetLoader#requestPageData API to use options object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377285 (owner: 10Esanders) [23:13:27] (03CR) 10jerkins-bot: [V: 04-1] ArticleTarget: Make save commands triggerable from anywhere [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377293 (owner: 10Esanders) [23:15:45] (03CR) 10jerkins-bot: [V: 04-1] Change ArticleTargetLoader#requestPageData API to use options object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377285 (owner: 10Esanders) [23:15:49] (03CR) 10jerkins-bot: [V: 04-1] Remove pageName/revision from ArticleTarget constructor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377286 (owner: 10Esanders) [23:15:51] (03CR) 10jerkins-bot: [V: 04-1] Use lowerCamelCase for javascript var oldId [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377287 (owner: 10Esanders) [23:23:37] (03CR) 10Jforrester: [C: 032] Change ArticleTargetLoader#requestPageData API to use options object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377285 (owner: 10Esanders) [23:29:24] (03CR) 10jerkins-bot: [V: 04-1] Change ArticleTargetLoader#requestPageData API to use options object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377285 (owner: 10Esanders) [23:29:26] (03CR) 10jerkins-bot: [V: 04-1] Remove pageName/revision from ArticleTarget constructor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377286 (owner: 10Esanders) [23:29:28] (03CR) 10jerkins-bot: [V: 04-1] Use lowerCamelCase for javascript var oldId [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377287 (owner: 10Esanders) [23:42:07] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror: Selecting syntax-highlighted text in the 2017 source editor covers it completely when using Firefox - https://phabricator.wikimedia.org/T175223#3602712 (10Niharika) [23:42:38] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror: Selecting syntax-highlighted text in the 2017 source editor covers it completely when using Firefox - https://phabricator.wikimedia.org/T175223#3602715 (10kaldari) [23:43:22] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror: Selecting syntax-highlighted text in the 2017 source editor covers it completely when using Firefox - https://phabricator.wikimedia.org/T175223#3587089 (10DannyH) p:05Triage>03Normal