[00:16:44] (03PS2) 10Jforrester: CollabTarget: Disable submit button when input is invalid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378019 (owner: 10Esanders) [00:16:46] (03CR) 10Jforrester: [C: 032] CollabTarget: Disable submit button when input is invalid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378019 (owner: 10Esanders) [00:17:35] (03CR) 10Jforrester: [C: 031] "Ping." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377301 (https://phabricator.wikimedia.org/T157755) (owner: 10DLynch) [00:22:13] (03Merged) 10jenkins-bot: CollabTarget: Disable submit button when input is invalid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378019 (owner: 10Esanders) [00:24:14] (03CR) 10jenkins-bot: CollabTarget: Disable submit button when input is invalid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378019 (owner: 10Esanders) [00:49:05] 10VisualEditor, 10VisualEditor-ContentEditable, 10Collaboration-Team-Triage, 10StructuredDiscussions, 10Regression: [testwiki-wmf.18-regression] Editing Flow board description issues - https://phabricator.wikimedia.org/T175967#3609367 (10SBisson) Is it the same as {T166634}? [00:53:40] 10VisualEditor, 10VisualEditor-ContentEditable, 10Collaboration-Team-Triage, 10StructuredDiscussions, 10Regression: [testwiki-wmf.18-regression] Editing Flow board description issues - https://phabricator.wikimedia.org/T175967#3609367 (10Jdforrester-WMF) Sounds plausible. [09:01:47] 10VisualEditor, 10ContentTranslation, 10Contributors-Team, 10Design, 10WorkType-NewFunctionality: Content Translation feature parity checklist post VisualEditor integration - https://phabricator.wikimedia.org/T150652#3609888 (10santhosh) >>! In T150652#3607497, @Esanders wrote: >> Presently you can add a... [09:09:23] 10VisualEditor, 10ContentTranslation, 10Contributors-Team, 10Design, 10WorkType-NewFunctionality: Content Translation feature parity checklist post VisualEditor integration - https://phabricator.wikimedia.org/T150652#3609895 (10Deskana) [09:10:08] 10VisualEditor, 10ContentTranslation, 10Contributors-Team, 10Design, 10WorkType-NewFunctionality: Content Translation feature parity checklist post VisualEditor integration - https://phabricator.wikimedia.org/T150652#2792172 (10Deskana) >>! In T150652#3609888, @santhosh wrote: > I don't see this issue e... [09:14:47] 10VisualEditor, 10VisualEditor-VisualDiffs, 10MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), 10Patch-For-Review, 10User-Ryasmeen: Stop showing excessive moves when moving a paragraph across the page - https://phabricator.wikimedia.org/T171451#3609913 (10Deskana) 05Open>03Resolved [09:24:37] 10VisualEditor: When inserting media, dialog should be titled “Insert Media” - https://phabricator.wikimedia.org/T175960#3609918 (10Deskana) 05Open>03stalled It looks like the reason this dialogue is titled this way is because it's the same dialogue that is used for doing actual altering of media settings.... [09:48:48] 10VisualEditor: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert" - https://phabricator.wikimedia.org/T175943#3609981 (10Deskana) p:05Triage>03High This is not in production yet, fortunately. [10:55:48] 10VisualEditor: [Regression wmf.18] Media Settings dialog is opening with a solid gray disabled selection in a slug - https://phabricator.wikimedia.org/T175939#3610056 (10Deskana) p:05Triage>03High [11:38:07] 10VisualEditor: Switching between Visual Editor and Wikitexteditor may result in loose of responsive-Keyword - https://phabricator.wikimedia.org/T175989#3610194 (10MichaelSchoenitzer_WMDE) [12:39:36] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Media, 10Browser-Support-Firefox, and 3 others: Editing captions in Firefox is so unpredictable as to be useless - https://phabricator.wikimedia.org/T174774#3610287 (10Deskana) 05Resolved>03Open Well, this appears to still be a problem, so... [13:16:24] (03CR) 10Esanders: [C: 032] "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361921 (https://phabricator.wikimedia.org/T49411) (owner: 10C. Scott Ananian) [13:21:49] 10Citoid, 10VisualEditor, 10Operations, 10Services (watching), 10User-mobrovac: Wiley requests for DOI and some other publishers don't work in production - https://phabricator.wikimedia.org/T165105#3610355 (10Samwalton9) Wiley are checking in to ask whether the problem is now resolved. Can anyone confirm? [13:24:14] (03CR) 10jerkins-bot: [V: 04-1] Inspectors for editing LanguageConverter markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361921 (https://phabricator.wikimedia.org/T49411) (owner: 10C. Scott Ananian) [13:28:19] 10Citoid, 10VisualEditor, 10Operations, 10Services (watching), 10User-mobrovac: Wiley requests for DOI and some other publishers don't work in production - https://phabricator.wikimedia.org/T165105#3610359 (10Kettner2) Hi all, I can confirm that the problem is solved, just checked for a DOI of a Wiley j... [13:41:00] 10Citoid, 10VisualEditor, 10Operations, 10Services (watching), 10User-mobrovac: Wiley requests for DOI and some other publishers don't work in production - https://phabricator.wikimedia.org/T165105#3610375 (10akosiaris) I don't think it has, but I 'd like a confirmation from @Mvolz. The stuff I posted in... [13:53:32] 10VisualEditor, 10ContentTranslation, 10Contributors-Team, 10Design, 10WorkType-NewFunctionality: Content Translation feature parity checklist post VisualEditor integration - https://phabricator.wikimedia.org/T150652#3610390 (10Esanders) [14:47:06] (03PS18) 10C. Scott Ananian: Inspectors for editing LanguageConverter markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361921 (https://phabricator.wikimedia.org/T49411) [14:47:18] (03PS3) 10C. Scott Ananian: Prevent language converter markup from spontaneously disappearing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378044 [14:49:27] (03PS19) 10C. Scott Ananian: Inspectors for editing LanguageConverter markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361921 (https://phabricator.wikimedia.org/T49411) [14:59:50] (03PS1) 10Esanders: Remove unused polyfills from EasyDeflate lib [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378248 [15:01:48] RoanKattouw: I always avoid jQuery when working on secondary documents. [15:01:59] (03CR) 10C. Scott Ananian: "ed -- this is a sort of unusual way to suppress the "parameter not used" warning from eslint w/o making jsduck disassociate the comment fr" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361921 (https://phabricator.wikimedia.org/T49411) (owner: 10C. Scott Ananian) [15:13:51] (03CR) 10Esanders: "I assumed jsduck error was a false negative because it's been failing for no reason recently" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361921 (https://phabricator.wikimedia.org/T49411) (owner: 10C. Scott Ananian) [16:00:42] (03CR) 10C. Scott Ananian: "> I assumed jsduck error was a false negative because it's been" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361921 (https://phabricator.wikimedia.org/T49411) (owner: 10C. Scott Ananian) [16:18:37] (03CR) 10Jforrester: [C: 032] Remove unused polyfills from EasyDeflate lib [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378248 (owner: 10Esanders) [16:18:52] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Always show the checkbox when the boolean type is added in the template insert dialog - https://phabricator.wikimedia.org/T176009#3610926 (10Whatamidoing-WMF) [16:24:24] (03Merged) 10jenkins-bot: Remove unused polyfills from EasyDeflate lib [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378248 (owner: 10Esanders) [16:24:43] (03PS20) 10Jforrester: Inspectors for editing LanguageConverter markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361921 (https://phabricator.wikimedia.org/T49411) (owner: 10C. Scott Ananian) [16:26:01] (03CR) 10Jforrester: [C: 032] "PS20: More canonical, less messy way to make eslint and jsduck happy. +2 per Ed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361921 (https://phabricator.wikimedia.org/T49411) (owner: 10C. Scott Ananian) [16:26:29] (03CR) 10jenkins-bot: Remove unused polyfills from EasyDeflate lib [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378248 (owner: 10Esanders) [16:26:50] (03CR) 10Jforrester: [C: 031] Prevent language converter markup from spontaneously disappearing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378044 (owner: 10C. Scott Ananian) [16:31:39] (03Merged) 10jenkins-bot: Inspectors for editing LanguageConverter markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361921 (https://phabricator.wikimedia.org/T49411) (owner: 10C. Scott Ananian) [16:33:37] (03CR) 10jenkins-bot: Inspectors for editing LanguageConverter markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361921 (https://phabricator.wikimedia.org/T49411) (owner: 10C. Scott Ananian) [16:36:29] 10VisualEditor, 10VisualEditor-ContentLanguage, 10Chinese-Sites, 10Epic, and 2 others: VisualEditor: Support "Language conversion blocks" for multi-script wikis - https://phabricator.wikimedia.org/T49411#3610973 (10Jdforrester-WMF) [16:36:34] 10VisualEditor, 10VisualEditor-ContentLanguage, 10MediaWiki-Language-converter, 10Parsoid, and 4 others: Decide on a strategy for supporting language variants in VisualEditor (or decide to give up) - https://phabricator.wikimedia.org/T95674#3610970 (10Jdforrester-WMF) 05Open>03Resolved This was decided... [17:13:15] 10VisualEditor, 10VisualEditor-ContentEditable, 10Collaboration-Team-Triage, 10StructuredDiscussions, 10Regression: [testwiki-wmf.18-regression] Editing Flow board description issues - https://phabricator.wikimedia.org/T175967#3611046 (10Etonkovidova) {T166634} is milder - there were only Console errors,... [17:42:44] 10Cite, 10MediaWiki-Internationalization, 10Parsoid, 10I18n, and 2 others: parser tags such as , , etc. cannot be localized - https://phabricator.wikimedia.org/T30980#329856 (10jeblad) It is a really bad idea to translate tag functions. Actually I believe it is a really bad idea to tr... [17:44:15] 10Cite, 10TCB-Team: Find a good name for new attribute in ref tag - https://phabricator.wikimedia.org/T171581#3611107 (10jeblad) [17:49:53] 10Cite, 10MediaWiki-Internationalization, 10Parsoid, 10I18n, and 2 others: parser tags such as , , etc. cannot be localized - https://phabricator.wikimedia.org/T30980#3611111 (10IKhitron) >>! In T30980#3611103, @jeblad wrote: > It is a really bad idea to translate tag functions. > If... [17:57:36] 10Cite, 10TCB-Team: Implement "extends"-attribute for ref-tag - https://phabricator.wikimedia.org/T151301#3611115 (10jeblad) As a note to T151301#3291681; the attribute "name" has //usually// no implication on uniqueness, but "id" has. To assume it is unique within a "group" seems consistent to me. If "name" s... [17:57:51] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10WikiEditor: Investigate ways to encourage use of the Preview button in the wikitext editors - https://phabricator.wikimedia.org/T170175#3611116 (10Samat) Is it possible to implement an (probably optional) preview feature (ideally live, but a manu... [18:55:59] 10VisualEditor, 10VisualEditor-Tables, 10MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), 10Patch-For-Review, and 3 others: [Regression pre-wmf.8] Table context menu is appearing over table cell menu - https://phabricator.wikimedia.org/T169389#3611237 (10Ryasmeen) Tested and re-verified. [19:08:26] edsanders: Oh right, I didn't realize it was a secondary doc [19:08:51] when is it not :) [19:44:41] 10VisualEditor: When inserting media, dialog should be titled “Insert Media” - https://phabricator.wikimedia.org/T175960#3611267 (10Volker_E) I agree that renaming in general would just shift the confusion to another place. From my point of view, it should alter the title depending on where the click was initiat... [20:11:30] 10VisualEditor: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert" - https://phabricator.wikimedia.org/T175943#3611285 (10Ryasmeen) Noticed the same error in couple of other scenarios in Firefox, they all might be coming from the same source, so listing here for now... [20:44:58] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), 10User-Ryasmeen, and 3 others: Cannot add the same Math/Chemical formula that has been cleared from the context menu before. - https://phabricator.wikimedia.org/T172586#3611319 (10Ryasmeen) [21:13:09] 10VisualEditor, 10Community-Tech, 10MediaWiki-extensions-ArticleCreationWorkflow, 10MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), 10User-Ryasmeen: ACW should intercept page creation via VisualEditor - https://phabricator.wikimedia.org/T173605#3611367 (10DannyH) [21:15:57] 10VisualEditor, 10Community-Tech, 10MediaWiki-extensions-ArticleCreationWorkflow: VisualEditor prevents AlternateEdit hook from working - https://phabricator.wikimedia.org/T175292#3611391 (10DannyH) [21:45:29] (03PS1) 10DLynch: Enable preload in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378343 (https://phabricator.wikimedia.org/T51622) [21:47:26] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10MediaWiki-Page-editing, 10Patch-For-Review: Add support for (the equivalent of?) editintro and preload - https://phabricator.wikimedia.org/T51622#555851 (10DLynch) That patch is very much the "better than nothing" version James sugg... [21:48:33] (03CR) 10jerkins-bot: [V: 04-1] Enable preload in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378343 (https://phabricator.wikimedia.org/T51622) (owner: 10DLynch) [21:49:02] Kemayo: Showy even so. :-) [21:54:44] (03PS2) 10DLynch: Enable preload in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378343 (https://phabricator.wikimedia.org/T51622) [21:55:44] I never remember that `grunt lint` doesn't test any of the php code style stuff. [22:00:31] (03CR) 10jerkins-bot: [V: 04-1] Enable preload in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378343 (https://phabricator.wikimedia.org/T51622) (owner: 10DLynch) [22:01:57] Kemayo: Yup, `npm it; composer test` is my mantra. :-) [22:02:03] Ugh, and I have to write API documentation. Lame. [22:02:31] We could put a shell exec in Gruntfile.js to run composer test, I suppose… We're not thinking of running those on different boxes any more. [22:02:34] (Unlike 2012.) [22:04:41] ...huh. One of those test failures was npm finding the wrong sha for eslint. That's a bit concerning. [22:06:20] Hmm. Poke it again and it'll probably work. If it continues, we can file a task. [22:08:56] (03PS3) 10DLynch: Enable preload in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378343 (https://phabricator.wikimedia.org/T51622) [22:14:38] (03CR) 10jerkins-bot: [V: 04-1] Enable preload in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378343 (https://phabricator.wikimedia.org/T51622) (owner: 10DLynch) [22:17:58] (03PS4) 10DLynch: Enable preload in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378343 (https://phabricator.wikimedia.org/T51622) [22:19:00] James_F: It went away on the second run, fortunately. [22:19:18] Huzzah. [22:19:38] They just replaced all the CI boxes with new builds based on a new OS version. [22:20:07] This has revealed a bunch of config which wasn't puppetised but just done as local hacks, which consequently didn't show up on the new stuff. :-) [22:26:04] 10VisualEditor: Unsuccessful move attempts trigger VisualEditor - https://phabricator.wikimedia.org/T176022#3611469 (10kaldari) [23:08:49] OK so after hours of debugging cxserver I finally have a clue for why link adaptation doesn't work [23:09:16] I found code that tries to call preq.get( { method: 'post', uri: '...', 'query': { .... }, 'body': {} } ); [23:09:36] Calling the get() function with { method: 'post' } is probably a bad idea, and apparently the 'body' is supposed to be a string as well