[00:00:05] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Trying to use `veaction=edit` on a talk page puts the whole page code in the edit window - https://phabricator.wikimedia.org/T176099#3613525 (10jrbs) [04:48:13] 10VisualEditor: ULS not working properly for Kannada in Visual editor - https://phabricator.wikimedia.org/T176104#3613665 (10Pavanaja) [07:36:50] 10VisualEditor, 10MediaWiki-extensions-UniversalLanguageSelector: ULS not working properly for Kannada in Visual editor - https://phabricator.wikimedia.org/T176104#3613808 (10Anooprao) [08:49:44] 10VisualEditor: VisualEditor stuck during the loading process - https://phabricator.wikimedia.org/T176049#3614100 (10Aklapper) a:05Jdforrester-WMF>03None [08:50:01] 10VisualEditor: VisualEditor stuck during the loading process - https://phabricator.wikimedia.org/T176049#3612122 (10Aklapper) Alright. In that case, please do not assign tasks without consent. Thanks :) [09:00:19] 10VisualEditor: Trying to force the visual editor to load on a user talk page whilst logged out causes the welcome dialogue to have no buttons - https://phabricator.wikimedia.org/T176125#3614109 (10Deskana) [09:00:42] 10VisualEditor: Trying to force the visual editor to load on a talk page whilst logged out causes the welcome dialogue to have no buttons - https://phabricator.wikimedia.org/T176125#3614121 (10Deskana) [09:03:17] 10VisualEditor: Trying to force the visual editor to load on a talk page whilst logged out causes the welcome dialogue to have no buttons - https://phabricator.wikimedia.org/T176125#3614129 (10Deskana) [09:03:36] 10VisualEditor: Trying to force the visual editor to load on a talk page whilst logged out causes the welcome dialogue to have no buttons - https://phabricator.wikimedia.org/T176125#3614109 (10Deskana) p:05Triage>03Low The edgiest of edge cases. [09:03:43] hmm. it seems the edit source pages get a reflow again for WikiEditor... I fixed that at one point.. did anything recently change to how the toolbar is loaded ? [09:03:44] 10VisualEditor: Trying to force the visual editor to load on a talk page whilst logged out causes the welcome dialogue to have no buttons - https://phabricator.wikimedia.org/T176125#3614132 (10Deskana) [09:04:50] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Trying to use `veaction=edit` on a talk page puts the whole page code in the edit window - https://phabricator.wikimedia.org/T176099#3614135 (10Deskana) p:05Triage>03Low This only happens if you force the visual editor to do something it shouldn'... [09:05:27] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Trying to use `veaction=edit` on a talk page loads the source editor and puts the page's HTML in the edit window - https://phabricator.wikimedia.org/T176099#3613525 (10Deskana) [09:06:37] hmm, .client-js .wikiEditor-oldToolbar + #wpTextbox1 { margin-top: 33px [09:06:40] } [09:09:52] ah, that depend on the oldtoolbar being enabled of course.. [09:09:53] sight [09:14:05] right, now i remember, we have no unique class for wikieditor in the generated html, unless the old toolbar is enabled [09:14:09] we should really fix that... [09:15:55] 10WikiEditor, 10MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)): Editing screen shouldn't re-shape or move after it is displayed - https://phabricator.wikimedia.org/T125843#3614168 (10TheDJ) 05Resolved>03Open That patch only works if the old toolbar is enabled as well.. Since we are removing that so... [10:02:56] 10VisualEditor: VisualEditor stuck during the loading process - https://phabricator.wikimedia.org/T176049#3614294 (10Deskana) 05Open>03Invalid >>! In T176049#3612299, @Samat wrote: > @Aklapper actually no, he didn't. I assigned to James because he is the product manager of the VisualEditor team, and he will... [10:04:39] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid: Don't display interwiki links with external icon in VE - https://phabricator.wikimedia.org/T103636#3614315 (10Deskana) @ssastry Is this something your team could take a quick look at to gauge the difficulty of... [10:17:35] 10VisualEditor: JavaScript freeze/loop when editing or adding references - https://phabricator.wikimedia.org/T176066#3614330 (10Deskana) p:05Triage>03Unbreak! This seems to be a performance problem somehow related to large articles on the German Wikipedia. I tried to reproduce with some large articles, and s... [11:28:14] 10VisualEditor, 10MediaWiki-extensions-UniversalLanguageSelector: ULS not working properly for Kannada in Visual editor - https://phabricator.wikimedia.org/T176104#3614429 (10Anooprao) [11:31:11] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/378677 (owner: 10L10n-bot) [11:45:00] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-General-or-Unknown: Unknown problem with 2017 wikitext editor - https://phabricator.wikimedia.org/T176073#3612722 (10Deskana) @Bencemac I tried editing a few different sections on that page (https://hu.wikipedia.org/wiki/WikipĂ©dia:Botga... [11:45:28] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-General-or-Unknown: Unknown problem with 2017 wikitext editor - https://phabricator.wikimedia.org/T176073#3614469 (10Deskana) p:05Triage>03Normal [11:47:54] 10VisualEditor: JavaScript freeze/loop when editing or adding references - https://phabricator.wikimedia.org/T176066#3612534 (10Esanders) The problem is they have started using the `` tag again, which is a good thing because it means the ref list updates dynamically. Unfortunately the large wikis hav... [11:52:21] 10VisualEditor, 10VisualEditor-DataModel, 10MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), 10User-Ryasmeen: Insertions with references too easily cause rebase conflicts - https://phabricator.wikimedia.org/T175059#3581388 (10Esanders) I think also TreeModifier could be to blame, emitting mor... [12:12:41] 10VisualEditor, 10Patch-For-Review: JavaScript freeze/loop when editing or adding references - https://phabricator.wikimedia.org/T176066#3614526 (10Esanders) The above patch fixes the symptom if not the cause. Pseudo-tested on de.wiki by pasting the following monkey patch in the console: ``` ve.ce.MWReferenc... [12:25:04] 10VisualEditor, 10Regression: VisualEditor: Image caption not shown direct after inserting the image, although it saves correctly - https://phabricator.wikimedia.org/T176078#3614544 (10Deskana) [12:31:49] 10VisualEditor, 10Regression: VisualEditor: Image caption not shown direct after inserting the image, although it saves correctly - https://phabricator.wikimedia.org/T176078#3614555 (10Deskana) p:05Triage>03Normal This is a visual glitch during editing; the page looks correct after saving. Even so, we shou... [13:45:19] 10VisualEditor, 10Patch-For-Review: JavaScript freeze/loop when editing or adding references - https://phabricator.wikimedia.org/T176066#3614741 (10Esanders) [14:06:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid: Don't display interwiki links with external icon in VE - https://phabricator.wikimedia.org/T103636#3614767 (10ssastry) >>! In T103636#3614315, @Deskana wrote: > @ssastry Is this something your team could take... [14:23:00] James_F: can you give DavidC +2 rights on Cite [14:23:17] and anyone else in the team who doesn't [14:34:04] 10VisualEditor, 10Patch-For-Review: JavaScript freeze/loop when editing or adding references - https://phabricator.wikimedia.org/T176066#3614852 (10Esanders) I think TreeModifier could be to blame, emitting more events than we used to and causing the list to rebuild many more times. Pinging @dchan . [14:38:29] edsanders: Everyone should have it automatically through LDAP. [14:39:05] edsanders: Which David? C.? [14:39:16] "DavidC" [14:39:21] Right-o. [14:39:22] ^^ [14:39:27] :) [14:42:07] edsanders: Hmm. He was added to the LDAP group in 2014 according to Phabricator. [14:42:18] hmm - maybe it was just that patch [14:42:36] something to do with jenkins bot? [14:44:09] Oh, no, because David uses a personal e-mail address and didn't reply to Opsen requests, they removed it again in January. [14:46:17] Filed https://phabricator.wikimedia.org/T176142. [14:54:15] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: 2017 wikitext editor doesn't load if I create a new page with preload worksheet - https://phabricator.wikimedia.org/T174487#3614906 (10DLynch) I have https://gerrit.wikimedia.org/r/378343 in T51622 which will make this work. Could probably close this... [15:07:42] (03PS1) 10DLynch: DesktopArticleTarget: Support preloadtitle in source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378726 (https://phabricator.wikimedia.org/T51622) [15:09:09] edsanders: Kemayo is waiting for you to review https://gerrit.wikimedia.org/r/#/c/377301/ https://gerrit.wikimedia.org/r/#/c/378726/ https://gerrit.wikimedia.org/r/#/c/378343/ you know. :-) [15:09:55] Technically I hadn't even added him to that last one yet. But I'll take it. [15:10:17] * James_F grins. [15:12:55] (03CR) 10Esanders: [C: 04-1] DesktopArticleTarget: Support preloadtitle in source mode (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378726 (https://phabricator.wikimedia.org/T51622) (owner: 10DLynch) [15:14:44] (03PS2) 10DLynch: DesktopArticleTarget: Support preloadtitle in source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378726 (https://phabricator.wikimedia.org/T51622) [15:18:35] (03PS3) 10DLynch: DesktopArticleTarget: Support preloadtitle in source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378726 (https://phabricator.wikimedia.org/T51622) [15:20:48] Actually, possible-relevant question: should having a preloadtitle set count for enabling the save button? [15:21:20] With no other content? [15:21:23] Yup. [15:21:29] Yeah, probably? Deskana's call. :-) [15:21:46] Well, that's the current state of the patch, so: 👍 [15:27:43] (03CR) 10Esanders: [C: 032] DesktopArticleTarget: Support preloadtitle in source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378726 (https://phabricator.wikimedia.org/T51622) (owner: 10DLynch) [15:33:21] (03PS1) 10Jforrester: Follow-up a45d6fc3: Add 'tay' language to build to unbreak the repo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/378733 [15:34:06] (03CR) 10Jforrester: [C: 032] "Self-merging to unbreak." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/378733 (owner: 10Jforrester) [15:34:49] edsanders: Also, who does MatmaRex need to kill to get you to upgrade your C+1 on https://gerrit.wikimedia.org/r/#/c/376262/ to a +2? :-) [15:36:02] Roan [15:39:50] (03Merged) 10jenkins-bot: DesktopArticleTarget: Support preloadtitle in source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378726 (https://phabricator.wikimedia.org/T51622) (owner: 10DLynch) [15:40:02] Hmm, OK. [15:40:37] (03Merged) 10jenkins-bot: Follow-up a45d6fc3: Add 'tay' language to build to unbreak the repo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/378733 (owner: 10Jforrester) [15:58:01] Kemayo: It seems unlikely that anyone would actually want to save something that's been preloaded and not add anything to it... but it's not actually a no-op, so it does make sense to let the user save. [15:59:10] Deskana: I think it'll make more sense if the preload patch gets merged, too. Then preload + preloadparams + preloadtitle might result in a legitimately complete page. Just preloadtitle is a bit weird, because all it does is add a new section-heading with no content. [16:03:22] 10VisualEditor: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert" - https://phabricator.wikimedia.org/T175943#3615153 (10Ryasmeen) >>! In T175943#3609981, @Deskana wrote: > This is not in production yet, fortunately. Now it is :) [16:40:41] 10VisualEditor: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert" - https://phabricator.wikimedia.org/T175943#3608681 (10DLynch) I do see this in production, but not locally or in beta. Maybe we've fixed it accidentally somewhere else. [16:41:50] 10VisualEditor: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert" - https://phabricator.wikimedia.org/T175943#3615283 (10Deskana) @Ryasmeen I can't reproduce this in production in Firefox. # Go to a random article, e.g. https://en.wikipedia.org/wiki/Bo_people_(Chi... [16:45:22] 10VisualEditor: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert" - https://phabricator.wikimedia.org/T175943#3615297 (10DLynch) Oh, also, in production that `node is null` error happens any time you hit enter, not just linked to the image-add. [16:46:55] 10VisualEditor: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert" - https://phabricator.wikimedia.org/T175943#3615302 (10Ryasmeen) Hmm, does not work for me on that page, getting same error. Mine is Firefox 55.0.3. [16:49:37] 10VisualEditor: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert" - https://phabricator.wikimedia.org/T175943#3615311 (10Deskana) I just made this edit using Firefox 55.0.3: https://en.wikipedia.org/w/index.php?title=User:Deskana_(WMF)/sandbox&diff=801256835&oldid=... [16:56:52] (03CR) 10jenkins-bot: DesktopArticleTarget: Support preloadtitle in source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378726 (https://phabricator.wikimedia.org/T51622) (owner: 10DLynch) [16:58:04] (03CR) 10jenkins-bot: Follow-up a45d6fc3: Add 'tay' language to build to unbreak the repo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/378733 (owner: 10Jforrester) [17:31:18] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid: Don't display interwiki links with external icon in VE - https://phabricator.wikimedia.org/T103636#3615538 (10ssastry) [17:32:16] 10VisualEditor: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert" - https://phabricator.wikimedia.org/T175943#3615541 (10Deskana) p:05High>03Unbreak! Well, two other people can reproduce it, so marking as highest. [17:34:02] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Media, 10Browser-Support-Firefox, and 3 others: Editing captions in Firefox is so unpredictable as to be useless - https://phabricator.wikimedia.org/T174774#3615545 (10Deskana) p:05Normal>03High [18:22:18] Deskana: Were any of those people reproducing T175943 not on production? I can't make it happen on beta or locally, which makes it harder to work out if we've actually fixed it somewhere. [18:22:20] T175943: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert" - https://phabricator.wikimedia.org/T175943 [18:26:56] 10VisualEditor, 10VisualEditor-ContentLanguage, 10MediaWiki-Language-converter, 10Parsoid, and 4 others: Decide on a strategy for supporting language variants in VisualEditor (or decide to give up) - https://phabricator.wikimedia.org/T95674#3615758 (10Jdforrester-WMF) [18:27:02] 10VisualEditor, 10VisualEditor-ContentLanguage, 10MediaWiki-Language-converter, 10Parsoid, and 4 others: Decide on a strategy for supporting language variants in VisualEditor (or decide to give up) - https://phabricator.wikimedia.org/T95674#1197364 (10Jdforrester-WMF) [18:36:48] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Media, 10Browser-Support-Firefox, and 3 others: Editing captions in Firefox is so unpredictable as to be useless - https://phabricator.wikimedia.org/T174774#3615768 (10Arlolra) >>! In T174774#3608819, @Ryasmeen wrote: > it happened when I tried... [19:10:11] 10Cite: Migrate citation IDs to HTML5 encoding - https://phabricator.wikimedia.org/T176170#3615896 (10cscott) [19:10:33] 10Cite: Migrate citation IDs to HTML5 encoding - https://phabricator.wikimedia.org/T176170#3615912 (10cscott) [19:11:04] 10Cite: Migrate citation IDs to HTML5 encoding - https://phabricator.wikimedia.org/T176170#3615896 (10cscott) [19:31:34] 10Cite, 10Patch-For-Review: Migrate citation IDs to HTML5 encoding - https://phabricator.wikimedia.org/T176170#3616009 (10cscott) a:03cscott [19:45:39] (03CR) 10Esanders: [C: 032] Enable preload in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378343 (https://phabricator.wikimedia.org/T51622) (owner: 10DLynch) [19:53:15] edsanders: Could you take a look at https://gerrit.wikimedia.org/r/#/c/378666/2/modules/ve-cx/ui/ve.ui.CXTranslationUnitContextItem.js ? (In particular my comment on that file, but the rest of the patch too if you're interested) [19:54:16] I think the problem is a few things are stored above the target in CX [19:54:25] although perhaps not in this case [19:55:42] In this case it's a child of the target and a sibling of the surface [19:55:48] But we can't get from the surface up to the target right now [19:56:39] the thinking there being that both surfaces need to know about this because it's a mapping between source and target text? [19:59:18] (03Merged) 10jenkins-bot: Enable preload in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378343 (https://phabricator.wikimedia.org/T51622) (owner: 10DLynch) [20:02:29] I guess it would be better if the surfaces knew about the translation object, but then they'd need to be re-subclassed [20:04:09] (03CR) 10jenkins-bot: Enable preload in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378343 (https://phabricator.wikimedia.org/T51622) (owner: 10DLynch) [20:17:58] (03PS1) 10Esanders: Use consistent comment style in PHP files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378788 [20:37:12] 10Cite, 10Patch-For-Review: Migrate citation IDs to HTML5 encoding - https://phabricator.wikimedia.org/T176170#3616178 (10cscott) Current patch mostly fixes this but if you set `$wgFragmentMode = ['html5']`.... ``` $ echo '[[#cite_note-{&#... [20:46:04] (03CR) 10DLynch: [C: 032] Use consistent comment style in PHP files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378788 (owner: 10Esanders) [20:57:45] (03Merged) 10jenkins-bot: Use consistent comment style in PHP files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378788 (owner: 10Esanders) [21:09:13] Kemayo: That was you and Rummana. :-p [21:09:39] I don't know why I can't reproduce it but you and Rummana can. [21:12:05] 10VisualEditor: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert" - https://phabricator.wikimedia.org/T175943#3616297 (10DLynch) @Ryasmeen: Could you check and let me know whether this happens to you on the beta cluster currently? I'm trying to work out whether I'm... [21:12:13] It's a weird one. [21:13:45] (03CR) 10jenkins-bot: Use consistent comment style in PHP files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378788 (owner: 10Esanders) [21:18:57] Kemayo: Well, I can reproduce it now. Now I have to figure out what I was doing that was different. [21:19:16] Can you reproduce it on the beta cluster, too? [21:19:36] Let me see. [21:20:41] Kemayo: Yes. [21:20:53] Drat, okay. [21:21:10] I have a theory why I couldn't reproduce it before... [21:21:20] It could be bunnies! [21:22:05] No one? [21:22:59] Kemayo: If immediately after opening VE, you click somewhere, and then try to insert the image, it will do it. If you press enter at any point before trying to insert the image, it will do it just fine. [21:23:17] No, I said that wrong. [21:23:23] * Deskana sighs [21:23:31] If immediately after opening VE, you click somewhere, and then try to insert the image, it will do it. If you press enter at any point before trying to insert the image, it won't insert the image. [21:23:49] Interestingly, this is not how it worked for me. [21:24:27] Hah. [21:24:28] Well. [21:25:11] I'm going to double-check this to make sure I'm not crazy. [21:25:52] Deskana: Do you get `TypeError: node is null` any time you hit enter? [21:26:04] Kemayo: Yep. [21:28:14] 10VisualEditor: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert" - https://phabricator.wikimedia.org/T175943#3616332 (10Deskana) I can reproduce it in both beta and production, and I figured out why. If I press enter at any point after VisualEditor loading and try... [21:28:16] Yep, that's it. [21:28:23] If I don't hit enter at any point, it works. [21:47:53] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Users who enable "Automatically enable all new beta features" should have the 2017 wikitext editor beta feature enabled - https://phabricator.wikimedia.org/T176181#3616358 (10Deskana) [21:50:44] Okay, the `node is null` part is definitely from the TransactionProcessor patch. [21:59:44] 10VisualEditor: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert" - https://phabricator.wikimedia.org/T175943#3616392 (10DLynch) Okay, bisect indicates that both the `node is null` error and the dialog issue were introduced by 37d1512, @dchan's TransactionProcessor... [22:08:38] Okay, I admit, "it's probably TransactionProcessor" would have been an easy guess without all that git bisecting. [22:20:18] (03CR) 10Catrope: [C: 032] ve.ce.Surface: Make attribute resolution consistent with ve.ui.PreviewElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376262 (owner: 10Bartosz DziewoƄski) [22:21:09] (03CR) 10Catrope: [C: 032] Do not "resolve attributes" in toDomElements() overrides [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376507 (https://phabricator.wikimedia.org/T169675) (owner: 10Bartosz DziewoƄski) [22:24:13] (03Merged) 10jenkins-bot: ve.ce.Surface: Make attribute resolution consistent with ve.ui.PreviewElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376262 (owner: 10Bartosz DziewoƄski) [22:27:31] (03Merged) 10jenkins-bot: Do not "resolve attributes" in toDomElements() overrides [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376507 (https://phabricator.wikimedia.org/T169675) (owner: 10Bartosz DziewoƄski) [22:30:21] (03CR) 10jenkins-bot: ve.ce.Surface: Make attribute resolution consistent with ve.ui.PreviewElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376262 (owner: 10Bartosz DziewoƄski) [22:32:54] (03CR) 10jenkins-bot: Do not "resolve attributes" in toDomElements() overrides [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376507 (https://phabricator.wikimedia.org/T169675) (owner: 10Bartosz DziewoƄski) [23:11:02] Further research: something about the TransactionProcessor patch makes it so that scrollCursorIntoView is trying to run and work out selection rects before branch slugs have been added, which causes problems with empty paragraphs. [23:11:20] Is it adding something in a different bit of the document somehow? [23:11:31] (03PS1) 10Jforrester: Update VE core submodule to master (75726b850) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378816 [23:11:49] Also ^^ [23:14:41] James_F: I don't *think* it is, but I need to dig deeper. I think it might just be the scroll stuff running at an interim point which previously couldn't exist, but now does because the transactionprocessor is modifying nodes in place. [23:16:00] I would say "make it Cavid's problem", but he's unlikely to look at it soon. :-( [23:17:37] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (75726b850) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378816 (owner: 10Jforrester) [23:23:36] (03Merged) 10jenkins-bot: Update VE core submodule to master (75726b850) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378816 (owner: 10Jforrester) [23:25:38] (03CR) 10jenkins-bot: Update VE core submodule to master (75726b850) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378816 (owner: 10Jforrester)