[00:51:28] (03PS1) 10VolkerE: Update OOjs UI to v0.23.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/379146 [01:22:33] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.23.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/379146 (owner: 10VolkerE) [01:25:40] (03Merged) 10jenkins-bot: Update OOjs UI to v0.23.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/379146 (owner: 10VolkerE) [01:33:40] (03CR) 10jenkins-bot: Update OOjs UI to v0.23.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/379146 (owner: 10VolkerE) [02:31:09] (03CR) 10C. Scott Ananian: Extend 'format' spec to include custom format strings. (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/306975 (https://phabricator.wikimedia.org/T138492) (owner: 10C. Scott Ananian) [08:41:15] 10VisualEditor, 10ContentTranslation, 10Contributors-Team, 10Design, 10WorkType-NewFunctionality: Content Translation feature parity checklist post VisualEditor integration - https://phabricator.wikimedia.org/T150652#3620490 (10Arrbee) [08:44:33] 10VisualEditor, 10VisualEditor-VisualDiffs: Consider clarifying the visual language for Visual Diffs - https://phabricator.wikimedia.org/T169325#3620500 (10Prtksxna) >>! In T169325#3587029, @Volker_E wrote: > Delete has in all image examples strike-through applied. “Bold style applied“, “Link added” and insert... [11:08:26] 10VisualEditor: VE freezes when trying to insert a reference with "Cannot read property 'getDataFromNode' of null" - https://phabricator.wikimedia.org/T176246#3620777 (10Deskana) 05Open>03stalled @tbayer I can't reproduce this problem. I managed to successfully insert a dummy reference on to that page by fol... [11:08:57] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review, 10User-Ryasmeen: Previews of citations generated by templates in subpages give incorrect internal redlinks - https://phabricator.wikimedia.org/T169675#3620779 (10Deskana) 05Open>03Resolved >>! In T169675#3619233, @matmarex wrote: > @Deskana... [11:13:27] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10MediaWiki-Page-editing, and 2 others: Add support for (the equivalent of?) editintro and preload - https://phabricator.wikimedia.org/T51622#3620799 (10Deskana) a:03DLynch What is the best way to test this? I tried using [[https://e... [12:23:41] 10VisualEditor: VisualEditor stuck during the loading process - https://phabricator.wikimedia.org/T176049#3620931 (10Deskana) >>! In T176049#3619387, @Samat wrote: > I am sorry, I didn't know. It is not always easy to follow the changes at the WMF :) No problem! I have trouble keeping up myself. :-) > Didn't k... [12:29:31] 10VisualEditor, 10VisualEditor-DataModel: Re-applying transactions to internal nodes can throw exceptions - https://phabricator.wikimedia.org/T135127#3620949 (10Deskana) p:05High>03Low Lowering in priority since there is a workaround. [12:36:57] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-General-or-Unknown, 10Patch-For-Review: Feedback tool displays/links the wrong target for page link when it's cross-wiki, although it does post to the correct place - https://phabricator.wikimedia.org/T125400#3620975 (10Deskana) [12:39:40] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-General-or-Unknown, 10Patch-For-Review: Feedback tool displays/links the wrong target for page link when it's cross-wiki, although it does post to the correct place - https://phabricator.wikimedia.org/T125400#3620978 (10Deskana) p:05Normal>03Low I'v... [12:49:38] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki, 10User-Ryasmeen: When cursor is in an invalid position, cancelling the save dialog ("Resume") will cause a fatal as it tries to re-insert the cursor in a wrong place - https://phabricator.wikimedia.org/T121017#3621020 (10Deskana) 05... [13:32:01] (03PS1) 10Deskana: "Automatically enable all new beta features" should enable 2017 editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379228 (https://phabricator.wikimedia.org/T176181) [13:34:18] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10User-notice: Users who enable "Automatically enable all new beta features" should have the 2017 wikitext editor beta feature enabled - https://phabricator.wikimedia.org/T176181#3621113 (10Deskana) [13:44:02] 10VisualEditor, 10MediaWiki-extensions-UniversalLanguageSelector: ULS not working properly for Kannada in Visual editor - https://phabricator.wikimedia.org/T176104#3613665 (10Elitre) It is probably severe, because it's also reported for Telugu. [13:44:48] 10VisualEditor, 10MediaWiki-extensions-UniversalLanguageSelector: ULS not working properly for Kannada in Visual editor - https://phabricator.wikimedia.org/T176104#3621150 (10Elitre) [13:52:52] 10VisualEditor, 10MediaWiki-extensions-UniversalLanguageSelector: ULS not working properly for Kannada in Visual editor - https://phabricator.wikimedia.org/T176104#3621164 (10Anooprao) Hindi language also same issue [13:54:36] 10VisualEditor, 10MediaWiki-extensions-UniversalLanguageSelector: ULS not working properly for Kannada in Visual editor - https://phabricator.wikimedia.org/T176104#3621167 (10Pavanaja) >>! In T176104#3621147, @Elitre wrote: > It is probably severe, because it's also reported for Telugu. I think the problem is... [13:55:44] 10VisualEditor, 10MediaWiki-extensions-UniversalLanguageSelector: ULS not working properly for Indic wikis in Visual editor - https://phabricator.wikimedia.org/T176104#3621172 (10Elitre) [14:43:21] 10VisualEditor, 10Contributors-Team: Obviate the need for wikis' wrapper and functionality-replacement templates - https://phabricator.wikimedia.org/T95543#1194043 (10Izno) {T176242} seems relevant to this task. [14:46:14] hello! what is the name of the hook for when VE/NWE successfully saves an edit? [14:46:40] or actually, when VE/NWE is closed (either with the Escape key or after saving) [14:52:36] (03CR) 10Zoranzoki21: [C: 031] Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373890 (https://phabricator.wikimedia.org/T173181) (owner: 10Eugene233) [14:55:13] (03CR) 10D3r1ck01: [C: 031] Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373890 (https://phabricator.wikimedia.org/T173181) (owner: 10Eugene233) [15:00:59] (03PS2) 10Esanders: Wait for tree to finish building before updating caption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379053 (https://phabricator.wikimedia.org/T176265) [15:13:23] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10MediaWiki-Page-editing, and 2 others: Add support for (the equivalent of?) editintro and preload - https://phabricator.wikimedia.org/T51622#3621455 (10DLynch) Ah, that's because I didn't remove `preloadtitle` from the `unsupportedEdit... [15:18:40] (03PS1) 10DLynch: Hooks: remove preloadtitle from unsupported list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379246 (https://phabricator.wikimedia.org/T51622) [15:20:38] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10User-notice: Users who enable "Automatically enable all new beta features" should have the 2017 wikitext editor beta feature enabled - https://phabricator.wikimedia.org/T176181#3621466 (10Deskana) [15:24:15] (03CR) 10Esanders: [C: 032] Hooks: remove preloadtitle from unsupported list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379246 (https://phabricator.wikimedia.org/T51622) (owner: 10DLynch) [15:28:40] (03CR) 10DLynch: [C: 032] Wait for tree to finish building before updating caption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379053 (https://phabricator.wikimedia.org/T176265) (owner: 10Esanders) [15:34:55] (03CR) 10Deskana: [C: 04-1] "Merge after 27th October 2017" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379228 (https://phabricator.wikimedia.org/T176181) (owner: 10Deskana) [15:37:52] (03CR) 10Deskana: [C: 04-1] "Ignore previous instructions. Merge after 27th September 2017." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379228 (https://phabricator.wikimedia.org/T176181) (owner: 10Deskana) [15:39:10] (03Merged) 10jenkins-bot: Hooks: remove preloadtitle from unsupported list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379246 (https://phabricator.wikimedia.org/T51622) (owner: 10DLynch) [15:41:34] (03Merged) 10jenkins-bot: Wait for tree to finish building before updating caption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379053 (https://phabricator.wikimedia.org/T176265) (owner: 10Esanders) [15:49:22] (03PS2) 10Jforrester: DesktopArticleTarget.init: handle new-section tab when in visual mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377301 (https://phabricator.wikimedia.org/T157755) (owner: 10DLynch) [16:04:23] (03CR) 10jenkins-bot: Hooks: remove preloadtitle from unsupported list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379246 (https://phabricator.wikimedia.org/T51622) (owner: 10DLynch) [16:07:41] (03CR) 10jenkins-bot: Wait for tree to finish building before updating caption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379053 (https://phabricator.wikimedia.org/T176265) (owner: 10Esanders) [16:13:44] (03CR) 10Bartosz Dziewoński: [C: 032] Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373890 (https://phabricator.wikimedia.org/T173181) (owner: 10Eugene233) [16:20:41] (03Merged) 10jenkins-bot: Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373890 (https://phabricator.wikimedia.org/T173181) (owner: 10Eugene233) [16:22:57] 10VisualEditor, 10Africa-Wikimedia-Developers, 10Easy, 10I18n, 10User-Ryasmeen: Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label - https://phabricator.wikimedia.org/T173181#3621670 (10Zoranzoki21) 05Open>03Resolved [16:27:10] (03CR) 10jenkins-bot: Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/373890 (https://phabricator.wikimedia.org/T173181) (owner: 10Eugene233) [16:56:09] (03CR) 10Bartosz Dziewoński: [C: 032] DesktopArticleTarget.init: handle new-section tab when in visual mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377301 (https://phabricator.wikimedia.org/T157755) (owner: 10DLynch) [17:04:49] (03Merged) 10jenkins-bot: DesktopArticleTarget.init: handle new-section tab when in visual mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377301 (https://phabricator.wikimedia.org/T157755) (owner: 10DLynch) [17:07:38] (03PS1) 10Arlolra: Update grammar to yield the results in the examples [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/379267 [17:09:02] (03CR) 10jenkins-bot: DesktopArticleTarget.init: handle new-section tab when in visual mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/377301 (https://phabricator.wikimedia.org/T157755) (owner: 10DLynch) [17:17:31] (03CR) 10Arlolra: [C: 04-2] Update grammar to yield the results in the examples [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/379267 (owner: 10Arlolra) [17:25:37] (03CR) 10Arlolra: "The -2 there was because of the "// Format checks" in tests/ext.templateData.tests.js" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/379267 (owner: 10Arlolra) [17:26:34] 10VisualEditor, 10Contributors-Team, 10MediaWiki-General-or-Unknown, 10OOjs-UI, and 3 others: Update extensions for deprecation of openWindow/closeWindow promise in OOjs UI v0.22 - https://phabricator.wikimedia.org/T166729#3305839 (10CCicalese_WMF) CommentStreams is not unmaintained. It uses the "master" c... [17:49:37] 10VisualEditor, 10Contributors-Team, 10MediaWiki-General-or-Unknown, 10OOjs-UI, and 3 others: Update extensions for deprecation of openWindow/closeWindow promise in OOjs UI v0.22 - https://phabricator.wikimedia.org/T166729#3622134 (10matmarex) >>! In T166729#3622029, @CCicalese_WMF wrote: > CommentStreams... [19:53:35] 10VisualEditor, 10Contributors-Team, 10MediaWiki-General-or-Unknown, 10OOjs-UI, and 3 others: Update extensions for deprecation of openWindow/closeWindow promise in OOjs UI v0.22 - https://phabricator.wikimedia.org/T166729#3622523 (10CCicalese_WMF) Yes, I absolutely plan to merge the patch when I'm sure it... [20:32:15] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10MediaWiki-Page-editing, and 3 others: Add support for (the equivalent of?) editintro and preload - https://phabricator.wikimedia.org/T51622#3622648 (10DLynch) Just to confirm, now that patch has made its way to the beta cluster, the i... [20:39:33] (03PS1) 10Jforrester: Setup slugs in TreeModifier [VisualEditor/VisualEditor] (REL1_30) - 10https://gerrit.wikimedia.org/r/379328 (https://phabricator.wikimedia.org/T175852) [20:39:50] (03CR) 10Jforrester: [C: 032] "Let's not leave the new release in this state." [VisualEditor/VisualEditor] (REL1_30) - 10https://gerrit.wikimedia.org/r/379328 (https://phabricator.wikimedia.org/T175852) (owner: 10Jforrester) [20:43:57] (03Merged) 10jenkins-bot: Setup slugs in TreeModifier [VisualEditor/VisualEditor] (REL1_30) - 10https://gerrit.wikimedia.org/r/379328 (https://phabricator.wikimedia.org/T175852) (owner: 10Jforrester) [21:10:32] (03PS1) 10Jforrester: Update VE core submodule to REL1_30 HEAD (8694af408) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379408 [21:11:49] (03Abandoned) 10Jforrester: Update VE core submodule to REL1_30 HEAD (8694af408) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379408 (owner: 10Jforrester) [21:39:36] (03CR) 10jenkins-bot: Setup slugs in TreeModifier [VisualEditor/VisualEditor] (REL1_30) - 10https://gerrit.wikimedia.org/r/379328 (https://phabricator.wikimedia.org/T175852) (owner: 10Jforrester) [21:50:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/379398 (owner: 10L10n-bot) [21:54:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379407 (owner: 10L10n-bot) [22:04:29] (03PS1) 10Jforrester: Update VE core submodule to REL1_30 HEAD (8694af408) [extensions/VisualEditor] (REL1_30) - 10https://gerrit.wikimedia.org/r/379421 [22:20:52] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to REL1_30 HEAD (8694af408) [extensions/VisualEditor] (REL1_30) - 10https://gerrit.wikimedia.org/r/379421 (owner: 10Jforrester) [22:25:59] Deskana: edsanders: NWE feature request: when in new section mode, if I press enter at the end of the section title, I'd like the cursor to move to the main body [22:26:24] I pressed enter 5 times until I realized I needed to use the mouse to move to the main surface [22:26:29] RoanKattouw: I think we intentionally didn't enable that (section->section transitions). [22:26:34] RoanKattouw: Tab also works. [22:26:39] Fair enough [22:26:43] What do you mean by section->section transitions? [22:26:46] But I can't remember why. [22:26:54] I'm talking specifically about ?section=new [22:27:11] The title and the body of the "new section" edit mode are just two VE sections [22:27:25] actually the title is a TextInputWidget [22:27:38] same as in source mode [22:27:39] Oh, right, yeah. [22:27:45] but in source mode it's more obvious they're separate inputs [22:28:22] *old source mode [22:28:53] sounds like a one liner [22:29:17] sectionTitle.on('enter', surface.focus() ) [22:31:19] 10VisualEditor: VE freezes when trying to insert a reference with "Cannot read property 'getDataFromNode' of null" - https://phabricator.wikimedia.org/T176246#3623080 (10Tbayer) @Deskana Thanks for looking into it! Strangely, it works fine for me too now. But I did reproduce it several times before filing this b... [23:01:30] (03PS1) 10DLynch: Surface: reset selection when popping staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/379435 (https://phabricator.wikimedia.org/T166134) [23:06:36] ^^^ arguably that + https://gerrit.wikimedia.org/r/379437 should have a more elegant solution. A fragmentdialog meddling with staging in its setup/teardown causes selection issues. [23:12:41] My patches (a) make popping staging just restore the saved prior selection state, and (b) has that particular Graph dialog update the fragment to reflect the selection change that the surface underwent.