[00:46:26] <Kemayo>	 edsanders: ^^^ relevant context, since James added you as a reviewer.
[07:35:51] <wikibugs_>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/379481 (owner: 10L10n-bot)
[09:59:27] <wikibugs_>	 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10User-notice: Users who enable "Automatically enable all new beta features" should have the 2017 wikitext editor beta feature enabled - https://phabricator.wikimedia.org/T176181#3616358 (10Johan) @Deskana Will this take effec...
[12:17:47] <wikibugs_>	 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10User-notice: Users who enable "Automatically enable all new beta features" should have the 2017 wikitext editor beta feature enabled - https://phabricator.wikimedia.org/T176181#3624128 (10Deskana) @johan I had planned for it...
[13:14:07] <wikibugs_>	 10Citoid, 10VisualEditor: Fetch citation details from Wikidata - https://phabricator.wikimedia.org/T176411#3624281 (10Pigsonthewing)
[13:16:37] <wikibugs_>	 10Citoid, 10VisualEditor: Fetch citation details from Wikidata - https://phabricator.wikimedia.org/T176411#3624311 (10Pigsonthewing)
[13:17:11] <wikibugs_>	 10Citoid, 10VisualEditor: Fetch citation details from Wikidata - https://phabricator.wikimedia.org/T176411#3624281 (10Pigsonthewing)
[13:17:34] <wikibugs_>	 10Citoid, 10VisualEditor: Fetch citation details from Wikidata, using QIDs - https://phabricator.wikimedia.org/T176411#3624281 (10Pigsonthewing)
[14:46:47] <wikibugs_>	 (03PS1) 10Esanders: Fix font size in local overlays in monobook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379548
[14:59:40] <wikibugs_>	 (03CR) 10Jforrester: [C: 032] Fix font size in local overlays in monobook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379548 (owner: 10Esanders)
[15:07:28] <wikibugs_>	 10VisualEditor, 10ContentTranslation: Integrate editing toolbar in the tools column in Content Translation - https://phabricator.wikimedia.org/T176422#3624629 (10Pginer-WMF)
[15:09:07] <wikibugs_>	 (03Merged) 10jenkins-bot: Fix font size in local overlays in monobook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379548 (owner: 10Esanders)
[15:12:47] <wikibugs_>	 (03CR) 10jenkins-bot: Fix font size in local overlays in monobook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379548 (owner: 10Esanders)
[15:22:16] <wikibugs_>	 (03CR) 10Esanders: [C: 032] Surface: reset selection when popping staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/379435 (https://phabricator.wikimedia.org/T166134) (owner: 10DLynch)
[15:24:45] <wikibugs_>	 (03Merged) 10jenkins-bot: Surface: reset selection when popping staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/379435 (https://phabricator.wikimedia.org/T166134) (owner: 10DLynch)
[15:27:06] <wikibugs_>	 (03CR) 10jenkins-bot: Surface: reset selection when popping staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/379435 (https://phabricator.wikimedia.org/T166134) (owner: 10DLynch)
[15:50:14] <wikibugs_>	 10VisualEditor: visual editor inserts a reference tag - https://phabricator.wikimedia.org/T176425#3624737 (10Formatierer)
[16:00:03] <wikibugs_>	 (03PS1) 10DLynch: Update VE core submodule to master (bd5da1725) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379557 (https://phabricator.wikimedia.org/T166134)
[16:03:38] <wikibugs_>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (bd5da1725) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379557 (https://phabricator.wikimedia.org/T166134) (owner: 10DLynch)
[16:11:35] <wikibugs_>	 (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (bd5da1725) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379557 (https://phabricator.wikimedia.org/T166134) (owner: 10DLynch)
[16:12:24] <wikibugs_>	 (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (bd5da1725) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379557 (https://phabricator.wikimedia.org/T166134) (owner: 10DLynch)
[16:17:19] <Kemayo>	 A test that does, indeed, pass locally.
[16:17:34] <James_F>	 Kemayo: And in the VE-core repo.
[16:17:44] <James_F>	 Maybe something changed in the CI setup?
[16:18:17] <James_F>	 Oh, yeah, my REL1_30 back-port last night failed in the same way.
[16:19:23] <James_F>	 Maybe it's a regression in a new version of Chromium or something?
[16:37:28] <wikibugs_>	 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: 2017 wikitext editor doesn't load if I create a new page with preload worksheet - https://phabricator.wikimedia.org/T174487#3624939 (10DLynch)
[16:37:35] <wikibugs_>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10MediaWiki-Page-editing, and 3 others: Add support for (the equivalent of?) editintro and preload - https://phabricator.wikimedia.org/T51622#3624942 (10DLynch)
[16:48:51] <wikibugs_>	 10VisualEditor, 10Contributors-Team, 10MediaWiki-General-or-Unknown, 10OOjs-UI, and 3 others: Update extensions for deprecation of openWindow/closeWindow promise in OOjs UI v0.22 - https://phabricator.wikimedia.org/T166729#3624987 (10CCicalese_WMF) I just tested the patch with 1.29, and it does not work, s...
[18:00:55] <wikibugs_>	 (03CR) 10Jforrester: [C: 032] Use findFirstSelectableitem instead of getFirstSelectableItem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376175 (https://phabricator.wikimedia.org/T76630) (owner: 10Prtksxna)
[18:01:49] <wikibugs_>	 (03CR) 10Jforrester: [C: 032] Use findFirstSelectableitem instead of getFirstSelectableItem [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376177 (https://phabricator.wikimedia.org/T76630) (owner: 10Prtksxna)
[18:02:24] <wikibugs_>	 (03CR) 10Jforrester: [C: 032] Use findFirstSelectableitem instead of getFirstSelectableItem [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/376174 (https://phabricator.wikimedia.org/T76630) (owner: 10Prtksxna)
[18:07:21] <wikibugs_>	 (03Merged) 10jenkins-bot: Use findFirstSelectableitem instead of getFirstSelectableItem [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376177 (https://phabricator.wikimedia.org/T76630) (owner: 10Prtksxna)
[18:13:10] <wikibugs_>	 (03Merged) 10jenkins-bot: Use findFirstSelectableitem instead of getFirstSelectableItem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376175 (https://phabricator.wikimedia.org/T76630) (owner: 10Prtksxna)
[18:13:12] <wikibugs_>	 (03Merged) 10jenkins-bot: Use findFirstSelectableitem instead of getFirstSelectableItem [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/376174 (https://phabricator.wikimedia.org/T76630) (owner: 10Prtksxna)
[18:58:47] <wikibugs_>	 (03CR) 10jenkins-bot: Use findFirstSelectableitem instead of getFirstSelectableItem [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/376174 (https://phabricator.wikimedia.org/T76630) (owner: 10Prtksxna)
[18:59:49] <wikibugs_>	 (03CR) 10jenkins-bot: Use findFirstSelectableitem instead of getFirstSelectableItem [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376177 (https://phabricator.wikimedia.org/T76630) (owner: 10Prtksxna)
[19:01:14] <wikibugs_>	 (03CR) 10jenkins-bot: Use findFirstSelectableitem instead of getFirstSelectableItem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376175 (https://phabricator.wikimedia.org/T76630) (owner: 10Prtksxna)
[19:07:39] <wikibugs_>	 (03PS1) 10Reedy: Replace $wgUser with $user [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379596
[19:09:19] <wikibugs_>	 (03PS1) 10Reedy: Replace $wgUser with $user [extensions/VisualEditor] (wmf/1.30.0-wmf.19) - 10https://gerrit.wikimedia.org/r/379597
[19:10:05] <wikibugs_>	 (03CR) 10Chad: [C: 032] Replace $wgUser with $user [extensions/VisualEditor] (wmf/1.30.0-wmf.19) - 10https://gerrit.wikimedia.org/r/379597 (owner: 10Reedy)
[19:18:06] <wikibugs_>	 (03Merged) 10jenkins-bot: Replace $wgUser with $user [extensions/VisualEditor] (wmf/1.30.0-wmf.19) - 10https://gerrit.wikimedia.org/r/379597 (owner: 10Reedy)
[19:30:30] <wikibugs_>	 (03CR) 10Legoktm: [C: 032] Replace $wgUser with $user [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379596 (owner: 10Reedy)
[19:38:26] <wikibugs_>	 (03Merged) 10jenkins-bot: Replace $wgUser with $user [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379596 (owner: 10Reedy)
[19:52:12] <wikibugs_>	 (03CR) 10jenkins-bot: Replace $wgUser with $user [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379596 (owner: 10Reedy)
[20:11:38] <wikibugs_>	 (03PS1) 10Arlolra: Guard against empty nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/379613 (https://phabricator.wikimedia.org/T174774)
[20:14:49] <wikibugs_>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Media, 10Browser-Support-Firefox, and 4 others: Editing captions in Firefox is so unpredictable as to be useless - https://phabricator.wikimedia.org/T174774#3625494 (10Arlolra) The selection seems to be prevented by a throw.
[20:23:00] <wikibugs_>	 (03CR) 10Esanders: "I think this cause of node being null was fixed separately by David." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/379613 (https://phabricator.wikimedia.org/T174774) (owner: 10Arlolra)
[20:23:17] <wikibugs_>	 (03CR) 10Esanders: [C: 04-1] "-1 pending David's opinion" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/379613 (https://phabricator.wikimedia.org/T174774) (owner: 10Arlolra)
[20:43:58] <wikibugs_>	 (03Abandoned) 10Arlolra: Guard against empty nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/379613 (https://phabricator.wikimedia.org/T174774) (owner: 10Arlolra)
[20:45:06] <wikibugs_>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Media, 10Browser-Support-Firefox, and 4 others: Editing captions in Firefox is so unpredictable as to be useless - https://phabricator.wikimedia.org/T174774#3625613 (10Arlolra) With the patch from T175852 / T175943, this seems to be resolved.
[20:50:13] <wikibugs_>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Media, 10Browser-Support-Firefox, and 4 others: Editing captions in Firefox is so unpredictable as to be useless - https://phabricator.wikimedia.org/T174774#3625624 (10Arlolra) 05Open>03Resolved
[20:53:50] <wikibugs_>	 10VisualEditor, 10Wikimedia-log-errors: Undefined variable: content in ApiVisualEditor - https://phabricator.wikimedia.org/T176440#3625630 (10demon)
[21:02:47] <wikibugs_>	 (03CR) 10Subramanya Sastry: [C: 031] "lgtm at a quick glance. cscott want to glance at this?" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/379267 (owner: 10Arlolra)
[21:06:33] <wikibugs_>	 10VisualEditor, 10Wikimedia-log-errors: Undefined variable: content in ApiVisualEditor - https://phabricator.wikimedia.org/T176440#3625697 (10Esanders) Looks like a regression from the preload patch. Pinging @DLynch
[21:09:06] <wikibugs_>	 (03CR) 10Arlolra: "See the comments on https://gerrit.wikimedia.org/r/#/c/306975/2/Specification.md" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/379267 (owner: 10Arlolra)
[21:10:45] <wikibugs_>	 (03CR) 10Subramanya Sastry: [C: 032] "okay then." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/379267 (owner: 10Arlolra)
[21:10:59] <Kemayo>	 edsanders: That's weird, I'm pretty sure $content is set in every possible branch.
[21:11:28] <Kemayo>	 Let me go read through those if statements line by line.
[21:14:21] <wikibugs_>	 10VisualEditor: visual editor inserts a reference tag - https://phabricator.wikimedia.org/T176425#3624737 (10Esanders) Doesn't sound like a problem with VE, just the user doing what they shouldn't.
[21:14:54] <wikibugs_>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/379653 (owner: 10L10n-bot)
[21:15:22] <wikibugs_>	 (03Merged) 10jenkins-bot: Update grammar to yield the results in the examples [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/379267 (owner: 10Arlolra)
[21:16:41] <wikibugs_>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379658 (owner: 10L10n-bot)
[21:18:13] <Kemayo>	 edsanders: Okay, worked it out.
[21:19:50] <wikibugs_>	 10VisualEditor, 10Wikimedia-log-errors: Undefined variable: content in ApiVisualEditor - https://phabricator.wikimedia.org/T176440#3625724 (10DLynch) Looks like I missed a path through the function. This is happening when a page that already exists is loaded with a preload parameter.
[21:22:16] <wikibugs_>	 (03PS1) 10DLynch: ApiVisualEditor: Stop an undefined variable error for preload on existing pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379666 (https://phabricator.wikimedia.org/T176440)
[21:22:56] <wikibugs_>	 (03CR) 10Jforrester: [C: 032] ApiVisualEditor: Stop an undefined variable error for preload on existing pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379666 (https://phabricator.wikimedia.org/T176440) (owner: 10DLynch)
[21:26:27] <wikibugs_>	 (03CR) 10jenkins-bot: Update grammar to yield the results in the examples [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/379267 (owner: 10Arlolra)
[21:29:51] <wikibugs_>	 (03Merged) 10jenkins-bot: ApiVisualEditor: Stop an undefined variable error for preload on existing pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379666 (https://phabricator.wikimedia.org/T176440) (owner: 10DLynch)
[21:34:15] <wikibugs_>	 (03CR) 10Arlolra: "> Maybe that needs to be updated or at least throw a `templatedata-invalid-format`" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/379267 (owner: 10Arlolra)
[21:41:28] <wikibugs_>	 (03CR) 10jenkins-bot: ApiVisualEditor: Stop an undefined variable error for preload on existing pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/379666 (https://phabricator.wikimedia.org/T176440) (owner: 10DLynch)
[21:43:42] <wikibugs_>	 (03PS1) 10Jforrester: ApiVisualEditor: Stop an undefined variable error for preload on existing pages [extensions/VisualEditor] (wmf/1.30.0-wmf.19) - 10https://gerrit.wikimedia.org/r/379671 (https://phabricator.wikimedia.org/T176440)
[21:58:52] <wikibugs_>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: Previews of some interwiki links do not work as expected in parsoid preview - https://phabricator.wikimedia.org/T176442#3625807 (10Quiddity) Ok, thanks for checking. I'll change the tag to VE then, with the hope that is correct. (I confirmed the bug in visual edi...