[00:38:35] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Dragging an image to a new location caused it to disappear - https://phabricator.wikimedia.org/T176899#3641582 (10Whatamidoing-WMF) https://en.wikipedia.org/wiki/Medical_identification_tag The diff is https://en.wikipedia.org/w/index.php?title=Medical_identifi... [00:39:17] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Dragging an image to a new location caused it to disappear - https://phabricator.wikimedia.org/T176899#3641583 (10Whatamidoing-WMF) I have wondered whether a key step might be first inserting the new image adjacent to the old one, rather than dragging the old one... [05:34:56] 10VisualEditor, 10VisualEditor-MediaWiki, 10VE-deploy-2013-05-13: VisualEditor: In RTL, the "Edit" tab appears down-tab (to the left) rather than up-tab (to the right) of "Edit source" - https://phabricator.wikimedia.org/T50017#3641746 (10matmarex) 05Resolved>03Open With the underlying issue T48947 being... [05:35:18] (03PS1) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget: Remove hack for reversed tabs in RTL in Vector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381167 (https://phabricator.wikimedia.org/T50017) [05:45:25] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VE-deploy-2013-05-13: VisualEditor: In RTL, the "Edit" tab appears down-tab (to the left) rather than up-tab (to the right) of "Edit source" - https://phabricator.wikimedia.org/T50017#3641760 (10matmarex) (This will need to be backported to 1.... [06:32:57] 10VisualEditor, 10ContentTranslation, 10Contributors-Team, 10Design, 10WorkType-NewFunctionality: Content Translation feature parity checklist post VisualEditor integration - https://phabricator.wikimedia.org/T150652#3641792 (10Arrbee) [06:33:18] 10VisualEditor, 10ContentTranslation, 10Contributors-Team, 10Design, 10WorkType-NewFunctionality: Content Translation feature parity checklist post VisualEditor integration - https://phabricator.wikimedia.org/T150652#2792172 (10Arrbee) [08:21:28] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Dragging an image to a new location caused it to disappear - https://phabricator.wikimedia.org/T176899#3641873 (10Esanders) Hmm, still can't reproduce so difficult to see what went wrong. [08:29:50] (03CR) 10Esanders: "I can't reproduce the bug as described, but it sounds like this is fixing the symptom rather than the cause. The cause here is the cursor " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381033 (https://phabricator.wikimedia.org/T148679) (owner: 10DLynch) [08:34:50] 10VisualEditor, 10VisualEditor-ContentEditable: Clicking to the right of a table in Firefox puts the cursor inside the last the cell (but not in cell editing mode) - https://phabricator.wikimedia.org/T176936#3641918 (10Esanders) [08:37:10] 10VisualEditor, 10VisualEditor-ContentEditable, 10Patch-For-Review: Uncaught Error: Inserted data is trying to close the root node (at index 0) appears when pressing returen after deselecting some nodes - https://phabricator.wikimedia.org/T148679#2729801 (10Esanders) Related: T176936 [08:47:54] edsanders: morning. if you're up and working already, https://gerrit.wikimedia.org/r/#/c/381167/ could use review (and backporting today) [08:49:16] (03CR) 10Esanders: [C: 032] ve.init.mw.DesktopArticleTarget: Remove hack for reversed tabs in RTL in Vector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381167 (https://phabricator.wikimedia.org/T50017) (owner: 10Bartosz Dziewoński) [08:50:06] well, that was quick. i had to draw myself a truth table to be certain about removing that xor. [08:57:59] (03Merged) 10jenkins-bot: ve.init.mw.DesktopArticleTarget: Remove hack for reversed tabs in RTL in Vector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381167 (https://phabricator.wikimedia.org/T50017) (owner: 10Bartosz Dziewoński) [08:58:43] That's a classic xor usage, using one bit to flip another [09:01:31] (03CR) 10jenkins-bot: ve.init.mw.DesktopArticleTarget: Remove hack for reversed tabs in RTL in Vector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381167 (https://phabricator.wikimedia.org/T50017) (owner: 10Bartosz Dziewoński) [11:15:34] (03Abandoned) 10Zfilipin: WIP WebdriverIO tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/345146 (https://phabricator.wikimedia.org/T150435) (owner: 10Zfilipin) [12:00:55] 10VisualEditor, 10ContentTranslation, 10Contributors-Team, 10Design, 10WorkType-NewFunctionality: Content Translation feature parity checklist post VisualEditor integration - https://phabricator.wikimedia.org/T150652#3642404 (10santhosh) > [ST] In case that machine translation is not available, null MT... [12:02:19] 10VisualEditor, 10ContentTranslation, 10Contributors-Team, 10Design, 10WorkType-NewFunctionality: Content Translation feature parity checklist post VisualEditor integration - https://phabricator.wikimedia.org/T150652#3642412 (10santhosh) [12:09:29] 10TemplateData, 10VisualEditor: Add a class to empty TemplateData fields titles (dt) - https://phabricator.wikimedia.org/T176956#3642445 (10The_RedBurn) [12:16:20] 10TemplateData, 10VisualEditor: Add a class to empty TemplateData fields titles (dt) - https://phabricator.wikimedia.org/T176956#3642470 (10The_RedBurn) https://phabricator.wikimedia.org/diffusion/ETDA/browse/master/TemplateDataBlob.php;68b8c0b60eb6e439291ac2a1c0bbd212b7e18ca1$842 [12:34:11] (03PS1) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget: Remove hack for reversed tabs in RTL in Vector [extensions/VisualEditor] (wmf/1.31.0-wmf.1) - 10https://gerrit.wikimedia.org/r/381210 (https://phabricator.wikimedia.org/T50017) [13:00:40] 10VisualEditor: VisualEditor no remove dialog for adding template(s) after adding in palemoon browser - https://phabricator.wikimedia.org/T176773#3642559 (10Zoranzoki21) [13:01:16] 10VisualEditor: VisualEditor no remove dialog for adding template(s) after adding in palemoon browser - https://phabricator.wikimedia.org/T176773#3636291 (10Zoranzoki21) I installed google chrome, and adding templates work normal.. It only happen in palemoon browser.. I changed description and title now. [13:05:41] (03CR) 10Zfilipin: [C: 032] "SWAT" [extensions/VisualEditor] (wmf/1.31.0-wmf.1) - 10https://gerrit.wikimedia.org/r/381210 (https://phabricator.wikimedia.org/T50017) (owner: 10Bartosz Dziewoński) [13:14:57] (03Merged) 10jenkins-bot: ve.init.mw.DesktopArticleTarget: Remove hack for reversed tabs in RTL in Vector [extensions/VisualEditor] (wmf/1.31.0-wmf.1) - 10https://gerrit.wikimedia.org/r/381210 (https://phabricator.wikimedia.org/T50017) (owner: 10Bartosz Dziewoński) [13:50:42] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), 10Patch-For-Review, and 2 others: VisualEditor: In RTL, the "Edit" tab appears down-tab (to the left) rather than up-tab (to the right) of "Edit source" - https://phabricator.wikimedia.org/T50017#3642787... [13:54:59] (03PS1) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget: Fix the code to reorder tabs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381217 (https://phabricator.wikimedia.org/T50017) [14:59:45] 10VisualEditor, 10VisualEditor-EditingTools, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), 10User-Ryasmeen: On blank lines, you can select multiple formats from the format menu; the surface only responds to the first, until there is cotent - https://phabricator.wikimedia.org/T146958#3643134... [15:01:49] 10VisualEditor, 10VisualEditor-EditingTools, 10MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), 10Regression, 10User-Ryasmeen: History tools not updating state in standalone demo - https://phabricator.wikimedia.org/T175734#3643137 (10Jdforrester-WMF) [15:02:50] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), 10User-Ryasmeen: Previews of citations generated by templates in subpages give incorrect internal redlinks - https://phabricator.wikimedia.org/T169675#3643139 (10Jdforrester-WMF) [15:40:05] (03CR) 10Esanders: [C: 032] ve.init.mw.DesktopArticleTarget: Fix the code to reorder tabs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381217 (https://phabricator.wikimedia.org/T50017) (owner: 10Bartosz Dziewoński) [15:49:13] (03Merged) 10jenkins-bot: ve.init.mw.DesktopArticleTarget: Fix the code to reorder tabs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381217 (https://phabricator.wikimedia.org/T50017) (owner: 10Bartosz Dziewoński) [15:54:50] (03CR) 10jenkins-bot: ve.init.mw.DesktopArticleTarget: Fix the code to reorder tabs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381217 (https://phabricator.wikimedia.org/T50017) (owner: 10Bartosz Dziewoński) [15:56:19] (03PS1) 10DLynch: ce.Surface: in observed selection changes, only make cursorable selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381235 (https://phabricator.wikimedia.org/T148679) [15:58:04] (03Abandoned) 10DLynch: LinearEnterKeyDownHandler: make sure the range is in a cursorable location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381033 (https://phabricator.wikimedia.org/T148679) (owner: 10DLynch) [16:02:19] (03CR) 10Esanders: "I think this should fixed upstream. We haven't had a case before where updateInvisibleIcon is called on a constructed invisible node, but " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378044 (owner: 10C. Scott Ananian) [16:10:06] 10VisualEditor, 10VisualEditor-ContentEditable, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10User-Ryasmeen, 10Verified: [Regression pre-wmf.1] The first letter of every line is disappearing while typing and getting appended at the end... - https://phabricator.wikimedia.org/T176762#3643515 [16:10:08] (03PS1) 10Esanders: Detach icon before updateInvisibleIcon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381239 [16:10:16] (03CR) 10Esanders: [C: 04-2] "See I45ceec9fe3" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/378044 (owner: 10C. Scott Ananian) [16:13:47] 10VisualEditor: Language conversion rule inspector is too complex, should be a dialog - https://phabricator.wikimedia.org/T176988#3643528 (10Esanders) [16:20:39] (03CR) 10Esanders: "Nice, I think this fixes T176936 too, but you should double check." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381235 (https://phabricator.wikimedia.org/T148679) (owner: 10DLynch) [16:23:58] (03CR) 10DLynch: "> Nice, I think this fixes T176936 too, but you should double check." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381235 (https://phabricator.wikimedia.org/T148679) (owner: 10DLynch) [16:24:21] (03PS2) 10DLynch: ce.Surface: in observed selection changes, only make cursorable selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381235 (https://phabricator.wikimedia.org/T148679) [16:28:33] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-Score: [Regression wmf.1] Context menu for Score extension (and nothing else?) are opening up in random positions - https://phabricator.wikimedia.org/T176766#3643612 (10Ryasmeen) It is actually happening for some other context menus as well suc... [16:32:25] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Caption stops displaying when you move an image - https://phabricator.wikimedia.org/T176918#3643624 (10Esanders) [16:32:28] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review, 10Regression: Block images lose captions when moved - https://phabricator.wikimedia.org/T176265#3643627 (10Esanders) [16:32:53] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Captions not showing when you insert an image - https://phabricator.wikimedia.org/T176917#3643631 (10Esanders) [16:32:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review, 10Regression: Block images lose captions when moved - https://phabricator.wikimedia.org/T176265#3619357 (10Esanders) [16:36:13] (03PS1) 10Esanders: Follow-up Iea80013: $attachable -> $bounding [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381244 [16:37:00] 10VisualEditor, 10Mobile-Content-Service, 10RESTBase, 10RESTBase-API, and 3 others: Support flagged revisions in RESTBase - https://phabricator.wikimedia.org/T169116#3387536 (10Tgr) On desktop, logged-in users will always be shown the latest revision of the page. (Well, it's subject to the page configurati... [16:37:07] (03PS1) 10Esanders: Follow-up Ia08dbb44: $attachable -> $bounding [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381245 [16:39:37] 10VisualEditor: [Regression pre wmf.2] There is some extra padding appearing on the inside of the link inspector. - https://phabricator.wikimedia.org/T176993#3643670 (10Ryasmeen) [16:52:52] Kemayo: I can still put the cursor to the left of a table in Chrome [16:53:03] (which I think I filed a bug about a year or two ago) [16:53:33] Hm, I guess my fix *is* only moving to the right. [16:54:28] I think the problem is it is allowing non-content offsets [16:54:59] Might be quickly fixed by trying the other direction in getNearestCursorOffset if no movement happened. [16:55:19] If I have a blank document with a table, it will put the cursor at [0,0] [16:56:02] also in some cases there won't be any movement [16:56:53] 10VisualEditor, 10VisualEditor-Media, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10User-Ryasmeen: Image inspector obscures caption - https://phabricator.wikimedia.org/T176646#3643738 (10Ryasmeen) 05Resolved>03Open hmm, I still see the context menu obscuring the caption on Beta and... [16:57:45] You could try getNearestContentOffset, and set to null if it returns -1 [16:57:45] My own chrome experience, with this patch, is that clicking to the left of a table does update the selection to being inside the first cell... but doesn't seem to actually *place* it there in practice. [16:58:12] You'd need to check it doesn't break anything with putting the cursor in focusable nodes [16:58:18] e.g. in the tables demo, clicking to the left of the first table gets it to offset 27, which is inside the "A" cell. [17:00:02] 10VisualEditor, 10VisualEditor-ContentEditable, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10User-Ryasmeen, and 2 others: [Regression pre-wmf.1] The first letter of every line is disappearing while typing and getting appended at the end... - https://phabricator.wikimedia.org/T176762#3643752 [17:07:45] (03CR) 10Jforrester: [C: 032] Detach icon before updateInvisibleIcon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381239 (owner: 10Esanders) [17:08:04] (03CR) 10Jforrester: [C: 032] Follow-up Iea80013: $attachable -> $bounding [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381244 (owner: 10Esanders) [17:08:52] (03CR) 10Jforrester: [C: 032] Follow-up Ia08dbb44: $attachable -> $bounding [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381245 (owner: 10Esanders) [17:12:32] 10VisualEditor, 10Graphs, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10User-Ryasmeen, and 2 others: "Uncaught Error: Inserted data is trying to close the root node (at index 0)" appears after closing the dialog for Graph and pressing re... - https://phabricator.wikimedia.org/T166134#3643801 [17:12:44] (03Merged) 10jenkins-bot: Detach icon before updateInvisibleIcon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381239 (owner: 10Esanders) [17:13:53] (03Merged) 10jenkins-bot: Follow-up Iea80013: $attachable -> $bounding [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381244 (owner: 10Esanders) [17:15:38] Kemayo: it would help if it didn't let you put the cursor in ce=false [17:16:43] (03Merged) 10jenkins-bot: Follow-up Ia08dbb44: $attachable -> $bounding [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381245 (owner: 10Esanders) [17:19:02] In chrome at least, it looks like clicking to the left puts the cursor to the left of the tag, so that should be fixable. [17:21:04] (03CR) 10jenkins-bot: Detach icon before updateInvisibleIcon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381239 (owner: 10Esanders) [17:22:53] (03CR) 10jenkins-bot: Follow-up Ia08dbb44: $attachable -> $bounding [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381245 (owner: 10Esanders) [17:23:31] (03CR) 10jenkins-bot: Follow-up Iea80013: $attachable -> $bounding [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381244 (owner: 10Esanders) [17:47:39] 10VisualEditor, 10Mobile-Content-Service, 10RESTBase, 10RESTBase-API, and 3 others: Support flagged revisions in RESTBase - https://phabricator.wikimedia.org/T169116#3643929 (10bearND) I would hold off merging and deploying this a bit longer until the following question is solved and agreed upon with clien... [17:55:09] (03PS1) 10Jforrester: Update VE core submodule to master (4fac129ce) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381269 (https://phabricator.wikimedia.org/T176636) [18:09:02] (03CR) 10Jforrester: [C: 031] ce.Surface: in observed selection changes, only make cursorable selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381235 (https://phabricator.wikimedia.org/T148679) (owner: 10DLynch) [18:36:41] 10VisualEditor, 10VisualEditor-Media, 10MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), 10User-Ryasmeen: Image inspector obscures caption - https://phabricator.wikimedia.org/T176646#3644114 (10Jdforrester-WMF) 05Open>03Resolved Fixed now in master. Whoops. [19:12:23] 10VisualEditor, 10Mobile-Content-Service, 10RESTBase, 10RESTBase-API, and 3 others: Support flagged revisions in RESTBase - https://phabricator.wikimedia.org/T169116#3644327 (10Tgr) > Not logged in desktop users get a new tab between Read and Edit, called "Pending changes". Clicking on the link reveals the... [19:25:12] 10VisualEditor: Disable adding between internal links - https://phabricator.wikimedia.org/T177015#3644407 (10Zoranzoki21) [21:02:24] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), 10User-Ryasmeen, 10VE-deploy-2013-05-13: VisualEditor: In RTL, the "Edit" tab appears down-tab (to the left) rather than up-tab (to the right) of "Edi... - https://phabricator.wikimedia.org/T50017#3644742 [21:02:59] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), 10User-Ryasmeen: Notifications showing greyed out in VE - https://phabricator.wikimedia.org/T176874#3644748 (10Jdforrester-WMF) [21:04:47] 10VisualEditor, 10Mobile-Content-Service, 10RESTBase, 10RESTBase-API, and 3 others: Support flagged revisions in RESTBase - https://phabricator.wikimedia.org/T169116#3644754 (10Tgr) Also worth noting that the stable version and the base revision of the stable version are not the same: template and file tra... [21:33:36] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Dragging an image to a new location caused it to disappear - https://phabricator.wikimedia.org/T176899#3644824 (10Whatamidoing-WMF) I can't reproduce it today. Also, the captions aren't disappearing today, either. Maybe it's been magically fixed? [21:35:04] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Community-Liaisons (Oct-Dec 2017): Make a list of wikis that will probably want to have enabled by default - https://phabricator.wikimedia.org/T160971#3644827 (10Whatamidoing-WMF) [21:35:18] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Wikimedia-Site-requests, 10Community-Liaisons (Oct-Dec 2017): Support wikis in converting reference lists over to `responsive` - https://phabricator.wikimedia.org/T159895#3644828 (10Whatamidoing-WMF) [21:35:23] 10VisualEditor, 10MediaWiki-Page-editing, 10Community-Liaisons (Oct-Dec 2017): CLs to communicate the Save/Publish change - https://phabricator.wikimedia.org/T134580#3644831 (10Whatamidoing-WMF) [21:49:15] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 10Design, 10Google-Code-In-2015: Consider removing the extra asterisk for the required parameters inside the template dialog - https://phabricator.wikimedia.org/T107544#3644872 (10Krinkle) @Duckworld I believe you have misunder... [21:54:58] 10VisualEditor, 10VisualEditor-Media, 10MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), 10User-Ryasmeen, 10Verified: Image inspector obscures caption - https://phabricator.wikimedia.org/T176646#3644906 (10Ryasmeen) [22:08:53] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor conflict with translate extension, unable to save even with minor change - https://phabricator.wikimedia.org/T177029#3644921 (10MusikAnimal) [22:10:40] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor conflict with translate extension, unable to save even with minor change - https://phabricator.wikimedia.org/T177029#3644934 (10MusikAnimal) [22:26:58] 10Cite, 10Easy, 10I18n, 10User-Ryasmeen, 10Voice & Tone: Cite: Error message for an empty reference should be more appropriate and helpful - https://phabricator.wikimedia.org/T59619#3644938 (10Ryasmeen) 05Open>03Resolved a:03Ryasmeen The VisualEditor does not any more allow adding empty reference,...