[06:44:02] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381727 (owner: 10L10n-bot) [10:26:06] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Design: Have Show preview and Review your changes more directly accessible in the New Wikitext Editor - https://phabricator.wikimedia.org/T153306#3650235 (10TheDJ) https://en.wikipedia.org/w/index.php?title=Wikipedia%3AVisualEditor%2FFeedback&typ... [15:09:17] (03PS1) 10Bartosz Dziewoński: ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381783 (https://phabricator.wikimedia.org/T177041) [15:22:36] (03PS1) 10Esanders: MWAlienExtensionNode: Listen to attribute changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381786 (https://phabricator.wikimedia.org/T177181) [15:23:07] (03PS2) 10Esanders: MWAlienExtensionNode: Listen to attribute changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381786 (https://phabricator.wikimedia.org/T177181) [15:30:06] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-General: Allow extensions providing XML-style tags to describe their parameters for VisualEditor - https://phabricator.wikimedia.org/T177184#3649581 (10Esanders) Given the amount of work it would take to build a dynamic form based on the input labels and... [15:30:57] (03PS1) 10Esanders: MWExtensionWindow: Always send a string to setValueAndWhitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381788 (https://phabricator.wikimedia.org/T177180) [15:40:47] (03PS1) 10Esanders: Follow-up Iea80013: Re-define this.$bounding after GCN re-render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381789 (https://phabricator.wikimedia.org/T176766) [15:47:08] (03CR) 10Zoranzoki21: [C: 031] "Looks good" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381789 (https://phabricator.wikimedia.org/T176766) (owner: 10Esanders) [16:07:01] (03PS1) 10Esanders: Allow extensions to use self closing tags [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381796 [16:21:14] (03CR) 10jerkins-bot: [V: 04-1] Allow extensions to use self closing tags [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381796 (owner: 10Esanders) [16:53:33] (03PS1) 10DLynch: ce.Surface: handle table-adjacent observed selection changes better [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381805 (https://phabricator.wikimedia.org/T148679) [17:14:31] (03CR) 10Jforrester: [C: 032] MWAlienExtensionNode: Listen to attribute changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381786 (https://phabricator.wikimedia.org/T177181) (owner: 10Esanders) [17:14:52] 10VisualEditor, 10VisualEditor-MediaWiki, 10User-Ryasmeen: VisualEditor XML-style extension tag editor widget does not listen to changes in parameter fields - https://phabricator.wikimedia.org/T177181#3651636 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03Esanders [17:15:25] 10VisualEditor, 10VisualEditor-MediaWiki, 10User-Ryasmeen: VisualEditor handles XML-style extension tags with no content incorrectly - https://phabricator.wikimedia.org/T177183#3651643 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03Esanders [17:16:39] 10VisualEditor, 10VisualEditor-ContentEditable: Clicking to the left of a table that is the first node in the document twice misplaces the cursor - https://phabricator.wikimedia.org/T177238#3651652 (10DLynch) [17:16:40] (03CR) 10Jforrester: [C: 032] MWExtensionWindow: Always send a string to setValueAndWhitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381788 (https://phabricator.wikimedia.org/T177180) (owner: 10Esanders) [17:17:21] 10VisualEditor, 10VisualEditor-MediaWiki, 10User-Ryasmeen: VisualEditor handling of self-closing XML-style extension tags is buggy (Cannot read property 'slice' of null) - https://phabricator.wikimedia.org/T177180#3651665 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03Esanders [17:22:46] (03CR) 10Jforrester: [C: 032] Follow-up Iea80013: Re-define this.$bounding after GCN re-render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381789 (https://phabricator.wikimedia.org/T176766) (owner: 10Esanders) [17:22:51] (03Merged) 10jenkins-bot: MWAlienExtensionNode: Listen to attribute changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381786 (https://phabricator.wikimedia.org/T177181) (owner: 10Esanders) [17:25:03] (03Merged) 10jenkins-bot: MWExtensionWindow: Always send a string to setValueAndWhitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381788 (https://phabricator.wikimedia.org/T177180) (owner: 10Esanders) [17:26:36] (03Merged) 10jenkins-bot: Follow-up Iea80013: Re-define this.$bounding after GCN re-render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381789 (https://phabricator.wikimedia.org/T176766) (owner: 10Esanders) [17:27:36] (03CR) 10jenkins-bot: MWAlienExtensionNode: Listen to attribute changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381786 (https://phabricator.wikimedia.org/T177181) (owner: 10Esanders) [17:29:42] (03CR) 10jenkins-bot: MWExtensionWindow: Always send a string to setValueAndWhitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381788 (https://phabricator.wikimedia.org/T177180) (owner: 10Esanders) [17:30:19] (03CR) 10jenkins-bot: Follow-up Iea80013: Re-define this.$bounding after GCN re-render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381789 (https://phabricator.wikimedia.org/T176766) (owner: 10Esanders) [17:32:55] (03CR) 10Jforrester: [C: 032] ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381783 (https://phabricator.wikimedia.org/T177041) (owner: 10Bartosz Dziewoński) [17:33:50] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Page-editing, 10User-Ryasmeen: After triggering edit conflict in VE, error about missing Unicode support is shown - https://phabricator.wikimedia.org/T177041#3651739 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03matmarex [17:44:47] (03Merged) 10jenkins-bot: ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381783 (https://phabricator.wikimedia.org/T177041) (owner: 10Bartosz Dziewoński) [17:45:57] 10VisualEditor, 10MediaWiki-General-or-Unknown: MediaWiki's feedback tool interface is confusing - https://phabricator.wikimedia.org/T100011#3651792 (10CKoerner_WMF) [17:51:16] (03CR) 10jenkins-bot: ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381783 (https://phabricator.wikimedia.org/T177041) (owner: 10Bartosz Dziewoński) [17:53:16] (03PS2) 10Jforrester: Allow MediaWiki extensions to use self closing tags [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381796 (owner: 10Esanders) [17:53:54] (03CR) 10Jforrester: [C: 032] "PS2: Doc quoting fix." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381796 (owner: 10Esanders) [17:54:09] 10VisualEditor, 10Modern: Visual editor does not work with Modern Skin - https://phabricator.wikimedia.org/T177243#3651806 (10AxelBoldt) [17:56:33] (03PS1) 10Jforrester: Update VE core submodule to master (cb52d8b7a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381814 (https://phabricator.wikimedia.org/T148679) [17:56:53] 10VisualEditor, 10Modern: Visual editor does not work with Modern Skin - https://phabricator.wikimedia.org/T177243#3651806 (10matmarex) The skin will probably need some changes to be compatble with VE. https://www.mediawiki.org/wiki/VisualEditor/Skin_requirements [18:04:09] (03Merged) 10jenkins-bot: Allow MediaWiki extensions to use self closing tags [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381796 (owner: 10Esanders) [18:07:42] (03PS1) 10Legoktm: ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission [extensions/VisualEditor] (REL1_30) - 10https://gerrit.wikimedia.org/r/381817 (https://phabricator.wikimedia.org/T177041) [18:08:39] (03CR) 10Jforrester: [C: 032] ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission [extensions/VisualEditor] (REL1_30) - 10https://gerrit.wikimedia.org/r/381817 (https://phabricator.wikimedia.org/T177041) (owner: 10Legoktm) [18:17:37] (03Merged) 10jenkins-bot: ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission [extensions/VisualEditor] (REL1_30) - 10https://gerrit.wikimedia.org/r/381817 (https://phabricator.wikimedia.org/T177041) (owner: 10Legoktm) [18:18:28] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10Contributors-Team, and 5 others: To help desktop users ensure pages look OK for mobile, let them "preview" how it will look as they edit on desktop, regardless of editor - https://phabricator.wikimedia.org/T119252#3651891 (10CKoerner_WMF) [18:34:36] (03CR) 10jenkins-bot: Allow MediaWiki extensions to use self closing tags [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381796 (owner: 10Esanders) [18:35:48] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: After checking the preview, the NWE appears one more plus (+) icon after the categories - https://phabricator.wikimedia.org/T170748#3651939 (10Tacsipacsi) I fixed it and pasted to P6066, and tested as I usually test such things, but that’s not so muc... [19:16:46] 10Editing-team, 10VisualEditor, 10Community-Liaisons (Jul-Sep 2017), 10User-Ryasmeen: Future of the visual editor newsletter - https://phabricator.wikimedia.org/T139305#3652055 (10Whatamidoing-WMF) We did something similar last time. https://meta.wikimedia.org/wiki/VisualEditor/Newsletter/2017/May#Future_... [19:17:43] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-extensions-WikimediaEvents, 10JavaScript, 10Performance: mw.track('counter.*') in statsd.js from WikimediaEvents seems to be having issues, breaking VE timing and mw-js-deprecate metrics - https://phabricator.wikimedia.org/T177250#3652056 (10Jdforres... [19:18:20] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-extensions-WikimediaEvents, 10Performance-Team: mw.track('counter.*') in statsd.js from WikimediaEvents seems to be having issues, breaking VE timing and mw-js-deprecate metrics - https://phabricator.wikimedia.org/T177250#3652068 (10Krinkle) [19:34:56] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-General: Allow extensions providing XML-style tags to describe their parameters for VisualEditor - https://phabricator.wikimedia.org/T177184#3652098 (10Jdforrester-WMF) 05Open>03declined Agreed. If you want your extension to work with VisualEditor, t... [20:17:41] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-General: Allow extensions providing XML-style tags to describe their parameters for VisualEditor - https://phabricator.wikimedia.org/T177184#3652175 (10Tgr) Is VisualEditor the only thing that uses TemplateData? It seems nice to have a generic way of des... [20:29:23] 10VisualEditor, 10Modern: Visual editor does not work with Modern Skin - https://phabricator.wikimedia.org/T177243#3652194 (10Esanders) p:05Triage>03Lowest [20:33:43] (03PS1) 10Jforrester: DesktopArticleTarget: Retain 'mwTarget' stats tracking object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381833 (https://phabricator.wikimedia.org/T177250) [20:33:54] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 10Performance-Team, 10Patch-For-Review: VisualEditor timing data broken by using a different target name in some circumstances - https://phabricator.wikimedia.org/T177250#3652216 (10Jdforrester-WMF) a:03Jdforrester-WMF [20:35:11] 10VisualEditor, 10VisualEditor-MediaWiki: Fix "JQMIGRATE: jQuery.fn.offset() requires an element connected to a document" from maybeShowMetaDialog - https://phabricator.wikimedia.org/T169393#3652226 (10matmarex) This may be a false warning, we should re-test after {T177252} is fixed. [20:35:15] 10VisualEditor, 10VisualEditor-MediaWiki: Fix "JQMIGRATE: jQuery.fn.offset() requires an element connected to a document" when saving - https://phabricator.wikimedia.org/T170366#3428838 (10matmarex) This may be a false warning, we should re-test after {T177252} is fixed. [20:47:26] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-General: Allow extensions providing XML-style tags to describe their parameters for VisualEditor - https://phabricator.wikimedia.org/T177184#3652240 (10Jdforrester-WMF) Note that there's {T54607} which we're planning to do (eventually). [20:48:37] (03CR) 10Esanders: [C: 032] DesktopArticleTarget: Retain 'mwTarget' stats tracking object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381833 (https://phabricator.wikimedia.org/T177250) (owner: 10Jforrester) [20:54:27] (03CR) 10Esanders: [C: 04-1] DesktopArticleTarget: Retain 'mwTarget' stats tracking object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381833 (https://phabricator.wikimedia.org/T177250) (owner: 10Jforrester) [20:57:32] (03CR) 10Esanders: [C: 04-1] DesktopArticleTarget: Retain 'mwTarget' stats tracking object (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381833 (https://phabricator.wikimedia.org/T177250) (owner: 10Jforrester) [21:03:14] (03PS2) 10Esanders: DesktopArticleTarget: Retain 'mwTarget' stats tracking object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381833 (https://phabricator.wikimedia.org/T177250) (owner: 10Jforrester) [21:03:21] (03CR) 10Esanders: [C: 032] DesktopArticleTarget: Retain 'mwTarget' stats tracking object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381833 (https://phabricator.wikimedia.org/T177250) (owner: 10Jforrester) [21:10:26] (03Merged) 10jenkins-bot: DesktopArticleTarget: Retain 'mwTarget' stats tracking object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381833 (https://phabricator.wikimedia.org/T177250) (owner: 10Jforrester) [21:12:50] (03PS1) 10Jforrester: DesktopArticleTarget: Retain 'mwTarget' stats tracking object [extensions/VisualEditor] (wmf/1.31.0-wmf.1) - 10https://gerrit.wikimedia.org/r/381878 (https://phabricator.wikimedia.org/T177250) [21:14:40] (03CR) 10jenkins-bot: DesktopArticleTarget: Retain 'mwTarget' stats tracking object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381833 (https://phabricator.wikimedia.org/T177250) (owner: 10Jforrester) [21:25:07] (03PS1) 10Esanders: Always use trackingName for tracking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381880 [21:27:38] (03CR) 10Jforrester: [C: 032] Always use trackingName for tracking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381880 (owner: 10Esanders) [21:36:12] (03Merged) 10jenkins-bot: Always use trackingName for tracking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381880 (owner: 10Esanders) [21:39:06] (03CR) 10jenkins-bot: Always use trackingName for tracking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/381880 (owner: 10Esanders) [22:33:21] (03PS1) 10Jforrester: Always use trackingName for tracking [extensions/VisualEditor] (wmf/1.31.0-wmf.1) - 10https://gerrit.wikimedia.org/r/381888 [23:02:24] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 10Patch-For-Review, 10Performance-Team (Radar): VisualEditor timing data broken by using a different target name in some circumstances - https://phabricator.wikimedia.org/T177250#3652537 (10Krinkle) [23:21:38] (03CR) 10Catrope: [C: 032] DesktopArticleTarget: Retain 'mwTarget' stats tracking object [extensions/VisualEditor] (wmf/1.31.0-wmf.1) - 10https://gerrit.wikimedia.org/r/381878 (https://phabricator.wikimedia.org/T177250) (owner: 10Jforrester) [23:21:40] (03CR) 10Catrope: [C: 032] Always use trackingName for tracking [extensions/VisualEditor] (wmf/1.31.0-wmf.1) - 10https://gerrit.wikimedia.org/r/381888 (owner: 10Jforrester) [23:30:39] (03Merged) 10jenkins-bot: DesktopArticleTarget: Retain 'mwTarget' stats tracking object [extensions/VisualEditor] (wmf/1.31.0-wmf.1) - 10https://gerrit.wikimedia.org/r/381878 (https://phabricator.wikimedia.org/T177250) (owner: 10Jforrester) [23:33:21] (03Merged) 10jenkins-bot: Always use trackingName for tracking [extensions/VisualEditor] (wmf/1.31.0-wmf.1) - 10https://gerrit.wikimedia.org/r/381888 (owner: 10Jforrester)