[00:01:54] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-CodeMirror, 10Community-Tech-Sprint: Selecting syntax-highlighted text in the 2017 source editor covers it completely when using Firefox - https://phabricator.wikimedia.org/T175223#3674313 (10kaldari) [00:44:44] 10VisualEditor, 10Contributors-Analysis: Generate statistics on recent beta feature rollout of 2017 wikitext editor - https://phabricator.wikimedia.org/T177597#3674354 (10Jdforrester-WMF) [00:49:44] 10VisualEditor, 10Contributors-Analysis: Generate statistics on recent beta feature rollout of 2017 wikitext editor - https://phabricator.wikimedia.org/T177597#3674355 (10Jdforrester-WMF) [00:59:08] 10VisualEditor, 10Contributors-Analysis: Generate statistics on recent beta feature rollout of 2017 wikitext editor - https://phabricator.wikimedia.org/T177597#3674362 (10Neil_P._Quinn_WMF) Thanks, James! Beat me to it :) [03:06:15] (03PS1) 10VolkerE: Align close colors to conform to WCAG level AA [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/383497 [03:38:44] 10VisualEditor: Interwiki with a colon inside ref tag are replaced by "wikipedia" - https://phabricator.wikimedia.org/T177784#3674487 (10Sunpriat2) 1. open https://ru.wikipedia.org/wiki/%D0%98%D0%BD%D0%BA%D1%83%D0%B1%D0%B0%D1%82%D0%BE%D1%80:%D0%9F%D0%B5%D1%81%D0%BE%D1%87%D0%BD%D0%B8%D1%86%D0%B0 2. edit in normal... [03:48:29] 10VisualEditor, 10Hindi-Sites: Publish Changes button not working some times on hindi wikipedia - https://phabricator.wikimedia.org/T177814#3674489 (10Capankajsmilyo) [03:54:35] 10VisualEditor, 10Hindi-Sites: Publish Changes button not working some times on hindi wikipedia - https://phabricator.wikimedia.org/T177814#3674508 (10Capankajsmilyo) [03:56:04] 10VisualEditor, 10Hindi-Sites: Publish Changes button not working some times on hindi wikipedia - https://phabricator.wikimedia.org/T177814#3671088 (10Capankajsmilyo) [05:36:44] (03PS1) 10Fomafix: Show invalidreason from API response on invalid title [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/383500 (https://phabricator.wikimedia.org/T99547) [05:38:33] (03CR) 10jerkins-bot: [V: 04-1] Show invalidreason from API response on invalid title [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/383500 (https://phabricator.wikimedia.org/T99547) (owner: 10Fomafix) [07:15:08] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-ContentHandler, 10MediaWiki-extensions-Translate, and 3 others: Changes made using NWE are blocked by Translate extension but copied into OWE they're accepted - https://phabricator.wikimedia.org/T154500#3674631 (10Nikerabbit) [07:15:10] 10VisualEditor: Interwiki with a colon inside ref tag are replaced by "wikipedia" - https://phabricator.wikimedia.org/T177784#3674632 (10Sunpriat2) p:05Low>03Triage [07:18:57] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-ContentHandler, 10MediaWiki-extensions-Translate, and 3 others: Changes made using NWE are blocked by Translate extension but copied into OWE they're accepted - https://phabricator.wikimedia.org/T154500#3674654 (10Arrbee) a:03Nikerab... [07:42:36] 10VisualEditor: VisualEditor says I have "2 notices" but only one is shown. - https://phabricator.wikimedia.org/T177822#3671516 (10Schnark) If your local edit message system is an outdated copy of enwiki's (or something similar), see T45013 and related tasks. [09:01:46] 10VisualEditor: VisualEditor says I have "2 notices" but only one is shown. - https://phabricator.wikimedia.org/T177822#3674814 (10Nikerabbit) >>! In T177822#3673070, @Deskana wrote: > What page is this on? It's https://dev.translatewiki.net/w/i.php?title=Vetest&veaction=editsource but it won't work for anyone... [09:21:03] (03PS2) 10Fomafix: Show invalidreason from API response on invalid title [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/383500 (https://phabricator.wikimedia.org/T99547) [09:46:19] 10VisualEditor, 10Community-Liaisons (Oct-Dec 2017): Second phase of centralisation of VE user feedback - https://phabricator.wikimedia.org/T162664#3674926 (10Elitre) [11:03:19] 10VisualEditor, 10Hindi-Sites: Publish Changes button not working some times on hindi wikipedia - https://phabricator.wikimedia.org/T177814#3675070 (10Deskana) @Capankajsmilyo Next time it happens, please open your browser console and tell us what errors are present. That's good information to have anyway, but... [11:11:19] 10VisualEditor, 10VisualEditor-MediaWiki: Occasional "docserver-http: HTTP 404" when trying to save an edit made in the visual editor - https://phabricator.wikimedia.org/T123708#3675076 (10Elitre) So... is this resolved? [11:16:12] 10VisualEditor, 10VisualEditor-MediaWiki, 10User-Ryasmeen: Occasional "docserver-http: HTTP 404" when trying to save an edit made in the visual editor - https://phabricator.wikimedia.org/T123708#3675079 (10Deskana) 05Open>03Resolved a:03DLynch >>! In T123708#3675076, @Elitre wrote: > So... is this reso... [11:19:16] 10VisualEditor, 10VisualEditor-EditingTools, 10Parsoid: Don't duplicate the contents of a footnote when you copy and paste it - https://phabricator.wikimedia.org/T122906#1916574 (10Deskana) I attempted to reproduce the bug and [[https://en.wikipedia.org/w/index.php?title=User:Whatamidoing_(WMF)/sandbox&diff=... [11:26:09] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-DataModel: data-ve-clipboard-key attribute added in wikitable - https://phabricator.wikimedia.org/T121588#1883127 (10Deskana) I went looking on the French Wikipedia. This issue, or something similar, still seems to be occurring, e.g. [[https://fr.wikip... [11:29:47] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-DataModel: data-ve-clipboard-key attribute added in wikitable - https://phabricator.wikimedia.org/T121588#3675119 (10Deskana) [11:29:49] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Media, 10VisualEditor-MediaWiki-Media: inserted into the page by a user edit to an image caption - https://phabricator.wikimedia.org/T163810#3675123 (10Deskana) [11:29:51] 10VisualEditor, 10VisualEditor-CopyPaste, 10MW-1.28-release (WMF-deploy-2016-05-10_(1.28.0-wmf.1)), 10Regression: [Regression] data-ve-clipboard-key span inserted in page - https://phabricator.wikimedia.org/T134680#3675122 (10Deskana) [11:33:29] 10VisualEditor: In Safari, the page title moves up and down while scrolling up in VE - https://phabricator.wikimedia.org/T169278#3675133 (10Deskana) [11:33:49] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid: Font size changes, and then the editor crashes - https://phabricator.wikimedia.org/T171616#3675134 (10Deskana) [11:35:54] 10VisualEditor, 10Collaboration-Team-Triage, 10StructuredDiscussions: The preview link for user page in the link dialog doesn't add local wiki domain prefix - https://phabricator.wikimedia.org/T165980#3675136 (10Deskana) [11:37:26] 10TemplateData, 10VisualEditor, 10User-Ryasmeen: In the TemplateData editor window shows an unnecessary horizontal scrollbar if a parameter has a long description - https://phabricator.wikimedia.org/T159602#3675139 (10Deskana) 05Open>03Resolved a:03Deskana I can't reproduce. I guess this was fixed. [12:02:55] 10VisualEditor, 10Hindi-Sites: Publish Changes button not working some times on hindi wikipedia - https://phabricator.wikimedia.org/T177814#3675203 (10Aklapper) p:05High>03Triage The second line of your output says: `at https://hi.wikipedia.org/w/load.php?debug=true&lang=en&modules=ext.gadget.defaultsumma... [12:24:44] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10User-Ryasmeen: Adding a citation manually causes it to be inserted at the top of the page, not where the cursor is, sometimes(?) - https://phabricator.wikimedia.org/T126437#3675231 (10Deskana) 05Open>03Resolved a:03Deskana I t... [12:31:11] (03CR) 10Esanders: [C: 032] ce.Surface: handle table-adjacent observed selection changes better [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381805 (https://phabricator.wikimedia.org/T148679) (owner: 10DLynch) [12:32:19] 10VisualEditor, 10VisualEditor-MediaWiki, 10User-Ryasmeen: Wikilinks in citation templates use the wrong basepath (/w/ not /wiki) when creating a new page in VE - https://phabricator.wikimedia.org/T144722#3675278 (10Deskana) 05Open>03Resolved a:03Deskana I can't reproduce. This appears to have been fix... [12:34:43] (03Merged) 10jenkins-bot: ce.Surface: handle table-adjacent observed selection changes better [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381805 (https://phabricator.wikimedia.org/T148679) (owner: 10DLynch) [12:35:10] 10VisualEditor, 10VisualEditor-MediaWiki: Wikitext diff and saving not the same as what has been edited (content loss) - https://phabricator.wikimedia.org/T159224#3675287 (10Deskana) 05Open>03stalled p:05Triage>03Normal [12:38:23] (03CR) 10jenkins-bot: ce.Surface: handle table-adjacent observed selection changes better [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/381805 (https://phabricator.wikimedia.org/T148679) (owner: 10DLynch) [13:01:04] 10VisualEditor, 10VisualEditor-DataModel, 10Parsoid, 10Patch-For-Review, 10User-Ryasmeen: Parsoid is generating [[Foo|Foo]] instead of [[Foo]] for some VE edits - https://phabricator.wikimedia.org/T153107#3675349 (10Elitre) What's the status of this task? [13:27:47] 10VisualEditor, 10Community-Liaisons (Oct-Dec 2017): Second phase of centralisation of VE user feedback - https://phabricator.wikimedia.org/T162664#3675562 (10Elitre) [13:48:23] 10Editing-team, 10MediaWiki-extensions-DynamicPageList, 10Performance: Address performance needs for Wikimedia from DynamicPageList extension so that it can be deployed to further wikis - https://phabricator.wikimedia.org/T124841#1967893 (10hashar) trwiktionary is asking for it. Given the size of the trwikt... [13:49:23] 10VisualEditor, 10Community-Liaisons (Oct-Dec 2017): Second phase of centralisation of VE user feedback - https://phabricator.wikimedia.org/T162664#3675658 (10Elitre) [13:59:49] 10TemplateData, 10VisualEditor, 10User-Ryasmeen: In the TemplateData editor window shows an unnecessary horizontal scrollbar if a parameter has a long description - https://phabricator.wikimedia.org/T159602#3675675 (10Amire80) Ack, looks OK. Thanks for testing and thanks to the mysterious person who fixed it :) [14:06:09] 10VisualEditor, 10VisualEditor-DataModel, 10Parsoid, 10Patch-For-Review, 10User-Ryasmeen: Parsoid is generating [[Foo|Foo]] instead of [[Foo]] for some VE edits - https://phabricator.wikimedia.org/T153107#3675699 (10Trizek-WMF) I didn't had time to make more edits that would have reproduced the issue. [15:17:07] 10Editing-team, 10VisualEditor, 10Wikimedia-Site-requests, 10Community-Liaisons (Jul-Sep 2017), and 3 others: Support WMF communities in run-up to switching EditPage over to OOUI - https://phabricator.wikimedia.org/T162849#3675957 (10matmarex) I've read older comments on this task again and it seems you po... [15:30:34] (03CR) 10Jforrester: [C: 032] "Nice." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/383500 (https://phabricator.wikimedia.org/T99547) (owner: 10Fomafix) [15:30:52] 10WikiEditor: Show reason for invalid titles in Link Dialog in WikiEditor - https://phabricator.wikimedia.org/T99547#3676043 (10Jdforrester-WMF) 05Open>03Resolved [15:33:27] (03Merged) 10jenkins-bot: Show invalidreason from API response on invalid title [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/383500 (https://phabricator.wikimedia.org/T99547) (owner: 10Fomafix) [15:53:07] 10VisualEditor, 10VisualEditor-MediaWiki, 10User-Ryasmeen: Occasional "docserver-http: HTTP 404" when trying to save an edit made in the visual editor - https://phabricator.wikimedia.org/T123708#3676093 (10Elitre) [16:03:42] 10Citoid, 10VisualEditor, 10User-Ryasmeen: Fix the automatic cite feature of VisualEditor in Sundanese Wikipedia - https://phabricator.wikimedia.org/T176571#3676138 (10Jdforrester-WMF) [16:46:47] 10VisualEditor, 10StructuredDiscussions, 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Regression: [minor] 'TypeError: Cannot read property 'model' of undefined' displayed on Flow pages when saving content with inspector open - https://phabricator.wikimedia.org/T166634#3676272 (10Catrope) [16:55:55] (03PS1) 10Jforrester: Update VE core submodule to master (e8188bac8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/383612 (https://phabricator.wikimedia.org/T148679) [17:01:59] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (e8188bac8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/383612 (https://phabricator.wikimedia.org/T148679) (owner: 10Jforrester) [17:04:14] 10VisualEditor, 10StructuredDiscussions, 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Regression: [minor] 'TypeError: Cannot read property 'model' of undefined' displayed on Flow pages when saving content with inspector open - https://phabricator.wikimedia.org/T166634#3676358 (10Catrope) U... [17:05:34] 10VisualEditor, 10StructuredDiscussions, 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Regression: [minor] 'TypeError: Cannot read property 'model' of undefined' displayed on Flow pages when saving content with inspector open - https://phabricator.wikimedia.org/T166634#3676363 (10Catrope) H... [17:09:30] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (e8188bac8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/383612 (https://phabricator.wikimedia.org/T148679) (owner: 10Jforrester) [17:10:53] 10VisualEditor, 10StructuredDiscussions, 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Regression: [minor] 'TypeError: Cannot read property 'model' of undefined' displayed on Flow pages when saving content with inspector open - https://phabricator.wikimedia.org/T166634#3676370 (10Catrope) S... [17:11:44] (03CR) 10Jforrester: [C: 032] "Eurgh, flaky tests." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/383612 (https://phabricator.wikimedia.org/T148679) (owner: 10Jforrester) [17:17:27] (03PS1) 10Esanders: Fix WikiEditor mode switcher widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/383614 [17:17:56] 10VisualEditor, 10StructuredDiscussions, 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Regression: [minor] 'TypeError: Cannot read property 'model' of undefined' displayed on Flow pages when saving content with inspector open - https://phabricator.wikimedia.org/T166634#3676415 (10Catrope) I... [17:18:24] (03Merged) 10jenkins-bot: Update VE core submodule to master (e8188bac8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/383612 (https://phabricator.wikimedia.org/T148679) (owner: 10Jforrester) [17:18:56] 10VisualEditor, 10StructuredDiscussions, 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Regression: [minor] 'TypeError: Cannot read property 'model' of undefined' displayed on Flow pages when saving content with inspector open - https://phabricator.wikimedia.org/T166634#3676421 (10Catrope) >... [17:20:30] (03CR) 10jenkins-bot: Update VE core submodule to master (e8188bac8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/383612 (https://phabricator.wikimedia.org/T148679) (owner: 10Jforrester) [17:21:32] 10VisualEditor, 10Collaboration-Team-Triage, 10StructuredDiscussions, 10Regression: [minor] 'TypeError: Cannot read property 'model' of undefined' displayed on Flow pages when saving content with inspector open - https://phabricator.wikimedia.org/T166634#3676428 (10Catrope) [17:24:42] (03CR) 10Jforrester: [C: 032] Fix WikiEditor mode switcher widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/383614 (owner: 10Esanders) [17:29:58] 10VisualEditor, 10Collaboration-Team-Triage, 10StructuredDiscussions, 10Regression: [minor] 'TypeError: Cannot read property 'model' of undefined' displayed on Flow pages when saving content with inspector open - https://phabricator.wikimedia.org/T166634#3676491 (10Catrope) >>! In T166634#3676415, @Catrop... [17:33:13] edsanders: So I've been investigating T166634 , and I found this code [17:33:13] T166634: [minor] 'TypeError: Cannot read property 'model' of undefined' displayed on Flow pages when saving content with inspector open - https://phabricator.wikimedia.org/T166634 [17:33:30] https://www.irccloud.com/pastebin/Dmw3hcOQ/ [17:33:39] (03Merged) 10jenkins-bot: Fix WikiEditor mode switcher widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/383614 (owner: 10Esanders) [17:33:44] I believe the setNullSelection() call will never do anything [17:34:12] Because at the time of that call the CE surface is still deactivated, and while that's true the DM surface will be disabled, and that will cause setSelection() to short-circuit and do nothing [17:34:30] The comment suggests it fixes a bug, so maybe it wasn't a no-op at the time it was introduced? [17:35:40] (03CR) 10jenkins-bot: Fix WikiEditor mode switcher widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/383614 (owner: 10Esanders) [17:37:05] (03PS1) 10Jforrester: Fix WikiEditor mode switcher widget [extensions/VisualEditor] (wmf/1.31.0-wmf.3) - 10https://gerrit.wikimedia.org/r/383618 [18:01:24] 10TemplateData, 10VisualEditor: Please strip leading spaces from the TemplateData GUI - https://phabricator.wikimedia.org/T177973#3676559 (10Whatamidoing-WMF) [18:06:50] Well it was a while ago: https://gerrit.wikimedia.org/r/#/c/229738/2 [18:10:00] RoanKattouw: Where does the model get disabled in #deactivate? All I see is the surfaceObserver getting disabled... [18:22:57] hi [18:23:26] do you work about integration of notes? those ones, which can be add by reference tags [18:38:45] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid, 10Patch-For-Review: Please put templates on separate lines (when it won't break things) and don't (when it will) - https://phabricator.wikimedia.org/T135667#3676744 (10Jdforrester-WMF) >>! In T135667#3613329, @Thryduulf wrote: > As T173... [19:04:15] ha you're right [19:04:46] Hmm good point, I wonder how it gets disabled [19:04:50] In my case it definitely is disabled [19:05:09] Maybe something calls disable on the ui.Surface [19:07:57] 10VisualEditor, 10Community-Liaisons (Oct-Dec 2017): Second phase of centralisation of VE user feedback - https://phabricator.wikimedia.org/T162664#3676934 (10Elitre) [19:13:47] 10Cite, 10MediaWiki-Internationalization, 10Parsoid, 10I18n, and 2 others: parser tags such as , , etc. cannot be localized - https://phabricator.wikimedia.org/T30980#3676971 (10Bawolff) [19:23:36] (03PS3) 10Esanders: Show visual diffs in wikitext mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365645 (https://phabricator.wikimedia.org/T170371) [19:25:15] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid, 10Patch-For-Review: Please put templates on separate lines (when it won't break things) and don't (when it will) - https://phabricator.wikimedia.org/T135667#3677073 (10Jdforrester-WMF) [19:25:17] 10TemplateData, 10VisualEditor, 10Patch-For-Review, 10User-Ryasmeen, 10User-notice: Add support for actual format strings to TemplateData's "format" parameter - https://phabricator.wikimedia.org/T138492#3677070 (10Jdforrester-WMF) 05Open>03Resolved This has been complete in TD for 10 months, and Pars... [19:30:24] 10Editing-team, 10MediaWiki-extensions-DynamicPageList, 10Performance: Address performance needs for Wikimedia from DynamicPageList extension so that it can be deployed to further wikis - https://phabricator.wikimedia.org/T124841#3677121 (10greg) For now, no, not until work is done on this. I don't want us t... [19:30:58] 10VisualEditor, 10VisualEditor-ContentEditable, 10MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), 10User-Ryasmeen: Uncaught Error: Inserted data is trying to close the root node (at index 0) appears when pressing returen after deselecting some... - https://phabricator.wikimedia.org/T148679#3677125 [19:31:46] (03PS4) 10Esanders: Show visual diffs in wikitext mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365645 (https://phabricator.wikimedia.org/T170371) [19:31:56] 10VisualEditor, 10VisualEditor-ContentEditable, 10MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), 10User-Ryasmeen: Clicking to the right of a table in Firefox puts the cursor inside the last the cell (but not in cell editing mode) - https://phabricator.wikimedia.org/T176936#3677131 (10Jdforres... [19:33:03] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), 10User-Ryasmeen: The keyboard shortcut for previewing a page (ctrl-option-p) doesn't do anything on some browsers - https://phabricator.wikimedia.org/T153959#3677140 (10Jdforrester-WM... [19:34:08] (03PS2) 10Jforrester: build: Drop all Ruby-related CI files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361929 [19:36:54] 10Cite, 10Patch-For-Review: Nulls passed to preg_match in Cite - https://phabricator.wikimedia.org/T177134#3677152 (10Umherirrender) 05Open>03Resolved p:05Triage>03Normal a:03alex-mashin [19:52:02] (03CR) 10jerkins-bot: [V: 04-1] build: Drop all Ruby-related CI files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361929 (owner: 10Jforrester) [19:56:12] (03CR) 10Tchanders: "Perhaps not the biggest deal in the world, but I'm getting a scrollbar on the visual diff in new wikitext editor mode that you don't get i" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365645 (https://phabricator.wikimedia.org/T170371) (owner: 10Esanders) [20:02:52] (03CR) 10Esanders: "On investigation it looks like that's a side effect of the over-tall footer when two buttons are in there. I should file a bug for that..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365645 (https://phabricator.wikimedia.org/T170371) (owner: 10Esanders) [20:06:47] (03CR) 10Tchanders: [C: 032] Show visual diffs in wikitext mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365645 (https://phabricator.wikimedia.org/T170371) (owner: 10Esanders) [20:08:27] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10OOjs-UI: Save dialog footer is wrong size after showing diff in NWE - https://phabricator.wikimedia.org/T177995#3677309 (10Esanders) [20:12:50] (03Merged) 10jenkins-bot: Show visual diffs in wikitext mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365645 (https://phabricator.wikimedia.org/T170371) (owner: 10Esanders) [20:14:48] (03CR) 10jenkins-bot: Show visual diffs in wikitext mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365645 (https://phabricator.wikimedia.org/T170371) (owner: 10Esanders) [20:14:55] 10WikiEditor, 10MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)): Show reason for invalid titles in Link Dialog in WikiEditor - https://phabricator.wikimedia.org/T99547#3677348 (10Fomafix) a:03Fomafix [20:21:57] 10Editing-team, 10MediaWiki-extensions-DynamicPageList, 10Performance: Address performance needs for Wikimedia from DynamicPageList extension so that it can be deployed to further wikis - https://phabricator.wikimedia.org/T124841#3677416 (10Bawolff) > I'd be happy to see a volunteer take this on, though I no... [20:24:23] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid, and 2 others: Please put templates on separate lines (when it won't break things) and don't (when it will) - https://phabricator.wikimedia.org/T135667#3677438 (10Deskana) 05Open>03Resolved a:03Deskana Thanks @Jdforrester-WMF! [20:26:17] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor-VisualDiffs, 10Epic, and 2 others: Allow reviewing your changes as visual diff in NWE - https://phabricator.wikimedia.org/T170371#3677445 (10Deskana) 05Open>03Resolved a:03Esanders [20:27:29] (03PS1) 10Esanders: requestParsoidData: Support 'wikitext' param in RESTBase-less environment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/383664 [20:32:24] edsanders: Aha, I found it. LinkAnnotationInspector#getSetupProcess disables the dm.Surface [20:32:42] So I guess this comes down to closing inspectors before trying to destroy the surface [20:39:19] Oh but then ReadyProcess enables it again [20:39:27] The real disable comes from the Flow target class [21:00:18] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor-VisualDiffs, 10Epic, and 2 others: Allow reviewing your changes as visual diff in NWE - https://phabricator.wikimedia.org/T170371#3677585 (10Deskana) [21:04:24] Alright I got it [21:04:30] There were two bugs, one in Flow and one in VE core [21:05:03] The Flow bug was that we destroyed the EditorWidget before popPending() was called on it, and that widget disables the editor while it's pending [21:05:40] The VE core bug was that ve.ce.Surface#destroy calls this.blur() , but does so after disconnecting model events, so when the selection is updated to a null selection, the view's selection doesn't mirror that [21:10:26] 10VisualEditor, 10VisualEditor-Tables: Misalignment regarding table cell lines - https://phabricator.wikimedia.org/T178005#3677605 (10Neve-selbert) [21:11:35] 10VisualEditor, 10VisualEditor-Tables: Misalignment regarding table cell lines - https://phabricator.wikimedia.org/T178005#3677621 (10Neve-selbert) p:05Triage>03High a:03Bazj [21:18:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/383700 (owner: 10L10n-bot) [21:29:32] 10Editing-team, 10MediaWiki-extensions-DynamicPageList, 10Performance: Address performance needs for Wikimedia from DynamicPageList extension so that it can be deployed to further wikis - https://phabricator.wikimedia.org/T124841#3677671 (10greg) >>! In T124841#3677618, @gerritbot wrote: > Change 383694 had... [21:30:43] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: TemplateData: Be able to specify a "no parameters accepted" definition - https://phabricator.wikimedia.org/T64417#3677674 (10Deskana) p:05High>03Normal [21:31:38] 10VisualEditor, 10VisualEditor-EditingTools, 10Parsoid, 10User-Ryasmeen: Don't duplicate the contents of a footnote when you copy and paste it - https://phabricator.wikimedia.org/T122906#3677677 (10Deskana) 05Open>03Resolved a:03Deskana >>! In T122906#3675090, @Deskana wrote: > It seems this bug was... [21:38:14] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 10MW-1.28-release (WMF-deploy-2016-05-10_(1.28.0-wmf.1)), 10Performance: Multi-part transclusion dialog a little slow to load - https://phabricator.wikimedia.org/T134814#3677697 (10Deskana) p:05High>03Normal [21:40:28] 10VisualEditor: Resize an image floating close to a list moves the bullets - https://phabricator.wikimedia.org/T175237#3677717 (10Deskana) [21:40:47] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-General-or-Unknown: Unknown problem with 2017 wikitext editor - https://phabricator.wikimedia.org/T176073#3677718 (10Deskana) [21:41:12] 10VisualEditor, 10VisualEditor-ContentEditable, 10Browser-Support-Firefox: Can't use the arrow keys to select back-to-back refs in Firefox - https://phabricator.wikimedia.org/T169353#3677719 (10Deskana) [21:46:40] 10VisualEditor, 10VisualEditor-MediaWiki: When deleting revisions, 2017 wikitext editor and VisualEditor load when they shouldn't, although the revision deletion works as expected - https://phabricator.wikimedia.org/T168533#3677730 (10Deskana) [21:48:15] 10VisualEditor, 10VisualEditor-MediaWiki: When deleting revisions, 2017 wikitext editor and VisualEditor load when they shouldn't, although the revision deletion works as expected - https://phabricator.wikimedia.org/T168533#3367580 (10Deskana) This doesn't actually block the hiding of the revision; the editor... [21:49:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10Documentation: Document hooks fired by VE via mw.hook - https://phabricator.wikimedia.org/T162337#3677737 (10Deskana) [22:32:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 10MW-1.28-release (WMF-deploy-2016-05-10_(1.28.0-wmf.1)), 10Performance: Multi-part transclusion dialog a little slow to load - https://phabricator.wikimedia.org/T134814#3677903 (10Akoopal) The example I provided, https://nl.wi... [22:41:24] 10VisualEditor: Interwiki with a colon inside ref tag are replaced by "wikipedia" - https://phabricator.wikimedia.org/T177784#3669943 (10ssastry) This is a Parsoid problem. ``` [subbu@earth parsoid] echo 'Robe... [23:04:15] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/VisualEditor] (wmf/1.31.0-wmf.3) - 10https://gerrit.wikimedia.org/r/383618 (owner: 10Jforrester) [23:17:07] (03Merged) 10jenkins-bot: Fix WikiEditor mode switcher widget [extensions/VisualEditor] (wmf/1.31.0-wmf.3) - 10https://gerrit.wikimedia.org/r/383618 (owner: 10Jforrester) [23:30:16] (03PS1) 10Catrope: ve.ce.Surface: When destroying, blur before disconnecting model events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/383732 (https://phabricator.wikimedia.org/T166634)