[01:24:00] That joyous experience when you spend forever going over and over your patch, trying to work out how it caused a certain breakage... then finally realize that you've just found a pre-existing bug, which is nothing to do with your changes. [01:37:14] Kemayo: Bugs? We have no bugs! [01:41:37] We prefer the term "unintentional opportunities for community engagement and involvement in the development process". [01:47:28] In this case: pressing enter in a sub-list which contains only one (empty) item. It's supposed to remove the sub-list entirely, but it only partially does, and throws the cursor to the start of the document. [05:04:30] (03PS9) 10Divec: RebaseServer persistent storage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334995 (https://phabricator.wikimedia.org/T152464) [05:08:00] (03CR) 10jerkins-bot: [V: 04-1] RebaseServer persistent storage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334995 (https://phabricator.wikimedia.org/T152464) (owner: 10Divec) [05:14:54] (03PS10) 10Divec: RebaseServer persistent storage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334995 (https://phabricator.wikimedia.org/T152464) [08:17:00] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Community-Liaisons: Help some smaller Wikipedias' communities by writing the TemplateData and enabling citoid for them - https://phabricator.wikimedia.org/T127354#3705672 (10Mvolz) [08:17:03] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Community-Liaisons, 10User-Ryasmeen: Assist Wikiversity in enabling Citoid - https://phabricator.wikimedia.org/T178796#3705669 (10Mvolz) 05Open>03Resolved a:03Mvolz [11:05:11] 10VisualEditor: "Replace" (in Search and Replace) doesn't scroll the page - https://phabricator.wikimedia.org/T177514#3706011 (10Deskana) p:05Triage>03Normal That's odd. [11:12:57] 10VisualEditor, 10Community-Liaisons (Oct-Dec 2017): Second phase of centralisation of VE user feedback - https://phabricator.wikimedia.org/T162664#3706017 (10Elitre) Ok, today is the day. Going to proceed. [13:02:36] 10VisualEditor: "Replace" (in Search and Replace) doesn't scroll the page - https://phabricator.wikimedia.org/T177514#3706373 (10Deskana) a:03Deskana [13:04:23] (03PS1) 10Deskana: Scroll to the next highlight after find and replace has replaced text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386171 (https://phabricator.wikimedia.org/T177514) [13:05:54] (03CR) 10Deskana: "Typo in the comment I added. FML." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386171 (https://phabricator.wikimedia.org/T177514) (owner: 10Deskana) [13:06:03] (03PS2) 10Deskana: Scroll to the next highlight after find and replace has replaced text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386171 (https://phabricator.wikimedia.org/T177514) [13:07:51] (03CR) 10jerkins-bot: [V: 04-1] Scroll to the next highlight after find and replace has replaced text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386171 (https://phabricator.wikimedia.org/T177514) (owner: 10Deskana) [13:13:11] (03PS3) 10Deskana: Scroll to the next highlight after find and replace has replaced text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386171 (https://phabricator.wikimedia.org/T177514) [13:44:57] 10VisualEditor, 10Community-Liaisons (Oct-Dec 2017): Second phase of centralisation of VE user feedback - https://phabricator.wikimedia.org/T162664#3706442 (10Elitre) Ok. The feedback pages were/are in the process of being redirected, and the internal feedback tool can be redirected to mw.org as well, for the... [14:51:59] (03CR) 10Esanders: [C: 032] build: Bump various devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386049 (owner: 10Jforrester) [14:52:12] (03CR) 10Esanders: [C: 032] build: Bump unit test-related devDependencies [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386050 (owner: 10Jforrester) [14:55:13] (03Merged) 10jenkins-bot: build: Bump various devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386049 (owner: 10Jforrester) [14:55:53] (03Merged) 10jenkins-bot: build: Bump unit test-related devDependencies [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386050 (owner: 10Jforrester) [14:57:31] (03CR) 10jenkins-bot: build: Bump various devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386049 (owner: 10Jforrester) [14:59:37] (03CR) 10jenkins-bot: build: Bump unit test-related devDependencies [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386050 (owner: 10Jforrester) [15:11:57] (03PS2) 10Jforrester: Update VE core submodule to master (4d8f80c6c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/386047 [15:19:19] (03CR) 10Esanders: [C: 04-1] "Looks about right, minor fix" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386171 (https://phabricator.wikimedia.org/T177514) (owner: 10Deskana) [15:32:17] (03PS1) 10Esanders: Depend on new mediawiki.editfont.styles module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/386204 [15:38:07] (03CR) 10jerkins-bot: [V: 04-1] Depend on new mediawiki.editfont.styles module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/386204 (owner: 10Esanders) [15:46:16] 10VisualEditor, 10Community-Liaisons: Change in-editor feedback tool to point to mediawiki.org - https://phabricator.wikimedia.org/T168886#3706978 (10Elitre) [15:47:35] 10VisualEditor, 10Community-Liaisons: Change in-editor feedback tool to point to mediawiki.org - https://phabricator.wikimedia.org/T168886#3379560 (10Elitre) Dan, I've made this more general now. Please assign to whoever can make this happen. I don't have an opinion about en.wp - I think when we discussed we s... [15:48:20] 10VisualEditor, 10Community-Liaisons (Oct-Dec 2017), 10User-Ryasmeen: Second phase of centralisation of VE user feedback - https://phabricator.wikimedia.org/T162664#3706980 (10Elitre) 05Open>03Resolved So the technical part of this will go through T168886 . [15:57:43] (03PS4) 10Deskana: Scroll to the next highlight after find and replace has replaced text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386171 (https://phabricator.wikimedia.org/T177514) [15:58:12] (03CR) 10Deskana: "@Esanders Updated per feedback. Thanks!" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386171 (https://phabricator.wikimedia.org/T177514) (owner: 10Deskana) [16:14:40] 10VisualEditor, 10Community-Liaisons: Change in-editor feedback tool to point to mediawiki.org - https://phabricator.wikimedia.org/T168886#3707061 (10Deskana) @Elitre Some of these wikis already point to mediawiki.org, namely: * ilo * he * mr The rest do not, and those can be changed. [16:23:18] 10VisualEditor, 10Community-Liaisons: Change in-editor feedback tool to point to mediawiki.org - https://phabricator.wikimedia.org/T168886#3707098 (10Deskana) a:03Deskana [17:02:41] 10VisualEditor, 10Operations, 10Parsoid, 10Traffic, 10HTTPS: Parsoid, VisualEditor not working with SSL / HTTPS - https://phabricator.wikimedia.org/T178778#3702250 (10Deskana) >>! In T178778#3702293, @PlanetKrypton wrote: > This appears to be the response / request and it's accompanying error > > https:... [17:09:57] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Tables, 10MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), and 2 others: Alien nodes trigger the table linear context - https://phabricator.wikimedia.org/T167150#3707389 (10Jdforrester-WMF) 05Open>03Resolved Whoops, long-Resolved. [17:52:35] 10VisualEditor, 10Operations, 10Parsoid, 10Traffic, 10HTTPS: Parsoid, VisualEditor not working with SSL / HTTPS - https://phabricator.wikimedia.org/T178778#3707527 (10PlanetKrypton) @Deskana I had plugin temporarily disabled so people didn't try to use it. Try now. [18:16:13] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Images shown in the link tool are very short and wide at cswiki - https://phabricator.wikimedia.org/T178933#3707600 (10Whatamidoing-WMF) [18:36:14] (03CR) 10Krinkle: [C: 032] build: Bump devDependencies to latest and make pass [unicodejs] - 10https://gerrit.wikimedia.org/r/386109 (owner: 10Jforrester) [18:36:40] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Images shown in the link tool are very short and wide at cswiki - https://phabricator.wikimedia.org/T178933#3707710 (10Deskana) p:05Triage>03Normal How peculiar. It's even doing it for placeholder images. @matmarex Some kind of OOUI regression? {F10416314} [18:37:48] (03Merged) 10jenkins-bot: build: Bump devDependencies to latest and make pass [unicodejs] - 10https://gerrit.wikimedia.org/r/386109 (owner: 10Jforrester) [18:42:26] 10VisualEditor, 10VisualEditor-MediaWiki-References: Two refs unexpectedly disappeared while editing - https://phabricator.wikimedia.org/T178781#3707722 (10Deskana) p:05Triage>03High This is a data loss issue, so needs investigation to make sure it's not a symptom of a much larger problem. Things like thi... [18:42:32] 10VisualEditor, 10VisualEditor-MediaWiki-References: Two refs unexpectedly disappeared while editing - https://phabricator.wikimedia.org/T178781#3707727 (10Deskana) [18:44:36] 10VisualEditor, 10VisualEditor-Performance, 10Performance: Use passive events where appropriate - https://phabricator.wikimedia.org/T178371#3707733 (10Deskana) p:05Triage>03Normal [18:46:33] 10VisualEditor: Improve preformated text format for multi-lines usage - https://phabricator.wikimedia.org/T157538#3707757 (10Deskana) [18:46:35] 10VisualEditor: Can't get multiple lines in a Preformatted paragraph - https://phabricator.wikimedia.org/T178178#3707759 (10Deskana) [18:47:17] 10TemplateData, 10VisualEditor, 10Easy: Please strip leading spaces from the TemplateData GUI - https://phabricator.wikimedia.org/T177973#3707763 (10Deskana) p:05Triage>03Low [18:48:34] 10VisualEditor, 10VisualEditor-ContentEditable: Clicking to the left of a table that is the first node in the document twice misplaces the cursor - https://phabricator.wikimedia.org/T177238#3707771 (10Deskana) p:05Triage>03Normal [18:50:31] 10VisualEditor, 10VisualEditor-ContentEditable, 10Browser-Support-Internet-Explorer: Shift+Up doesn't work in IE11 - https://phabricator.wikimedia.org/T177061#3707777 (10Deskana) p:05Triage>03Normal [18:57:48] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Images shown in the link tool are very short and wide at cswiki - https://phabricator.wikimedia.org/T178933#3707798 (10Deskana) p:05Normal>03Unbreak! This is happening everywhere. The screenshot below is from English Wikipedia. {F10416406} [19:02:21] edsanders Kemayo UBN issue ^ [19:03:08] Deskana: I’m out eating lunch right now. I’ll look at it as soon as I’m by a computer again. [19:03:29] Kemayo: Thanks. It can wait until the end of your lunch. :-) [19:42:41] (03CR) 10jenkins-bot: build: Bump devDependencies to latest and make pass [unicodejs] - 10https://gerrit.wikimedia.org/r/386109 (owner: 10Jforrester) [19:45:55] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/386047 (owner: 10Jforrester) [19:55:13] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Images shown in the link tool are very short and wide at cswiki - https://phabricator.wikimedia.org/T178933#3707600 (10DLynch) I //think// this is further fallout from 8e31b2f27342f7fe3aa188412e719bf86249d08f. [19:56:02] Okay, I **think** it's another problem from Volker_E 's change to OOUI icon stuff. MatmaRex already has a patch up reverting that because it caused another issue as well: https://gerrit.wikimedia.org/r/#/c/385236/ [20:29:22] 10VisualEditor, 10Contributors-Analysis, 10Contributors-Team, 10User-Ryasmeen: Define metrics for the VisualEditor team - https://phabricator.wikimedia.org/T107351#3708159 (10Neil_P._Quinn_WMF) 05Open>03Resolved [20:36:03] James_F: Got an opinion on doing a new OOUI release with that icons change reverted, versus patching up things in MWInternalLinkContextItem.css? [21:12:12] (03PS1) 10DLynch: MWInternalLinkContextItem: increase specificity to override OOUI changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/386286 (https://phabricator.wikimedia.org/T178933) [21:13:07] Deskana: ^ That fixes it. [21:15:48] Kemayo: Local fix for now, yeaeh. [21:15:50] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10Patch-For-Review: Images shown in the link tool are very short and wide at cswiki - https://phabricator.wikimedia.org/T178933#3708246 (10DLynch) To confirm, I did some testing of OOUI releases, and that icons commit does seem to have been the cause after all.... [21:28:04] And now... back to unit testing LinearEnterKeyDownHandler. [21:46:10] (03CR) 10Jforrester: [C: 031] Scroll to the next highlight after find and replace has replaced text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386171 (https://phabricator.wikimedia.org/T177514) (owner: 10Deskana) [21:47:13] (03CR) 10Jforrester: [C: 032] MWInternalLinkContextItem: increase specificity to override OOUI changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/386286 (https://phabricator.wikimedia.org/T178933) (owner: 10DLynch) [21:52:26] (03PS6) 10Jforrester: tests: Align setup/teardown function naming with QUnit 2.x [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365682 (https://phabricator.wikimedia.org/T170872) [21:52:56] (03Merged) 10jenkins-bot: MWInternalLinkContextItem: increase specificity to override OOUI changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/386286 (https://phabricator.wikimedia.org/T178933) (owner: 10DLynch) [21:54:43] (03PS1) 10Jforrester: MWInternalLinkContextItem: increase specificity to override OOUI changes [extensions/VisualEditor] (wmf/1.31.0-wmf.5) - 10https://gerrit.wikimedia.org/r/386308 (https://phabricator.wikimedia.org/T178933) [21:54:54] (03PS1) 10Jforrester: MWInternalLinkContextItem: increase specificity to override OOUI changes [extensions/VisualEditor] (wmf/1.31.0-wmf.4) - 10https://gerrit.wikimedia.org/r/386309 (https://phabricator.wikimedia.org/T178933) [21:56:14] (03CR) 10jenkins-bot: MWInternalLinkContextItem: increase specificity to override OOUI changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/386286 (https://phabricator.wikimedia.org/T178933) (owner: 10DLynch) [21:56:41] (03PS7) 10Jforrester: tests: Align setup/teardown function naming with QUnit 2.x [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365682 (https://phabricator.wikimedia.org/T170872) [22:04:47] (03CR) 10jerkins-bot: [V: 04-1] tests: Align setup/teardown function naming with QUnit 2.x [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/365682 (https://phabricator.wikimedia.org/T170872) (owner: 10Jforrester) [22:40:51] (03CR) 10Esanders: [C: 032] Scroll to the next highlight after find and replace has replaced text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386171 (https://phabricator.wikimedia.org/T177514) (owner: 10Deskana) [22:45:50] (03Merged) 10jenkins-bot: Scroll to the next highlight after find and replace has replaced text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386171 (https://phabricator.wikimedia.org/T177514) (owner: 10Deskana) [22:50:39] (03CR) 10jenkins-bot: Scroll to the next highlight after find and replace has replaced text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386171 (https://phabricator.wikimedia.org/T177514) (owner: 10Deskana)