[08:24:01] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/390957 (owner: 10L10n-bot) [08:46:43] 10TemplateData, 10VisualEditor, 10Accessibility: Access "Add more information" link when inserting a template using keyboard only is very long and ultimately doesn't work - https://phabricator.wikimedia.org/T179136#3753800 (10Trizek-WMF) >>! In T179136#3752092, @Whatamidoing-WMF wrote: > Some of the tab-orde... [12:44:35] (03CR) 10Bartosz Dziewoński: [C: 032] Add mw-parser-output to preview elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/390417 (https://phabricator.wikimedia.org/T180214) (owner: 10Esanders) [12:47:14] (03PS3) 10Bartosz Dziewoński: build: Drop all Ruby-related CI files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361929 (owner: 10Jforrester) [12:55:25] (03Merged) 10jenkins-bot: Add mw-parser-output to preview elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/390417 (https://phabricator.wikimedia.org/T180214) (owner: 10Esanders) [12:55:46] (03CR) 10jerkins-bot: [V: 04-1] build: Drop all Ruby-related CI files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361929 (owner: 10Jforrester) [12:57:56] (03CR) 10jenkins-bot: Add mw-parser-output to preview elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/390417 (https://phabricator.wikimedia.org/T180214) (owner: 10Esanders) [13:03:51] (03PS1) 10Esanders: Use versioned URLs for data, instead of latest [unicodejs] - 10https://gerrit.wikimedia.org/r/390986 [13:03:53] (03PS1) 10Esanders: Build automated wordbreak tests from official test data [unicodejs] - 10https://gerrit.wikimedia.org/r/390987 [13:20:50] (03PS3) 10Esanders: Update to Unicode 9.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/348975 (owner: 10Jforrester) [13:20:52] (03PS2) 10Esanders: Update to Unicode 10.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/390022 (owner: 10Jforrester) [14:23:57] (03PS2) 10Esanders: Build automated wordbreak tests from official test data [unicodejs] - 10https://gerrit.wikimedia.org/r/390987 [14:23:59] (03PS4) 10Esanders: Update to Unicode 9.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/348975 (owner: 10Jforrester) [14:24:01] (03PS3) 10Esanders: Update to Unicode 10.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/390022 (owner: 10Jforrester) [15:01:51] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Insert images, lose citations? - https://phabricator.wikimedia.org/T133475#2232819 (10Elitre) Should we close this one? [15:04:25] 10Citoid, 10VisualEditor, 10VisualEditor-EditingTools: Consider auto-inserting citations - https://phabricator.wikimedia.org/T173437#3754937 (10Elitre) I think this is also what https://meta.wikimedia.org/wiki/2017_Community_Wishlist_Survey/Editing/VisualEditor:_Allow_editing_of_auto-generated_references_bef... [15:21:42] 10VisualEditor: Add certain templates and try to create a link on it results in link+template - https://phabricator.wikimedia.org/T180354#3755064 (10Trizek-WMF) [15:22:18] 10VisualEditor: Add certain templates and try to create a link on it results in link+template - https://phabricator.wikimedia.org/T180354#3755090 (10Trizek-WMF) [15:35:57] 10VisualEditor: Some navigation text shows as variable names - https://phabricator.wikimedia.org/T180358#3755158 (10njnatale_lmco) [15:43:31] 10Citoid, 10VisualEditor, 10MediaWiki-Documentation, 10Documentation, and 2 others: Update citoid image in documentation - https://phabricator.wikimedia.org/T180363#3755228 (10Mvolz) [15:45:21] 10Cite, 10TCB-Team, 10WMDE-Design, 10Design: Error handling for "extends" parameter - https://phabricator.wikimedia.org/T151305#3755247 (10Jan_Dittrich) @Lea_WMDE shall we build this on the existing solution as shown above? Or did you have something else in mind with "Error Message"? [16:07:06] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), 10User-Ryasmeen: Numbered external links not visible in preview in NWE - https://phabricator.wikimedia.org/T180214#3755350 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03Esanders [16:07:29] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), 10User-Ryasmeen: Link to action=edit of a specific revision shows current revision in VE - https://phabricator.wikimedia.org/T179994#3755358 (10Jdforrester-WMF) 05Open>03Resolved [16:08:42] 10VisualEditor, 10VisualEditor-ContentEditable, 10Patch-For-Review: List editing exception: TypeError: Cannot read property 'getSurface' of null - https://phabricator.wikimedia.org/T179574#3755378 (10Jdforrester-WMF) a:03DLynch [16:10:52] 10VisualEditor, 10Contributors-Team, 10MediaWiki-Page-editing, 10MediaWiki-extensions-FlaggedRevs, 10Patch-For-Review: FlaggedRev's over-ride of the submit button's label via the EditPageBeforeEditButtons PHP hook doesn't work for any other code (mobile a... - https://phabricator.wikimedia.org/T179326#3755407 [16:43:24] 10Citoid, 10VisualEditor, 10VisualEditor-EditingTools: Insert citations automatically after generating and show citation to edit it afterwards - https://phabricator.wikimedia.org/T173437#3755520 (10SoWhy) [17:03:41] 10VisualEditor: Some VE system message keys shown after MW upgrade - https://phabricator.wikimedia.org/T180358#3755606 (10Aklapper) [17:04:05] 10VisualEditor: Some VE system message keys shown after MW upgrade - https://phabricator.wikimedia.org/T180358#3755158 (10Aklapper) If you go to `Special:AllMessages`, what messages are displayed for those message keys? [17:25:42] 10Citoid, 10VisualEditor, 10MediaWiki-Documentation, 10Documentation, and 2 others: Update citoid image in documentation - https://phabricator.wikimedia.org/T180363#3755228 (10Esanders) I've updated it to use the LanguageScreenshotBot generated one, so it will also get localised. We should add the manual t... [17:33:43] 10VisualEditor: Some VE system message keys shown after MW upgrade - https://phabricator.wikimedia.org/T180358#3755722 (10njnatale_lmco) @Aklapper - I searched for both, and I'm not seeing either show up in the list of results returned. Here's what I see now after searching for "Visualeditor-mweditmode" {F10767... [17:40:39] (03PS1) 10Esanders: Add screenshot tasks for manual and re-use tabs in Citoid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/391043 (https://phabricator.wikimedia.org/T180363) [17:41:42] 10Citoid, 10VisualEditor, 10MediaWiki-Documentation, 10Documentation, and 3 others: Update citoid image in documentation - https://phabricator.wikimedia.org/T180363#3755757 (10Esanders) Once this patch ^^ has been deployed and the bot does a run we can also update manual and re-use screenshots. [17:55:55] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Provide a way to insert nested templates to template parameters - https://phabricator.wikimedia.org/T173274#3755814 (10Jdforrester-WMF) [17:55:59] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Add support for editing templates' parameters as DOM elements ("visually"), including supporting nested templates - https://phabricator.wikimedia.org/T52355#3755817 (10Jdforrester-WMF) [17:57:34] 10VisualEditor: Some VE system message keys shown after MW upgrade - https://phabricator.wikimedia.org/T180358#3755839 (10njnatale_lmco) In addition, I've found a few other places where I'm seeing the keys instead of values. These keys also do not appear in `Special:AllMessages` {F10767928} [18:50:13] 10Citoid, 10VisualEditor, 10MediaWiki-Documentation, 10Documentation, and 2 others: Update citoid image in documentation - https://phabricator.wikimedia.org/T180363#3756123 (10Mvolz) [19:01:26] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Apple-Safari: Find behaves strangely in preview in Safari - https://phabricator.wikimedia.org/T180393#3756201 (10Whatamidoing-WMF) [19:21:48] (03CR) 10Jforrester: [C: 032] Add screenshot tasks for manual and re-use tabs in Citoid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/391043 (https://phabricator.wikimedia.org/T180363) (owner: 10Esanders) [19:22:22] (03CR) 10Jforrester: [C: 032] Use versioned URLs for data, instead of latest [unicodejs] - 10https://gerrit.wikimedia.org/r/390986 (owner: 10Esanders) [19:23:36] (03CR) 10Jforrester: [C: 031] Build automated wordbreak tests from official test data [unicodejs] - 10https://gerrit.wikimedia.org/r/390987 (owner: 10Esanders) [19:25:57] (03Merged) 10jenkins-bot: Use versioned URLs for data, instead of latest [unicodejs] - 10https://gerrit.wikimedia.org/r/390986 (owner: 10Esanders) [19:29:19] (03Merged) 10jenkins-bot: Add screenshot tasks for manual and re-use tabs in Citoid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/391043 (https://phabricator.wikimedia.org/T180363) (owner: 10Esanders) [19:29:28] 10VisualEditor, 10Contributors-Team, 10MediaWiki-Page-editing, 10MediaWiki-extensions-FlaggedRevs, 10MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)): FlaggedRev's over-ride of the submit button's label via the EditPageBeforeEditButtons PHP ho... - https://phabricator.wikimedia.org/T179326#3756387 [19:30:11] (03CR) 10Jforrester: Update to Unicode 9.0.0 (031 comment) [unicodejs] - 10https://gerrit.wikimedia.org/r/348975 (owner: 10Jforrester) [19:30:45] (03PS5) 10Jforrester: Update to Unicode 9.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/348975 [19:30:58] 10Citoid, 10VisualEditor, 10MediaWiki-Documentation, 10Documentation, 10Patch-For-Review: Update citoid image in documentation - https://phabricator.wikimedia.org/T180363#3756393 (10Mvolz) [19:31:09] 10Citoid, 10VisualEditor, 10MediaWiki-Documentation, 10Documentation: Update citoid image in documentation - https://phabricator.wikimedia.org/T180363#3755228 (10Mvolz) [19:31:32] (03CR) 10Jforrester: [C: 031] Update to Unicode 9.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/348975 (owner: 10Jforrester) [19:32:03] 10Citoid, 10VisualEditor, 10MediaWiki-Documentation, 10Documentation: Update citoid image in documentation - https://phabricator.wikimedia.org/T180363#3755228 (10Mvolz) [19:32:05] (03PS4) 10Jforrester: Update to Unicode 10.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/390022 [19:32:07] (03CR) 10Jforrester: [C: 031] Update to Unicode 10.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/390022 (owner: 10Jforrester) [19:45:40] (03CR) 10jenkins-bot: Use versioned URLs for data, instead of latest [unicodejs] - 10https://gerrit.wikimedia.org/r/390986 (owner: 10Esanders) [19:48:20] (03CR) 10jenkins-bot: Add screenshot tasks for manual and re-use tabs in Citoid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/391043 (https://phabricator.wikimedia.org/T180363) (owner: 10Esanders) [21:27:08] 10Citoid, 10VisualEditor, 10MediaWiki-Documentation, 10Documentation, 10MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)): Update citoid image in documentation - https://phabricator.wikimedia.org/T180363#3756689 (10Esanders) (Apologies, I noticed too late that you tagged this as GCI) [21:28:06] 10Citoid, 10VisualEditor, 10MediaWiki-Documentation, 10Documentation, 10MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)): Update citoid image in documentation - https://phabricator.wikimedia.org/T180363#3756691 (10Mvolz) That's okay, better to do it this way anyway :) [21:28:52] (03PS3) 10Tchanders: Fix visual diff timeout [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/385831 (https://phabricator.wikimedia.org/T177378) [21:29:27] (03CR) 10Tchanders: Fix visual diff timeout (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/385831 (https://phabricator.wikimedia.org/T177378) (owner: 10Tchanders) [21:30:30] (03CR) 10Esanders: [C: 032] Fix visual diff timeout [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/385831 (https://phabricator.wikimedia.org/T177378) (owner: 10Tchanders) [21:32:59] (03Merged) 10jenkins-bot: Fix visual diff timeout [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/385831 (https://phabricator.wikimedia.org/T177378) (owner: 10Tchanders) [21:34:11] (03CR) 10Esanders: [C: 04-1] Update to Unicode 9.0.0 (031 comment) [unicodejs] - 10https://gerrit.wikimedia.org/r/348975 (owner: 10Jforrester) [21:35:32] (03CR) 10jenkins-bot: Fix visual diff timeout [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/385831 (https://phabricator.wikimedia.org/T177378) (owner: 10Tchanders) [21:37:37] 10VisualEditor: Single edit tab: Setting should apply per-namespace - https://phabricator.wikimedia.org/T180155#3748789 (10Esanders) I think want we want to do is just not override the preference if the namespace only supports one mode, rather than store a separate preference for every namespace. [21:56:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/391125 (owner: 10L10n-bot) [22:27:10] (03CR) 10Jforrester: "Bah." [unicodejs] - 10https://gerrit.wikimedia.org/r/348975 (owner: 10Jforrester) [22:30:59] Hey guys, I am having an issue with visual editor and subpages [22:31:21] HAs anyone run into this ? [22:31:21] 127.0.0.1 - - [13/Nov/2017:16:58:25 -0500] "GET /wiki.iits.company/v3/page/html/Main_Page%2FNetwork.IITS/362?redirect=false HTTP/1.1" 404 2472 "-" "VisualEditor-MediaWiki/1.29.1" [22:32:10] im thinking it's trying to uise %2F instead of "/" (URL Encoded) instead of actual "/" [22:32:21] thats why getting 404? [22:32:28] works fine in normal namespace [22:40:02] rest api should use %2F for page titles, that's correct [22:40:45] but there's a suspicious /362 at the end of your path [22:45:29] hey cscott [22:46:16] SO, looks like it skips the inistial api json call [22:49:12] It does not do "127.0.0.1 - - [13/Nov/2017:16:57:56 -0500] "GET [22:49:21] /api.php?format=json&action=query&prop=info%7Crevisions&rawcontinue=1&rvprop=content%7Cids%7Ctimestamp%7Csize%7Csha1%7Ccontentmodel&revids=361 HTTP/1.1" 200 1149 "-" "Parsoid/0.7.1" [22:51:09] so its probably a parsoid problem more then visualeditor then? [23:30:18] (03PS1) 10Jforrester: Update VE core submodule to master (d9059cd50) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/391137 (https://phabricator.wikimedia.org/T139089)