[03:00:22] (03PS3) 10Divec: Destroy CE nodes on removal by onSplice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/393436 (https://phabricator.wikimedia.org/T179574) [03:05:28] (03CR) 10Divec: "Good point: added a test case that fails without this fix" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/393436 (https://phabricator.wikimedia.org/T179574) (owner: 10Divec) [03:29:21] (03CR) 10Divec: [C: 032] ce.ContentBranchNode: Move setNotUnicorning into detach [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386419 (owner: 10DLynch) [03:31:56] (03Merged) 10jenkins-bot: ce.ContentBranchNode: Move setNotUnicorning into detach [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386419 (owner: 10DLynch) [03:34:17] (03CR) 10jenkins-bot: ce.ContentBranchNode: Move setNotUnicorning into detach [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/386419 (owner: 10DLynch) [04:11:32] (03CR) 10Jforrester: [C: 031] Destroy CE nodes on removal by onSplice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/393436 (https://phabricator.wikimedia.org/T179574) (owner: 10Divec) [04:13:04] (03CR) 10Jforrester: [C: 04-1] "Unit test please. Or at least a Phabricator task justifying this." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/390876 (owner: 10Esanders) [04:13:06] (03CR) 10Jforrester: "Squashable into parent yet?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/387511 (owner: 10Divec) [05:54:34] (03CR) 10Divec: "@Esanders are you happy with this?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/387511 (owner: 10Divec) [11:13:41] 10Cite, 10Timeless: Highlight for references extends above ref - https://phabricator.wikimedia.org/T181490#3791949 (10Schnark) [12:37:57] 10Citoid, 10VisualEditor: When adding a reference, figure out the page number the user wants based on information in the URL, and automatically add it - https://phabricator.wikimedia.org/T96000#3792236 (10Deskana) >>! In T96000#3788644, @Elitre wrote: > Isn't that T113262? Yes, it seems so. [12:38:06] 10Citoid, 10VisualEditor: When adding a reference, figure out the page number the user wants based on information in the URL, and automatically add it - https://phabricator.wikimedia.org/T96000#3792241 (10Deskana) [12:38:09] 10Citoid, 10VisualEditor, 10WorkType-Maintenance: Keep page number parameter when processing Google Books links - https://phabricator.wikimedia.org/T113262#3792239 (10Deskana) [12:50:53] 10VisualEditor, 10Collaboration-Team-Triage, 10StructuredDiscussions: FlowMention template makes impossible to type in the same line - https://phabricator.wikimedia.org/T180185#3792271 (10Deskana) [12:50:57] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), 10Patch-For-Review, and 2 others: Polish Wikipedia template {{odn}} is inserted as a block element in VE rather than inline - https://phabricator.wikimedia.org/T179618#3792265 (10Deskana) 05Open>03... [13:48:19] 10VisualEditor, 10Community-Liaisons, 10Documentation, 10Need-volunteer: Write a help page that explains how to create interlanguage and interproject links - https://phabricator.wikimedia.org/T134186#2257294 (10Trizek-WMF) Can I add (and mentor) that task as a #google-code-in-2017 one? [15:51:54] 10Citoid, 10VisualEditor, 10Internet-Archive: wrong author listed and wrong first/last name for the one author listed - https://phabricator.wikimedia.org/T160845#3792792 (10Mvolz) >>! In T160845#3788695, @Elitre wrote: > @Mvolz this isn't even triaged, and yet it seems to affect every wiki, making ISBN ref... [15:52:06] 10Citoid, 10VisualEditor: wrong author listed and wrong first/last name for the one author listed - https://phabricator.wikimedia.org/T160845#3792794 (10Mvolz) p:05Triage>03Normal [16:05:53] 10Citoid, 10VisualEditor: wrong author listed and wrong first/last name for the one author listed - https://phabricator.wikimedia.org/T160845#3792869 (10Elitre) >>! In T160845#3792792, @Mvolz wrote: > > I agree the data looks okay from the worldcat website. I wonder if they have an internal data format that... [17:01:42] (03CR) 10DLynch: [C: 032] Destroy CE nodes on removal by onSplice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/393436 (https://phabricator.wikimedia.org/T179574) (owner: 10Divec) [17:03:44] (03Merged) 10jenkins-bot: Destroy CE nodes on removal by onSplice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/393436 (https://phabricator.wikimedia.org/T179574) (owner: 10Divec) [17:06:18] (03CR) 10jenkins-bot: Destroy CE nodes on removal by onSplice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/393436 (https://phabricator.wikimedia.org/T179574) (owner: 10Divec) [17:34:50] 10VisualEditor, 10Wikimedia-Site-requests, 10Patch-For-Review: Enable both "edit" and "edit code" tabs in Polish Wikipedia - https://phabricator.wikimedia.org/T181045#3793377 (10Deskana) 05Open>03declined I've taken a look at the discussion. There seem to be a few central points made, namely: # Editors w... [17:55:02] (03PS1) 10Jforrester: Update VE core submodule to master (56cfb5d6f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/393812 (https://phabricator.wikimedia.org/T179574) [17:58:42] (03PS1) 10DLynch: ce.Surface: support formatted google docs paste content again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/393813 (https://phabricator.wikimedia.org/T145252) [18:05:01] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (56cfb5d6f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/393812 (https://phabricator.wikimedia.org/T179574) (owner: 10Jforrester) [18:10:45] (03Merged) 10jenkins-bot: Update VE core submodule to master (56cfb5d6f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/393812 (https://phabricator.wikimedia.org/T179574) (owner: 10Jforrester) [18:12:24] 10VisualEditor, 10VisualEditor-ContentEditable, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10User-Ryasmeen: List editing exception: TypeError: Cannot read property 'getSurface' of null - https://phabricator.wikimedia.org/T179574#3793583 (10Jdforrester-WMF) 05Open>03Resolved p:05T... [18:12:40] (03CR) 10jenkins-bot: Update VE core submodule to master (56cfb5d6f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/393812 (https://phabricator.wikimedia.org/T179574) (owner: 10Jforrester) [18:27:37] 10VisualEditor, 10Collaboration-Team-Triage, 10StructuredDiscussions: FlowMention template makes impossible to type in the same line - https://phabricator.wikimedia.org/T180185#3793667 (10matmarex) @Etonkovidova Can you verify if this is fixed now? (on beta) [19:35:09] 10VisualEditor, 10VisualEditor-Tables, 10Accessibility: In VE table editor, cannot move cursor out of caption area using keyboard - https://phabricator.wikimedia.org/T181416#3794103 (10Deskana) p:05Triage>03Normal Today I learnt tables can have captions in MediaWiki. [19:35:59] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Timeless: Slight conflict between 2017 WTE and Timeless top-bars - https://phabricator.wikimedia.org/T181167#3794110 (10Deskana) I suspect that this is a problem with Timeless itself, if it's happening with both the 2017 wikitext editor and on th... [19:41:11] 10VisualEditor, 10Collaboration-Team-Triage, 10StructuredDiscussions: FlowMention template makes impossible to type in the same line - https://phabricator.wikimedia.org/T180185#3794118 (10Etonkovidova) @matmarex The issue is still exists in beta. [19:44:36] 10VisualEditor, 10VisualEditor-MediaWiki-References: Groups can be added, but not removed or changed, on refs that contain citation templates - https://phabricator.wikimedia.org/T181087#3794130 (10Deskana) p:05Triage>03Normal [19:48:08] 10VisualEditor: A URL with a < in it can't be added using VE - https://phabricator.wikimedia.org/T180949#3794143 (10Deskana) p:05Triage>03Normal I can reproduce it with Chrome on Mac OS. [19:51:26] 10VisualEditor: Please convert a URL to the internal link that I want for redirecting a page - https://phabricator.wikimedia.org/T180740#3794153 (10Deskana) p:05Triage>03Normal [20:12:49] (03PS1) 10Jforrester: build: Bump Ruby cruft to avoid security warnings for old rubocop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/393836 [20:12:54] (03PS1) 10Jforrester: build: Bump Ruby cruft to avoid security warnings for old rubocop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/393837 [20:31:55] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Timeless: Slight conflict between 2017 WTE and Timeless top-bars - https://phabricator.wikimedia.org/T181167#3794291 (10Izno) >>! In T181167#3794110, @Deskana wrote: > I suspect that this is a problem with Timeless itself, if it's happening with... [21:37:30] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Timeless: Slight conflict between 2017 WTE and Timeless top-bars - https://phabricator.wikimedia.org/T181167#3794476 (10Deskana) >>! In T181167#3794291, @Izno wrote: > Yes. I didn't mean to implicate VE or search or whatever. #betaskinsbebetaskin... [22:02:20] 10VisualEditor, 10Wikimedia-Site-requests, 10Patch-For-Review: Enable both "edit" and "edit code" tabs in Polish Wikipedia - https://phabricator.wikimedia.org/T181045#3777724 (10Tufor) I am sorry but this is bullshit. I am no longer active on plwiki and wikimedia projects in general but after I saw this I th... [22:06:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/393909 (owner: 10L10n-bot) [22:39:29] (03CR) 10Esanders: [C: 032] "We might as well write more tests for the other tags" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/393813 (https://phabricator.wikimedia.org/T145252) (owner: 10DLynch) [22:42:24] (03Merged) 10jenkins-bot: ce.Surface: support formatted google docs paste content again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/393813 (https://phabricator.wikimedia.org/T145252) (owner: 10DLynch) [22:50:10] (03CR) 10jenkins-bot: ce.Surface: support formatted google docs paste content again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/393813 (https://phabricator.wikimedia.org/T145252) (owner: 10DLynch) [23:10:09] (03PS1) 10DLynch: ce.Surface: more tests for Google Docs pasting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/393932 (https://phabricator.wikimedia.org/T145252) [23:12:00] (03CR) 10DLynch: "Fair point, I've made https://gerrit.wikimedia.org/r/#/c/393932/ for more tests (and tightened up the underline detection as a result)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/393813 (https://phabricator.wikimedia.org/T145252) (owner: 10DLynch) [23:18:58] (03CR) 10Jforrester: [C: 032] ce.Surface: more tests for Google Docs pasting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/393932 (https://phabricator.wikimedia.org/T145252) (owner: 10DLynch) [23:22:51] (03Merged) 10jenkins-bot: ce.Surface: more tests for Google Docs pasting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/393932 (https://phabricator.wikimedia.org/T145252) (owner: 10DLynch) [23:30:36] (03CR) 10jenkins-bot: ce.Surface: more tests for Google Docs pasting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/393932 (https://phabricator.wikimedia.org/T145252) (owner: 10DLynch)