[00:56:27] 10VisualEditor, 10VisualEditor-EditingTools: Format tools (bold, italic, etc.) in toolbar don't work (regression in wmf.11) - https://phabricator.wikimedia.org/T182270#3818652 (10Catrope) [00:56:35] 10VisualEditor, 10VisualEditor-EditingTools: Format tools (bold, italic, etc.) in toolbar don't work (regression in wmf.11) - https://phabricator.wikimedia.org/T182270#3818662 (10Catrope) p:05Triage>03Unbreak! [03:35:39] 10VisualEditor, 10VisualEditor-EditingTools: Format tools (bold, italic, etc.) in toolbar don't work (regression in wmf.11) - https://phabricator.wikimedia.org/T182270#3818652 (10dchan) Oh, command.execute( surface ) is happening twice, and it so happens that the commands are self-inverse (toggling). [03:46:08] 10VisualEditor, 10Collaboration-Team-Triage, 10StructuredDiscussions, 10Patch-For-Review: Migrate Flow to use the integrated VE/WT editor widget when it exists - https://phabricator.wikimedia.org/T155861#2957070 (10Catrope) >>! In T155861#3776799, @TerraCodes wrote: >>>! In T155861#3038131, @Anomie wrote:... [03:47:09] (03PS1) 10Divec: Don't execute commands twice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/395919 (https://phabricator.wikimedia.org/T182270) [03:47:56] (03CR) 10Catrope: [C: 031] Don't execute commands twice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/395919 (https://phabricator.wikimedia.org/T182270) (owner: 10Divec) [03:48:21] 10VisualEditor, 10VisualEditor-EditingTools, 10Patch-For-Review: Format tools (bold, italic, etc.) in toolbar don't work (regression in wmf.11) - https://phabricator.wikimedia.org/T182270#3818824 (10Catrope) Hah, that explains why buttons that open dialogs did work. [03:49:04] 10VisualEditor, 10StructuredDiscussions, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Patch-For-Review: Migrate Flow to use the integrated VE/WT editor widget when it exists - https://phabricator.wikimedia.org/T155861#3818834 (10Catrope) [03:49:19] 10VisualEditor, 10StructuredDiscussions, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Patch-For-Review: Migrate Flow to use the integrated VE/WT editor widget when it exists - https://phabricator.wikimedia.org/T155861#2957070 (10Catrope) My patch for this is now ready for review. [08:11:49] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/395937 (owner: 10L10n-bot) [10:29:52] (03CR) 10Esanders: [C: 031] Track action=loaded for consistency with WikiEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395783 (owner: 10DLynch) [10:54:41] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Internet-Archive, 10The-Wikipedia-Library: On URL submission, look up the archived page in the Internet Archive's index and add to the return data - https://phabricator.wikimedia.org/T115224#3819553 (10Mvolz) Thanks @Cyberpower678 - I will... [10:59:51] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Internet-Archive, 10The-Wikipedia-Library: On URL submission, look up the archived page in the Internet Archive's index and add to the return data - https://phabricator.wikimedia.org/T115224#3819568 (10Mvolz) (T162886 was where we dealt wit... [11:01:09] 10Citoid, 10VisualEditor, 10Internet-Archive: Try to find link in archive.org for 520 page - https://phabricator.wikimedia.org/T95388#3819576 (10Mvolz) [11:01:11] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Internet-Archive, 10The-Wikipedia-Library: On URL submission, look up the archived page in the Internet Archive's index and add to the return data - https://phabricator.wikimedia.org/T115224#3819575 (10Mvolz) 05Open>03stalled [11:01:33] 10Citoid, 10VisualEditor, 10Internet-Archive: Try to find link in archive.org for 520 page - https://phabricator.wikimedia.org/T95388#1188433 (10Mvolz) a:05Mvolz>03None [11:15:01] (03PS1) 10Esanders: Pass editor mode (visual/source) to tracking code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395975 [11:22:37] 10Citoid, 10VisualEditor: Add scraping of PRISM tags to html-metadata node library - https://phabricator.wikimedia.org/T118636#3819610 (10Mvolz) [11:26:25] 10Citoid, 10VisualEditor, 10Google-Code-in-2017: Add scraping of PRISM tags to html-metadata node library - https://phabricator.wikimedia.org/T118636#3819618 (10Mvolz) [11:27:02] 10Citoid, 10VisualEditor, 10Google-Code-in-2017: Add scraping of PRISM tags to html-metadata node library - https://phabricator.wikimedia.org/T118636#1805423 (10Mvolz) I will mentor this in #google-code-in-2017 [11:32:29] 10Citoid, 10VisualEditor: Read CoinS data in lib/scrape.js - https://phabricator.wikimedia.org/T76223#3819661 (10Mvolz) [11:38:48] 10Citoid, 10VisualEditor, 10Google-Code-in-2017: Add scraping of PRISM tags to html-metadata node library - https://phabricator.wikimedia.org/T118636#3819667 (10Mvolz) [11:51:20] (03CR) 10Esanders: [C: 032] Don't execute commands twice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/395919 (https://phabricator.wikimedia.org/T182270) (owner: 10Divec) [11:53:26] (03Merged) 10jenkins-bot: Don't execute commands twice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/395919 (https://phabricator.wikimedia.org/T182270) (owner: 10Divec) [11:55:36] (03CR) 10jenkins-bot: Don't execute commands twice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/395919 (https://phabricator.wikimedia.org/T182270) (owner: 10Divec) [12:07:53] 10VisualEditor: VisualEditor cssUrlEmbed:dist complains not being able to find resize-nw-se.svg and resize-ne-sw.svg - https://phabricator.wikimedia.org/T182312#3819744 (10hashar) [12:16:11] 10Citoid, 10VisualEditor, 10Design, 10Google-Code-in-2017, 10User-Ryasmeen: Propose a logo for the Citoid service - https://phabricator.wikimedia.org/T179691#3819774 (10Mvolz) @AnmolSingh on commons can you link to where you got the book icon from? It's necessary to verify that the image is correctly lic... [12:57:17] 10VisualEditor, 10VisualEditor-EditingTools, 10Patch-For-Review: Format tools (bold, italic, etc.) in toolbar don't work (regression in wmf.11) - https://phabricator.wikimedia.org/T182270#3819882 (10Deskana) Thanks @dchan! Presumably this now needs a backport and SWAT deployment? [13:12:28] 10Citoid, 10VisualEditor: Citoid unable to parse ISO dates with no or mixed punctuation - https://phabricator.wikimedia.org/T178586#3819947 (10Mvolz) [13:19:44] 10Citoid, 10VisualEditor: Citoid unable to parse ISO dates with no or mixed punctuation - https://phabricator.wikimedia.org/T178586#3696965 (10mobrovac) Both `20170821T1415+0300Z` and `20171207T124731Z` are valid date-time notations; they are different variants of the [ISO 8601](https://en.wikipedia.org/wiki/I... [13:26:55] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: Autolinking for URLs and magic links (ISBN etc.) not applied when copy-pasting a block of text - https://phabricator.wikimedia.org/T162291#3819977 (10Deskana) >>! In T162291#3817273, @Elitre wrote: > @Deskana , I think this is now going to b... [13:40:10] 10Citoid, 10VisualEditor: Citoid unable to parse ISO dates with punctuation missing in date and/or time - https://phabricator.wikimedia.org/T178586#3820002 (10Mvolz) [13:43:26] 10Citoid, 10VisualEditor: Citoid unable to parse ISO dates with punctuation missing in date and/or time - https://phabricator.wikimedia.org/T178586#3820031 (10Mvolz) >>! In T178586#3819963, @mobrovac wrote: > Both `20170821T1415+0300Z` and `20171207T124731Z` are valid date-time notations; they are different v... [14:11:47] 10Citoid, 10VisualEditor: Citoid VisualEditor code failing to escape wiki markup for citoid derived citations in some situations - https://phabricator.wikimedia.org/T143453#3820062 (10Mvolz) p:05Normal>03High [14:12:21] 10Citoid, 10VisualEditor: Citoid VisualEditor code failing to escape wiki markup for citoid derived citations in some situations - https://phabricator.wikimedia.org/T143453#2568730 (10Mvolz) [14:14:46] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10SyntaxHighlight: Text and selection are shifted - https://phabricator.wikimedia.org/T180678#3820068 (10Esanders) My suspicion is resolving T182320 will fix this. Let's test again when that is closed. [14:32:20] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10SyntaxHighlight: Text and selection are shifted - https://phabricator.wikimedia.org/T180678#3820102 (10Elitre) Ok, thanks. [16:03:54] (03PS1) 10Jforrester: Don't execute commands twice [VisualEditor/VisualEditor] (wmf/1.31.0-wmf.11) - 10https://gerrit.wikimedia.org/r/396034 (https://phabricator.wikimedia.org/T182270) [16:04:01] (03CR) 10Jforrester: [C: 032] Don't execute commands twice [VisualEditor/VisualEditor] (wmf/1.31.0-wmf.11) - 10https://gerrit.wikimedia.org/r/396034 (https://phabricator.wikimedia.org/T182270) (owner: 10Jforrester) [16:07:29] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-References, 10User-Ryasmeen: Odd ref names being added by VisualEditor - https://phabricator.wikimedia.org/T94712#3820462 (10Deskana) 05stalled>03Resolved a:03Deskana This hasn't happened in a long time, so presumably it got fixed at... [16:09:11] (03PS1) 10Jforrester: Update VE core submodule to master (cd6bce192) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396039 (https://phabricator.wikimedia.org/T180878) [16:10:26] 10Citoid, 10VisualEditor: Citoid unable to parse ISO dates with punctuation missing in date and/or time - https://phabricator.wikimedia.org/T178586#3820521 (10mobrovac) >>! In T178586#3820031, @Mvolz wrote: > By my reading of the standard punctuation can be missing from the date, time, or both. And the date c... [16:17:26] (03CR) 10Jforrester: [C: 032] Don't execute commands twice [VisualEditor/VisualEditor] (wmf/1.31.0-wmf.11) - 10https://gerrit.wikimedia.org/r/396034 (https://phabricator.wikimedia.org/T182270) (owner: 10Jforrester) [16:19:00] 10VisualEditor, 10StructuredDiscussions, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Patch-For-Review: Migrate Flow to use the integrated VE/WT editor widget when it exists - https://phabricator.wikimedia.org/T155861#3820551 (10Anomie) >>! In T155861#3818817, @Catrope wrote: >>>! In T155861#3... [16:21:32] (03CR) 10jenkins-bot: Don't execute commands twice [VisualEditor/VisualEditor] (wmf/1.31.0-wmf.11) - 10https://gerrit.wikimedia.org/r/396034 (https://phabricator.wikimedia.org/T182270) (owner: 10Jforrester) [16:24:05] (03PS1) 10Jforrester: Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396046 (https://phabricator.wikimedia.org/T182270) [16:25:06] (03Abandoned) 10Jforrester: Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396046 (https://phabricator.wikimedia.org/T182270) (owner: 10Jforrester) [16:25:08] (03PS1) 10Jforrester: Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396048 (https://phabricator.wikimedia.org/T182270) [16:26:20] (03PS1) 10Jforrester: Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62) [extensions/VisualEditor] (wmf/1.31.0-wmf.11) - 10https://gerrit.wikimedia.org/r/396050 (https://phabricator.wikimedia.org/T182270) [16:26:34] (03CR) 10Aklapper: "Could this get a review please? For the records, the bug reporter stated in https://phabricator.wikimedia.org/T177313#3786032 that this fi" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/393282 (https://phabricator.wikimedia.org/T177313) (owner: 10Seb35) [16:26:46] (03Abandoned) 10Jforrester: Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396048 (https://phabricator.wikimedia.org/T182270) (owner: 10Jforrester) [16:27:50] 10VisualEditor, 10VisualEditor-EditingTools, 10Patch-For-Review: Format tools (bold, italic, etc.) in toolbar don't work (regression in wmf.11) - https://phabricator.wikimedia.org/T182270#3818652 (10Jdforrester-WMF) >>! In T182270#3819882, @Deskana wrote: > Thanks @dchan! > > Presumably this now needs a bac... [17:11:56] 10VisualEditor, 10StructuredDiscussions, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Patch-For-Review: Migrate Flow to use the integrated VE/WT editor widget when it exists - https://phabricator.wikimedia.org/T155861#3820672 (10Catrope) >>! In T155861#3820551, @Anomie wrote: > Does that mean... [17:18:51] (03CR) 10Deskana: [C: 032] Update VE core submodule to master (cd6bce192) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396039 (https://phabricator.wikimedia.org/T180878) (owner: 10Jforrester) [17:21:49] (03CR) 10Chad: [C: 032] Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62) [extensions/VisualEditor] (wmf/1.31.0-wmf.11) - 10https://gerrit.wikimedia.org/r/396050 (https://phabricator.wikimedia.org/T182270) (owner: 10Jforrester) [17:26:02] (03Merged) 10jenkins-bot: Update VE core submodule to master (cd6bce192) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396039 (https://phabricator.wikimedia.org/T180878) (owner: 10Jforrester) [17:31:03] (03Merged) 10jenkins-bot: Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62) [extensions/VisualEditor] (wmf/1.31.0-wmf.11) - 10https://gerrit.wikimedia.org/r/396050 (https://phabricator.wikimedia.org/T182270) (owner: 10Jforrester) [17:31:11] (03CR) 10jenkins-bot: Update VE core submodule to master (cd6bce192) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396039 (https://phabricator.wikimedia.org/T180878) (owner: 10Jforrester) [17:44:50] (03CR) 10Catrope: [C: 032] Cancel button returns Undefined error [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/393282 (https://phabricator.wikimedia.org/T177313) (owner: 10Seb35) [17:45:11] 10VisualEditor, 10VisualEditor-EditingTools, 10Patch-For-Review, 10User-Ryasmeen: Format tools (bold, italic, etc.) in toolbar don't work (regression in wmf.11) - https://phabricator.wikimedia.org/T182270#3820751 (10Deskana) 05Open>03Resolved a:03Deskana This was backported. Thanks @demon for the dep... [17:47:46] (03Merged) 10jenkins-bot: Cancel button returns Undefined error [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/393282 (https://phabricator.wikimedia.org/T177313) (owner: 10Seb35) [17:52:21] 10VisualEditor: VE doesn't find an existing image - https://phabricator.wikimedia.org/T182014#3820765 (10matej_suchanek) [17:55:23] (03PS1) 10C. Scott Ananian: Interwiki links are a type of external link [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396069 [17:56:14] (03CR) 10C. Scott Ananian: "I think this is the only change needed. Ed, could you double check this?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396069 (owner: 10C. Scott Ananian) [19:31:01] 10Citoid, 10VisualEditor, 10Design, 10Google-Code-in-2017, 10User-Ryasmeen: Propose a logo for the Citoid service - https://phabricator.wikimedia.org/T179691#3821039 (10AnmolSingh) @Mvolz done [19:31:37] is there an option I'm missing to get the VisualEditor to be not quite as ugly about GraphViz etc? [19:34:14] (it basically doesn't recognize the existance of the tags and just parses it and the contents like wikitax) [20:55:27] Hello! [20:55:45] I have migrated the CI job that runs "npm install && npm test" to a Docker container [20:56:25] that container uses stretch and comes with Chromium 62 and Firefox ESR (v52) [20:56:25] (there is PhantomJS as well bah) [20:56:39] the job pass. If that causes troubles one would need to get https://gerrit.wikimedia.org/r/#/c/395553/ reverted [20:58:08] (03PS1) 10Hashar: (WIP) run karma:main with Firefox as well [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/396125 [21:03:48] eventually some tests are failling on Firefox ^ But at least it seems Firefox is there and reacheable by karma \o/ [21:04:29] (03CR) 10jerkins-bot: [V: 04-1] (WIP) run karma:main with Firefox as well [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/396125 (owner: 10Hashar) [21:06:14] (03Abandoned) 10Hashar: (WIP) run karma:main with Firefox as well [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/396125 (owner: 10Hashar) [21:13:44] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-CodeMirror, 10Browser-Support-Firefox, and 2 others: Selecting syntax-highlighted text in the 2017 source editor covers it completely when using Firefox on OSX - https://phabricator.wikimedia.org/T175223#3821368 (10Aschmidt...