[07:22:20] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/397269 (owner: 10L10n-bot) [09:34:06] (03CR) 10jenkins-bot: build: Updating mediawiki/minus-x to 0.2.1 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/397376 (owner: 10Libraryupgrader) [12:38:58] 10VisualEditor: If Template:! is actually transcluded on a page, VisualEditor still displays it as a pipe. - https://phabricator.wikimedia.org/T182576#3827739 (10GKFX) [12:41:06] 10VisualEditor: If Template:! is actually transcluded on a page, VisualEditor still displays it as a pipe. - https://phabricator.wikimedia.org/T182576#3827749 (10GKFX) [12:49:33] 10VisualEditor, 10Parsoid: Visual Editor removing whitespace from infoboxes by default - https://phabricator.wikimedia.org/T179259#3827758 (10TheDJ) This problem seems significantly less annoying now with param order preservation ! Thanks @Arlolra ! [13:12:48] 10VisualEditor: VisualEditor converts interwiki/Special:BookSources links to magic links - https://phabricator.wikimedia.org/T179769#3827825 (10Deskana) 05Open>03stalled p:05Triage>03Low >>! In T179769#3817716, @Tacsipacsi wrote: > It’s tracked by T145604, though I think it’s one of the “will be done in... [13:24:45] 10VisualEditor, 10Performance: Move VEE cookie to a hidden preference (for registered users) - https://phabricator.wikimedia.org/T181933#3827846 (10Deskana) Looks like the truth is somewhere between what @eddiegp and I said. @eddiegp is right that the cookie is still being put on the user's system. However, if... [13:27:26] 10VisualEditor: VisualEditor converts interwiki/Special:BookSources links to magic links - https://phabricator.wikimedia.org/T179769#3827848 (10Tacsipacsi) I think that as the transition is in progress (there are tracking categories, bot is doing the conversion), VE shouldn’t work against this. (Leaving the link... [14:25:06] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: When inserting templates, consider using the name instead of a redirect - https://phabricator.wikimedia.org/T145067#3828020 (10Deskana) 05stalled>03declined Given that calling a template by a redirect and calling it by its actual name are functionally equ... [14:25:49] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE edits are not always tagged with the appropriate tag - https://phabricator.wikimedia.org/T153305#3828034 (10Deskana) 05stalled>03declined It doesn't seem like this is happening any more. [14:26:03] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE edits are not always tagged with the appropriate tag - https://phabricator.wikimedia.org/T153305#3828038 (10Deskana) 05declined>03Invalid Oops, wrong status. [14:27:35] 10VisualEditor, 10VisualEditor-ContentLanguage, 10TestMe: Pressing the Shift key moves the cursor (when "GoogleTrans" gadget is enabled) - https://phabricator.wikimedia.org/T156228#3828043 (10Deskana) This is likely a problem with the gadget. [14:29:26] 10VisualEditor, 10VisualEditor-Performance, 10Epic, 10Patch-For-Review, 10Technical-Debt: Internal nodes should eventually be in a separate document ("sub-documents") - https://phabricator.wikimedia.org/T49344#3828064 (10Deskana) a:05DLynch>03None [14:44:44] 10VisualEditor: VE doesn't find an existing image - https://phabricator.wikimedia.org/T182014#3828163 (10Juandev) Yes, when I enter a single file it is also happening. I think it might be a couse of time. If I give it more time it works, if I past there inmediately the image name it doesnt work. [16:18:08] (03CR) 10DLynch: [C: 032] Pass editor mode (visual/source) to tracking code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395975 (owner: 10Esanders) [16:24:58] (03CR) 10Esanders: [C: 032] Track action=loaded for consistency with WikiEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395783 (owner: 10DLynch) [16:25:30] (03CR) 10Jforrester: [C: 04-1] "You'll also need to bump the schema version from 13457736 to 17520312, as currently we're squawking the former and so all the new events w" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395783 (owner: 10DLynch) [16:25:38] (03CR) 10Jforrester: [C: 04-2] Track action=loaded for consistency with WikiEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395783 (owner: 10DLynch) [16:29:10] James_F: Where's that supposed to be updated? [16:29:36] Kemayo: Probably it's in extension.json? [16:30:41] edsanders, Kemayo: Also https://gerrit.wikimedia.org/r/#/c/395777/ needs fixing in the same way. [16:31:15] James_F: I didn't see anything about it in there. 13457736 doesn't appear in the codebase anywhere, for instance. [16:31:20] Hmm. [16:31:23] Oh, wait. [16:31:29] This is that terrible thing we did, isn't it? [16:31:49] You might have to narrow that one down. [16:31:51] Yeah. [16:32:34] (03CR) 10jerkins-bot: [V: 04-1] Pass editor mode (visual/source) to tracking code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395975 (owner: 10Esanders) [16:32:43] So, "cleverly", the code in VE doesn't use the normal system but a custom one in the EventLogging extension itself. [16:33:02] Which is such an utter hack, but allows WikiEditor and VisualEditor to move together. [16:33:04] * James_F sighs. [16:33:23] I… think? [16:35:01] Kemayo: I don't have anything useful to give more info. :-( [16:36:26] Kemayo: Aha, yeah, it's all in https://github.com/wikimedia/mediawiki-extensions-WikimediaEvents/blob/407303f2adf98b6bb8bf0a2934d5de719d4a77e4/WikimediaEventsHooks.php [16:37:06] Hence why this code does nothing unless you've got VE+EL+WikimediaEvents loaded. [16:47:41] 10VisualEditor: Switch magic word for showing VisualEditor edit button - https://phabricator.wikimedia.org/T182606#3828520 (10Tacsipacsi) [16:49:02] And specifically in *its* extension.json, okay. That's doable. [16:52:23] James_F: Okay, https://gerrit.wikimedia.org/r/397573 to increment the schema? [16:53:06] Kemayo: That looks right. I can't test anything today though, so can you and Ed merge them between yourselves? [16:53:25] It seems plausible. [17:08:55] 10VisualEditor, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10User-Ryasmeen, 10Verified, 10Verified-in-Phase0: [Regression pre-wmf.11] Undoing a table insertion throws error "Uncaught TypeError: Cannot read property 'getAttribute' of ... - https://phabricator.wikimedia.org/T181767#3828581 [17:18:12] 10VisualEditor, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10User-Ryasmeen, 10Verified, and 2 others: [Regression pre-wmf.11] Undoing a table insertion throws error "Uncaught TypeError: Cannot read property 'getAttribute' of null" - https://phabricator.wikimedia.org/T181767#3828614 (10... [17:20:19] 10VisualEditor: Switch magic word for showing VisualEditor edit button - https://phabricator.wikimedia.org/T182606#3828520 (10Elitre) The Wikipedia namespace isn't editable with the visual editor though (at least not in a way that makes sense - without visualising a wall of unintelligible code, at least). That's... [17:24:53] Kemayo: is there a patch to fix the WikiEditor ready timing? [17:27:54] James_F: who owns WikimediaEvents and/or can review that patch? [17:29:47] (03CR) 10Esanders: [C: 031] "Why block this commit then? Seems like this change is backwards compatible if the new events are just ignored..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395783 (owner: 10DLynch) [17:36:41] 10VisualEditor, 10Parsoid: Visual Editor removing whitespace from infoboxes by default - https://phabricator.wikimedia.org/T179259#3828670 (10Arlolra) >>! In T179259#3827758, @TheDJ wrote: > Thanks @Arlolra ! All I did was review and deploy it. @ssastry and @cscott wrote the patch. So, thanks goes to them. [17:37:31] 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Visual Editor removing whitespace from infoboxes by default - https://phabricator.wikimedia.org/T179259#3828677 (10Arlolra) 05Open>03Resolved a:03Arlolra Tentatively going to try closing this. [17:40:51] edsanders: You can, or Roan can if you're uncomfortable. [17:41:49] I assume that is just a revision ID, but I can't test it locally [17:42:49] (03CR) 10Jforrester: [C: 032] "OK, let's go." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395783 (owner: 10DLynch) [17:42:55] edsanders: Merged. [17:43:06] ta [17:46:55] (03PS1) 10DLynch: Track time-to-ready/loaded via window.performance [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/397580 [17:47:23] (03PS2) 10DLynch: Track time-to-ready/loaded via window.performance [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/397580 [17:48:03] edsanders: https://gerrit.wikimedia.org/r/#/c/397580/ [17:48:12] (03CR) 10Esanders: Track time-to-ready/loaded via window.performance (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/397580 (owner: 10DLynch) [17:48:14] thanks [17:48:24] endtime - startime? [17:48:36] Ooops, yes. [17:49:00] (03PS3) 10DLynch: Track time-to-ready/loaded via window.performance [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/397580 [17:49:08] I wonder if falling back to Date.now() will skew our statistics... [17:49:18] (03Merged) 10jenkins-bot: Track action=loaded for consistency with WikiEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395783 (owner: 10DLynch) [17:49:38] https://developer.mozilla.org/en-US/docs/Web/API/Performance/timing says that most of our support browsers should support it [17:49:45] Alternative would be to not track at all if window.performance.timing isn't there. Which isn't unreasonable. [17:49:57] I think that would be better [17:50:26] with a comment explaining [17:51:16] (03Merged) 10jenkins-bot: Pass editor mode (visual/source) to tracking code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395975 (owner: 10Esanders) [17:51:55] (03CR) 10Esanders: Track time-to-ready/loaded via window.performance (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/397580 (owner: 10DLynch) [17:53:02] 10VisualEditor: Typed characters get messed up splitting the next line, after changing the text format - https://phabricator.wikimedia.org/T181757#3828724 (10Ryasmeen) [17:53:18] (03PS4) 10DLynch: Track time-to-ready/loaded via window.performance [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/397580 [17:55:23] (03CR) 10jenkins-bot: Track action=loaded for consistency with WikiEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395783 (owner: 10DLynch) [17:56:49] 10VisualEditor: Implement data collection for performance metrics - https://phabricator.wikimedia.org/T182610#3828732 (10Deskana) [17:57:03] 10VisualEditor: Implement data collection for performance metrics - https://phabricator.wikimedia.org/T182610#3828742 (10Deskana) p:05Triage>03High [17:57:04] (03CR) 10jenkins-bot: Pass editor mode (visual/source) to tracking code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395975 (owner: 10Esanders) [17:59:12] (03CR) 10Esanders: [C: 032] Track time-to-ready/loaded via window.performance [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/397580 (owner: 10DLynch) [18:00:04] 10VisualEditor, 10VisualEditor-EditingTools, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10Patch-For-Review, and 4 others: Format tools (bold, italic, etc.) in toolbar don't work (regression in wmf.11) - https://phabricator.wikimedia.org/T182270#3828754 (10Ryasmeen) [19:37:36] 10VisualEditor, 10MediaWiki-Page-editing, 10Community-Liaisons (Oct-Dec 2017), 10Goal: CLs to communicate the Save/Publish change - https://phabricator.wikimedia.org/T134580#3829123 (10Jdforrester-WMF) [19:40:32] 10Editing-team, 10VisualEditor, 10Contributors-Analysis: Update edit-analysis dashboards to account for schema change - https://phabricator.wikimedia.org/T182620#3829134 (10Jdforrester-WMF) [19:40:41] 10VisualEditor: Implement data collection for performance metrics - https://phabricator.wikimedia.org/T182610#3829136 (10Jdforrester-WMF) [19:40:43] 10Editing-team, 10VisualEditor, 10Contributors-Analysis: Update edit-analysis dashboards to account for schema change - https://phabricator.wikimedia.org/T182620#3829061 (10Jdforrester-WMF) [19:49:23] (03CR) 10Jforrester: [C: 031] Track action=loaded when the editor is *fully* ready [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/395777 (owner: 10Esanders) [19:54:08] (03Restored) 10Hashar: (WIP) run karma:main with Firefox as well [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/396125 (owner: 10Hashar) [19:54:15] (03PS2) 10Hashar: (WIP) run karma:main with Firefox as well [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/396125 [19:57:04] (03CR) 10jerkins-bot: [V: 04-1] (WIP) run karma:main with Firefox as well [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/396125 (owner: 10Hashar) [20:07:47] 10VisualEditor, 10VisualEditor-Initialisation, 10Browser-Support-Firefox: VisualEditor: Support Firefox 10-14 - https://phabricator.wikimedia.org/T43245#463747 (10hashar) Firefox 10-14 are from the past. From https://analytics.wikimedia.org/dashboards/browsers/#all-sites-by-browser/browser-family-and-major-... [20:13:55] 10VisualEditor: VisualEditor karma test fails on Firefox v52 - https://phabricator.wikimedia.org/T182626#3829244 (10hashar) [20:14:05] (03CR) 10Hashar: "Filled as https://phabricator.wikimedia.org/T182626" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/396125 (owner: 10Hashar) [20:15:42] 10VisualEditor: Switch magic word for showing VisualEditor edit button - https://phabricator.wikimedia.org/T182606#3829254 (10Tacsipacsi) The Wikipedia namespace //is// [[https://hu.wikipedia.org/w/index.php?title=Wikip%C3%A9dia:Homokoz%C3%B3&diff=19408378|editable]] with the visual editor, and it works fairly w... [20:35:37] 10VisualEditor, 10Browser-Support-Firefox: VisualEditor karma test fails on Firefox v52 - https://phabricator.wikimedia.org/T182626#3829274 (10gh87) [20:50:27] 10VisualEditor, 10WikiEditor, 10Community-Liaisons, 10Contributors-Team, and 8 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#3829304 (10Jdforrester-WMF) [21:15:11] 10VisualEditor, 10Browser-Support-Firefox: VisualEditor karma test fails on Firefox v52 - https://phabricator.wikimedia.org/T182626#3829244 (10Esanders) We've known about these for a while. The first two are to do with different copy/paste behaviour, but doesn't lead to a significant difference. The third is j... [21:20:15] 10VisualEditor, 10VisualEditor-Initialisation, 10Browser-Support-Firefox: VisualEditor: Support Firefox 10-14 - https://phabricator.wikimedia.org/T43245#3829394 (10Jdforrester-WMF) > Maybe that bug can be reconsidered as "Support Firefox ESR version". That is currently version 52 released in March 2017. No.... [21:25:11] (03CR) 10DLynch: [C: 032] Track action=loaded when the editor is *fully* ready [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/395777 (owner: 10Esanders) [21:28:31] (03Merged) 10jenkins-bot: Track action=loaded when the editor is *fully* ready [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/395777 (owner: 10Esanders) [21:28:34] (03Merged) 10jenkins-bot: Track time-to-ready/loaded via window.performance [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/397580 (owner: 10DLynch) [21:37:07] 10VisualEditor, 10Community-Liaisons, 10Contributors-Team, 10MediaWiki-Internationalization, and 2 others: Consider to re-label "Save changes"/"Publish changes" to be "Save & Publish" - https://phabricator.wikimedia.org/T163302#3829422 (10Jdforrester-WMF) [21:37:14] 10VisualEditor, 10WikiEditor, 10Community-Liaisons, 10Contributors-Team, and 9 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#3829420 (10Jdforrester-WMF) 05Open>03Resolved Last wiki is now done, sa... [21:37:24] 10VisualEditor, 10WikiEditor, 10Community-Liaisons, 10Contributors-Team, and 9 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#3829425 (10Jdforrester-WMF) [21:37:32] 10VisualEditor, 10WikiEditor, 10Community-Liaisons, 10Contributors-Team, and 9 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#2428043 (10Jdforrester-WMF) [22:08:13] 10VisualEditor, 10VisualEditor-Initialisation, 10Browser-Support-Firefox: VisualEditor: Support Firefox 10-14 - https://phabricator.wikimedia.org/T43245#3829565 (10Krinkle) [22:44:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/397694 (owner: 10L10n-bot)