[09:46:18] 10VisualEditor: Switch magic word for showing VisualEditor edit button - https://phabricator.wikimedia.org/T182606#3830358 (10Elitre) If you want to force visual editing any page, you just need to provide a URL for that. [[ https://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&veaction=edit&action=edit |... [11:20:10] 10VisualEditor: Switch magic word for showing VisualEditor edit button - https://phabricator.wikimedia.org/T182606#3830514 (10Tacsipacsi) Placing the sandbox in the project namespace is merely a convention, but it’s because that’s the least illogical place. In which namespace should we place the VE sandbox than?... [12:16:30] 10VisualEditor: Extension of the Visual Editor namespaces on the French Wikiversity to "Project" (ns102) - https://phabricator.wikimedia.org/T182669#3830626 (10JackPotte) [15:06:27] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting HTML in NWE can't be undone via keyboard - https://phabricator.wikimedia.org/T182402#3822477 (10Esanders) Looks like selection is getting restored correctly after async paste. [15:33:50] 10VisualEditor, 10Community-Liaisons, 10Documentation, 10Google-Code-in-2017, 10Need-volunteer: Write a help page that explains how to create non conventional links (interlanguage, interproject, images and categories) - https://phabricator.wikimedia.org/T134186#3831296 (10Albert221) a:03Albert221 [15:49:24] (03CR) 10C. Scott Ananian: "poke! we're going to deploy the parsoid-side change today, it would be good to have this one riding the train at least." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396069 (https://phabricator.wikimedia.org/T97093) (owner: 10C. Scott Ananian) [16:04:25] (03CR) 10Sbailey: [C: 031] "Reviewed" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396069 (https://phabricator.wikimedia.org/T97093) (owner: 10C. Scott Ananian) [16:22:12] (03PS1) 10Esanders: Allow access to a fragment's async state [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/397861 [16:23:33] (03PS2) 10Esanders: Allow access to a fragment's async state [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/397861 [16:25:15] (03PS1) 10Esanders: Only resolve wikitext promise when progress dialog has closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/397862 (https://phabricator.wikimedia.org/T182402) [16:26:10] (03CR) 10jerkins-bot: [V: 04-1] Allow access to a fragment's async state [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/397861 (owner: 10Esanders) [16:31:10] (03CR) 10jerkins-bot: [V: 04-1] Only resolve wikitext promise when progress dialog has closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/397862 (https://phabricator.wikimedia.org/T182402) (owner: 10Esanders) [16:35:52] (03CR) 10Esanders: [C: 032] Interwiki links are a type of external link [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396069 (https://phabricator.wikimedia.org/T97093) (owner: 10C. Scott Ananian) [16:36:02] (03CR) 10Esanders: [C: 032] "unit test follow up would be nice too" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396069 (https://phabricator.wikimedia.org/T97093) (owner: 10C. Scott Ananian) [16:43:47] (03PS1) 10Esanders: Enable spellchecking on media caption inputs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/397866 (https://phabricator.wikimedia.org/T182393) [16:45:28] (03CR) 10C. Scott Ananian: "Could we get this one on the train today, too?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395831 (https://phabricator.wikimedia.org/T152540) (owner: 10C. Scott Ananian) [16:46:57] edsanders: i'll get you a unit test [16:47:05] * cscott loves tests [16:47:12] :) [16:51:38] edsanders: but maybe i could get a C+2 on https://gerrit.wikimedia.org/r/395831 in the meantime? [16:52:02] (03PS22) 10Esanders: WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [16:55:57] (03CR) 10Esanders: Strip legacy section IDs from inside headings (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395831 (https://phabricator.wikimedia.org/T152540) (owner: 10C. Scott Ananian) [16:56:05] cscott ^ [16:57:05] edsanders: what else would we stick an ID on? I guess maybe Cite nodes? [16:57:13] (03CR) 10Jforrester: [C: 032] Enable spellchecking on media caption inputs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/397866 (https://phabricator.wikimedia.org/T182393) (owner: 10Esanders) [16:57:25] I don't know, but I assume that's why you added the parentNode test? [16:57:25] s/an ID/a legacy ID/ [16:57:56] I was just being super precise, I didn't want to strip anything which might later turn out to be significant [16:58:38] I would have added it to querySelectorAll except I can't easily match all H* nodes :( [16:59:01] (there have been various proposals to replace

and friends with for exactly that reason, but AFAIK they have never gotten off the ground) [17:00:26] but if it makes getting a quick C+2 easier, I can make that change if you like. [17:00:43] yeah [17:01:14] if we need to support some other legacy id's in the future we can refine, but for now we can keep it simple and bin them all [17:01:35] the opposite "conservativeness" than mine, but sure ;) [17:02:06] indeed [17:04:38] (03Merged) 10jenkins-bot: Enable spellchecking on media caption inputs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/397866 (https://phabricator.wikimedia.org/T182393) (owner: 10Esanders) [17:05:17] cscott: FYI neither of those patches made the train. [17:05:39] boo, i'm supposed to have 55 minutes yet :( [17:06:25] Nope, it normally gets cut around 08:30 SF time. It gets *deployed* at 10:00 SF time. [17:06:39] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10User-Ryasmeen: Alt text for images should be spellchecked - https://phabricator.wikimedia.org/T182393#3831627 (10Deskana) 05Open>03Resolved p:05Triage>03Normal a:03Esanders [17:06:43] VE-MW for that is 28bc31f58a4f3b62e29b5d9401c4a846cb371c77 [17:08:22] (03CR) 10jenkins-bot: Enable spellchecking on media caption inputs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/397866 (https://phabricator.wikimedia.org/T182393) (owner: 10Esanders) [17:08:24] well, if they get merged at least they'll be handy for SWATting if necessary [17:08:27] Also, pet peeve is that I can't find out how to set git to default logs to `git log --topo-order --no-merges` [17:08:56] I don't expect them to actually be necessary when Parsoid's 1.6.0 HTML goes live (in my testing at least), but I've been surprised before [17:09:17] (03PS4) 10C. Scott Ananian: Strip legacy section IDs from inside headings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395831 [17:09:19] (03PS4) 10C. Scott Ananian: Interwiki links are a type of external link [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396069 (https://phabricator.wikimedia.org/T97093) [17:09:49] edsanders: Are you ever going to revisit https://gerrit.wikimedia.org/r/#/c/384579/ ? [17:11:15] maybe when the vendors get their shit together [17:16:23] (03PS5) 10C. Scott Ananian: Strip legacy section IDs from inside headings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395831 [17:16:25] (03PS5) 10C. Scott Ananian: Interwiki links are a type of external link [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396069 (https://phabricator.wikimedia.org/T97093) [17:16:28] (03PS1) 10C. Scott Ananian: WIP: Add test for fallback ids and interwiki links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/397877 [17:16:30] (03CR) 10jerkins-bot: [V: 04-1] Interwiki links are a type of external link [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396069 (https://phabricator.wikimedia.org/T97093) (owner: 10C. Scott Ananian) [17:19:46] edsanders: :-( [17:22:55] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add test for fallback ids and interwiki links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/397877 (owner: 10C. Scott Ananian) [17:23:54] (03PS6) 10C. Scott Ananian: Interwiki links are a type of external link [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396069 (https://phabricator.wikimedia.org/T97093) [17:27:17] (03CR) 10C. Scott Ananian: Strip legacy section IDs from inside headings (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395831 (owner: 10C. Scott Ananian) [17:46:08] (03CR) 10Esanders: [C: 032] Strip legacy section IDs from inside headings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395831 (owner: 10C. Scott Ananian) [17:53:21] (03Merged) 10jenkins-bot: Strip legacy section IDs from inside headings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395831 (owner: 10C. Scott Ananian) [17:54:59] (03CR) 10jenkins-bot: Strip legacy section IDs from inside headings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/395831 (owner: 10C. Scott Ananian) [18:52:12] (03PS2) 10Jforrester: Drop the never-finished "Labs" publish and preview features [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392899 [18:52:14] (03PS2) 10Jforrester: Follow-up 7815040: Remove the 'dialogs' config object, no longer read [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392900 [18:52:17] (03PS2) 10Jforrester: Radically simplify this extension now there's only one config option [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392901 [18:52:20] (03PS3) 10Jforrester: Merge all the non-styles-only ResourceLoader modules into one [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392902 (https://phabricator.wikimedia.org/T165112) [18:53:35] 10VisualEditor: Pages marked for translation are doing very strange things in VE - https://phabricator.wikimedia.org/T182704#3831919 (10atgo) [19:30:27] (03CR) 10Sbailey: [C: 031] "Reviewed" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/396069 (https://phabricator.wikimedia.org/T97093) (owner: 10C. Scott Ananian) [19:38:13] 10VisualEditor, 10MediaWiki-extensions-Translate: Pages marked for translation are doing very strange things in VE - https://phabricator.wikimedia.org/T182704#3832036 (10Deskana) p:05Triage>03High This is bad. This seems to be happening on any page that uses translation markup. I tested on mediawiki.org on... [19:48:03] (03PS3) 10Jforrester: build: Run karma unit tests with Firefox as well as Chrom{e|ium} [unicodejs] - 10https://gerrit.wikimedia.org/r/396389 (owner: 10Hashar) [19:48:36] (03CR) 10Jforrester: [C: 032] "No need for the complexity." [unicodejs] - 10https://gerrit.wikimedia.org/r/396389 (owner: 10Hashar) [19:51:01] (03Merged) 10jenkins-bot: build: Run karma unit tests with Firefox as well as Chrom{e|ium} [unicodejs] - 10https://gerrit.wikimedia.org/r/396389 (owner: 10Hashar) [19:51:56] (03CR) 10jenkins-bot: build: Run karma unit tests with Firefox as well as Chrom{e|ium} [unicodejs] - 10https://gerrit.wikimedia.org/r/396389 (owner: 10Hashar) [19:52:00] 10VisualEditor: If Template:! is actually transcluded on a page, VisualEditor still displays it as a pipe. - https://phabricator.wikimedia.org/T182576#3832127 (10Deskana) p:05Triage>03Low `{{!}}` is now a magic word. According to [[https://www.mediawiki.org/wiki/Help:Magic_words#Other|the documentation of th... [19:53:21] 10VisualEditor: VisualEditor adds to [[]] in a CSV file dragged to VE - https://phabricator.wikimedia.org/T182532#3832134 (10Deskana) p:05Triage>03Low [19:58:24] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review: Pasting HTML in NWE can't be undone via keyboard - https://phabricator.wikimedia.org/T182402#3832293 (10Deskana) p:05Triage>03Normal a:03Esanders [20:04:46] 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Visual Editor removing whitespace from infoboxes by default - https://phabricator.wikimedia.org/T179259#3832318 (10Arlolra) Another example confirming what was implemented, https://en.wikipedia.org/w/index.php?title=Yandex.Taxi&curid=48884802&diff=815101213&oldid=... [21:56:09] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/397955 (owner: 10L10n-bot) [22:50:52] 10VisualEditor, 10MediaWiki-Page-editing, 10MediaWiki-User-preferences, 10Patch-For-Review: Edit font preview in preferences uses a small font size for monospace - https://phabricator.wikimedia.org/T181324#3832717 (10Jdforrester-WMF) p:05Triage>03Low a:03Esanders [23:16:14] 10VisualEditor, 10Community-Liaisons, 10Documentation, 10Google-Code-in-2017, 10Need-volunteer: Write a help page that explains how to create non conventional links (interlanguage, interproject, images and categories) - https://phabricator.wikimedia.org/T134186#3832789 (10Albert221) Could someone please... [23:40:36] 10VisualEditor, 10Community-Liaisons, 10Documentation, 10Google-Code-in-2017, 10Need-volunteer: Write a help page that explains how to create non conventional links (interlanguage, interproject, images and categories) - https://phabricator.wikimedia.org/T134186#3832868 (10John_Broughton) I thought that t... [23:56:19] (03PS1) 10C. Scott Ananian: Bump Parsoid HTML version to 1.6.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/397982 [23:58:07] (03CR) 10Subramanya Sastry: [C: 031] Bump Parsoid HTML version to 1.6.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/397982 (owner: 10C. Scott Ananian) [23:58:09] (03CR) 10Arlolra: [C: 031] Bump Parsoid HTML version to 1.6.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/397982 (owner: 10C. Scott Ananian)