[08:26:49] 10VisualEditor, 10Browser-Support-Firefox: VisualEditor karma test fails on Firefox v52 - https://phabricator.wikimedia.org/T182626#3836688 (10hashar) p:05Triage>03Low //Setting priority to low, that is merely an enhancement and not blocking anything// I have just encountered that issue while testing the... [11:48:24] 10VisualEditor, 10Browser-Support-Firefox: VisualEditor karma test fails on Firefox v52 - https://phabricator.wikimedia.org/T182626#3837037 (10Deskana) [12:03:59] 10VisualEditor: Implement data collection for performance metrics - https://phabricator.wikimedia.org/T182610#3837077 (10Deskana) [12:04:01] 10Editing-team, 10VisualEditor, 10Contributors-Analysis, 10Patch-For-Review, 10User-Ryasmeen: Update edit-analysis dashboards to account for schema change - https://phabricator.wikimedia.org/T182620#3837073 (10Deskana) 05Open>03Resolved p:05Triage>03High [16:35:40] 10VisualEditor, 10Wikimedia-Site-requests, 10Patch-For-Review: Enable both "edit" and "edit code" tabs in Polish Wikipedia - https://phabricator.wikimedia.org/T181045#3837921 (10Deskana) I'm disappointed that this change was forced through by [[https://pl.wikipedia.org/w/index.php?title=MediaWiki:Common.js&d... [16:44:23] (03PS1) 10DLynch: Add section id to URI fragment on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/398285 (https://phabricator.wikimedia.org/T181075) [16:46:28] (03PS2) 10DLynch: Add section id to URI fragment on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/398285 (https://phabricator.wikimedia.org/T181075) [16:47:16] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: When you edit a section, the URL should include a link to the section - https://phabricator.wikimedia.org/T181075#3778802 (10DLynch) I have a patch for this: https://gerrit.wikimedia.org/r/#/c/398285/ [16:53:01] 10VisualEditor, 10Wikimedia-Site-requests, 10Patch-For-Review: Enable both "edit" and "edit code" tabs in Polish Wikipedia - https://phabricator.wikimedia.org/T181045#3837945 (10Wargo) >>! In T181045#3793377, @Deskana wrote: > Sadly, the premise of this discussion is incorrect. If an editor comes back after... [17:19:55] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor fails to load if a plugin is not loadable - https://phabricator.wikimedia.org/T172476#3499624 (10DLynch) 3 we can do fairly easily; the rest is harder. [mw.loader.using](https://doc.wikimedia.org/mediawiki-core/master/js/source/mediawiki.html#mw-loader-met... [17:37:57] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor fails to load if a plugin is not loadable - https://phabricator.wikimedia.org/T172476#3838090 (10DLynch) {F11830109} [19:18:09] 10VisualEditor, 10OOjs-UI: The link inspector can behave weirdly when editing links in tables and references - https://phabricator.wikimedia.org/T182907#3838345 (10Elitre) [19:24:31] 10VisualEditor, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Ryasmeen: Enable both "edit" and "edit code" tabs in Polish Wikipedia - https://phabricator.wikimedia.org/T181045#3838365 (10Deskana) 05Open>03Resolved The config change has now been deployed. The code on common.js is no longer neede... [19:25:46] Deskana: I filed a bug! ^ may or may not be an OOjs UI issue. [19:30:18] 10VisualEditor, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Ryasmeen: Enable both "edit" and "edit code" tabs in Polish Wikipedia - https://phabricator.wikimedia.org/T181045#3838396 (10Deskana) I [[https://pl.wikipedia.org/w/index.php?title=MediaWiki:Common.js&diff=51245735&oldid=51208336|removed... [19:50:03] 10VisualEditor: VE should support "hidden" and "describe" flags for language converter markup. - https://phabricator.wikimedia.org/T182910#3838444 (10cscott) [19:50:49] 10VisualEditor, 10Community-Liaisons, 10Wikimedia-Site-requests: Please enable VisualEditor at the Kazakh Wikipedia - https://phabricator.wikimedia.org/T97315#3838462 (10cscott) [19:50:51] 10VisualEditor, 10Tracking, 10User-Ryasmeen, 10VisualEditor pre-2015 work: VisualEditor: Non-English Wikipedia issues (tracking) - https://phabricator.wikimedia.org/T53792#3838464 (10cscott) [19:50:53] 10VisualEditor, 10Wikimedia-Site-requests, 10Chinese-Sites, 10User-notice: Enable VisualEditor by default for all users of all "phase 7" Wikipedias - https://phabricator.wikimedia.org/T93388#3838463 (10cscott) [19:50:55] 10VisualEditor, 10VisualEditor-ContentLanguage, 10Chinese-Sites, 10Epic, and 2 others: VisualEditor: Support "Language conversion blocks" for multi-script wikis - https://phabricator.wikimedia.org/T49411#3838465 (10cscott) 05Open>03Resolved a:03cscott >>! In T49411#3691289, @Deskana wrote: > I believ... [19:58:17] 10VisualEditor, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Ryasmeen: Enable both "edit" and "edit code" tabs in Polish Wikipedia - https://phabricator.wikimedia.org/T181045#3838487 (10Wostr) @Deskana As a person who placed here this request, I feel obligated to clarify a few issues. Firstly, I'm... [21:13:10] Kemayo: Boo. At a guess, it looks like our code to set the right 'editor' isn't being run for the save* events: [21:13:19] https://www.irccloud.com/pastebin/NFG0yFJ7/ [21:13:37] (The 2010 wikitext editor numbers look likely.) [21:31:19] James_F: Oh, yeah, that would be the case. It's why that earlier fatal error was happening. I should have made those provide the mode when I was also fixing up the way it *could* be a fatal. [21:31:45] Aha. [21:32:14] Kemayo: At least it won't affect the loaded/ready timing data. ;-) [21:38:21] (03PS1) 10DLynch: ArticleTargetEvents: Track editor mode on save events [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/398333 (https://phabricator.wikimedia.org/T182610) [21:39:50] That should cover it, I think. [21:50:49] (03CR) 10Jforrester: [C: 031] ArticleTargetEvents: Track editor mode on save events [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/398333 (https://phabricator.wikimedia.org/T182610) (owner: 10DLynch) [22:13:20] (03CR) 10Esanders: [C: 04-1] "Lots of repetition. Either create a new method or expand this.track?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/398333 (https://phabricator.wikimedia.org/T182610) (owner: 10DLynch) [22:15:59] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/398375 (owner: 10L10n-bot) [22:21:02] 10VisualEditor, 10VisualEditor-ContentEditable: I can't edit a a table with visual editor in Wikipedia article - https://phabricator.wikimedia.org/T182920#3838763 (10Thinker78) [22:23:26] (03PS2) 10DLynch: ArticleTargetEvents: Track editor mode on save events [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/398333 (https://phabricator.wikimedia.org/T182610) [22:23:51] (03CR) 10DLynch: "> Lots of repetition. Either create a new method or expand" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/398333 (https://phabricator.wikimedia.org/T182610) (owner: 10DLynch) [22:35:01] 10VisualEditor, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Ryasmeen: Enable both "edit" and "edit code" tabs in Polish Wikipedia - https://phabricator.wikimedia.org/T181045#3838800 (10Wargo) Misunderstanding. This disabled the whole feature. We asked to have two tabs by default for not logged in... [22:42:49] (03CR) 10Esanders: [C: 032] ArticleTargetEvents: Track editor mode on save events [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/398333 (https://phabricator.wikimedia.org/T182610) (owner: 10DLynch) [22:51:04] (03Merged) 10jenkins-bot: ArticleTargetEvents: Track editor mode on save events [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/398333 (https://phabricator.wikimedia.org/T182610) (owner: 10DLynch) [22:55:28] (03CR) 10jenkins-bot: ArticleTargetEvents: Track editor mode on save events [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/398333 (https://phabricator.wikimedia.org/T182610) (owner: 10DLynch) [23:06:03] (03PS3) 10Esanders: Add section id to URI fragment on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/398285 (https://phabricator.wikimedia.org/T181075) (owner: 10DLynch) [23:28:20] 10VisualEditor, 10VisualEditor-ContentEditable: I can't edit a a table with visual editor in Wikipedia article - https://phabricator.wikimedia.org/T182920#3838763 (10jhsoby) Have tested, and can reproduce. This is probably happening because the table is built using templates, but the normal prompt to edit the... [23:53:44] (03PS1) 10Jforrester: ArticleTargetEvents: Track editor mode on save events [extensions/VisualEditor] (wmf/1.31.0-wmf.12) - 10https://gerrit.wikimedia.org/r/398389 (https://phabricator.wikimedia.org/T182610) [23:54:33] 10VisualEditor, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Ryasmeen: Enable both "edit" and "edit code" tabs in Polish Wikipedia - https://phabricator.wikimedia.org/T181045#3777724 (10matmarex) We don't have an option in site configuration to do that right now. The options are: * `$wmgVisualEdit... [23:55:47] (03CR) 10Jforrester: [C: 04-1] "Is the bump of lib/ve intentional? If so, the commit message should explain why." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/398285 (https://phabricator.wikimedia.org/T181075) (owner: 10DLynch) [23:56:25] James_F: That's an accident. My shielding it from `commit -a` seems to have broken down somewhere. [23:56:50] Aha. [23:56:55] I'll drop it. [23:57:13] (03PS4) 10Jforrester: Add section id to URI fragment on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/398285 (https://phabricator.wikimedia.org/T181075) (owner: 10DLynch) [23:59:40] Thanks!