[00:02:10] 10VisualEditor, 10MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), 10Patch-For-Review, 10User-Ryasmeen: VE's whitespace normalization code in headings is being tripped up by html5 fallback ids in Parsoid's output for headings - https://phabricator.wikimedia.org/T183173#3919218 (10Deskana) 05... [00:10:28] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405751 (https://phabricator.wikimedia.org/T56299) (owner: 10Jforrester) [00:17:34] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (67548dc57) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405751 (https://phabricator.wikimedia.org/T56299) (owner: 10Jforrester) [00:31:21] 10Cite, 10MediaWiki-Parser: Extra spaces are meaningful in sfn (differs from article text behavior) - https://phabricator.wikimedia.org/T184912#3919272 (10David_J_Wilson) >>! In T184912#3900555, @Aklapper wrote: > ………… > (This task welcomes editing its task description to make it clearer by providing sect... [01:03:53] (03PS1) 10Divec: Create ve.EventEmitter with emitCatch, and use it throughout ve.dm [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405827 (https://phabricator.wikimedia.org/T185546) [01:11:10] (03PS3) 10Jforrester: Update VE core submodule to master (67548dc57) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405751 (https://phabricator.wikimedia.org/T56299) [01:14:10] (03PS1) 10Bartosz Dziewoński: Revert "Workaround missing child selector in OOUI for menuLayout" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405829 (https://phabricator.wikimedia.org/T185544) [01:14:20] (03CR) 10Bartosz Dziewoński: [C: 04-2] "To be merged after OOUI update." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405829 (https://phabricator.wikimedia.org/T185544) (owner: 10Bartosz Dziewoński) [01:17:12] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (67548dc57) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405751 (https://phabricator.wikimedia.org/T56299) (owner: 10Jforrester) [01:20:17] (03PS4) 10Jforrester: Update VE core submodule to master (67548dc57) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405751 (https://phabricator.wikimedia.org/T56299) [01:24:47] (03PS5) 10Jforrester: Update VE core submodule to master (67548dc57) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405751 (https://phabricator.wikimedia.org/T56299) [01:32:39] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (67548dc57) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405751 (https://phabricator.wikimedia.org/T56299) (owner: 10Jforrester) [05:48:12] (03PS1) 10Catrope: rebaser: Fix sequencing of server operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405832 [05:59:53] (03PS1) 10Catrope: SurfaceSynchronizer: Also translate selections that are not mentioned in the change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405833 [06:28:46] (03CR) 10Divec: [C: 032] SurfaceSynchronizer: Also translate selections that are not mentioned in the change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405833 (owner: 10Catrope) [06:33:08] (03Merged) 10jenkins-bot: SurfaceSynchronizer: Also translate selections that are not mentioned in the change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405833 (owner: 10Catrope) [06:34:52] (03CR) 10jenkins-bot: SurfaceSynchronizer: Also translate selections that are not mentioned in the change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405833 (owner: 10Catrope) [06:46:00] (03CR) 10Divec: [C: 032] rebaser: Fix sequencing of server operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405832 (owner: 10Catrope) [06:48:21] (03Merged) 10jenkins-bot: rebaser: Fix sequencing of server operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405832 (owner: 10Catrope) [06:50:56] (03CR) 10jenkins-bot: rebaser: Fix sequencing of server operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405832 (owner: 10Catrope) [07:01:27] (03PS2) 10Divec: Create ve.EventEmitter with emitCatch, and use it throughout ve.dm [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405827 (https://phabricator.wikimedia.org/T185546) [07:05:21] (03PS1) 10Divec: Disable undo/usurp within SurfaceSynchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405838 [07:54:09] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-DataModel: SurfaceSynchronizer doesn't propagate annotations first seen in a reverted change - https://phabricator.wikimedia.org/T185556#3919564 (10dchan) [08:36:02] 10VisualEditor: Undo doesn't work, if you switch to the visual mode - https://phabricator.wikimedia.org/T185542#3919020 (10Schnark) Probably caused by {b1ea5d618a5f}. [10:26:20] 10Citoid, 10VisualEditor, 10Operations, 10Services (watching), 10User-mobrovac: Wiley requests for DOI and some other publishers don't work in production - https://phabricator.wikimedia.org/T165105#3919661 (10The_RedBurn) From Twitter above: * 10.1080/03014223.1975.9517878 (tandfonline.com) The delay for... [14:40:01] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Community-Liaisons: Help some smaller Wikipedias' communities by writing the TemplateData and enabling citoid for them - https://phabricator.wikimedia.org/T127354#3919967 (10Ivi104) >>! In T127354#3915201, @Acamicamacaraca wrote: > @Mvolz its... [18:09:59] (03PS6) 10Jforrester: Update VE core submodule to master (67548dc57) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405751 (https://phabricator.wikimedia.org/T56299) [18:16:59] 10VisualEditor: Invisible character at end of line through copy&paste - https://phabricator.wikimedia.org/T185590#3920509 (10XanonymusX) [18:17:13] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (67548dc57) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405751 (https://phabricator.wikimedia.org/T56299) (owner: 10Jforrester) [18:20:25] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Invisible text in new wikitext editor - https://phabricator.wikimedia.org/T185184#3908649 (10XanonymusX) This sounds a lot like T171616 to me! There it has nothing to do with syntax highlighting, though. In any case I can still reproduce my problems,... [18:49:07] (03CR) 10DLynch: [C: 04-1] "Should add `jquery.textSelection` to the extension dependencies, I think." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/405668 (https://phabricator.wikimedia.org/T73363) (owner: 10Esanders) [18:59:13] (03PS7) 10DLynch: LinkContextItem: add a button to select the entire label [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) [19:11:55] (03PS1) 10Divec: ve.dm.Change: Truncate stores as well as transactions on conflict [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405926 [19:12:42] (03CR) 10Catrope: [C: 032] Disable undo/usurp within SurfaceSynchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405838 (owner: 10Divec) [19:16:32] (03Merged) 10jenkins-bot: Disable undo/usurp within SurfaceSynchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405838 (owner: 10Divec) [19:18:16] (03CR) 10jenkins-bot: Disable undo/usurp within SurfaceSynchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405838 (owner: 10Divec) [19:20:03] (03PS1) 10Divec: rebaser: Only apply artificial delay to submitChange events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405927 [19:21:48] (03PS2) 10Divec: ve.dm.Change: Truncate stores as well as transactions on conflict [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405926 [19:28:05] (03PS2) 10Divec: rebaser: Only apply artificial delay to submitChange events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405927 [19:37:48] (03PS8) 10DLynch: LinkContextItem: add a button to select the entire label [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) [19:57:36] 10VisualEditor, 10OOUI, 10Performance: VE spends time doing computed CSS to measure toolbars on init - https://phabricator.wikimedia.org/T185599#3920783 (10Esanders) [20:10:36] (03PS1) 10Jforrester: NWE: Don't attempt to set selection on unattached textarea [extensions/VisualEditor] (wmf/1.31.0-wmf.17) - 10https://gerrit.wikimedia.org/r/405933 (https://phabricator.wikimedia.org/T185304) [20:12:17] (03PS1) 10Esanders: Toolbars: Replace $.width with clientWidth/offsetWidth [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405934 (https://phabricator.wikimedia.org/T185599) [20:21:56] (03CR) 10Catrope: [C: 032] ve.dm.Change: Truncate stores as well as transactions on conflict [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405926 (owner: 10Divec) [20:24:58] (03PS1) 10Bartosz Dziewoński: ve.ui.DesktopContext: Remove unused CSS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405936 [20:25:00] (03PS1) 10Bartosz Dziewoński: ve.ui.DesktopContext: Remove old unnecessary CSS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405937 [20:26:14] (03Merged) 10jenkins-bot: ve.dm.Change: Truncate stores as well as transactions on conflict [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405926 (owner: 10Divec) [20:28:56] (03CR) 10jenkins-bot: ve.dm.Change: Truncate stores as well as transactions on conflict [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405926 (owner: 10Divec) [20:32:46] (03PS1) 10Esanders: Toolbars: Replace $.height with clientHeight/offsetHeight [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405940 (https://phabricator.wikimedia.org/T185599) [21:01:33] (03PS2) 10Esanders: Public API for the tempWikitextEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405746 (https://phabricator.wikimedia.org/T185279) [21:01:35] (03PS1) 10Esanders: Sync tempWikitextEditor just before building target, not on every change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405943 [21:11:35] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Firefox, 10MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), 10Patch-For-Review: NWE doesn't load in Firefox ESR - https://phabricator.wikimedia.org/T185304#3912336 (10matmarex) SWAT: https://wikitech.wikimedia.or... [21:22:14] (03CR) 10Jforrester: [C: 031] "When did we kill this class off?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405936 (owner: 10Bartosz Dziewoński) [21:44:43] (03CR) 10DLynch: [C: 032] Public API for the tempWikitextEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405746 (https://phabricator.wikimedia.org/T185279) (owner: 10Esanders) [21:53:34] (03CR) 10Bartosz Dziewoński: "We never had it, this instance was mistakenly renamed from .ve-ui-context-menu in d2dfb9ac4fe1c2b3ce679a2de63db8f612967219. The 'right: 0" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405936 (owner: 10Bartosz Dziewoński) [22:00:39] (03CR) 10Jforrester: [C: 032] ve.ui.DesktopContext: Remove unused CSS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405936 (owner: 10Bartosz Dziewoński) [22:02:26] (03Merged) 10jenkins-bot: ve.ui.DesktopContext: Remove unused CSS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405936 (owner: 10Bartosz Dziewoński) [22:05:10] (03CR) 10jenkins-bot: ve.ui.DesktopContext: Remove unused CSS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405936 (owner: 10Bartosz Dziewoński) [22:53:14] (03CR) 10Bartosz Dziewoński: [C: 032] Toolbars: Replace $.width with clientWidth/offsetWidth [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405934 (https://phabricator.wikimedia.org/T185599) (owner: 10Esanders) [22:53:16] (03CR) 10Bartosz Dziewoński: [C: 032] Toolbars: Replace $.height with clientHeight/offsetHeight [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405940 (https://phabricator.wikimedia.org/T185599) (owner: 10Esanders) [22:55:06] (03Merged) 10jenkins-bot: Toolbars: Replace $.width with clientWidth/offsetWidth [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405934 (https://phabricator.wikimedia.org/T185599) (owner: 10Esanders) [22:56:05] 10VisualEditor, 10VisualEditor-MediaWiki-Plugins, 10Collaboration-Team-Triage, 10StructuredDiscussions, 10TechCom-RFC: Inline discussion feature "discuss this" - https://phabricator.wikimedia.org/T185607#3921095 (10tstarling) [22:57:01] (03CR) 10jenkins-bot: Toolbars: Replace $.width with clientWidth/offsetWidth [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405934 (https://phabricator.wikimedia.org/T185599) (owner: 10Esanders) [22:58:12] (03CR) 10Esanders: [C: 04-1] Sync tempWikitextEditor just before building target, not on every change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405943 (owner: 10Esanders) [22:58:55] (03CR) 10DLynch: [C: 032] Sync tempWikitextEditor just before building target, not on every change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405943 (owner: 10Esanders) [22:59:12] (03CR) 10DLynch: [C: 04-1] Sync tempWikitextEditor just before building target, not on every change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405943 (owner: 10Esanders) [23:01:41] (03Merged) 10jenkins-bot: Toolbars: Replace $.height with clientHeight/offsetHeight [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405940 (https://phabricator.wikimedia.org/T185599) (owner: 10Esanders) [23:05:27] (03CR) 10jenkins-bot: Toolbars: Replace $.height with clientHeight/offsetHeight [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405940 (https://phabricator.wikimedia.org/T185599) (owner: 10Esanders) [23:09:21] (03CR) 10jerkins-bot: [V: 04-1] Public API for the tempWikitextEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405746 (https://phabricator.wikimedia.org/T185279) (owner: 10Esanders) [23:21:50] 10VisualEditor, 10VisualEditor-MediaWiki-Plugins, 10Collaboration-Team-Triage, 10StructuredDiscussions, 10TechCom-RFC: Provide an inline discussion feature, "DiscussThis" - https://phabricator.wikimedia.org/T185607#3921137 (10Jdforrester-WMF) [23:25:21] (03PS1) 10Bartosz Dziewoński: Use jQuery 3 .catch( fn ) instead of .then( null, fn ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405988 [23:40:31] (03PS1) 10Bartosz Dziewoński: Support 'safemode' parameter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405993 (https://phabricator.wikimedia.org/T185303) [23:41:02] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review: safemode parameter doesn't work with VE - https://phabricator.wikimedia.org/T185303#3921160 (10matmarex) a:03matmarex [23:42:50] (03CR) 10Bartosz Dziewoński: "Of note: in case we ever have VisualEditor on a page like Special:Preferences (perhaps to edit user signature?), after this change it will" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405993 (https://phabricator.wikimedia.org/T185303) (owner: 10Bartosz Dziewoński) [23:44:15] (03PS1) 10Catrope: [WIP] Failing test case for losing annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405994 [23:45:09] (03PS2) 10Esanders: Sync tempWikitextEditor just before building target, not on every change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405943 [23:45:11] (03PS3) 10Esanders: Public API for the tempWikitextEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405746 (https://phabricator.wikimedia.org/T185279) [23:45:13] (03PS2) 10Esanders: WIP Create transactions for changes to tempWikitextEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/403472 [23:46:36] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Failing test case for losing annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405994 (owner: 10Catrope) [23:50:20] (03CR) 10Jforrester: [WIP] Failing test case for losing annotations (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405994 (owner: 10Catrope) [23:51:55] (03CR) 10Jforrester: Support 'safemode' parameter (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405993 (https://phabricator.wikimedia.org/T185303) (owner: 10Bartosz Dziewoński) [23:56:33] 10VisualEditor, 10VisualEditor-MediaWiki-Plugins, 10Collaboration-Team-Triage, 10StructuredDiscussions, 10TechCom-RFC: Provide an inline discussion feature, "DiscussThis" - https://phabricator.wikimedia.org/T185607#3921024 (10Sj) Pubpub is experimenting with inline discussion (in addition to sidebar disc... [23:56:38] 10VisualEditor, 10VisualEditor-MediaWiki-Plugins, 10Collaboration-Team-Triage, 10StructuredDiscussions, 10TechCom-RFC: Provide an inline discussion feature, "DiscussThis" - https://phabricator.wikimedia.org/T185607#3921211 (10Sj) Pubpub is experimenting with inline discussion (in addition to sidebar disc... [23:57:52] (03CR) 10Jforrester: [C: 032] Use jQuery 3 .catch( fn ) instead of .then( null, fn ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/405988 (owner: 10Bartosz Dziewoński) [23:58:40] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review: safemode parameter doesn't work with VE - https://phabricator.wikimedia.org/T185303#3921213 (10Krinkle)