[00:54:13] (03CR) 10Legoktm: [C: 032] build: Update linters [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/408111 (owner: 10Esanders) [00:56:50] (03Merged) 10jenkins-bot: build: Update linters [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/408111 (owner: 10Esanders) [01:51:46] (03CR) 10Jforrester: [C: 032] Standardise origDoc property as originalDocument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408088 (owner: 10Esanders) [01:52:05] (03CR) 10Jforrester: [C: 032] Use plain ve.dm.Document for doc fragments, instead of self [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408226 (owner: 10Esanders) [01:54:19] (03Merged) 10jenkins-bot: Standardise origDoc property as originalDocument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408088 (owner: 10Esanders) [01:56:41] (03CR) 10jenkins-bot: Standardise origDoc property as originalDocument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408088 (owner: 10Esanders) [06:31:44] (03PS1) 10Divec: WIP: Fix getNodeAndOffset for MetaItems [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408236 (https://phabricator.wikimedia.org/T186109) [06:32:43] (03PS2) 10Divec: WIP: Fix getNodeAndOffset for MetaItems [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408236 (https://phabricator.wikimedia.org/T186109) [13:17:40] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10CirrusSearch, 10Discovery, 10Discovery-Search: Allow autocomplete (search) link selection in VE to tolerate more typos - https://phabricator.wikimedia.org/T186469#3945872 (10Deskana) Before I moved to the Editing team, I was the product manager for the Se... [14:32:26] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10CirrusSearch, 10Discovery, 10Discovery-Search: Allow autocomplete (search) link selection in VE to tolerate more typos - https://phabricator.wikimedia.org/T186469#3946045 (10tarlocesilion) Ofc, I didn't assume that there could be an English-centric bias.... [15:41:05] 10VisualEditor: Extending backwards selection beyond top of viewport doesn't scroll correctly - https://phabricator.wikimedia.org/T186472#3946356 (10Esanders) [15:49:06] 10VisualEditor: Extending backwards selection beyond top of viewport doesn't scroll correctly - https://phabricator.wikimedia.org/T186472#3944970 (10Esanders) I think the issue is that https://gerrit.wikimedia.org/r/#/c/328395/ assumed that start/endRects corresponded to anchor/focus points respectively, when in... [15:54:59] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10CirrusSearch, 10Discovery, 10Discovery-Search: Allow autocomplete (search) link selection in VE to tolerate more typos - https://phabricator.wikimedia.org/T186469#3946429 (10TJones) [15:59:03] 10WikiEditor: Preview tab has disappeared - https://phabricator.wikimedia.org/T185555#3946451 (10TheDJ) @TMagen i think the confusion comes from the fact that Gadgets are not officially supported software elements (and this is why they differ for each language/sister version of the wiki's) even though they are a... [16:06:08] (03PS1) 10Esanders: scrollCursorIntoView: Collapse selection to 'to' (anchor) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408289 (https://phabricator.wikimedia.org/T186472) [16:07:47] 10WikiEditor: Preview tab has disappeared - https://phabricator.wikimedia.org/T185555#3946482 (10TMagen) Thanks for the detailed explanation. I'll miss it. RIP. [16:21:11] (03CR) 10Jforrester: [C: 031] "Testable?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408289 (https://phabricator.wikimedia.org/T186472) (owner: 10Esanders) [16:22:27] (03CR) 10Jforrester: [C: 032] Use plain ve.dm.Document for doc fragments, instead of self [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408226 (owner: 10Esanders) [16:24:56] (03Merged) 10jenkins-bot: Use plain ve.dm.Document for doc fragments, instead of self [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408226 (owner: 10Esanders) [16:26:53] (03PS1) 10Jforrester: Update VE core submodule to master (ef55ee03a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408295 [16:27:46] (03CR) 10jenkins-bot: Use plain ve.dm.Document for doc fragments, instead of self [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408226 (owner: 10Esanders) [16:44:28] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10CirrusSearch, 10Discovery, 10Discovery-Search: Allow autocomplete (search) link selection in VE to tolerate more typos - https://phabricator.wikimedia.org/T186469#3946595 (10TJones) @tarlocesilion, can you point us to more info on the configuration of "to... [16:44:55] 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Visual Editor removing whitespace from infoboxes by default - https://phabricator.wikimedia.org/T179259#3946598 (10cscott) @Alsee in this case, if you had entries which were whitespace aligned, whichever editor put 'format:block' in the templatedata was at fault. i... [16:47:02] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10CirrusSearch, 10Discovery, 10Discovery-Search: Allow autocomplete (search) link selection in VE to tolerate more typos - https://phabricator.wikimedia.org/T186469#3946599 (10Deskana) >>! In T186469#3946045, @tarlocesilion wrote: > Ofc, I didn't assume tha... [17:20:49] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-UniversalLanguageSelector, 10MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), 10User-Ryasmeen: jQuery.IME not working in VisualEditor/2017 wikitext editor - https://phabricator.wikimedia.org/T176104#3946649 (1... [17:23:22] 10VisualEditor, 10MediaWiki-Page-deletion, 10MediaWiki-Page-editing, 10MediaWiki-Page-protection, 10MediaWiki-User-management: Update web UI for increased comment length - https://phabricator.wikimedia.org/T185948#3929312 (10matmarex) Is there a reason why CommentStore::COMMENT_CHARACTER_LIMIT (the magic... [17:27:15] 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Visual Editor removing whitespace from infoboxes by default - https://phabricator.wikimedia.org/T179259#3946703 (10Alsee) @cscott you suggested two options. One, you yet-again proposed "custom format string", which we have told you DOESN'T FIX ANYTHING. That will s... [17:37:24] 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Visual Editor removing whitespace from infoboxes by default - https://phabricator.wikimedia.org/T179259#3946756 (10ssastry) >>! In T179259#3943639, @Alsee wrote: > > As TheDJ tried to explain, as I tried to explain, we have all known for years that generating dirty... [17:52:29] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage: interface to support extensions that provide on-screen keyboards for Visual Editor - https://phabricator.wikimedia.org/T86479#3946822 (10Petar.petkovic) [17:52:58] (03PS1) 10Esanders: Use .isNull check for NullSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408316 (https://phabricator.wikimedia.org/T121347) [17:53:28] 10VisualEditor, 10MediaWiki-Page-deletion, 10MediaWiki-Page-editing, 10MediaWiki-Page-protection, 10MediaWiki-User-management: Update web UI for increased comment length - https://phabricator.wikimedia.org/T185948#3946831 (10Anomie) >>! In T185948#3946663, @matmarex wrote: > Is there a reason why Comment... [19:05:56] (03PS1) 10Jforrester: build: Move PHP files to expected paths [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408332 [19:05:58] (03PS1) 10Jforrester: phpcs: Don't try to be smart about excluding VE, it doens't worky [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408333 [19:10:01] (03PS2) 10Tchanders: Show diffs for references lists in place [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408227 (https://phabricator.wikimedia.org/T183118) [19:20:55] (03CR) 10jerkins-bot: [V: 04-1] build: Move PHP files to expected paths [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408332 (owner: 10Jforrester) [19:22:45] (03CR) 10jerkins-bot: [V: 04-1] phpcs: Don't try to be smart about excluding VE, it doens't worky [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408333 (owner: 10Jforrester) [19:25:15] (03PS2) 10Jforrester: build: Move PHP files to expected paths [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408332 [19:41:06] (03PS1) 10Jforrester: [POC] Don't show the Cite tool if the config lacks key parts [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/408344 (https://phabricator.wikimedia.org/T186276) [19:42:51] 10Citoid, 10VisualEditor, 10Patch-For-Review: Prevent citoid from being enabled unless all required keys are present in MediaWiki:Citoid-template-type-map.json - https://phabricator.wikimedia.org/T186276#3947240 (10Jdforrester-WMF) ^^^ This proof of concept checks on init for the map having `journalArticle`,... [19:43:29] 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Visual Editor removing whitespace from infoboxes by default - https://phabricator.wikimedia.org/T179259#3947242 (10Alsee) @ssastry I was hoping it would be sufficient to cite the known issue of dirty diffs and the fact that people clearly want this fixed. I previou... [19:57:52] (03PS2) 10Jforrester: phpcs: Don't try to be smart about excluding VE, it doens't worky [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408333 [19:58:10] (03PS3) 10Jforrester: phpcs: Don't try to be smart about excluding VE, it doesn't work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408333 [20:50:34] 10VisualEditor, 10MediaWiki-Page-deletion, 10MediaWiki-Page-editing, 10MediaWiki-Page-protection, 10MediaWiki-User-management: Update web UI for increased comment length - https://phabricator.wikimedia.org/T185948#3947469 (10matmarex) [21:09:49] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10CirrusSearch, 10Discovery, 10Discovery-Search: Allow autocomplete (search) link selection in VE to tolerate more typos - https://phabricator.wikimedia.org/T186469#3947553 (10tarlocesilion) > can you point us to more info on the configuration of "tolerated... [21:40:37] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408419 (owner: 10L10n-bot) [21:46:40] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Implement $.textSelection's encapsulateSelection in NWE - https://phabricator.wikimedia.org/T185917#3947674 (10matmarex) I've started working on this, and then realized that we should be able to implement $.textSelection's encapsulateSelection in ter... [21:48:56] (03PS1) 10Esanders: Fix byteLimit/byteLength dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408431 [21:54:04] 10VisualEditor: Visual editor gives erroneous warning about missing edit summary when switching editing modes - https://phabricator.wikimedia.org/T186531#3947682 (10Zoranzoki21) [23:08:24] (03CR) 10Jforrester: [C: 032] Fix byteLimit/byteLength dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408431 (owner: 10Esanders) [23:09:44] 10Citoid, 10VisualEditor, 10Services (done), 10User-Ryasmeen: unable to make citation for http://apps.who.int/iris/handle/10665/70863 - https://phabricator.wikimedia.org/T186395#3947805 (10mobrovac) 05Open>03Resolved Fix merged and deployed. Resolving. [23:16:37] (03Merged) 10jenkins-bot: Fix byteLimit/byteLength dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408431 (owner: 10Esanders) [23:31:01] (03PS1) 10Bartosz Dziewoński: ve.ui.MWWikitextSurface: Remove unnecessary textSelection 'encapsulateSelection' override [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408466 (https://phabricator.wikimedia.org/T185917) [23:32:28] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review: Implement $.textSelection's encapsulateSelection in NWE - https://phabricator.wikimedia.org/T185917#3947879 (10matmarex) On second thought, I'm not sure if that was the best idea… This now essentially works by replacing the enti... [23:40:19] (03CR) 10jenkins-bot: Fix byteLimit/byteLength dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408431 (owner: 10Esanders)