[00:04:48] (03PS1) 10Jforrester: Update VE core submodule to master (2ac0e8b0c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408721 (https://phabricator.wikimedia.org/T121347) [00:06:15] (03Merged) 10jenkins-bot: Add trailing linebreak to NWE's temporary wikitext editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/407499 (https://phabricator.wikimedia.org/T185632) (owner: 10Esanders) [00:18:03] 10VisualEditor, 10VisualEditor-ContentEditable, 10Technical-Debt: Abstract more selection handling by selection type - https://phabricator.wikimedia.org/T121347#3951140 (10Jdforrester-WMF) With that merged, there are still 30 `instanceof` calls in ve.ce.Surface.js. How many is "done"? [00:18:53] 10VisualEditor, 10VisualEditor-ContentEditable, 10Patch-For-Review: Extending backwards selection beyond top of viewport doesn't scroll correctly - https://phabricator.wikimedia.org/T186472#3951146 (10Jdforrester-WMF) p:05Triage>03Normal a:03Esanders [00:37:46] (03PS1) 10VolkerE: Update OOUI to v0.25.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408727 [00:38:59] (03CR) 10jenkins-bot: Add trailing linebreak to NWE's temporary wikitext editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/407499 (https://phabricator.wikimedia.org/T185632) (owner: 10Esanders) [00:39:33] (03CR) 10Jforrester: [C: 032] Update OOUI to v0.25.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408727 (owner: 10VolkerE) [00:40:17] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10User-Ryasmeen: No trailing newline in temporary wikitext editor - https://phabricator.wikimedia.org/T185632#3951205 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03Esanders [00:45:29] (03Merged) 10jenkins-bot: Update OOUI to v0.25.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408727 (owner: 10VolkerE) [00:47:16] (03CR) 10jenkins-bot: Update OOUI to v0.25.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408727 (owner: 10VolkerE) [00:55:46] 10TemplateData, 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Create shortcut/alias for aligned parameter style in TemplateData - https://phabricator.wikimedia.org/T186632#3951229 (10Alsee) Is there a reason this is a subtask of T179259? They both involve working on the same region of code, but the tasks ar... [01:16:18] 10TemplateData, 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Create shortcut/alias for aligned parameter style in TemplateData - https://phabricator.wikimedia.org/T186632#3951283 (10kaldari) I made it a subtask since it is designed to mitigate the effects of T179259, but doesn't entirely solve the issue. [01:44:38] (03CR) 10Bartosz Dziewoński: "Should be safe to merge now." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405829 (https://phabricator.wikimedia.org/T185544) (owner: 10Bartosz Dziewoński) [02:03:50] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (2ac0e8b0c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408721 (https://phabricator.wikimedia.org/T121347) (owner: 10Jforrester) [02:15:00] (03Merged) 10jenkins-bot: Update VE core submodule to master (2ac0e8b0c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408721 (https://phabricator.wikimedia.org/T121347) (owner: 10Jforrester) [02:16:49] (03CR) 10jenkins-bot: Update VE core submodule to master (2ac0e8b0c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408721 (https://phabricator.wikimedia.org/T121347) (owner: 10Jforrester) [09:08:18] 10TemplateData, 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Create shortcut/alias for aligned parameter style in TemplateData - https://phabricator.wikimedia.org/T186632#3951773 (10Alsee) @kaldari it doesn't mitigate T179259 at all. It is as likely to //increase// dirty diffs as to reduce them, and it does... [09:08:59] 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Visual Editor removing whitespace from infoboxes by default - https://phabricator.wikimedia.org/T179259#3951775 (10Alsee) [09:09:02] 10TemplateData, 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Create shortcut/alias for aligned parameter style in TemplateData - https://phabricator.wikimedia.org/T186632#3951774 (10Alsee) [10:47:27] 10Citoid, 10VisualEditor, 10Services (done), 10User-Ryasmeen: TypeError thrown and prevented citation of any website which contained multiple dublinCore identifiers, multiple bePress dois, or multiple highwirePress dois - https://phabricator.wikimedia.org/T186395#3951909 (10Mvolz) [10:51:33] 10VisualEditor, 10VisualEditor-VisualDiffs: Remove added 15px of left margin from historical visual diffs - https://phabricator.wikimedia.org/T186636#3950168 (10Esanders) The padding is for showing the move markers: {F13186227} In the historical diffs there is already a margin, so we should apply a negative m... [10:59:28] 10VisualEditor, 10VisualEditor-VisualDiffs: Remove added 15px of left margin from historical visual diffs - https://phabricator.wikimedia.org/T186636#3951945 (10Esanders) Removing the margin would be a problem in Monobook though: {F13186510} These left margin markers may not exist after the next design iterat... [11:02:06] 10VisualEditor, 10VisualEditor-VisualDiffs: Remove added 15px of left margin from historical visual diffs - https://phabricator.wikimedia.org/T186636#3951962 (10Esanders) We could also track if there were any moves at all and only show the margin in those cases, similar to what we do with the right sidebar. [11:21:28] (03PS1) 10Esanders: DiffElement: Only show left margin if moves present [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408779 (https://phabricator.wikimedia.org/T186636) [14:35:37] 10VisualEditor: The insert menu in VE is awkward - https://phabricator.wikimedia.org/T135099#3952589 (10jeblad) 05stalled>03Invalid [14:36:31] (03CR) 10Esanders: [C: 032] Revert "Workaround missing child selector in OOUI for menuLayout" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405829 (https://phabricator.wikimedia.org/T185544) (owner: 10Bartosz Dziewoński) [14:40:41] (03Merged) 10jenkins-bot: Revert "Workaround missing child selector in OOUI for menuLayout" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405829 (https://phabricator.wikimedia.org/T185544) (owner: 10Bartosz Dziewoński) [14:43:20] (03CR) 10jenkins-bot: Revert "Workaround missing child selector in OOUI for menuLayout" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/405829 (https://phabricator.wikimedia.org/T185544) (owner: 10Bartosz Dziewoński) [14:47:54] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review: Implement $.textSelection's encapsulateSelection in NWE - https://phabricator.wikimedia.org/T185917#3952631 (10Esanders) (NB there is another textSelection implementation in CodeMirror that is 90% encapsulateSelection) [14:49:10] 10VisualEditor: [feature request] User scenario to fix old raw references - https://phabricator.wikimedia.org/T179773#3952656 (10jeblad) Yes, but it is still very awkward to do the remaining updates. [14:51:46] (03CR) 10Esanders: [C: 04-1] "Per James" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408466 (https://phabricator.wikimedia.org/T185917) (owner: 10Bartosz Dziewoński) [14:56:15] (03CR) 10Esanders: Block duplicate parameter names when editing existing parameters (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/407470 (https://phabricator.wikimedia.org/T166520) (owner: 10DLynch) [15:05:06] 10VisualEditor, 10VisualEditor-ContentEditable, 10I18n, 10RTL, 10Upstream: thgir sevom worra tfel+tfihs | shift+left arrow moves right - https://phabricator.wikimedia.org/T186265#3952751 (10Esanders) [15:07:50] 10VisualEditor, 10VisualEditor-ContentEditable, 10I18n, 10RTL, 10Upstream: thgir sevom worra tfel+tfihs | shift+left arrow moves right - https://phabricator.wikimedia.org/T186265#3952755 (10Esanders) 05Open>03declined We deliberately (and a great expense) defer to the browser for cursor movement. [15:19:54] 10VisualEditor, 10MediaWiki-General-or-Unknown: MediaWiki's feedback tool interface is confusing, and may make it unclear how to submit reports - https://phabricator.wikimedia.org/T100011#3952782 (10Elitre) [16:05:17] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Patch-For-Review: Remove added 15px of left margin from historical visual diffs - https://phabricator.wikimedia.org/T186636#3952927 (10TheDJ) I like that solution Ed ! nice work. [17:09:51] (03PS3) 10DLynch: Block duplicate parameter names when editing existing parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/407470 (https://phabricator.wikimedia.org/T166520) [18:08:05] 10VisualEditor: VisualEditor toolbar overlaps with Minerva header - https://phabricator.wikimedia.org/T186735#3953467 (10Jdlrobson) [18:08:30] 10VisualEditor: VisualEditor toolbar overlaps with Minerva header - https://phabricator.wikimedia.org/T186735#3953493 (10Jdlrobson) [18:51:25] (03PS3) 10Jforrester: build: Move PHP files to expected paths [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408332 [18:51:27] (03PS4) 10Jforrester: phpcs: Don't try to be smart about excluding VE, it doesn't work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408333 [18:53:10] (03PS2) 10Jforrester: ve.ui.MWWikitextSurface: Remove unnecessary textSelection 'encapsulateSelection' override [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408466 (https://phabricator.wikimedia.org/T185917) (owner: 10Bartosz Dziewoński) [18:53:16] (03CR) 10Jforrester: [C: 032] ve.ui.MWWikitextSurface: Remove unnecessary textSelection 'encapsulateSelection' override [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408466 (https://phabricator.wikimedia.org/T185917) (owner: 10Bartosz Dziewoński) [18:54:22] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.MWWikitextSurface: Remove unnecessary textSelection 'encapsulateSelection' override [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408466 (https://phabricator.wikimedia.org/T185917) (owner: 10Bartosz Dziewoński) [18:54:36] (03CR) 10Jforrester: [C: 031] ve.ui.MWWikitextSurface: Remove unnecessary textSelection 'encapsulateSelection' override [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408466 (https://phabricator.wikimedia.org/T185917) (owner: 10Bartosz Dziewoński) [19:48:51] (03PS1) 10Jforrester: Revert "Use wgEditSubmitButtonLabelPublish from upstream" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408860 [19:48:58] (03CR) 10Jforrester: [C: 032] Revert "Use wgEditSubmitButtonLabelPublish from upstream" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408860 (owner: 10Jforrester) [19:52:53] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Switching from 2010 WTE (e.g. edit conflict) to VE and then to 2017 WTE throws a JS fatal - https://phabricator.wikimedia.org/T186743#3953875 (10Jdforrester-WMF) [19:52:57] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Switching from 2010 WTE (e.g. edit conflict) to VE and then to 2017 WTE throws a JS fatal - https://phabricator.wikimedia.org/T186744#3953885 (10Jdforrester-WMF) [19:57:29] 10VisualEditor, 10VisualEditor-ContentEditable, 10MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), 10User-Ryasmeen: Extending backwards selection beyond top of viewport doesn't scroll correctly - https://phabricator.wikimedia.org/T186472#3953919 (10Jdforrester-WMF) 05Open>03Resolved [19:58:17] (03Merged) 10jenkins-bot: Revert "Use wgEditSubmitButtonLabelPublish from upstream" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408860 (owner: 10Jforrester) [19:59:24] (03CR) 10Jforrester: [C: 032] DiffElement: Only show left margin if moves present [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408779 (https://phabricator.wikimedia.org/T186636) (owner: 10Esanders) [20:00:01] (03CR) 10jenkins-bot: Revert "Use wgEditSubmitButtonLabelPublish from upstream" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408860 (owner: 10Jforrester) [20:00:13] (03PS1) 10Jforrester: Revert "Use wgEditSubmitButtonLabelPublish from upstream" [extensions/VisualEditor] (wmf/1.31.0-wmf.20) - 10https://gerrit.wikimedia.org/r/408861 [20:01:51] (03Merged) 10jenkins-bot: DiffElement: Only show left margin if moves present [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408779 (https://phabricator.wikimedia.org/T186636) (owner: 10Esanders) [20:03:39] (03CR) 10jenkins-bot: DiffElement: Only show left margin if moves present [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408779 (https://phabricator.wikimedia.org/T186636) (owner: 10Esanders) [20:08:51] (03CR) 10Jforrester: [C: 031] Block duplicate parameter names when editing existing parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/407470 (https://phabricator.wikimedia.org/T166520) (owner: 10DLynch) [20:14:17] (03PS1) 10Esanders: Assume wpTextbox1 has an API registered already [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408865 (https://phabricator.wikimedia.org/T186743) [20:15:25] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review: Switching from 2010 WTE (e.g. edit conflict) to VE and then to 2017 WTE throws a JS fatal - https://phabricator.wikimedia.org/T186743#3953875 (10Esanders) We don't unload the 2010 editor at all... [20:16:49] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review: Switching from 2010 WTE (e.g. edit conflict) to VE and then to 2017 WTE throws a JS fatal - https://phabricator.wikimedia.org/T186743#3953995 (10Jdforrester-WMF) >>! In T186743#3953977, @Esanders wrote: > We don't unload the 201... [20:18:06] (03PS3) 10Esanders: Show diffs for references lists in place [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408227 (https://phabricator.wikimedia.org/T183118) (owner: 10Tchanders) [20:22:07] (03CR) 10Jforrester: [C: 032] Assume wpTextbox1 has an API registered already [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408865 (https://phabricator.wikimedia.org/T186743) (owner: 10Esanders) [20:25:59] (03PS4) 10Jforrester: build: Bring SVGO optimization to 'ci' step [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/407189 (https://phabricator.wikimedia.org/T185596) (owner: 10VolkerE) [20:26:33] (03CR) 10Jforrester: [C: 032] build: Bring SVGO optimization to 'ci' step [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/407189 (https://phabricator.wikimedia.org/T185596) (owner: 10VolkerE) [20:29:28] (03Merged) 10jenkins-bot: build: Bring SVGO optimization to 'ci' step [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/407189 (https://phabricator.wikimedia.org/T185596) (owner: 10VolkerE) [20:29:30] (03Merged) 10jenkins-bot: Assume wpTextbox1 has an API registered already [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408865 (https://phabricator.wikimedia.org/T186743) (owner: 10Esanders) [20:29:58] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Switching from 2010 WTE (e.g. edit conflict) to VE and then to 2017 WTE throws a JS fatal - https://phabricator.wikimedia.org/T186744#3954007 (10Esanders) [20:30:01] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review: Switching from 2010 WTE (e.g. edit conflict) to VE and then to 2017 WTE throws a JS fatal - https://phabricator.wikimedia.org/T186743#3954009 (10Esanders) [20:31:14] (03CR) 10jenkins-bot: Assume wpTextbox1 has an API registered already [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408865 (https://phabricator.wikimedia.org/T186743) (owner: 10Esanders) [20:31:16] (03CR) 10jenkins-bot: build: Bring SVGO optimization to 'ci' step [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/407189 (https://phabricator.wikimedia.org/T185596) (owner: 10VolkerE) [20:31:56] (03PS4) 10Jforrester: build: Move PHP files to expected paths [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408332 [20:31:58] (03PS5) 10Jforrester: phpcs: Don't try to be smart about excluding VE, it doesn't work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408333 [20:33:22] (03CR) 10Jforrester: LinkContextItem: add a button to select the entire label (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [21:13:08] (03CR) 10VolkerE: "Excited about this, just for understanding: Why is 'ci' preferred?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/407189 (https://phabricator.wikimedia.org/T185596) (owner: 10VolkerE) [21:19:17] (03CR) 10Jforrester: [C: 032] ""By adding this to the 'ci' step, it won't slow down regular development," [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/407189 (https://phabricator.wikimedia.org/T185596) (owner: 10VolkerE) [21:21:02] (03PS1) 10Jforrester: Assume wpTextbox1 has an API registered already [extensions/VisualEditor] (wmf/1.31.0-wmf.20) - 10https://gerrit.wikimedia.org/r/408924 (https://phabricator.wikimedia.org/T186743) [21:26:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408918 (owner: 10L10n-bot) [22:05:46] (03PS3) 10Jforrester: build: Use SVGO option of 'grunt-image' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/407184 (https://phabricator.wikimedia.org/T185596) (owner: 10VolkerE) [22:06:34] (03PS4) 10Jforrester: build: Use SVGO option of 'grunt-image' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/407184 (https://phabricator.wikimedia.org/T185596) (owner: 10VolkerE) [22:07:21] (03CR) 10Jforrester: build: Use SVGO option of 'grunt-image' (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/407184 (https://phabricator.wikimedia.org/T185596) (owner: 10VolkerE) [22:07:42] (03CR) 10Jforrester: [C: 031] build: Use SVGO option of 'grunt-image' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/407184 (https://phabricator.wikimedia.org/T185596) (owner: 10VolkerE) [22:22:39] 10VisualEditor, 10Collaboration-Team-Triage, 10StructuredDiscussions: Broken section links in VE in StructuredDiscussions - https://phabricator.wikimedia.org/T186088#3933316 (10Catrope) Does this happen in a "normal" VisualEditor instance (when editing an article) too, or only in SD? [22:23:14] 10VisualEditor, 10Collaboration-Team-Triage, 10StructuredDiscussions: Broken section links in VE in StructuredDiscussions - https://phabricator.wikimedia.org/T186088#3954323 (10Catrope) Also what Elena said sounds like it's actually correct behavior: the href of the link is correct. [22:39:30] (03CR) 10Esanders: "This should wait for https://gerrit.wikimedia.org/r/#/c/408604/" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408227 (https://phabricator.wikimedia.org/T183118) (owner: 10Tchanders) [23:16:17] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Design: Have Show preview and Review your changes more directly accessible in the New Wikitext Editor - https://phabricator.wikimedia.org/T153306#3954464 (10Alsee) Adding [[ https://www.mediawiki.org/wiki/Topic:U77456xp6560xxv9 | another complain...