[00:18:26] (03CR) 10EBernhardson: [C: 032] Revert "Use wgEditSubmitButtonLabelPublish from upstream" [extensions/VisualEditor] (wmf/1.31.0-wmf.20) - 10https://gerrit.wikimedia.org/r/408861 (owner: 10Jforrester) [00:18:28] (03CR) 10EBernhardson: [C: 032] Assume wpTextbox1 has an API registered already [extensions/VisualEditor] (wmf/1.31.0-wmf.20) - 10https://gerrit.wikimedia.org/r/408924 (https://phabricator.wikimedia.org/T186743) (owner: 10Jforrester) [00:26:27] (03Merged) 10jenkins-bot: Revert "Use wgEditSubmitButtonLabelPublish from upstream" [extensions/VisualEditor] (wmf/1.31.0-wmf.20) - 10https://gerrit.wikimedia.org/r/408861 (owner: 10Jforrester) [00:27:38] (03Merged) 10jenkins-bot: Assume wpTextbox1 has an API registered already [extensions/VisualEditor] (wmf/1.31.0-wmf.20) - 10https://gerrit.wikimedia.org/r/408924 (https://phabricator.wikimedia.org/T186743) (owner: 10Jforrester) [00:38:16] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), 10Patch-For-Review, 10User-Ryasmeen: Switching from 2010 WTE (e.g. edit conflict) to VE and then to 2017 WTE throws a JS fatal - https://phabricator.wikimedia.org/T186743#3954632 (... [04:18:38] (03PS3) 10Divec: Fix getNodeAndOffset for MetaItems [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408236 (https://phabricator.wikimedia.org/T186109) [04:22:27] (03CR) 10Divec: Fix getNodeAndOffset for MetaItems (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408236 (https://phabricator.wikimedia.org/T186109) (owner: 10Divec) [04:24:46] Minor scream and feedback. After spending days trying to get visual editor to work, and failing. I deleted it. Too many different programs to install, and just too complicated. Either that or I'm more ignorant than I thought. [06:03:42] (03PS5) 10VolkerE: build: Use SVGO option of 'grunt-image' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/407184 (https://phabricator.wikimedia.org/T185596) [06:07:12] (03CR) 10VolkerE: [C: 031] build: Use SVGO option of 'grunt-image' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/407184 (https://phabricator.wikimedia.org/T185596) (owner: 10VolkerE) [06:14:29] (03PS3) 10VolkerE: Re-crush beta feature SVG screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408582 (owner: 10Jforrester) [06:15:36] (03CR) 10VolkerE: [C: 031] "Further optimized images based on I318494488c8caad842a2d0dd93e7353f8d05b08e, but holding on to "search-*" paths. Also fixed VisualEditor-r" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408582 (owner: 10Jforrester) [07:22:49] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Epic, 10MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), and 2 others: Move visual diff out of beta in visual and 2017 wikitext editors - https://phabricator.wikimedia.org/T178248#3685827 (10Alsee) When I saw Visual Diff was coming our of beta and... [07:23:10] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Epic, 10MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), and 2 others: Move visual diff out of beta in visual and 2017 wikitext editors - https://phabricator.wikimedia.org/T178248#3954872 (10Alsee) 05Resolved>03Open [09:06:59] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408980 (owner: 10L10n-bot) [11:25:47] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Community-Liaisons: Help some smaller Wikipedias' communities by writing the TemplateData and enabling citoid for them - https://phabricator.wikimedia.org/T127354#3955215 (10Mvolz) @Whatamidoing-WMF - so I just enabled ta wiki. Interestingly... [11:50:33] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Community-Liaisons: Help some smaller Wikipedias' communities by writing the TemplateData and enabling citoid for them - https://phabricator.wikimedia.org/T127354#3955273 (10Acamicamacaraca) [12:07:05] (03CR) 10Esanders: [C: 032] Re-crush beta feature SVG screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408582 (owner: 10Jforrester) [12:09:15] (03CR) 10Esanders: [C: 032] Fix getNodeAndOffset for MetaItems [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408236 (https://phabricator.wikimedia.org/T186109) (owner: 10Divec) [12:10:51] (03PS1) 10Esanders: demo: Rename from deprecated OOUI method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/409003 [12:12:34] (03Merged) 10jenkins-bot: Fix getNodeAndOffset for MetaItems [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408236 (https://phabricator.wikimedia.org/T186109) (owner: 10Divec) [12:15:27] (03CR) 10jenkins-bot: Fix getNodeAndOffset for MetaItems [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408236 (https://phabricator.wikimedia.org/T186109) (owner: 10Divec) [12:18:29] (03Merged) 10jenkins-bot: Re-crush beta feature SVG screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408582 (owner: 10Jforrester) [12:20:11] (03CR) 10jenkins-bot: Re-crush beta feature SVG screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408582 (owner: 10Jforrester) [13:22:27] (03PS2) 10Mvolz: [POC] Don't show the Cite tool if the config lacks any required key [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/408344 (https://phabricator.wikimedia.org/T186276) (owner: 10Jforrester) [14:21:03] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Patch-For-Review: Only show 15px of left margin from historical visual diffs when the diff contains a move - https://phabricator.wikimedia.org/T186636#3955600 (10Deskana) [14:21:33] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10User-Ryasmeen: Only show 15px of left margin from historical visual diffs when the diff contains a move - https://phabricator.wikimedia.org/T186636#3955604 (10Deskana) 05Open>03Resolved a:03Esanders Thanks for the feedback, @TheDJ! [15:49:15] 10Citoid, 10VisualEditor, 10Wikimedia-Site-requests: Disallow adding Czech language tag (cs-CZ) into citation templates on cswiki - https://phabricator.wikimedia.org/T156548#2979314 (10TheDJ) When I read: "I do not understand why developers do not want to accept the fact that each Wiki has citation templates... [15:57:23] 10Citoid, 10VisualEditor, 10Wikimedia-Site-requests: Disallow adding Czech language tag (cs-CZ) into citation templates on cswiki - https://phabricator.wikimedia.org/T156548#3955919 (10Mvolz) As noted earlier, there are several options: # You can remove the language parameter entirely from the citoid map i... [16:28:13] (03CR) 10Esanders: [C: 032] Block duplicate parameter names when editing existing parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/407470 (https://phabricator.wikimedia.org/T166520) (owner: 10DLynch) [16:37:22] (03Merged) 10jenkins-bot: Block duplicate parameter names when editing existing parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/407470 (https://phabricator.wikimedia.org/T166520) (owner: 10DLynch) [16:40:56] (03CR) 10jenkins-bot: Block duplicate parameter names when editing existing parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/407470 (https://phabricator.wikimedia.org/T166520) (owner: 10DLynch) [17:21:07] (03CR) 10Jforrester: [C: 032] demo: Rename from deprecated OOUI method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/409003 (owner: 10Esanders) [17:23:36] (03Merged) 10jenkins-bot: demo: Rename from deprecated OOUI method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/409003 (owner: 10Esanders) [17:25:30] (03CR) 10jenkins-bot: demo: Rename from deprecated OOUI method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/409003 (owner: 10Esanders) [17:41:12] (03PS6) 10Jforrester: build: Use SVGO option of 'grunt-image' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/407184 (https://phabricator.wikimedia.org/T185596) (owner: 10VolkerE) [17:41:35] (03CR) 10Jforrester: [C: 032] build: Use SVGO option of 'grunt-image' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/407184 (https://phabricator.wikimedia.org/T185596) (owner: 10VolkerE) [17:41:58] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Beta-Feature, 10MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), 10User-notice: Make historical VisualDiffs a BetaFeature - https://phabricator.wikimedia.org/T185708#3956189 (10Deskana) I [[https://meta.wikimedia.org/w/index.php?title=Tech/News/... [17:49:59] (03Merged) 10jenkins-bot: build: Use SVGO option of 'grunt-image' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/407184 (https://phabricator.wikimedia.org/T185596) (owner: 10VolkerE) [17:51:12] 10VisualEditor, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 10Design: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype - https://phabricator.wikimedia.org/T124305#1952432 (10Deskana) >>! In T124305#2134010, @gerritbot wrote: > C... [17:53:44] (03CR) 10jenkins-bot: build: Use SVGO option of 'grunt-image' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/407184 (https://phabricator.wikimedia.org/T185596) (owner: 10VolkerE) [17:55:36] 10VisualEditor, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 10Design: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype - https://phabricator.wikimedia.org/T124305#3956215 (10DLynch) @Deskana Sorry, I forgot that I'd put all my s... [18:24:25] (03CR) 10Esanders: [C: 032] phpcs: Don't try to be smart about excluding VE, it doesn't work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408333 (owner: 10Jforrester) [18:25:04] (03CR) 10Esanders: [C: 032] build: Move PHP files to expected paths [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408332 (owner: 10Jforrester) [18:34:38] (03Merged) 10jenkins-bot: build: Move PHP files to expected paths [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408332 (owner: 10Jforrester) [18:36:58] (03CR) 10jenkins-bot: build: Move PHP files to expected paths [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408332 (owner: 10Jforrester) [18:45:16] 10VisualEditor, 10VisualEditor-MediaWiki, 10Community-Tech, 10Front-end-Standards-Group, and 2 others: [Epic] VisualEditor: Implement some form of auto-save - https://phabricator.wikimedia.org/T57370#3956332 (10TBolliger) [18:55:20] (03PS3) 10Bartosz Dziewoński: ve.ui.MWWikitextSurface: Implement textSelection 'replaceSelection', 'encapsulateSelection' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408466 (https://phabricator.wikimedia.org/T185917) [18:55:22] (03PS1) 10Bartosz Dziewoński: ve.ui.MWWikitextSurface: Make 'textSelection' API chainable methods really chainable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/409111 [18:58:13] edsanders: ^ [18:58:25] anyone here has safari 5.1 handy to see if this works correctly there? https://jsfiddle.net/z4q7a2ko/ [18:58:32] 10VisualEditor, 10VisualEditor-MediaWiki-Plugins, 10Collaboration-Team-Triage, 10StructuredDiscussions, 10TechCom-RFC: Provide an inline discussion feature, "DiscussThis" - https://phabricator.wikimedia.org/T185607#3956371 (10Mattflaschen-WMF) [19:12:56] (03PS9) 10Jforrester: LinkContextItem: add a button to select the entire label [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [19:13:06] (03PS10) 10Jforrester: LinkContextItem: add a button to select the entire label [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [19:35:20] MatmaRex: I think at some point we should just raised what we declare Band A to be to Safari 7, given that's all we can test in… [19:36:03] perhaps [19:36:53] (03CR) 10Jforrester: [C: 032] ve.ui.MWWikitextSurface: Make 'textSelection' API chainable methods really chainable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/409111 (owner: 10Bartosz Dziewoński) [19:44:37] (03Merged) 10jenkins-bot: ve.ui.MWWikitextSurface: Make 'textSelection' API chainable methods really chainable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/409111 (owner: 10Bartosz Dziewoński) [19:49:41] (03CR) 10jenkins-bot: ve.ui.MWWikitextSurface: Make 'textSelection' API chainable methods really chainable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/409111 (owner: 10Bartosz Dziewoński) [20:20:27] (03CR) 10Jforrester: "This works for now. Testing the template data as well is pretty heavy-weight (fetching up to 20 TD blocks over the API and walking them), " [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/408344 (https://phabricator.wikimedia.org/T186276) (owner: 10Jforrester) [21:36:39] 10Citoid, 10VisualEditor, 10Wikimedia-Site-requests: Disallow adding Czech language tag (cs-CZ) into citation templates on cswiki - https://phabricator.wikimedia.org/T156548#3956855 (10Dvorapa) Well, the community of Czech Wikipedia users has chosen the option two, but please try to understand, that nobody f... [21:41:45] 10VisualEditor, 10MediaWiki-Page-deletion, 10MediaWiki-Page-editing, 10MediaWiki-Page-protection, and 2 others: Update web UI for increased comment length - https://phabricator.wikimedia.org/T185948#3956866 (10matmarex) This commit implements the "backend" part of the changes, and only updates the edit for... [23:49:27] (03CR) 10Jforrester: [C: 032] ve.ui.MWWikitextSurface: Implement textSelection 'replaceSelection', 'encapsulateSelection' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408466 (https://phabricator.wikimedia.org/T185917) (owner: 10Bartosz Dziewoński) [23:51:09] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Developer-notice, 10MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)): NWE: Provide API supporting majority of calls and integrations Gadgets make with wikitext editor - https://phabricator.wikimedia.org/T185992#3957052 (10Jdforreste... [23:58:34] (03Merged) 10jenkins-bot: ve.ui.MWWikitextSurface: Implement textSelection 'replaceSelection', 'encapsulateSelection' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408466 (https://phabricator.wikimedia.org/T185917) (owner: 10Bartosz Dziewoński)